D19606: [Task Manager] Reorganize and improve presentation of context menu

[Eike Hein]

hein added a comment.


  I'm concerned that having title labels on everything could be overdoing it a 
bit? It makes the context menu very large and have a lot of dead space, and 
adds to the noise. Isn't that rather a detriment to utility on repeated use? 
It's sometimes important to remember new users don't stay new users for very 
long, and first-time use isn't the only experience to optimize for.
  
  Also, I do get a lot of user reports every time the window title bar menu and 
the task context menu diverge. Personally I've never felt that they need to 
match because tasks aren't windpw title bars, but it's worth keeping in mind.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19096: Improvements for long label items in Application Dashboard

[Eike Hein]

hein added a comment.


  In D19096#427339 , @trmdi wrote:
  
  > In D19096#427329 , @hein wrote:
  >
  > > ... I'll need to set some time aside to analyze what you're trying to 
achieve there and propose an alternative.
  >
  >
  > I just want 2 things:
  >
  > 1. Display 2 lines for long labels.
  > 2. For labels need more than 2 lines -> display a tooltip that has the full 
label when hovering on it.
  >
  >   That's all, no matter how you do it. Basically, I don't want to add any 
new feature, just want to make the existed stuff usable. (Currently it's not 
usable while it's existing)
  >
  >   Thank you!
  
  
  Which is fine, I don't disagree with the goal :). Just that the particular 
implementation (the hover changes in the delegate) aren't a good way to do it.
  
  As for the comment after, sorry, I accidentally posted it in the wrong 
ticket, you can ignore that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18979: foldermodel: store information about screen used

[Eike Hein]

hein added a comment.


  Can you explain more what this is trying to achieve / what it solves with an 
example?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

To: McPain, broulik, hein, #plasma
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19647: [sddm-theme/lock screen] Use QQC2 instead of PlasmaComponents

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  dont-crop-the-clock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19647

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty updated this revision to Diff 53570.
rooty added a comment.


  Make Katie uppercase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19469?vs=53567=53570

BRANCH
  update-preview-image (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty updated this revision to Diff 53567.
rooty added a comment.


  Update preview to reflect latest theme version

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19469?vs=52955=53567

BRANCH
  update-preview-image (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53561.
rooty edited the summary of this revision.
rooty added a comment.


  Make the logout screen work too

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53557=53561

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/Logout.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Nathaniel Graham]

ngraham added a comment.


  Probably someone else should commandeer it and finish it up so we can get it 
in for 5.16. Do you wanna do that, @filipf or @rooty?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53557.
rooty added a comment.


  Apply theme.conf approach to all modifications

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53556=53557

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53555.
rooty added a comment.


  Use fixed font size for SDDM theme but not lock screen

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53518=53555

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53556.
rooty added a comment.


  Revert changes to UserDelegate.qml (empty line)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53555=53556

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml
  sddm-theme/theme.conf.cmake

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Björn Feber]

GB_2 added a comment.


  In D19472#427613 , @ngraham wrote:
  
  > In D19472#427046 , @broulik 
wrote:
  >
  > > This suffers from the same bug as the action in the D17410 
. The action doesn't show up unless the 
real applet context menu was opened once.
  >
  >
  > So I see. :(
  >
  > I guess we really gotta figure out how to call 
`plasmoid.contextualActionsAboutToShow();` before a different context menu 
appears.
  
  
  Yeah, I think @davidedmundson has it on his TODO list, I asked him at a 
monday meeting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: GB_2, abetts, broulik, rooty, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  Can confirm. theme.defaultFont.pointSize is indeed 9 pt.
  I've already got a hack in mind in case we can't make the sddm user's default 
font size 10 pt haha

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Filip Fila]

filipf added a comment.


  Something's odd. It's not that the +1 and the +2  code isn't working, but 
it's as if `theme.defaultFont.pointSize` is actually 9pt in SDDM.
  
  Lock screen:
  F6677937: Screenshot_20190309_175127.png 

  
  SDDM:
  F6677940: Screenshot_20190309_175200.png 

  
  You see that in the case of action buttons it's 10pt vs 11pt, and in the case 
of usernames it's 11pt vs 12pt.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  In D19631#427916 , @ngraham wrote:
  
  > In D19631#427911 , @rooty wrote:
  >
  > > In D19631#427905 , @ngraham 
wrote:
  > >
  > > > I don't think we should use hardcoded font sizes in either place. Maybe 
what we should do is have both of them use `font.pointSize: 
theme.defaultFont.pointSize + 1` (etc.).
  > >
  > >
  > > Yes that was the idea in D19547 , but 
we can't because sddm doesn't recognize theme.defaultFont.pointSize.
  >
  >
  > Hmm, why not? Wouldn't the SDDM user just have its own value for that?
  
  
  I have no idea. It should.
  It's not just the sddm user - "sudo sddm-greeter" doesn't either. I'm stumped.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Nathaniel Graham]

ngraham added a comment.


  In D19631#427911 , @rooty wrote:
  
  > In D19631#427905 , @ngraham 
wrote:
  >
  > > I don't think we should use hardcoded font sizes in either place. Maybe 
what we should do is have both of them use `font.pointSize: 
theme.defaultFont.pointSize + 1` (etc.).
  >
  >
  > Yes that was the idea in D19547 , but 
we can't because sddm doesn't recognize theme.defaultFont.pointSize.
  
  
  Hmm, why not? Wouldn't the SDDM user just have its own value for that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  In D19631#427905 , @ngraham wrote:
  
  > I don't think we should use hardcoded font sizes in either place. Maybe 
what we should do is have both of them use `font.pointSize: 
theme.defaultFont.pointSize + 1` (etc.).
  
  
  Yes that was the idea in D19547 , but we 
can't because sddm doesn't recognize theme.defaultFont.pointSize.
  So the point of this patch was to hardcode them in the sddm theme and let the 
lock screen do its own thing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

[Nathaniel Graham]

ngraham added a comment.


  I don't think we should use hardcoded font sizes in either place. Maybe what 
we should do is have both of them use `font.pointSize: 
theme.defaultFont.pointSize + 1` (etc.). That way they will both use the same 
font sizes unless the user changes that. There will be some inconsistency if 
the user does change the font size, but that's unavoidable right now. And even 
if we hardcode sizes for both of them, we'd never be able to match the actual 
font itself in the case that the user changes it. It's currently an unsolvable 
problem.
  
  Long term, what I would like to do is that when there is only a single user 
on the system, SDDM automatically reads font, cursor, and theme information 
from the user's account. For security, maybe the way this is implemented is 
that when that user makes any changes to those settings, they get copied into 
the SDDM user's home directory rather than SDDM reading from the user's home 
directory. This behavior should be user-configurable and able to be turned off, 
and automatically turn itself (with no ability to turn it back on) off when 
there is more than one user on the system.
  
  Otherwise there will //always// be a measure of inconsistency between the 
lock and login screens.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Filip Fila]

filipf added a comment.


  I liked this patch, how come you abandoned it @trmdi ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19036: [notifications] Lift up notification content if one line of body text droops

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:23f3345a2287: [notifications] Lift up notification 
content if one line of body text droops (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19036?vs=53523=53525

REVISION DETAIL
  https://phabricator.kde.org/D19036

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: rooty, #plasma, #vdg, broulik, ngraham, filipf
Cc: cfeck, anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19036: [notifications] Lift up notification content if one line of body text droops

[Krešimir Čohar]

rooty updated this revision to Diff 53523.
rooty added a comment.


  Rebase if needed

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19036?vs=52409=53523

BRANCH
  arcpatch-D19036

REVISION DETAIL
  https://phabricator.kde.org/D19036

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: rooty, #plasma, #vdg, broulik, ngraham, filipf
Cc: cfeck, anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2003b267d4bc: Image Wallpaper Slideshow - display the 
list of images that will be shown (authored by davidre, committed by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18809?vs=53512=53524#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=53512=53524

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg, ngraham, davidedmundson
Cc: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19036: [notifications] Lift up notification content if one line of body text droops

[Filip Fila]

filipf added a comment.


  In D19036#427849 , @rooty wrote:
  
  > In D19036#427845 , @cfeck wrote:
  >
  > > The status of this says 'Accepted', so developers might not check it.
  > >
  > > If you want to wait for a developer's review, I suggest to keep the 
status 'Needs Review'.
  >
  >
  > I could also land it though? :D
  
  
  I'm under the impression that if people had anything more to add they already 
would have done so. 5.15.3 comes out on Tuesday so it would be good to get it 
in by then.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19036

REVISION DETAIL
  https://phabricator.kde.org/D19036

To: rooty, #plasma, #vdg, broulik, ngraham, filipf
Cc: cfeck, anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

KDE Review passes

[Jonathan Riddell]

Welcome the following projects which passed kdereview process

plasma-simplemenu now in selfrelease/extra and released on store.kde.org
pulseaudio-qt now in selfrelease/extra and released on download.kde.org
rust-qt-binding-generator now in selfrelease/extra
plasma-redshift-control now in selfrelease/extra

We really do need to sort out the terminology for
extragear/extra/self-released things.

Jontahan

D18979: foldermodel: store information about screen used

[Christoph Feck]

cfeck added a comment.


  Could a Plasma developer please review?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

To: McPain, broulik, sebas, hein
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19036: [notifications] Lift up notification content if one line of body text droops

[Krešimir Čohar]

rooty added a comment.


  In D19036#427845 , @cfeck wrote:
  
  > The status of this says 'Accepted', so developers might not check it.
  >
  > If you want to wait for a developer's review, I suggest to keep the status 
'Needs Review'.
  
  
  I could also land it though? :D

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19036

REVISION DETAIL
  https://phabricator.kde.org/D19036

To: rooty, #plasma, #vdg, broulik, ngraham, filipf
Cc: cfeck, anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  Can anyone please help - how do I tell Main.qml to set the integer 
"nameFontSize" to 12 pt? My knowledge here is very limited and nothing I've 
tried has worked :/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Welcome Latte Dock to KDE

[Jonathan Riddell]

Latte is a dock based on plasma frameworks that provides an elegant
and intuitive experience for your tasks and plasmoids. It animates its
contents by using parabolic zoom effect and tries to be there only
when it is needed.

It's been part of KDE for a while but the incubation process stalled.
With the creation of a new home wiki page
https://community.kde.org/LatteDock and User wiki page
https://userbase.kde.org/LatteDock/ I've been able to set the
incubation to green.

Jonathan

D19036: [notifications] Lift up notification content if one line of body text droops

[Christoph Feck]

cfeck added a comment.


  The status of this says 'Accepted', so developers might not check it.
  
  If you want to wait for a developer's review, I suggest to keep the status 
'Needs Review'.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19036

REVISION DETAIL
  https://phabricator.kde.org/D19036

To: rooty, #plasma, #vdg, broulik, ngraham, filipf
Cc: cfeck, anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty updated this revision to Diff 53518.
rooty edited the summary of this revision.
rooty added a comment.


  (WIP) Switch back to the default theme font + 1 (or 2) for the lock screen

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19631?vs=53498=53518

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/components/UserList.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  lookandfeel/contents/logout/LogoutButton.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 53512.
davidre added a comment.


  const 

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=52797=53512

BRANCH
  arcpatch-D18809_2

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg, ngraham, davidedmundson
Cc: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  > What hardcoding font sizes gives us are 2 places in Plasma losing their 
flexibility and not taking the user's preferences into consideration = SDDM-ing 
it.
  
  Then the solution is obvious - we should make the sddm theme (SDDM itself) 
more customizable (theme.conf?).
  
  > The core reason isn't strong enough either, especially given that SDDM is 
not a pre-requisite for using Plasma.
  
  What do you mean? I never said it was.
  
  > Frankly I'd rather have inconsistency than hardcoded font sizes in Plasma.
  
  I would rather not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf added a comment.


  In D19631#427731 , @rooty wrote:
  
  > In D19631#427726 , @filipf wrote:
  >
  > > There has to be a better solution. We're dragging the quality of Plasma 
down simply because SDDM isn't on par with it. If there's no other way, 
hardcoded font sizes should only be present in SDDM.
  >
  >
  > I'm actually not really sure about this being a bad solution
  >  Hardcoding font sizes gives us total control over our environment, which 
might not be a bad thing in the long run (in case we want to hard-code settings 
that point to a .conf file, for greater versatility).
  
  
  What hardcoding font sizes gives us are 2 places in Plasma losing their 
flexibility and not taking the user's preferences into consideration = SDDM-ing 
it. The core reason isn't strong enough either, especially given that SDDM is 
not a pre-requisite for using Plasma.
  
  > As far as the lock screen goes, if you separate the SDDM font sizes from 
the lock screen font sizes, there's a glaring inconsistency between them.
  
  Frankly I'd rather have inconsistency than hardcoded font sizes in Plasma.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty added a comment.


  In D19631#427726 , @filipf wrote:
  
  > There has to be a better solution. We're dragging the quality of Plasma 
down simply because SDDM isn't on par with it. If there's no other way, 
hardcoded font sizes should only be present in SDDM.
  
  
  I'm actually not really sure about this being a bad solution.
  Hardcoding font sizes gives us total control over our environment, which 
might not be a bad thing in the long run (in case we want to hard-code settings 
that point to a .conf file, for greater versatility).
  As far as the lock screen goes, if you separate the SDDM font sizes from the 
lock screen font sizes, there's a glaring inconsistency between them.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty added a subscriber: davidedmundson.
rooty added a comment.


  @davidedmundson thoughts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf requested changes to this revision.
filipf added a comment.
This revision now requires changes to proceed.


  There has to be a better solution. We're dragging the quality of Plasma down 
simply because SDDM isn't on par with it. If there's no other way, hardcoded 
font sizes should only be present in SDDM.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19465: Port to ECM's component/imported target based FindXCB

[Rik Mills]

rikmills added a comment.


  Results in cmake configure build failure on Neon
  
  
https://build.neon.kde.org/job/bionic_unstable_kde_plasma-desktop_bin_amd64/292/consoleFull

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19465

To: vkrause, apol
Cc: rikmills, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  revert-more (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19631

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MainBlock.qml
  lookandfeel/contents/lockscreen/MediaControls.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/SessionButton.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart