D19874: Reduce the margins of KickoffItem

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  A lot of space on the left and right of each KickoffItem was wasted, so I've 
reduced the margins. This also improves the readability of long application 
titles and descriptions.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  KickoffItem-margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19874

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffItem.qml

To: ndavis, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Noah Davis]

ndavis added a comment.


  In D19694#434169 , @ngraham wrote:
  
  > I was talking about the problem of small monochrome icons in the sidebar 
itself, not in the tooltip. But anyway since then I fixed the tooltip too.
  >
  > Any more #VDG  or #plasma 
 opinions on this?
  
  
  I was talking about the sidebar as well, but I think I misunderstood what you 
were saying.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Nathaniel Graham]

ngraham added a comment.


  I was talking about the problem of small monochrome icons in the sidebar 
itself, not in the tooltip. But anyway since then I fixed the tooltip too.
  
  Any more #VDG  or #plasma 
 opinions on this?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10091: Combine source and version into a single piece of metadata

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Nah.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10091

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  The spacing change is clearly correct. As for the width change, we should 
match the exact calculation used for the other combobox we're trying to match, 
which is `width: theme.mSize(theme.defaultFont).width * 24`. Otherwise they'll 
drift out of sync when `formAlignment` changes or the next time 
`Kirigami.Units.largeSpacing` is modified.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf added a comment.


  I think I'm still off by a pixel, will test better tomorrow.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Master currently has bad horizontal alignment of the "Positioning:" row since 
it's not a part of the FormLayout as everything else.
  This patch tweak the values a bit so it's at least horizontally aligned.
  
  NOTE: Vertical spacing is still clearly wrong, but I could fix that as well 
if someone could offer a suggestion on how to do it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  OMG I love this one! +1000 shipit!

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  add-elarun (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19872

To: filipf, ngraham, #vdg, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18934: [Notifications] Port the close ToolButton to RoundButton

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Abandoning due to the impending overhaul of notifications.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18934

To: filipf, ngraham, #vdg, rooty, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19802: [comic] Modernize configuration windows

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filipf wrote in configAdvanced.qml:55
> It's always the plural now, but I also realized we shouldn't be using 
> singular if value is 1 because some Slavic languages use singular with 21, 
> 31, etc.

Yep, even if the quantity will always be more than one, it should always use an 
`i18np()`. for just that reason. :)

> configGeneral.qml:112
> +Layouts.RowLayout {
> +Kirigami.FormData.label: i18nc("@label:spinbox", "Check for new 
> comic strips every:")
> +

"comic strips" -> "comics"

> configGeneral.qml:121
> +Controls.Label {
> +text: i18ncp("@item:valuesuffix spacing to number + unit 
> (minutes)", "min", "mins")
> +}

"Mins" -> "Minutes" (etc)

> ngraham wrote in configGeneral.qml:97
> I'd recommend putting these in the FormLayout rather than using a RowLayout, 
> since now the spinboxes aren't aligned anymore.

You could shorten this very long string by writing it as "Check for new plugins 
every:"

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19802

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Elarun is an  iconic and beautiful KDE wallpaper that only takes up 1.4 MiB 
of disk space and as such would make a fine addition to
  our collection.

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  add-elarun (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19872

AFFECTED FILES
  CMakeLists.txt
  Elarun/contents/images/2560x1600.png
  Elarun/contents/screenshot.jpg
  Elarun/metadata.desktop

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma distro-specific installation path?

[Ongun Kanat]

There's an utility called kf5-config which prints several paths. It
might work for your purposes too.
-Ongun


On Sat, 16 Mar 2019 at 11:49, Michail Vourlakos  wrote:
>
> Hello,
>
> one question please: Is there any way to know from Qt/KDE frameworks side in 
> which global installation path Plasma was installed?
>
> e.g. in Tumbleweed that is "/usr/share/plasma"
>
> but other distros there is a chance that use something different
>
>
> regards,
> michail
>
> Latte Dev Team

D19855: Fix bugzilla login page widgets tab order

[Christoph Feck]

cfeck added a comment.


  QLineEdit has Qt::StrongFocus policy and it is the focus proxy of 
KPasswordLineEdit. My impression was that KPasswordLineEdit then automatically 
also had Qt::StrongFocus.
  
  Appearantly, the policy is propagated in the other direction, so a correct 
fix would be to change the focus policy in kwidgetsaddons, see 
https://cgit.kde.org/kwidgetsaddons.git/tree/src/kpasswordlineedit.cpp#n88
  
  Testing would need to confirm that this doesn't open password dialogs with 
the password line focussed by default.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19855

To: marcelomariano, patrickelectric, sitter, cfeck, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18934: [Notifications] Port the close ToolButton to RoundButton

[Filip Fila]

filipf updated this revision to Diff 54262.
filipf added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18934?vs=54259=54262

BRANCH
  arcpatch-D18934

REVISION DETAIL
  https://phabricator.kde.org/D18934

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: filipf, ngraham, #vdg, rooty, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty added inline comments.

INLINE COMMENTS

> rooty wrote in powerdevilcore.cpp:330
> Hmm sure

Actually you're right, without "the profile" and "it" it sounds fancier haha

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:22d725ca0361: [powerdevil] Touch up messages/prompts 
(authored by rooty).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54260=54261

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Krešimir Čohar]

rooty updated this revision to Diff 54260.
rooty added a comment.


  "or because"

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19838?vs=54168=54260

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18934: [Notifications] Port the close ToolButton to RoundButton

[Filip Fila]

filipf updated this revision to Diff 54259.
filipf added a comment.


  fix dumb value

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18934?vs=54258=54259

BRANCH
  arcpatch-D18934

REVISION DETAIL
  https://phabricator.kde.org/D18934

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: filipf, ngraham, #vdg, rooty, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

[Filip Fila]

filipf added a comment.


  Alright so I'd like to give RoundButton another chance. Its advantage is that 
the frame is considerably smaller.
  
  The control seems a bit weird though, it needs implicitWidth and an embedded 
icon class to work properly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18934

To: filipf, ngraham, #vdg, rooty, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

[Filip Fila]

filipf updated this revision to Diff 54258.
filipf added a comment.


  Try using RoundButton

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18934?vs=51444=54258

BRANCH
  arcpatch-D18934

REVISION DETAIL
  https://phabricator.kde.org/D18934

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: filipf, ngraham, #vdg, rooty, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19865: Linux softraid: Define _GNU_SOURCE for pipe2

[A. Wilcox]

awilcox created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
awilcox requested review of this revision.

REVISION SUMMARY
  In a strict POSIX compilation environment, pipe2 is not defined.  Use the 
_GNU_SOURCE FTM to expose it.
  
  Fixes a failure to build ksysguard on Adélie Linux.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D19865

AFFECTED FILES
  ksysguardd/Linux/softraid.c

To: awilcox
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19802: [comic] Modernize configuration windows

[Filip Fila]

filipf marked 7 inline comments as done.
filipf added inline comments.

INLINE COMMENTS

> ngraham wrote in configAdvanced.qml:55
> The way you do this properly is as follows, with `i18ncp()`:
> 
>   text: i18ncp("@item:valuesuffix spacing to number + unit", " strip per 
> comic", "strips per comic")

It's always the plural now, but I also realized we shouldn't be using singular 
if value is 1 because some Slavic languages use singular with 21, 31, etc.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19802

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D19802: [comic] Modernize configuration windows

[Filip Fila]

filipf updated this revision to Diff 54254.
filipf added a comment.


  avoid using headings, fix spinbox strings

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19802?vs=54001=54254

BRANCH
  modernized-comic-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19802

AFFECTED FILES
  applets/comic/package/contents/config/config.qml
  applets/comic/package/contents/ui/configAdvanced.qml
  applets/comic/package/contents/ui/configAppearance.qml
  applets/comic/package/contents/ui/configGeneral.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D19863: [Host] Add Message.sh

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: ltoscano.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Noticed it was still untranslated, found there's no `Message.sh`

TEST PLAN
  None. 5.15 since it only makes stuff translatable

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D19863

AFFECTED FILES
  host/CMakeLists.txt
  host/Messages.sh

To: broulik, ltoscano
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19855: Fix bugzilla login page widgets tab order

[Harald Sitter]

sitter added a comment.


  While that fixes the drkonqi bug just fine I am not sure that is the best fix 
for the problem. As I understand it KPasswordLineEdit doesn't set itself to 
StrongFocus, seeing as it is a replacement for QLineEdit that seems 
inconsistent and should be rectified though. IOW: I think KPasswordLineEdit 
should be changed to set a StrongFocus by default, same as QLineEdit.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19855

To: marcelomariano, patrickelectric, sitter, cfeck, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19851: [kirigami] make it compile without foreach

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> apol wrote in kirigamiplugin.cpp:48
> qAsConst isn't necessary because the method is already const.
> Is it just for readability?

Yep just for readability. It's just for avoiding that we thing it will detach.
For sure here it will not detach.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19851

To: mlaurent, dfaure
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19857: [DownloadJob] Report total size only if known

[Bhushan Shah]

bshah added a comment.


  Other download managers show the downloaded amount as total amount, so it is 
e.g 25 MiB out of 25 MiB.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D19857

To: broulik, #plasma
Cc: bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19800: [Application Dashboard] Improve mouse handler

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0ecb1359eaca: [Application Dashboard] Improve mouse 
handler (authored by trmdi, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19800?vs=54052=54240

REVISION DETAIL
  https://phabricator.kde.org/D19800

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: trmdi, hein, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic updated this revision to Diff 54239.
kdautovic added a comment.


  Removed the use of goto.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19852?vs=54237=54239

REVISION DETAIL
  https://phabricator.kde.org/D19852

AFFECTED FILES
  klipper/klipper.cpp

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic updated this revision to Diff 54237.
kdautovic added a comment.


  Remove the image filter which stopped copying images to clipboard.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19852?vs=54222=54237

REVISION DETAIL
  https://phabricator.kde.org/D19852

AFFECTED FILES
  klipper/klipper.cpp

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic added a comment.


  You mean line 739?
  
else if( data->hasImage() )
{
if( m_bIgnoreImages )
return;
}

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19857: [DownloadJob] Report total size only if known

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In case the download size isn't known, the browser reports `-1`

TEST PLAN
  It now shows "xyz MiB of 0 B" so we don't handle that in notifications but 
it's better than -1 B
  Or should I explicitly `setTotalAmount(0)` in this case?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D19857

AFFECTED FILES
  host/downloadjob.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Nathaniel Graham]

ngraham added reviewers: mart, hein.
ngraham added a comment.


  A few more days of waiting may be required since most of the Plasma 
developers are quite busy right now. But it will get reviewed, don't worry!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19788: [service runner] throw out kde3 "compat" code

[Björn Feber]

GB_2 added a comment.


  GTK+ was recently renamed to GTK 
(https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg0.html).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19788

To: sitter, broulik
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[David Edmundson]

davidedmundson added a comment.


  We don't use goto.
  
  Whilst I think doing this makes sense, it's not the complete solution you've 
not got this far as we filter out the images on line 753 which is run before 
this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19800: [Application Dashboard] Improve mouse handler

[Nathaniel Graham]

ngraham added a comment.


  Land on the `Plasma/5.15` stable branch please: 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
  
  If you need a hand with that, let me know. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-390424 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19800

To: trmdi, hein, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19800: [Application Dashboard] Improve mouse handler

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yep, I can no longer reproduce the issue under any circumstances. Thanks a 
lot for fixing this!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-390424 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19800

To: trmdi, hein, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19826: kns: Show subcategories for things that have one

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:3dfd7cbc8e4b: kns: Show subcategories for things that 
have one (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19826?vs=54219=54227

REVISION DETAIL
  https://phabricator.kde.org/D19826

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: apol, #discover_software_store, leinir
Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19851: [kirigami] make it compile without foreach

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kirigamiplugin.cpp:48
>  {
> -foreach (const QString , m_stylesFallbackChain) {
> +for (const QString  : qAsConst(m_stylesFallbackChain)) {
>  const QString candidate = QStringLiteral("styles/") + style + 
> QLatin1Char('/') + fileName;

qAsConst isn't necessary because the method is already const.
Is it just for readability?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19851

To: mlaurent, dfaure
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19855: Fix bugzilla login page widgets tab order

[Marcelo Mariano]

marcelomariano created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
marcelomariano requested review of this revision.

REVISION SUMMARY
  BUG: 398275

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19855

AFFECTED FILES
  src/bugzillaintegration/ui/assistantpage_bugzilla_login.ui

To: marcelomariano
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic updated this revision to Diff 54222.
kdautovic added a comment.


  Added a special case for not saving history when the data is an image and 
m_bIgnoreImages is set. This allows copying images to clipboard, and keeping 
the current default behavior of Klipper to not save images in history when 
m_bIgnoreImages is set.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19852?vs=54210=54222

REVISION DETAIL
  https://phabricator.kde.org/D19852

AFFECTED FILES
  klipper/klipper.cpp

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19826: kns: Show subcategories for things that have one

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Nifty :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  arcpatch-D19826_1

REVISION DETAIL
  https://phabricator.kde.org/D19826

To: apol, #discover_software_store, leinir
Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19826: kns: Show subcategories for things that have one

[Aleix Pol Gonzalez]

apol updated this revision to Diff 54219.
apol added a comment.


  Rebase and test with opendesktop apps

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19826?vs=54085=54219

BRANCH
  arcpatch-D19826_1

REVISION DETAIL
  https://phabricator.kde.org/D19826

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: apol, #discover_software_store, leinir
Cc: leinir, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[David Edmundson]

davidedmundson added a comment.


  It means only spectacle fills memory, not doing work in gimp.
  
  The issue is that spectacle closes, but we need klipper to copy the image in 
advance as it doesn't know that spectacle is about to close. It's unique to 
this situation.
  
  > Your approach is just going to give the data a different MIME type.
  
  Additional mime hint, not a different mime type.
  
  But you're right my idea could be expanded upon to only keep the image when 
it's the top of the stack, that would work nicely.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic added a comment.


  The problem I see with that is that memory usage wasn't solved. Regardless of 
whether we use my approach or your approach, they're going to use the same 
amount of memory if people copy screenshots to clipboard. Your approach is just 
going to give the data a different MIME type.
  
  This way, all image handling applications get the same behavior.
  
  With all of this in mind, perhaps the best solution would be to never save 
images in history, so that once something else is copied, the image is 
forgotten.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19852: Change default Klipper behavior to accept images

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  You're just going to burn through memory like crazy. We can't do this.
  It also doesn't properly fix the klipper issue as it then breaks for anyone 
who has changed the setting.
  
  There is a proposal by me last time this came up:
  https://phabricator.kde.org/D9117#202448

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19837: Add support for applications in KNSBackend

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:ffc6023c5412: Add support for applications in KNSBackend 
(authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19837?vs=54204=54213

REVISION DETAIL
  https://phabricator.kde.org/D19837

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp
  libdiscover/backends/KNSBackend/KNSBackend.h

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic created this revision.
kdautovic added a reviewer: Plasma: Workspaces.
kdautovic added a project: Plasma: Workspaces.
Herald edited projects, added Plasma; removed Plasma: Workspaces.
Herald added a subscriber: plasma-devel.
kdautovic requested review of this revision.

REVISION SUMMARY
  Change the default Klipper behavior in order for 
https://phabricator.kde.org/D19715 to work.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

AFFECTED FILES
  klipper/klipper.kcfg

To: kdautovic, #plasma_workspaces
Cc: plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19851: [kirigami] make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R169 Kirigami

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19851

AFFECTED FILES
  CMakeLists.txt
  src/kirigamiplugin.cpp

To: mlaurent, dfaure
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19837: Add support for applications in KNSBackend

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 54204.
leinir marked 2 inline comments as done.
leinir added a comment.


  Address various comments, and also fix one issue discovered while addressing 
those

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19837?vs=54110=54204

REVISION DETAIL
  https://phabricator.kde.org/D19837

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp
  libdiscover/backends/KNSBackend/KNSBackend.h

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19837: Add support for applications in KNSBackend

[Dan Leinir Turthra Jensen]

leinir marked 4 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in KNSBackend.cpp:151
> we can just compare with == here, it will be easier to read.

Tru dat... i was just keeping consistency with the long list below, but yeah, 
at the very least for now we've just got the one source, and can always add a 
check like this if we find we have more app sources later on :)

> apol wrote in KNSBackend.cpp:159
> I wonder if that's alright, it's very ad-hoc to the opendesktop semantics, 
> isn't it?

This is pretty much just mapping the current machine's abilities to run certain 
types of binaries to what is offered by opendesktop, yes. I am quite unsure as 
to how to implement this in some other way. In particular, we need to be able 
to make sure that on x86_64 we get both x86 and x86_64 packages, so we can't 
just send along the result verbatim and ask opendesktop to return what Qt 
returns (given we have to produce a mapping anyway)...

> apol wrote in KNSBackend.cpp:186
> decoration isn't used anymore, it could make sense to not include it at all 
> over here.

Good idea :) This is just code moved down a bit, but i'll just pop that in here 
as well while we're at it :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19837

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19788: [service runner] throw out kde3 "compat" code

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1f3ab6f7dddb: [service runner] throw out kde3 
compat code (authored by sitter).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19788?vs=53960=54185

REVISION DETAIL
  https://phabricator.kde.org/D19788

AFFECTED FILES
  runners/services/servicerunner.cpp

To: sitter, broulik
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19837: Add support for applications in KNSBackend

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> KNSBackend.cpp:151
>  
> -const auto topLevelName = knsrcPlasma.contains(fileName)? i18n("Plasma 
> Addons") : i18n("Application Addons");
> -const QUrl decoration(knsrcPlasma.contains(fileName)? 
> QStringLiteral("https://c2.staticflickr.com/4/3148/3042248532_20bd2e38f4_b.jpg;)
>  : 
> QStringLiteral("https://c2.staticflickr.com/8/7067/6847903539_d9324dcd19_o.jpg;));
> -auto addonsCategory = new Category(topLevelName, 
> QStringLiteral("plasma"), filters, backendName, {actualCategory}, decoration, 
> true);
> -m_rootCategories = { addonsCategory };
> +if(knsrcApplications.contains(fileName)) {
> +m_hasApplications = true;

we can just compare with == here, it will be easier to read.

> KNSBackend.cpp:159
> +QStringList tagFilter = m_engine->tagFilter();
> +if(QSysInfo::currentCpuArchitecture() == QLatin1String("arm")) {
> +tagFilter << QLatin1String("application##architecture=armhf");

I wonder if that's alright, it's very ad-hoc to the opendesktop semantics, 
isn't it?

> KNSBackend.cpp:186
> +const auto topLevelName = knsrcPlasma.contains(fileName)? 
> i18n("Plasma Addons") : i18n("Application Addons");
> +const QUrl decoration(knsrcPlasma.contains(fileName)? 
> QStringLiteral("https://c2.staticflickr.com/4/3148/3042248532_20bd2e38f4_b.jpg;)
>  : 
> QStringLiteral("https://c2.staticflickr.com/8/7067/6847903539_d9324dcd19_o.jpg;));
> +auto addonsCategory = new Category(topLevelName, 
> QStringLiteral("plasma"), filters, backendName, {actualCategory}, decoration, 
> true);

decoration isn't used anymore, it could make sense to not include it at all 
over here.

> KNSBackend.cpp:242
>  {
> +
>  KNSResource* r = 
> static_cast(m_resourcesByName.value(entry.uniqueId()));

Unrelated change.

> KNSBackend.cpp:469
> +for(const QString& category : m_categories) {
> +if(m_hasApplications || 
> filter.category->matchesCategoryName(category)) {
> +auto r = new 
> ResultsStream(QStringLiteral("KNS-search-")+name());

Just use contains?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19837

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19837: Add support for applications in KNSBackend

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D19837#433343 , @ngraham wrote:
  
  > Can you edit the test plan to indicate the name of an app from the store 
that now appears in Discover's Applications section? A quick test of this patch 
didn't reveal ExeQt or Treeline in Discover, which are visible on 
http://opendesktop.org.
  
  
  Applications will show up if a knsrc which provides them (specifically 
storekdeapps.knsrc) is installed... I did in fact ponder whether it would make 
sense for us to ship said knsrc file with Discover, but also am unsure if that 
is the right place for it...

INLINE COMMENTS

> ngraham wrote in KNSBackend.cpp:125
> Is this intentional? Don't we want to initialize it right after creating it?

It is intentional, and ensures that just on the wild offchance we get any error 
signals during that initialisation are caught. It would be sufficient to put 
this after the signalErrorCode connect statement, but it just seems reasonable 
and pleasant to have those connect statements together :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19837

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  Hello,
  
  Any progress on this one? Does it usually take long to review?
  
  Sorry for impatience.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19838: [powerdevil] Touch up messages/prompts

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Awesome. Go ahead and make your proposed change if you'd like, then shipit!

INLINE COMMENTS

> rooty wrote in powerdevilcore.cpp:367
> "or because the action is not supported", "This is due to the action not 
> being supported" sounds too elaborate for my taste and I'd rather have a 
> disconnected clause here

That was actually going to be my first suggestion. :) Go ahead and do that if 
you think it sounds better.

> rooty wrote in powerdevilcore.cpp:541
> I thought about that, then realized that the heading says "Mouse" (Mouse 
> Battery Low)  "Keyboard" etc. so it seems redundant too (to repeat it in the 
> body text)

Ah, you're right!

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19838

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt updated this revision to Diff 54176.
fvogt added a comment.


  One more file.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19821?vs=54143=54176

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/widgets/tooltip.svgz
  src/desktoptheme/breeze/widgets/tooltip.svgz

To: fvogt, #plasma
Cc: falqueto, rooty, Zren, arojas, rikmills, asturmlechner, 
kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  There's a special case in `./src/desktoptheme/breeze/icons/audio.svgz` and 
`.../battery.svgz`: It has color scheme definitions both in a