D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Alexander Kernozhitsky]

gepardo added a comment.


  Nice :)
  
  I have some suggestions to prevent such errors in the future:
  
  - `sass` (but not `sassc`) has `-E` option to set the encoding for building
  - it may be a good idea to add such lines to all the SCSS files
  
  BTW, where does the build error happen?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf added a comment.


  In D19873#434949 , @mart wrote:
  
  > So,
  >  FormLayout has api to align two or more of them with each other, which is 
the list property FormLayout.twinFormLayouts
  >
  > I wonder if there is a way to make the parent and child formlayouts visible 
ot each other to use such property.
  >
  > the parent is in 
plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml,
 loading the individual wallpapers config in the stackview at line 162.
  >
  > so, we could try something like:
  >  the wallpaper configs will expose a formLayout property.
  >  the main formLayout has something like
  >  twinFormLayouts: stack.item && stack.item.formLayout ? 
[stack.item.formLayout] : []
  >
  > then the parent layout may be i guess injected at instantiation as a 
property of the wallpaper plugin, so the child formlayout can set 
twinformlayouts as well
  >
  > this is all untested, so is a bit of R project, but if you would like to 
give a try it may be finally the properfix(tm)
  
  
  This works!!! Thank you :D
  
  For tonight I can only offer a sneak peak: the port for this "Positioning:" 
row, as well as the groundwork in D19932 . 
But if the code is right we could port all of the wallpaper plugins pretty fast.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Filip Fila]

filipf updated this revision to Diff 54460.
filipf added a comment.


  Initial implementation of twinFormLayouts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54288=54460

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch does the groundwork for indvidual wallpaper plugins to be able to 
use Kirigami FormLayout with twinFormLayouts,
  finally allowing us to easily ensure that both the main and child layout are 
aligned without hacks.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  support-twinLayouts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19932

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19931

AFFECTED FILES
  src/gtk318/widgets/_notebook.scss
  src/gtk320/widgets/_treeview.scss

To: luc4
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

[Kai Uwe Broulik]

broulik added a comment.


  +1
  Nice and clean, no real complaints.

INLINE COMMENTS

> kworkspace.cpp:70
>  
> +void requestShutDown(KWorkSpace::ShutdownConfirm, KWorkSpace::ShutdownType, 
> KWorkSpace::ShutdownMode)
> +{

:)

> sessionmanagement.cpp:32
> +
> +// add a constructor with the servica names and paths pre-populated
> +class LogoutPromptIface : public OrgKdeLogoutPromptInterface {

*service

> sessionmanagement.cpp:95
> +{
> +return KAuthorized::authorizeAction(QStringLiteral("start_new_session"));
> +}

The old one also checked KDM or whatever for "free ttys", is that still a thing?

> sessionmanagementbackend.cpp:46
> +s_backend = new LogindSessionBackend();
> +} else if (ConsoleKitSessionBackend::exists() ){
> +s_backend = new ConsoleKitSessionBackend();

Coding style

> sessionmanagementbackend.cpp:51
> +}
> +Q_ASSERT(s_backend);
> +

Can this even be hit?

> sessionmanagementbackend.cpp:84
> +} else {
> +// DECISION FIXME, do we want to show the option in the menu if 
> the response is "challenge"?
> +*argToUpdate = reply.value() == QLatin1String("yes")  ? true : 
> false;

I would say yes. If one wants to hide from UI they can use KIOSK? 
Docs perhaps need updating that Polkit is obviously prefered since kiosk is 
mostly UI and not real security

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19389

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19890: Changes the drawing of QToolButton inline indicator arrows

[Nathaniel Graham]

ngraham added a comment.


  Thanks very much for this patch! I will review sometime in the next 48 hours.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 172 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/172/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 20 Mar 2019 10:05:31 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 14 test(s), Passed: 94 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDebugConsoleFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testInternalWindowFailed: projectroot.autotests.integration.kwin_testInternalWindow_waylandonlyFailed: projectroot.autotests.integration.kwin_testLockScreenFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testShellClientFailed: projectroot.autotests.integration.kwin_testShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 3 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucency

D19802: [comic] Modernize configuration windows

[Andres Betts]

abetts added a comment.


  > You mean "General", "Appearance" etc. right? Yeah that happens when windows 
are stretched horizontally, but the window wouldn't be much narrower IRL tbh. 
Kirigami's FormLayout is center aligned and the category's title always remains 
left aligned. They're pretty far apart in full-screen:
  > 
  > F6704320: image.png 
  
  Awesome! Thank you, just wanted to be sure. +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19802

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: abetts, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19802: [comic] Modernize configuration windows

[Filip Fila]

filipf added a comment.


  In D19802#435421 , @abetts wrote:
  
  > The title labels appear to be very far from the content. Is that just the 
size on the images or does it actually look very far when the config screen is 
full size?
  
  
  You mean "General", "Appearance" etc. right? Yeah that happens when windows 
are stretched horizontally, but the window wouldn't be much narrower IRL tbh. 
Kirigami's FormLayout is center aligned and the category's title always remains 
left aligned. They're pretty far apart in full-screen:
  
  F6704320: image.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19802

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: abetts, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19802: [comic] Modernize configuration windows

[Andres Betts]

abetts added a comment.


  The title labels appear to be very far from the content. Is that just the 
size on the images or does it actually look very far when the config screen is 
full size?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19802

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: abetts, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19802: [comic] Modernize configuration windows

[Filip Fila]

filipf updated this revision to Diff 54453.
filipf marked an inline comment as done.
filipf added a comment.


  Change strings according to Nate's suggestions

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19802?vs=54254=54453

BRANCH
  modernized-comic-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19802

AFFECTED FILES
  applets/comic/package/contents/config/config.qml
  applets/comic/package/contents/ui/configAdvanced.qml
  applets/comic/package/contents/ui/configAppearance.qml
  applets/comic/package/contents/ui/configGeneral.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D19857: [DownloadJob] Report total size only if known

[Kai Uwe Broulik]

broulik added a comment.


  It should just hide the total if unknown but that's an issue in the 
notification view

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D19857

To: broulik, #plasma
Cc: bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D19748#434289 , @kossebau wrote:
  
  > In D19748#432027 , @broulik 
wrote:
  >
  > > F6696238: Screenshot_20190316_121442.png 

  > >  Seems it does break things here (both with and without Qt scaling :/)
  >
  
  
  I could reproduce this now by accident while juggling with my patches. Turns 
out this is another case where D19743  will 
fix things, as this ensures the correct current margins are used.
  So would be great if someone could have a look at that one. And also means, 
this patch here is then only Plasma master/5.16 material...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19925: Split up subcategories for KNS categories

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Discover Software Store, apol, ngraham.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This adds functionality to programmatically add subcategories (with a 
suitable warning not to do so after the initialisation stage), and uses that to 
perform a splitting of the subcategories supplied the KNewStuff backend.

TEST PLAN
  Previously: Many categories, with annoying and bad readability
  With patch: A nice dig-down tree of categories in the KDE Store applications 
category

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19925

AFFECTED FILES
  libdiscover/Category/Category.cpp
  libdiscover/Category/Category.h
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:94dcbf0500aa: [sddm-theme] Update login screen preview 
image (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19469?vs=54430=54443

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Beautiful.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19469

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19924: [TabBar] Update height when TabButtons are added dynamically

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When using a `Repeater` with an asynchronously populated model `TabBar` fails 
to initially get a height.

TEST PLAN
  - Used a `Repeater` with `ActivitiesModel` wired up to a `TabBar`, previously 
didn't get a height, now it gets a height
  - KWin decoration KCM (which uses hardcoded `TabButtons`) still works fine

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D19924

AFFECTED FILES
  org.kde.desktop/TabBar.qml

To: broulik, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:154637e69119: [sddm-theme/lock screen] Move main stack to 
a more vertically centered position (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19916?vs=54419=54440

REVISION DETAIL
  https://phabricator.kde.org/D19916

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Main.qml

To: rooty, #vdg, ngraham, filipf, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19894: Use https for links in the UI

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:f6eb9ba3dd92: Use https for links in the UI (authored by 
vkrause).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19894?vs=54355=54432

REVISION DETAIL
  https://phabricator.kde.org/D19894

AFFECTED FILES
  src/aboutbugreportingdialog.cpp
  src/bugzillaintegration/reportassistantpages_base.cpp

To: vkrause, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty updated this revision to Diff 54430.
rooty added a comment.


  Deselect password field

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19469?vs=54427=54430

BRANCH
  arcpatch-D19469

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty updated this revision to Diff 54427.
rooty added a comment.


  Use correct Desktop Sesion setting and use Konqi and Katie mascot avatars

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19469?vs=54424=54427

BRANCH
  arcpatch-D19469

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  I'll be retaking this shortly - it says Openbox instead of Plasma (sorry) and 
yeah I'll be replacing the avatars
  The blurry thing - don't look at me (or flipwise and me) because we're about 
as certain as a person can get that it's //not// sddm's (or the theme's) fault

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty updated this revision to Diff 54424.
rooty added a comment.


  Use color avatars and 16:9 aspect ratio

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19469?vs=54421=54424

BRANCH
  arcpatch-D19469

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Björn Feber]

GB_2 added a comment.


  In D19469#435220 , @rooty wrote:
  
  > F6703853: image.png 
  >
  > This is the Konqi avatar I have available in SySe. It renders as fairly 
blurry / lower quality than the one I opted for originally - are you sure you 
want to use this?
  
  
  Hmm, I don't think this should happen, but then I'd just use the default user 
image.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Björn Feber]

GB_2 added a comment.


  In D19469#435216 , @rooty wrote:
  
  > In D19469#435215 , @GB_2 wrote:
  >
  > > BTW, it's still not 1920x1080.
  >
  >
  > Noted. (Why is that relevant though?)
  
  
  Much more common resolution and also used for other images and previews.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  F6703853: image.png 
  
  This is the Konqi avatar I have available in SySe. It renders as fairly 
blurry / lower quality than the one I opted for originally - are you sure you 
want to use this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  In D19469#435215 , @GB_2 wrote:
  
  > BTW, it's still not 1920x1080.
  
  
  Noted.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Björn Feber]

GB_2 added a comment.


  BTW, it's still not 1920x1080.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19915: [Mnemonic Handling] Replace only first occurrence

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Actually

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19915

To: broulik, #plasma, mart, apol
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19915: [Mnemonic Handling] Replace only first occurrence

[Aleix Pol Gonzalez]

apol added a comment.


  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19915

To: broulik, #plasma, mart
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  In D19469#435184 , @GB_2 wrote:
  
  > In D19469#435183 , @rooty wrote:
  >
  > > In D19469#435175 , @GB_2 wrote:
  > >
  > > > The file size is quite big (you can change the compression in 
Spectacle) and I think the resolution should be 1920x1080.
  > > >  Please also change the user images to the colorful Konqi and Katie 
ones.
  > >
  > >
  > > But they're uglier? :D
  >
  >
  > I think they look nice and we've been using them in other previews and 
release announcements too.
  
  
  I beg to differ, but I'll change them if we've been using them in other places

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Björn Feber]

GB_2 added a comment.


  In D19469#435183 , @rooty wrote:
  
  > In D19469#435175 , @GB_2 wrote:
  >
  > > The file size is quite big (you can change the compression in Spectacle) 
and I think the resolution should be 1920x1080.
  > >  Please also change the user images to the colorful Konqi and Katie ones.
  >
  >
  > But they're uglier? :D
  
  
  I think they look nice and we've been using them in other previews and 
release announcements too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  In D19469#435175 , @GB_2 wrote:
  
  > The file size is quite big (you can change the compression in Spectacle) 
and I think the resolution should be 1920x1080.
  >  Please also change the user images to the colorful Konqi and Katie ones.
  
  
  But they're uglier? :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty updated this revision to Diff 54421.
rooty added a comment.


  Compress image

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19469?vs=54418=54421

BRANCH
  arcpatch-D19469

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Björn Feber]

GB_2 added a comment.


  The file size is quite big (you can change the compression in Spectacle) and 
I think the resolution should be 1920x1080.
  Please also change the user images to the colorful Konqi and Katie ones.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19916

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Main.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  Okay so, scrot and xwd kinda drove me nuts, so I decided to open up 
sddm-greeter, cut off its titlebar, hide the panel and it looks identical to 
the login screen so :D Voila

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty updated this revision to Diff 54418.
rooty added a comment.


  Update preview image

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19469?vs=53570=54418

BRANCH
  arcpatch-D19469

REVISION DETAIL
  https://phabricator.kde.org/D19469

AFFECTED FILES
  sddm-theme/preview.png

To: rooty, #vdg, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19915: [Mnemonic Handling] Replace only first occurrence

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Noticed my KCM checkboxes and labels all had all the mnemonic letters 
highlighted, now it's only the first one

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19915

AFFECTED FILES
  src/mnemonicattached.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19096: [Kicker] Fix "Tooltip can not be displayed"

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Yeah, this looks fine, thanks!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19166: Add application path as valid path for debuggers

[patrick j pereira]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:8c74d90e28fb: Add application path as valid path for 
debuggers (authored by patrickelectric).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19166?vs=54345=54412

REVISION DETAIL
  https://phabricator.kde.org/D19166

AFFECTED FILES
  src/debugger.cpp
  src/drkonqibackends.cpp

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[David Edmundson]

davidedmundson added a comment.


  > Sorry it's been taking so long, I've been having the hardest time getting 
virtualbox to work...
  
  FWIW, you can run qmlscene Main.qml inside the
  
  plasma-workspace/sddm-theme directly
  
  It'll load the data from the testdata folder which makes development and 
custom screenshots much easier.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19909: Enable blurbehind for panels only if theme sets it

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D19909#435065 , @zzag wrote:
  
  > What about plasma::dialog?
  
  
  Actually, this was done in plasma-frrameworks. I overlooked that as I had 
stashed this away with other WIP changes when doing D19907 
. Where is my brown paper bag...
  
  Sorry for the incomplete patches, will update this afternoon/tonight.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  supportblurBehindEnabled

REVISION DETAIL
  https://phabricator.kde.org/D19909

To: kossebau, #plasma, davidedmundson
Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19909: Enable blurbehind for panels only if theme sets it

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D19909#435065 , @zzag wrote:
  
  > What about plasma::dialog?
  
  
  Good catch, that slipped from the uploaded patch.  Will update later today.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  supportblurBehindEnabled

REVISION DETAIL
  https://phabricator.kde.org/D19909

To: kossebau, #plasma, davidedmundson
Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19909: Enable blurbehind for panels only if theme sets it

[Vlad Zagorodniy]

zzag added a comment.


  What about plasma::dialog?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  supportblurBehindEnabled

REVISION DETAIL
  https://phabricator.kde.org/D19909

To: kossebau, #plasma, davidedmundson
Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19909: Enable blurbehind for panels only if theme sets it

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Depends on  D19907 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19909

To: kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19909: Enable blurbehind for panels only if theme sets it

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  supportblurBehindEnabled

REVISION DETAIL
  https://phabricator.kde.org/D19909

AFFECTED FILES
  shell/panelview.cpp

To: kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Marco Martin]

mart added a comment.


  So,
  FormLayout has api to align two or more of them with each other, which is the 
list property FormLayout.twinFormLayouts
  
  I wonder if there is a way to make the parent and child formlayouts visible 
ot each other to use such property.
  
  the parent is in 
plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml,
 loading the individual wallpapers config in the stackview at line 162.
  
  so, we could try something like:
  the wallpaper configs will expose a formLayout property.
  the main formLayout has something like
  twinFormLayouts: stack.item && stack.item.formLayout ? 
[stack.item.formLayout] : []
  
  then the parent layout may be i guess injected at instantiation as a property 
of the wallpaper plugin, so the child formlayout can set twinformlayouts as well
  
  this is all untested, so is a bit of R project, but if you would like to 
give a try it may be finally the properfix(tm)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19799: QNetworkReply was not deleted

[Laurent Montel]

mlaurent updated this revision to Diff 54387.
mlaurent added a comment.


  Fix QScopedPointer

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19799?vs=54015=54387

BRANCH
  delete_qnetwork_reply (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19799

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: mlaurent, apol, #discover_software_store
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

[Krešimir Čohar]

rooty added a comment.


  Sure thing
  Sorry it's been taking so long, I've been having the hardest time getting 
virtualbox to work...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19469

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart