D19963: Avoid serializing base64 encoded favicon data twice

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The URL is ignored in case the image data is available. Avoid pushing
  it twice via DBus.

TEST PLAN
  1. start dbus-monitor
  2. type some string in krunner
  
  before: dict entries contain both favIconData and favIconUrl, with
  
identical data
  
  after:  only favIconData is part of the dict
  
  Favicons are still shown in the krunner results

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  favicondata

REVISION DETAIL
  https://phabricator.kde.org/D19963

AFFECTED FILES
  extension/extension.js

To: bruns, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19962: plasmoid: Make it possible to connect to a device using a touchscreen

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, bshah.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  At the moment the button was only shown on hover. Now it will also be
  shown when the details are expanded, which happens on tap.

TEST PLAN
  Connected to my headphones.

REPOSITORY
  R97 Bluedevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19962

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml

To: apol, #plasma, bshah
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19940: always support all command line options

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Sounds good to me.

REPOSITORY
  R871 DrKonqi

BRANCH
  arbitrary-options

REVISION DETAIL
  https://phabricator.kde.org/D19940

To: sitter, #plasma, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19959: Fixed issue causing changed signal to be called with false argument

[Tigran Gabrielyan]

tigrang created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tigrang requested review of this revision.

REVISION SUMMARY
  AdvanceConfig::changed signal is called with changed=false arguement when 
QGroupBox::clicked is called with checked=false causing the Apply button to 
remain disabled.
  

  
  BUG: 403366

TEST PLAN
  1. Open SDDM settings
  2. Enable auto-login, save and close.
  3. Open SDDM settings again
  4. Uncheck auto-login
  
  Apply button should now be enabled.
  Same steps for Relogin after quit checkbox.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

AFFECTED FILES
  src/advanceconfig.cpp

To: tigrang
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  I added the explicit charset to all scss files.

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 updated this revision to Diff 54514.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19931?vs=54457=54514

REVISION DETAIL
  https://phabricator.kde.org/D19931

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: luc4, gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19838: [powerdevil] Touch up messages/prompts

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> powerdevilcore.cpp:541
>  msg = i18nc("Placeholder is device name",
> -"The battery in your mouse (\"%1\") is low, and 
> the device may turn itself off at any time. "
> -"Please replace or charge the battery as soon as 
> possible.", name);
> +"The battery in (\"%1\") is running low, and the 
> device may turn off at any time. "
> +"Please recharge or replace the battery.", name);

Since you removed the separation between the three cases you might as well 
unify the codebase into one. Now you have three separate identical strings.

Also, "The battery in (some device) is running low" with the parenthesis is a 
bit awkward since now it's the sentence's subject.

> powerdevilcore.cpp:580
>  emitRichNotification(QStringLiteral("lowbattery"), i18n("Battery Low 
> (%1% Remaining)", currentPercent),
> - i18n("Your battery is low. If you need to 
> continue using your computer, either plug in your computer, or shut it down 
> and then change the battery."));
> + i18n("Battery running low - to continue using 
> your computer, plug it in or shut it down and change the battery."));
>  return true;

not a fan of that hyphen. It is in the heading, so just change the main text to 
"To continue using your computer..."

> powerdevilcore.cpp:641
>   i18n("AC Adapter Plugged In"),
> - i18n("All pending suspend actions have been 
> canceled."));
> + i18n("The computer will no longer go to 
> sleep."));
>  } else {

Sounds like from now on it will never suspend anymore.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19838

To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19947: systray: show a small animation on the icons when activated

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Both for plasmoids and SNI

TEST PLAN
  Now there's some kind of feedback when pressing the icons

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19947

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: apol, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19946: systray: show a the context menu upon press an hold on the icon

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This way we can open the context menu from touch

TEST PLAN
  Tapped and hold on my screen

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19946

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: apol, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

[Yuri Chornoivan]

yurchor added a comment.


  What should happen when the "Help" button at the bottom of KCM page is 
pressed?
  
  Thanks in advance for your answer.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, 
fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[David Edmundson]

davidedmundson added a comment.


  This is definitely better. The part with the history saving is neat and that 
part is all good to go.
  
  But it still does a huge image copy to plasma every time you copy and paste 
an image around in gimp. It's very expensive, both in memory and the blocking X 
calls for something not needed as you're not closing the app.
  
  I would still like to have the mime type hint solution on line 743.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic added a comment.


  Is this good enough to merge?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19011: Thunderbolt KCM and KDED module

[Daniel Vrátil]

dvratil added a comment.


  Ping, VDG folks are OK with this, how about Plasma :)?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, 
fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Michail Vourlakos]

mvourlakos added a comment.


  In D19822#435735 , @filipf wrote:
  
  > This is a good feature. I'd definitely add an option so it can be turned 
on/off regardless of how well we fix up the icon. Sometimes you need to 
dummy-proof installs so all that matters is that it can be configured; by 
default it could be turned on IMO.
  
  
  This is exactly how Latte git version handles the situation. Enabled by 
default  but it can be turned off from settings window

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Filip Fila]

filipf added a comment.


  This is a good feature. I'd definitely add an option so it can be turned 
on/off regardless of how well we fix up the icon. Sometimes you need to 
dummy-proof installs so all that matters is that it can be configured; by 
default it could be turned on IMO.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19802: [comic] Modernize configuration windows

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:f2647deeeac7: [comic] Modernize configuration windows 
(authored by filipf).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19802?vs=54453=54486

REVISION DETAIL
  https://phabricator.kde.org/D19802

AFFECTED FILES
  applets/comic/package/contents/config/config.qml
  applets/comic/package/contents/ui/configAdvanced.qml
  applets/comic/package/contents/ui/configAppearance.qml
  applets/comic/package/contents/ui/configGeneral.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: abetts, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf added a comment.


  I've done a lot of clean up because: (1) some code is not needed for the 
FormLayout; (2) things worked the same without some code; (3) ported the 
combobox to QQC2 because the main layout is also using QQC2 comboboxes and 
everything still fits with normal scaling.
  
  Let me know if I've gone too far.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

[Filip Fila]

filipf updated this revision to Diff 54485.
filipf added a comment.


  remove line: twinFormLayouts: stack.item && stack.item.formLayout ? 
[stack.item.formLayout] : []

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19932?vs=54459=54485

BRANCH
  support-twinLayouts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19932

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, mart, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 54484.
filipf added a comment.


  port everything

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54460=54484

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

[Filip Fila]

filipf added a comment.


  Second line results in a `stack` not defined error.
  
  I'm actually seeing it's enough to just have the id at line 82 and then in 
the wallpaper plugins do `twinFormLayouts: parentLayout`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19932

To: filipf, mart, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19940: always support all command line options

[Harald Sitter]

sitter added a comment.


  I should add for the record that I'd actually find stricter versioning 
better, but arg handling in kcrash is already a bit tricky because of 
signal-safety restrictions and adding versioning complexity on top would 
probably do nothing for how easy the code base is to approach. On top of that, 
even with minimal options (correctly) set, drkonqi will and should be able to 
help the user file a bug report. In theory we need as little as the pid to do 
something of use.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19940

To: sitter, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19940: always support all command line options

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  with the current way options are handled we'd always have a tight lock
  between kcrash and drkonqi making it unnecessarily difficult to add
  new options because newer kcrashes cannot simply pass them regardless of
  drkonqi's version.
  
  e.g.
  
  - drkonqi 5.20 adds --displayName
  - kcrash 5.70 adds support for passing --displayName
  - kcrash now needs to somehow determine the precise version of drkonqi 
because passing --displayName to 5.19 or below results in exit1
  
  by having drkonqi ignore unknown options we can eliminate this restriction
  as kcrash can then simply always pass all arguments it knows (which it
  needs to do for the entire so-series; 5.70 needs to still work with
  plasma 5.0 in theory)
  
  NB: 5.x still needs some variant of version checking as kcrash needs to
  find out if drkonqi has this new behavior. come 6.x we would be able to
  ignore versions entirely in kcrash

TEST PLAN
  passing arbitrary cli options no longer causes drkonqi to exit in error

REPOSITORY
  R871 DrKonqi

BRANCH
  arbitrary-options

REVISION DETAIL
  https://phabricator.kde.org/D19940

AFFECTED FILES
  src/main.cpp

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19390: adjust the size of the window after the labels sizes were changed

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:cc640cea3e9c: adjust the size of the window after the 
labels sizes were changed (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19390?vs=52734=54474

REVISION DETAIL
  https://phabricator.kde.org/D19390

AFFECTED FILES
  src/backtracewidget.cpp

To: sitter, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19937: don't connect to lambdas and call slots when you can just call the slots

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:d0974fdc18b4: dont connect to lambdas and call 
slots when you can just call the slots (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19937?vs=54471=54475

REVISION DETAIL
  https://phabricator.kde.org/D19937

AFFECTED FILES
  src/statusnotifier.cpp

To: sitter, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19937: don't connect to lambdas and call slots when you can just call the slots

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the lambdas were really unnecessary. both deleteLater and restart
  are losts, and arg-less ones at that, so instead of using a lambda we can
  just connect to the slots directly.

REPOSITORY
  R871 DrKonqi

BRANCH
  randomlambdas

REVISION DETAIL
  https://phabricator.kde.org/D19937

AFFECTED FILES
  src/statusnotifier.cpp

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19390: adjust the size of the window after the labels sizes were changed

[Harald Sitter]

sitter added a comment.


  ping

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19390

To: sitter, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

[David Redondo]

davidre added a comment.


  Great! I see that also  fixes the issue that the label vanished when the 
window got to narrow.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  Happened on KDE Neon in docker.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart