D12055: Remove border around menubars

[Noah Davis]

ndavis added a comment.


  In D12055#436424 , @filipf wrote:
  
  > In D12055#436412 , @ndavis wrote:
  >
  > > I don't see this border at all in the current version of Breeze GTK with 
Firefox. F6711302: Screenshot_20190322_152144.png 

  >
  >
  > Try with a non-default theme
  >
  > F6711393: image.png 
  
  
  Ok, I see what you mean. +1 to this change

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  remove-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

[Vlad Zagorodniy]

zzag updated this revision to Diff 54576.
zzag added a comment.


  rebase

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12055?vs=35206=54576

BRANCH
  remove-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

AFFECTED FILES
  src/gtk318/widgets/_menus.scss
  src/gtk320/widgets/_menus.scss

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

[Filip Fila]

filipf added a comment.


  In D12055#436412 , @ndavis wrote:
  
  > I don't see this border at all in the current version of Breeze GTK with 
Firefox. F6711302: Screenshot_20190322_152144.png 

  
  
  Try with a non-default theme
  
  F6711393: image.png 

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

[Andres Betts]

abetts added a comment.


  +1 for visual improvement

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

[Noah Davis]

ndavis added a comment.


  I don't see this border at all in the current version of Breeze GTK with 
Firefox. F6711302: Screenshot_20190322_152144.png 


REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19959: Fixed issue causing changed signal to be called with false argument

[Tigran Gabrielyan]

tigrang added a comment.


  I do not have commit access.
  
  Can you commit for me, please?
  
  Full Name: Tigran Gabrielyan
  Email: tigran...@gmail.com

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

To: tigrang, mlaurent
Cc: mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

[Filip Fila]

filipf added a comment.


  These borders are still pretty bad looking, I think we should go through with 
this.
  
  F6711163: image.png 

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19694: [RFC] Reduce sidebar icon size/increase list information density

[Filip Fila]

filipf added a comment.


  > Ever since increasing the list item size to accommodate 32px icons, System 
Settings' sidebar has felt somehow wrong to me
  
  Same here, I prefer this patch rather than the bigger icons. Since we're 
still having issues with monochrome issues showing up, obviously the question 
is what do we want to solve at this moment. I'd be more in favor of 
prioritizing reduced information density, but we definitely need more opinions 
and discussion on this.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19694

To: ngraham, #vdg
Cc: filipf, ndavis, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19752: [Splash KCM] Use InlineMessage for testing error

[Andres Betts]

abetts added a comment.


  Could the message include some hints of what failed? Maybe the theme name? 
Something like:
  
  "Failed to test Adwaita splash screen, please check theme"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19752

To: broulik, #plasma, #vdg, filipf
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19752: [Splash KCM] Use InlineMessage for testing error

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Visually I don't think there's anything to object to, and this is a useful 
message to have. The wording seems fine. Someone should also confirm that the 
code is sane.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19752

To: broulik, #plasma, #vdg, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19863: [Host] Add Message.sh

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:832a18822cca: [Host] Add Message.sh (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19863?vs=54248=54571

REVISION DETAIL
  https://phabricator.kde.org/D19863

AFFECTED FILES
  host/CMakeLists.txt
  host/Messages.sh

To: broulik, ltoscano, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19946: systray: show a the context menu upon press an hold on the icon

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:890e91b29bfe: systray: show a the context menu upon press 
an hold on the icon (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19946?vs=54499=54567

REVISION DETAIL
  https://phabricator.kde.org/D19946

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: apol, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19977: Prevent context drawer from disappearing

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Currently, on plasma mobile, if you navigate from a page that contains 
contextual actions to a page without contextual actions and back, context 
drawer disappears. Looking for contextual actions in 
pageStack.layers.currentItem only when pageStack.layers.depth > 1, then 
checking pageStack.currentItem and finally, checking pageStack.lastVisibleItem, 
we ensure that we look for contextual actions in the most relevant page.

TEST PLAN
  On mobile, navigate from a page that contains contextual actions to a page 
without contextual actions and back.
  
  Before patching:
  Context drawer disappears
  
  After patching:
  Context drawer is still visible

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19977

AFFECTED FILES
  src/controls/ContextDrawer.qml

To: dkardarakos, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19959: Fixed issue causing changed signal to be called with false argument

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Good catch.
  it's a bug in clazy.
  
  Thanks
  Do you have an commit access ?
  or do you want that I commit for you ?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

To: tigrang, mlaurent
Cc: mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19976: [about-distro] OSRelease to collect "extra" keys

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously we'd ignore unknown keys. in preparation of moving to a library
  let's instead collect them so a user of the class may also access them.
  
  - new extraKeys helper and extraValue getters
  - extras are always processed as String
  - test case fixture extended + now has comment variants (previously comments 
couldn't be tested since they were skipped as either comments or 
invalid/unknown lines. with the extras API we can actually verify that they do 
not incorrectly end up getting parsed

TEST PLAN
  test still passes

REPOSITORY
  R102 KInfoCenter

BRANCH
  extras

REVISION DETAIL
  https://phabricator.kde.org/D19976

AFFECTED FILES
  Modules/about-distro/autotests/OSReleaseTest.cpp
  Modules/about-distro/autotests/data/os-release
  Modules/about-distro/src/OSRelease.cpp
  Modules/about-distro/src/OSRelease.h

To: sitter, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19975: [about-distro] pimpl OSRelease privates

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  in preparation of moving it into library
  
  - private members are now in private class
  - private class is dptr'd into public class
  - public class has getters for all keys
  - public class has docs

TEST PLAN
  test still passes

REPOSITORY
  R102 KInfoCenter

BRANCH
  pimpl

REVISION DETAIL
  https://phabricator.kde.org/D19975

AFFECTED FILES
  Modules/about-distro/autotests/OSReleaseTest.cpp
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/OSRelease.cpp
  Modules/about-distro/src/OSRelease.h

To: sitter, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19962: plasmoid: Make it possible to connect to a device using a touchscreen

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:bc0b2e4a244c: plasmoid: Make it possible to connect to a 
device using a touchscreen (authored by apol).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19962?vs=54526=54556

REVISION DETAIL
  https://phabricator.kde.org/D19962

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml

To: apol, #plasma, bshah, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 54554.
filipf added a comment.


  make the "Folders" string translatable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54484=54554

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Filip Fila]

filipf added a comment.


  In D18809#436246 , @victorr wrote:
  
  > File /wallpapers/image/imagepackage/contents/ui/config.qml
  >  Word "Folders" without translation
  >
  >   Kirigami.Heading {
  >   text: "Folders"
  >   level: 2
  >   }
  
  
  I'll fix this in D19873 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham, davidedmundson
Cc: victorr, filipf, mart, alexde, davidedmundson, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Victor Ryzhykh]

victorr added a comment.


  File /wallpapers/image/imagepackage/contents/ui/config.qml
  Word "Folders" without translation
  
Kirigami.Heading {
text: "Folders"
level: 2
}

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham, davidedmundson
Cc: victorr, filipf, mart, alexde, davidedmundson, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D19784: Avoid calling QT_LSTAT and accessing recent documents

[Robert Hoffmann]

hoffmannrobert added a comment.


  In D19784#434564 , @hoffmannrobert 
wrote:
  
  > In D19784#431683 , @ngraham 
wrote:
  >
  > > Nice, kinda sounds like this fixes 
https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm?
  >
  >
  > No, unfortunately it doesn't fix this. If the network isn't available, the 
file dialog waits for KCoreDirLister ("Iterating over dirs").
  
  
  After debugging opening a file dialog in kate and firefox, I found it's not 
`KCoreDirLister` but the `Recent Files[$e]` entries in `.config/katerc` and 
`.config/kdialogrc` which cause the hang.
  If they point to files on a network drive, and the network or the drive is 
not responding, `KUrlComboBox::setUrls()` is trying to access them at `if 
(u.isLocalFile() && !QFile::exists(u.toLocalFile())) {...`. The 
`QFile::exists()` calls `QFileInfo::exists()`which is hanging at a 
`__xstat64()` call.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19971: Fix compilation error when SA_TRACE is 1

[Vlad Zagorodniy]

zzag created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The error itself:
  

/home/vlad/Workspace/KDE/src/kde/workspace/libksysguard/ksgrd/SensorAgent.cpp: 
In member function ‘void KSGRD::SensorAgent::executeCommand()’:

/home/vlad/Workspace/KDE/src/kde/workspace/libksysguard/ksgrd/SensorAgent.cpp:210:60:
 error: ‘class QString’ has no member named ‘toAscii’
 qCDebug(LIBKSYSGUARD_KSGRD) << ">> " << req->request().toAscii() << 
"(" << mInputFIFO.count()
^~~
ninja: build stopped: subcommand failed.

REPOSITORY
  R111 KSysguard Library

BRANCH
  fix-compile-error

REVISION DETAIL
  https://phabricator.kde.org/D19971

AFFECTED FILES
  ksgrd/SensorAgent.cpp

To: zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  Hello. No, sorry, I don't think I have it.

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Do you have commit access?

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:34387d450ab2: [Desktop Theme KCM] Normalize 
margin around background in previews (authored by kossebau).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19748?vs=53938=54545

REVISION DETAIL
  https://phabricator.kde.org/D19748

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 370569] kde4breeze.upd ignores system distributor values from XDG_CONFIG_DIRS/kdeglobals

[Erik Quaeghebeur]

https://bugs.kde.org/show_bug.cgi?id=370569

Erik Quaeghebeur  changed:

   What|Removed |Added

 CC||k...@equaeghe.nospammail.net

--- Comment #1 from Erik Quaeghebeur  ---
(In reply to Rohan Garg from comment #0)
> It seems like kde4breeze.upd completely ignores the values set in
> $XDG_CONFIG_DIRS/kdeglobals by a system distributor causing the script to
> override the configured values with Breeze.
Is this still an issue? Do you have a ~/.kde4//share/config/kdeglobals?

-- 
You are receiving this mail because:
You are the assignee for the bug.