D19829: kicker: add option to make root level icons visible

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Björn Feber]

GB_2 added a comment.


  I think this revision can be abandoned.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes added a comment.


  In D16425#448828 , @ngraham wrote:
  
  > In D16425#448822 , @avaldes 
wrote:
  >
  > > In D16425#448820 , @ngraham 
wrote:
  > >
  > > > So is everything now working for you, or not?
  > >
  > >
  > > No, I can't use my keyboard to change brightness, but it might be related 
on how I test my changes. I need guidance on how can I test powerdevil changes 
locally.
  >
  >
  > It's a plasma component, so this might be helpful: 
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Test_plasma
  
  
  I applied this patch to v5.15.4 tag and tested with that and it works (my 
machine is running plasma 5.15.4), I can change the brightness with the 
keyboard and set the suspend-then-hibernate option.
  
  F6769609: image.png 

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Plasma Dev Docs questions

[Juan Carlos Torres]

On Fri, Apr 12, 2019 at 9:22 PM David Edmundson 
wrote:

> Doxyqml is about input rather than output.
>
> We have 3 cases:
> 1) C++ - > used by C++ devs
> 2) C++ - > used by QML devs (currently the same docs as #1)
> 3) QML  -> used by QML devs
>
> Doxyqml makes QML readable by doxygen to give a similar output as 1 & 2.
>

I see. I think we'll have to look around for alternatives then if Doxyqml
can't be improved
to handle #3. Or at least something to use in the meantime. Have you come
across potential
solutions? Aurelein's blog post [1] suggested QDoc, which is what Qt itself
uses but also
lists the drawbacks.

Hopefully, we could find a sustainable solution for Plasma and Kirigami and
future Qt Quick
docs that might be coming our way.

1. http://agateau.com/2013/introducing-doxyqml/


-- 
Regards,

Juan Carlos Torres
Jucato

D20445: signalplotter: Add highdpi support

[Alexander Volkov]

volkov updated this revision to Diff 56102.
volkov added a comment.


  use QPen::setWidthF() instead of QPen::setWidth()

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20445?vs=56079&id=56102

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20445

AFFECTED FILES
  signalplotter/ksignalplotter.cpp

To: volkov
Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Unannounced Dependency Change - plasma-framework

[Friedrich W. H. Kossebau]

Am Freitag, 12. April 2019, 20:47:51 CEST schrieb Ben Cooksley:
> Hi all,
> 
> Recently builds of plasma-framework have started failing on Windows
> due to the absence of "gzip", which was added as a Dependency without
> any announcement as is required of all new dependencies.
> 
> With regards to Windows in particular, usually Craft based systems
> will make use of 7-Zip instead of gzip (and as such, it's already
> available)
> 
> Could we get this fixed please?

I am to blame, missed that plasma-frameworks also is used for WIndows (and 
looked at the wrong product build on CI).

Windows experts, please give https://phabricator.kde.org/D20499 a look, which 
should fix this.

Cheers
Friedrich

D19796: [Device Notifier] Restore Solid notification messages

[Thomas Surrel]

thsurrel added a comment.


  Anyone could have a look at this ? Thanks in advance.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19796

To: thsurrel, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Unannounced Dependency Change - plasma-framework

[Ben Cooksley]

Hi all,

Recently builds of plasma-framework have started failing on Windows
due to the absence of "gzip", which was added as a Dependency without
any announcement as is required of all new dependencies.

With regards to Windows in particular, usually Craft based systems
will make use of 7-Zip instead of gzip (and as such, it's already
available)

Could we get this fixed please?

Regards,
Ben

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> powerdevilcore.cpp:635
> +if (m_batteryRemainingTime > 0) {
> +detail = i18n("You need %s to fill the battery", 
> KFormat().formatDuration(m_batteryRemainingTime, KFormat::HideSeconds));
> +} else {

`Remaining charging time: %s`

> powerdevilcore.cpp:638
> +int currentPercent = currentChargePercent();
> +detail = i18n("Your battery charge level is %s %", 
> currentPercent);
> +}

`Charge level: %s%`

> powerdevilcore.cpp:646
> +if (m_batteryRemainingTime > 0) {
> +detail = i18n("You have %s autonomy left on battery", 
> KFormat().formatDuration(m_batteryRemainingTime, KFormat::HideSeconds));
> +} else {

`Remaining battery life: %s`

> powerdevilcore.cpp:649
> +int currentPercent = currentChargePercent();
> +detail = i18n("Your battery charge level is %s %", 
> currentPercent);
> +}

`Charge level: %s%`

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D20492

To: meven, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

[Méven Car]

meven added a comment.


  In D20492#448825 , @ngraham wrote:
  
  > Screenshots would be nice. :)
  
  
  That's my intent, we can yet talk about wording.
  
  I can now move forward after recompiling everything...

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D20492

To: meven, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  It seems like Elisa has a function to do this: 
https://lxr.kde.org/source/extragear/multimedia/elisa/src/elisaapplication.h#0083
  Maybe something like this could be added to KDE/Plasma Franeworks?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#448842 , @davidedmundson 
wrote:
  
  > Toolbutton should be able to take a qicon as a source
  
  
  Nope, when I use `iconSource: plasmoid.action("alternatives").icon` this 
happens:
  `ConfigOverlay.qml:392:21: Unable to assign QIcon to QString`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson added a comment.


  Toolbutton should be able to take a qicon as a source

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D16425: Added new Suspend then Hibernate option

[Nathaniel Graham]

ngraham added a comment.


  In D16425#448822 , @avaldes wrote:
  
  > In D16425#448820 , @ngraham 
wrote:
  >
  > > So is everything now working for you, or not?
  >
  >
  > No, I can't use my keyboard to change brightness, but it might be related 
on how I test my changes. I need guidance on how can I test powerdevil changes 
locally.
  
  
  It's a plasma component, so this might be helpful: 
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Test_plasma

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

[Nathaniel Graham]

ngraham added a comment.


  Screenshots would be nice. :)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D20492

To: meven, #plasma_workspaces
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes added a comment.


  In D16425#448820 , @ngraham wrote:
  
  > So is everything now working for you, or not?
  
  
  No, I can't use my keyboard to change brightness, but it might be related on 
how I test my changes. I need guidance on how can I test powerdevil changes 
locally.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Nathaniel Graham]

ngraham added a comment.


  So is everything now working for you, or not?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20445: signalplotter: Add highdpi support

[Alexander Volkov]

volkov updated this revision to Diff 56079.
volkov added a comment.


  reduced beam width

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20445?vs=55922&id=56079

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20445

AFFECTED FILES
  signalplotter/ksignalplotter.cpp

To: volkov
Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  in the toolbutton icon source/name property.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#448756 , @davidedmundson 
wrote:
  
  > > It currently returns a QIcon, but I want the name/source of it from QML.
  >
  > What for?
  
  
  So I can use the same icon that is in the context menu

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

Re: More Love for Aether

[Michail Vourlakos]

maybe irrelevant  but it has a bug concerning its panel shadows...

The theme has a small bug.
It misses a "shadow-center" element. Without this element plasma framework
does not indicate that there is a full shadow element in the svgs.

1. This is the reason you do not see the shadow in plasma system settings.
2. This is the reason Latte Dock can not draw this theme shadow properly
for its docks. For its panels there is no problem because PanelShadows
class uses a different way to identify shadows.

Στις Παρ, 12 Απρ 2019 στις 4:42 μ.μ., ο/η Boudhayan Gupta 
έγραψε:

> Hi all,
>
> I've been using Aether Dark (https://store.kde.org/p/1245521/) pretty
> much exclusively on all my computers for over half a year now. I think it's
> beautiful (I prefer dark themes and IMO this is currently far better than
> the default Plasma Dark theme).
>
> I haven't _really_ noticed anything being broken as such; nothing that
> sticks out anyway (I'm on Arch at home and SLES 11.3 with the latest stable
> Plasma releases at work). The theme doesn't seem to have been updated in a
> while. Is it possible that this could be adopted into the official repos
> and so that at the very least it's kept compatible with the latest Plasma
> releases and it doesn't completely wither and die?
>
> Thanks,
> Boudhayan
>

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson added a comment.


  > It currently returns a QIcon, but I want the name/source of it from QML.
  
  What for?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

Re: More Love for Aether

[David Edmundson]

It's already hosted on KDE infrastructure.
We also try to keep theme compatibility.

I don't see a need to make it "official".
I want to push for Plasma to become a much smaller well-maintained
core with a flourishing wider ecosystem.

David

More Love for Aether

[Boudhayan Gupta]

Hi all,

I've been using Aether Dark (https://store.kde.org/p/1245521/) pretty much
exclusively on all my computers for over half a year now. I think it's
beautiful (I prefer dark themes and IMO this is currently far better than
the default Plasma Dark theme).

I haven't _really_ noticed anything being broken as such; nothing that
sticks out anyway (I'm on Arch at home and SLES 11.3 with the latest stable
Plasma releases at work). The theme doesn't seem to have been updated in a
while. Is it possible that this could be adopted into the official repos
and so that at the very least it's kept compatible with the latest Plasma
releases and it doesn't completely wither and die?

Thanks,
Boudhayan

Re: Plasma Dev Docs questions

[David Edmundson]

On Sat, Apr 6, 2019 at 12:55 PM Juan Carlos Torres  wrote:
>
> Hi Jonathan and David!
>
> Thanks for the replies and sorry for not getting back to you ASAP.
>
> It's good there's Workboard for some of those tasks already. Will be
> easier to keep track of them at least and hopefully we can get the ball
> rolling in the next few months. Wish it could be faster but if we had
> enough manpower for docs, we wouldn't be in this state in the first place.
>
> I thought that the desktop scripting tutorials are going to be moved to
> userbase (the Plasma ones are already there):
>
> https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting
>
> Regardless, both scripting guides would have to be updated anyway and
> it's quite a lengthy one.
>
> It does seem we have a bit of a problem with QML support in our apidocs.
> If I'm not mistaken, it's a limitation with Doxygen that KApidox uses. It does
> already use Doxyqml but the output is less than ideal. It's another area
> we'll have to investigate whether it can be approved or, if not, use a 
> different
> system like how ECM and the HIG do it (with Sphinx).
>
Doxyqml is about input rather than output.

We have 3 cases:
1) C++ - > used by C++ devs
2) C++ - > used by QML devs (currently the same docs as #1)
3) QML  -> used by QML devs

Doxyqml makes QML readable by doxygen to give a similar output as 1 & 2.

David

D20492: [WI] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

[Méven Car]

meven created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Improve the notification when the ac adapter is plugged/unplugged.
  Displaying direcly in them the time remaining to empty or fill the battery is 
quite more informative.

TEST PLAN
  No yet tested.

REPOSITORY
  R122 Powerdevil

BRANCH
  add-battery-level-notification

REVISION DETAIL
  https://phabricator.kde.org/D20492

AFFECTED FILES
  CMakeLists.txt
  daemon/powerdevilcore.cpp
  daemon/powerdevilcore.h

To: meven
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20491: Rewrite applicationjobs dataengine to work with libnotificationmanager

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Keeps it mostly working for compatibility.

TEST PLAN
  Depends on D20265 
  
  Copied a file in Dolphin, got task bar progress.
  Tested the old notification plasmoid, showed copy progress and details 
(source, dest, number of files etc) just fine and I could pause and cancel jobs 
from it

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20491

AFFECTED FILES
  dataengines/applicationjobs/CMakeLists.txt
  dataengines/applicationjobs/jobaction.cpp
  dataengines/applicationjobs/jobaction.h
  dataengines/applicationjobs/jobcontrol.cpp
  dataengines/applicationjobs/jobcontrol.h
  dataengines/applicationjobs/kuiserverengine.cpp
  dataengines/applicationjobs/kuiserverengine.h

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20490: Rewrite notifications dataengine to work with libnotificationmanager

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Keeps it mostly working for compatibility.
  
  The grouping stuff in there has been dropped, the old plasmoid should 
otherwise continue to work as normal.
  The dataengine inhibition feature used by plasma-nm is defunct now, not sure 
how this could be implemented in the new system as the `Server` knows nothing 
about inhibitions, it's all filtered in the models.

TEST PLAN
  D20265 
  
  Tried with old plasmoid, got notifications with title and text and images. 
Also tested the timer plasmoid and it successfully showed a "timer finished" 
notification with the new system

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20490

AFFECTED FILES
  dataengines/notifications/CMakeLists.txt
  dataengines/notifications/notificationaction.cpp
  dataengines/notifications/notifications_test.cpp
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h
  dataengines/notifications/org.freedesktop.Notifications.xml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20266: Add new notification plasmoid

[Kai Uwe Broulik]

broulik updated this revision to Diff 56059.
broulik added a comment.


  - Fix diff screwup

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20266?vs=56057&id=56059

REVISION DETAIL
  https://phabricator.kde.org/D20266

AFFECTED FILES
  applets/notifications/CMakeLists.txt
  applets/notifications/Messages.sh
  applets/notifications/filemenu.cpp
  applets/notifications/filemenu.h
  applets/notifications/lib/CMakeLists.txt
  applets/notifications/lib/notificationsapplet.cpp
  applets/notifications/lib/notificationsapplet.h
  applets/notifications/notificationapplet.cpp
  applets/notifications/notificationapplet.h
  applets/notifications/package/Messages.sh
  applets/notifications/package/contents/config/config.qml
  applets/notifications/package/contents/config/main.xml
  applets/notifications/package/contents/tests/test.qml
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  applets/notifications/package/contents/ui/EditContextMenu.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/JobDelegate.qml
  applets/notifications/package/contents/ui/JobDetails.qml
  applets/notifications/package/contents/ui/JobDetailsItem.qml
  applets/notifications/package/contents/ui/JobItem.qml
  applets/notifications/package/contents/ui/Jobs.qml
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationIcon.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/package/contents/ui/ScreenPositionSelector.qml
  applets/notifications/package/contents/ui/SelectableLabel.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml
  applets/notifications/package/contents/ui/TightLabel.qml
  applets/notifications/package/contents/ui/configNotifications.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  applets/notifications/package/contents/ui/global/PulseAudio.qml
  applets/notifications/package/contents/ui/global/qmldir
  applets/notifications/package/contents/ui/main.qml
  applets/notifications/package/contents/ui/uiproperties.js
  applets/notifications/package/metadata.desktop
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/draghelper.cpp
  applets/notifications/plugin/draghelper.h
  applets/notifications/plugin/notificationshelper.cpp
  applets/notifications/plugin/notificationshelper.h
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/notificationshelperplugin.h
  applets/notifications/plugin/qmldir
  applets/notifications/plugin/thumbnailer.cpp
  applets/notifications/plugin/thumbnailer.h
  applets/notifications/thumbnailer.cpp
  applets/notifications/thumbnailer.h

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20266: Add new notification plasmoid

[Kai Uwe Broulik]

broulik updated this revision to Diff 56057.
broulik added a comment.


  - Grouping fixes, unread notifications are automatically expanded now and 
collapsing a group scrolls to the top of it
  - Added "4 hours" and "until disabled" do not disturb mode
  - Job progress bar is hidden when completed
  - Minor fixes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20266?vs=55471&id=56057

REVISION DETAIL
  https://phabricator.kde.org/D20266

AFFECTED FILES
  applets/notifications/CMakeLists.txt
  applets/notifications/Messages.sh
  applets/notifications/filemenu.cpp
  applets/notifications/filemenu.h
  applets/notifications/lib/CMakeLists.txt
  applets/notifications/lib/notificationsapplet.cpp
  applets/notifications/lib/notificationsapplet.h
  applets/notifications/notificationapplet.cpp
  applets/notifications/notificationapplet.h
  applets/notifications/package/Messages.sh
  applets/notifications/package/contents/config/config.qml
  applets/notifications/package/contents/config/main.xml
  applets/notifications/package/contents/tests/test.qml
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  applets/notifications/package/contents/ui/EditContextMenu.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/JobDelegate.qml
  applets/notifications/package/contents/ui/JobDetails.qml
  applets/notifications/package/contents/ui/JobDetailsItem.qml
  applets/notifications/package/contents/ui/JobItem.qml
  applets/notifications/package/contents/ui/Jobs.qml
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationIcon.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/package/contents/ui/ScreenPositionSelector.qml
  applets/notifications/package/contents/ui/SelectableLabel.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml
  applets/notifications/package/contents/ui/TightLabel.qml
  applets/notifications/package/contents/ui/configNotifications.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  applets/notifications/package/contents/ui/global/PulseAudio.qml
  applets/notifications/package/contents/ui/global/qmldir
  applets/notifications/package/contents/ui/main.qml
  applets/notifications/package/contents/ui/uiproperties.js
  applets/notifications/package/metadata.desktop
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/draghelper.cpp
  applets/notifications/plugin/draghelper.h
  applets/notifications/plugin/notificationshelper.cpp
  applets/notifications/plugin/notificationshelper.h
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/notificationshelperplugin.h
  applets/notifications/plugin/qmldir
  applets/notifications/plugin/thumbnailer.cpp
  applets/notifications/plugin/thumbnailer.h
  applets/notifications/thumbnailer.cpp
  applets/notifications/thumbnailer.h

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20265: Introduce libnotificationmanager

[Kai Uwe Broulik]

broulik updated this revision to Diff 56056.
broulik edited the summary of this revision.
broulik added a comment.


  - Address review comments
  - Rewrite job handling to be kuiserver and kill it
  
  I removed the dataengine rewrite from the diff to make it a bit less 
overwhelming, will come up as separate patch
  kuiserver removal is also not in the diff as that's just deleting the folder 
and removing it from CMakeLists

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20265?vs=55470&id=56056

REVISION DETAIL
  https://phabricator.kde.org/D20265

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/LibNotificationManagerConfig.cmake.in
  libnotificationmanager/autotests/CMakeLists.txt
  libnotificationmanager/autotests/notifications_test.cpp
  libnotificationmanager/dbus/org.freedesktop.Notifications.xml
  libnotificationmanager/dbus/org.kde.JobViewServer.xml
  libnotificationmanager/dbus/org.kde.JobViewServerV2.xml
  libnotificationmanager/dbus/org.kde.JobViewV2.xml
  libnotificationmanager/dbus/org.kde.JobViewV3.xml
  libnotificationmanager/dbus/org.kde.kuiserver.xml
  libnotificationmanager/declarative/CMakeLists.txt
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/declarative/notificationmanagerplugin.h
  libnotificationmanager/declarative/qmldir
  libnotificationmanager/job.cpp
  libnotificationmanager/job.h
  libnotificationmanager/job_p.cpp
  libnotificationmanager/job_p.h
  libnotificationmanager/jobsmodel.cpp
  libnotificationmanager/jobsmodel.h
  libnotificationmanager/jobsmodel_p.cpp
  libnotificationmanager/jobsmodel_p.h
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/libnotificationmanager.categories
  libnotificationmanager/limitedrowcountproxymodel.cpp
  libnotificationmanager/limitedrowcountproxymodel_p.h
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationfilterproxymodel.cpp
  libnotificationmanager/notificationfilterproxymodel_p.h
  libnotificationmanager/notificationgroupcollapsingproxymodel.cpp
  libnotificationmanager/notificationgroupcollapsingproxymodel_p.h
  libnotificationmanager/notificationgroupingproxymodel.cpp
  libnotificationmanager/notificationgroupingproxymodel_p.h
  libnotificationmanager/notifications.cpp
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/notificationsortproxymodel.cpp
  libnotificationmanager/notificationsortproxymodel_p.h
  libnotificationmanager/plasmanotifyrc
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h
  libnotificationmanager/utils.cpp
  libnotificationmanager/utils_p.h

To: broulik, #plasma
Cc: nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg added a comment.


  In D20186#31 , @atulbi wrote:
  
  > In D20186#443596 , @romangg 
wrote:
  >
  > > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file 
are copy-paste from the Wayland backend. It would make sense to have a new 
abstract parent class such that the code is shared.
  >
  >
  > Initially, I also wanted to implement it that way, but it'll mess up 
existing code, and especially because LibinputTouchpad class already extends 
XlibTouchpad class. Or split out the common parts into a helper-class.
  
  
  Can it multi-inherit?
  
  > I wanted to have minimal changes to existing code.
  
  Make a two patch series: first patch would be creating the parent class and 
let current Wayland backend inherit it. Second patch would be creating 
X11/libinput child class.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20113: [Desktop Theme KCM] Adapt clock to new hand rotation center options

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dfdbc19d9fc9: [Desktop Theme KCM] Adapt clock to new hand 
rotation center options (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20113?vs=55781&id=56046#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20113?vs=55781&id=56046

REVISION DETAIL
  https://phabricator.kde.org/D20113

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/Hand.qml
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2558f3626280: [analog-clock] Allow themes to define hand 
shadow offset & hand rot center (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20112?vs=55777&id=56045#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20112?vs=55777&id=56045

REVISION DETAIL
  https://phabricator.kde.org/D20112

AFFECTED FILES
  applets/analog-clock/contents/ui/Hand.qml
  applets/analog-clock/contents/ui/analogclock.qml

To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 2 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/2/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Apr 2019 07:03:44 +
 Build duration:
37 min and counting
   CONSOLE OUTPUT
  [...truncated 381 lines...][2019-04-12T07:41:15.300Z] **[2019-04-12T07:41:15.300Z] ** Visual Studio 2017 Developer Command Prompt v15.7.3[2019-04-12T07:41:15.300Z] ** Copyright (c) 2017 Microsoft Corporation[2019-04-12T07:41:15.300Z] **[2019-04-12T07:41:16.240Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-04-12T07:41:16.501Z] [2019-04-12T07:41:16.501Z] jom 1.1.2 - empower your cores[2019-04-12T07:41:16.501Z] [2019-04-12T07:41:16.501Z] jom: parallel job execution disabled for Makefile[2019-04-12T07:41:16.501Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-04-12T07:41:16.501Z] Scanning dependencies of target kdbgwin_autogen[2019-04-12T07:41:16.501Z] Scanning dependencies of target crashtest_autogen[2019-04-12T07:41:16.501Z] Scanning dependencies of target bugzillalibtest_autogen[2019-04-12T07:41:16.501Z] [  3%] Automatic MOC for target drkonqi_backtrace_parser[2019-04-12T07:41:16.501Z] [  3%] Automatic MOC for target crashtest[2019-04-12T07:41:16.501Z] [  4%] Built target crashtest_autogen[2019-04-12T07:41:16.501Z] [  1%] Automatic MOC for target kdbgwin[2019-04-12T07:41:16.766Z] [  4%] Built target kdbgwin_autogen[2019-04-12T07:41:16.766Z] Scanning dependencies of target kdbgwin[2019-04-12T07:41:16.766Z] [  4%] Built target drkonqi_backtrace_parser_autogen[2019-04-12T07:41:16.766Z] [  4%] Automatic MOC for target bugzillalibtest[2019-04-12T07:41:16.766Z] [  5%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/main.cpp.obj[2019-04-12T07:41:16.766Z] [  7%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/process.cpp.obj[2019-04-12T07:41:16.766Z] [  9%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/callbacks.cpp.obj[2019-04-12T07:41:16.766Z] [  9%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/abstract_generator.cpp.obj[2019-04-12T07:41:16.766Z] [ 11%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/outputters.cpp.obj[2019-04-12T07:41:16.766Z] [ 11%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/__/drkonqi_debug.cpp.obj[2019-04-12T07:41:16.766Z] [ 12%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/msvc_generator.cpp.obj[2019-04-12T07:41:16.766Z] [ 14%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_autogen/mocs_compilation.cpp.obj[2019-04-12T07:41:16.766Z] Scanning dependencies of target crashtest[2019-04-12T07:41:16.766Z] main.cpp[2019-04-12T07:41:16.766Z] [ 15%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.obj[2019-04-12T07:41:16.766Z] [ 15%] Built target bugzillalibtest_autogen[2019-04-12T07:41:16.766Z] [ 16%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.obj[2019-04-12T07:41:16.766Z] drkonqi_debug.cpp[2019-04-12T07:41:16.766Z] c:\ci\workspace\plasma\drkonqi\stable-kf5-qt5 windowsmsvcqt5.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-04-12T07:41:16.766Z] crashtest.cpp[2019-04-12T07:41:16.766Z] Scanning dependencies of target drkonqi_backtrace_parser[2019-04-12T07:41:17.051Z] mocs_compilation.cpp[2019-04-12T07:41:17.051Z] [ 18%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.obj[2019-04-12T07:41:17.051Z] [ 20%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.obj[2019-04-12T07:41:17.051Z] [ 18%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.obj[2019-04-12T07:41:17.051Z] backtraceparser.cpp[2019-04-12T07:41:17.051Z] Scanning dependencies of target bugzillalibtest[2019-04-12T07:41:17.311Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-04-12T07:41:17.311Z] jom: C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11\build\src\kdbgwin\CMakeFiles\kdbgwin.dir\build.make [src\kdbgwin\CMakeFiles\kdbgwin.dir\main.cpp.obj] Error 2[2019-04-12T07:41:17.311Z] process.cpp[2019-04-12T07:41:17.311Z] abstract_generator.cpp[2019-04-12T07:41:17.311Z] callbacks.cpp[2019-04-12T07:41:17.311Z] outputters.cpp[2019-04-12T07:41:17.311Z] msvc_generator.cpp[2019-04-12T07:41:17.311Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-04-12T07:41:17.311Z] mocs_compilation.cpp[2019-04-12T07:41:17.311Z] jom: C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 Wi