D20522: Don't load the KSharedConfig instance on every read

2019-04-13 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
apol requested review of this revision.

REVISION SUMMARY
  At the moment it was loading >2000 times at plasma boot for me because some
  settings are being used in AppletProxyModel::filterAcceptsRow.

TEST PLAN
  Added a debug statement in KSharedPointer::openFile()

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20522

AFFECTED FILES
  libs/configuration.cpp

To: apol, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

2019-04-13 Thread Alejandro Valdes 
avaldes added a comment.


  In D16425#449026 , @meven wrote:
  
  > In D16425#448999 , @avaldes 
wrote:
  >
  > > I applied this patch to v5.15.4 tag and tested with that and it works (my 
machine is running plasma 5.15.4), I can change the brightness with the 
keyboard and set the suspend-then-hibernate option.
  > >
  > > F6769609: image.png 
  >
  >
  > Very nice.
  >  The position of the checkbox in the settings seems odd to me.
  >  It would be great to align it below the "After" field.
  >  Or perhaps the screenshot just does not justice to the UI.
  
  
  This is how the module looks with the new option:
  F6770639: image.png 
  It looks the same as the "Even when an external monitor is connected", I 
tried using a HBox but it didn't change the alignment, maybe there is a 
restriction on how powerdevil builds the UI, but I'm no expert on that. if 
anyone has any idea on how to change it I'm open to suggestions.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car 
meven added a comment.


  Also I'd like to display the duration naturally like "1 hour 30 minutes" 
instead of "1:30" as it does currently.
  Could someone point me to the right Kcore/KLocale feature for this ?
  I have done a little research but haven't found any, perhaps we are lacking 
the feature.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D20492

To: meven, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car 
meven added a comment.


  When AC is plugged:
  F6770195: ac-plugged.png 
  
  When AC is unplugged:
  F6770194: ac-unplugged.png 
  
  I have noticed that sometimes the remaining time is not available.
  In which case the percent is used, but I haven't tested this case properly.
  
  Also I hesitate to always include the percent in those notifications.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D20492

To: meven, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car 
meven updated this revision to Diff 56125.
meven added a comment.


  No need to keep stored localy the batterRemainingTime

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20492?vs=56123=56125

BRANCH
  arcpatch-D20492

REVISION DETAIL
  https://phabricator.kde.org/D20492

AFFECTED FILES
  CMakeLists.txt
  daemon/powerdevilcore.cpp

To: meven, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car 
meven updated this revision to Diff 56123.
meven added a comment.


  Fix formatting of details

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20492?vs=56113=56123

BRANCH
  arcpatch-D20492

REVISION DETAIL
  https://phabricator.kde.org/D20492

AFFECTED FILES
  CMakeLists.txt
  daemon/powerdevilcore.cpp
  daemon/powerdevilcore.h

To: meven, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car 
meven updated this revision to Diff 56113.
meven added a comment.


  Improve wording

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20492?vs=56063=56113

BRANCH
  arcpatch-D20492

REVISION DETAIL
  https://phabricator.kde.org/D20492

AFFECTED FILES
  CMakeLists.txt
  daemon/powerdevilcore.cpp
  daemon/powerdevilcore.h

To: meven, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

2019-04-13 Thread Méven Car 
meven added a comment.


  In D16425#448999 , @avaldes wrote:
  
  > I applied this patch to v5.15.4 tag and tested with that and it works (my 
machine is running plasma 5.15.4), I can change the brightness with the 
keyboard and set the suspend-then-hibernate option.
  >
  > F6769609: image.png 
  
  
  Very nice.
  The position of the checkbox in the settings seems odd to me.
  It would be great to align it below the "After" field.
  Or perhaps the screenshot just does not justice to the UI.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-13 Thread Björn Feber 
GB_2 added a comment.


  Or we could just leave it how it is now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D19829: kicker: add option to make root level icons visible

2019-04-13 Thread Björn Feber 
GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

2019-04-13 Thread Björn Feber 
GB_2 added a comment.


  I think this revision can be abandoned.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart