D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Luigi Toscano]

ltoscano added a comment.


  Thanks, I will keep an eye on the review.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

[Filip Fila]

filipf added a comment.


  In D20598#456330 , @meven wrote:
  
  > I don't see those buttons, I guess you need a remote mouse or something 
similar to have them.
  
  
  Yeah you would need 2 devices I guess. I have my laptop's battery and the 
wireless mouse's battery listed.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

[Fabian Vogt]

fvogt added a comment.


  I'm not sure why this is necessary - during `new Audio` the created object 
can't play anything by itself as `src` is not set.
  If just doing `createdAudio.paused = false` after the removeChild is not 
enough, is that because the DOM modifications are queued and executed after the 
audio started playing?
  
  Here I can let google translate speak and play the radio just fine, but 
neither of them are visible to pbi. So race condition, browser differences or 
bug?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20830

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e39aed6f167f: [Calendar] Port settings window to 
QQC2+Kirigami FormLayout and modernize UI (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20829?vs=56995=56996

REVISION DETAIL
  https://phabricator.kde.org/D20829

AFFECTED FILES
  applets/calendar/package/contents/config/config.qml
  applets/calendar/package/contents/ui/configGeneral.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> meven wrote in main.qml:21
> I might be too aggressive here, what would be the best version to set here ?

2.5 is always a safe bet.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filipf wrote in configGeneral.qml:50
> Compact version is maybe a bit vague, but I can't think of anything better 
> honestly.

Yeah me neither. :/

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-calendar-widget-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20829

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham updated this revision to Diff 56995.
ngraham marked an inline comment as done.
ngraham added a comment.


  Delete trailing space

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20829?vs=56993=56995

BRANCH
  modernize-calendar-widget-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20829

AFFECTED FILES
  applets/calendar/package/contents/config/config.qml
  applets/calendar/package/contents/ui/configGeneral.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

[Méven Car]

meven added a comment.


  
  
  In D20598#456309 , @filipf wrote:
  
  > Works for me, nice work with aligning the layouts.
  >
  > I'm a bit conflicted, but I think visually the issue is how these buttons 
look like with the port, as well as their icons (but that was a problem before 
as well):
  >
  > F6793389: image.png 
  >
  > Before they had a useless frame, but the buttons had a border on all 4 
sides:
  >
  > F6793398: image.png 
  >
  > Losing the bottom maybe makes sense, but feels disconnected here IMO.
  
  
  I am using the dark theme and those buttons are pretty much
  
  In D20598#456309 , @filipf wrote:
  
  > Works for me, nice work with aligning the layouts.
  >
  > I'm a bit conflicted, but I think visually the issue is how these buttons 
look like with the port, as well as their icons (but that was a problem before 
as well):
  >
  > F6793389: image.png 
  >
  > Before they had a useless frame, but the buttons had a border on all 4 
sides:
  >
  > F6793398: image.png 
  >
  > Losing the bottom maybe makes sense, but feels disconnected here IMO.
  
  
  I don't see those buttons, I guess you need a remote mouse or something 
similar to have them.

INLINE COMMENTS

> main.qml:21
> +import QtQuick 2.5
> +import QtQuick.Controls 2.12
>  import QtQuick.Layouts 1.1

I might be too aggressive here, what would be the best version to set here ?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Let the comment in the code speak for itself. Now, where is my jug of 
disinfecting agent...

TEST PLAN
  Google translate works again and so does https://www.radio.net/s/cinemix for 
which I originally added this.
  
  Can also control them via p-b-i

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20830

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Filip Fila]

filipf accepted this revision.
filipf added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> configGeneral.qml:27
>  id: generalPage
>  
> +anchors.left: parent.left

trailing space

> configGeneral.qml:50
> +QtControls.RadioButton {
> +Kirigami.FormData.label: i18nc("What information is shown in the 
> calendar icon", "Compact version:")
> +

Compact version is maybe a bit vague, but I can't think of anything better 
honestly.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-calendar-widget-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20829

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

[Filip Fila]

filipf added a comment.


  Works for me, nice work with aligning the layouts.
  
  I'm a bit conflicted, but I think visually the issue is how these buttons 
look like with the port, as well as their icons (but that was a problem before 
as well):
  
  F6793389: image.png 
  
  Before they had a useless frame, but the buttons had a border on all 4 sides:
  
  F6793398: image.png 
  
  Losing the bottom maybe makes sense, but feels disconnected here IMO.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port to QQC2+Kirigami FormLayout style
  - Adjust some strings to be more natural
  - Use radio buttons instead of a two-item combobox

TEST PLAN
  Everything works.
  
  F6793395: Calendar.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-calendar-widget-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20829

AFFECTED FILES
  applets/calendar/package/contents/config/config.qml
  applets/calendar/package/contents/ui/configGeneral.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20828: Correctly show memory sizes > 4 GiB on 32 bit Linux

[Christoph Feck]

cfeck created this revision.
cfeck added a reviewer: Plasma.
cfeck added a project: Plasma.
Herald added a subscriber: plasma-devel.
cfeck requested review of this revision.

REVISION SUMMARY
  BUG: 406351

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20828

AFFECTED FILES
  Modules/about-distro/src/Module.cpp

To: cfeck, #plasma
Cc: sitter, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R103:fb171dff39c7: Fix sorting to use locale-aware comparisons 
(authored by jen6, committed by cfeck).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20386?vs=55792=56990#toc

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20386?vs=55792=56990

REVISION DETAIL
  https://phabricator.kde.org/D20386

AFFECTED FILES
  treeview.cpp

To: jen6, #plasma, cfeck, pino, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b8d753f4f00f: [Pager] Port settings window to 
QQC2+Kirigami FormLayout and improve UI (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20796?vs=56941=56989

REVISION DETAIL
  https://phabricator.kde.org/D20796

AFFECTED FILES
  applets/pager/package/contents/config/config.qml
  applets/pager/package/contents/ui/configGeneral.qml

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

[Björn Feber]

GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Perfect.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize-pager-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20796

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

[Björn Feber]

GB_2 added a comment.


  Can you please update this patch? It doesn't apply anymore. It would also be 
nice if you used Arcanist/`arc` in the future: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20819: Make really sure we show an error message in case saving failed

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> options.js:174
> +// When the extension is reloaded, any call to 
> extension APIs throws, make sure we show at least some form of error
> +saveMessage.innerText = "Saving settings failed 
> (" + e + ")";
> +}

This should show `error` as well

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20819

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Aleix Pol Gonzalez]

apol added subscribers: ltoscano, apol.
apol accepted this revision.
apol added a comment.


  Looks good to me. Will have to move the (few) translations with it. @ltoscano

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20810: Fix launcher URL comparison

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ContextMenu.qml:279
>  
> -enabled: visualParent && get(atm.LauncherUrlWithoutIcon) !== ""
> +enabled: visualParent && get(atm.LauncherUrlWithoutIcon) != ""
>  

how about `enabled: visualParent && get(atm.LauncherUrlWithoutIcon)`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20810

To: broulik, #plasma, hein, ngraham, mlaurent, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D20820: Add Show Desktop applet to default panel

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice. Please wait for a #plasma  
review too. :)
  
  It would also be nice if we can find a way to make this monochrome by default 
so it matches everything else on the default panel. However Kubuntu currently 
ships this way and IIRC nobody's complained so it's a very small papercut. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-showdesktop-applet-to-default-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20820

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice. Please wait for a #plasma  
review too. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20817: Remove the Show Desktop applet (it's in plasma-desktop now)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice. Please wait for a #plasma  
review too. :)

REPOSITORY
  R114 Plasma Addons

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20817

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20820: Add Show Desktop applet to default panel

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  T7917 

TEST PLAN
  The default panel should now have a Show Desktop applet.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-showdesktop-applet-to-default-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20820

AFFECTED FILES
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20819: Make really sure we show an error message in case saving failed

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When the extension is reloaded, its context is invalidated and any call to an 
extension API would just throw.
  Catch the most important bits of error reporting on save, so you're not left 
wondering why your settings don't change.

TEST PLAN
  Was working on some settings bits, had to reload the extension often to test 
things and was always wondering why it didn't do anything when I forgot to also 
reload the settings page
  
  Now at least I get an error of sorts:
  
  > Saving settings failed (Error: Extension context invalidated.)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20819

AFFECTED FILES
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20818: [plasma-desktop] Move the Show Desktop applet

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Move the Show Desktop applet from `kdeplasma-addons` to `plasma-desktop`, so 
it can be added to the panel by default later.

TEST PLAN
  The Show Desktop applet should now appear in the "Add Widgets..." dialog when 
`kdeplasma-addons` is not installed.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

AFFECTED FILES
  applets/CMakeLists.txt
  applets/showdesktop/CMakeLists.txt
  applets/showdesktop/Messages.sh
  applets/showdesktop/package/contents/config/main.xml
  applets/showdesktop/package/contents/ui/main.qml
  applets/showdesktop/package/metadata.desktop
  applets/showdesktop/plugin/qmldir
  applets/showdesktop/plugin/showdesktop.cpp
  applets/showdesktop/plugin/showdesktop.h
  applets/showdesktop/plugin/showdesktopplugin.cpp
  applets/showdesktop/plugin/showdesktopplugin.h

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20817: [kdeplasma-addons] Move the Show Desktop applet

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Move the Show Desktop applet from `kdeplasma-addons` to `plasma-desktop`, so 
it can be added to the panel by default later.

TEST PLAN
  The Show Desktop applet should now be missing from `kdeplasma-addons`.

REPOSITORY
  R114 Plasma Addons

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20817

AFFECTED FILES
  applets/CMakeLists.txt
  applets/showdesktop/CMakeLists.txt
  applets/showdesktop/Messages.sh
  applets/showdesktop/package/contents/config/main.xml
  applets/showdesktop/package/contents/ui/main.qml
  applets/showdesktop/package/metadata.desktop
  applets/showdesktop/plugin/qmldir
  applets/showdesktop/plugin/showdesktop.cpp
  applets/showdesktop/plugin/showdesktop.h
  applets/showdesktop/plugin/showdesktopplugin.cpp
  applets/showdesktop/plugin/showdesktopplugin.h

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

[Topi Miettinen]

topimiettinen added a comment.


  It looks like the CGroup rows are visually not vertically aligned to center 
like other cells, but instead they are aligned to the top. However, I'd expect 
that the default item of switch in ProcessModel.cpp:1693 should implement this, 
like it does for e.g. HeadingName. So I'm a bit puzzled why this happens.

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20810: Fix launcher URL comparison

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein, ngraham, mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Launcher URL is a `QUrl` which doesn't strictly map empty `string`.

TEST PLAN
  Pin to task bar and start new instance is correctly disabled now if no 
launcher url could be determined
  Yet another regression caused by 6e36de2e1e92743751ddd5b735cdfe9b2e95e5e2 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20810

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: broulik, #plasma, hein, ngraham, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: App Stores in Plasma

[Jonathan Riddell]

On Thu, 25 Apr 2019 at 00:23, Aleix Pol  wrote:

> Having a recommendation could make sense, but it's more a policy that
> the distro should have more than Plasma, given we cannot regulate
> something that isn't in our control.
>

We do already have a recommendation which is our default install, which
currently seems to say we trust Snap Store, Flathub but not Appimagehub.
Maybe that's fine but it should be a conscious decision we make. We could
also take some responsibility for investigating what the policies of these
stores are about updates etc and publishing that for our users to
distributors to understand.

And in the brave new world of containerised packages it may not be long
before KDE provides a package of Discover to install direct in which case
it's even more our responsibility.

Jonathan

D20804: RFC: Try getting the X keyboard grab multiple times

[David Edmundson]

davidedmundson added a comment.


  > Shouldn't this and the above function name start with small letter?
  
  DBus methods and signals tend to start with an upper case. Though interface 
already consists of a mixture :/
  Classes using Qt generated DBus adaptors have to match the interface they're 
implementing.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20804

To: davidedmundson, #plasma, #kwin
Cc: shubham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20804: RFC: Try getting the X keyboard grab multiple times

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> interface.h:116
>  
> +void AboutToLock();
> +

Shouldn't this and the above function name start with small letter?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20804

To: davidedmundson, #plasma, #kwin
Cc: shubham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20804: RFC: Try getting the X keyboard grab multiple times

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20804

To: davidedmundson, #plasma, #kwin
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20804: RFC: Try getting the X keyboard grab multiple times

[David Edmundson]

davidedmundson created this revision.
davidedmundson added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Right now when the screen locker starts it tries to grab the keyboard on
  X. This fails if any other application has grabbed the keyboard.
  
  In these situations the screen simply doesn't lock which is a pretty
  rubbish state.
  
  This can't be realistically fixed properly on X, on wayland it's a
  non-issue.
  
  However, we can minimise the occasions when this occurs.
  
  This patch emits a signal before locking and then tries the lack
  multiple times. Clients can listen for this event and release their
  keyboard grabs.

TEST PLAN
  Wrote relevant matching kwin patch to close effects
  "sleep 5 ; loginctl lock-session" whilst a desktop effect was active still 
locked the session

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20804

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  interface.cpp
  interface.h
  ksldapp.cpp
  ksldapp.h

To: davidedmundson, #plasma, #kwin
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20803: Send vivaldi-stable as DesktopEntry

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:04d079f57858: Send vivaldi-stable as DesktopEntry 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20803?vs=56947=56948

REVISION DETAIL
  https://phabricator.kde.org/D20803

AFFECTED FILES
  host/mprisplugin.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20803: Send vivaldi-stable as DesktopEntry

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  The RPM as well (luckily, that would've been a mess otherwise)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20803

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20803: Send vivaldi-stable as DesktopEntry

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is what the official deb package I downloaded from their website uses

TEST PLAN
  I now get media controls in task manager for it

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20803

AFFECTED FILES
  host/mprisplugin.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart