D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce marked 8 inline comments as done.
andersonbruce added a comment.


  Update to fix some comments.

INLINE COMMENTS

> jgrulich wrote in connectionicon.cpp:403
> You can now use NetworkManager::Device::WireGuard.

There is still a discrepancy between the enum defined by NetworkManager and the 
one defined by NMQT.  NetworkManager is returning a value of 29 but 
NetworkManager::Device::WireGuard has a value of 30.

> jgrulich wrote in wireguardpeerwidget.cpp:52
> You can change all the validators to take all the necessary parameters as 
> first and then have a default value for the parent object so you don't need 
> to pass a nullptr.
> 
> E.g.
> 
>   explicit SimpleIpV4AddressValidator(AddressStyle style = 
> AddressStyle::Base, QObject *parent = nullptr);
> 
> I should have noticed this before. Can you change all the validators you use 
> this way?

SimpleIpV4AddressValidator and SimpleIpV6AddressValidator were intentionally 
done this way because they were existing functions that I didn't want to break 
when I added new (defaulted) parameters for use in with WireGuard functionality.

Since changing these two will involve changes to non-WireGuard code and it 
makes sense to do them all at the same time, can we write this up as a separate 
Bug?

> jgrulich wrote in networkmodelitem.cpp:480
> There is already WireGuard device in NMQT with KF5 5.58 which you should be 
> able to use.

This was just an extraneous comment so it was removed

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce updated this revision to Diff 57888.
andersonbruce added a comment.


  - Correct review comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57790&id=57888

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerwidget.ui
  libs/editor/settings/ui/wireguardtabwidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/settings/wireguardpeerwidget.h
  libs/editor/settings/wireguardtabwidget.cpp
  libs/editor/settings/wireguardtabwidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21134: [Notifications] Tweak paddings

[Aleix Pol Gonzalez]

apol added a comment.


  +1 I too am missing some spacing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21134: [Notifications] Tweak paddings

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The new notification pop-ups are great, but they can feel a bit cramped. This 
patch
  slightly increases the paddings around the edges.

TEST PLAN
  [screenshots go here]

REPOSITORY
  R120 Plasma Workspace

BRANCH
  tweak-notification-paddings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21134

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: ngraham, #vdg, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 228 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/228/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 10 May 2019 20:45:32 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 11 test(s), Passed: 97 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testLockScreenFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testShellClientFailed: projectroot.autotests.integration.kwin_testShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 3 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucency

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 145 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/145/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 10 May 2019 17:25:16 +
 Build duration:
4 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 2551 lines...][2019-05-10T17:29:00.371Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/input.cpp: In member function ���virtual bool KWin::DragAndDropInputFilter::touchMotion(quint32, const QPointF&, quint32)���:[2019-05-10T17:29:00.371Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/input.cpp:1546:23: warning: comparison of integer expressions of different signedness: ���qint32��� {aka ���int���} and ���quint32��� {aka ���unsigned int���} [-Wsign-compare][2019-05-10T17:29:00.371Z]  if (m_touchId != id) {[2019-05-10T17:29:00.371Z]  ~~^[2019-05-10T17:29:00.371Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/input.cpp: In member function ���virtual bool KWin::DragAndDropInputFilter::touchUp(quint32, quint32)���:[2019-05-10T17:29:00.371Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/input.cpp:1582:23: warning: comparison of integer expressions of different signedness: ���qint32��� {aka ���int���} and ���quint32��� {aka ���unsigned int���} [-Wsign-compare][2019-05-10T17:29:00.371Z]  if (m_touchId == id) {[2019-05-10T17:29:00.371Z]  ~~^[2019-05-10T17:29:00.371Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/pointer_input.cpp.o[2019-05-10T17:29:00.371Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/touch_input.cpp.o[2019-05-10T17:29:00.942Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/netinfo.cpp.o[2019-05-10T17:29:01.507Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/placement.cpp.o[2019-05-10T17:29:01.779Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/atoms.cpp.o[2019-05-10T17:29:01.779Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/utils.cpp.o[2019-05-10T17:29:02.037Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/layers.cpp.o[2019-05-10T17:29:02.037Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/main.cpp.o[2019-05-10T17:29:02.970Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/options.cpp.o[2019-05-10T17:29:02.970Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/outline.cpp.o[2019-05-10T17:29:02.970Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/events.cpp.o[2019-05-10T17:29:03.535Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/killwindow.cpp.o[2019-05-10T17:29:03.535Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/geometrytip.cpp.o[2019-05-10T17:29:03.792Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/screens.cpp.o[2019-05-10T17:29:04.720Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/outputscreens.cpp.o[2019-05-10T17:29:04.720Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/shadow.cpp.o[2019-05-10T17:29:04.976Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/sm.cpp.o[2019-05-10T17:29:04.976Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/group.cpp.o[2019-05-10T17:29:05.232Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/manage.cpp.o[2019-05-10T17:29:05.569Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/overlaywindow.cpp.o[2019-05-10T17:29:05.876Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/activation.cpp.o[2019-05-10T17:29:05.876Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/useractions.cpp.o[2019-05-10T17:29:05.876Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/geometry.cpp.o[2019-05-10T17:29:06.174Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/rules.cpp.o[2019-05-10T17:29:06.750Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/composite.cpp.o[2019-05-10T17:29:07.311Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/toplevel.cpp.o[2019-05-10T17:29:07.311Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/unmanaged.cpp.o[2019-05-10T17:29:07.311Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scene.cpp.o[2019-05-10T17:29:07.568Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/screenlockerwatcher.cpp.o[2019-05-10T17:29:07.825Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/thumbnailitem.cpp.o[2019-05-10T17:29:09.196Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/deleted.cpp.o[2019-05-10T17:29:09.196Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/effects.cpp.o[2019-05-10T17:29:09.759Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/effectloader.cpp.o[2019-05-10T17:29:10.016Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/virtualdesktops.cpp.o[2019-05-10T17:29:10.273Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/xcbutils.cpp.o[2019-05-10T17:29:10.531Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/x11eventfilter.cpp.o[2019-05-10T17:29:10.532Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/logind.cpp.o[2019-05-10T17:29:11.097Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/virtualdesktops.cpp: In member function ���QString KWin::VirtualDesktopManager::name(uint) const���:[2019-05-10T17:29:11.097Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/virtualdesktops.cp

D21131: ScrollBar: Make it work as a horizontal scroll bar as well

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:f7f99e8b8ca4: ScrollBar: Make it work as a horizontal 
scroll bar as well (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21131?vs=57869&id=57879

REVISION DETAIL
  https://phabricator.kde.org/D21131

AFFECTED FILES
  org.kde.desktop/ScrollBar.qml

To: apol, #kirigami, mart, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21102: Mark "Connection Activated" notifications as low priority

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1ce4ea2f9af1: Mark "Connection Activated" 
notifications as low priority (authored by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21102?vs=57812&id=57877

REVISION DETAIL
  https://phabricator.kde.org/D21102

AFFECTED FILES
  kded/networkmanagement.notifyrc

To: ngraham, broulik, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21104: Port widget settings window to QQC2+Kirigami FormLayout

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:48543b1b1192: Port widget settings window to 
QQC2+Kirigami FormLayout (authored by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21104?vs=57815&id=57876

REVISION DETAIL
  https://phabricator.kde.org/D21104

AFFECTED FILES
  applet/contents/ui/configGeneral.qml

To: ngraham, #vdg, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 227 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/227/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 10 May 2019 15:42:30 +
 Build duration:
8 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 2532 lines...][2019-05-10T15:50:32.697Z] 4 warnings generated.[2019-05-10T15:50:32.697Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/options.cpp.o[2019-05-10T15:50:32.697Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/outline.cpp.o[2019-05-10T15:50:32.697Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/events.cpp.o[2019-05-10T15:50:32.697Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/killwindow.cpp.o[2019-05-10T15:50:33.275Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/geometrytip.cpp.o[2019-05-10T15:50:33.275Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/screens.cpp.o[2019-05-10T15:50:33.531Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/outputscreens.cpp.o[2019-05-10T15:50:34.155Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/shadow.cpp.o[2019-05-10T15:50:34.414Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/sm.cpp.o[2019-05-10T15:50:34.414Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/group.cpp.o[2019-05-10T15:50:34.414Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/manage.cpp.o[2019-05-10T15:50:34.414Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/overlaywindow.cpp.o[2019-05-10T15:50:34.680Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/activation.cpp.o[2019-05-10T15:50:34.939Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/useractions.cpp.o[2019-05-10T15:50:35.208Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/geometry.cpp.o[2019-05-10T15:50:35.208Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/rules.cpp.o[2019-05-10T15:50:35.467Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/composite.cpp.o[2019-05-10T15:50:36.055Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/toplevel.cpp.o[2019-05-10T15:50:36.315Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/unmanaged.cpp.o[2019-05-10T15:50:36.315Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/scene.cpp.o[2019-05-10T15:50:36.581Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/screenlockerwatcher.cpp.o[2019-05-10T15:50:36.581Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/useractions.cpp:351:22: warning: lambda capture 'p' is not used [-Wunused-lambda-capture][2019-05-10T15:50:36.581Z] [p] (QProcess::ProcessError e) {[2019-05-10T15:50:36.581Z]  ^[2019-05-10T15:50:36.848Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/thumbnailitem.cpp.o[2019-05-10T15:50:37.788Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/deleted.cpp.o[2019-05-10T15:50:38.055Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/effects.cpp.o[2019-05-10T15:50:38.055Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/effectloader.cpp.o[2019-05-10T15:50:38.055Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/virtualdesktops.cpp.o[2019-05-10T15:50:38.320Z] 1 warning generated.[2019-05-10T15:50:38.320Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/xcbutils.cpp.o[2019-05-10T15:50:38.899Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/x11eventfilter.cpp.o[2019-05-10T15:50:38.899Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/logind.cpp.o[2019-05-10T15:50:38.899Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/onscreennotification.cpp.o[2019-05-10T15:50:39.171Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/virtualdesktops.cpp:258:29: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare][2019-05-10T15:50:39.171Z] if (m_desktops.length() > desktop - 1) {[2019-05-10T15:50:39.171Z] ~~~ ^ ~~~[2019-05-10T15:50:39.429Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/osd.cpp.o[2019-05-10T15:50:39.695Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/screenedge.cpp.o[2019-05-10T15:50:39.952Z] 1 warning generated.[2019-05-10T15:50:39.952Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting.cpp.o[2019-05-10T15:50:39.952Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/workspace_wrapper.cpp.o[2019-05-10T15:50:39.952Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/meta.cpp.o[2019-05-10T15:50:40.219Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/scriptedeffect.cpp.o[2019-05-10T15:50:40.480Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/scriptingutils.cpp.o[2019-05-10T15:50:40.480Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/timer.cpp.o[2019-05-10T15:50:40.738Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting_model.cpp.o[2019-05-10T15:50:41.689Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/dbuscall.cpp.o[2019-05-10T15:50:41.689Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/screenedgeitem.cpp.o[2019-05-10T15:50:41.956Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting_logging.cpp.o[2019-05-10T15:50:41.9

D21082: Fix lid open/closed configurations

[Roman Gilg]

romangg added a comment.


  So your goal is to support the following use case: User wants to set 
different screens properties (for example positions) on the same screen 
arrangement for when the lid is closed and when it is opened.
  
  Correct? Had the lidOpenend mechanic this goal from the beginning or is this 
a new feature? To my understanding the lidOpenend mechanic does the following 
at the moment:
  
  1. Disable the internal display on closing the lid and reenable it when the 
lid is opened again.
  2. Restore displays values active, which were active, before the lid was 
closed when the lid is opened again.
  
  Function 2. is questionable. What if I move my external screens around while 
the lid is closed? Why should this become different for when the lid is opened 
again? With this logic the same holds the other way around. Why should the 
display positions of external screens become different just when I close the 
lid? It would make more sense to keep these display positions consistent 
independently of lid closed/opened and just reinsert the internal screen at a 
sensible / the old position. Can you explain why, as described in your test 
plan, it is sensible to have different display positions of external monitors 
for when having the lid opened and closed?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D21082

To: hoffmannrobert, broulik, #plasma
Cc: romangg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19603: Fix colours of header bar for active and inactive windows

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:df538d149294: Fix colours of header bar for acitve and 
inactive windows (authored by davidedmundson).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19603?vs=53398&id=57871

REVISION DETAIL
  https://phabricator.kde.org/D19603

AFFECTED FILES
  src/_functions.scss
  src/gtk320/widgets/_headerbar.scss
  src/render_assets.py

To: davidedmundson, #breeze, zzag, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21128: Improve keyboard navigation

[Aleix Pol Gonzalez]

apol updated this revision to Diff 57870.
apol added a comment.


  Remove unnecessary name

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21128?vs=57865&id=57870

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21128

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml
  src/delegaterecycler.cpp
  src/delegaterecycler.h

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D21128: Improve keyboard navigation

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> mart wrote in delegaterecycler.cpp:373
> this doesn't look right. especially because it will help with keyboard 
> navigation, but not with accessibility at all.
> 
> The proper solutuion should be make DelegateRecycler a FocusScope (and i 
> *think* setting activefocusontab to false tough not 100% sure now)

DelegateRecycler can't be a FocusScope itself because QQuickFocusScope is 
private API.

We could put it in a FocusScope but then this opens a can of worms WRT sizes.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D21128

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D21131: ScrollBar: Make it work as a horizontal scroll bar as well

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It was only taking into account the height so always working as vertical.
  This tracks the orientation property
  
  BUG: 390351

TEST PLAN
  Now case explained in the bug report works just fine, couldn't see any 
regressions.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21131

AFFECTED FILES
  org.kde.desktop/ScrollBar.qml

To: apol, #kirigami, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21129: Require KF5 5.58.0 like the rest of Plasma

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2a2e73781481: Require KF5 5.58.0 like the rest of Plasma 
(authored by heikobecker).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21129?vs=57866&id=57867

REVISION DETAIL
  https://phabricator.kde.org/D21129

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Looks really nice. I have yet to try it out, but following a code review.
  
  In general it is good practice to make class member variables private and 
have protected getters/setters if child classes need to interact with them. For 
example `TouchpadBackend::m_mode`. Other cases of that are all the properties 
in the child classes of LibinputCommon. Fixing that might be difficult though 
because of the template usage. And it might induce regressions in Wayland case, 
so I would wait with that for after next release. Some more ideas I wrote in 
the inline comments for that. But the m_mode thing can be changed already in 
this diff.

INLINE COMMENTS

> libinputcommon.h:1
> -/*
> - * Copyright 2017 Roman Gilg 
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, 
> USA.
> - */
> -
> -#ifndef KWINWAYLANDTOUCHPAD_H
> -#define KWINWAYLANDTOUCHPAD_H
> +#ifndef LIBINPUTCOMMON_H
> +#define LIBINPUTCOMMON_H

Needs copyright notice (you should of course add yourself to the notice for 
files with non-marginal changes).

> libinputtouchpad.h:54
> +bool supportsDisableEvents() const override {
> +return m_supportsDisableEvents.avail ? m_supportsDisableEvents.val : 
> false;
> +}

Equivalent and more concise is:
`return m_supportsDisableEvents.avail && m_supportsDisableEvents.val ;`
For other getters below as well.

Long term try to not access the member variables from child class though. You 
could just have these functions in the parent class and just always check if 
avail is true before accessing the value. This will change the behavior on 
Wayland backend as well, but it should be fine (let's do this after release 
though to not risk regressions).

> libinputtouchpad.h:57
> +bool isEnabled() const override {
> +return !m_enabled.val;
> +}

Why is there the negation? Put the Enabled-related function in the parent class.

> libinputtouchpad.h:65
> +bool supportsLeftHanded() const override {
> +return m_leftHanded.avail;
> +}

I get why you query the avail field of this and other properties in the X case 
and not the special property as on Wayland, but maybe there is a way to find a 
common approach for both?

Anyways stuff for after the release. It's fine this way at the moment.

> xlibtouchpad.h:48
>  {
> +Q_GADGET
> +

Necessary?

> touchpadconfiglibinput.h:35
>  explicit TouchpadConfigLibinput(TouchpadConfigContainer *parent,
> +TouchpadBackend* backend,
>  const QVariantList &args = QVariantList());

Pointer asterisk goes to the right.

> touchpadconfigplugin.h:32
>  public:
> -explicit TouchpadConfigPlugin(QWidget *parent);
> +explicit TouchpadConfigPlugin(QWidget *parent, TouchpadBackend* backend);
>  virtual ~TouchpadConfigPlugin() {}

No need for explicit anymore.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21128: Improve keyboard navigation

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> PrivateActionToolButton.qml:100
> +
> +readonly property var p0: Shortcut {
> +sequence: label.MnemonicData.sequence

why p0?

having another shortcut here isn't nice, but is kinda necessary since how the 
desktop style paints the text in the button background

just remove p0

> delegaterecycler.cpp:373
> +
> +bool DelegateRecycler::event(QEvent* event)
> +{

this doesn't look right. especially because it will help with keyboard 
navigation, but not with accessibility at all.

The proper solutuion should be make DelegateRecycler a FocusScope (and i 
*think* setting activefocusontab to false tough not 100% sure now)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D21128

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D21129: Require KF5 5.58.0 like the rest of Plasma

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21129

AFFECTED FILES
  CMakeLists.txt

To: heikobecker
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21128: Improve keyboard navigation

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Forward DelegateRecycler keyboard events to the actual delegate.
  Have PrivateActionToolButton trigger its action if the mnemonic is activated.
  
  BUG: 403711

TEST PLAN
  I can navigate into applications in Discover

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21128

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml
  src/delegaterecycler.cpp
  src/delegaterecycler.h

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D21111: Added new option to use GlobalProtect with openconnect

[Alejandro Valdes]

avaldes added a comment.


  In D2#463270 , @jgrulich wrote:
  
  > In D2#463216 , @avaldes 
wrote:
  >
  > > networkmanager-openconnect has added support in master for global protect 
,
 so now we can use it from plasma.
  > >
  > > This was tested in my machine with Plasma 5.15.5 and the lastest 
networkmanager-openconnect.
  > >
  > > The VPN works but I'm having an issue with  the existing configuration 
options:
  > >
  > > Unselecting the option "Use only for resources on this connection" in 
IPv4 > Routes doesn't work, I can access the network resources only available 
at the VPN but all my internet connections goes to the default internet route. 
I was able to solve this temporally by modifying the kernel routes. Is this 
intended?
  >
  >
  > Do you mean this change didn't apply and when you opened the configuration 
again was still selected? If the change did apply and after you open the 
configuration again it was set as it was supposed to be, then it's most likely 
a NM issue.
  >
  > > I also tried changing the priority of the VPN to 0 and the default 
network connection to 2 but it didn't work.
  >
  > It's autoconnect priority, this means that a connection with a higher 
priority will be automatically activated after restart instead of any other 
connection with a lower priority if available.
  
  
  No, my question is about VPN connectivity with NM, the connection is active 
but not all traffic goes through the VPN, I would expect that if that option in 
Routes (use only for resources of this network) should make the VPN as the main 
connection, but it doesn't.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D2

To: avaldes, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21111: Added new option to use GlobalProtect with openconnect

[Alejandro Valdes]

avaldes updated this revision to Diff 57861.
avaldes added a comment.


  - Changes based on code review

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2?vs=57837&id=57861

BRANCH
  globalprotect (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectprop.ui
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop

To: avaldes, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> kcm.cpp:527
> +
> +if (connection.isEmpty()) { // the "positive" part will arrive 
> with connectionAdded
> +// TODO display success

if (!connection.isEmpty()) {
  return;
  }

> connectionicon.cpp:403
>  }
> +} else if (type == 29) {  // TODO change to WireGuard enum 
> value once it is added
> +// WireGuard is a VPN but is not implemented

You can now use NetworkManager::Device::WireGuard.

> networkstatus.cpp:175
> +if (device && ((device->type() != 
> NetworkManager::Device::Generic && device->type() <= 
> NetworkManager::Device::Team)
> +   || device->type() == 29)) {  // TODO: Change to 
> WireGuard enum value when it is added
>  bool connecting = false;

You can use now NetworkManager::Device::WireGuard. It should be part of NMQT 
5.58 so we can use it for Plasma 5.16.

> wireguardinterfacewidget.cpp:620
> +}
> +if (!havePrivateKey || !haveAllowedIps || !havePublicKey || 
> !haveAllowedIps)
> +{

The "{" bracket should be on the same line with the "if"

> wireguardpeerwidget.cpp:52
> +
> +static WireGuardKeyValidator keyValidator(nullptr);
> +static SimpleIpListValidator allowedIPsValidator(nullptr, 
> SimpleIpListValidator::WithCidr,

You can change all the validators to take all the necessary parameters as first 
and then have a default value for the parent object so you don't need to pass a 
nullptr.

E.g.

  explicit SimpleIpV4AddressValidator(AddressStyle style = AddressStyle::Base, 
QObject *parent = nullptr);

I should have noticed this before. Can you change all the validators you use 
this way?

> wireguardpeerwidget.cpp:86
> +
> +WireGuardPeerWidget::WireGuardPeerWidget(const QVariantMap& peerData, 
> QWidget* parent, Qt::WindowFlags f)
> +: QDialog(parent, f)

WireGuardPeerWidget::WireGuardPeerWidget(const QVariantMap &peerData, QWidget 
*parent, Qt::WindowFlags f)

> wireguardpeerwidget.h:34
>  public:
> -explicit WireGuardAdvancedWidget(const NetworkManager::VpnSetting::Ptr 
> &setting, QWidget *parent = nullptr);
> -~WireGuardAdvancedWidget() override;
> -NetworkManager::VpnSetting::Ptr setting() const;
> +explicit WireGuardPeerWidget(const QVariantMap& peerData, QWidget* 
> parent = nullptr, Qt::WindowFlags f = {});
> +~WireGuardPeerWidget() override;

explicit WireGuardPeerWidget(const QVariantMap &peerData, QWidget *parent = 
nullptr, Qt::WindowFlags f = {});

> wireguardtabwidget.h:34
>  public:
> -explicit WireGuardAdvancedWidget(const NetworkManager::VpnSetting::Ptr 
> &setting, QWidget *parent = nullptr);
> -~WireGuardAdvancedWidget() override;
> -NetworkManager::VpnSetting::Ptr setting() const;
> +explicit WireGuardTabWidget(const NMVariantMapList& peerData, QWidget* 
> parent = nullptr, Qt::WindowFlags f = {});
> +~WireGuardTabWidget() override;

explicit WireGuardTabWidget(const NMVariantMapList &peerData, QWidget *parent = 
nullptr, Qt::WindowFlags f = {});

Sorry for being so pedantic :)

> wireguardtabwidget.h:39
> +
> +void loadConfig(const NMVariantMapList& peerData);
> +

void loadConfig(const NMVariantMapList &peerData);

> wireguardtabwidget.h:44
> +void slotAddPeer();
> +void slotAddPeerWithData(QVariantMap peerData);
> +void slotRemovePeer();

void slotAddPeerWithData(const QVariantMap &peerData);

> networkmodelitem.cpp:480
>  }
> -
> +// BAA Todo: add WireGuard
>  if (m_type == NetworkManager::ConnectionSettings::Wired) {

There is already WireGuard device in NMQT with KF5 5.58 which you should be 
able to use.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20943: Update tests cmake to WebEngine port

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:58770026d43a: Update tests cmake to WebEngine port 
(authored by davidedmundson).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20943?vs=57341&id=57855

REVISION DETAIL
  https://phabricator.kde.org/D20943

AFFECTED FILES
  tests/CMakeLists.txt

To: davidedmundson, #plasma, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19752: [Splash KCM] Use InlineMessage for testing error

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bbd7fcb3a300: [Splash KCM] Use InlineMessage for testing 
error (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19752?vs=53864&id=57850

REVISION DETAIL
  https://phabricator.kde.org/D19752

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, filipf
Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21111: Added new option to use GlobalProtect with openconnect

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> CMakeLists.txt:62
>  install(FILES plasmanetworkmanagement_openconnect_juniperui.desktop  
> DESTINATION ${KDE_INSTALL_KSERVICES5DIR})
> +install(FILES 
> plasmanetworkmanagement_openconnect_globalprotect.desktop  DESTINATION 
> ${KDE_INSTALL_KSERVICES5DIR})
>  else()

It should be named plasmanetworkmanagement_openconnect_globalprotectui.desktop 
for consistency with the rest of openconnect types.

> openconnectwidget.cpp:190
> +}
> +else if (dataMap[NM_OPENCONNECT_KEY_PROTOCOL] == QLatin1String("nc")) {
> +cmbProtocolIndex = 1;

Coding style, the "else if" should be on the same line as the "}" bracket.

> openconnectwidget.cpp:193
> +}
> +else {
> +cmbProtocolIndex = 2; // paloAlto/GlobalProtect (gp)

Same here.

> plasmanetworkmanagement_openconnect_globalprotect.desktop:17
> +X-KDE-PluginInfo-EnabledByDefault=false
> +Name=Palo Alto / Global Protect VPN (openconnect)
> +Comment=Compatible with Palo Alto Global Protect VPN

I would use what NM use:
PAN GlobalProtect (openconnect)

> plasmanetworkmanagement_openconnect_globalprotect.desktop:18
> +Name=Palo Alto / Global Protect VPN (openconnect)
> +Comment=Compatible with Palo Alto Global Protect VPN

Same here:
Compatible with PAN GlobalProtect SSL VPN

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D2

To: avaldes, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21111: Added new option to use GlobalProtect with openconnect

[Jan Grulich]

jgrulich added a comment.


  In D2#463216 , @avaldes wrote:
  
  > networkmanager-openconnect has added support in master for global protect 
,
 so now we can use it from plasma.
  >
  > This was tested in my machine with Plasma 5.15.5 and the lastest 
networkmanager-openconnect.
  >
  > The VPN works but I'm having an issue with  the existing configuration 
options:
  >
  > Unselecting the option "Use only for resources on this connection" in IPv4 
> Routes doesn't work, I can access the network resources only available at the 
VPN but all my internet connections goes to the default internet route. I was 
able to solve this temporally by modifying the kernel routes. Is this intended?
  
  
  Do you mean this change didn't apply and when you opened the configuration 
again was still selected? If the change did apply and after you open the 
configuration again it was set as it was supposed to be, then it's most likely 
a NM issue.
  
  > I also tried changing the priority of the VPN to 0 and the default network 
connection to 2 but it didn't work.
  
  It's autoconnect priority, this means that a connection with a higher 
priority will be automatically activated after restart instead of any other 
connection with a lower priority if available.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D2

To: avaldes, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21114: [Microphone Indicator] Avoid duplicate application names

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  VirtualBox grabs all recording devices and would show up multiple times.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D21114

AFFECTED FILES
  src/qml/microphoneindicator.cpp

To: broulik, #plasma, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21113: Allow hiding option items depending on available extension and version in the host

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We already have somewhat of a versioning system available in the host and it 
stores and exposes information about what extension it supports and in what 
version.
  This makes this information available to the options page and allows hiding 
elements using the `data-requires-extension="foo"` and 
`data-requires-extension-version-minimum="2"` attributes.
  This is for better compatibility when adding new features to the host which 
is released independently of the extension.
  Since the settings are still read and the items still added to the DOM, 
saving settings will not touch/change the enabled state of unsupported 
extensions should you use the extension on multiple computers with different 
versions of the host.

TEST PLAN
  Depends on D21112 
  
  - Added a new item with required extension attribute, didn't add it to the 
host, had the item successfully hidden
  - Added a new item with a required version of 2, had the item successfully 
hidden
  - Verified that saving would still write the enabled state correctly

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21113

AFFECTED FILES
  extension/extension.js
  extension/options.css
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21112: Support message response and reply callbacks

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This allows to make use of the sendReply/sendResponse callbacks allowing for 
the callee to reply directly without having to manually track state and relate 
a message to a reply.
  Also add a bit of documentation on the required callback signature.

TEST PLAN
  Sent a message with a callback, replied, got reply in callback.
  Returned true from a callback and stored the callback in a variable, did some 
processing, replied successfully at a later point.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21112

AFFECTED FILES
  extension/content-script.js
  extension/extension.js
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart