D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465361 , @ngraham wrote:
  
  > @atulbi This has caused a failure in the CI:
  >
  > 
https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console
  >
  >   09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 
SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal 
error: libinput-properties.h: No such file or directory
  >   09:12:41   #include 
  >   09:12:41^~~
  >   09:12:41  compilation terminated.
  >
  >
  > Looks like we need to make the libinput xorg dev package a mandatory dep 
(boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I 
know it's short notice but we branch in two days; do you think you could fix 
this? Thanks!
  
  
  Whoops...
  If it's just because of "libinput-properties.h", then we could replace all 
macros with their property name, then there is no need for 
libinput-properties.h .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM, visually.

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-notes-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21221

To: ngraham, #vdg, #plasma, GB_2, ndavis
Cc: ndavis, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[Nathaniel Graham]

ngraham updated this revision to Diff 58113.
ngraham added a comment.


  Revert one last unnecessary change

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21221?vs=58112=58113

BRANCH
  modernize-notes-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21221

AFFECTED FILES
  applets/notes/package/contents/ui/configAppearance.qml

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[Nathaniel Graham]

ngraham updated this revision to Diff 58112.
ngraham added a comment.


  Revert one unnecessary ID change

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21221?vs=58111=58112

BRANCH
  modernize-notes-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21221

AFFECTED FILES
  applets/notes/package/contents/ui/configAppearance.qml

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, GB_2.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Use GridView KCM component for the color chooser grid
  - Use standard import names
  - Port to QQC2
  
  Thanks to @gb_2 for providing the skeleton of this patch

TEST PLAN
  Everything works and color value is saved and loaded properly
  F6823455: Notes.png 

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-notes-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21221

AFFECTED FILES
  applets/notes/package/contents/ui/configAppearance.qml

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21193: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21193

To: ngraham, #vdg, #plasma, ndavis
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21194: [Holidays plugin] Port partially to QQC2 and modernize UI

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21194

To: ngraham, #vdg, #plasma, ndavis
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14147: Port from GConf to GSettings

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D14147#443705 , @kossebau wrote:
  
  > Seems this patch sadly broke the build on FreeBSD: 
https://build.kde.org/job/Plasma/view/Everything/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/18/
  
  
  Solved for now with fba8f7327aaf9869f2873068842970cabb1c8a0b 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: fvogt, kossebau, ngraham, pino, lbeltrame, evpokp, rikmills, broulik, 
asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/34/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 15 May 2019 03:27:19 +
 Build duration:
54 sec and counting

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Alright, LGTM then.

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframe-modernize-paths-category (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21191

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:e6ad673c26b2: [Media Frame] Port Paths 
category to QQC2+Kirigami and modernize UI (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21191?vs=58020=58110

REVISION DETAIL
  https://phabricator.kde.org/D21191

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigPaths.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

[Nathaniel Graham]

ngraham added a comment.


  Yeah pretty much. See the new virtual desktops KCM for example. The nice 
thing about adopting the same API everywhere is that it's easy to change at 
least!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21191

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

[Noah Davis]

ndavis added a comment.


  In D21191#465438 , @ngraham wrote:
  
  > It does on the desktop, yes. On mobile, it's always visible.
  
  
  Is this standard behavior now? If not, I'm not sure I like it.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21191

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21193: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:4b1607879f23: [Astronomical Calendar Plugin] Port to 
QQC2+Kirigami Formlayout (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21193?vs=58021=58108

REVISION DETAIL
  https://phabricator.kde.org/D21193

AFFECTED FILES
  plasmacalendarplugins/astronomical/config/qml/AstronomicalEventsConfig.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21189: [System tray] Modernize "Entries" category

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fc086efe7bd2: [System tray] Modernize Entries 
category (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21189?vs=58010=58107

REVISION DETAIL
  https://phabricator.kde.org/D21189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21194: [Holidays plugin] Port partially to QQC2 and modernize UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cde0e90b2eb1: [Holidays plugin] Port partially to QQC2 
and modernize UI (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21194?vs=58023=58106

REVISION DETAIL
  https://phabricator.kde.org/D21194

AFFECTED FILES
  plasmacalendarintegration/HolidaysConfig.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

[Nathaniel Graham]

ngraham added a comment.


  (`Kirigami.SwipeListItem` gives us that for free)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21191

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

[Nathaniel Graham]

ngraham added a comment.


  It does on the desktop, yes. On mobile, it's always visible.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21191

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21194: [Holidays plugin] Port partially to QQC2 and modernize UI

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  No visual changes, so LGTM

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-holidays-plugin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21194

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21189: [System tray] Modernize "Entries" category

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM, visually

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-entries-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21189

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21193: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM, visually

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-astronomical-calendar-plugin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21193

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

[Noah Davis]

ndavis added a comment.


  Does the button to remove items show up on hover? I don't see it anywhere.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21191

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21220: [Touchpad KCM] Fix libinput-less build and warnings

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8b1c894effa0: [Touchpad KCM] Fix libinput-less build and 
warnings (authored by romangg).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21220?vs=58100=58103

REVISION DETAIL
  https://phabricator.kde.org/D21220

AFFECTED FILES
  CMakeLists.txt
  config-X11.h.cmake
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.cpp

To: romangg, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21220: [Touchpad KCM] Fix libinput-less build and warnings

[Roman Gilg]

romangg updated this revision to Diff 58100.
romangg added a comment.


  Also include libinput header only when compiling with X.Org libinput.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21220?vs=58098=58100

BRANCH
  touchpadLibinputFixes

REVISION DETAIL
  https://phabricator.kde.org/D21220

AFFECTED FILES
  CMakeLists.txt
  config-X11.h.cmake
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.cpp

To: romangg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg added a comment.


  In D20186#465361 , @ngraham wrote:
  
  > @atulbi This has caused a failure in the CI:
  >
  > 
https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console
  >
  >   09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 
SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal 
error: libinput-properties.h: No such file or directory
  >   09:12:41   #include 
  >   09:12:41^~~
  >   09:12:41  compilation terminated.
  >
  >
  > Looks like we need to make the libinput xorg dev package a mandatory dep 
(boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I 
know it's short notice but we branch in two days; do you think you could fix 
this? Thanks!
  
  
  Of course we miss out again on these compilation corner cases... For that see 
D21220 .
  
  I found a grave issue now when testing though: Saved values are not restored 
on Reboot. Are they saved at all to a config file?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20859: Crash in sddmthemeinstaller invalid use of errorString

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:7df456404c26: Crash in sddmthemeinstaller invalid use of 
errorString (authored by johngehrig, committed by ngraham).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20859?vs=57581=58099

REVISION DETAIL
  https://phabricator.kde.org/D20859

AFFECTED FILES
  sddmthemeinstaller.cpp

To: johngehrig, ngraham, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  Oh, nevermind. I forgot I should be using `arc` indeed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D21220: [Touchpad KCM] Fix libinput-less build and warnings

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  If the X.Org libinput dev packages are not found, do not
  build the X11 libinput backend. This way the build succeeds.
  
  Fix also some minor warnings.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  touchpadLibinputFixes

REVISION DETAIL
  https://phabricator.kde.org/D21220

AFFECTED FILES
  CMakeLists.txt
  config-X11.h.cmake
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.cpp

To: romangg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Nathaniel Graham]

ngraham added a comment.


  What you need to do is rebase the branch for your patch on current master: 
`git pull --rebase origin master`
  
  Then fix up the merge  conflicts. Then run `arc diff` again.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  My parent commit was `169238848136`;  current master is `f8d5e1a2`. While on 
master, I am doing `git diff --summary  169238848136`. There is no intersection 
in changed files with my pull request. Still patch (as you aforementioned) can 
not be applied to master without tweaking.
  
  Am I missing something? Is `git diff` hiding something?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D14147: Port from GConf to GSettings

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> FindGIO.cmake:20
> +include(UsePkgConfig)
> +pkgconfig(gio-2.0 _LibGIOIncDir _LibGIOLinkDir _LibGIOLinkFlags 
> _LibGIOCflags)
> +endif(NOT WIN32)

It seems `_LibGIOLinkFlags`, `_LibGIOLinkDir` & `_LibGIOCflags` are not 
propagated  into the build. So if e.g. the libraries are not in default lib 
dir, linking will fail, cmp. 
https://build.kde.org/view/Failing/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/18/

Please give this another look & also compare with other pkgconfig() using Find' 
macros.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: fvogt, kossebau, ngraham, pino, lbeltrame, evpokp, rikmills, broulik, 
asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a subscriber: fvogt.
ngraham added a comment.


  @atulbi This has caused a failure in the CI:
  
  
https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console
  
09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 
SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal 
error: libinput-properties.h: No such file or directory
09:12:41   #include 
09:12:41^~~
09:12:41  compilation terminated.
  
  Looks like we need to make the libinput xorg package a mandatory dep (boo) or 
else not build the libinput module if it isn't found (preferred). I know it's 
short notice but we branch in two days; do you think you could fix this? Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Nathaniel Graham]

ngraham added a comment.


  I will review this, sorry it's taken so much time.
  
  I had to solve a minor merge conflict when rebasing this on master. Could you 
do that and update the patch? Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D20797: [dict] Modernize configuration window

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
filipf marked an inline comment as done.
Closed by commit R114:781e66cb2d05: [dict] Modernize configuration window 
(authored by filipf).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20797?vs=57813=58093

REVISION DETAIL
  https://phabricator.kde.org/D20797

AFFECTED FILES
  applets/dict/package/contents/config/config.qml
  applets/dict/package/contents/ui/ConfigDictionaries.qml

To: filipf, dfaure, ngraham, #vdg, #plasma, davidedmundson, mart
Cc: GB_2, mart, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes added a comment.


  In D16425#465321 , @ngraham wrote:
  
  > UI looks good enough for now. But is this the full diff? It seems like 
something got lost. The whole patch should include the changes from all commits 
in your branch, not just the last one.
  
  
  should be fixed now, I'm not sure what happened with arcanist.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes updated this revision to Diff 58091.
avaldes added a comment.


  Added new Suspend then Hibernate option
  

  
  Summary:
  See bug 399727  for a good 
description of what this code is for.
  The new ui will show a new option like the following image F6349860: 
screenshot.png 
  FEATURE: 399727
  
  Reviewers: broulik, ngraham
  
   
  
  Subscribers: soriano, abalaji, graesslin, ngraham, plasma-devel
  

  
  Tags: #plasma 
  

  
  Differential Revision: https://phabricator.kde.org/D16425

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16425?vs=58044=58091

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

AFFECTED FILES
  daemon/actions/bundled/suspendsession.cpp
  daemon/actions/bundled/suspendsession.h
  daemon/actions/bundled/suspendsessionconfig.cpp
  daemon/actions/bundled/suspendsessionconfig.h
  daemon/backends/upower/login1suspendjob.cpp
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/upowersuspendjob.cpp
  daemon/org.freedesktop.PowerManagement.xml
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilfdoconnector.cpp
  daemon/powerdevilfdoconnector.h
  daemon/powerdevilpowermanagement.cpp
  daemon/powerdevilpowermanagement.h

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Nathaniel Graham]

ngraham added a comment.


  UI looks good enough for now. But is this the full diff? It seems like 
something got lost. The whole patch should include the changes from all commits 
in your branch, not just the last one.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21176: PanelView: update mask on window on change of panelMask property

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f8d5e1a24e97: PanelView: update mask on window on change 
of panelMask property (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21176?vs=57974=58090

REVISION DETAIL
  https://phabricator.kde.org/D21176

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: kossebau, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 204 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 15:08:36 +
 Build duration:
4 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 5491 lines...][2019-05-14T15:12:41.608Z] Unknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to string[2019-05-14T15:12:41.608Z] Unknown property type for key "Categories" -> falling back to string[2019-05-14T15:12:41.608Z] Generated  "/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/fonts/kcm_fonts.json" [2019-05-14T15:12:41.608Z] [2019-05-14T15:12:41.865Z] [ 82%] Automatic MOC for target kaccess[2019-05-14T15:12:41.865Z] [ 82%] Automatic MOC for target kcm_fonts[2019-05-14T15:12:41.865Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/xlibbackend.h:30,[2019-05-14T15:12:41.865Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/xlibbackend.cpp:30:[2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/touchpadbackend.h: In member function ���virtual void TouchpadBackend::watchForEvents(bool)���:[2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/touchpadbackend.h:70:38: warning: unused parameter ���keyboard��� [-Wunused-parameter][2019-05-14T15:12:41.865Z]  virtual void watchForEvents(bool keyboard) {}[2019-05-14T15:12:41.865Z]  ~^~~~[2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/touchpadbackend.h: In member function ���virtual QStringList TouchpadBackend::listMouses(const QStringList&)���:[2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/touchpadbackend.h:72:55: warning: unused parameter ���blacklist��� [-Wunused-parameter][2019-05-14T15:12:41.865Z]  virtual QStringList listMouses(const QStringList ) {return QStringList();}[2019-05-14T15:12:41.865Z] ~~~^[2019-05-14T15:12:41.865Z] [ 82%] Built target kaccess_autogen[2019-05-14T15:12:41.865Z] [ 83%] Building CXX object kcms/keyboard/tests/CMakeFiles/keyboard_daemon_test.dir/__/flags.cpp.o[2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/synapticstouchpad.cpp:129:1: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant][2019-05-14T15:12:41.865Z]  };[2019-05-14T15:12:41.865Z]  ^[2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/synapticstouchpad.cpp:129:1: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant][2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/xlibbackend.cpp: In constructor ���XlibBackend::XlibBackend(QObject*)���:[2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/xlibbackend.cpp:77:28: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant][2019-05-14T15:12:41.865Z]  m_display(XOpenDisplay(0)), m_connection(0)[2019-05-14T15:12:41.865Z] ^[2019-05-14T15:12:41.865Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/xlibbackend.cpp:77:47: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant][2019-05-14T15:12:41.865Z]  m_display(XOpenDisplay(0)), m_connection(0)[2019-05-14T15:12:41.865Z]^[2019-05-14T15:12:42.122Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.h:25,[2019-05-14T15:12:42.122Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/xlibbackend.h:32,[2019-05-14T15:12:42.122Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/xlibbackend.cpp:30:[2019-05-14T15:12:42.122Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/libinputcommon.h: At global scope:[2019-05-14T15:12:42.122Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/libinputcommon.h:46:18: warning: ���T {anonymous}::valueLoaderPart(const QVariant&) [with T = QFlags]��� defined but not used [-Wunused-function][2019-05-14T15:12:42.122Z]  Qt::MouseButtons valueLoaderPart(QVariant const ) { return static_cast(reply.toInt()); }[2019-05-14T15:12:42.122Z]   

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ce84d6ab4bab: [libinput-touchpad-kcm] Use wayland 
specific touchpad KCM UI when libinput is… (authored by atulbi, committed by 
ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=58083=58084

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465278 , @ngraham wrote:
  
  > Are you ready for me to land this?
  
  
  Yeah \o/
  I'll take that for the next patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Are you ready for me to land this?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 58083.
atulbi added a comment.


  Set visible to false, until accel profiles are not supported.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=58082=58083

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  In D20186#465267 , @atulbi wrote:
  
  > Regarding acceleration profile, maybe we should set visible to false for 
now.
  
  
  +1, let's do that in this patch
  
  > If no touchpad is connected, we could also show a large icon in middle  
with "No touchpad Detected" written below it.
  
  +1, though maybe material for a follow-up patch if you don't think you can 
get that in today. I'd really like to get this landed today or tomorrow before 
Plasma 5.16 branches so it's in for the beta.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 58082.
atulbi added a comment.


  Finally no more greyed settings there \o/
  
  Work I've planned for future releases :
  
  - Adding support to disable horizontal scrolling on wayland.
  - Provide settings to Disable touchpad on external mouse.
  
  Regarding acceleration profile, maybe we should set visible to false for now.
  
  If no touchpad is connected, we could also show a large icon in middle  with 
"No touchpad Detected" written below it.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57933=58082

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 43 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/43/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 13:15:28 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report11%
(2/19)5%
(7/132)5%
(7/132)4%
(465/12644)2%
(179/8490)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskcm0%
(0/1)0%
(0/1)0%
(0/310)0%
(0/210)kded0%
(0/12)0%
(0/12)0%
(0/1281)0%
(0/940)libs0%
(0/4)0%
(0/4)0%
(0/851)0%
(0/456)libs.declarative0%
(0/6)0%
(0/6)0%
(0/592)0%
(0/451)libs.editor36%
(4/11)36%
(4/11)27%
(213/798)22%
(164/754)libs.editor.settings0%
(0/21)0%
(0/21)0%
(0/2946)0%
(0/1906)libs.editor.widgets0%
(0/17)0%
(0/17)0%
(0/981)0%
(0/424)libs.models0%
(0/8)0%
(0/8)0%
(0/1370)0%
(0/1161)tests100%
(3/3)100%
(3/3)100%
(252/252)63%
(15/24)vpn.fortisslvpn0%
(0/5)0%
(0/5)0%
(0/143)0%
(0/66)vpn.iodine0%
(0/4)0%
(0/4)0%
(0/96)0%
(0/36)vpn.l2tp0%
(0/6)0%
(0/6)0%
(0/341)0%
(0/175)vpn.openswan0%
(0/4)0%
(0/4)0%
(0/159)0%
(0/100)vpn.openvpn0%
(0/5)0%
(0/5)0%
(0/1224)0%
(0/1079)vpn.pptp0%
(0/5)0%
(0/5)0%
(0/207)0%
(0/89)vpn.ssh0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/131)vpn.sstp0%
(0/5)0%
(0/5)0%
(0/244)0%
(0/117)vpn.strongswan0%
(0/5)0%
(0/5)0%
(0/140)0%
(0/71)vpn.vpnc0%
(0/5)0%
 

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 42 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/42/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 13:06:27 +
 Build duration:
5 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 481 lines...][2019-05-14T13:10:50.851Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/settingwidget.cpp.o[2019-05-14T13:10:51.927Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ssidcombobox.cpp.o[2019-05-14T13:10:53.624Z] [ 26%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditorbase.cpp.o[2019-05-14T13:11:00.426Z] [ 26%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditordialog.cpp.o[2019-05-14T13:11:02.815Z] [ 27%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditortabwidget.cpp.o[2019-05-14T13:11:05.207Z] [ 27%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/listvalidator.cpp.o[2019-05-14T13:11:05.729Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleipv4addressvalidator.cpp.o[2019-05-14T13:11:07.527Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleipv6addressvalidator.cpp.o[2019-05-14T13:11:08.041Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleiplistvalidator.cpp.o[2019-05-14T13:11:10.108Z] [ 29%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/wireguardkeyvalidator.cpp.o[2019-05-14T13:11:10.108Z] [ 29%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/vpnuiplugin.cpp.o[2019-05-14T13:11:11.271Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/configuration.cpp.o[2019-05-14T13:11:13.661Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/debug.cpp.o[2019-05-14T13:11:16.049Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/uiutils.cpp.o[2019-05-14T13:11:16.558Z] [ 31%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/mobileconnectionwizard.cpp.o[2019-05-14T13:11:20.611Z] [ 31%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/mobileproviders.cpp.o[2019-05-14T13:11:22.304Z] [ 32%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/plasmanm_editor_autogen/mocs_compilation.cpp.o[2019-05-14T13:11:28.303Z] [ 32%] Linking CXX shared library ../../bin/libplasmanm_editor.so[2019-05-14T13:11:31.472Z] [ 32%] Built target plasmanm_editor[2019-05-14T13:11:31.472Z] Scanning dependencies of target simpleipv4test_autogen[2019-05-14T13:11:31.472Z] Scanning dependencies of target plasmanm_internal_autogen[2019-05-14T13:11:31.472Z] [ 33%] Automatic MOC for target simpleipv4test[2019-05-14T13:11:31.472Z] [ 34%] Automatic MOC for target plasmanm_internal[2019-05-14T13:11:31.472Z] [ 34%] Built target simpleipv4test_autogen[2019-05-14T13:11:31.987Z] Scanning dependencies of target simpleipv6test_autogen[2019-05-14T13:11:31.987Z] [ 35%] Automatic MOC for target simpleipv6test[2019-05-14T13:11:32.499Z] [ 35%] Built target simpleipv6test_autogen[2019-05-14T13:11:32.499Z] Scanning dependencies of target simpleiplisttest_autogen[2019-05-14T13:11:32.499Z] [ 35%] Automatic MOC for target simpleiplisttest[2019-05-14T13:11:33.014Z] [ 35%] Built target simpleiplisttest_autogen[2019-05-14T13:11:33.014Z] Scanning dependencies of target simpleipv4test[2019-05-14T13:11:33.014Z] [ 36%] Building CXX object tests/CMakeFiles/simpleipv4test.dir/simpleipv4test.cpp.o[2019-05-14T13:11:33.525Z] [ 36%] Built target plasmanm_internal_autogen[2019-05-14T13:11:33.525Z] Scanning dependencies of target simpleipv6test[2019-05-14T13:11:34.037Z] [ 36%] Building CXX object tests/CMakeFiles/simpleipv6test.dir/simpleipv6test.cpp.o[2019-05-14T13:11:35.121Z] /home/jenkins/workspace/Plasma/plasma-nm/kf5-qt5 SUSEQt5.12/tests/simpleipv4test.cpp: In constructor ���SimpleIpv4Test::SimpleIpv4Test()���:[2019-05-14T13:11:35.121Z] /home/jenkins/workspace/Plasma/plasma-nm/kf5-qt5 SUSEQt5.12/tests/simpleipv4test.cpp:49:71: error: no matching function for call to ���SimpleIpV4AddressValidator::SimpleIpV4AddressValidator(std::nullptr_t, SimpleIpV4AddressValidator::AddressStyle)���[2019-05-14T13:11:35.121Z]  , m_vp(nullptr, SimpleIpV4AddressValidator::AddressStyle::WithPort)[2019-05-14T13:11:35.121Z]^[2019-05-14T13:11:35.121Z] In file included from /home/jenkins/workspace/Plasma/plasma-nm/kf5-qt5 SUSEQt5.12/tests/simpleipv4test.cpp:21:[2019-05-14T13:11:35.121Z] /home/jenkins/workspace/Plasma/plasma-nm/kf5-qt5 SUSEQt5.12/libs/editor/simpleipv4addressvalidator.h:31:14: note: candidate: ���SimpleIpV4AddressValidator::SimpleIpV4AddressValidator(SimpleIpV4AddressValidator::AddressStyle, QObject*)���[2019-05-14T13:11:35.121Z]  explicit SimpleIpV4AddressValidator(AddressStyle style = AddressStyle::Base, QObject *parent 

D21188: Improve keyboard-only usage of the toolbar

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:56cb2c2b14c2: Improve keyboard-only usage of the toolbar 
(authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21188?vs=58009=58074

REVISION DETAIL
  https://phabricator.kde.org/D21188

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 41 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/41/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 12:24:19 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 460 lines...][2019-05-14T12:47:49.400Z] [ 18%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wificonnectionwidget.cpp.o[2019-05-14T12:47:49.972Z] [ 18%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wifisecurity.cpp.o[2019-05-14T12:47:49.972Z] [ 18%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wiredconnectionwidget.cpp.o[2019-05-14T12:47:50.229Z] [ 19%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wiredsecurity.cpp.o[2019-05-14T12:47:50.500Z] [ 19%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardinterfacewidget.cpp.o[2019-05-14T12:47:51.088Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardtabwidget.cpp.o[2019-05-14T12:47:52.508Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardpeerwidget.cpp.o[2019-05-14T12:47:54.471Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/advancedpermissionswidget.cpp.o[2019-05-14T12:47:54.471Z] [ 21%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/bssidcombobox.cpp.o[2019-05-14T12:47:54.471Z] [ 21%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/delegate.cpp.o[2019-05-14T12:47:54.471Z] [ 22%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/editlistdialog.cpp.o[2019-05-14T12:47:54.471Z] [ 22%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/hwaddrcombobox.cpp.o[2019-05-14T12:47:54.737Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/intdelegate.cpp.o[2019-05-14T12:47:55.007Z] /home/jenkins/workspace/Plasma/plasma-nm/kf5-qt5 SUSEQt5.12/libs/editor/settings/wireguardtabwidget.cpp:53:30: warning: ���WireGuardKeyValidator keyValidator()��� declared ���static��� but never defined [-Wunused-function][2019-05-14T12:47:55.007Z]  static WireGuardKeyValidator keyValidator();[2019-05-14T12:47:55.007Z]   ^~~~[2019-05-14T12:47:55.953Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv4delegate.cpp.o[2019-05-14T12:47:55.953Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv4routeswidget.cpp.o[2019-05-14T12:47:56.221Z] [ 24%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv6delegate.cpp.o[2019-05-14T12:47:56.484Z] [ 24%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv6routeswidget.cpp.o[2019-05-14T12:47:56.747Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/passwordfield.cpp.o[2019-05-14T12:47:56.747Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/settingwidget.cpp.o[2019-05-14T12:47:57.311Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ssidcombobox.cpp.o[2019-05-14T12:47:57.569Z] [ 26%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditorbase.cpp.o[2019-05-14T12:47:58.175Z] [ 26%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditordialog.cpp.o[2019-05-14T12:47:58.768Z] [ 27%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditortabwidget.cpp.o[2019-05-14T12:47:58.768Z] [ 27%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/listvalidator.cpp.o[2019-05-14T12:47:58.768Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleipv4addressvalidator.cpp.o[2019-05-14T12:47:58.768Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleipv6addressvalidator.cpp.o[2019-05-14T12:47:59.733Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleiplistvalidator.cpp.o[2019-05-14T12:48:00.298Z] [ 29%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/wireguardkeyvalidator.cpp.o[2019-05-14T12:48:03.622Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/plasmanm_editor_autogen/mocs_compilation.cpp.o[2019-05-14T12:48:06.927Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/mobileproviders.cpp.o[2019-05-14T12:48:08.869Z] [ 31%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/mobileconnectionwizard.cpp.o[2019-05-14T12:48:14.180Z] [ 31%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/uiutils.cpp.o[2019-05-14T12:48:17.459Z] [ 31%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/debug.cpp.o[2019-05-14T12:48:18.397Z] [ 32%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/configuration.cpp.o[2019-05-14T12:48:20.932Z] [ 32%] 

D21209: drop internal os-release class in favor of KOSRelease of kcoreaddons 5.58

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:a869a8b12f9a: drop internal os-release class in favor of 
KOSRelease of kcoreaddons 5.58 (authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21209?vs=58055=58067

REVISION DETAIL
  https://phabricator.kde.org/D21209

AFFECTED FILES
  Modules/about-distro/CMakeLists.txt
  Modules/about-distro/autotests/CMakeLists.txt
  Modules/about-distro/autotests/OSReleaseTest.cpp
  Modules/about-distro/autotests/data/os-release
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/OSRelease.cpp
  Modules/about-distro/src/OSRelease.h

To: sitter, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  I'm afraid the more we wait, the more code base is diverging, which will 
require more patches for this pull request to be accepted. Btw, I'm still stuck 
with pinning old version in my package manager.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D21209: drop internal os-release class in favor of KOSRelease of kcoreaddons 5.58

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  KOSRelease was based on our class so it is fully API compatible and doesn't
  require any changes besides different include and name

TEST PLAN
  builds + modules still loads os release data

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21209

AFFECTED FILES
  Modules/about-distro/CMakeLists.txt
  Modules/about-distro/autotests/CMakeLists.txt
  Modules/about-distro/autotests/OSReleaseTest.cpp
  Modules/about-distro/autotests/data/os-release
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/OSRelease.cpp
  Modules/about-distro/src/OSRelease.h

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:751f4da01b42: Update WireGuard to match NetworkManager 
1.16 interface (authored by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20930?vs=57983=58052#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57983=58052

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerwidget.ui
  libs/editor/settings/ui/wireguardtabwidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/settings/wireguardpeerwidget.h
  libs/editor/settings/wireguardtabwidget.cpp
  libs/editor/settings/wireguardtabwidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart