D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

[Björn Feber]

GB_2 added a comment.


  In D20549#466129 , @davidedmundson 
wrote:
  
  > What is "the rest" ?
  
  
  The open inline comments.

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D20549

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: davidedmundson, abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes added a comment.


  > This patch doesn't seem to work for me. I have Arch Linux, 
powerdevil-5.15.5-1 and your patch applied. After clicking the check-box the 
"Apply" button doesn't get active. Therefore, this setting is not being saved.
  
  Did you enable the Suspend Session option too? you need to enable the Suspend 
Session before using the new checkbox, it is the same behavior of "Even when an 
external monitor is connected" checkbox. Is a limitation on how powerdevil UI 
is built.
  
  > Also, why does the checkbox label say "While asleep, hibernate after 3 
hours"? This value can be overriden in /etc/systemd/sleep.conf
  
  It is the default timeout, there's no easy way to change it using a UI or a 
parameter, unless we want to point the users to modify a root-owned file.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: reverendhomer, meven, soriano, abalaji, graesslin, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Am I right that this can be closed as D17773 
 obsoletes this.
  
  Please reopen this if it's still relevant.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma, davidedmundson
Cc: davidedmundson, ngraham, gregormi, cfeck, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D18884: Workaround to prevent recursive handling of wakeup

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  > Under certain circumstances, Core::onResumingFromIdle triggers an action, 
which causes Core::resumingFromIdle to be emitted.
  
  Can you expand on what action causes resumingFromIdle to be emitted

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D18884

To: akreuzkamp, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18579: Rework Sensor Browser

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Marking as requst changes due till we get the minor comments from zzag done

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D18579

To: tcanabrava, davidedmundson
Cc: davidedmundson, zzag, argonel, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

[David Edmundson]

davidedmundson added a comment.


  > @broulik Do you want to commandeer this revision and do the rest?
  
  What is "the rest" ?

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D20549

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: davidedmundson, abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19865: Linux softraid: Define _GNU_SOURCE for pipe2

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Do you have commit access?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D19865

To: awilcox, #plasma, davidedmundson, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20901: Hide the new NNP column by default

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:7904e204a12c: Hide the new NNP column by default 
(authored by topimiettinen, committed by davidedmundson).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20901?vs=57198=58182

REVISION DETAIL
  https://phabricator.kde.org/D20901

AFFECTED FILES
  processui/ksysguardprocesslist.cpp

To: topimiettinen, broulik, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Generally I don't like things being blocked for no discernable reason. It 
makes toggling between two things order dependent.
  
  > If the user disables the last checkbox, all other checkboxes will 
automatically get enabled in the settings.
  
  Yeah, that's weird behaviour.
  
  Lets do this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21147: Null pointer dereference at ksysguard

[David Edmundson]

davidedmundson added a comment.


  > I don't know the procedure though; should I do anything?
  
  You can update a diff

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21147

To: gkaragiannidis
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21246: Search also legacy location for knsrc files

[Antonio Rojas]

arojas updated this revision to Diff 58177.
arojas added a comment.


  Actually remove the conditional since 5.16 depends on KF 5.58

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21246?vs=58176=58177

REVISION DETAIL
  https://phabricator.kde.org/D21246

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: arojas, leinir, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21246: Search also legacy location for knsrc files

[Antonio Rojas]

arojas created this revision.
arojas added reviewers: leinir, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Discover 5.16 beta only searches for knrsc files in the new 
/usr/share/knsrcfiles location, but most applications still install them to the 
legacy /etc/xdg location, so search there too.

TEST PLAN
  All categories are displayed instead of only a few of them

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21246

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: arojas, leinir, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Reverend Homer]

reverendhomer added a comment.


  Hi,
  
  In D16425#465325 , @avaldes wrote:
  
  > In D16425#465321 , @ngraham 
wrote:
  >
  > > UI looks good enough for now. But is this the full diff? It seems like 
something got lost. The whole patch should include the changes from all commits 
in your branch, not just the last one.
  >
  >
  > should be fixed now, I'm not sure what happened with arcanist.
  
  
  This patch doesn't seem to work for me. I have Arch Linux, 
powerdevil-5.15.5-1 and your patch applied. After clicking the check-box the 
"Apply" button doesn't get active. Therefore, this setting is not being saved.
  
  Also, why does the checkbox label say "While asleep, hibernate after 3 
hours"? This value can be overriden in /etc/systemd/sleep.conf

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: reverendhomer, meven, soriano, abalaji, graesslin, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/14/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 18:46:08 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(3/7)30%
(9/30)30%
(9/30)36%
(1184/3254)26%
(662/2513)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsconsole0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/74)kcm.src0%
(0/10)0%
(0/10)0%
(0/790)0%
(0/480)kcm.src.declarative0%
(0/4)0%
(0/4)0%
(0/498)0%
(0/440)kded63%
(5/8)63%
(5/8)53%
(568/1078)41%
(396/955)plasmoid0%
(0/2)0%
(0/2)0%
(0/39)0%
(0/10)tests.kded100%
(2/2)100%
(2/2)97%
(574/593)49%
(257/520)tests.osd100%
(2/2)100%
(2/2)60%
(42/70)26%
(9/34)

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/13/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 18:10:41 +
 Build duration:
4 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 457 lines...][2019-05-16T18:15:04.179Z] [ 30%] Building CXX object plasmoid/CMakeFiles/plasma_applet_kscreen.dir/plasma_applet_kscreen_autogen/mocs_compilation.cpp.o[2019-05-16T18:15:04.458Z] [ 31%] Building CXX object tests/osd/CMakeFiles/osdtest.dir/__/__/kded/osdaction.cpp.o[2019-05-16T18:15:04.752Z] Scanning dependencies of target kcm_kscreen[2019-05-16T18:15:04.752Z] [ 32%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/kcm_kscreen.cpp.o[2019-05-16T18:15:06.131Z] [ 33%] Building CXX object kded/CMakeFiles/kscreen.dir/serializer.cpp.o[2019-05-16T18:15:06.387Z] [ 34%] Building CXX object kded/CMakeFiles/kscreen.dir/generator.cpp.o[2019-05-16T18:15:06.648Z] [ 35%] Building CXX object tests/osd/CMakeFiles/osdtest.dir/__/__/kcm/src/utils.cpp.o[2019-05-16T18:15:06.648Z] [ 36%] Linking CXX shared module ../bin/plasma_applet_kscreen.so[2019-05-16T18:15:06.649Z] [ 37%] Linking CXX executable ../bin/kscreen-console[2019-05-16T18:15:06.928Z] [ 38%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/declarative/qmlscreen.cpp.o[2019-05-16T18:15:06.928Z] [ 40%] Building CXX object kded/CMakeFiles/kscreen.dir/osd.cpp.o[2019-05-16T18:15:06.928Z] [ 40%] Building CXX object kded/CMakeFiles/kscreen.dir/device.cpp.o[2019-05-16T18:15:06.928Z] [ 41%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/declarative/qmloutput.cpp.o[2019-05-16T18:15:07.198Z] [ 41%] Built target kscreen-console[2019-05-16T18:15:07.198Z] [ 42%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/declarative/qmloutputcomponent.cpp.o[2019-05-16T18:15:07.463Z] [ 42%] Built target plasma_applet_kscreen[2019-05-16T18:15:07.463Z] [ 43%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/declarative/qmlscreen.cpp.o[2019-05-16T18:15:07.730Z] [ 44%] Building CXX object kded/CMakeFiles/kscreen.dir/osdmanager.cpp.o[2019-05-16T18:15:09.190Z] [ 45%] Building CXX object tests/osd/CMakeFiles/osdtest.dir/osdtest_autogen/mocs_compilation.cpp.o[2019-05-16T18:15:09.458Z] [ 46%] Building CXX object kded/CMakeFiles/kscreen.dir/osdaction.cpp.o[2019-05-16T18:15:09.725Z] [ 47%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/controlpanel.cpp.o[2019-05-16T18:15:09.725Z] [ 48%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/controlpanel.cpp.o[2019-05-16T18:15:09.991Z] [ 48%] Building CXX object kded/CMakeFiles/kscreen.dir/__/kcm/src/utils.cpp.o[2019-05-16T18:15:10.957Z] [ 49%] Linking CXX executable ../../bin/osdtest[2019-05-16T18:15:11.221Z] [ 50%] Building CXX object kded/CMakeFiles/kscreen.dir/kscreen_daemon_debug.cpp.o[2019-05-16T18:15:11.221Z] [ 51%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/outputconfig.cpp.o[2019-05-16T18:15:11.221Z] [ 52%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/unifiedoutputconfig.cpp.o[2019-05-16T18:15:11.221Z] [ 53%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/resolutionslider.cpp.o[2019-05-16T18:15:11.221Z] [ 54%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/utils.cpp.o[2019-05-16T18:15:11.221Z] [ 55%] Building CXX object kded/CMakeFiles/kscreen.dir/freedesktop_interface.cpp.o[2019-05-16T18:15:12.175Z] [ 55%] Built target osdtest[2019-05-16T18:15:12.175Z] [ 56%] Building CXX object kded/CMakeFiles/kscreen.dir/kscreenadaptor.cpp.o[2019-05-16T18:15:12.440Z] [ 57%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/widget.cpp.o[2019-05-16T18:15:12.440Z] [ 58%] Building CXX object kded/CMakeFiles/kscreen.dir/kscreen_autogen/mocs_compilation.cpp.o[2019-05-16T18:15:12.440Z] [ 59%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/previewwidget.cpp.o[2019-05-16T18:15:12.705Z] [ 60%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/outputconfig.cpp.o[2019-05-16T18:15:12.969Z] [ 61%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/unifiedoutputconfig.cpp.o[2019-05-16T18:15:13.236Z] [ 62%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/resolutionslider.cpp.o[2019-05-16T18:15:13.236Z] [ 63%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/utils.cpp.o[2019-05-16T18:15:13.501Z] [ 64%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/widget.cpp.o[2019-05-16T18:15:13.768Z] [ 65%] Building CXX object kcm/src/CMakeFiles/kcm_kscreen.dir/previewwidget.cpp.o[2019-05-16T18:15:13.768Z] [ 66%] Linking CXX shared module ../bin/kscreen.so[2019-05-16T18:15:14.344Z] [ 67%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/scalingconfig.cpp.o[2019-05-16T18:15:14.344Z] [ 68%] Building CXX object kcm/src/CMakeFiles/kcm_testapp.dir/kcm_screen_debug.cpp.o[2019-05-16T18:15:14.344Z] [ 68%] Built target kscreen[2019-05-16T18:15:14.344Z] [ 69%] Building CXX object 

D21228: [Touchpad KCM] Load previous setting on reboot

[Atul Bisht]

atulbi added a comment.


  Thank you so much for fixing it.
  Wanted it to on beta.

INLINE COMMENTS

> romangg wrote in libinputtouchpad.cpp:426
> Why this write back? What's configProps.

Yeah realized later that there is no need to write config here. So no need for 
configProps. Should I open a new patch for removing it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: romangg, ngraham, davidedmundson, atulbi
Cc: fvogt, davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[Powerdevil] [Bug 189456] powerdevil should not suspend when computer is being shutdown

[Manuel López-Ibáñez]

https://bugs.kde.org/show_bug.cgi?id=189456

Manuel López-Ibáñez  changed:

   What|Removed |Added

 CC||lopeziba...@gmail.com

--- Comment #30 from Manuel López-Ibáñez  ---
(In reply to Sascha Zenglein from comment #29)
> still happens to me...
> 
> systemd-inhibit --list tells that PowerDevil has a block on all the events,
> so I can't workaround this by setting LidSwitchIgnoreInhibited=no in
> /etc/systemd/logind.conf

I opened a new report in
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1829404

Please join that bug report if you still suffer from this (like I do).

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/20/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 14:08:19 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 15 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/15/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 14:08:17 +
 Build duration:
9 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2578)14%
(212/1499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/255)0%
(0/134)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/218)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/26/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 14:08:16 +
 Build duration:
4 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4010)0%
(0/2728)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1416)0%
(0/1104)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/806)0%
(0/470)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/221)0%
(0/114)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1019)0%
(0/759)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/196)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 31 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/31/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 14:08:15 +
 Build duration:
3 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/20)0%
(0/20)0%
(0/1692)0%
(0/649)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/273)0%
(0/126)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/100)0%
(0/25)classic0%
(0/2)0%
(0/2)0%
(0/187)0%
(0/52)core0%
(0/9)0%
(0/9)0%
(0/502)0%
(0/236)icons0%
(0/3)0%
(0/3)0%
(0/241)0%
(0/48)sidebar0%
(0/1)0%
(0/1)0%
(0/288)0%
(0/133)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/29)

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.12/39/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 13:20:23 +
 Build duration:
38 min and counting

Plasma 5.16 branched

[Jonathan Riddell]

I have branched master into Plasma/5.16 for the released git repos

bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi
kactivitymanagerd kde-cli-tools kdecoration kde-gtk-config kdeplasma-addons
kgamma5 khotkeys kinfocenter kmenuedit kscreen kscreenlocker ksshaskpass
ksysguard kwallet-pam kwayland-integration kwin kwrited libkscreen
libksysguard milou oxygen plasma-browser-integration plasma-desktop
plasma-integration plasma-nm plasma-pa plasma-sdk plasma-tests plasma-vault
plasma-workspace plasma-workspace-wallpapers plymouth-kcm
polkit-kde-agent-1 powerdevil sddm-kcm systemsettings user-manager
xdg-desktop-portal-kde

Please make bug fixes in Plasma/5.16 for the next 3 weeks until tars and
tags are made on June 6.

Jonathan

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/25/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 13:20:10 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 258 lines...][2019-05-16T13:34:27.290Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/25/display/redirect'[2019-05-16T13:34:27.290Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-05-16T13:34:27.290Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12'[2019-05-16T13:34:27.290Z] HUDSON_URL= 'https://build.kde.org/'[2019-05-16T13:34:27.290Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-05-16T13:34:27.290Z] NODE_NAME = 'Docker Swarm-0dfac5b747cc'[2019-05-16T13:34:27.290Z] HOST  = '0dfac5b747cc'[2019-05-16T13:34:27.290Z] LESSOPEN  = 'lessopen.sh %s'[2019-05-16T13:34:27.290Z] USER  = 'jenkins'[2019-05-16T13:34:27.290Z] MORE  = '-sl'[2019-05-16T13:34:27.290Z] CSHEDIT   = 'emacs'[2019-05-16T13:34:27.290Z] SHLVL = '2'[2019-05-16T13:34:27.290Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-kf5-qt5 SUSEQt5.12-25'[2019-05-16T13:34:27.290Z] WINDOWMANAGER = 'xterm'[2019-05-16T13:34:27.290Z] PAGER = 'less'[2019-05-16T13:34:27.290Z] EXECUTOR_NUMBER   = '0'[2019-05-16T13:34:27.290Z] CVS_RSH   = 'ssh'[2019-05-16T13:34:27.290Z] LIBGL_DEBUG   = 'quiet'[2019-05-16T13:34:27.290Z] STAGE_NAME= 'Configuring Build'[2019-05-16T13:34:27.290Z] NODE_LABELS   = 'Docker Swarm-0dfac5b747cc SUSEQt5.12'[2019-05-16T13:34:27.290Z] XCURSOR_THEME = 'DMZ-Black'[2019-05-16T13:34:27.290Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-05-16T13:34:27.290Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-05-16T13:34:27.290Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-05-16T13:34:27.290Z] PROFILEREAD   = 'true'[2019-05-16T13:34:27.290Z] MAIL  = '/var/mail/jenkins'[2019-05-16T13:34:27.290Z] HOSTTYPE  = 'x86_64'[2019-05-16T13:34:27.290Z] BUILD_ID  = '25'[2019-05-16T13:34:27.290Z] LESSKEY   = '/etc/lesskey.bin'[2019-05-16T13:34:27.290Z] OLDPWD= '/home/jenkins'[2019-05-16T13:34:27.290Z] LC_CTYPE  = 'C.UTF-8'[2019-05-16T13:34:27.290Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-16T13:34:27.290Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-05-16T13:34:27.290Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-05-16T13:34:27.290Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-05-16T13:34:27.290Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-05-16T13:34:27.290Z] QT_SELECT = 'qt5'[2019-05-16T13:34:27.290Z] LANG  = 'en_US.UTF-8'[2019-05-16T13:34:27.290Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-16T13:34:27.290Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-05-16T13:34:27.290Z] [2019-05-16T13:34:27.290Z] [2019-05-16T13:34:27.290Z] == Commencing Configuration:[2019-05-16T13:34:27.290Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12"[2019-05-16T13:34:27.791Z] -- The C compiler identification is GNU 8.3.1[2019-05-16T13:34:28.292Z] -- The CXX compiler identification is GNU 8.3.1[2019-05-16T13:34:28.292Z] -- Check for working C compiler: /usr/bin/cc[2019-05-16T13:34:28.292Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-16T13:34:28.292Z] -- Detecting C compiler ABI info[2019-05-16T13:34:28.793Z] -- Detecting C compiler ABI info - done[2019-05-16T13:34:28.793Z] -- Detecting C compile features[2019-05-16T13:34:29.294Z] -- Detecting C compile features - done[2019-05-16T13:34:29.794Z] -- Check for working CXX compiler: /usr/bin/c++[2019-05-16T13:34:29.794Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-05-16T13:34:29.794Z] -- Detecting CXX compiler ABI info[2019-05-16T13:34:30.294Z] -- Detecting CXX compiler ABI info - done[2019-05-16T13:34:30.294Z] -- Detecting CXX compile 

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 30 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/30/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 13:20:23 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 263 lines...][2019-05-16T13:33:37.201Z] NODE_NAME = 'Docker Swarm-1cf6987ef6f3'[2019-05-16T13:33:37.201Z] HOST  = '1cf6987ef6f3'[2019-05-16T13:33:37.201Z] LESSOPEN  = 'lessopen.sh %s'[2019-05-16T13:33:37.201Z] USER  = 'jenkins'[2019-05-16T13:33:37.201Z] MORE  = '-sl'[2019-05-16T13:33:37.201Z] CSHEDIT   = 'emacs'[2019-05-16T13:33:37.201Z] SHLVL = '2'[2019-05-16T13:33:37.201Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-kf5-qt5 SUSEQt5.12-30'[2019-05-16T13:33:37.201Z] WINDOWMANAGER = 'xterm'[2019-05-16T13:33:37.201Z] PAGER = 'less'[2019-05-16T13:33:37.201Z] EXECUTOR_NUMBER   = '0'[2019-05-16T13:33:37.201Z] CVS_RSH   = 'ssh'[2019-05-16T13:33:37.201Z] LIBGL_DEBUG   = 'quiet'[2019-05-16T13:33:37.201Z] STAGE_NAME= 'Configuring Build'[2019-05-16T13:33:37.201Z] NODE_LABELS   = 'Docker Swarm-1cf6987ef6f3 SUSEQt5.12'[2019-05-16T13:33:37.201Z] XCURSOR_THEME = 'DMZ-Black'[2019-05-16T13:33:37.201Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-05-16T13:33:37.201Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-05-16T13:33:37.201Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-05-16T13:33:37.201Z] PROFILEREAD   = 'true'[2019-05-16T13:33:37.201Z] MAIL  = '/var/mail/jenkins'[2019-05-16T13:33:37.201Z] HOSTTYPE  = 'x86_64'[2019-05-16T13:33:37.201Z] BUILD_ID  = '30'[2019-05-16T13:33:37.201Z] LESSKEY   = '/etc/lesskey.bin'[2019-05-16T13:33:37.201Z] OLDPWD= '/home/jenkins'[2019-05-16T13:33:37.201Z] LC_CTYPE  = 'C.UTF-8'[2019-05-16T13:33:37.201Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-16T13:33:37.201Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-05-16T13:33:37.201Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-05-16T13:33:37.201Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-05-16T13:33:37.201Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-05-16T13:33:37.201Z] QT_SELECT = 'qt5'[2019-05-16T13:33:37.201Z] LANG  = 'en_US.UTF-8'[2019-05-16T13:33:37.201Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-16T13:33:37.201Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-05-16T13:33:37.201Z] [2019-05-16T13:33:37.201Z] [2019-05-16T13:33:37.201Z] == Commencing Configuration:[2019-05-16T13:33:37.201Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12"[2019-05-16T13:33:40.474Z] -- The C compiler identification is GNU 8.3.1[2019-05-16T13:33:40.474Z] -- The CXX compiler identification is GNU 8.3.1[2019-05-16T13:33:40.474Z] -- Check for working C compiler: /usr/bin/cc[2019-05-16T13:33:42.156Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-16T13:33:42.156Z] -- Detecting C compiler ABI info[2019-05-16T13:33:42.156Z] -- Detecting C compiler ABI info - done[2019-05-16T13:33:42.156Z] -- Detecting C compile features[2019-05-16T13:33:46.328Z] -- Detecting C compile features - done[2019-05-16T13:33:46.328Z] -- Check for working CXX compiler: /usr/bin/c++[2019-05-16T13:33:46.328Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-05-16T13:33:46.328Z] -- Detecting CXX compiler ABI info[2019-05-16T13:33:46.585Z] -- Detecting CXX compiler ABI info - done[2019-05-16T13:33:46.585Z] -- Detecting CXX compile features[2019-05-16T13:33:47.518Z] -- Detecting CXX compile features - done[2019-05-16T13:33:47.518Z] -- Looking for __GLIBC__[2019-05-16T13:33:47.791Z] -- Looking for __GLIBC__ - found[2019-05-16T13:33:47.791Z] -- Performing Test _OFFT_IS_64BIT[2019-05-16T13:33:47.791Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-05-16T13:33:47.791Z] -- Performing Test HAVE_DATE_TIME[2019-05-16T13:33:48.049Z] -- Performing Test HAVE_DATE_TIME - Success[2019-05-16T13:33:48.049Z] -- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/19/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 13:16:27 +
 Build duration:
5 min 58 sec and counting
   CONSOLE OUTPUT
  [...truncated 190 lines...][2019-05-16T13:22:22.563Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-05-16T13:22:22.563Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/display/redirect'[2019-05-16T13:22:22.563Z] MAIL  = '/var/mail/jenkins'[2019-05-16T13:22:22.563Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/19/display/redirect?page=changes'[2019-05-16T13:22:22.563Z] JENKINS_URL   = 'https://build.kde.org/'[2019-05-16T13:22:22.563Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-05-16T13:22:22.563Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.12'[2019-05-16T13:22:22.563Z] HUDSON_HOME   = '/home/production/data'[2019-05-16T13:22:22.563Z] BUILD_ID  = '19'[2019-05-16T13:22:22.563Z] OLDPWD= '/usr/home/jenkins'[2019-05-16T13:22:22.563Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12'[2019-05-16T13:22:22.563Z] _ = '/usr/local/bin/java'[2019-05-16T13:22:22.563Z] TERM  = 'su'[2019-05-16T13:22:22.563Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.12'[2019-05-16T13:22:22.563Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 FreeBSDQt5.12-19'[2019-05-16T13:22:22.563Z] BUILD_DISPLAY_NAME= '#19'[2019-05-16T13:22:22.563Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/19/display/redirect'[2019-05-16T13:22:22.563Z] USER  = 'jenkins'[2019-05-16T13:22:22.563Z] HOME  = '/home/jenkins'[2019-05-16T13:22:22.563Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/19/'[2019-05-16T13:22:22.563Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/'[2019-05-16T13:22:22.563Z] HUDSON_URL= 'https://build.kde.org/'[2019-05-16T13:22:22.563Z] SHELL = '/usr/local/bin/bash'[2019-05-16T13:22:22.563Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12'[2019-05-16T13:22:22.563Z] MM_CHARSET= 'UTF-8'[2019-05-16T13:22:22.563Z] STAGE_NAME= 'Configuring Build'[2019-05-16T13:22:22.563Z] NODE_NAME = 'FreeBSD Builder 1'[2019-05-16T13:22:22.563Z] BLOCKSIZE = 'K'[2019-05-16T13:22:22.563Z] EXECUTOR_NUMBER   = '0'[2019-05-16T13:22:22.563Z] SHLVL = '0'[2019-05-16T13:22:22.563Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-16T13:22:22.563Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-05-16T13:22:22.563Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-05-16T13:22:22.819Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-05-16T13:22:22.819Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-05-16T13:22:22.819Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-05-16T13:22:22.819Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-05-16T13:22:22.819Z] QT_SELECT = 'qt5'[2019-05-16T13:22:22.819Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-16T13:22:22.819Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-05-16T13:22:22.819Z] [2019-05-16T13:22:22.819Z] [2019-05-16T13:22:22.819Z] == Commencing Configuration:[2019-05-16T13:22:22.819Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12"[2019-05-16T13:22:22.819Z] -- The C compiler identification is Clang 6.0.1[2019-05-16T13:22:22.819Z] -- The CXX compiler identification is Clang 6.0.1[2019-05-16T13:22:22.819Z] -- Check for working C compiler: /usr/bin/cc[2019-05-16T13:22:23.081Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-16T13:22:23.081Z] -- Detecting C compiler ABI info[2019-05-16T13:22:23.081Z] -- Detecting C compiler ABI info - 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 14 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/14/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 13:16:27 +
 Build duration:
3 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 255 lines...][2019-05-16T13:19:49.324Z] OSTYPE= 'linux'[2019-05-16T13:19:49.324Z] JOB_NAME  = 'Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2019-05-16T13:19:49.324Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-05-16T13:19:49.324Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/14/display/redirect'[2019-05-16T13:19:49.324Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-05-16T13:19:49.324Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2019-05-16T13:19:49.324Z] HUDSON_URL= 'https://build.kde.org/'[2019-05-16T13:19:49.324Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-05-16T13:19:49.324Z] NODE_NAME = 'Docker Swarm-33ebfc438d4f'[2019-05-16T13:19:49.324Z] HOST  = '33ebfc438d4f'[2019-05-16T13:19:49.324Z] LESSOPEN  = 'lessopen.sh %s'[2019-05-16T13:19:49.324Z] USER  = 'jenkins'[2019-05-16T13:19:49.324Z] MORE  = '-sl'[2019-05-16T13:19:49.324Z] CSHEDIT   = 'emacs'[2019-05-16T13:19:49.324Z] SHLVL = '2'[2019-05-16T13:19:49.324Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 SUSEQt5.12-14'[2019-05-16T13:19:49.324Z] WINDOWMANAGER = 'xterm'[2019-05-16T13:19:49.324Z] PAGER = 'less'[2019-05-16T13:19:49.324Z] EXECUTOR_NUMBER   = '0'[2019-05-16T13:19:49.324Z] CVS_RSH   = 'ssh'[2019-05-16T13:19:49.324Z] LIBGL_DEBUG   = 'quiet'[2019-05-16T13:19:49.324Z] STAGE_NAME= 'Configuring Build'[2019-05-16T13:19:49.324Z] NODE_LABELS   = 'Docker Swarm-33ebfc438d4f SUSEQt5.12'[2019-05-16T13:19:49.324Z] XCURSOR_THEME = 'DMZ-Black'[2019-05-16T13:19:49.324Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-05-16T13:19:49.324Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-05-16T13:19:49.324Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-05-16T13:19:49.324Z] PROFILEREAD   = 'true'[2019-05-16T13:19:49.324Z] MAIL  = '/var/mail/jenkins'[2019-05-16T13:19:49.324Z] HOSTTYPE  = 'x86_64'[2019-05-16T13:19:49.324Z] BUILD_ID  = '14'[2019-05-16T13:19:49.324Z] LESSKEY   = '/etc/lesskey.bin'[2019-05-16T13:19:49.324Z] OLDPWD= '/home/jenkins'[2019-05-16T13:19:49.324Z] LC_CTYPE  = 'C.UTF-8'[2019-05-16T13:19:49.324Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-16T13:19:49.324Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-05-16T13:19:49.324Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-05-16T13:19:49.324Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-05-16T13:19:49.324Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-05-16T13:19:49.324Z] QT_SELECT = 'qt5'[2019-05-16T13:19:49.324Z] LANG  = 'en_US.UTF-8'[2019-05-16T13:19:49.324Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-16T13:19:49.324Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-05-16T13:19:49.324Z] [2019-05-16T13:19:49.324Z] [2019-05-16T13:19:49.324Z] == Commencing Configuration:[2019-05-16T13:19:49.324Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12"[2019-05-16T13:19:50.987Z] -- The C compiler identification is GNU 8.3.1[2019-05-16T13:19:52.038Z] -- The CXX compiler identification is GNU 8.3.1[2019-05-16T13:19:52.038Z] -- Check for working C compiler: /usr/bin/cc[2019-05-16T13:19:52.537Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-16T13:19:52.537Z] -- Detecting C compiler ABI info[2019-05-16T13:19:52.537Z] -- Detecting C compiler ABI info - done[2019-05-16T13:19:52.537Z] -- Detecting C compile features[2019-05-16T13:19:53.036Z] -- Detecting C compile features - done[2019-05-16T13:19:53.036Z] -- Check for working CXX compiler: /usr/bin/c++[2019-05-16T13:19:53.534Z] -- Check for working CXX 

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 25 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/25/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 16 May 2019 13:16:20 +
 Build duration:
3 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 221 lines...][2019-05-16T13:19:28.878Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-05-16T13:19:28.878Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-05-16T13:19:28.878Z] PROCESSOR_LEVEL   = '6'[2019-05-16T13:19:28.878Z] PROCESSOR_REVISION= '5e03'[2019-05-16T13:19:28.878Z] PROGRAMDATA   = 'C:\ProgramData'[2019-05-16T13:19:28.878Z] PROGRAMFILES  = 'C:\Program Files'[2019-05-16T13:19:28.878Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-05-16T13:19:28.878Z] PROGRAMW6432  = 'C:\Program Files'[2019-05-16T13:19:28.878Z] PROMPT= '$P$G'[2019-05-16T13:19:28.878Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-05-16T13:19:28.878Z] PUBLIC= 'C:\Users\Public'[2019-05-16T13:19:28.878Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/25/display/redirect?page=changes'[2019-05-16T13:19:28.878Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/25/display/redirect'[2019-05-16T13:19:28.878Z] STAGE_NAME= 'Configuring Build'[2019-05-16T13:19:28.878Z] SYSTEMDRIVE   = 'C:'[2019-05-16T13:19:28.878Z] SYSTEMROOT= 'C:\WINDOWS'[2019-05-16T13:19:28.878Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-05-16T13:19:28.878Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-05-16T13:19:28.878Z] UCRTVERSION   = '10.0.17763.0'[2019-05-16T13:19:28.878Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-05-16T13:19:28.878Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-05-16T13:19:28.878Z] USERNAME  = 'Jenkins'[2019-05-16T13:19:28.878Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-05-16T13:19:28.878Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-05-16T13:19:28.878Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-05-16T13:19:28.878Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-05-16T13:19:28.878Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-05-16T13:19:28.878Z] VCTOOLSVERSION= '14.16.27023'[2019-05-16T13:19:28.878Z] VISUALSTUDIOVERSION   = '16.0'[2019-05-16T13:19:28.878Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-05-16T13:19:28.878Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-05-16T13:19:28.878Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-05-16T13:19:28.878Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-05-16T13:19:28.878Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-05-16T13:19:28.878Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-05-16T13:19:28.878Z] VSCMD_VER = '16.0.3'[2019-05-16T13:19:28.878Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-05-16T13:19:28.878Z] WINDIR= 'C:\WINDOWS'[2019-05-16T13:19:28.878Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-05-16T13:19:28.878Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-05-16T13:19:28.878Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-05-16T13:19:28.878Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-05-16T13:19:28.878Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-05-16T13:19:28.878Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-05-16T13:19:28.878Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-05-16T13:19:28.878Z] __DOTNET_ADD_64BIT= '1'[2019-05-16T13:19:28.878Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-05-16T13:19:28.878Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-05-16T13:19:28.878Z] 

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 234 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/234/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 10:47:55 +
 Build duration:
1 hr 24 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 11 test(s), Passed: 97 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testLockScreenFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testShellClientFailed: projectroot.autotests.integration.kwin_testShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 4 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.integration.effects.kwin_testScriptedEffectsFailed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucency

D21228: [Touchpad KCM] Load previous setting on reboot

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
romangg marked an inline comment as done.
Closed by commit R119:5afc24db67ed: [Touchpad KCM] Load previous setting on 
reboot (authored by atulbi, committed by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21228?vs=58164=58166#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21228?vs=58164=58166

REVISION DETAIL
  https://phabricator.kde.org/D21228

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h

To: romangg, ngraham, davidedmundson, atulbi
Cc: fvogt, davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21228: [Touchpad KCM] Load previous setting on reboot

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> touchpadconfigcontainer.cpp:59
> +backend->applyConfig();
> +}
> +else if (backend->getMode() == TouchpadInputBackendMode::XSynaptics) {

pedantically

} else if {

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D21228

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: romangg, ngraham, davidedmundson, atulbi
Cc: fvogt, davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/18/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 10:47:39 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D21228: [Touchpad KCM] Load previous setting on reboot

[Roman Gilg]

romangg updated this revision to Diff 58164.
romangg added a comment.


  - Fix loading, code style, shared cfg ptr

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21228?vs=58131=58164

BRANCH
  arcpatch-D21228

REVISION DETAIL
  https://phabricator.kde.org/D21228

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h

To: romangg, ngraham, davidedmundson, atulbi
Cc: fvogt, davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.12/38/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 10:10:45 +
 Build duration:
44 min and counting
   CONSOLE OUTPUT
  [...truncated 200 lines...][2019-05-16T10:55:10.477Z] BUILD_ID  = '38'[2019-05-16T10:55:10.477Z] OLDPWD= '/usr/home/jenkins'[2019-05-16T10:55:10.477Z] PWD   = '/usr/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 FreeBSDQt5.12'[2019-05-16T10:55:10.477Z] _ = '/usr/local/bin/java'[2019-05-16T10:55:10.477Z] TERM  = 'su'[2019-05-16T10:55:10.477Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.12'[2019-05-16T10:55:10.477Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-kf5-qt5 FreeBSDQt5.12-38'[2019-05-16T10:55:10.477Z] BUILD_DISPLAY_NAME= '#38'[2019-05-16T10:55:10.477Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.12/38/display/redirect'[2019-05-16T10:55:10.477Z] USER  = 'jenkins'[2019-05-16T10:55:10.477Z] HOME  = '/home/jenkins'[2019-05-16T10:55:10.477Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.12/38/'[2019-05-16T10:55:10.477Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.12/'[2019-05-16T10:55:10.477Z] HUDSON_URL= 'https://build.kde.org/'[2019-05-16T10:55:10.477Z] SHELL = '/usr/local/bin/bash'[2019-05-16T10:55:10.477Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 FreeBSDQt5.12'[2019-05-16T10:55:10.477Z] MM_CHARSET= 'UTF-8'[2019-05-16T10:55:10.477Z] STAGE_NAME= 'Configuring Build'[2019-05-16T10:55:10.477Z] NODE_NAME = 'FreeBSD Builder 1'[2019-05-16T10:55:10.477Z] BLOCKSIZE = 'K'[2019-05-16T10:55:10.477Z] EXECUTOR_NUMBER   = '0'[2019-05-16T10:55:10.477Z] SHLVL = '0'[2019-05-16T10:55:10.477Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-16T10:55:10.477Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-05-16T10:55:10.477Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-05-16T10:55:10.477Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-05-16T10:55:10.477Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-05-16T10:55:10.477Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-05-16T10:55:10.477Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-05-16T10:55:10.477Z] QT_SELECT = 'qt5'[2019-05-16T10:55:10.477Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-16T10:55:10.477Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-05-16T10:55:10.477Z] [2019-05-16T10:55:10.477Z] [2019-05-16T10:55:10.477Z] == Commencing Configuration:[2019-05-16T10:55:10.477Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 FreeBSDQt5.12"[2019-05-16T10:55:10.733Z] -- The C compiler identification is Clang 6.0.1[2019-05-16T10:55:10.733Z] -- The CXX compiler identification is Clang 6.0.1[2019-05-16T10:55:10.733Z] -- Check for working C compiler: /usr/bin/cc[2019-05-16T10:55:10.733Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-16T10:55:10.733Z] -- Detecting C compiler ABI info[2019-05-16T10:55:10.733Z] -- Detecting C compiler ABI info - done[2019-05-16T10:55:10.733Z] -- Detecting C compile features[2019-05-16T10:55:10.988Z] -- Detecting C compile features - done[2019-05-16T10:55:10.988Z] -- Check for working CXX compiler: /usr/bin/c++[2019-05-16T10:55:10.988Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-05-16T10:55:10.988Z] -- Detecting CXX compiler ABI info[2019-05-16T10:55:10.988Z] -- Detecting CXX compiler ABI info - done[2019-05-16T10:55:10.988Z] -- Detecting CXX compile features[2019-05-16T10:55:11.552Z] -- Detecting CXX compile features - done[2019-05-16T10:55:11.552Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-05-16T10:55:11.552Z] -- Looking for __GLIBC__[2019-05-16T10:55:11.552Z] -- Looking for __GLIBC__ - not found[2019-05-16T10:55:11.552Z] -- Performing Test _OFFT_IS_64BIT[2019-05-16T10:55:11.552Z] -- Performing Test _OFFT_IS_64BIT - 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/17/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 10:28:22 +
 Build duration:
18 min and counting
   CONSOLE OUTPUT
  [...truncated 192 lines...][2019-05-16T10:46:18.015Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-05-16T10:46:18.015Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/display/redirect'[2019-05-16T10:46:18.015Z] MAIL  = '/var/mail/jenkins'[2019-05-16T10:46:18.016Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/17/display/redirect?page=changes'[2019-05-16T10:46:18.016Z] JENKINS_URL   = 'https://build.kde.org/'[2019-05-16T10:46:18.016Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-05-16T10:46:18.016Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.12'[2019-05-16T10:46:18.016Z] HUDSON_HOME   = '/home/production/data'[2019-05-16T10:46:18.016Z] BUILD_ID  = '17'[2019-05-16T10:46:18.016Z] OLDPWD= '/usr/home/jenkins'[2019-05-16T10:46:18.016Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12'[2019-05-16T10:46:18.016Z] _ = '/usr/local/bin/java'[2019-05-16T10:46:18.016Z] TERM  = 'su'[2019-05-16T10:46:18.016Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.12'[2019-05-16T10:46:18.016Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 FreeBSDQt5.12-17'[2019-05-16T10:46:18.016Z] BUILD_DISPLAY_NAME= '#17'[2019-05-16T10:46:18.016Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/17/display/redirect'[2019-05-16T10:46:18.016Z] USER  = 'jenkins'[2019-05-16T10:46:18.016Z] HOME  = '/home/jenkins'[2019-05-16T10:46:18.016Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/17/'[2019-05-16T10:46:18.016Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/'[2019-05-16T10:46:18.016Z] HUDSON_URL= 'https://build.kde.org/'[2019-05-16T10:46:18.016Z] SHELL = '/usr/local/bin/bash'[2019-05-16T10:46:18.016Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12'[2019-05-16T10:46:18.016Z] MM_CHARSET= 'UTF-8'[2019-05-16T10:46:18.016Z] STAGE_NAME= 'Configuring Build'[2019-05-16T10:46:18.016Z] NODE_NAME = 'FreeBSD Builder 1'[2019-05-16T10:46:18.016Z] BLOCKSIZE = 'K'[2019-05-16T10:46:18.016Z] EXECUTOR_NUMBER   = '0'[2019-05-16T10:46:18.016Z] SHLVL = '0'[2019-05-16T10:46:18.016Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-16T10:46:18.016Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-05-16T10:46:18.016Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-05-16T10:46:18.016Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-05-16T10:46:18.016Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-05-16T10:46:18.016Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-05-16T10:46:18.016Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-05-16T10:46:18.016Z] QT_SELECT = 'qt5'[2019-05-16T10:46:18.016Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-16T10:46:18.016Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-05-16T10:46:18.016Z] [2019-05-16T10:46:18.016Z] [2019-05-16T10:46:18.016Z] == Commencing Configuration:[2019-05-16T10:46:18.016Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12"[2019-05-16T10:46:18.273Z] -- The C compiler identification is Clang 6.0.1[2019-05-16T10:46:18.273Z] -- The CXX compiler identification is Clang 6.0.1[2019-05-16T10:46:18.273Z] -- Check for working C compiler: /usr/bin/cc[2019-05-16T10:46:18.531Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-16T10:46:18.531Z] -- Detecting C compiler ABI info[2019-05-16T10:46:18.531Z] -- Detecting C compiler ABI info - 

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 233 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/233/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 10:02:57 +
 Build duration:
42 min and counting
   CONSOLE OUTPUT
  [...truncated 527 lines...][2019-05-16T10:42:10.042Z] [2019-05-16T10:42:10.042Z]  * libhybris, libhybris allows to run bionic-based HW adaptations in glibc systems., [2019-05-16T10:42:10.042Z]Required for libhybris backend[2019-05-16T10:42:10.042Z]  * Libcap, Capabilities are a measure to limit the omnipotence of the superuser., [2019-05-16T10:42:10.042Z]Needed for running kwin_wayland with real-time scheduling policy[2019-05-16T10:42:10.042Z] [2019-05-16T10:42:10.042Z] -- Configuring doneResuming build at Thu May 16 10:45:21 UTC 2019 after Jenkins restartWaiting to resume part of Plasma » kwin » kf5-qt5 FreeBSDQt5.12 #233: Finished waitingWaiting to resume part of Plasma » kwin » kf5-qt5 FreeBSDQt5.12 #233: Waiting for next available executor on ‘FreeBSD Builder 1’Waiting to resume part of Plasma » kwin » kf5-qt5 FreeBSDQt5.12 #233: Waiting for next available executor on ‘FreeBSD Builder 1’Ready to run at Thu May 16 10:45:27 UTC 2019[2019-05-16T10:45:27.603Z] -- Generating done[2019-05-16T10:45:27.604Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-05-16T10:45:29.802Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kwin --branchGroup kf5-qt5 --platform FreeBSDQt5.12 --usingInstall /home/jenkins/install-prefix/[2019-05-16T10:45:30.060Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-05-16T10:45:30.060Z] -- Could NOT find KF5Config (missing: KF5Config_DIR)[2019-05-16T10:45:30.060Z] -- Could NOT find KF5Config: found neither KF5ConfigConfig.cmake nor kf5config-config.cmake [2019-05-16T10:45:30.060Z] -- Could NOT find KF5ConfigWidgets (missing: KF5ConfigWidgets_DIR)[2019-05-16T10:45:30.060Z] -- Could NOT find KF5ConfigWidgets: found neither KF5ConfigWidgetsConfig.cmake nor kf5configwidgets-config.cmake [2019-05-16T10:45:30.060Z] CMake Warning at /usr/local/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-05-16T10:45:30.060Z]   Could not find a configuration file for package "KF5CoreAddons" that is[2019-05-16T10:45:30.060Z]   compatible with requested version "5.58.0".[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z]   The following configuration files were considered but not accepted:[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] /usr/local/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake, version: 5.57.0[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] Call Stack (most recent call first):[2019-05-16T10:45:30.060Z]   CMakeLists.txt:72 (find_package)[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] -- Could NOT find KF5CoreAddons , checked the following files:[2019-05-16T10:45:30.060Z] /usr/local/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (version 5.57.0)[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] -- Could NOT find KF5Crash (missing: KF5Crash_DIR)[2019-05-16T10:45:30.060Z] -- Could NOT find KF5Crash: found neither KF5CrashConfig.cmake nor kf5crash-config.cmake [2019-05-16T10:45:30.060Z] -- Could NOT find KF5GlobalAccel (missing: KF5GlobalAccel_DIR)[2019-05-16T10:45:30.060Z] -- Could NOT find KF5GlobalAccel: found neither KF5GlobalAccelConfig.cmake nor kf5globalaccel-config.cmake [2019-05-16T10:45:30.060Z] CMake Warning at /usr/local/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-05-16T10:45:30.060Z]   Could not find a configuration file for package "KF5I18n" that is[2019-05-16T10:45:30.060Z]   compatible with requested version "5.58.0".[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z]   The following configuration files were considered but not accepted:[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] /usr/local/lib/cmake/KF5I18n/KF5I18nConfig.cmake, version: 5.57.0[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] Call Stack (most recent call first):[2019-05-16T10:45:30.060Z]   CMakeLists.txt:72 (find_package)[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] -- Could NOT find KF5I18n , checked the following files:[2019-05-16T10:45:30.060Z] /usr/local/lib/cmake/KF5I18n/KF5I18nConfig.cmake (version 5.57.0)[2019-05-16T10:45:30.060Z] [2019-05-16T10:45:30.060Z] -- Could NOT find KF5Init (missing: KF5Init_DIR)[2019-05-16T10:45:30.061Z] -- Could NOT find KF5Init: found neither KF5InitConfig.cmake nor kf5init-config.cmake [2019-05-16T10:45:30.061Z] -- Could NOT find KF5Notifications (missing: KF5Notifications_DIR)[2019-05-16T10:45:30.061Z] -- Could NOT find KF5Notifications: found neither KF5NotificationsConfig.cmake nor kf5notifications-config.cmake [2019-05-16T10:45:30.061Z] -- Could NOT find 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 13 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/13/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 10:28:21 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2578)14%
(212/1499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/255)0%
(0/134)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/218)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D20585: [FormLayout] Use even top and bottom spacing for separator

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  I don't like adding a new property to separator for doing duck typing...
  
  even is really ugly and errorprone as well, but i would prefer 
  Layout.topMargin: item.toString().indexOf("Separator")===0 ? 
Kirigami.Units.smallSpacing : 0
  
  with a comment:
  // FIXME: use item instanceof Kirigami.Separator when we can depend from Qt 
5.11

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D20585

To: filipf, mart, #kirigami, ngraham
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 16 May 2019 09:59:37 +
 Build duration:
28 min and counting
   CONSOLE OUTPUT
  [...truncated 190 lines...][2019-05-16T10:27:34.207Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-05-16T10:27:34.207Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/display/redirect'[2019-05-16T10:27:34.207Z] MAIL  = '/var/mail/jenkins'[2019-05-16T10:27:34.207Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/16/display/redirect?page=changes'[2019-05-16T10:27:34.207Z] JENKINS_URL   = 'https://build.kde.org/'[2019-05-16T10:27:34.207Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-05-16T10:27:34.207Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.12'[2019-05-16T10:27:34.207Z] HUDSON_HOME   = '/home/production/data'[2019-05-16T10:27:34.207Z] BUILD_ID  = '16'[2019-05-16T10:27:34.207Z] OLDPWD= '/usr/home/jenkins'[2019-05-16T10:27:34.207Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12'[2019-05-16T10:27:34.207Z] _ = '/usr/local/bin/java'[2019-05-16T10:27:34.207Z] TERM  = 'su'[2019-05-16T10:27:34.207Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.12'[2019-05-16T10:27:34.207Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 FreeBSDQt5.12-16'[2019-05-16T10:27:34.207Z] BUILD_DISPLAY_NAME= '#16'[2019-05-16T10:27:34.207Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/16/display/redirect'[2019-05-16T10:27:34.207Z] USER  = 'jenkins'[2019-05-16T10:27:34.207Z] HOME  = '/home/jenkins'[2019-05-16T10:27:34.207Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/16/'[2019-05-16T10:27:34.207Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/'[2019-05-16T10:27:34.207Z] HUDSON_URL= 'https://build.kde.org/'[2019-05-16T10:27:34.207Z] SHELL = '/usr/local/bin/bash'[2019-05-16T10:27:34.207Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12'[2019-05-16T10:27:34.207Z] MM_CHARSET= 'UTF-8'[2019-05-16T10:27:34.207Z] STAGE_NAME= 'Configuring Build'[2019-05-16T10:27:34.207Z] NODE_NAME = 'FreeBSD Builder 1'[2019-05-16T10:27:34.207Z] BLOCKSIZE = 'K'[2019-05-16T10:27:34.207Z] EXECUTOR_NUMBER   = '0'[2019-05-16T10:27:34.207Z] SHLVL = '0'[2019-05-16T10:27:34.207Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-16T10:27:34.207Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-05-16T10:27:34.207Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-05-16T10:27:34.207Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-05-16T10:27:34.207Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-05-16T10:27:34.207Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-05-16T10:27:34.207Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-05-16T10:27:34.207Z] QT_SELECT = 'qt5'[2019-05-16T10:27:34.207Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-16T10:27:34.207Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-05-16T10:27:34.207Z] [2019-05-16T10:27:34.207Z] [2019-05-16T10:27:34.207Z] == Commencing Configuration:[2019-05-16T10:27:34.207Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12"[2019-05-16T10:27:34.463Z] -- The C compiler identification is Clang 6.0.1[2019-05-16T10:27:34.463Z] -- The CXX compiler identification is Clang 6.0.1[2019-05-16T10:27:34.463Z] -- Check for working C compiler: /usr/bin/cc[2019-05-16T10:27:34.720Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-16T10:27:34.720Z] -- Detecting C compiler ABI info[2019-05-16T10:27:34.720Z] -- Detecting C compiler ABI info - 

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 24 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/24/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 16 May 2019 09:59:22 +
 Build duration:
1 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-05-16T10:00:41.480Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-05-16T10:00:41.480Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-05-16T10:00:41.480Z] PROCESSOR_LEVEL   = '6'[2019-05-16T10:00:41.480Z] PROCESSOR_REVISION= '5e03'[2019-05-16T10:00:41.480Z] PROGRAMDATA   = 'C:\ProgramData'[2019-05-16T10:00:41.480Z] PROGRAMFILES  = 'C:\Program Files'[2019-05-16T10:00:41.480Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-05-16T10:00:41.480Z] PROGRAMW6432  = 'C:\Program Files'[2019-05-16T10:00:41.480Z] PROMPT= '$P$G'[2019-05-16T10:00:41.480Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-05-16T10:00:41.480Z] PUBLIC= 'C:\Users\Public'[2019-05-16T10:00:41.480Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/24/display/redirect?page=changes'[2019-05-16T10:00:41.480Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/24/display/redirect'[2019-05-16T10:00:41.480Z] STAGE_NAME= 'Configuring Build'[2019-05-16T10:00:41.480Z] SYSTEMDRIVE   = 'C:'[2019-05-16T10:00:41.480Z] SYSTEMROOT= 'C:\WINDOWS'[2019-05-16T10:00:41.480Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-05-16T10:00:41.480Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-05-16T10:00:41.480Z] UCRTVERSION   = '10.0.17763.0'[2019-05-16T10:00:41.480Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-05-16T10:00:41.480Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-05-16T10:00:41.480Z] USERNAME  = 'Jenkins'[2019-05-16T10:00:41.480Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-05-16T10:00:41.480Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-05-16T10:00:41.480Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-05-16T10:00:41.480Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-05-16T10:00:41.480Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-05-16T10:00:41.480Z] VCTOOLSVERSION= '14.16.27023'[2019-05-16T10:00:41.480Z] VISUALSTUDIOVERSION   = '16.0'[2019-05-16T10:00:41.480Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-05-16T10:00:41.480Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-05-16T10:00:41.480Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-05-16T10:00:41.480Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-05-16T10:00:41.480Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-05-16T10:00:41.480Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-05-16T10:00:41.480Z] VSCMD_VER = '16.0.3'[2019-05-16T10:00:41.480Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-05-16T10:00:41.480Z] WINDIR= 'C:\WINDOWS'[2019-05-16T10:00:41.480Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-05-16T10:00:41.480Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-05-16T10:00:41.480Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-05-16T10:00:41.480Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-05-16T10:00:41.480Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-05-16T10:00:41.480Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-05-16T10:00:41.480Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-05-16T10:00:41.480Z] __DOTNET_ADD_64BIT= '1'[2019-05-16T10:00:41.480Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-05-16T10:00:41.480Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-05-16T10:00:41.480Z] 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 12 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 May 2019 09:59:37 +
 Build duration:
1 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 255 lines...][2019-05-16T10:00:36.260Z] OSTYPE= 'linux'[2019-05-16T10:00:36.260Z] JOB_NAME  = 'Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2019-05-16T10:00:36.260Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-05-16T10:00:36.260Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/12/display/redirect'[2019-05-16T10:00:36.260Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-05-16T10:00:36.260Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2019-05-16T10:00:36.260Z] HUDSON_URL= 'https://build.kde.org/'[2019-05-16T10:00:36.260Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-05-16T10:00:36.260Z] NODE_NAME = 'Docker Swarm-8083ebd6fc3d'[2019-05-16T10:00:36.260Z] HOST  = '8083ebd6fc3d'[2019-05-16T10:00:36.260Z] LESSOPEN  = 'lessopen.sh %s'[2019-05-16T10:00:36.260Z] USER  = 'jenkins'[2019-05-16T10:00:36.260Z] MORE  = '-sl'[2019-05-16T10:00:36.260Z] CSHEDIT   = 'emacs'[2019-05-16T10:00:36.260Z] SHLVL = '2'[2019-05-16T10:00:36.260Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 SUSEQt5.12-12'[2019-05-16T10:00:36.260Z] WINDOWMANAGER = 'xterm'[2019-05-16T10:00:36.260Z] PAGER = 'less'[2019-05-16T10:00:36.260Z] EXECUTOR_NUMBER   = '0'[2019-05-16T10:00:36.260Z] CVS_RSH   = 'ssh'[2019-05-16T10:00:36.260Z] LIBGL_DEBUG   = 'quiet'[2019-05-16T10:00:36.260Z] STAGE_NAME= 'Configuring Build'[2019-05-16T10:00:36.260Z] NODE_LABELS   = 'Docker Swarm-8083ebd6fc3d SUSEQt5.12'[2019-05-16T10:00:36.260Z] XCURSOR_THEME = 'DMZ-Black'[2019-05-16T10:00:36.260Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-05-16T10:00:36.260Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-05-16T10:00:36.260Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-05-16T10:00:36.260Z] PROFILEREAD   = 'true'[2019-05-16T10:00:36.260Z] MAIL  = '/var/mail/jenkins'[2019-05-16T10:00:36.260Z] HOSTTYPE  = 'x86_64'[2019-05-16T10:00:36.260Z] BUILD_ID  = '12'[2019-05-16T10:00:36.260Z] LESSKEY   = '/etc/lesskey.bin'[2019-05-16T10:00:36.260Z] OLDPWD= '/home/jenkins'[2019-05-16T10:00:36.260Z] LC_CTYPE  = 'C.UTF-8'[2019-05-16T10:00:36.260Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-16T10:00:36.260Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-05-16T10:00:36.260Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-05-16T10:00:36.260Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-05-16T10:00:36.260Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-05-16T10:00:36.260Z] QT_SELECT = 'qt5'[2019-05-16T10:00:36.260Z] LANG  = 'en_US.UTF-8'[2019-05-16T10:00:36.260Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-16T10:00:36.260Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-05-16T10:00:36.260Z] [2019-05-16T10:00:36.260Z] [2019-05-16T10:00:36.260Z] == Commencing Configuration:[2019-05-16T10:00:36.260Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12"[2019-05-16T10:00:36.260Z] -- The C compiler identification is GNU 8.3.1[2019-05-16T10:00:36.523Z] -- The CXX compiler identification is GNU 8.3.1[2019-05-16T10:00:36.523Z] -- Check for working C compiler: /usr/bin/cc[2019-05-16T10:00:36.778Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-16T10:00:36.778Z] -- Detecting C compiler ABI info[2019-05-16T10:00:37.701Z] -- Detecting C compiler ABI info - done[2019-05-16T10:00:37.701Z] -- Detecting C compile features[2019-05-16T10:00:38.634Z] -- Detecting C compile features - done[2019-05-16T10:00:38.634Z] -- Check for working CXX compiler: /usr/bin/c++[2019-05-16T10:00:38.634Z] -- Check for working CXX 

D21239: Port knsbackendtest to ecm_add_test

[Michael Palimaka]

palimaka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
palimaka requested review of this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21239

AFFECTED FILES
  libdiscover/backends/KNSBackend/tests/CMakeLists.txt

To: palimaka
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[David Edmundson]

davidedmundson added a comment.


  > When anchors.margins is removed we see that the ToolButton still has 1px of 
its own margin around it
  
  From what? Should they be there?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/23/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 16 May 2019 09:13:56 +
 Build duration:
2 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-05-16T09:16:22.049Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-05-16T09:16:22.049Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-05-16T09:16:22.049Z] PROCESSOR_LEVEL   = '6'[2019-05-16T09:16:22.049Z] PROCESSOR_REVISION= '5e03'[2019-05-16T09:16:22.049Z] PROGRAMDATA   = 'C:\ProgramData'[2019-05-16T09:16:22.049Z] PROGRAMFILES  = 'C:\Program Files'[2019-05-16T09:16:22.049Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-05-16T09:16:22.049Z] PROGRAMW6432  = 'C:\Program Files'[2019-05-16T09:16:22.049Z] PROMPT= '$P$G'[2019-05-16T09:16:22.049Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-05-16T09:16:22.049Z] PUBLIC= 'C:\Users\Public'[2019-05-16T09:16:22.049Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/23/display/redirect?page=changes'[2019-05-16T09:16:22.049Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/23/display/redirect'[2019-05-16T09:16:22.049Z] STAGE_NAME= 'Configuring Build'[2019-05-16T09:16:22.049Z] SYSTEMDRIVE   = 'C:'[2019-05-16T09:16:22.049Z] SYSTEMROOT= 'C:\WINDOWS'[2019-05-16T09:16:22.049Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-05-16T09:16:22.049Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-05-16T09:16:22.049Z] UCRTVERSION   = '10.0.17763.0'[2019-05-16T09:16:22.049Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-05-16T09:16:22.049Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-05-16T09:16:22.049Z] USERNAME  = 'Jenkins'[2019-05-16T09:16:22.049Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-05-16T09:16:22.049Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-05-16T09:16:22.049Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-05-16T09:16:22.049Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-05-16T09:16:22.049Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-05-16T09:16:22.049Z] VCTOOLSVERSION= '14.16.27023'[2019-05-16T09:16:22.049Z] VISUALSTUDIOVERSION   = '16.0'[2019-05-16T09:16:22.049Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-05-16T09:16:22.050Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-05-16T09:16:22.050Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-05-16T09:16:22.050Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-05-16T09:16:22.050Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-05-16T09:16:22.050Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-05-16T09:16:22.050Z] VSCMD_VER = '16.0.3'[2019-05-16T09:16:22.050Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-05-16T09:16:22.050Z] WINDIR= 'C:\WINDOWS'[2019-05-16T09:16:22.050Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-05-16T09:16:22.050Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-05-16T09:16:22.050Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-05-16T09:16:22.050Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-05-16T09:16:22.050Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-05-16T09:16:22.050Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-05-16T09:16:22.050Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-05-16T09:16:22.050Z] __DOTNET_ADD_64BIT= '1'[2019-05-16T09:16:22.050Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-05-16T09:16:22.050Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-05-16T09:16:22.050Z] 

Re: Review Request: plasma-thunderbolt

[Daniel Vrátil]

On Wednesday, 15 May 2019 23:08:57 CEST Albert Astals Cid wrote:
> El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va 
escriure:
> > Hi all,
> > 
> > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt
> > KCM for Plasma. I initially submitted the code as a patch against
> > plasma-desktop [0], where it got reviewed, but it was ultimately decided
> > to better put it into a separate repository, since it's not just a KCM
> > but also a library and a KDED module. I have backported all the changes
> > from the Phabricator review back to the repository, so the code in the
> > repo is identical to the one in the Phab review (minus buildsystem
> > changes and a small build fix for clang).
> > 
> > However, since this is still a new code, it must formally pass through
> > kdereview before I can submit it into Plasma as a new module.
> > 
> > Thus I'd kindly ask you to take one more look at the codebase [1] and let
> > me know if there are any more issues to fix, or if we can proceed to
> > include this in the next Plasma release.
> 
> There's this cmake warning
> 
> CMake Warning at /usr/lib64/cmake/KF5Package/KF5PackageMacros.cmake:74
> (message): KPackage components should be specified in reverse domain
> notation. Appstream information won't be generated for kcm_bolt.
> Call Stack (most recent call first):
>   src/kcm/CMakeLists.txt:22 (kpackage_install_package)

I need some help with this - I looked into plasma-desktop, but all KCMs 
generate this warning and after renaming the package I just wasn't able to 
pair it with the library (which makes not sense to be called 
org.kde.plasma.thunderbolt.so) - so for now I'd just ignore the warning (we 
don't need Appstream data for KCM anyway, do we?).

> clazy complains about a few Q_PROPERTY that should ideally either have a
> NOTIFY signal or be marked as CONSTANT

I fixed the ones in the code, I can't fix the ones in the generated DBus 
interfaces and adaptors.


> it also complains about a few const slots that return values. Seems like
> what you want is to actually mark them as invokable/scriptable and not as
> slots?

Good point, fixed those.

Thanks for the review,
Dan

> 
> Cheers,
>   Albert
> 
> > Thanks,
> > - Dan
> > 
> > [0] https://phabricator.kde.org/D19011
> > [1] https://cgit.kde.org/plasma-thunderbolt.git


-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.

Re: Review Request: plasma-thunderbolt

[Daniel Vrátil]

On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote:
> Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil:
> > Thus I'd kindly ask you to take one more look at the codebase [1] and let
> > me know if there are any more issues to fix, or if we can proceed to
> > include this in the next Plasma release.
> 
> Pushed some small fixes to toplevel CMakeLists.txt
> 
> Other things seen on quick look at code (also not tested runtime):
> * kded misses a Messages.sh file.
> * no COPYRIGHT license files in the repo
> * kde_enable_exceptions() duplicated a few times, perhaps only do in subdirs
> where needed or use of kde_target_enable_exceptions() if fitting
> * libkbolt being a private library could be reflected in the libname, also
> get install(TARGETS kbolt ${KDE_INSTALL_TARGETS_DEFAULT_ARGS} LIBRARY
> NAMELINK_SKIP)

All fixed, thanks for the review (and the fixes)!

Dan

> 
> Cheers
> Friedrich


-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.

D21228: [Touchpad KCM] Load previous setting on reboot

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> libinputtouchpad.cpp:34
>  
> +const QSet configProps = {
> +QStringLiteral("enabled"),

`static`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: atulbi, ngraham, romangg, davidedmundson
Cc: fvogt, davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart