D21278: [Touchpad KCM] Fix kded crashing at startup

[Roman Gilg]

romangg added a comment.


  Codewise looks fine. Good adaption in comparison to first revision! Question 
remains if we want to further disconnect/deactivate the applet functionality in 
case libinput is used. We don't need to watch the keyboard presses at all. Same 
holds for the Wayland case, where we wouldn't even need the kcminit at all 
(T6084 ).
  
  Anyways, we can do small steps. This looks good already. Let's wait for some 
feedback from bug report and I would be happy with current revision.

INLINE COMMENTS

> xlibtouchpad.h:63
>  bool enabled();
> -void setTouchpadOff(int touchpadOff);
> -int touchpadOff();
> +virtual void setTouchpadOff(int touchpadOff) {}
> +virtual int touchpadOff() = 0;

Q_UNUSED

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21278

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Matthew Scheirer]

zanny added a comment.


  Testing out the beta release that includes this change has the search bar 
overflow the menu list with high (160, in the example) DPI settings:
  
  F6838228: Screenshot_20190519_193434.png 

  
  It gets worse the higher the DPI gets:
  
  F6838231: Screenshot_20190519_193757.png 

  
  Looks like the home button isn't DPI aware and the row including the search 
bar size constrains to it.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21234

To: ngraham, #vdg, #discover_software_store, apol, ndavis
Cc: zanny, filipf, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

atulbi updated this revision to Diff 58319.
atulbi added a comment.


  - Now we have separate m_touchpadOffAtom for synaptics and Libinput. On 
Libinput, used m_enabled prop.
  - setTouchpadOff will be ignored on X Libinput.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21278?vs=58266=58319

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21278

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21296: Add the option to configure the realm

[Enrique Melendez]

enriquem created this revision.
enriquem added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
enriquem requested review of this revision.

REVISION SUMMARY
  Add an option in the advanced elements dialog to let the user set the 
connection realm. Realms are authentication user groups that can be defined to 
give different access rights to the network. The openfortivpn binary and the 
gnome applets both provide this capability. The diff includes this capability 
in plasma-nm.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D21296

AFFECTED FILES
  vpn/fortisslvpn/fortisslvpnadvanced.ui
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/fortisslvpn/nm-fortisslvpn-service.h

To: enriquem, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf added a comment.


  In D19631#467170 , @rikmills wrote:
  
  > > ! In D19631#467167 , @filipf 
wrote:
  > > 
  > > Why does it look different than Neon?
  >
  > Seems neon have a settings tweak to force more font Noto (especially for 
sddm).
  >
  > Cherry picking that...
  
  
  We could also increase the width of each of the button's container, basically 
what this shows I guess is the Shut Down button barely fits in one row. I'll 
look into it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Rik Mills]

rikmills added a comment.


  > ! In D19631#467167 , @filipf 
wrote:
  > 
  > Why does it look different than Neon?
  
  Seems neon have a settings tweak to force more font Noto (especially for 
sddm).
  
  Cherry picking that...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf added a comment.


  In D19631#467156 , @rikmills wrote:
  
  > Not looking good.
  >
  > F6835091: c0924558f6.png 
  
  
  Why does it look different than Neon?
  
  F6835124: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Rik Mills]

rikmills added a comment.


  Not looking good.
  
  F6835091: c0924558f6.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  @davidedmundson
  
  Thanks.
  
  It is my first contribution to KDE/Plasma, so I **do hope** that I don't have 
a commit access.

INLINE COMMENTS

> davidedmundson wrote in CompactApplet.qml:34
> You will enter this branch if the system tray is on the left.
> 
> It doesn't make a difference now since Dialog gained support to not not 
> overlap panels and to switch edges if it doesn't fit.
> 
> This puts the location in a "wrong" way we hit the conflict detection in 
> Dialog and it fixes it.

Honestly, I tried putting plasma panel on each of four sides (naturally 
including left and right), but for some reason I still did not enter the 
branch. Or maybe it did, but no visual changes were observed. I don't remember.

It was not an easy decision to remove someone else's code which I do not 
understand. Whereas "(a) I do not understand; and (b) I has no visual effect" 
sounds a little bit more convincing.

As far as i get it from your reply, it's now Dialog's unified responsibility 
(which is fine, I guess) so this lines were redundant already.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-system-tray

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

atulbi added a comment.


  In D21278#466804 , @romangg wrote:
  
  > > by kded on key press other than Kded Keyboard shortcuts
  >
  > Do you mean it's sent on shortcut or not? Just wondering why I couldn't 
replicate the issue in my testing.
  
  
  kded5 did not crash until I pressed some key which is not Kded Keyboard 
shortcuts. Like Ctrl+Alt+T did not crash it, but just pressing any other key 
crashed it.
  Sending patch for it in a while.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21278

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

atulbi added a comment.


  In D21278#466801 , @davidedmundson 
wrote:
  
  > > m_connection seems to be having null or 0x0 value.
  >
  > Which means we're calling XcbAtom::atom after being constructed from the 
default constructor not the proper one.
  >
  > That doesn't sound right. If you can explain why we end up in this 
situation and it's legit, I'll accept, otherwise it looks like we're just 
treating a symptom.
  
  
  As Roman pointed out, X Libinput backend do not call `XcbAtom::intern` for 
m_touchpadOffAtom. Rightly said we're just treating a symptom.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21278

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart