D13095: Scren brightness follow a quatratic progression

[Kevin Slagle]

kjslag added a comment.


  I like the idea of this patch. I just reassigned my brightness hotkeys to a 
small script that does almost exactly what this patch does before I discovered 
this patch.
  
  In order to deal with Nate's problem, perhaps instead of starting with 
brightness=0, we could just start with the next increment of brightness, which 
happens to be 2 for Nate. Nate's situation would be similar to before the patch 
was applied: only the lowest brightness setting turns off his screen. So there 
wouldn't be a regression for Nate.
  
  On my laptop, brightness=0 turns the screen off and brightness 1 through 46 
correspond to the minimum brightness, and max_brightness=24242. My proposal 
would also be better for me since then my screen wouldn't turn off with the 
minimum brightness.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

To: thsurrel, #plasma, broulik, ngraham
Cc: kjslag, sharvey, zzag, ngraham, romangg, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21307: Optimise the NetworkModel

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:7e1d06d0c0aa: Optimise the NetworkModel (authored by 
apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21307?vs=58366=58388#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21307?vs=58366=58388

REVISION DETAIL
  https://phabricator.kde.org/D21307

AFFECTED FILES
  libs/declarative/networkstatus.cpp
  libs/models/networkmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/models/networkmodelitem.h

To: apol, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

[Nathaniel Graham]

ngraham added a comment.


  @davidedmundson Given your comments in 
https://bugs.kde.org/show_bug.cgi?id=407460, can this go in?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21181

To: broulik, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Nathaniel Graham]

ngraham added a comment.


  That's exactly why manually setting the DPI isn't the correct way to enable 
high DPI mode. It only changes the fonts, so UI elements that aren't textual 
(like icon-only buttons, and icons in buttons) don't get scaled. You should use 
the scale factor slider in System Settings > Display and Monitor > Scale 
Display to enable high DPI mode. If there are bugs preventing this from working 
for you, please file them.
  
  Thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21234

To: ngraham, #vdg, #discover_software_store, apol, ndavis
Cc: zanny, filipf, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21307: Optimise the NetworkModel

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good.

INLINE COMMENTS

> networkmodelitem.cpp:561
>  if (m_mode == NetworkManager::WirelessSetting::Infrastructure) {
> -m_details << i18n("Signal strength") << 
> QString("%1%").arg(m_signal);
> +m_details << i18n("Signal strength") << 
> QString::number(m_signal);
>  }

This will remove the '%' at the end of signal strength.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21307

To: apol, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Nathaniel Graham]

ngraham added a comment.


  This doesn't apply to master anymore:
  
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20222.
Checking patch applets/systemmonitor/common/contents/ui/ConfigGeneral.qml...
error: while searching for:
}
} else {
var idx = cfg_sources.indexOf(model.source);
if (idx !== -1) {
cfg_sources.splice(idx, 1);
}
}
cfg_sourcesChanged();

error: patch failed: 
applets/systemmonitor/common/contents/ui/ConfigGeneral.qml:134
Applying patch applets/systemmonitor/common/contents/ui/ConfigGeneral.qml 
with 1 reject...
Rejected hunk #1.

 Patch Failed! 
Usage Exception: Unable to apply patch!
  
  Can you rebase the patch so we can land it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Nathaniel Graham]

ngraham added a comment.


  Thanks again. Very nice patch. May it be the first of many! :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a73aa33028ef: Fix system tray UI/UX  refactor 
(authored by ratijastk, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19745?vs=58123=58376

REVISION DETAIL
  https://phabricator.kde.org/D19745

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/StatusNotifierItemModel.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ksysguardd: show Mandatory Access Control (SELinux/AppArmor) context

[Topi Miettinen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:446a3b368813: ksysguardd: show Mandatory Access Control 
(SELinux/AppArmor) context (authored by topimiettinen).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20853?vs=58257=58374

REVISION DETAIL
  https://phabricator.kde.org/D20853

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: libksysguard: show Mandatory Access Control (SELinux/AppArmor) context

[Topi Miettinen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:e3894f9408cc: libksysguard: show Mandatory Access Control 
(SELinux/AppArmor) context (authored by topimiettinen).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20854?vs=58372=58373

REVISION DETAIL
  https://phabricator.kde.org/D20854

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: process: show SELinux context

[Topi Miettinen]

topimiettinen updated this revision to Diff 58372.
topimiettinen added a comment.


  update to reflect that this also shows AppArmor context

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20854?vs=57197=58372

BRANCH
  process-cgroup-selinux

REVISION DETAIL
  https://phabricator.kde.org/D20854

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Nathaniel Graham]

ngraham added a comment.


  Thanks. Let's wait for @broulik's review once he gets back from vacation (a 
few days, I think).

REPOSITORY
  R122 Powerdevil

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: reverendhomer, meven, soriano, abalaji, graesslin, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21274: Don't assign a QtObject to a model

[David Edmundson]

davidedmundson added a comment.


  That would still hit the Qt crash unless I declare all used properties, which 
is the part I wanted to avoid.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21274

To: davidedmundson, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21307: Optimise the NetworkModel

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
apol requested review of this revision.

REVISION SUMMARY
  Only notify changes about the bits that actually changed.
  This is especially important for sorted lists, as a small change on a detail 
could trigger a resort and redraw of the whole view, especially at boot.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21307

AFFECTED FILES
  libs/declarative/networkstatus.cpp
  libs/models/networkmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/models/networkmodelitem.h

To: apol, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21279: [sddm-theme] Add spacing between action buttons' labels

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch please!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-spacing-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21279

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Nathaniel Graham]

ngraham added a comment.


  In D19631#467171 , @filipf wrote:
  
  > We could also increase the width of each of the button's container, 
basically what this shows I guess is the Shut Down button barely fits in one 
row. I'll look into it.
  
  
  +1. I don't see any particular reason why the buttons need to be so close 
together.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21303: Set application name to org_kde_powerdevil

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:90839c802ebc: Set application name to org_kde_powerdevil 
(authored by bshah).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21303?vs=58355=58356

REVISION DETAIL
  https://phabricator.kde.org/D21303

AFFECTED FILES
  daemon/powerdevilapp.cpp

To: bshah, davidedmundson, romangg
Cc: fvogt, arojas, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21303: Set application name to org_kde_powerdevil

[Bhushan Shah]

bshah updated this revision to Diff 58355.
bshah added a comment.


  setProductName

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21303?vs=58350=58355

BRANCH
  bshah-rename-component

REVISION DETAIL
  https://phabricator.kde.org/D21303

AFFECTED FILES
  daemon/powerdevilapp.cpp

To: bshah, davidedmundson, romangg
Cc: fvogt, arojas, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21303: Set application name to org_kde_powerdevil

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Probably needs a matching 
  KAboutData::setProductName to "powerdevil"

REPOSITORY
  R122 Powerdevil

BRANCH
  bshah-rename-component

REVISION DETAIL
  https://phabricator.kde.org/D21303

To: bshah, davidedmundson, romangg
Cc: fvogt, arojas, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21303: Set application name to org_kde_powerdevil

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: davidedmundson, romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  Previously application component name without any KAboutData was
  org_kde_powerdevil (executable name), although, 972eb26d0558d 
 
commit
  changed the component name to powerdevil, which had side-effects that
  powerdevil would write shortcuts to powerdevil component and it would
  conflict with old org_kde_powerdevil shortcuts, and ultimately none
  would work.
  
  In theory we can do migration of the shortcuts to powerdevil component
  using kconf_update but that doesn't work, as kglobalaccel is already
  started before powerdevil, resulting in kconf_update changes having no
  effect, more on this in commit 4ae36ae 
 
which introduces the
  PowerDevilApp::migratePre512KeyboardShortcuts() function, while in
  theory PowerDevilApp::migratePre516KeyboardShortcuts can be introduced,
  we can simply avoid this hassle by re-assigning old component name.
  
  BUG: 407721

REPOSITORY
  R122 Powerdevil

BRANCH
  bshah-rename-component

REVISION DETAIL
  https://phabricator.kde.org/D21303

AFFECTED FILES
  daemon/powerdevilapp.cpp

To: bshah, davidedmundson, romangg
Cc: arojas, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

plasma-desktop 5.15.90.1 update

[Jonathan Riddell]

I've updated plasma-desktop tar for 5.16 beta due to a crasher it caused in
kded

Plasma 5.16 beta

[Jonathan Riddell]

Plasma 5.16 beta is out now for testing before a final release due on June
11

https://kde.org/announcements/plasma-5.15.90.php

Notes from Monday meeting of 20/5/2019

[Marco Martin]

Eike:
* Nothing to report, $dayjob still has me in its throes :( However in $dayjob 
I've been working a lot with Qt Quick's new TableView + DelegateChooser + 
pointer handlers lately, which has given me a lot of ideas for how to overhaul 
the Folder View presentation layer. I'll likely make that my Plasma sprint pet 
project. I also wrote a drop-in for QTreeView (with desktop style support) 
that could allow us to use the FV backend in something Dolphin/KFileDialog-
like based on 
* Qt Quick, ... could all be interesting

Bhushan:
* nothing new to report, but report by romangg about powerdevil shortcuts 
caught my eye
* looking into it

Jonathan:
* Plasma 5.16 beta release is out! https://kde.org/announcements/
plasma-5.15.90.php
* I've copied over the announcement for final and it'll need to be ready ahead 
of time for translations, so please send any changes you want compared to beta 
announce to me pronto
* Better communication with Promo needed, communication on who should write 
the announcement broke down
* Relevant Phab ticket: https://phabricator.kde.org/T10855

atulbi[m]:
Work done on Touchpad KCM:
- Added Click method support on wayland. For which I first added its support 
in Kwin way back in December.
- Earlier Libinput on X was partially implemented. As Libinput specific UI was 
already present on wayland. Used that UI for Libinput on X. So added support 
for most of the Libinput specific properties.
- Fixed bug about mouse and touchpad KCM interfering with each other
- I want to have three-four finger gesture support.
- Currently disable horizontal scrolling is only available on X. Work needs to 
be done on wayland too.

Friedrich:
*watching fallouts from what I did. bug 406380 might be one, need someone to 
test with qt 5.12 other than me, as I cannot reproduce the issue locally :(
KDE bug 406380 in plasmashell (Panel) "Gap between panel edge and panel 
shadow / apps with Qt 5.13 branch" [normal,] https://bugs.kde.org/
show_bug.cgi?id=406380

Marco:
Kirigami:
* DelegateRecycler is a focus scope that assigns focus to its main item as 
soon as it gets it, this fixes keyboard navigation in cardlistview and 
cardgridview
Plasma:
* fixed lnf packaging not installing from ghns
* fixed a crash in qqc2-desktop-style that made opening most kcms crash
Containment Applets layout c++ rewrite
* working load and save of the layout
* fixed last layouting bugs
* added a js callback to filter applets needed for the mycroft tablet 
containment and for an hypotetical future grouping feature

-- 
Marco Martin

D21278: [Touchpad KCM] Fix kded crashing at startup

[Atul Bisht]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ecea8b93d997: [Touchpad KCM] Fix kded crashing at startup 
(authored by atulbi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21278?vs=58319=58343

REVISION DETAIL
  https://phabricator.kde.org/D21278

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h

To: atulbi, romangg, davidedmundson
Cc: fvogt, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.


  Feedback positive in bug report.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21278

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21296: Add the option to configure the realm

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D21296

To: enriquem, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart