date:20190528

D21470: Properly read stderr when data is ready from the daemon.

2019-05-28 Thread Luca Carlon

luc4 created this revision.
luc4 added reviewers: davidedmundson, mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REVISION SUMMARY
  When stderr data is sent from the daemon, it seems that libksysguard was 
actually reading the stdout buffer. Also, as the comment states, it was trying 
to read potentially incomplete UTF-8 data. This patch reads from stderr and 
also only reads entire lines, preventing incomplete UTF-8 data buffers.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21470

AFFECTED FILES
  ksgrd/SensorShellAgent.cpp

To: luc4, davidedmundson, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Nathaniel Graham

ngraham added a comment.


  In D21414#471289 , @kishoreg wrote:
  
  > BTW, if I open the window standalone (from krunner), it allows me to resize 
it vertically so that the entire window gets scrollbars. F6856837: 
Screenshot_20190528_220702.png 
  >  I can't do this horizontally. Is there some vertical minimum size hint I 
have to set for the entire window? The minimum size is obeyed correctly when we 
open it as part of the System Settings window. Is this intended behaviour or a 
known bug? The result is a bit awkward to use, with scrollbars within 
scrollbars.
  
  
  That means the SizeHint is probably not set correctly to account for the new 
layout.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: GB_2, abetts, bruns, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Nathaniel Graham

ngraham added a comment.


  In D21414#471286 , @GB_2 wrote:
  
  > In D21414#471285 , @ngraham 
wrote:
  >
  > > Actually now that I think about it, this should probably go into Plasma 
5.16. However since I asked you to add a colon to the end of a string, 
technically that's a string change and those aren't allowed so close to the 
release, so it would have to go into Plasma 5.17
  > >
  > > I propose reverting that part so there are no string changes, and then 
this can go into 5.16. Then let's add the colon back on the master branch. How 
does that sound?
  >
  >
  > Yeah. Can you also please move the buttons to the left?
  
  
  Oh right, I forgot about that, Yeah. That will make this align with T10384 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: GB_2, abetts, bruns, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Kishore Gopalakrishnan

kishoreg added a comment.


  BTW, if I open the window standalone (from krunner), it allows me to resize 
it vertically so that the entire window gets scrollbars. F6856837: 
Screenshot_20190528_220702.png 
  I can't do this horizontally. Is there some vertical minimum size hint I have 
to set for the entire window? The minimum size is obeyed correctly when we open 
it as part of the System Settings window. Is this intended behaviour or a known 
bug? The result is a bit awkward to use, with scrollbars within scrollbars.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: GB_2, abetts, bruns, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Björn Feber

GB_2 added a comment.


  In D21414#471285 , @ngraham wrote:
  
  > Actually now that I think about it, this should probably go into Plasma 
5.16. However since I asked you to add a colon to the end of a string, 
technically that's a string change and those aren't allowed so close to the 
release, so it would have to go into Plasma 5.17
  >
  > I propose reverting that part so there are no string changes, and then this 
can go into 5.16. Then let's add the colon back on the master branch. How does 
that sound?
  
  
  Yeah. Can you also please move the buttons to the left?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: GB_2, abetts, bruns, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Nathaniel Graham

ngraham added a comment.


  Actually now that I think about it, this should probably go into Plasma 5.16. 
However since I asked you to add a colon to the end of a string, technically 
that's a string change and those aren't allowed so close to the release, so it 
would have to go into Plasma 5.17
  
  I propose reverting that part so there are no string changes, and then this 
can go into 5.16. Then let's add the colon back on the master branch. How does 
that sound?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: abetts, bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Nathaniel Graham

ngraham added a comment.


  Nope, that looks perfect to me!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: abetts, bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Kishore Gopalakrishnan

kishoreg updated this revision to Diff 58797.
kishoreg added a comment.


  Screenshot as of this diff: F6856823: Screenshot_20190528_220210.png 

  
  Are there any other changes that need to be made?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58786=58797

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: abetts, bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Andres Betts

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: abetts, bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21436: Use onClicked for Home button

2019-05-28 Thread Björn Feber

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:66f3bec02825: Use onClicked for Home button (authored by 
GB_2).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21436?vs=58739=58791

REVISION DETAIL
  https://phabricator.kde.org/D21436

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21451: [System Tray] Ignore services that start with a colon (:)

2019-05-28 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:143969f24fbe: [System Tray] Ignore services that start 
with a colon (:) (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21451?vs=58767=58788

REVISION DETAIL
  https://phabricator.kde.org/D21451

AFFECTED FILES
  applets/systemtray/systemtray.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21460: [Notifications] Group applications with same display name but no desktop entry

2019-05-28 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:08b027f1124b: [Notifications] Group applications with 
same display name but no desktop entry (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21460?vs=58782=58789

REVISION DETAIL
  https://phabricator.kde.org/D21460

AFFECTED FILES
  libnotificationmanager/notificationgroupingproxymodel.cpp

To: broulik, #plasma, hein, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21439: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one

2019-05-28 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:999b619bc5c8: [Touchpad KCM] Revoke touchpad 
enabled/disabled notification before sending a… (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21439?vs=58752=58787

REVISION DETAIL
  https://phabricator.kde.org/D21439

AFFECTED FILES
  kcms/touchpad/src/kded/kded.cpp
  kcms/touchpad/src/kded/kded.h

To: broulik, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Nathaniel Graham

ngraham added a comment.


  I think I confused you, sorry. My desire was for some spacing above the 
listview's label, like this:
  
  F6856571: edited.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Kishore Gopalakrishnan

kishoreg updated this revision to Diff 58786.
kishoreg added a comment.


  This is awkward. I hadn't realized that I was supposed to use one space for 
indentation. Fixed as per the preexisting convention.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58784=58786

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Kishore Gopalakrishnan

kishoreg updated this revision to Diff 58784.
kishoreg added a comment.


  I seem to have messed up the indentation in my previous diff. Here it is with 
the indentation fixed.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58781=58784

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21460: [Notifications] Group applications with same display name but no desktop entry

2019-05-28 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The specification says `appName` should be the display name of the 
application.
  An application may not send a desktop name at which point we have no other 
way of identifying it.

TEST PLAN
  VLC notifications are grouped together now (I fixed vlc in a newer version to 
send such a hint) but there might also be other applications and scripts that 
could benefit from this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21460

AFFECTED FILES
  libnotificationmanager/notificationgroupingproxymodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Kishore Gopalakrishnan

kishoreg marked an inline comment as done.
kishoreg added a comment.


  BTW, checkboxes in other KCMs also seem to have the same spacing as this one 
had before this change. Is there a way to globally apply this spacing / padding 
consistently to QCheckBoxes in all KCMs for the sake of consistency? Perhaps 
some sort of global stylesheet that this should go into?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-28 Thread Kishore Gopalakrishnan

kishoreg updated this revision to Diff 58781.
kishoreg added a comment.


  I've added a colon after the 'Do not search in these locations' text. I've 
also added spacing between the checkboxes and their text. I've put in 10 px for 
now. Is there a better way to do this?
  
  Without additional space after checkbox: F6856451: 
Screenshot_20190528_175816.png 
  
  With additional space after checkbox: F6856452: 
Screenshot_20190528_180003.png 
  
  The change seems to have slightly reduced the vertical space between the 
checkboxes, so should I add padding to the stylesheet?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58723=58781

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-05-28 Thread Méven Car

meven added a comment.


  In D20598#471149 , @filipf wrote:
  
  > In D20598#455424 , @ngraham 
wrote:
  >
  > > This doesn't actually work for me. Upon opening, the following is printed 
to the console:
  > >
  > >   org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared 
library was not found." 
  > >   Plugin search paths are ("/usr/lib/x86_64-linux-gnu/qt5/plugins", 
"/usr/bin") 
  > >   The environment variable QT_PLUGIN_PATH might be not correctly set
  > >   :3:89: Unable to assign [undefined] to double
  > >   QQmlExpression: Expression 
file:///usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/main.qml:436:33 
depends on non-NOTIFYable properties:
  > >   Solid::Battery::serial
  > >
  >
  >
  > I am now getting the same error as well, kcmshell5 is eating up one cpu 
core in the background.
  
  
  I am not focused on this anymore and might abandon this review as I really 
don't enjoy Qml hacking and lack of good tooling at least in my experience.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-05-28 Thread Filip Fila

filipf added a comment.


  In D20598#455424 , @ngraham wrote:
  
  > This doesn't actually work for me. Upon opening, the following is printed 
to the console:
  >
  >   org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared 
library was not found." 
  >   Plugin search paths are ("/usr/lib/x86_64-linux-gnu/qt5/plugins", 
"/usr/bin") 
  >   The environment variable QT_PLUGIN_PATH might be not correctly set
  >   :3:89: Unable to assign [undefined] to double
  >   QQmlExpression: Expression 
file:///usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/main.qml:436:33 
depends on non-NOTIFYable properties:
  >   Solid::Battery::serial
  >
  
  
  I am now getting the same error as well, kcmshell5 is eating up one cpu core 
in the background.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik, filipf
Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21438: [plasmashell] Don't talk to ksmserver

2019-05-28 Thread Aleix Pol Gonzalez

apol added a comment.


  Maybe we can just get this in 
https://codereview.qt-project.org/c/qt/qtbase/+/254679.
  
  Tampering with env vars is scary.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21438

To: broulik, #plasma, davidedmundson
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21451: [System Tray] Ignore services that start with a colon (:)

2019-05-28 Thread Kai Uwe Broulik

broulik created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21451

AFFECTED FILES
  applets/systemtray/systemtray.cpp

To: broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21441: Start krunner later

2019-05-28 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5bb4680bcffc: Start krunner later (authored by broulik).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21441?vs=58755=58756

REVISION DETAIL
  https://phabricator.kde.org/D21441

AFFECTED FILES
  krunner/krunner.desktop

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, kde-frameworks-devel, mart, jraleigh, GB_2, ragreen, Pitel, 
michaelh, ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D21439: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one

2019-05-28 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 387590
  FIXED-IN: 5.16.0

TEST PLAN
  Enabled automatic touchpad disabling when plugging in a mouse.
  Plugged in a mouse, got a "touchpad disabled" notification, unplugged it, 
notification vanished.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21439

AFFECTED FILES
  kcms/touchpad/src/kded/kded.cpp
  kcms/touchpad/src/kded/kded.h

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21423: [Notifications] Don't show blue icon when a notification is active

2019-05-28 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:100075ab4413: [Notifications] Dont show blue icon 
when a notification is active (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21423?vs=58705=58751

REVISION DETAIL
  https://phabricator.kde.org/D21423

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  libnotificationmanager/notifications.cpp

To: broulik, #plasma, #vdg, ndavis, ngraham
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21147: Null pointer dereference at ksysguard

2019-05-28 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:c5bc3a6c5d31: Null pointer dereference at ksysguard 
(authored by gkaragiannidis, committed by davidedmundson).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21147?vs=58214=58750

REVISION DETAIL
  https://phabricator.kde.org/D21147

AFFECTED FILES
  ksysguardd/conf.c

To: gkaragiannidis, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21431: [kaccess] Don't talk to ksmserver

2019-05-28 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:43b8cab44b6c: [kaccess] Dont talk to ksmserver 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21431?vs=58729=58748

REVISION DETAIL
  https://phabricator.kde.org/D21431

AFFECTED FILES
  kaccess/main.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21434: [Notifications KCM] Try both model indices

2019-05-28 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:85359e1d4b22: [Notifications KCM] Try both model indices 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21434?vs=58737=58749

REVISION DETAIL
  https://phabricator.kde.org/D21434

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: broulik, #plasma, nicolasfella, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21438: [plasmashell] Don't talk to ksmserver

2019-05-28 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We don't need any of its session restoration capabilities but it still talks 
to ksmserver just to then have us discard all the info anyway.

TEST PLAN
  - Sent sigstop to ksmserver, started plasmashell, started fine now.
  
  Kicker (not Kickoff) might still block doing a `KWorkspace::canShutdown` on 
initialization, Kickoff does that only once you enter the Leave tab.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21438

AFFECTED FILES
  shell/main.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21431: [kaccess] Don't talk to ksmserver

2019-05-28 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  kaccess is invoked by kcminit which currently happens before ksmserver...at 
best it was racy.
  May as well make is explicit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21431

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21470: Properly read stderr when data is ready from the daemon.

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21436: Use onClicked for Home button

D21451: [System Tray] Ignore services that start with a colon (:)

D21460: [Notifications] Group applications with same display name but no desktop entry

D21439: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21460: [Notifications] Group applications with same display name but no desktop entry

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

D21438: [plasmashell] Don't talk to ksmserver

D21451: [System Tray] Ignore services that start with a colon (:)

D21441: Start krunner later

D21439: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one

D21423: [Notifications] Don't show blue icon when a notification is active

D21147: Null pointer dereference at ksysguard

D21431: [kaccess] Don't talk to ksmserver

D21434: [Notifications KCM] Try both model indices

D21438: [plasmashell] Don't talk to ksmserver

D21431: [kaccess] Don't talk to ksmserver

31 matches

Site Navigation

Mail list logo

Footer information