D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes marked 5 inline comments as done.
avaldes added a comment.


  Added changes based on recent comments.

INLINE COMMENTS

> abalaji wrote in suspendsessionconfig.cpp:106
> Stray line swap

Done on purpose to change the UI:

F6822188: suspendThenHibernate.png 

Automatically, m_comboBox, m_idleTime

> abalaji wrote in suspendsessionconfig.cpp:121
> Not sure if this is necessary, just `delete m_suspendThenHibernateEnabled` 
> might be enough.

yeah it's necessary, without it powerdevil crashes at launch

REPOSITORY
  R122 Powerdevil

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: jobauer, reverendhomer, meven, soriano, abalaji, graesslin, ngraham, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes updated this revision to Diff 58969.
avaldes added a comment.


  Added new Suspend then Hibernate option
  
  Summary:
  See bug 399727  for a good 
description of what this code is for.
  
  The new ui will show a new option like the following image F6822188: 
suspendThenHibernate.png 
  
  FEATURE: 399727
  
  Reviewers: broulik, ngraham
  
  Subscribers: soriano, abalaji, graesslin, ngraham, plasma-devel
  
  Tags: #plasma 
  
  Differential Revision: https://phabricator.kde.org/D16425

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16425?vs=58273&id=58969

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

AFFECTED FILES
  daemon/actions/bundled/suspendsession.cpp
  daemon/actions/bundled/suspendsession.h
  daemon/actions/bundled/suspendsessionconfig.cpp
  daemon/actions/bundled/suspendsessionconfig.h
  daemon/backends/upower/login1suspendjob.cpp
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/upowersuspendjob.cpp
  daemon/org.freedesktop.PowerManagement.xml
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilfdoconnector.cpp
  daemon/powerdevilfdoconnector.h
  daemon/powerdevilpowermanagement.cpp
  daemon/powerdevilpowermanagement.h

To: avaldes, broulik, ngraham
Cc: jobauer, reverendhomer, meven, soriano, abalaji, graesslin, ngraham, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Siddhartha Sahu]

siddharthasahu added a comment.


  Friendly ping! Since the behaviour is already different, can we merge this 
one and work on the SDDM part in a later PR?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

[Aleksei Nikiforov]

i.Dark_Templar added a comment.


  In D19829#472621 , @ngraham wrote:
  
  > @i.Dark_Templar can you land this yourself?
  
  
  I don't think I have access for that. Also I don't have Arc at the moment, 
and there's no indication in web interface that I have capability to do it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[David Faure]

dfaure added a comment.


  Writing into the user's home dir is a "hack".
  
  There are better ways for distros to set defaults (such as the global 
mimeapps.list) but it seems KIO ignores that... (to be checked...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  I don't think it's a "distro hack" to set a default browser, which is why 
they all do it. Not having a default browser set seems like an error condition 
to me. However I see what you meanabout the bugginess and will work on it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19829: kicker: add option to make root level icons visible

[Nathaniel Graham]

ngraham added a comment.


  @i.Dark_Templar can you land this yourself?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  I'm still a bit grumpy about this and dragging my feet! My gut still says 
it's both option clutter and UI noise :-)
  
  However:
  
  - There's a fair amount of people calling for this now.
  - The underlying code is already there.
  - Since the codepath is already in, it's more likely to bitrot when there 
isn't a GUI option that allows testing it.
  
  It's a go.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I agree that we shouldn't remove the underlying feature, in fact it's still 
used on other protocols than http.
  
  But we have to ensure the default behaviour matches the KCM and vice-versa, 
for http.

INLINE COMMENTS

> componentchooserbrowser.cpp:68
> +if (browserCombo->count() > 0) {
> +const QString &storageId = 
> browserCombo->currentData().toString();
> +m_browserService = KService::serviceByStorageId(storageId);

This will lead to rather confusing user experience, btw.

On a freshly installed system [without distro hacks], BrowserApplication is 
empty.
In practice that means KRun::setEnableExternalBrowser will pick the entry 
x-scheme-handler/https in the user's mimeapps.list, if any. And if that isn't 
set either, then well, the current behaviour in KRun, AFAICS, *will* be to use 
KIO to find out the mimetype.

Then the user opens this KCM, and it says "your default browser is firefox" (or 
whichever is first in the list). "What?" says the user... "that's not what I'm 
experiencing..."

If you want to change the default behaviour, you need to actually change the 
default behaviour (in KRun), not just what the KCM shows by default.

The default behaviour of KRun and the default settings shown by this KCM have 
to match.

This investigation shows that this is already buggy before this patch (the 
fallback to x-scheme-handler/https in the user's mimeapps.list is missing 
here), but this patch makes it much worse, as is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D21514: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet

[David Faure]

dfaure created this revision.
dfaure added reviewers: mart, apol, broulik.
Herald added a project: Plasma.
dfaure requested review of this revision.

REVISION SUMMARY
  This file checks for controlRoot being undefined, everywhere else.

TEST PLAN
  `qmlscene tests/testComboBox.qml` showed
  MobileTextActionsToolBar.qml:62: TypeError: Cannot read property 
'selectedText' of null
  MobileTextActionsToolBar.qml:70: TypeError: Cannot read property 
'selectedText' of null
  MobileTextActionsToolBar.qml:78: TypeError: Cannot read property 'canPaste' 
of null

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  2019_fix_MobileTextActionsToolBar_warnings

REVISION DETAIL
  https://phabricator.kde.org/D21514

AFFECTED FILES
  org.kde.desktop/private/MobileTextActionsToolBar.qml

To: dfaure, mart, apol, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21513: queue load() after all deleteLater() in unload() are done

[Nathaniel Graham]

ngraham added a comment.


  Stable branch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21513

To: mart, #plasma, davidedmundson
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21513: queue load() after all deleteLater() in unload() are done

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b059097a5bc1: queue load() after all deleteLater() in 
unload() are done (authored by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21513?vs=58960&id=58961

REVISION DETAIL
  https://phabricator.kde.org/D21513

AFFECTED FILES
  shell/shellcorona.cpp

To: mart, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21513: queue load() after all deleteLater() in unload() are done

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  Put load in queue of the event loop to wait for the whole set of containments 
to have been deleteLater(), as some like FolderView operate on singletons which 
can cause inconsistent states

TEST PLAN
  now switching look and feel between 2 themes that use both FolderView
  as desktop containment, the icons are still there

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/queueload

REVISION DETAIL
  https://phabricator.kde.org/D21513

AFFECTED FILES
  shell/shellcorona.cpp

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham added a comment.


  Can you update the test plan to provide examples of themes that are correctly 
tagged so we can test this?
  
  - Plasma 5 only theme
  - Plasma 4 only theme
  - Theme that works on both Plasma 4 and 5

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Nathaniel Graham]

ngraham added reviewers: Frameworks, dfaure.
ngraham added a comment.


  I'm still not sure whether the feature needs to be removed entirely. I feel 
that this minimal patch probably stands on its own well enough as-is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#472514 , @ngraham wrote:
  
  > Is the content actually tagged appropriately yet? When I test this out I 
see no effect, i.e. old Plasma 4 themes like OLED Orange 
(https://store.kde.org/p/998790/) are still visible.
  
  
  Not all of it, no - we do have a bit of a chicken/egg situation going on 
here, but at least the one you linked to isn't tagged with appropriate 
versioning information (https://api.kde-look.org/ocs/v1/content/data/998790 is 
the full xml data for that item). Fair bunch of them are, though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good and works for me, though I'm not super familiar with this code so 
I'd appreciate a review from @hein or @broulik.

REVISION DETAIL
  https://phabricator.kde.org/D21497

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain updated this revision to Diff 58951.
McPain added a comment.


  style: for

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21497?vs=58950&id=58951

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  kcms/keyboard/keyboard_config.cpp
  kcms/keyboard/keyboard_daemon.cpp

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> keyboard_config.cpp:112
> +QList x11layouts = X11Helper::getLayoutsList();
> +for(const LayoutUnit& layoutUnit : x11layouts) {
> +layouts.append(layoutUnit);

Style: space between `for` and `(`

> keyboard_config.cpp:116
> +} else {
> +for(const QString& layoutString : layoutStrings) {
> +layouts.append(LayoutUnit(layoutString));

Ditto

REVISION DETAIL
  https://phabricator.kde.org/D21497

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain updated this revision to Diff 58950.
McPain added a comment.


  foreach -> for
  use const

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21497?vs=58932&id=58950

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  kcms/keyboard/keyboard_config.cpp
  kcms/keyboard/keyboard_daemon.cpp

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham added a comment.


  Is the content actually tagged appropriately yet? When I test this out I see 
no effect, i.e. old Plasma 4 themes like OLED Orange 
(https://store.kde.org/p/998790/) are still visible.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21507: Remove DefaultListItemBackground and MenuItem animation

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:59d06ca5df04: Remove DefaultListItemBackground and 
MenuItem animation (authored by GB_2).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21507?vs=58947&id=58949

REVISION DETAIL
  https://phabricator.kde.org/D21507

AFFECTED FILES
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/private/DefaultListItemBackground.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21507: Remove DefaultListItemBackground and MenuItem animation

[Björn Feber]

GB_2 added a comment.


  In D21507#472482 , @mart wrote:
  
  > no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo 
shouldn't be removed
  
  
  Ok, but if the DefaultListItemBackground animation there doesn't get removed 
there is still an animation the sidebar of SySe and Discover.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  remove-defaultlistitembackground-animation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21507

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21507: Remove DefaultListItemBackground and MenuItem animation

[Björn Feber]

GB_2 added a comment.


  In D21507#472482 , @mart wrote:
  
  > no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo 
shouldn't be removed
  
  
  Thanks!

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  remove-defaultlistitembackground-animation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21507

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21507: Remove DefaultListItemBackground animation

[Björn Feber]

GB_2 updated this revision to Diff 58947.
GB_2 added a comment.


  Change MenuItem too

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21507?vs=58922&id=58947

BRANCH
  remove-defaultlistitembackground-animation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21507

AFFECTED FILES
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/private/DefaultListItemBackground.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21497: fill layouts from X server when there are no layouts in config

[Nathaniel Graham]

ngraham added a comment.


  Thanks, it works now!

INLINE COMMENTS

> keyboard_config.cpp:112
> +QList x11layouts = X11Helper::getLayoutsList();
> +foreach(LayoutUnit layoutUnit, x11layouts) {
> +layouts.append(layoutUnit);

While you're touching this, port away from `foreach`, which is deprecated.

Also more const

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21497

To: McPain, ngraham, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21507: Remove DefaultListItemBackground animation

[Marco Martin]

mart added a comment.


  it's MenuI
  
  In D21507#472376 , @GB_2 wrote:
  
  > In D21507#472356 , @ngraham 
wrote:
  >
  > > I would guess that the code is somewhere in 
https://cgit.kde.org/kirigami.git/tree/src/controls/private/ActionButton.qml
  >
  >
  > Removing all animations there doesn't affect it :(
  
  
  no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo 
shouldn't be removed

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  remove-defaultlistitembackground-animation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21507

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D15247: Show tooltips in krunner

[Nathaniel Graham]

ngraham added a comment.


  In D15247#472419 , @McPain wrote:
  
  > In D15247#472255 , @ngraham 
wrote:
  >
  > > I am still not actually getting any tooltips when I hover over an elided 
entry.
  > >
  > > F6860589: Screenshot_20190530_114108.png 

  >
  >
  > strange
  >  F6861650: изображение.png 
  
  
  IMO what's seen in your screenshot is not useful behavior. If the full text 
fits in the regular UI, there's no need to show a tooltip; it's just redundant.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham, mart
Cc: mart, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 58937.
leinir added a comment.


  - Add TagFilter (for top level tags), and don't explicitly reject 4

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=58935&id=58937

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  In D15247#472255 , @ngraham wrote:
  
  > I am still not actually getting any tooltips when I hover over an elided 
entry.
  >
  > F6860589: Screenshot_20190530_114108.png 

  
  
  strange
  F6861650: изображение.png 

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham, mart
Cc: mart, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Following a lengthy discussion on the topic[1], the first step
  towards getting themes cleaned up and hidden when they don't
  work is to get the ones hidden which are only for Plasma 4.
  We do this by filtering out any theme which is tagged as
  being for the major version 4 of plasma. We also allow themes
  through which have been tested to work on both, by accepting
  themes which are tagged as both 4 and 5.
  
  [1] https://phabricator.kde.org/T8126#184198 and down a few pages

TEST PLAN
  See themes tagged as plasma##majorversion=4 being hidden, except when they
  are also tagged as plasma##majorversion=5. This can most easily be done
  by launching the plasma theme dialog and opening Get New Themes from there
  and turning on debugging for KNewStuff(Core) like so:
  
  `QT_LOGGING_RULES="org.kde.knewstuff*=true" kcmshell5 kcm_desktoptheme`
  
  and then watching the output, and seeing that content is being rejected
  by the InequalityFilter for plasma##majorversion when appropriate.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21507: Remove DefaultListItemBackground animation

[Björn Feber]

GB_2 added a comment.


  In D21507#472356 , @ngraham wrote:
  
  > I would guess that the code is somewhere in 
https://cgit.kde.org/kirigami.git/tree/src/controls/private/ActionButton.qml
  
  
  Removing all animations there doesn't affect it :(

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  remove-defaultlistitembackground-animation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21507

To: GB_2, #plasma, #vdg, ngraham
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21497: fill layouts from X server when there are no layouts in config

[Oleg Solovyov]

McPain updated this revision to Diff 58932.
McPain set the repository for this revision to R119 Plasma Desktop.
McPain added a comment.


  updated paths

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21497?vs=58911&id=58932

REVISION DETAIL
  https://phabricator.kde.org/D21497

AFFECTED FILES
  kcms/keyboard/keyboard_config.cpp
  kcms/keyboard/keyboard_daemon.cpp

To: McPain, ngraham, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart