D21503: [Calculator] Make buttons' text labels scale in size along with the widget

2019-06-03 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> calculator.qml:39
>  Plasmoid.switchHeight: Layout.minimumHeight
>  Layout.minimumWidth: mainLayout.Layout.minimumWidth + 8
>  Layout.minimumHeight: mainLayout.Layout.minimumHeight + 8

This will change with the font size, surely breaking it?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21503

To: ngraham, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D16425: Added new Suspend then Hibernate option

2019-06-03 Thread Ambareesh Balaji 
abalaji added inline comments.

INLINE COMMENTS

> suspendsessionconfig.cpp:122
> +int comboBoxMaxWidth = 300;
> +if (m_suspendThenHibernateEnabled) {
> +comboBoxMaxWidth = qMax(comboBoxMaxWidth, 
> m_suspendThenHibernateEnabled->sizeHint().width());

After doing the above, this if block can be merged with the above if block, if 
you know what I mean.

> avaldes wrote in suspendsessionconfig.cpp:106
> Done on purpose to change the UI:
> 
> F6822188: suspendThenHibernate.png 
> 
> Automatically, m_comboBox, m_idleTime

Oh i see, that actually makes sense

> avaldes wrote in suspendsessionconfig.cpp:121
> yeah it's necessary, without it powerdevil crashes at launch

Yeah it crashes because you're probably not doing a null check somewhere. I 
would suggest initializing `m_suspendThenHibernateEnabled ` to nullptr in the 
ctor, moving line 79 into this if block right above, and getting rid of this 
else block altogether, that way you don't wastefully allocate the object. After 
this, check for nullptr in every place you use `m_suspendThenHibernateEnabled`.

REPOSITORY
  R122 Powerdevil

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: jobauer, reverendhomer, meven, soriano, abalaji, graesslin, ngraham, 
plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21561: [Notifier] Delay creating QNetworkConfigurationManager

2019-06-03 Thread David Edmundson 
davidedmundson added a comment.


  Is QNetworkAccessManager::networkAccessible any better?
  
  It has an unknown state which implies it might be async.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21561

To: broulik, #plasma, apol
Cc: davidedmundson, plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21561: [Notifier] Delay creating QNetworkConfigurationManager

2019-06-03 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Yes, it's a big one.
  
  I was wondering if it would make sense to see if we can improve it on Qt 
level.

INLINE COMMENTS

> DiscoverNotifier.cpp:166
>  {
> +if (!m_manager) {
> +m_manager = new QNetworkConfigurationManager(this);

Explain why in a short comment. Something like `// delay initializing, Qt does 
a bunch of blocking calls there when using networkmanager`

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21561

To: broulik, #plasma, apol
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:21d8bf8b8700: [sddm-theme] Update theme preview with 5.16 
wallpaper (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21560?vs=59095=59096

REVISION DETAIL
  https://phabricator.kde.org/D21560

AFFECTED FILES
  sddm-theme/preview.png

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit! Stable branch, obviously

REPOSITORY
  R120 Plasma Workspace

BRANCH
  new-sddm-theme-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21560

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Filip Fila 
filipf updated this revision to Diff 59095.
filipf added a comment.


  mask white glow on left side

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21560?vs=59091=59095

BRANCH
  new-sddm-theme-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21560

AFFECTED FILES
  sddm-theme/preview.png

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Filip Fila 
filipf updated this revision to Diff 59091.
filipf added a comment.


  change time from 00:00 to 13:37

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21560?vs=59063=59091

BRANCH
  new-sddm-theme-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21560

AFFECTED FILES
  sddm-theme/preview.png

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21566: Improve label for Disk Monitor widget

2019-06-03 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently it uses up and down arrows, which do not really map to "read" and 
"write".
  
  This patch makes the up/down labels overridable properties, and makes the 
Disk Monitor
  widget use the new properties to set slearer labels.

TEST PLAN
  F6866567: Legends.png 
  
  (text contrast is not great in this screenshot because my VM isn't blurring 
the translucent
  background. Also, that's a separate issue for another patch)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  better-disk-monitor-label (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21566

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10362: Change reveal password button logic

2019-06-03 Thread Björn Feber 
GB_2 added a comment.


  In D10362#202592 , 
@elvisangelaccio wrote:
  
  > Hmm I don't know, that's a button and a button should tell me what happens 
when I click it (Dolphin is also wrong imho).
  >
  > Would it be possible to implement this feature like in the Windows 10 lock 
screen? (i.e. don't toggle the state; reveal the password only as long as the 
button is pressed). I feel like it would remove the security issue in the first 
place (as there isn't anymore a persistent state where the password can be 
visible).
  
  
  Done.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, michaelh, ZrenBot, 
bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber 
GB_2 added a comment.


  Changed `onClicked` to `onPressedChanged`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, michaelh, ZrenBot, 
bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber 
GB_2 updated this revision to Diff 59081.
GB_2 added a comment.


  Change reveal password button logic

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10362?vs=26701=59081

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TextField.qml

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, michaelh, ZrenBot, 
bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

2019-06-03 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:987f5fe9bb12: [Calculator] Make buttons text labels 
scale in size along with the widget (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21503?vs=58918=59079

REVISION DETAIL
  https://phabricator.kde.org/D21503

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: ngraham, #plasma, broulik
Cc: broulik, plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

2019-06-03 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  That 12 is a bit random, isn't it? But glad my approach just works™

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21503

To: ngraham, #plasma, broulik
Cc: broulik, plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

2019-06-03 Thread Marco Martin 
mart added a comment.


  This is the rough patch which gives a rough implementation of this look into 
qwidget config dialogs
  F6866217: fullsidebar.diff 
  
  The real hack which I consider a no-go (and no idea how to avoid) is this 
piece:
  
  - layout->addWidget(mButtonBox);
  
  +if (mPageWidget && mPageWidget->layout()) {
  +mButtonBox->setParent(mPageWidget);
  +
static_cast(mPageWidget->layout())->addWidget(mButtonBox, 4, 1);
  +} else {
  +layout->addWidget(mButtonBox);
  +}
  
  it reparents the buttonbox inside the pagewidget itself to have the buttons 
laid out considering the sidebar.
  This will break badly and possibily crash in many situations, so ideas for 
alternative implementations welcome :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, ericadams, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Nathaniel Graham 
ngraham added a comment.


  Hah, why not? :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21560

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Filip Fila 
filipf added a comment.


  In D21560#473670 , @ngraham wrote:
  
  > Just seems like kind of an odd time to have in the screenshot. Maybe choose 
some other random time, like 9:30 or something.
  
  
  OK, I will edit the diff in a few hours or so (compiling from scratch now so 
can't log out). Can I do 13:37? :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21560

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Nathaniel Graham 
ngraham added a comment.


  Just seems like kind of an odd time to have in the screenshot. Maybe choose 
some other random time, like 9:30 or something.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21560

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Filip Fila 
filipf added a comment.


  In D21560#473664 , @ngraham wrote:
  
  > `00:00`?
  
  
  I did the 24 hour system, but didn't get any idea about a meaningful number. 
I'm open to suggestions.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21560

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Nathaniel Graham 
ngraham added a comment.


  `00:00`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21560

To: filipf, GB_2, ngraham, #vdg
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21561: [Notifier] Delay creating QNetworkConfigurationManager

2019-06-03 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Creating it is quite heavy (25ms here) as it has to query NetworkManager for 
information.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21561

AFFECTED FILES
  notifier/DiscoverNotifier.cpp
  notifier/DiscoverNotifier.h

To: broulik, #plasma, apol
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

2019-06-03 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Our current preview has become inaccurate.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  new-sddm-theme-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21560

AFFECTED FILES
  sddm-theme/preview.png

To: filipf
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21433: [kdecoration] Unset resize borders for maximized clients

2019-06-03 Thread Vlad Zagorodniy 
zzag abandoned this revision.
zzag added a comment.


  Hugo will push a bit simpler solution.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D21433

To: zzag, #plasma
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21432: [kdecoration] Unset resize borders for maximized clients

2019-06-03 Thread Vlad Zagorodniy 
zzag abandoned this revision.
zzag added a comment.


  Hugo will push a bit simpler solution.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D21432

To: zzag, #plasma
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

2019-06-03 Thread Oleg Solovyov 
McPain added a comment.


  In D15247#472461 , @ngraham wrote:
  
  > IMO what's seen in your screenshot is not useful behavior. If the full text 
fits in the regular UI, there's no need to show a tooltip; it's just redundant.
  
  
  I see. Somehow `subTextLabel.truncated` is always true

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham, mart
Cc: mart, abetts, ngraham, plasma-devel, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D21497: fill layouts from X server when there are no layouts in config

2019-06-03 Thread Oleg Solovyov 
McPain added a comment.


  In D21497#472546 , @ngraham wrote:
  
  > Looks good and works for me, though I'm not super familiar with this code 
so I'd appreciate a review from @hein or @broulik.
  
  
  I'll land this tomorrow if everything will be still ok

REVISION DETAIL
  https://phabricator.kde.org/D21497

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21557: [Media Controller] Anchor album art left and right as well

2019-06-03 Thread Filip Fila 
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Fixes it for me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21557

To: broulik, #plasma, filipf
Cc: filipf, plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21557: [Media Controller] Anchor album art left and right as well

2019-06-03 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0cd335211ad4: [Media Controller] Anchor album art left 
and right as well (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21557?vs=59055=59056

REVISION DETAIL
  https://phabricator.kde.org/D21557

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: broulik, #plasma, filipf
Cc: filipf, plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21557: [Media Controller] Anchor album art left and right as well

2019-06-03 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures it doesn't overflow its bounding box. Shouldn't make a visual 
differences (save for the margin) as it is `PreserveAspectFit`
  
  BUG: 408101
  FIXED-IN: 5.16.0

TEST PLAN
  Put media controller on desktop, started youtube video (which provides a 16:9 
thumbnail through p-b-i), resized the plasmoid to weird sizes, didn't overflow 
anymore.
  Still looked the same in systray popup

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21557

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: broulik, #plasma
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

2019-06-03 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8f1daa56f9e8: Better notification number alignment 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21408?vs=58711=59050#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21408?vs=58711=59050

REVISION DETAIL
  https://phabricator.kde.org/D21408

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  applets/notifications/package/contents/ui/TightLabel.qml

To: broulik, #plasma, #vdg, ngraham
Cc: lavender, cfeck, davidedmundson, ngraham, ndavis, plasma-devel, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21554: Allow setting fullscreen via MPRIS

2019-06-03 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This implements `CanSetFullscreen` to return `true` when it's a video and 
lets the `Fullscreen` property reflect and change the fullscreen state of the 
player.
  
  BUG: 408059

TEST PLAN
  YouTube sets the entire website as fullscreen and gets confused when just 
fullscreening the player but it works fine in e.g. Vimeo.
  If the video autostarted it refuses to fullscreen it as there hasn't benn any 
user interaction, otherwise works fine.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21554

AFFECTED FILES
  extension/content-script.js
  extension/extension.js
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21038: Also store the player's frame ID

2019-06-03 Thread Kai Uwe Broulik 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:71b4b66d5cf1: Also store the players frame ID 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21038?vs=57633=59048

REVISION DETAIL
  https://phabricator.kde.org/D21038

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart