D21828: Invert controls direction for process priority slider

2019-06-15 Thread Christoph Feck 
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21828

To: kishoreg, cfeck
Cc: cfeck, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread Björn Feber 
GB_2 added a comment.


  I think `plasma-sddm.conf` is a better filename.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  new-config-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21832

To: filipf, davidedmundson, ngraham, #plasma
Cc: GB_2, plasma-devel, LeGast00n, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Good stuff, thanks

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  new-config-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21832

To: filipf, davidedmundson, ngraham, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21832: [sddm-kcm] WIP: Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread Filip Fila 
filipf marked 3 inline comments as done.
filipf added inline comments.

INLINE COMMENTS

> davidedmundson wrote in sddmauthhelper.cpp:86
> if something is going into the file "kde_settings.conf" then we want to 
> remove it from sddmOldConfig
> 
> Nothing in args is sent with this filename

Thanks! This is what I was not figuring out properly all along.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21832

To: filipf, davidedmundson, ngraham, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21832: [sddm-kcm] WIP: Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread Filip Fila 
filipf updated this revision to Diff 59890.
filipf added a comment.


  - revert 2 unecessary changes to file location
  - actually delete duplicate entries from sddm.conf
  - tidy up comment

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21832?vs=59883&id=59890

BRANCH
  new-config-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21832

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp
  src/sddmkcm.cpp
  src/sddmkcm.h
  src/themeconfig.cpp

To: filipf, davidedmundson, ngraham, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 33 - Still Failing!

2019-06-15 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/33/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 15 Jun 2019 18:12:34 +
 Build duration:
1 hr 46 min and counting
   CONSOLE OUTPUT
  [...truncated 222 lines...][2019-06-15T19:58:40.738Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-15T19:58:40.738Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-06-15T19:58:40.738Z] PROCESSOR_LEVEL   = '6'[2019-06-15T19:58:40.738Z] PROCESSOR_REVISION= '5e03'[2019-06-15T19:58:40.738Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-15T19:58:40.738Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-15T19:58:40.738Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-15T19:58:40.738Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-15T19:58:40.738Z] PROMPT= '$P$G'[2019-06-15T19:58:40.738Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-15T19:58:40.738Z] PUBLIC= 'C:\Users\Public'[2019-06-15T19:58:40.738Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/33/display/redirect?page=changes'[2019-06-15T19:58:40.738Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/33/display/redirect'[2019-06-15T19:58:40.738Z] STAGE_NAME= 'Configuring Build'[2019-06-15T19:58:40.738Z] SYSTEMDRIVE   = 'C:'[2019-06-15T19:58:40.738Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-15T19:58:40.738Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-15T19:58:40.738Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-15T19:58:40.738Z] UCRTVERSION   = '10.0.17763.0'[2019-06-15T19:58:40.738Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-15T19:58:40.738Z] USERDOMAIN= 'DESKTOP-66R8QOQ'[2019-06-15T19:58:40.738Z] USERNAME  = 'Jenkins'[2019-06-15T19:58:40.738Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-15T19:58:40.738Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-15T19:58:40.738Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-15T19:58:40.738Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-15T19:58:40.738Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-15T19:58:40.738Z] VCTOOLSVERSION= '14.16.27023'[2019-06-15T19:58:40.738Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-15T19:58:40.738Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-15T19:58:40.738Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-15T19:58:40.738Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-15T19:58:40.738Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-15T19:58:40.738Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-15T19:58:40.738Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-15T19:58:40.738Z] VSCMD_VER = '16.0.3'[2019-06-15T19:58:40.738Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-15T19:58:40.738Z] WINDIR= 'C:\WINDOWS'[2019-06-15T19:58:40.738Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-15T19:58:40.738Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-15T19:58:40.738Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-15T19:58:40.738Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-15T19:58:40.738Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-15T19:58:40.738Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-15T19:58:40.738Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-06-15T19:58:40.738Z] __DOTNET_ADD_64BIT= '1'[2019-06-15T19:58:40.738Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-15T19:58:40.739Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-15T19:58:40.739Z] CMAKE_PREFIX_PATH

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Still Failing!

2019-06-15 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/32/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 14 Jun 2019 13:07:03 +
 Build duration:
1 day 5 hr and counting
   CONSOLE OUTPUT
  [...truncated 222 lines...][2019-06-15T18:12:13.772Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-15T18:12:13.772Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-06-15T18:12:13.772Z] PROCESSOR_LEVEL   = '6'[2019-06-15T18:12:13.772Z] PROCESSOR_REVISION= '5e03'[2019-06-15T18:12:13.772Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-15T18:12:13.772Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-15T18:12:13.772Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-15T18:12:13.772Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-15T18:12:13.772Z] PROMPT= '$P$G'[2019-06-15T18:12:13.772Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-15T18:12:13.772Z] PUBLIC= 'C:\Users\Public'[2019-06-15T18:12:13.772Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/32/display/redirect?page=changes'[2019-06-15T18:12:13.772Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/32/display/redirect'[2019-06-15T18:12:13.772Z] STAGE_NAME= 'Configuring Build'[2019-06-15T18:12:13.772Z] SYSTEMDRIVE   = 'C:'[2019-06-15T18:12:13.772Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-15T18:12:13.772Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-15T18:12:13.772Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-15T18:12:13.772Z] UCRTVERSION   = '10.0.17763.0'[2019-06-15T18:12:13.772Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-15T18:12:13.772Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-15T18:12:13.772Z] USERNAME  = 'Jenkins'[2019-06-15T18:12:13.772Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-15T18:12:13.772Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-15T18:12:13.772Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-15T18:12:13.772Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-15T18:12:13.772Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-15T18:12:13.772Z] VCTOOLSVERSION= '14.16.27023'[2019-06-15T18:12:13.772Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-15T18:12:13.772Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-15T18:12:13.772Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-15T18:12:13.772Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-15T18:12:13.772Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-15T18:12:13.772Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-15T18:12:13.772Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-15T18:12:13.772Z] VSCMD_VER = '16.0.3'[2019-06-15T18:12:13.772Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-15T18:12:13.772Z] WINDIR= 'C:\WINDOWS'[2019-06-15T18:12:13.772Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-15T18:12:13.772Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-15T18:12:13.772Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-15T18:12:13.772Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-15T18:12:13.772Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-15T18:12:13.772Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-15T18:12:13.772Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-06-15T18:12:13.772Z] __DOTNET_ADD_64BIT= '1'[2019-06-15T18:12:13.772Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-15T18:12:13.772Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-15T18:12:13.772Z] CMAKE_PREFIX_PATH

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 9 - Still Failing!

2019-06-15 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/9/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 14 Jun 2019 13:07:03 +
 Build duration:
1 day 5 hr and counting
   CONSOLE OUTPUT
  [...truncated 223 lines...][2019-06-15T18:10:47.305Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-15T18:10:47.305Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-06-15T18:10:47.305Z] PROCESSOR_LEVEL   = '6'[2019-06-15T18:10:47.305Z] PROCESSOR_REVISION= '5e03'[2019-06-15T18:10:47.305Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-15T18:10:47.305Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-15T18:10:47.305Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-15T18:10:47.305Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-15T18:10:47.305Z] PROMPT= '$P$G'[2019-06-15T18:10:47.305Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-15T18:10:47.305Z] PUBLIC= 'C:\Users\Public'[2019-06-15T18:10:47.305Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/9/display/redirect?page=changes'[2019-06-15T18:10:47.305Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/9/display/redirect'[2019-06-15T18:10:47.305Z] STAGE_NAME= 'Configuring Build'[2019-06-15T18:10:47.305Z] SYSTEMDRIVE   = 'C:'[2019-06-15T18:10:47.305Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-15T18:10:47.305Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-15T18:10:47.305Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-15T18:10:47.305Z] UCRTVERSION   = '10.0.17763.0'[2019-06-15T18:10:47.305Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-15T18:10:47.305Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-15T18:10:47.305Z] USERNAME  = 'Jenkins'[2019-06-15T18:10:47.305Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-15T18:10:47.305Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-15T18:10:47.305Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-15T18:10:47.305Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-15T18:10:47.305Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-15T18:10:47.305Z] VCTOOLSVERSION= '14.16.27023'[2019-06-15T18:10:47.305Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-15T18:10:47.305Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-15T18:10:47.305Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-15T18:10:47.305Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-15T18:10:47.305Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-15T18:10:47.305Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-15T18:10:47.305Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-15T18:10:47.305Z] VSCMD_VER = '16.0.3'[2019-06-15T18:10:47.305Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-15T18:10:47.305Z] WINDIR= 'C:\WINDOWS'[2019-06-15T18:10:47.305Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-15T18:10:47.305Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-15T18:10:47.305Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-15T18:10:47.305Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-15T18:10:47.305Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-15T18:10:47.305Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-15T18:10:47.305Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11'[2019-06-15T18:10:47.305Z] __DOTNET_ADD_64BIT= '1'[2019-06-15T18:10:47.305Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-15T18:10:47.305Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-15T1

D21832: [sddm-kcm] WIP: Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> sddmauthhelper.cpp:86
> +// see: 
> https://github.com/sddm/sddm/blob/develop/src/common/ConfigReader.cpp#L144
> +if (fileName == QStringLiteral("sddm.conf") && 
> (args.count(keyName) > 1)) {
> +sddmOldConfig->group(groupName).deleteEntry(keyName);

if something is going into the file "kde_settings.conf" then we want to remove 
it from sddmOldConfig

Nothing in args is sent with this filename

> sddmkcm.cpp:60
>  
> -mSddmConfig = 
> KSharedConfig::openConfig(QStringLiteral(SDDM_CONFIG_FILE), 
> KConfig::CascadeConfig);
> +mSddmConfig = 
> KSharedConfig::openConfig(QStringLiteral("kde_settings.conf"), 
> KConfig::CascadeConfig);
> +

This file doesn't need to be changed at all

> sddmkcm.cpp:74
>  
>  mSddmConfig->addConfigSources(systemConfigFiles + configFiles);
> +mSddmOldConfig->addConfigSources(systemConfigFiles + configFiles);

as it's all done here

> themesmodel.cpp:93
>  
> -QString themesBaseDir = 
> KSharedConfig::openConfig(QStringLiteral(SDDM_CONFIG_FILE), 
> KConfig::SimpleConfig)->group("Theme").readEntry("ThemeDir");
> +QString themesBaseDir = 
> KSharedConfig::openConfig(QStringLiteral("kde_settings.conf"), 
> KConfig::SimpleConfig)->group("Theme").readEntry("ThemeDir");
>  

this needs to be using the same logic as sddmkcm.cpp

probably easier if they share the same kconfig instance

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21832

To: filipf, davidedmundson, ngraham, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black 
cblack updated this revision to Diff 59884.
cblack added a comment.


  Use PC3 components in the kb & session buttons instead of PC2 components

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=59880&id=59884

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21832: [sddm-kcm] WIP: Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  As of SDDM release 0.16.0 it advised to use /etc/sddm.conf.d/ as the 
directory for user settings.
  
  This patch aims to achieve it by saving in that very same directory under the 
filename "kde_settings.conf".
  
  It must also remove identical entries from the old "sddm.conf" file because 
SDDM will simply load them instead of new user set values.
  
  BUG: 386241
  FIXED-IN: 5.17

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  new-config-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21832

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp
  src/sddmkcm.cpp
  src/sddmkcm.h
  src/themeconfig.cpp
  src/themesmodel.cpp

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black 
cblack added inline comments.

INLINE COMMENTS

> cblack wrote in SessionButton.qml:23
> The `menu` property seems to be removed in PC3

Additionally, `ToolButton` 

 still seems to use QQC1 even in PC3.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black 
cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SessionButton.qml:23
> Note that (confusingly) Plasma components 2 is QQC1
> Plasma components3 is QQC2
> 
> It might fix the menu issue

The `menu` property seems to be removed in PC3

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> SessionButton.qml:23
>  import org.kde.plasma.core 2.0 as PlasmaCore
>  import org.kde.plasma.components 2.0 as PlasmaComponents
>  

Note that (confusingly) Plasma components 2 is QQC1
Plasma components3 is QQC2

It might fix the menu issue

> SessionButton.qml:29
>  id: root
> -property int currentIndex: -1
> +implicitWidth: width
> +height: toolBtn.implicitHeight

I meant

implicitWidth: toolBtn.implicitWidth

width by default is bound to the implicitWidth so you don't need to set it
but more importantly you still have the data of the size something wants to be 
after someone else (a layout) sets the size

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Filip Fila 
filipf added a comment.


  Seems like you have all the QQC1 imports covered. I'm seeing a couple more in 
other files that are unused so it would be perfectly fine to remove them as a 
part of this diff.
  
  I'll give the new code a spin soon and then I can add more detailed comments.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

2019-06-15 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f65a0eee09da: PanelView: align setting of masks with how 
it's done for dialogs/tooltips (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21803?vs=59800&id=59882

REVISION DETAIL
  https://phabricator.kde.org/D21803

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: kossebau, #plasma, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: 5.17 Kickoff Meeting

2019-06-15 Thread Nate Graham 

On 6/15/19 2:00 AM, Jonathan Riddell wrote:
Great, I added it to the meeting etherpad, please go over the phab tasks 
and triage them.


Please also decide on a version of Qt to be the minimum, possibly Qt 
5.13 will be out by then.


And review the schedule we agreed on, release is currently pencilled in 
for October.

https://community.kde.org/Schedules/Plasma_5

  Jonathan




Sounds good to me. Also, since it worked pretty well for 5.16, here's an 
Etherpad we can use to note new features and bugfixes for Plasmas 5.17: 
https://notes.kde.org/p/plasma_5_17 (thank Björn for starting it).


Nate

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black 
cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SessionButton.qml:27
> Why the wrapper?

QML files can only have one root, and the ToolButton's `menu` property doesn't 
accept QQC2 menus, meaning they have to be separated.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black 
cblack updated this revision to Diff 59880.
cblack added a comment.


  Updates based off of feedback, and adding the standard menu fade animation to 
the QQC2 menus.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=59842&id=59880

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21690: Only show system total cpu usage by default on high core count machines

2019-06-15 Thread Robin Appelman 
rappelman added a comment.


  ro...@icewind.nl

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21690

To: rappelman, #plasma, #vdg, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21829: Improved Touch support for Kickoff

2019-06-15 Thread Steffen Hartleib 
steffenh created this revision.
steffenh added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
steffenh requested review of this revision.

REVISION SUMMARY
  - enabled touch scrolling in Kickoff
  - open the correct category in the application tab
  - open the context menu with touch (tapandhold gesture similar to Windows 10)
  - start drag action with touch similar to Windows 10 (Issue: drag Icon 
doesn't follow  touch point at the moment)
  
  BUG:406359
  BUG:406361

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff

REVISION DETAIL
  https://phabricator.kde.org/D21829

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffListView.qml

To: steffenh, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21828: Invert controls direction for process priority slider

2019-06-15 Thread Kishore Gopalakrishnan 
kishoreg updated this revision to Diff 59864.
kishoreg added a comment.


  Do the same for the ionice slider too.

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21828?vs=59862&id=59864

REVISION DETAIL
  https://phabricator.kde.org/D21828

AFFECTED FILES
  processui/ReniceDlgUi.ui

To: kishoreg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21828: Invert controls direction for process priority slider

2019-06-15 Thread Kishore Gopalakrishnan 
kishoreg created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kishoreg requested review of this revision.

REVISION SUMMARY
  Since low 'nice' values correspond to high priority, the slider labels are 
inverted so that 'higher' corresponds to a lower nice number. However, this was 
not done for the slider control, resulting in the arrow keys moving the slider 
in the direction opposite to that expected by the user. This patch fixes this 
by setting invertedControls to 'true' for the priority slider.
  
  BUG: 408074

TEST PLAN
  1. Open Ksysguard.
  2. Go to the tab that lists processes.
  3. Right click on a process and select 'Set Priority'.
  4. Click on the slider that sets the CPU priority.
  5. Press the left and right arrow keys on the keyboard and check if they move 
the slider in the appropriate direction.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21828

AFFECTED FILES
  processui/ReniceDlgUi.ui

To: kishoreg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: 5.17 Kickoff Meeting

2019-06-15 Thread Jonathan Riddell 
On Fri, 14 Jun 2019 at 19:36, Aleix Pol  wrote:

> On Fri, Jun 14, 2019 at 7:08 PM Jonathan Riddell  wrote:
> >
> > We would typically have a start of cycle Kickoff meeting sometime in the
> coming week.  But there is a Sprint happening next Wednesday to the
> following Wednesday.  I'm also aware that plenty people who normally spend
> time on Plasma are otherwise engaged and won't be able to take on so much
> in the coming cycle.
> >
> > So it is still useful to schedule a Kickoff meeting?  It could be while
> the Sprint was happening but held online still.
> >
> > Or is it better for people at the sprint to have a group discussion in
> person going over the Todo items and then I can chase up anyone else for
> Todo items outside that discussion?
>
> It could make sense to have a 5.17 discussion in the sprint and report
> it to the mailing list, then further discussions can happen here or
> the different phabricator tasks.
>

Great, I added it to the meeting etherpad, please go over the phab tasks
and triage them.

Please also decide on a version of Qt to be the minimum, possibly Qt 5.13
will be out by then.

And review the schedule we agreed on, release is currently pencilled in for
October.
https://community.kde.org/Schedules/Plasma_5

 Jonathan