D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

[N. Higa]

nhiga added a comment.


  In D21979#484281 , @ngraham wrote:
  
  > Sorry, my mistake. I missed that this tooltip is set on the wrong checkbox. 
It needs to be set on the "CPUs separately" checkbox
  
  
  This is intentional - if we set this on the "CPUs separately" checkbox, 
QTBUG-30801  will make this patch 
not useful, because the tooltip will not be shown when the checkbox is disabled 
(i.e. grayed out), and therefore Jung's issue will not be addressed (see below).
  
  > In Bug 408959 , Jung wrote:
  > The "CPUs separately" box in the system load viewer widget configuration is 
grayed out. There is no indication what I could/should do to be allowed to 
enable that checkbox.  That's at best confusing and at worst frustrating UI 
design.
  
  Another option would be to put this patch on hold and wait for QTBUG-30801 to 
be fixed, and find other ways to let the user know that he/she should choose 
"Compact bar" to enable "CPUs separately".

REVISION DETAIL
  https://phabricator.kde.org/D21979

To: nhiga, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22011: Add MenuSeparator

[Filip Fila]

filipf added a comment.


  In the after picture I'm noticing that the separator is 1px outside the frame 
when the menus is over a dark bg.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22011

To: astippich, mart, apol, ngraham
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22011: Add MenuSeparator

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> MenuSeparator.qml:37
> +width: controlRoot.width
> +height: 1
> +}

@mart does this need to be multiplied by the device pixel ratio to account for 
fractional scale factors? I forget.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22011

To: astippich, mart, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22012: Clean up old bug workaround in KCMFileIndexer

[Nathaniel Graham]

ngraham added subscribers: mart, ngraham.
ngraham added reviewers: mart, Plasma.
ngraham added a comment.


  @mart do you know the history of this?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22012

To: meven, mart, #plasma
Cc: ngraham, mart, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D22012: Clean up old bug workarount in KCMFileIndexer

[Méven Car]

meven created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22012

AFFECTED FILES
  Modules/fileindexermonitor/kcm.cpp

To: meven
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22011: Add MenuSeparator

[Alexander Stippich]

astippich added a comment.


  Related to D21944 
  Menu now looks like
  F6924938: menu_separator.png 
  
  before:
  F6924945: menu_before.png 

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22011

To: astippich, mart, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22011: Add MenuSeparator

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: mart, apol, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Make the MenuSeparator span the full width of the menu
  like in QWidget-based menus

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  menu_separator

REVISION DETAIL
  https://phabricator.kde.org/D22011

AFFECTED FILES
  org.kde.desktop/MenuSeparator.qml

To: astippich, mart, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21993: [Klipper] Always restore the last clipbboard item

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a comment.


  Arc didn't automatically close this because for some reason the commit 
message of what got committed lacked the Phab revision ID and the `BUG:` 
keyword. Not sure why.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21993

To: davidre, ngraham, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 60379.
cblack added a comment.


  - Change toolBtn to be more descriptive based on file the id was in
  - Styling changes on menus (they now have shadows)
  - Menu item highlight is tweaked as per T11124 
 (can revert if shouldn't be here)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=60136=60379

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22004: Increment iterator before any potential continue

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:51d16037ee16: Increment iterator before any potential 
continue (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22004?vs=60370=60376#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22004?vs=60370=60376

REVISION DETAIL
  https://phabricator.kde.org/D22004

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21983: [Kickoff/Dash] Show Calculator and Unit Converter runners

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:16eddf0503ba: [Kickoff/Dash] Show Calculator and Unit 
Converter runners (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21983?vs=60375=60377

REVISION DETAIL
  https://phabricator.kde.org/D21983

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kickoff/package/contents/ui/SearchView.qml

To: ngraham, #vdg, #plasma, hein, filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

[Nathaniel Graham]

ngraham updated this revision to Diff 60375.
ngraham added a comment.


  Do do it for Dash

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21983?vs=60374=60375

BRANCH
  add-more-runners (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21983

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kickoff/package/contents/ui/SearchView.qml

To: ngraham, #vdg, #plasma, hein, filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

[Eike Hein]

hein added a comment.


  You can do it for Dash, though -- check that `isDash` check where it already 
adds some runners to the Dash it doesn't add to App Menu.
  
  I'm fine with doing it for Kicker later, but we need to resolve the design 
issue first so we don't create a new bug.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-more-runners (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21983

To: ngraham, #vdg, #plasma, hein, filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

[Nathaniel Graham]

ngraham updated this revision to Diff 60374.
ngraham added a comment.


  Don't do it for Kicker

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21983?vs=60289=60374

BRANCH
  add-more-runners (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21983

AFFECTED FILES
  applets/kickoff/package/contents/ui/SearchView.qml

To: ngraham, #vdg, #plasma, hein, filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

[Eike Hein]

hein added a comment.


  Let's only do it for Kickoff and the Dash? The Kicker UI is really not made 
for arbitrary runners.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-more-runners (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21983

To: ngraham, #vdg, #plasma, hein, filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 215 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/215/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 14 Jun 2019 15:00:42 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.16.80.xmlacc/LibKWorkspace-5.16.80.xmlacc/LibNotificationManager-5.16.80.xmlacc/LibTaskManager-5.16.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.16.80/log.txtlogs/LibKWorkspace/5.16.80/log.txtlogs/LibNotificationManager/5.16.80/log.txtlogs/LibTaskManager/5.16.80/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report15%
(18/122)12%
(47/406)12%
(47/406)7%
(2495/36394)5%
(1263/24816)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/943)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/279)0%
(0/186)applets.notifications0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/78)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/271)0%
(0/277)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%
(0/66)components.keyboardlayout0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/32)components.sessionsprivate0%
(0/3)0%
(0/3)0%
(0/163)0%

Re: KInit - Current state and benchmarks

[Christoph Cullmann]

Hi,

On 2019-06-17 11:56, David Edmundson wrote:

From API.kde.org:
Using kdeinit to launch KDE applications makes starting a typical KDE 
applications 2.5 times faster (100ms instead of 250ms on a P-III 500)


Certainly sounds like a good thing.

===The current State===

==Plasma==
* Apps launched from the plasma menu skip klauncher and therefore
kinit. This was done due to the API for KRun blocking somewhere
(Though I don't remember details)

This seems like something easily fixable if we tried.

* Processes launched on bootup (with the exception of kcminit,
ksmserver and kded5) skip kinit. This was due to a deadlock in
klauncher and ksmserver at the time when apps autostart moved from
frameworks.

This deadlock is since resolved in my ksmserver splitting branches.

* But Plasma apps launched from the desktop do go through klauncher
(and therefore kinit)! So we're not even consistent.

==Apps==
* The number of applications linking kinit properly under KF5 is in an
equally sorry state.
Dolphin does, but even core applications like Okular and Kate don't.
I stopped using it I guess to be consistent between all platforms 
shipping Kate.
(beside, if you profile the Kate startup, all things are > the stuff 
kdeinit saves)




See
$ find -name 'CMakeLists.txt' -print0 | xargs -0 grep
'kf5_add_kdeinit_executable'
for a local list.

* It's also incompatible with flatpak/snaps/appimage, which is a rising 
trend


==Other==
Kinit is still also used for spawning KIO slaves.

===Is it still useful?===
We're not using it properly and we need to do something. Either fix it
or start to phase it out officially.

Since the time of writing kinit Qt has changed a lot. linking has
changed a bit. CPUs have changed a lot and Hard Disks have changed a
lot.

So I wrote a benchmark tool to see if the initial speed boost claim is
relevant: kde:scratch/davidedmundson/inittimer

My test does the following:
 - creates a dummy (headless) wayland server
 - spawns an app using either QProcess or sending a DBus message to 
KLauncher

 - times how long it takes for the first window to appear, timing the
more important real world metric and one that includes all the
factors.

Results:
(Showing the median out of 5 runs on a mid range SSD desktop)

Dolphin QProcess: 348
Dolphin Kinit: 332

KCalc   QProcess:  242
KCalc   KInit: 232

Plasmoidviewer (patched) QProces: 622
Plasmoidviewer (patched) KInit: 591

KWrite  QProcess: 391
KWrite  Kinit: 390
(unsurprisingly similar as kwrite does not have a kdeinit exec, I
included it as it shows the others aren't false positives)

===What about memory?===

Good question. It needs a similar investigation by someone who
understands memory...

===Conclusion===

My test implies there /is/ a genuine saving with kinit !
However it's far from the claimed 2.5 times faster, it is less than
1.1 times faster. Saving up to 30ms.


my opinion: it's not worh the hassle.

Greetings
Christoph

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org

Re: user-manager avatars

[Filip Fila]

Those are just existing avatars which have been upscaled and have had more
contrast added to them.

But FWIW I don't like the female avatar either. If we manage to get our
hands on better avatars we might even up removing these plain circular ones
too.

(And those better ones would be shifted towards interests, not primary
identity)

For the time being someone could definitely improve the female avatar
though.

On Sat, Jun 22, 2019 at 5:58 PM Nate Graham  wrote:

> I agree. Note that the existing female avatar was already like that
> before Filip's patch. The only change was simply to add more contrast to
> the shade of gray used for the background in these avatars.
>
> That said: yeah, we should definitely have a more appropriate female
> avatar and a gender-neutral outline as well.
>
> Nate
>
>
> On 6/22/19 5:41 PM, Jonathan Riddell wrote:
> > Looking at the new avatars in user-manager
> >
> > https://phabricator.kde.org/D21926
> >
> > The Female one is much more genderised and almost sexualied compared to
> > the male one.  It's fine to emphasise gendered aspects if that's the
> > desire but they should be balanced between the male and female one.
> > It's probably easier not to emphasise them however.
> >
> > There should also be a non-genderised person avatar because many people
> > do not want to define themselves primarily or at all by being male or
> > female.
> >
> > Jonathan
> >
>
>
>

D22004: Increment iterator before any potential continue

[Eike Hein]

hein added a comment.


  I'm not super happy with hardcoding directory separators and schemas, 
judicious use of `QUrl::fromLocalFile` or `QUrl::fromUserInput` would probably 
be better to norm behavior.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22004

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 180 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/180/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 21 Jun 2019 03:36:05 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 11 test(s), Passed: 97 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDebugConsoleFailed: projectroot.autotests.integration.kwin_testDontCrashGlxgearsFailed: projectroot.autotests.integration.kwin_testInternalWindowFailed: projectroot.autotests.integration.kwin_testInternalWindow_waylandonlyFailed: projectroot.autotests.integration.kwin_testMaximizedFailed: projectroot.autotests.integration.kwin_testMaximized_waylandonlyFailed: projectroot.autotests.integration.kwin_testMoveResizeFailed: projectroot.autotests.integration.kwin_testQuickTilingFailed: projectroot.autotests.integration.kwin_testShellClientFailed: projectroot.autotests.integration.kwin_testShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report70%
(59/84)57%
(320/559)57%
(320/559)42%
(30803/73739)31%
(14259/45326)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault87%
(134/154)87%
(134/154)64%
(19075/29988)48%
(9943/20605)colorcorrection100%
(4/4)100%
(4/4)81%
(429/528)59%
(191/324)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)79%
(438/552)64%
(135/210)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/380)4%
(12/296)effects.blur20%
(1/5)20%
(1/5)2%
(14/683)3%
(13/403)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(4/1285)0%
(0/1017)effects.cubeslide67%
(2/3)67%
(2/3)33%
(158/480)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)7%
(73/1023)3%
(27/962)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/232)2%
(3/160)effects.fallapart100%
(2/2)100%
(2/2)34%

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added a comment.


  In D21815#482624 , @filipf wrote:
  
  > For positioning the menu maybe you could have a look at how it was done in 
Kickoff config window: 
https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/ConfigGeneral.qml
  
  
  The menu seems to be extremely stubborn when it comes to y positioning. No 
amount of properties set or values passed to popup will get it to budge from 
its y position, including the method Kickoff uses.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22005: Accept local paths

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Alternate approach to D16087 

TEST PLAN
  5.12
  No longer get broken recent folders without icon in Dolphin

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22005

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Re: user-manager avatars

[Nate Graham]

I agree. Note that the existing female avatar was already like that 
before Filip's patch. The only change was simply to add more contrast to 
the shade of gray used for the background in these avatars.


That said: yeah, we should definitely have a more appropriate female 
avatar and a gender-neutral outline as well.


Nate


On 6/22/19 5:41 PM, Jonathan Riddell wrote:

Looking at the new avatars in user-manager

https://phabricator.kde.org/D21926

The Female one is much more genderised and almost sexualied compared to 
the male one.  It's fine to emphasise gendered aspects if that's the 
desire but they should be balanced between the male and female one.  
It's probably easier not to emphasise them however.


There should also be a non-genderised person avatar because many people 
do not want to define themselves primarily or at all by being male or 
female.


Jonathan

D22004: Increment iterator before any potential continue

[Kai Uwe Broulik]

broulik updated this revision to Diff 60370.
broulik retitled this revision from "[Task Manager] Increment iterator before 
any potential continue" to "Increment iterator before any potential continue".

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22004?vs=60368=60370

REVISION DETAIL
  https://phabricator.kde.org/D22004

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Noah Davis]

ndavis added a comment.


  In D22000#484409 , @IlyaBizyaev 
wrote:
  
  > Looks fine in the menu, but black on bright blue in the list model below is 
just wrong now.
  
  
  I don't actually have all the necessary patches right now, so pretend you 
don't see that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: filipf, IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22004: [Task Manager] Increase iterator before any potential continue

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise if none of the results are viable, we could end up in an infinite 
loop because we `continue` before we actually advance the iterator but also 
never reach the `actionCount` limit.

TEST PLAN
  This can probably go to 5.12

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22004

AFFECTED FILES
  applets/taskmanager/plugin/backend.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Filip Fila]

filipf added a comment.


  In D22000#484409 , @IlyaBizyaev 
wrote:
  
  > Looks fine in the menu, but black on bright blue in the list model below is 
just wrong now.
  
  
  There would be no black on bright blue once the task is finished; that's one 
of the points - to not have white on bright blue.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: filipf, IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

user-manager avatars

[Jonathan Riddell]

Looking at the new avatars in user-manager

https://phabricator.kde.org/D21926

The Female one is much more genderised and almost sexualied compared to the
male one.  It's fine to emphasise gendered aspects if that's the desire but
they should be balanced between the male and female one.  It's probably
easier not to emphasise them however.

There should also be a non-genderised person avatar because many people do
not want to define themselves primarily or at all by being male or female.

Jonathan

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 60366.
romangg added a comment.


  - Minor style changes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=60364=60366

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D22000: [colors/Breeze] Change selected text color to black

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Looks fine in the menu, but black on bright blue in the list model below is 
just wrong now.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 60364.
romangg added a comment.


  - Revert drm_fourcc.h whitespace changes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=60360=60364

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D22002: [Look and Feel KCM] Use view-preview for preview button

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ea079d0e5906: [Look and Feel KCM] Use view-preview for 
preview button (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22002?vs=60357=60363

REVISION DETAIL
  https://phabricator.kde.org/D22002

AFFECTED FILES
  kcms/lookandfeel/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, ndavis, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 60360.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=28986=60360

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

[Filip Fila]

filipf added a comment.


  Users shouldn't be creating random files in this directory.
  
  But if considering the possibility, according to tests configs are ordered 
alphabetically so we'd need to have a z_kde_settings.conf (if not intervening 
in SDDM).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21832

To: filipf, davidedmundson, ngraham, #plasma
Cc: sitter, fvogt, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg commandeered this revision.
romangg added a reviewer: fredrik.
romangg added a comment.


  Thanks @fredrik for initiating this. I'll try to finish the patches up.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D22000: [colors/Breeze] Change selected text color to black

[Nathaniel Graham]

ngraham added subscribers: cfeck, ngraham.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This also needs to be changed in the Default theme here in the same repo, in 
the Kirigami repo (which has a duplicate of it) and in some Framework that I 
never remember (maybe @cfeck remembers).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: ngraham, cfeck, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Vlad Zagorodniy]

zzag added a comment.


  Can you attach before & after screenshots?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22002: [Look and Feel KCM] Use view-preview for preview button

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It makes sense for the splash screen preview to use a "play" icon since it's 
effectively an animation or video.
  However, the look and feel preview is merely a static image.

TEST PLAN
  F6924214: Screenshot_20190622_164307.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22002

AFFECTED FILES
  kcms/lookandfeel/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22000: Change selected text color to black

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Also make black text color match the Shade Black color:
  
  https://hig.kde.org/style/color/default.html

REPOSITORY
  R31 Breeze

BRANCH
  breeze-selected-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22000

AFFECTED FILES
  colors/Breeze.colors

To: ndavis, #vdg, #breeze, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9d9c1fc3b378: Provide a way for developers to easily set 
up plasma sessions for their… (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21992?vs=60342=60354#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21992?vs=60342=60354

REVISION DETAIL
  https://phabricator.kde.org/D21992

AFFECTED FILES
  CMakeLists.txt
  login-sessions/CMakeLists.txt
  login-sessions/install-sessions.sh.cmake
  login-sessions/plasma.desktop.cmake
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/plasmax11-dev.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  plasma.desktop.cmake
  plasmawayland.desktop.cmake

To: apol, ngraham, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21999: [WIP] Make context menu highlight similar to Kickoff highlight

[Noah Davis]

ndavis updated this revision to Diff 60353.
ndavis added a comment.


  Remove unnecessary if statement

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21999?vs=60349=60353

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21999

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #breeze, #vdg, #plasma
Cc: filipf, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21998: Batch MPRIS DBus property changes

[Kai Uwe Broulik]

broulik updated this revision to Diff 60352.
broulik added a comment.


  Timer on stack

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21998?vs=60347=60352

REVISION DETAIL
  https://phabricator.kde.org/D21998

AFFECTED FILES
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Sorry, my mistake. I missed that this tooltip is set on the wrong checkbox. 
It needs to be set on the "CPUs separately" checkbox

REVISION DETAIL
  https://phabricator.kde.org/D21979

To: nhiga, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21998: Batch MPRIS DBus property changes

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fvogt wrote in mprisplugin.h:153
> Why a pointer?

No particular reason, just that we usually do that..

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21998

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21999: [WIP] Make context menu highlight similar to Kickoff highlight

[Filip Fila]

filipf added a comment.


  Visually +100, obviously we can only merge it until we have changed it all 
places (+gtk theme).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D21999

To: ndavis, #breeze, #vdg, #plasma
Cc: filipf, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21999: [WIP] Make context menu highlight similar to Kickoff highlight

[Nathaniel Graham]

ngraham added a comment.


  Looks amazing! But I think we need to do all the highlight effects at once. 
At least, all the ones that need to be done in this repo. Kirigami and 
qqc2-desktop-style will need their own patches, of course.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D21999

To: ndavis, #breeze, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21998: Batch MPRIS DBus property changes

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  There should be a comment somewhere to explain what's happening and why.

INLINE COMMENTS

> mprisplugin.h:153
>  
> +QTimer *m_propertyChangeSignalTimer;
> +// interface - 

Why a pointer?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21998

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21987: Extend KDE Connect to images, video, audio, selection

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Will add a separate `shareText` method.
  Will re-introduce some subsystem status query thing and then set kdeconnect 
plugin to version 2 and then only show the "copy" entry if host host has 
version >= 2

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21987

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21999: Make context menu highlight similar to Kickoff highlight

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Breeze, VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Part of T11124 

REPOSITORY
  R31 Breeze

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21999

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #breeze, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> shutdown.cpp:66
>  runShutdownScripts();
> -KDisplayManager().shutdown( m_shutdownType, 
> KWorkSpace::ShutdownModeDefault);
> +// if (m_shutdownType == KWorkSpace::ShutdownTypeHalt) {
> +// SessionBackend::self()->shutdown();

This code is ready, just commented out due to waiting on libkworkspace2

Commented out to allow for testing without making them dependent.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21995

To: davidedmundson, #plasma
Cc: bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This is fantastic. I think it'll be a real improvement over the current set 
of manual steps.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21992

To: apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21998: Batch MPRIS DBus property changes

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Didn't rename the `emitPropertyChange` method to `queuePropertyChange` to 
keep the changes to a minimum. Might change that separately later

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21998

AFFECTED FILES
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21987: Extend KDE Connect to images, video, audio, selection

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> kdeconnectplugin.cpp:188
>  
> QStringLiteral("org.kde.kdeconnect.device.share"),
> -
> QStringLiteral("shareUrl"));
> -msg.setArguments({url});
> +!text.isEmpty() 
> ? QStringLiteral("shareText") : QStringLiteral("shareUrl"));
> +if (!text.isEmpty()) {

This looks like an ugly hack. Is there any reason not to add a new `shareText` 
event?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21987

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson updated this revision to Diff 60345.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  Update merge issue

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21995?vs=60340=60345

BRANCH
  davidedmundson/ksession

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> CMakeLists.txt:8
>  ecm_qt_declare_logging_category(plasma_waitforname_SRCS HEADER debug_p.h 
> IDENTIFIER LOG_PLASMA CATEGORY_NAME org.kde.knotifications)
> -ecm_mark_nongui_executable(ksyncdbusenv)
>  

?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21995

To: davidedmundson, #plasma
Cc: bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

[Aleix Pol Gonzalez]

apol updated this revision to Diff 60342.
apol added a comment.


  Make executables executable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21992?vs=60330=60342

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21992

AFFECTED FILES
  CMakeLists.txt
  login-sessions/CMakeLists.txt
  login-sessions/install-sessions.sh.cmake
  login-sessions/plasma.desktop.cmake
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/plasmax11-dev.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  plasma.desktop.cmake
  plasmawayland.desktop.cmake

To: apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

[Aleix Pol Gonzalez]

apol added a comment.


  Works for me.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20830

To: broulik, #plasma, fvogt
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This allows new startup procedures to use a session manager and also
  allows us to slowly replace the session manager without breaking plasma.
  
  Following on from the previous refactor, Startup and Shutdown are moved
  from kmserver and the previous calls into KSMserver are replaced with
  DBus calls.

TEST PLAN
  Logged in

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/ksession

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp
  startkde/waitforname/CMakeLists.txt

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21991: Add X-KDE-ParentApp entries in metadata.desktop

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:53d45a126e5d: Add X-KDE-ParentApp entries in 
metadata.desktop (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21991?vs=60323=60338

REVISION DETAIL
  https://phabricator.kde.org/D21991

AFFECTED FILES
  applets/digital-clock/package/metadata.desktop
  applets/notifications/package/metadata.desktop
  wallpapers/color/metadata.desktop
  wallpapers/image/imagepackage/metadata.desktop
  wallpapers/image/slideshowpackage/metadata.desktop

To: bshah, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thank you!
  
  The email address I have on file for you is 
`c822c4f23bca1ea6faac7...@mail.xn--3ds443g`. Is there any chance you can 
provide a different, more human-readable email address?

REVISION DETAIL
  https://phabricator.kde.org/D21979

To: nhiga, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21993: [Klipper] Always restore the last clipbboard item

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch please!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  unify

REVISION DETAIL
  https://phabricator.kde.org/D21993

To: davidre, ngraham, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Kai Uwe Broulik]

broulik added a comment.


  Yes but you can only do that once it shows up because of a removable device 
then

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21944: Show shortcut in menu item when specified

[Alexander Stippich]

astippich added a comment.


  Unfortunately, even with this reverted change I know get a wrong menu 
separator. I don't know what was different before...
  
  Since it was also there without this patch (see screenshot), it is probably a 
different issue which needs investigation

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21944

To: astippich, mart, ngraham, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21944: Show shortcut in menu item when specified

[Alexander Stippich]

astippich updated this revision to Diff 60332.
astippich added a comment.


  - use item for margin again

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21944?vs=60300=60332

BRANCH
  menu_item

REVISION DETAIL
  https://phabricator.kde.org/D21944

AFFECTED FILES
  org.kde.desktop/MenuItem.qml

To: astippich, mart, ngraham, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21993: [Klipper] Always restore the last clipbboard item

[David Redondo]

davidre created this revision.
davidre added reviewers: ngraham, davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  D19852  intrdouced x-kde-force-image-copy 
hint for programs to specify that
  images should be set to the clipboard even if should not be included in the
  history. But when the program was closed the clipboard was restored to the 
first
  item in history in which the image was not included. To fix this introduce a 
new
  class member which holds the last clipboard item and restore it.
  Credit goes to David Edumndson

TEST PLAN
  Try it with spectacle

REPOSITORY
  R120 Plasma Workspace

BRANCH
  unify

REVISION DETAIL
  https://phabricator.kde.org/D21993

AFFECTED FILES
  klipper/klipper.cpp
  klipper/klipper.h

To: davidre, ngraham, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

[Aleix Pol Gonzalez]

apol updated this revision to Diff 60330.
apol added a comment.


  Duplicated line

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21992?vs=60328=60330

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21992

AFFECTED FILES
  CMakeLists.txt
  login-sessions/CMakeLists.txt
  login-sessions/install-sessions.sh.cmake
  login-sessions/plasma.desktop.cmake
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/plasmax11-dev.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  plasma.desktop.cmake
  plasmawayland.desktop.cmake

To: apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

[Aleix Pol Gonzalez]

apol updated this revision to Diff 60328.
apol added a comment.


  Forgot to install the prefix.sh file

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21992?vs=60327=60328

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21992

AFFECTED FILES
  CMakeLists.txt
  login-sessions/CMakeLists.txt
  login-sessions/install-sessions.sh.cmake
  login-sessions/plasma.desktop.cmake
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/plasmax11-dev.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  plasma.desktop.cmake
  plasmawayland.desktop.cmake

To: apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

[N. Higa]

nhiga updated this revision to Diff 60326.
nhiga added a comment.


  Rephrased the tooltip message according to ngraham's suggestion.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21979?vs=60279=60326

REVISION DETAIL
  https://phabricator.kde.org/D21979

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml

To: nhiga, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Creates the necessary files in the build directory as well as provide a 
script that will install them to /usr so the login manager can find it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21992

AFFECTED FILES
  CMakeLists.txt
  login-sessions/CMakeLists.txt
  login-sessions/install-sessions.sh.cmake
  login-sessions/plasma.desktop.cmake
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/plasmax11-dev.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  plasma.desktop.cmake
  plasmawayland.desktop.cmake

To: apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21987: Extend KDE Connect to images, video, audio, selection

[Kai Uwe Broulik]

broulik updated this revision to Diff 60324.
broulik added a comment.


  - Fix id mismatch

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21987?vs=60315=60324

REVISION DETAIL
  https://phabricator.kde.org/D21987

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/extension.js
  host/kdeconnectplugin.cpp

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21991: Add X-KDE-ParentApp entries in metadata.desktop

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: apol, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  If this entry is not added, kpackagetool5 tries to load the specific
  packagestructure plugin, fails to load it and then writes the metainfo
  as it is "application" instead of add-on

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bshah/correctparentapp

REVISION DETAIL
  https://phabricator.kde.org/D21991

AFFECTED FILES
  applets/digital-clock/package/metadata.desktop
  applets/notifications/package/metadata.desktop
  wallpapers/color/metadata.desktop
  wallpapers/image/imagepackage/metadata.desktop
  wallpapers/image/slideshowpackage/metadata.desktop

To: bshah, apol, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21990: Don't propagate a title change if it didn't actually change

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Ironically quite similar to a DDoS vector on the Task Manager. Apps suck :)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21990

To: broulik, #plasma, fvogt, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21990: Don't propagate a title change if it didn't actually change

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Noticed Telegram continuously touched the window title. The host didn't 
actually send a change on mpris but there was still some useless communication 
going on between content script and extension.

TEST PLAN
  Didn't get that anymore. Genuine window title changes e.g. in spotify are 
still reflected fine on mpris

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21990

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21988: Reject duplicate events with identical coordinates

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0628dab8f42b: Reject duplicate events with identical 
coordinates (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21988?vs=60316=60319

REVISION DETAIL
  https://phabricator.kde.org/D21988

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: hein, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21988: Reject duplicate events with identical coordinates

[Nathaniel Graham]

ngraham added a comment.


  Stable branch would be nice

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21988

To: hein, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20442: Provide a KModifierKeyInfoProvider implementation

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R130:1a54c53bca82: Provide a KModifierKeyInfoProvider 
implementation (authored by apol).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20442?vs=55914=60318

REVISION DETAIL
  https://phabricator.kde.org/D20442

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kmodifierkeyinfoprovider/CMakeLists.txt
  src/kmodifierkeyinfoprovider/kmodifierkeyinfoprovider_wayland.cpp
  src/kmodifierkeyinfoprovider/kmodifierkeyinfoprovider_wayland.h

To: apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21988: Reject duplicate events with identical coordinates

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes perfect sense and fixes the bug.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21988

To: hein, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

[Eike Hein]

hein added a comment.


  In D21978#483972 , @hein wrote:
  
  > That's wrong, sorry - I'm uploading a different patch that fixes the 
underlying cause.
  
  
  D21988 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21978

To: filipf, hein, #plasma, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21988: Reject duplicate events with identical coordinates

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hein requested review of this revision.

REVISION SUMMARY
  BUG:401861

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21988

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: hein, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

[Eike Hein]

hein added a comment.


  That's wrong, sorry - I'm uploading a different patch that fixes the 
underlying cause.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21978

To: filipf, hein, #plasma, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21987: Extend KDE Connect to images, video, audio, selection

[Kai Uwe Broulik]

broulik updated this revision to Diff 60315.
broulik added a comment.


  - Simplify

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21987?vs=60314=60315

REVISION DETAIL
  https://phabricator.kde.org/D21987

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/extension.js
  host/kdeconnectplugin.cpp

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21987: Extend KDE Connect to images, video, audio, selection

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, davidedmundson, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This lets it share image, video, and audio URLs as well as text selection via 
KDE Connect.
  For text selection a separate entry "Copy to" is added.

TEST PLAN
  Right clicked image, sent it to KDE connect, had my browser open it. Same for 
video player.
  
  Only compat issue with older host is that sending a text selection will 
instead just open the page if not supported but I think that's pretty minor.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21987

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/extension.js
  host/kdeconnectplugin.cpp

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.12/15/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 10:32:31 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 231 lines...][2019-06-22T10:44:49.004Z] -- Check for working CXX compiler: /usr/bin/c++[2019-06-22T10:44:49.004Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-06-22T10:44:49.004Z] -- Detecting CXX compiler ABI info[2019-06-22T10:44:49.261Z] -- Detecting CXX compiler ABI info - done[2019-06-22T10:44:49.261Z] -- Detecting CXX compile features[2019-06-22T10:44:49.517Z] -- Detecting CXX compile features - done[2019-06-22T10:44:49.517Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-06-22T10:44:49.517Z] -- Looking for __GLIBC__[2019-06-22T10:44:49.517Z] -- Looking for __GLIBC__ - not found[2019-06-22T10:44:49.517Z] -- Performing Test _OFFT_IS_64BIT[2019-06-22T10:44:49.517Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-06-22T10:44:49.517Z] -- Performing Test HAVE_DATE_TIME[2019-06-22T10:44:49.779Z] -- Performing Test HAVE_DATE_TIME - Success[2019-06-22T10:44:49.779Z] -- Found KF5IdleTime: /usr/home/jenkins/install-prefix/lib/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.60.0") [2019-06-22T10:44:49.779Z] -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.60.0") [2019-06-22T10:44:49.779Z] -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.60.0") [2019-06-22T10:44:49.779Z] -- Found KF5: success (found suitable version "5.60.0", minimum required is "5.58.0") found components:  IdleTime WindowSystem GuiAddons [2019-06-22T10:44:49.779Z] -- The following REQUIRED packages have been found:[2019-06-22T10:44:49.779Z] [2019-06-22T10:44:49.779Z]  * ECM (required version >= 5.58.0)[2019-06-22T10:44:49.779Z]  * Qt5Gui (required version >= 5.12.2)[2019-06-22T10:44:49.779Z]  * Qt5Widgets[2019-06-22T10:44:49.779Z]  * Qt5Core[2019-06-22T10:44:49.779Z]  * KF5IdleTime (required version >= 5.58.0)[2019-06-22T10:44:49.779Z]  * KF5WindowSystem (required version >= 5.58.0)[2019-06-22T10:44:49.779Z]  * KF5GuiAddons (required version >= 5.58.0)[2019-06-22T10:44:49.779Z]  * KF5 (required version >= 5.58.0)[2019-06-22T10:44:49.779Z]  * KF5Wayland[2019-06-22T10:44:49.779Z]  * Qt5Test[2019-06-22T10:44:49.779Z]  * Qt5[2019-06-22T10:44:49.779Z] [2019-06-22T10:44:49.779Z] -- Configuring done[2019-06-22T10:44:49.779Z] -- Generating done[2019-06-22T10:44:49.779Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 FreeBSDQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-06-22T10:44:50.855Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kwayland-integration --branchGroup kf5-qt5 --platform FreeBSDQt5.12 --usingInstall /home/jenkins/install-prefix/[2019-06-22T10:44:51.112Z] Scanning dependencies of target KF5WindowSystemKWaylandPlugin_autogen[2019-06-22T10:44:51.112Z] Scanning dependencies of target KF5IdleTimeKWaylandPlugin_autogen[2019-06-22T10:44:51.112Z] Scanning dependencies of target kmodifierkey_wayland_autogen[2019-06-22T10:44:51.112Z] Scanning dependencies of target idleTest_autogen[2019-06-22T10:44:51.112Z] [  9%] Automatic MOC for target KF5WindowSystemKWaylandPlugin[2019-06-22T10:44:51.112Z] [  9%] Automatic MOC for target KF5IdleTimeKWaylandPlugin[2019-06-22T10:44:51.112Z] [ 14%] Automatic MOC for target idleTest[2019-06-22T10:44:51.112Z] [ 19%] Automatic MOC for target kmodifierkey_wayland[2019-06-22T10:44:51.369Z] [ 19%] Built target KF5IdleTimeKWaylandPlugin_autogen[2019-06-22T10:44:51.369Z] [ 19%] Built target kmodifierkey_wayland_autogen[2019-06-22T10:44:51.369Z] Scanning dependencies of target KF5IdleTimeKWaylandPlugin[2019-06-22T10:44:51.369Z] Scanning dependencies of target kmodifierkey_wayland[2019-06-22T10:44:51.369Z] [ 23%] Building CXX object src/idletime/CMakeFiles/KF5IdleTimeKWaylandPlugin.dir/KF5IdleTimeKWaylandPlugin_autogen/mocs_compilation.cpp.o[2019-06-22T10:44:51.369Z] [ 28%] Building CXX object src/idletime/CMakeFiles/KF5IdleTimeKWaylandPlugin.dir/poller.cpp.o[2019-06-22T10:44:51.369Z] [ 38%] Building CXX object src/kmodifierkeyinfoprovider/CMakeFiles/kmodifierkey_wayland.dir/kmodifierkeyinfoprovider_wayland.cpp.o[2019-06-22T10:44:51.369Z] [ 38%] Building CXX object src/kmodifierkeyinfoprovider/CMakeFiles/kmodifierkey_wayland.dir/kmodifierkey_wayland_autogen/mocs_compilation.cpp.o[2019-06-22T10:44:51.369Z] In file included from /usr/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 FreeBSDQt5.12/src/kmodifierkeyinfoprovider/kmodifierkeyinfoprovider_wayland.cpp:21:[2019-06-22T10:44:51.369Z] /usr/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 

D21811: [Calculator] Fix popup size and minimum size for expanded version

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:ba5d35dfe829: [Calculator] Fix popup size and minimum 
size for expanded version (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21811?vs=60312=60313

REVISION DETAIL
  https://phabricator.kde.org/D21811

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: ngraham, davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21811: [Calculator] Fix popup size and minimum size for expanded version

[Nathaniel Graham]

ngraham updated this revision to Diff 60312.
ngraham added a comment.


  Just use a reasonable hardcoded size, per @davidedmundson's suggestion

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21811?vs=59830=60312

BRANCH
  fix-calculator-popup (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21811

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: ngraham, davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/13/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Jun 2019 10:32:30 +
 Build duration:
2 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 277 lines...][2019-06-22T10:33:36.699Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-06-22T10:33:36.699Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-06-22T10:33:36.699Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-06-22T10:33:36.699Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-06-22T10:33:36.699Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-06-22T10:33:36.699Z] QT_SELECT = 'qt5'[2019-06-22T10:33:36.699Z] LANG  = 'en_US.UTF-8'[2019-06-22T10:33:36.699Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-06-22T10:33:36.699Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-06-22T10:33:36.699Z] [2019-06-22T10:33:36.699Z] [2019-06-22T10:33:36.699Z] == Commencing Configuration:[2019-06-22T10:33:36.699Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 SUSEQt5.12"[2019-06-22T10:33:37.642Z] -- The C compiler identification is GNU 8.3.1[2019-06-22T10:33:37.900Z] -- The CXX compiler identification is GNU 8.3.1[2019-06-22T10:33:37.900Z] -- Check for working C compiler: /usr/bin/cc[2019-06-22T10:33:38.165Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-06-22T10:33:38.165Z] -- Detecting C compiler ABI info[2019-06-22T10:33:38.165Z] -- Detecting C compiler ABI info - done[2019-06-22T10:33:38.165Z] -- Detecting C compile features[2019-06-22T10:33:38.754Z] -- Detecting C compile features - done[2019-06-22T10:33:38.754Z] -- Check for working CXX compiler: /usr/bin/c++[2019-06-22T10:33:39.019Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-06-22T10:33:39.019Z] -- Detecting CXX compiler ABI info[2019-06-22T10:33:39.277Z] -- Detecting CXX compiler ABI info - done[2019-06-22T10:33:39.277Z] -- Detecting CXX compile features[2019-06-22T10:33:40.668Z] -- Detecting CXX compile features - done[2019-06-22T10:33:40.668Z] -- Looking for __GLIBC__[2019-06-22T10:33:40.668Z] -- Looking for __GLIBC__ - found[2019-06-22T10:33:40.668Z] -- Performing Test _OFFT_IS_64BIT[2019-06-22T10:33:40.940Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-06-22T10:33:40.940Z] -- Performing Test HAVE_DATE_TIME[2019-06-22T10:33:40.940Z] -- Performing Test HAVE_DATE_TIME - Success[2019-06-22T10:33:40.940Z] -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.60.0") [2019-06-22T10:33:40.940Z] -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.60.0") [2019-06-22T10:33:40.941Z] -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.60.0") [2019-06-22T10:33:40.941Z] -- Found KF5: success (found suitable version "5.60.0", minimum required is "5.58.0") found components:  IdleTime WindowSystem GuiAddons [2019-06-22T10:33:40.941Z] -- The following REQUIRED packages have been found:[2019-06-22T10:33:40.941Z] [2019-06-22T10:33:40.941Z]  * ECM (required version >= 5.58.0)[2019-06-22T10:33:40.941Z]  * Qt5Gui (required version >= 5.12.3)[2019-06-22T10:33:40.941Z]  * Qt5Widgets[2019-06-22T10:33:40.941Z]  * Qt5Core[2019-06-22T10:33:40.941Z]  * KF5IdleTime (required version >= 5.58.0)[2019-06-22T10:33:40.941Z]  * KF5WindowSystem (required version >= 5.58.0)[2019-06-22T10:33:40.941Z]  * KF5GuiAddons (required version >= 5.58.0)[2019-06-22T10:33:40.941Z]  * KF5 (required version >= 5.58.0)[2019-06-22T10:33:40.941Z]  * KF5Wayland[2019-06-22T10:33:40.941Z]  * Qt5Test[2019-06-22T10:33:40.941Z]  * Qt5[2019-06-22T10:33:40.941Z] [2019-06-22T10:33:40.941Z] -- Configuring done[2019-06-22T10:33:41.197Z] -- Generating done[2019-06-22T10:33:41.197Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-06-22T10:33:42.582Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kwayland-integration --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-06-22T10:33:42.582Z] Scanning dependencies of target KF5IdleTimeKWaylandPlugin_autogen[2019-06-22T10:33:42.582Z] [  4%] Automatic MOC for target KF5IdleTimeKWaylandPlugin[2019-06-22T10:33:42.582Z] [  4%] 

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:43eb5fae5784: Set SwipeListItem implicitHeight to be the 
maximum of content and actions (authored by davidre).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21981?vs=60284=60305

REVISION DETAIL
  https://phabricator.kde.org/D21981

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: davidre, #kirigami, mart, ngraham
Cc: ngraham, mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D21944: Show shortcut in menu item when specified

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> apol wrote in MenuItem.qml:103
> Use Layout.rightMargin on the shortcut object.
> https://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#rightMargin-attached-prop

I think the original approach to use an Item was correct, both because now it 
looks wrong, but also because using an Item makes the layout automatically RTL 
compatible, while setting the right padding property requires conditional 
handling for the reversed case.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21944

To: astippich, mart, ngraham, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21944: Show shortcut in menu item when specified

[Alexander Stippich]

astippich added a comment.


  The menu separator now does not look correct:
  F6923245: menu_after2.png 
  I don't know why

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21944

To: astippich, mart, ngraham, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21944: Show shortcut in menu item when specified

[Alexander Stippich]

astippich updated this revision to Diff 60300.
astippich added a comment.


  - simplify

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21944?vs=60162=60300

BRANCH
  menu_item

REVISION DETAIL
  https://phabricator.kde.org/D21944

AFFECTED FILES
  org.kde.desktop/MenuItem.qml

To: astippich, mart, ngraham, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

[Nathaniel Graham]

ngraham added a comment.


  Now that I look at it, the right-most button's right padding is also too 
high; it should be much closer to the right edge of the list item. Maybe good 
material for another patch.

REPOSITORY
  R169 Kirigami

BRANCH
  height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21981

To: davidre, #kirigami, mart, ngraham
Cc: ngraham, mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

[Nathaniel Graham]

ngraham added a comment.


  This works for me, and doesn't seem to break the triangle filter, but I'd 
like @hein to take a look since he wrote this code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21978

To: filipf, hein, #plasma, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> GeneralSettings.qml:54
> +visible: parent.hovered
> +text: i18n("CPUs can be shown separately when using compact bar 
> monitor")
> +}

Rephrase this in the form of a command (e.g. "Show multiple CPUs separately 
when using compact bar monitor")

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21979

To: nhiga, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21934: Ensure no one but us writes to stdout

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:ee36561ca66f: Ensure no one but us writes to stdout 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21934?vs=60182=60290

REVISION DETAIL
  https://phabricator.kde.org/D21934

AFFECTED FILES
  host/connection.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The Calculator and Unit Converter runners are some of the most useful and
  productivity-boosting runners, yet they don't show up in Kicker/Kickoff/Dash
  right now, only in KRunner.
  
  This patch makes them show up in the aforementioned launcher widgets, 
increasing
  discoverability and productivity for regular users who are less likely to know
  about KRunner's standalone UI.
  
  CCBUG: 382760

TEST PLAN
  F6923047: unit converter.png 
  F6923046: Calculator.png 
  
  Also works in Kicker and Dash. Display in Kicker is slightly awkward due to 
  https://bugs.kde.org/show_bug.cgi?id=389146, but that's a pre-existing bug.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-more-runners (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21983

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kickoff/package/contents/ui/SearchView.qml

To: ngraham, #vdg, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21959: Fix selectedNameFilter() multiple matches

[Robert Hoffmann]

hoffmannrobert updated this revision to Diff 60286.
hoffmannrobert added a comment.


  - Remove redundant condition

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21959?vs=60217=60286

BRANCH
  fix_selectedNameFilter

REVISION DETAIL
  https://phabricator.kde.org/D21959

AFFECTED FILES
  autotests/kfiledialog_unittest.cpp
  src/platformtheme/kdeplatformfiledialogbase_p.h
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformfiledialoghelper.h
  src/platformtheme/kdirselectdialog.cpp
  src/platformtheme/kdirselectdialog_p.h

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21980: Fix ocasional crash on the touchpad kded

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:920e39c2e5cc: Fix ocasional crash on the touchpad kded 
(authored by aacid).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21980?vs=60283=60285

REVISION DETAIL
  https://phabricator.kde.org/D21980

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp

To: aacid, atulbi, ngraham
Cc: ngraham, knambiar, atulbi, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21980: Fix ocasional crash on the touchpad kded

[Atul Bisht]

atulbi accepted this revision.
atulbi added a comment.


  Me too

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21980

To: aacid, atulbi, ngraham
Cc: ngraham, knambiar, atulbi, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

[Nathaniel Graham]

ngraham added subscribers: mart, ngraham.
ngraham added reviewers: Kirigami, mart.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. @mart?

REPOSITORY
  R169 Kirigami

BRANCH
  height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21981

To: davidre, #kirigami, mart, ngraham
Cc: ngraham, mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D21980: Fix ocasional crash on the touchpad kded

[Nathaniel Graham]

ngraham added a reviewer: atulbi.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. @atulbi?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21980

To: aacid, atulbi, ngraham
Cc: ngraham, knambiar, atulbi, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart