D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-27 Thread Nathaniel Graham
ngraham added a comment.


  +100
  
  Will do a bigger review and test tomorrow!

INLINE COMMENTS

> config.qml:147
> +{
> +'label': i18nd("plasma_wallpaper_org.kde.image", 
> "Modification time (oldest first"),
> +'slideshowMode':  Wallpaper.Image.Modified

Needs a trailing ")" in the label

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-27 Thread Noah Davis
ndavis added a comment.


  Since these seem to be scaled 2x, the thicker (6px@2x) highlight is more 
desirable.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-27 Thread Noah Davis
ndavis added a comment.


  Why is the tab highlight thicker in these
  
  F6939066: Screenshot_20190627_234222.png 

  F6939070: Screenshot_20190628_000624.png 

  
  And thinner in these?
  
  F6939067: Screenshot_20190627_234519.png 

  F6939065: Screenshot_20190627_234358.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22132: Initialize view with the right size

2019-06-27 Thread Aleix Pol Gonzalez
apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise there's some logical glitches and the image ends up being loaded
  3 times.

TEST PLAN
  qDebug

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22132

AFFECTED FILES
  greeter/greeterapp.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-27 Thread Filip Fila
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch makes Kickoff tab indicators glide(patch _) on the tab bar 
separator in all 4 orientations.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-tabbarseparator-geometr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22128

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D21959: Fix selectedNameFilter() multiple matches

2019-06-27 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D21959

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D22106: [Separator] Match Breeze borders' color

2019-06-27 Thread Noah Davis
ndavis added a comment.


  +1 visually, but I agree that the Breeze Widget theme should be the part that 
provides the theming, if possible.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22106

To: filipf, #kirigami, #vdg, ngraham
Cc: ndavis, mglb, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein


D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-27 Thread Filip Fila
filipf added a comment.


  Awesome 

INLINE COMMENTS

> config.qml:135
> +{
> +'label': i18nd("plasma_wallpaper_org.kde.image", 
> "Alphabetical (A first)"),
> +'slideshowMode':  Wallpaper.Image.Alphabetical

Instead of "A first" I think we can just say "A to Z" or even "A-Z"

> config.qml:139
> +{
> +'label': i18nd("plasma_wallpaper_org.kde.image", 
> "Alphabetical (Z first)"),
> +'slideshowMode':  Wallpaper.Image.AlphabeticalReversed

Same comment as above just reverse A and Z.

> config.qml:143
> +{
> +'label': i18nd("plasma_wallpaper_org.kde.image", 
> "Modification time (newest first)"),
> +'slideshowMode':  Wallpaper.Image.ModifiedReversed

Something like "Date modified" might be closer to what we have in file managers.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22122: use pwquality_strerror to get error strings

2019-06-27 Thread Harald Sitter
sitter added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in passworddialog.cpp:157
> Shouldn't be fromUtf8 ? You can't handle all languages by latin.

Oh, indeed!

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D22122

To: sitter, #plasma
Cc: anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D16425: Added new Suspend then Hibernate option

2019-06-27 Thread Méven Car
meven added a comment.


  I tried using it but my system does not suspend-then-hibernate mode.
  
  You can check if your system supports it once you have systemd >= 239 and the 
following command returns true :
  
qdbus org.freedesktop.PowerManagement /org/freedesktop/PowerManagement 
CanSuspendThenHibernate
  
  Or this one should have the same result :
  
qdbus org.freedesktop.PowerManagement /org/freedesktop/PowerManagement 
CanHibernate

REPOSITORY
  R122 Powerdevil

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: ericadams, jobauer, reverendhomer, meven, soriano, abalaji, graesslin, 
ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22122: use pwquality_strerror to get error strings

2019-06-27 Thread Anthony Fieroni
anthonyfieroni added inline comments.

INLINE COMMENTS

> passworddialog.cpp:157
> +const QString errorString =
> +QString::fromLatin1(pwquality_strerror(buf, 
> PWQ_MAX_ERROR_MESSAGE_LEN,
> +   error, auxerror));

Shouldn't be fromUtf8 ? You can't handle all languages by latin.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D22122

To: sitter, #plasma
Cc: anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 13 - Still Failing!

2019-06-27 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/13/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 27 Jun 2019 14:04:42 +
 Build duration:
8 min 47 sec and counting
   CONSOLE OUTPUT
  [...truncated 221 lines...][2019-06-27T14:13:10.133Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-27T14:13:10.133Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 42 Stepping 1, GenuineIntel'[2019-06-27T14:13:10.133Z] PROCESSOR_LEVEL   = '6'[2019-06-27T14:13:10.133Z] PROCESSOR_REVISION= '2a01'[2019-06-27T14:13:10.133Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-27T14:13:10.133Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-27T14:13:10.133Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-27T14:13:10.133Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-27T14:13:10.133Z] PROMPT= '$P$G'[2019-06-27T14:13:10.133Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-27T14:13:10.133Z] PUBLIC= 'C:\Users\Public'[2019-06-27T14:13:10.133Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/13/display/redirect?page=changes'[2019-06-27T14:13:10.133Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/13/display/redirect'[2019-06-27T14:13:10.133Z] STAGE_NAME= 'Configuring Build'[2019-06-27T14:13:10.133Z] SYSTEMDRIVE   = 'C:'[2019-06-27T14:13:10.133Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-27T14:13:10.133Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-27T14:13:10.133Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-27T14:13:10.133Z] UCRTVERSION   = '10.0.17763.0'[2019-06-27T14:13:10.133Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-27T14:13:10.133Z] USERDOMAIN= 'DESKTOP-V7LQR8M'[2019-06-27T14:13:10.133Z] USERNAME  = 'Jenkins'[2019-06-27T14:13:10.133Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-27T14:13:10.133Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-27T14:13:10.133Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-27T14:13:10.133Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-27T14:13:10.133Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-27T14:13:10.133Z] VCTOOLSVERSION= '14.16.27023'[2019-06-27T14:13:10.133Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-27T14:13:10.133Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-27T14:13:10.133Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-27T14:13:10.133Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-27T14:13:10.133Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-27T14:13:10.133Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-27T14:13:10.133Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-27T14:13:10.133Z] VSCMD_VER = '16.0.3'[2019-06-27T14:13:10.133Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-27T14:13:10.133Z] WINDIR= 'C:\WINDOWS'[2019-06-27T14:13:10.133Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-27T14:13:10.133Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-27T14:13:10.133Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-27T14:13:10.133Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-27T14:13:10.134Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-27T14:13:10.134Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-27T14:13:10.134Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11'[2019-06-27T14:13:10.134Z] __DOTNET_ADD_64BIT= '1'[2019-06-27T14:13:10.134Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-27T14:13:10.134Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program 

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 37 - Still Failing!

2019-06-27 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/37/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 27 Jun 2019 14:04:42 +
 Build duration:
3 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-06-27T14:08:24.320Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-27T14:08:24.320Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-06-27T14:08:24.320Z] PROCESSOR_LEVEL   = '6'[2019-06-27T14:08:24.320Z] PROCESSOR_REVISION= '5e03'[2019-06-27T14:08:24.320Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-27T14:08:24.320Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-27T14:08:24.320Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-27T14:08:24.320Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-27T14:08:24.320Z] PROMPT= '$P$G'[2019-06-27T14:08:24.320Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-27T14:08:24.320Z] PUBLIC= 'C:\Users\Public'[2019-06-27T14:08:24.320Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/37/display/redirect?page=changes'[2019-06-27T14:08:24.320Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/37/display/redirect'[2019-06-27T14:08:24.320Z] STAGE_NAME= 'Configuring Build'[2019-06-27T14:08:24.320Z] SYSTEMDRIVE   = 'C:'[2019-06-27T14:08:24.320Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-27T14:08:24.320Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-27T14:08:24.320Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-27T14:08:24.320Z] UCRTVERSION   = '10.0.17763.0'[2019-06-27T14:08:24.320Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-27T14:08:24.320Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-27T14:08:24.320Z] USERNAME  = 'Jenkins'[2019-06-27T14:08:24.320Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-27T14:08:24.320Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-27T14:08:24.320Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-27T14:08:24.320Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-27T14:08:24.320Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-27T14:08:24.320Z] VCTOOLSVERSION= '14.16.27023'[2019-06-27T14:08:24.320Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-27T14:08:24.320Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-27T14:08:24.320Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-27T14:08:24.320Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-27T14:08:24.320Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-27T14:08:24.320Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-27T14:08:24.320Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-27T14:08:24.320Z] VSCMD_VER = '16.0.3'[2019-06-27T14:08:24.320Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-27T14:08:24.320Z] WINDIR= 'C:\WINDOWS'[2019-06-27T14:08:24.320Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-27T14:08:24.320Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-27T14:08:24.320Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-27T14:08:24.320Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-27T14:08:24.320Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-27T14:08:24.320Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-27T14:08:24.320Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-06-27T14:08:24.320Z] __DOTNET_ADD_64BIT= '1'[2019-06-27T14:08:24.320Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-27T14:08:24.320Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-27T14:08:24.320Z] 

D22106: [Separator] Match Breeze borders' color

2019-06-27 Thread Mariusz Glebocki
mglb added a comment.


  Widgets style: 
https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76
  
  Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha 
and either color mixing or transparent text color.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22106

To: filipf, #kirigami, #vdg, ngraham
Cc: mglb, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein


D22122: use pwquality_strerror to get error strings

2019-06-27 Thread Harald Sitter
sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  libpwquality has localized error string mappings, no need to reinvent
  the wheel here. the previous mapping was fairly incomplete resulting in
  cases where one would get the generic "use another password" option
  was shown, which is fairly meh as it can mean literally anything.
  
  should libpwquality for whatever reason fail to provide a string we will
  still fall back to the unfortunate generic default. better than nothing
  I suppose.
  
  also carry around auxerror. it contains data such as how many digits
  would have been reuired. auxerror doesn't need freeing it simply contains
  pointers to internals for the benefit of pwquality_strerror
  
  CHANGELOG: Password quality problems are better explained in the UI

TEST PLAN
  password 'a' now gets error'd as a palindrom rather than the generic error. 
other errors such as too-short, no-match continue to be reported properly as 
well

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22122

AFFECTED FILES
  src/passworddialog.cpp
  src/passworddialog.h

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-27 Thread David Redondo
davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Allows setting of other sorting orders like alphabetical or last modified 
date.
  To enable this a new ProxyModel is introduced which handles the sorting and
  filtering (as indicated by the checkboxes). This is backed by the 
slideshowModel
  whcih previously as only used for the configutation. The lists of slides and  
unseen
  slides are dropped as now the slides that are shown are taken from the model.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D18920: Fix and update PCI module

2019-06-27 Thread Konrad Rzepecki
konradr added a comment.


  Ufff, I can try. Do you want new string names diff separated from "#pragrma 
pack" diff?
  
  However, the only one  important change is this two lines:
  #pragma pack(push, 1)
  #pragma pack(pop)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18920

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D21797: do not set a hardcoded minimum size

2019-06-27 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:fdff5bd4bc20: do not set a hardcoded minimum size 
(authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21797?vs=59989=60721

REVISION DETAIL
  https://phabricator.kde.org/D21797

AFFECTED FILES
  src/backtracewidget.cpp
  src/bugzillaintegration/reportassistantdialog.cpp
  src/drkonqidialog.cpp
  src/ui/backtracewidget.ui
  src/ui/maindialog.ui

To: sitter, #plasma, apol
Cc: apol, cfeck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart


D21801: force the backtracewidget into loading state when the generator is loading

2019-06-27 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:c2775e7335a1: force the backtracewidget into loading 
state when the generator is loading (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21801?vs=59790=60720

REVISION DETAIL
  https://phabricator.kde.org/D21801

AFFECTED FILES
  src/backtracewidget.cpp

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 12 - Still Failing!

2019-06-27 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/12/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 27 Jun 2019 11:43:36 +
 Build duration:
3 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 221 lines...][2019-06-27T11:46:28.593Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-27T11:46:28.593Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-06-27T11:46:28.593Z] PROCESSOR_LEVEL   = '6'[2019-06-27T11:46:28.593Z] PROCESSOR_REVISION= '5e03'[2019-06-27T11:46:28.593Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-27T11:46:28.593Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-27T11:46:28.593Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-27T11:46:28.593Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-27T11:46:28.593Z] PROMPT= '$P$G'[2019-06-27T11:46:28.593Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-27T11:46:28.593Z] PUBLIC= 'C:\Users\Public'[2019-06-27T11:46:28.593Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/12/display/redirect?page=changes'[2019-06-27T11:46:28.593Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/12/display/redirect'[2019-06-27T11:46:28.593Z] STAGE_NAME= 'Configuring Build'[2019-06-27T11:46:28.593Z] SYSTEMDRIVE   = 'C:'[2019-06-27T11:46:28.593Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-27T11:46:28.593Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-27T11:46:28.593Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-27T11:46:28.593Z] UCRTVERSION   = '10.0.17763.0'[2019-06-27T11:46:28.593Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-27T11:46:28.593Z] USERDOMAIN= 'DESKTOP-66R8QOQ'[2019-06-27T11:46:28.593Z] USERNAME  = 'Jenkins'[2019-06-27T11:46:28.593Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-27T11:46:28.593Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-27T11:46:28.593Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-27T11:46:28.593Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-27T11:46:28.593Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-27T11:46:28.593Z] VCTOOLSVERSION= '14.16.27023'[2019-06-27T11:46:28.593Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-27T11:46:28.593Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-27T11:46:28.593Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-27T11:46:28.593Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-27T11:46:28.593Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-27T11:46:28.593Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-27T11:46:28.593Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-27T11:46:28.593Z] VSCMD_VER = '16.0.3'[2019-06-27T11:46:28.593Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-27T11:46:28.593Z] WINDIR= 'C:\WINDOWS'[2019-06-27T11:46:28.593Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-27T11:46:28.593Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-27T11:46:28.593Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-27T11:46:28.593Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-27T11:46:28.593Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-27T11:46:28.593Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-27T11:46:28.594Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11'[2019-06-27T11:46:28.594Z] __DOTNET_ADD_64BIT= '1'[2019-06-27T11:46:28.594Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-27T11:46:28.594Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program 

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Still Failing!

2019-06-27 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/36/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 27 Jun 2019 11:43:36 +
 Build duration:
2 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-06-27T11:46:09.228Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-27T11:46:09.228Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-06-27T11:46:09.228Z] PROCESSOR_LEVEL   = '6'[2019-06-27T11:46:09.228Z] PROCESSOR_REVISION= '5e03'[2019-06-27T11:46:09.228Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-27T11:46:09.228Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-27T11:46:09.228Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-27T11:46:09.228Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-27T11:46:09.228Z] PROMPT= '$P$G'[2019-06-27T11:46:09.228Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-27T11:46:09.228Z] PUBLIC= 'C:\Users\Public'[2019-06-27T11:46:09.228Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/36/display/redirect?page=changes'[2019-06-27T11:46:09.228Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/36/display/redirect'[2019-06-27T11:46:09.228Z] STAGE_NAME= 'Configuring Build'[2019-06-27T11:46:09.228Z] SYSTEMDRIVE   = 'C:'[2019-06-27T11:46:09.228Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-27T11:46:09.228Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-27T11:46:09.228Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-27T11:46:09.228Z] UCRTVERSION   = '10.0.17763.0'[2019-06-27T11:46:09.228Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-27T11:46:09.228Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-27T11:46:09.228Z] USERNAME  = 'Jenkins'[2019-06-27T11:46:09.228Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-27T11:46:09.228Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-27T11:46:09.228Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-27T11:46:09.228Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-27T11:46:09.228Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-27T11:46:09.228Z] VCTOOLSVERSION= '14.16.27023'[2019-06-27T11:46:09.228Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-27T11:46:09.228Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-27T11:46:09.229Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-27T11:46:09.229Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-27T11:46:09.229Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-27T11:46:09.229Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-27T11:46:09.229Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-27T11:46:09.229Z] VSCMD_VER = '16.0.3'[2019-06-27T11:46:09.229Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-27T11:46:09.229Z] WINDIR= 'C:\WINDOWS'[2019-06-27T11:46:09.229Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-27T11:46:09.229Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-27T11:46:09.229Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-27T11:46:09.229Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-27T11:46:09.229Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-27T11:46:09.229Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-27T11:46:09.229Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-06-27T11:46:09.229Z] __DOTNET_ADD_64BIT= '1'[2019-06-27T11:46:09.229Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-27T11:46:09.229Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-27T11:46:09.229Z] 

D20569: RFC: Use more compact OSD

2019-06-27 Thread Filip Fila
filipf added a comment.


  I've been thinking about this OSD themes thing and I can't say I like it. I 
don't like the fact that you now need a different LnF to change them either, 
but to have another configurable theme thing seems like overkill.
  
  Although it's not without a solution without drawbacks, visually and 
functionally I'd love to have the OSDs spawned as notifications. It would also 
make it super easy to just turn them off for DnD mode, which can be super 
easily turned on for when playing games or watching video.
  
  I don't think it would work with the current screen layout chooser OSD though.
  
  Then if that's not possible I'd keep them the way they are but include the 
option to disable them for full-screen apps.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, davidedmundson, hein, Codezela, Fuchs, filipf, zzag, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


D21797: do not set a hardcoded minimum size

2019-06-27 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good.

REPOSITORY
  R871 DrKonqi

BRANCH
  minimums

REVISION DETAIL
  https://phabricator.kde.org/D21797

To: sitter, #plasma, apol
Cc: apol, cfeck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart


D22106: [Separator] Match Breeze borders' color

2019-06-27 Thread Aleix Pol Gonzalez
apol added a comment.


  Maybe we should have the Theme provide the opacity somehow?
  
  You can look at the kde:breeze repository for the kstyle and others.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22106

To: filipf, #kirigami, #vdg, ngraham
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein


D18860: Add comment / description to the translations kcm

2019-06-27 Thread Harald Sitter
sitter added a comment.


  Mh, technically it's not setting system language, is it? It changes the 
user's language but has no facilities to apply that at system scope (i.e. 
across all users)
  
  Looking at the other KCMs the comment is more of the form 
"Configure/Change/Customize foobar" or "Foobar settings". I am not sure how 
exactly the comment is used in plasma-settings, but I am guessing "Change 
application languages" would fit better for a "description" of what one can do 
with this?

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma, ngraham
Cc: sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart


D22088: [Notifications] Ignore excess spam

2019-06-27 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0ed653ba75d6: [Notifications] Ignore excess spam 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22088?vs=60634=60715

REVISION DETAIL
  https://phabricator.kde.org/D22088

AFFECTED FILES
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D21510: Filter KNewStuff Plasma Themes by Download Tag

2019-06-27 Thread Dan Leinir Turthra Jensen
leinir added a comment.


  In D21510#472572 , @ngraham wrote:
  
  > Can you update the test plan to provide examples of themes that are 
correctly tagged so we can test this?
  >
  > - Plasma 5 only theme
  > - Plasma 4 only theme
  > - Theme that works on both Plasma 4 and 5
  
  
  When i first looked, for some reason i couldn't find any that matched the 
last option (i feel fairly certain that it was there when i originally 
checked), and then got sidetracked. Here is a list of three themes which match 
the three conditions:
  
  Plasma 5 only theme: "OxyLight 5 Plasma theme" (id: 998609)
  Plasma 4 only theme: "A Pimp Named Slickback (for the contest)" (id: 998596)
  Theme which says it works on both: "OxygenDymAero7" (id: 1305103)
  
  (and, of course, any theme which has no version set will be accepted, or we'd 
be filtering out the vast majority of themes on there...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still unstable!

2019-06-27 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.12/18/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 27 Jun 2019 08:39:26 +
 Build duration:
56 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.idletime.idleTest_kwayland_test

D22084: Span wayland objects to lifespan of the QApplication

2019-06-27 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R130:bfce3c6727cd: Span wayland objects to lifespan of the 
QApplication (authored by davidedmundson).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22084?vs=60705=60712

REVISION DETAIL
  https://phabricator.kde.org/D22084

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h

To: davidedmundson, #plasma, zzag
Cc: apol, ngraham, anthonyfieroni, zzag, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart