date:20190705

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

2019-07-05 Thread Hugo Pereira Da Costa

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:d6b2a3a36a1c: Remove unneeded 1 pixel margin around side 
panels (authored by hpereiradacosta).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22138?vs=61228=61236

REVISION DETAIL
  https://phabricator.kde.org/D22138

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

2019-07-05 Thread Noah Davis

ndavis added a comment.


  Works for me. Tested RTL with `kate --reverse`.

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

2019-07-05 Thread Hugo Pereira Da Costa

hpereiradacosta updated this revision to Diff 61228.
hpereiradacosta added a comment.


  Simplified the patch: special case in ::pixelMetrics is in fact not needed, 
because it is overridden in ::frameContentsRect anyway

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22138?vs=61227=61228

REVISION DETAIL
  https://phabricator.kde.org/D22138

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

2019-07-05 Thread Hugo Pereira Da Costa

hpereiradacosta updated this revision to Diff 61227.
hpereiradacosta added a comment.


  New patch, adding proper margin to avoid overlap with viewport

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22138?vs=60773=61227

REVISION DETAIL
  https://phabricator.kde.org/D22138

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

2019-07-05 Thread Hugo Pereira Da Costa

hpereiradacosta added a comment.


  In D22138#491285 , @mart wrote:
  
  > In D22138#491173 , 
@hpereiradacosta wrote:
  >
  > > Indeed. This is a problem. As soon as treeviews are animated Qt makes a 
pixmap copy of the treeview viewport. This does not include the blue line on 
the side, which is painted in the frame, below the (transparent) viewport. Will 
investigate further.
  >
  >
  > would still adding a pixel on the right work around the issue?
  
  
  Yes, left or right depending of RTL. I have a working patch (I think). Will 
upload in a minute.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 51 - Still Failing!

2019-07-05 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/51/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 05 Jul 2019 14:50:56 +
 Build duration:
2 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-05T14:53:22.262Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-05T14:53:22.262Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-05T14:53:22.262Z] PROCESSOR_LEVEL   = '6'[2019-07-05T14:53:22.262Z] PROCESSOR_REVISION= '5e03'[2019-07-05T14:53:22.262Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-05T14:53:22.262Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-05T14:53:22.262Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-05T14:53:22.262Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-05T14:53:22.262Z] PROMPT= '$P$G'[2019-07-05T14:53:22.262Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-05T14:53:22.262Z] PUBLIC= 'C:\Users\Public'[2019-07-05T14:53:22.262Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/51/display/redirect?page=changes'[2019-07-05T14:53:22.262Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/51/display/redirect'[2019-07-05T14:53:22.262Z] STAGE_NAME= 'Configuring Build'[2019-07-05T14:53:22.262Z] SYSTEMDRIVE   = 'C:'[2019-07-05T14:53:22.262Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-05T14:53:22.262Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-05T14:53:22.262Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-05T14:53:22.262Z] UCRTVERSION   = '10.0.17763.0'[2019-07-05T14:53:22.262Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-05T14:53:22.262Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-05T14:53:22.262Z] USERNAME  = 'Jenkins'[2019-07-05T14:53:22.262Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-05T14:53:22.262Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-05T14:53:22.262Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-05T14:53:22.262Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-05T14:53:22.262Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-05T14:53:22.262Z] VCTOOLSVERSION= '14.16.27023'[2019-07-05T14:53:22.262Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-05T14:53:22.262Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-05T14:53:22.262Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-05T14:53:22.262Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-05T14:53:22.262Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-05T14:53:22.262Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-05T14:53:22.262Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-05T14:53:22.262Z] VSCMD_VER = '16.0.3'[2019-07-05T14:53:22.262Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-05T14:53:22.262Z] WINDIR= 'C:\WINDOWS'[2019-07-05T14:53:22.262Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-05T14:53:22.262Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-05T14:53:22.262Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-05T14:53:22.262Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-05T14:53:22.262Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-05T14:53:22.262Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-05T14:53:22.262Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-05T14:53:22.262Z] __DOTNET_ADD_64BIT= '1'[2019-07-05T14:53:22.262Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-05T14:53:22.262Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-05T14:53:22.262Z]

D22288: force a token refresh before submitting the report

2019-07-05 Thread Harald Sitter

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:824efbe6aa17: force a token refresh before submitting the 
report (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22288?vs=61204=61222

REVISION DETAIL
  https://phabricator.kde.org/D22288

AFFECTED FILES
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportinterface.h

To: sitter, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22289: hijack nextbutton on preview page and rename it to Submit!

2019-07-05 Thread Harald Sitter

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:470549de27d8: hijack nextbutton on preview page and 
rename it to Submit! (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22289?vs=61205=61223#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22289?vs=61205=61223

REVISION DETAIL
  https://phabricator.kde.org/D22289

AFFECTED FILES
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h

To: sitter, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22268: Port containmentActions to use KPlugin instead of KService

2019-07-05 Thread Aleix Pol Gonzalez

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7e2c5231114e: Port containmentActions to use KPlugin 
instead of KService (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22268?vs=61137=61219

REVISION DETAIL
  https://phabricator.kde.org/D22268

AFFECTED FILES
  containmentactions/applauncher/CMakeLists.txt
  containmentactions/contextmenu/CMakeLists.txt
  containmentactions/paste/CMakeLists.txt
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchwindow/CMakeLists.txt

To: apol, #plasma, mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-05 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> image.cpp:600
> +m_slideshowModel->addBackground(path);
> +m_currentSlide = m_slideFilterModel->indexOf(path) - 1;
>  nextSlide();

what will happen if you add a background that the slideFilterModel then filters 
out?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-05 Thread Nathaniel Graham

ngraham added a comment.


  Huh, in a VM everything works for me too. I wonder if there's some subtle 
issue with the fact that I'm running a custom-compiled Plasma at a different 
path on bare metal.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 131 - Fixed!

2019-07-05 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/131/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 13:32:21 +
 Build duration:
4 min 22 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)46%
(58/126)46%
(58/126)39%
(5215/13442)28%
(2748/9911)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1077/1123)51%
(556/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(780/2302)27%
(394/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1689/3505)36%
(1021/2837)src.plasma.packagestructure57%
(4/7)57%
(4/7)36%
(50/137)42%
(5/12)src.plasma.private67%
(12/18)67%
(12/18)60%
(952/1594)41%
(429/1048)src.plasma.scripting67%
(2/3)67%
(2/3)21%
(35/167)11%
(14/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(588/2020)19%
(324/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1185)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.12 - Build # 139 - Still unstable!

2019-07-05 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.12/139/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 05 Jul 2019 11:57:43 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 139 - Still unstable!

2019-07-05 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/139/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 05 Jul 2019 11:57:43 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 128 - Fixed!

2019-07-05 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/128/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:57:43 +
 Build duration:
8 min 34 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)46%
(58/126)46%
(58/126)39%
(5213/13442)28%
(2748/9911)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1075/1123)51%
(556/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(780/2302)27%
(394/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1689/3505)36%
(1021/2837)src.plasma.packagestructure57%
(4/7)57%
(4/7)36%
(50/137)42%
(5/12)src.plasma.private67%
(12/18)67%
(12/18)60%
(952/1594)41%
(429/1048)src.plasma.scripting67%
(2/3)67%
(2/3)21%
(35/167)11%
(14/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(588/2020)19%
(324/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1185)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

D15875: [Media Controller] Disallow seeking beyond end of track

2019-07-05 Thread Fabian Vogt

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.

  In D15875#334752 , @anthonyfieroni 
wrote:

  > 1s file is a corner case as well as 0, cause you have always 2 positions - 
start and stop.

  The slider's value is floating point, so you also have the (theoretically) 
infinite positions in between.

  > In 0/1s these 2 steps just match, if you are right 0 isn't valid in 0s 
length file, does it?

  A file with 0s length can't be seeked.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15875

To: broulik, #plasma, fvogt
Cc: anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 130 - Still Failing!

2019-07-05 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/130/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:57:43 +
 Build duration:
4 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 4475 lines...][2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/components/plugins.qmltypes[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/libplasmaextracomponentsplugin.so[2019-07-05T12:02:25.428Z] -- Set runtime path of "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert//home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/libplasmaextracomponentsplugin.so" to "/home/jenkins/install-prefix/lib64"[2019-07-05T12:02:25.428Z] -- Up-to-date: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/Title.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/DescriptiveLabel.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/animations[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/animations/ReleasedAnimation.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/animations/PressedAnimation.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/animations/DisappearAnimation.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/animations/AppearAnimation.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/animations/ActivateAnimation.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/Heading.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/App.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/PageRow.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/ConditionalLoader.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/ScrollArea.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/Paragraph.qml[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/qmldir[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/extras/plugins.qmltypes[2019-07-05T12:02:25.428Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/platformcomponents/libplatformcomponentsplugin.so[2019-07-05T12:02:25.428Z] -- Set runtime path of "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert//home/jenkins/install-prefix/lib64/qml/org/kde/plasma/platformcomponents/libplatformcomponentsplugin.so" to "/home/jenkins/install-prefix/lib64"[2019-07-05T12:02:25.428Z] -- Installing:

D22285: [ActionTextField] Make action glow on press

2019-07-05 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:4384fa0c8162: [ActionTextField] Make action glow on press 
(authored by broulik).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22285?vs=61195=61214

REVISION DETAIL
  https://phabricator.kde.org/D22285

AFFECTED FILES
  src/controls/ActionTextField.qml

To: broulik, #plasma, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22229: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false

2019-07-05 Thread Kai Uwe Broulik

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:0c1b8d57b0ea: Ignore Next/Previous call if 
CanGoNext/CanGoPrevious are false (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9?vs=61050=61212

REVISION DETAIL
  https://phabricator.kde.org/D9

AFFECTED FILES
  host/mprisplugin.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22065: Introduce PluginManager

2019-07-05 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:cc4436cf491c: Introduce PluginManager (authored by 
broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22065?vs=60997=61211

REVISION DETAIL
  https://phabricator.kde.org/D22065

AFFECTED FILES
  host/CMakeLists.txt
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/main.cpp
  host/pluginmanager.cpp
  host/pluginmanager.h
  host/settings.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 149 - Still Failing!

2019-07-05 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/149/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:43:13 +
 Build duration:
2 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 604 lines...][2019-07-05T11:45:13.267Z]  * Qt5Concurrent[2019-07-05T11:45:13.267Z]  * KF5Auth (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5Plasma (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5PlasmaQuick (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5DocTools (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5NewStuff (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5Notifications (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5Attica (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5Wallet (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5Runner (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5People (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5ActivitiesStats (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * KF5 (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * LibKWorkspace (required version >= 5.14.90)[2019-07-05T11:45:13.267Z]  * LibTaskManager (required version >= 5.14.90)[2019-07-05T11:45:13.267Z]  * LibNotificationManager (required version >= 5.14.90)[2019-07-05T11:45:13.267Z]  * LibColorCorrect (required version >= 5.14.90)[2019-07-05T11:45:13.267Z]  * KWinDBusInterface[2019-07-05T11:45:13.267Z]  * ScreenSaverDBusInterface[2019-07-05T11:45:13.267Z]  * KRunnerAppDBusInterface[2019-07-05T11:45:13.267Z]  * KSMServerDBusInterface[2019-07-05T11:45:13.267Z]  * KF5ItemModels[2019-07-05T11:45:13.267Z]  * KF5Emoticons[2019-07-05T11:45:13.267Z]  * Qt5Core[2019-07-05T11:45:13.267Z]  * Qt5DBus[2019-07-05T11:45:13.267Z]  * KF5KCMUtils[2019-07-05T11:45:13.267Z]  * KF5Declarative[2019-07-05T11:45:13.267Z]  * KF5XmlGui[2019-07-05T11:45:13.267Z]  * Qt5Gui[2019-07-05T11:45:13.267Z]  * Qt5Sql[2019-07-05T11:45:13.267Z]  * Qt5QuickWidgets[2019-07-05T11:45:13.267Z]  * KF5WidgetsAddons[2019-07-05T11:45:13.267Z]  * KDED (required version >= 5.58.0)[2019-07-05T11:45:13.267Z]  * X11_XCB, A compatibility library for code that translates Xlib API calls into XCB calls, [2019-07-05T11:45:13.267Z]  * XCB, X protocol C-language Binding, [2019-07-05T11:45:13.267Z]  * Qt5Test[2019-07-05T11:45:13.267Z]  * ECM (required version >= 0.0.8)[2019-07-05T11:45:13.267Z]  * Qt5Widgets[2019-07-05T11:45:13.267Z]  * Qt5Qml[2019-07-05T11:45:13.267Z]  * Qt5X11Extras[2019-07-05T11:45:13.267Z]  * Qt5Quick[2019-07-05T11:45:13.267Z]  * Qt5[2019-07-05T11:45:13.267Z]  * Gettext[2019-07-05T11:45:13.267Z]  * KF5I18n[2019-07-05T11:45:13.267Z]  * KF5Config[2019-07-05T11:45:13.267Z]  * KF5CoreAddons[2019-07-05T11:45:13.267Z]  * KF5GlobalAccel[2019-07-05T11:45:13.267Z]  * KF5GuiAddons[2019-07-05T11:45:13.267Z]  * KF5KIO[2019-07-05T11:45:13.267Z]  * KF5Activities[2019-07-05T11:45:13.267Z]  * KF5WindowSystem[2019-07-05T11:45:13.267Z]  * PkgConfig[2019-07-05T11:45:13.267Z]  * X11, X11 libraries, [2019-07-05T11:45:13.267Z]Required for building the X11 based workspace[2019-07-05T11:45:13.267Z]  * Phonon4Qt5[2019-07-05T11:45:13.267Z] [2019-07-05T11:45:13.267Z] -- The following features have been disabled:[2019-07-05T11:45:13.267Z] [2019-07-05T11:45:13.267Z]  * XorgLibinput, Libinput driver headers needed for mouse and touchpad KCM[2019-07-05T11:45:13.267Z] [2019-07-05T11:45:13.267Z] -- The following OPTIONAL packages have not been found:[2019-07-05T11:45:13.267Z] [2019-07-05T11:45:13.267Z]  * XorgLibinput, Libinput driver headers needed for mouse and touchpad KCM[2019-07-05T11:45:13.267Z] [2019-07-05T11:45:13.267Z] CMake Error: The following variables are used in this project, but they are set to NOTFOUND.[2019-07-05T11:45:13.267Z] Please set them or make sure they are set and tested correctly in the CMake files:[2019-07-05T11:45:13.267Z] XORGLIBINPUT_INCLUDE_DIRS (ADVANCED)[2019-07-05T11:45:13.267Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:45:13.267Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:45:13.267Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:45:13.267Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:45:13.267Z]used as include directory in directory

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 148 - Failure!

2019-07-05 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/148/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:35:43 +
 Build duration:
7 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 604 lines...][2019-07-05T11:43:11.876Z]  * Qt5Concurrent[2019-07-05T11:43:11.876Z]  * KF5Auth (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5Plasma (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5PlasmaQuick (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5DocTools (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5NewStuff (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5Notifications (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5Attica (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5Wallet (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5Runner (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5People (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5ActivitiesStats (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * KF5 (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * LibKWorkspace (required version >= 5.14.90)[2019-07-05T11:43:11.876Z]  * LibTaskManager (required version >= 5.14.90)[2019-07-05T11:43:11.876Z]  * LibNotificationManager (required version >= 5.14.90)[2019-07-05T11:43:11.876Z]  * LibColorCorrect (required version >= 5.14.90)[2019-07-05T11:43:11.876Z]  * KWinDBusInterface[2019-07-05T11:43:11.876Z]  * ScreenSaverDBusInterface[2019-07-05T11:43:11.876Z]  * KRunnerAppDBusInterface[2019-07-05T11:43:11.876Z]  * KSMServerDBusInterface[2019-07-05T11:43:11.876Z]  * KF5ItemModels[2019-07-05T11:43:11.876Z]  * KF5Emoticons[2019-07-05T11:43:11.876Z]  * Qt5Core[2019-07-05T11:43:11.876Z]  * Qt5DBus[2019-07-05T11:43:11.876Z]  * KF5KCMUtils[2019-07-05T11:43:11.876Z]  * KF5Declarative[2019-07-05T11:43:11.876Z]  * KF5XmlGui[2019-07-05T11:43:11.876Z]  * Qt5Gui[2019-07-05T11:43:11.876Z]  * Qt5Sql[2019-07-05T11:43:11.876Z]  * Qt5QuickWidgets[2019-07-05T11:43:11.876Z]  * KF5WidgetsAddons[2019-07-05T11:43:11.876Z]  * KDED (required version >= 5.58.0)[2019-07-05T11:43:11.876Z]  * X11_XCB, A compatibility library for code that translates Xlib API calls into XCB calls, [2019-07-05T11:43:11.876Z]  * XCB, X protocol C-language Binding, [2019-07-05T11:43:11.876Z]  * Qt5Test[2019-07-05T11:43:11.876Z]  * ECM (required version >= 0.0.8)[2019-07-05T11:43:11.876Z]  * Qt5Widgets[2019-07-05T11:43:11.876Z]  * Qt5Qml[2019-07-05T11:43:11.876Z]  * Qt5X11Extras[2019-07-05T11:43:11.876Z]  * Qt5Quick[2019-07-05T11:43:11.876Z]  * Qt5[2019-07-05T11:43:11.876Z]  * Gettext[2019-07-05T11:43:11.876Z]  * KF5I18n[2019-07-05T11:43:11.876Z]  * KF5Config[2019-07-05T11:43:11.876Z]  * KF5CoreAddons[2019-07-05T11:43:11.876Z]  * KF5GlobalAccel[2019-07-05T11:43:11.876Z]  * KF5GuiAddons[2019-07-05T11:43:11.876Z]  * KF5KIO[2019-07-05T11:43:11.876Z]  * KF5Activities[2019-07-05T11:43:11.876Z]  * KF5WindowSystem[2019-07-05T11:43:11.876Z]  * PkgConfig[2019-07-05T11:43:11.876Z]  * X11, X11 libraries, [2019-07-05T11:43:11.876Z]Required for building the X11 based workspace[2019-07-05T11:43:11.876Z]  * Phonon4Qt5[2019-07-05T11:43:11.876Z] [2019-07-05T11:43:11.876Z] -- The following features have been disabled:[2019-07-05T11:43:11.876Z] [2019-07-05T11:43:11.876Z]  * XorgLibinput, Libinput driver headers needed for mouse and touchpad KCM[2019-07-05T11:43:11.876Z] [2019-07-05T11:43:11.876Z] -- The following OPTIONAL packages have not been found:[2019-07-05T11:43:11.876Z] [2019-07-05T11:43:11.876Z]  * XorgLibinput, Libinput driver headers needed for mouse and touchpad KCM[2019-07-05T11:43:11.876Z] [2019-07-05T11:43:11.876Z] CMake Error: The following variables are used in this project, but they are set to NOTFOUND.[2019-07-05T11:43:11.876Z] Please set them or make sure they are set and tested correctly in the CMake files:[2019-07-05T11:43:11.876Z] XORGLIBINPUT_INCLUDE_DIRS (ADVANCED)[2019-07-05T11:43:11.876Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:43:11.876Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:43:11.876Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:43:11.876Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:43:11.876Z]used as include directory in directory

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 289 - Still Failing!

2019-07-05 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/289/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:37:03 +
 Build duration:
1 min 54 sec and counting
   CONSOLE OUTPUT
  [...truncated 603 lines...][2019-07-05T11:38:56.912Z]  * Qt5Concurrent[2019-07-05T11:38:56.912Z]  * KF5Auth (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5Plasma (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5PlasmaQuick (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5DocTools (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5NewStuff (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5Notifications (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5Attica (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5Wallet (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5Runner (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5People (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5ActivitiesStats (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * KF5 (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * LibKWorkspace (required version >= 5.14.90)[2019-07-05T11:38:56.912Z]  * LibTaskManager (required version >= 5.14.90)[2019-07-05T11:38:56.912Z]  * LibNotificationManager (required version >= 5.14.90)[2019-07-05T11:38:56.912Z]  * LibColorCorrect (required version >= 5.14.90)[2019-07-05T11:38:56.912Z]  * KWinDBusInterface[2019-07-05T11:38:56.912Z]  * ScreenSaverDBusInterface[2019-07-05T11:38:56.912Z]  * KRunnerAppDBusInterface[2019-07-05T11:38:56.912Z]  * KSMServerDBusInterface[2019-07-05T11:38:56.912Z]  * KF5ItemModels[2019-07-05T11:38:56.912Z]  * KF5Emoticons[2019-07-05T11:38:56.912Z]  * Qt5Core[2019-07-05T11:38:56.912Z]  * Qt5DBus[2019-07-05T11:38:56.912Z]  * KF5KCMUtils[2019-07-05T11:38:56.912Z]  * KF5Declarative[2019-07-05T11:38:56.912Z]  * KF5XmlGui[2019-07-05T11:38:56.912Z]  * Qt5Gui[2019-07-05T11:38:56.912Z]  * Qt5Sql[2019-07-05T11:38:56.912Z]  * Qt5QuickWidgets[2019-07-05T11:38:56.912Z]  * KF5WidgetsAddons[2019-07-05T11:38:56.912Z]  * KDED (required version >= 5.58.0)[2019-07-05T11:38:56.912Z]  * X11_XCB, A compatibility library for code that translates Xlib API calls into XCB calls, [2019-07-05T11:38:56.912Z]  * XCB, X protocol C-language Binding, [2019-07-05T11:38:56.912Z]  * Qt5Test[2019-07-05T11:38:56.912Z]  * ECM (required version >= 0.0.8)[2019-07-05T11:38:56.912Z]  * Qt5Widgets[2019-07-05T11:38:56.912Z]  * Qt5Qml[2019-07-05T11:38:56.912Z]  * Qt5X11Extras[2019-07-05T11:38:56.912Z]  * Qt5Quick[2019-07-05T11:38:56.912Z]  * Qt5[2019-07-05T11:38:56.912Z]  * Gettext[2019-07-05T11:38:56.912Z]  * KF5I18n[2019-07-05T11:38:56.912Z]  * KF5Config[2019-07-05T11:38:56.912Z]  * KF5CoreAddons[2019-07-05T11:38:56.912Z]  * KF5GlobalAccel[2019-07-05T11:38:56.912Z]  * KF5GuiAddons[2019-07-05T11:38:56.912Z]  * KF5KIO[2019-07-05T11:38:56.912Z]  * KF5Activities[2019-07-05T11:38:56.912Z]  * KF5WindowSystem[2019-07-05T11:38:56.912Z]  * PkgConfig[2019-07-05T11:38:56.912Z]  * X11, X11 libraries, [2019-07-05T11:38:56.912Z]Required for building the X11 based workspace[2019-07-05T11:38:56.912Z]  * Phonon4Qt5[2019-07-05T11:38:56.912Z] [2019-07-05T11:38:56.912Z] -- The following features have been disabled:[2019-07-05T11:38:56.912Z] [2019-07-05T11:38:56.912Z]  * XorgLibinput, Libinput driver headers needed for mouse and touchpad KCM[2019-07-05T11:38:56.912Z] [2019-07-05T11:38:56.912Z] -- The following OPTIONAL packages have not been found:[2019-07-05T11:38:56.912Z] [2019-07-05T11:38:56.912Z]  * XorgLibinput, Libinput driver headers needed for mouse and touchpad KCM[2019-07-05T11:38:56.912Z] [2019-07-05T11:38:57.168Z] CMake Error: The following variables are used in this project, but they are set to NOTFOUND.[2019-07-05T11:38:57.168Z] Please set them or make sure they are set and tested correctly in the CMake files:[2019-07-05T11:38:57.168Z] XORGLIBINPUT_INCLUDE_DIRS (ADVANCED)[2019-07-05T11:38:57.168Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:38:57.168Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:38:57.168Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:38:57.168Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:38:57.168Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 288 - Failure!

2019-07-05 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/288/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:35:43 +
 Build duration:
1 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 603 lines...][2019-07-05T11:36:58.980Z]  * Qt5Concurrent[2019-07-05T11:36:58.980Z]  * KF5Auth (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5Plasma (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5PlasmaQuick (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5DocTools (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5NewStuff (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5Notifications (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5Attica (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5Wallet (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5Runner (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5People (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5ActivitiesStats (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * KF5 (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * LibKWorkspace (required version >= 5.14.90)[2019-07-05T11:36:58.980Z]  * LibTaskManager (required version >= 5.14.90)[2019-07-05T11:36:58.980Z]  * LibNotificationManager (required version >= 5.14.90)[2019-07-05T11:36:58.980Z]  * LibColorCorrect (required version >= 5.14.90)[2019-07-05T11:36:58.980Z]  * KWinDBusInterface[2019-07-05T11:36:58.980Z]  * ScreenSaverDBusInterface[2019-07-05T11:36:58.980Z]  * KRunnerAppDBusInterface[2019-07-05T11:36:58.980Z]  * KSMServerDBusInterface[2019-07-05T11:36:58.980Z]  * KF5ItemModels[2019-07-05T11:36:58.980Z]  * KF5Emoticons[2019-07-05T11:36:58.980Z]  * Qt5Core[2019-07-05T11:36:58.980Z]  * Qt5DBus[2019-07-05T11:36:58.980Z]  * KF5KCMUtils[2019-07-05T11:36:58.980Z]  * KF5Declarative[2019-07-05T11:36:58.980Z]  * KF5XmlGui[2019-07-05T11:36:58.980Z]  * Qt5Gui[2019-07-05T11:36:58.980Z]  * Qt5Sql[2019-07-05T11:36:58.980Z]  * Qt5QuickWidgets[2019-07-05T11:36:58.980Z]  * KF5WidgetsAddons[2019-07-05T11:36:58.980Z]  * KDED (required version >= 5.58.0)[2019-07-05T11:36:58.980Z]  * X11_XCB, A compatibility library for code that translates Xlib API calls into XCB calls, [2019-07-05T11:36:58.980Z]  * XCB, X protocol C-language Binding, [2019-07-05T11:36:58.980Z]  * Qt5Test[2019-07-05T11:36:58.980Z]  * ECM (required version >= 0.0.8)[2019-07-05T11:36:58.980Z]  * Qt5Widgets[2019-07-05T11:36:58.980Z]  * Qt5Qml[2019-07-05T11:36:58.980Z]  * Qt5X11Extras[2019-07-05T11:36:58.980Z]  * Qt5Quick[2019-07-05T11:36:58.981Z]  * Qt5[2019-07-05T11:36:58.981Z]  * Gettext[2019-07-05T11:36:58.981Z]  * KF5I18n[2019-07-05T11:36:58.981Z]  * KF5Config[2019-07-05T11:36:58.981Z]  * KF5CoreAddons[2019-07-05T11:36:58.981Z]  * KF5GlobalAccel[2019-07-05T11:36:58.981Z]  * KF5GuiAddons[2019-07-05T11:36:58.981Z]  * KF5KIO[2019-07-05T11:36:58.981Z]  * KF5Activities[2019-07-05T11:36:58.981Z]  * KF5WindowSystem[2019-07-05T11:36:58.981Z]  * PkgConfig[2019-07-05T11:36:58.981Z]  * X11, X11 libraries, [2019-07-05T11:36:58.981Z]Required for building the X11 based workspace[2019-07-05T11:36:58.981Z]  * Phonon4Qt5[2019-07-05T11:36:58.981Z] [2019-07-05T11:36:58.981Z] -- The following features have been disabled:[2019-07-05T11:36:58.981Z] [2019-07-05T11:36:58.981Z]  * XorgLibinput, Libinput driver headers needed for mouse and touchpad KCM[2019-07-05T11:36:58.981Z] [2019-07-05T11:36:58.981Z] -- The following OPTIONAL packages have not been found:[2019-07-05T11:36:58.981Z] [2019-07-05T11:36:58.981Z]  * XorgLibinput, Libinput driver headers needed for mouse and touchpad KCM[2019-07-05T11:36:58.981Z] [2019-07-05T11:36:58.981Z] CMake Error: The following variables are used in this project, but they are set to NOTFOUND.[2019-07-05T11:36:58.981Z] Please set them or make sure they are set and tested correctly in the CMake files:[2019-07-05T11:36:58.981Z] XORGLIBINPUT_INCLUDE_DIRS (ADVANCED)[2019-07-05T11:36:58.981Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:36:58.981Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:36:58.981Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:36:58.981Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src[2019-07-05T11:36:58.981Z]used as include directory in directory /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5

D22284: Add missing libinput include

2019-07-05 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ebc5bc9e1df2: Add missing libinput include (authored by 
bkchr, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22284?vs=61194=61209

REVISION DETAIL
  https://phabricator.kde.org/D22284

AFFECTED FILES
  kcms/touchpad/src/backends/x11.cmake

To: bkchr, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 129 - Still Failing!

2019-07-05 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/129/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:09:11 +
 Build duration:
1 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 1040 lines...][2019-07-05T11:10:23.478Z] /usr/include/qt5/QtCore/qvariant.h:520:35:   required from ���QVariant qVariantFromValue(const T&) [with T = KPluginMetaData]���[2019-07-05T11:10:23.478Z] /usr/include/qt5/QtCore/qvariant.h:366:31:   required from ���static QVariant QVariant::fromValue(const T&) [with T = KPluginMetaData]���[2019-07-05T11:10:23.478Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:421:112:   required from here[2019-07-05T11:10:23.478Z] /usr/include/qt5/QtCore/qmetatype.h:1662:96: error: ���qt_metatype_id��� is not a member of ���QMetaTypeId���[2019-07-05T11:10:23.478Z]  1662 | static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId::qt_metatype_id(); }[2019-07-05T11:10:23.478Z]   |  ~~^~[2019-07-05T11:10:23.478Z] /usr/include/qt5/QtCore/qmetatype.h:1662:100: error: body of ���constexpr��� function ���static constexpr int QMetaTypeId2::qt_metatype_id() [with T = KPluginMetaData]��� not a return-statement[2019-07-05T11:10:23.478Z]  1662 | static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId::qt_metatype_id(); }[2019-07-05T11:10:23.478Z]   |^[2019-07-05T11:10:23.478Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.cpp:23:[2019-07-05T11:10:23.478Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/private/containmentactions_p.h: In constructor ���Plasma::ContainmentActionsPrivate::ContainmentActionsPrivate(const QVariant&, Plasma::ContainmentActions*)���:[2019-07-05T11:10:23.478Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/private/containmentactions_p.h:33:162: warning: ���KPluginInfo::KPluginInfo(KService::Ptr)��� is deprecated [-Wdeprecated-declarations][2019-07-05T11:10:23.478Z]33 | containmentActionsDescription(arg.canConvert() ? arg.value() : KPluginInfo(KService::serviceByStorageId(arg.toString())).toMetaData()),[2019-07-05T11:10:23.478Z]   |  ^[2019-07-05T11:10:23.478Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.h:25,[2019-07-05T11:10:23.478Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.cpp:20:[2019-07-05T11:10:23.478Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: declared here[2019-07-05T11:10:23.478Z]   115 | explicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service);[2019-07-05T11:10:23.478Z]   |  ^~~[2019-07-05T11:10:23.478Z] make[2]: *** [src/plasma/CMakeFiles/KF5Plasma.dir/build.make:97: src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o] Error 1[2019-07-05T11:10:23.478Z] make[2]: *** Waiting for unfinished jobs[2019-07-05T11:10:23.478Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp: In member function ���Plasma::Package Plasma::Applet::package() const���:[2019-07-05T11:10:23.478Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:316:13: warning: ���Plasma::Package::Package(Plasma::PackageStructure*)��� is deprecated [-Wdeprecated-declarations][2019-07-05T11:10:23.478Z]   316 | Package p;[2019-07-05T11:10:23.478Z]   | ^[2019-07-05T11:10:23.478Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:50:[2019-07-05T11:10:23.478Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/package.h:95:32: note: declared here[2019-07-05T11:10:23.478Z]95 | PLASMA_DEPRECATED explicit Package(PackageStructure *structure = nullptr);[2019-07-05T11:10:23.478Z]   |^~~[2019-07-05T11:10:23.478Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:318:12: warning: ���Plasma::Package::Package(const Plasma::Package&)��� is deprecated [-Wdeprecated-declarations][2019-07-05T11:10:23.478Z]   318 | return p;[2019-07-05T11:10:23.478Z]   |^[2019-07-05T11:10:23.478Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

2019-07-05 Thread Marco Martin

mart added a comment.


  In D22138#491173 , 
@hpereiradacosta wrote:
  
  > Indeed. This is a problem. As soon as treeviews are animated Qt makes a 
pixmap copy of the treeview viewport. This does not include the blue line on 
the side, which is painted in the frame, below the (transparent) viewport. Will 
investigate further.
  
  
  would still adding a pixel on the right work around the issue?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22289: hijack nextbutton on preview page and rename it to Submit!

2019-07-05 Thread Harald Sitter

sitter created this revision.
sitter added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  it's very awkward when you don't know when a change happens or
  not, so suitably label the next button so it actually says submit when
  it will trigger the report submission.
  
  CHANGELOG: Buttons are more suitably labled when bug reports are submitted

TEST PLAN
  file bug report -> preview page has submit button -> going back it is not 
submit -> clicking submit it also turns back to next (albeit disabled)

REPOSITORY
  R871 DrKonqi

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D22289

AFFECTED FILES
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h

To: sitter, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22289: hijack nextbutton on preview page and rename it to Submit!

2019-07-05 Thread Harald Sitter

sitter added a comment.


  Looks comme ca:
  F6973746: Screenshot_20190705_125955.png 


REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22289

To: sitter, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22288: force a token refresh before submitting the report

2019-07-05 Thread Harald Sitter

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  when the user takes a very long time to prepare the bug report the original
  login session may have timed out and prevent submitting the bug report.
  as a super simple way to prevent this let's simply force a refresh.
  we need to do a query to check validity anyway, so we might as well
  force a refresh and get a new token right away.
  
  this temporarily chains the login interfaces to the report interfaces, upon
  successful login the report is sent. if any of the two throws an error
  the page goes into error state which offers a retry button to run
  aboutToShow again. therefore we also want to disconnect the signal chains
  to avoid multiple slot invocations on possible retries.
  
  BUG: 338216
  FIXED-IN: 5.17.0
  CHANGELOG: Login tokens get refreshed before submitting reports to prevent 
unauthorized errors

TEST PLAN
  - file bug without any interruption all goody
  - add `Bugzilla::connection().setToken(QString());` to simulate the token 
having gone invalid -> continues to work
  - disconnect network before submit causes a network unreachable login error 
-> connect again -> retry -> submission succeeds

REPOSITORY
  R871 DrKonqi

BRANCH
  refresh-token

REVISION DETAIL
  https://phabricator.kde.org/D22288

AFFECTED FILES
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportinterface.h

To: sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22285: [ActionTextField] Make action glow on press

2019-07-05 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, much better

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22285

To: broulik, #plasma, mart, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-05 Thread Mihai Sorin Dobrescu

msdobrescu updated this revision to Diff 61201.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22256?vs=61191=61201

REVISION DETAIL
  https://phabricator.kde.org/D22256

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/config/main.xml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 128 - Still Failing!

2019-07-05 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/128/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 10:22:33 +
 Build duration:
3 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 957 lines...][2019-07-05T10:26:27.627Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/package.h:95:32: note: declared here[2019-07-05T10:26:27.627Z]95 | PLASMA_DEPRECATED explicit Package(PackageStructure *structure = nullptr);[2019-07-05T10:26:27.627Z]   |^~~[2019-07-05T10:26:27.627Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:506:20: warning: ���Plasma::Package::Package(const Plasma::Package&)��� is deprecated [-Wdeprecated-declarations][2019-07-05T10:26:27.627Z]   506 | return Package();[2019-07-05T10:26:27.627Z]   |^[2019-07-05T10:26:27.627Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/build/src/plasma/plasma/package.h:1,[2019-07-05T10:26:27.627Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.h:23,[2019-07-05T10:26:27.627Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:20:[2019-07-05T10:26:27.627Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/package.h:107:23: note: declared here[2019-07-05T10:26:27.627Z]   107 | PLASMA_DEPRECATED Package(const Package );[2019-07-05T10:26:27.627Z]   |   ^~~[2019-07-05T10:26:27.627Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp: In member function ���KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString&, const QString&)���:[2019-07-05T10:26:27.627Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:551:157: warning: ���KPluginInfo::KPluginInfo(KService::Ptr)��� is deprecated [-Wdeprecated-declarations][2019-07-05T10:26:27.627Z]   551 | auto pi = md.metaDataFileName().endsWith(QLatin1String(".json")) ? KPluginInfo(md) : KPluginInfo(KService::serviceByStorageId(md.metaDataFileName()));[2019-07-05T10:26:27.627Z]   | ^[2019-07-05T10:26:27.627Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/package.h:25,[2019-07-05T10:26:27.627Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/build/src/plasma/plasma/package.h:1,[2019-07-05T10:26:27.627Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.h:23,[2019-07-05T10:26:27.627Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:20:[2019-07-05T10:26:27.627Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: declared here[2019-07-05T10:26:27.627Z]   115 | explicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service);[2019-07-05T10:26:27.627Z]   |  ^~~[2019-07-05T10:26:27.627Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp: In member function ���KPluginInfo::List Plasma::PluginLoader::listContainmentActionsInfo(const QString&)���:[2019-07-05T10:26:27.627Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:767:38: warning: ���KPluginInfo::KPluginInfo(KService::Ptr)��� is deprecated [-Wdeprecated-declarations][2019-07-05T10:26:27.627Z]   767 | list.append(KPluginInfo(s));[2019-07-05T10:26:27.627Z]   |  ^[2019-07-05T10:26:27.627Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/package.h:25,[2019-07-05T10:26:27.627Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/build/src/plasma/plasma/package.h:1,[2019-07-05T10:26:27.627Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.h:23,[2019-07-05T10:26:27.627Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:20:[2019-07-05T10:26:27.627Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: declared here[2019-07-05T10:26:27.627Z]   115 | explicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service);[2019-07-05T10:26:27.627Z]   |  ^~~[2019-07-05T10:26:27.627Z]

D21510: Filter KNewStuff Plasma Themes by Download Tag

2019-07-05 Thread Dan Leinir Turthra Jensen

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e93b567ecb7f: Filter KNewStuff Plasma Themes by Download 
Tag (authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21510?vs=61120=61196#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=61120=61196

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22285: [ActionTextField] Make action glow on press

2019-07-05 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This matches `QLineEdit` behavior

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22285

AFFECTED FILES
  src/controls/ActionTextField.qml

To: broulik, #plasma, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22284: Add missing libinput include

2019-07-05 Thread Bastian Köcher

bkchr created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bkchr requested review of this revision.

REVISION SUMMARY
  The libinput include path was missing for the x11 touchpad kcm.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22284

AFFECTED FILES
  kcms/touchpad/src/backends/x11.cmake

To: bkchr
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still unstable!

2019-07-05 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/28/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 05 Jul 2019 07:35:15 +
 Build duration:
2 min 29 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 26 - Still unstable!

2019-07-05 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/26/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 07:35:14 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2577)14%
(212/1499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/255)0%
(0/134)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/217)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

2019-07-05 Thread Hugo Pereira Da Costa

hpereiradacosta added a comment.


  Indeed. This is a problem. As soon as treeviews are animated Qt makes a 
pixmap copy of the treeview viewport. This does not include the blue line on 
the side, which is painted in the frame, below the (transparent) viewport. Will 
investigate further.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-05 Thread Mihai Sorin Dobrescu

msdobrescu updated this revision to Diff 61191.
msdobrescu edited the summary of this revision.
msdobrescu added a comment.


  Added Reversed, DirsFirst/DirsLast, IgnoreCase, LocaleAware options.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22256?vs=6=61191

REVISION DETAIL
  https://phabricator.kde.org/D22256

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/config/main.xml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22283: Change validator for Endpoint Address entry field

2019-07-05 Thread Bruce Anderson

andersonbruce created this revision.
andersonbruce added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
andersonbruce requested review of this revision.

REVISION SUMMARY
  BUG: 408670
  
  Change validator for FQDN entry in Endpoint Address entry 
  field to allow single character domain names rather than 
  limiting them to a minimum of two characters.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  FQDN_Fix

REVISION DETAIL
  https://phabricator.kde.org/D22283

AFFECTED FILES
  libs/editor/settings/wireguardpeerwidget.cpp

To: andersonbruce, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

41 matches

Mail list logo