D22344: Expose some more settings in an Advanced dialog

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good to me now.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: aspotashev, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf added a comment.


  In D22191#493949 , @ngraham wrote:
  
  > In D22191#493928 , @filipf wrote:
  >
  > > In general we do need an additional message box which says sync 
successful or failed. And then in the case of failure it should state what 
failed.
  > >
  > > But as far as I can tell the operations won't fail. They're all 
conditional on values being existent or not and if things aren't in order they 
won't get carried out.
  >
  >
  > Famous last words. :) You never know what situations users will get 
themselves into. Maybe they discover the feature while testing with a live CD 
where the root filesystem isn't writable, for example.
  
  
  If that's the case then the whole KCM needs to be disabled because any change 
made within it entails writing to root. This would be relevant to the function 
though when abstracted and used throughout KCMs. Another thing that crosses my 
mind in regards to failing is BSD (due to different generic paths), but I have 
no idea if they even use SDDM.
  
  Well whatever the case, I need to have a look at how to add all this 
fail/success info.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: leinir, cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 60 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/60/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 11 Jul 2019 02:48:45 +
 Build duration:
3 min 13 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-11T02:51:54.570Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-11T02:51:54.570Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-11T02:51:54.570Z] PROCESSOR_LEVEL   = '6'[2019-07-11T02:51:54.570Z] PROCESSOR_REVISION= '5e03'[2019-07-11T02:51:54.570Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-11T02:51:54.570Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-11T02:51:54.570Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-11T02:51:54.570Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-11T02:51:54.570Z] PROMPT= '$P$G'[2019-07-11T02:51:54.570Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-11T02:51:54.570Z] PUBLIC= 'C:\Users\Public'[2019-07-11T02:51:54.570Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/60/display/redirect?page=changes'[2019-07-11T02:51:54.570Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/60/display/redirect'[2019-07-11T02:51:54.570Z] STAGE_NAME= 'Configuring Build'[2019-07-11T02:51:54.570Z] SYSTEMDRIVE   = 'C:'[2019-07-11T02:51:54.570Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-11T02:51:54.570Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-11T02:51:54.570Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-11T02:51:54.570Z] UCRTVERSION   = '10.0.17763.0'[2019-07-11T02:51:54.570Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-11T02:51:54.570Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-11T02:51:54.570Z] USERNAME  = 'Jenkins'[2019-07-11T02:51:54.570Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-11T02:51:54.570Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-11T02:51:54.570Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-11T02:51:54.570Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-11T02:51:54.570Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-11T02:51:54.570Z] VCTOOLSVERSION= '14.16.27023'[2019-07-11T02:51:54.570Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-11T02:51:54.570Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-11T02:51:54.570Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-11T02:51:54.570Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-11T02:51:54.570Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-11T02:51:54.570Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-11T02:51:54.570Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-11T02:51:54.570Z] VSCMD_VER = '16.0.3'[2019-07-11T02:51:54.570Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-11T02:51:54.570Z] WINDIR= 'C:\WINDOWS'[2019-07-11T02:51:54.570Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-11T02:51:54.570Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-11T02:51:54.570Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-11T02:51:54.570Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-11T02:51:54.570Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-11T02:51:54.570Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-11T02:51:54.570Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-11T02:51:54.570Z] __DOTNET_ADD_64BIT= '1'[2019-07-11T02:51:54.570Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-11T02:51:54.571Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-11T02:51:54.571Z] 

D22390: ksmserver/autostart: remove qstandardpaths queries

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Remember the autostart path instead of looking it up over and over.
  
  Depends on D22387 

TEST PLAN
  Plasma starts normally for me

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22390

AFFECTED FILES
  startkde/plasma-session/autostart.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Nathaniel Graham]

ngraham added a subscriber: leinir.
ngraham added a comment.


  In D22191#493928 , @filipf wrote:
  
  > In general we do need an additional message box which says sync successful 
or failed. And then in the case of failure it should state what failed.
  >
  > But as far as I can tell the operations won't fail. They're all conditional 
on values being existent or not and if things aren't in order they won't get 
carried out.
  
  
  Famous last words. :) You never know what situations users will get 
themselves into. Maybe they discover the feature while testing with a live CD 
where the root filesystem isn't writable, for example.
  
  In D22191#493928 , @filipf wrote:
  
  > I agree with points 2 and 3 as well, but would ask if we could implement it 
all gradually as working with multiple branches is already getting a bit clumsy.
  
  
  Yeah, that makes sense.
  
  In D22191#493928 , @filipf wrote:
  
  > As for point 3, I've looked it additionally and it does complicate things 
but might be doable. The question is how to interact with the user. We could 
copy everything to a global directory and then remove it from the user 
directory (to avoid duplicates in kcms). What sucks is that users could no 
longer easily remove these theme files via kcms.
  
  
  Definitely something to ask @leinir about. The GHNS dialog would have to be 
involved in any event, either to (optionally or by default) install things 
globally, to know how to remove themes that are globally installed, and to 
de-duplicate themes that are installed both locally and globally.
  
  But yeah, material for another patch.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: leinir, cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21763: [kcms/ksmserver] Port to new kworkspace API

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4e2db5dc02a2: [kcms/ksmserver] Port to new kworkspace API 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21763?vs=59929=61555

REVISION DETAIL
  https://phabricator.kde.org/D21763

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6bab1f518c50: Split ksmserver into a small application 
that handles startup and ksmserver (authored by bruns, committed by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21995?vs=61150=61554#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21995?vs=61150=61554

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  libkworkspace/CMakeLists.txt
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/README
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Shutdown.xml
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp

To: davidedmundson, #plasma, apol
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D7820: man ioslave: spurious numbers included in clang(1) man page

[Luigi Toscano]

ltoscano added a comment.


  Apologize for the long delay - I can't reproduce the issue with the current 
master. The mentioned structure of the clang man page seems to be the same 
(clang 8).
  
  Adding @mkoller too.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh, 
fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, 
navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, himcesjf, 
emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, 
apol, mart

D9033: man ioslave: asserts trying to display pam(8)

[Luigi Toscano]

ltoscano added a comment.


  Apologize for the long delay. It looks like that the fix still applies and 
works according the comment.
  
  I added @mkoller, the historical maintainer of kio-man, who can probably 
validate the change better than me, but let's try to push this for the upcoming 
KDE Applications 19.04.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, apol, plasma-devel, fprice, LeGast00n, 
jraleigh, gennad, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, 
michaelh, spoorun, navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, 
skadinna, himcesjf, emmanuelp, lesliezhai, ali-mohamed, mikesomov, 
jensreuterberg, abetts, sebas, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf added a comment.


  In general we do need an additional message box which says sync successful or 
failed. And then in the case of failure it should state what failed.
  
  But as far as I can tell the operations won't fail. They're all conditional 
on values being existent or not and if things aren't in order they won't get 
carried out.
  
  I agree with points 2 and 3 as well, but would ask if we could implement it 
all gradually as working with multiple branches is already getting a bit clumsy.
  
  Implementation wise, point 2 is something Plasma elders would understand 
better atm.
  
  As for point 3, I've looked it additionally and it does complicate things but 
might be doable. The question is how to interact with the user. We could copy 
everything to a global directory and then remove it from the user directory (to 
avoid duplicates in kcms). What sucks is that users could no longer easily 
remove these theme files via kcms. So what if we the remove button worked with 
globally installed? Currently I'm not sure of the repercussions for stuff 
installed via package manager.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22381: Add previous-/nextActivity methods

[Ivan Čukić]

ivan added a comment.


  You are right, they are randomized.
  
  And, yes, that is what I meant on IRC - that redundancy due to keeping a 
sorted list will likely lead to future issues, but I see no other way if we 
want to be consistent regarding listing and switching.
  
  As it is required to have fast access by UUID, the hash needs to stay. So, 
I'd say we will need the redundancy. Maybe there is some multi-key sorted 
multi-map in boost - kamd already uses boost::flat_map, so this would be fine. 
:)

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D22381

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22381: Add previous-/nextActivity methods

[Christian Muehlhaeuser]

muesli added inline comments.

INLINE COMMENTS

> ivan wrote in Activities.cpp:218
> I don't like the fact that it constantly resorts the activities.
> 
> The second problem is that ListActivities returns a list in one order, and 
> this traverses activities in another order. If this will work by name, 
> probably the List functions should as well.

List probably returns a fairly randomized (per session) list, seeing how it's 
returning keys() from a QHash. Maybe I misunderstood you on IRC, I thought 
you'd rather not store a sorted list here. Instead of keeping a sorted cache 
though, maybe we should just keep the original list in a sorted order?

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D22381

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22385: [mobile/wifi] Port settings to Kirigami Formlayout

[Nathaniel Graham]

ngraham added a comment.


  Nice!
  
  Are the "Security" and "IP Settings" headers really necessary, I wonder? I 
bet the two sections would look just fine with some whitespace or a separator, 
and no header text.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22385

To: nicolasfella, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22368: Formatting cleanup in PCI module

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:196d4aaa9cf6: Formatting cleanup in PCI module (authored 
by konradr, committed by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22368?vs=61497=61533

REVISION DETAIL
  https://phabricator.kde.org/D22368

AFFECTED FILES
  Modules/pci/kpci.cpp
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22385: [mobile/wifi] Port settings to Kirigami Formlayout

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Simplifies the code and makes it more consistent with other settings

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  form

REVISION DETAIL
  https://phabricator.kde.org/D22385

AFFECTED FILES
  mobile/wifi/package/contents/ui/IPAddressSetting.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/WirelessSecuritySetting.qml

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18920: Fix PCI module

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kpci_private.h:48
>  
> +/* Following structurs MUST BE packed, otherwise variables will be mapped to
> +   wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are

structure or structures?

> kpci_private.h:49
> +/* Following structurs MUST BE packed, otherwise variables will be mapped to
> +   wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are
> +   more widely adopted, and should be ignored if not supported.

seems to

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18920

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22367: Update mail address in PCI module

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:96c18ee3cf63: Update Konrads mail address in PCI 
module (authored by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22367?vs=61496=61531

REVISION DETAIL
  https://phabricator.kde.org/D22367

AFFECTED FILES
  Modules/pci/kpci.cpp
  Modules/pci/kpci.h
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22381: Add previous-/nextActivity methods

[Ivan Čukić]

ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> Activities.cpp:218
> +auto a = q->ListActivitiesWithInformation();
> +std::sort(a.begin(), a.end(), );
> +

I don't like the fact that it constantly resorts the activities.

The second problem is that ListActivities returns a list in one order, and this 
traverses activities in another order. If this will work by name, probably the 
List functions should as well.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D22381

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22382: Add global shortcuts for switching to the previous/next activity

[Christian Muehlhaeuser]

muesli created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
muesli requested review of this revision.

REVISION SUMMARY
  We currently have a mouse-wheel action to switch to the previous/next desktop,
  but it wasn't possible to assign a global keyboard shortcut to these actions.
  
  I've assigned Ctrl-Meta-Left and Ctrl-Meta-Right respectively as the default
  shortcuts to these actions, as they seem to fit and are currently unused.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shortcut-prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22382

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22344: Expose some more settings in an Advanced dialog

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61520.
apol added a comment.


  add loadConfig bits

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22344?vs=61510=61520

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22344

AFFECTED FILES
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv4widget.h
  libs/editor/settings/ui/ipv4.ui

To: apol, #plasma, jgrulich
Cc: aspotashev, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 59 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/59/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 10 Jul 2019 15:15:41 +
 Build duration:
2 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-10T15:18:18.964Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-10T15:18:18.964Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-10T15:18:18.964Z] PROCESSOR_LEVEL   = '6'[2019-07-10T15:18:18.964Z] PROCESSOR_REVISION= '5e03'[2019-07-10T15:18:18.964Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-10T15:18:18.964Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-10T15:18:18.964Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-10T15:18:18.964Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-10T15:18:18.964Z] PROMPT= '$P$G'[2019-07-10T15:18:18.964Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-10T15:18:18.964Z] PUBLIC= 'C:\Users\Public'[2019-07-10T15:18:18.964Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/59/display/redirect?page=changes'[2019-07-10T15:18:18.964Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/59/display/redirect'[2019-07-10T15:18:18.964Z] STAGE_NAME= 'Configuring Build'[2019-07-10T15:18:18.964Z] SYSTEMDRIVE   = 'C:'[2019-07-10T15:18:18.964Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-10T15:18:18.965Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-10T15:18:18.965Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-10T15:18:18.965Z] UCRTVERSION   = '10.0.17763.0'[2019-07-10T15:18:18.965Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-10T15:18:18.965Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-10T15:18:18.965Z] USERNAME  = 'Jenkins'[2019-07-10T15:18:18.965Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-10T15:18:18.965Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-10T15:18:18.965Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-10T15:18:18.965Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-10T15:18:18.965Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-10T15:18:18.965Z] VCTOOLSVERSION= '14.16.27023'[2019-07-10T15:18:18.965Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-10T15:18:18.965Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-10T15:18:18.965Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-10T15:18:18.965Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-10T15:18:18.965Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-10T15:18:18.965Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-10T15:18:18.965Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-10T15:18:18.965Z] VSCMD_VER = '16.0.3'[2019-07-10T15:18:18.965Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-10T15:18:18.965Z] WINDIR= 'C:\WINDOWS'[2019-07-10T15:18:18.965Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-10T15:18:18.965Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-10T15:18:18.965Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-10T15:18:18.965Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-10T15:18:18.965Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-10T15:18:18.965Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-10T15:18:18.965Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-10T15:18:18.965Z] __DOTNET_ADD_64BIT= '1'[2019-07-10T15:18:18.965Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-10T15:18:18.965Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-10T15:18:18.965Z] 

D22326: fix API availability/version detection to not be terribly racey

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:e6a81b2d466b: fix API availability/version detection to 
not be terribly racey (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22326?vs=61514=61519#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22326?vs=61514=61519

REVISION DETAIL
  https://phabricator.kde.org/D22326

AFFECTED FILES
  src/CMakeLists.txt
  src/bugzillaintegration/assistantpage_bugzilla_version.cpp
  src/bugzillaintegration/assistantpage_bugzilla_version.h
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/ui/assistantpage_bugzilla_version.ui
  src/drkonqi_globals.h

To: sitter, #plasma, apol
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 61518.
tcanabrava added a comment.


  - Add pid information to the log files
  - Store only the last 10 files in the cache directory

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22322?vs=61371=61518

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

AFFECTED FILES
  src/drkonqi.cpp
  src/drkonqi.h
  src/main.cpp

To: tcanabrava, sitter, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22344: Expose some more settings in an Advanced dialog

[Jan Grulich]

jgrulich added a comment.


  You still need to add following lines to the loadConfig() method, otherwise 
those properties won't be filled when editing an existing connection:
  
m_tmpIpv4Setting.setDhcpHostname(ipv4Setting->dhcpHostname());
m_tmpIpv4Setting.setDhcpSendHostname(ipv4Setting->dhcpSendHostname());
m_tmpIpv4Setting.setDadTimeout(ipv4Setting->dadTimeout());

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: aspotashev, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22381: Add previous-/nextActivity methods

[Christian Muehlhaeuser]

muesli created this revision.
muesli added a reviewer: ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
muesli requested review of this revision.

REVISION SUMMARY
  These two methods can be used to switch to the previous/next activity in
  alphabetical order. They are exposed via the DBus interface. This
  functionality can also be accessed by kactivities(-cli) and plasmashell, which
  currently both implement their own separate versions of it.
  
  @Ivan mentioned being a bit wary of keeping a sorted activity list in
  kactivitymanagerd, so I've opted to only retrieve and sort the list on demand
  here.

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22381

AFFECTED FILES
  src/common/dbus/org.kde.ActivityManager.Activities.xml
  src/service/Activities.cpp
  src/service/Activities.h
  src/service/Activities_p.h

To: muesli, ivan
Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22326: fix API availability/version detection to not be terribly racey

[Harald Sitter]

sitter updated this revision to Diff 61514.
sitter added a comment.


  build fix

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22326?vs=61513=61514

BRANCH
  versioncheck

REVISION DETAIL
  https://phabricator.kde.org/D22326

AFFECTED FILES
  src/CMakeLists.txt
  src/bugzillaintegration/assistantpage_bugzilla_version.cpp
  src/bugzillaintegration/assistantpage_bugzilla_version.h
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/ui/assistantpage_bugzilla_version.ui
  src/drkonqi_globals.h

To: sitter, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22326: fix API availability/version detection to not be terribly racey

[Harald Sitter]

sitter updated this revision to Diff 61513.
sitter added a comment.


  use qprogressbar until a proper busyindicator becomes available

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22326?vs=61343=61513

BRANCH
  versioncheck

REVISION DETAIL
  https://phabricator.kde.org/D22326

AFFECTED FILES
  src/CMakeLists.txt
  src/bugzillaintegration/assistantpage_bugzilla_version.cpp
  src/bugzillaintegration/assistantpage_bugzilla_version.h
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/ui/assistantpage_bugzilla_version.ui
  src/drkonqi_globals.h

To: sitter, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Nathaniel Graham]

ngraham added a comment.


  Overall this is very nice! I have some inline comments, and two macro design 
comments:
  
  1. You need to handle failure conditions for the remove, mkpath, copy, chown 
etc. operations. Thede functions all return false if they fail, so you can find 
out easily enough. There's nothing worse than an unhandled error, because then 
the operation will just fail silently, leaving the user confused. Even showing 
an ugly error dialog box would probably be better than nothing, though a 
KMessageWidget would be much nicer.
  
  2. This should be considered a framework for optionally having the sync 
operation done automatically when selecting a new theme/icon set/font/etc. The 
feature is nice, but not very discoverable, and the better UX is to have new 
settings synced to SDDM automatically for the case where there's only one admin 
user account on the box.
  
  3. We need to come up with a way for user-installed content from GHNS etc. to 
get synced. If detecting when it's installed in a non-system location is 
unfeasible, we should consider installing new content to a system location 
rather than in the user's homedir, either optionally of even by default.

INLINE COMMENTS

> sddmauthhelper.cpp:57
> +if (QFile::exists(destination)) {
> +QFile::remove(destination);
> +}

Don't ignore the error if the removal fails

> sddmauthhelper.cpp:60
> +
> +QFile::copy(source, destination);
> +const char* destinationConverted = destination.toLocal8Bit().data();

Don't ignore the error if the copy fails

> sddmauthhelper.cpp:62
> +const char* destinationConverted = destination.toLocal8Bit().data();
> +if (chown(destinationConverted, sddmUser.userId().nativeId(), 
> sddmUser.groupId().nativeId())) {
> +return;

Don't ignore the error if the chown fails

> sddmauthhelper.cpp:71
> +if (!sddmConfigLocation.exists()) {
> +QDir().mkpath(sddmConfigLocation.path());
> +}

Ditto for this and other `mkpath()` calls. Errors should be handled, even with 
something as simple as a dialog box saying, "Could not create !"

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay

[Harald Sitter]

sitter added a comment.


  Fair point but I don't want to throttle my music stream, I want to throttle 
the drkonqi api requests ;)
  Also, an IO throttle isn't always useful. e.g. for the stuff in D22326 
 I want control exactly how long the reply 
should take so I reach the page in question when the reply hasn't yet returned, 
but then returns "soon enough".

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22376

To: sitter
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22344: Expose some more settings in an Advanced dialog

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61510.
apol added a comment.


  addressed comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22344?vs=61474=61510

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22344

AFFECTED FILES
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv4widget.h
  libs/editor/settings/ui/ipv4.ui

To: apol, #plasma, jgrulich
Cc: aspotashev, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay

[Kai Uwe Broulik]

broulik added a comment.


  Why not just use `tc` to throttle the network connection?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22376

To: sitter
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this is super duper handy when trying to test slow network connections
  as it makes every single api job take a minimum amount of time

TEST PLAN
  things are slow when set to 1

REPOSITORY
  R871 DrKonqi

BRANCH
  delay

REVISION DETAIL
  https://phabricator.kde.org/D22376

AFFECTED FILES
  src/bugzillaintegration/libbugzilla/apijob.cpp

To: sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Re: Technical Advise for PlasmaQuick::ContainmentView [Latte]

[Michail Vourlakos]

Marco I played with this but I didnt have any success,

1. I added a reload() function in AppletQuickItem :

void AppletQuickItemPrivate::reload()
{
auto oldQmlObject = qmlObject;
s_rootObjects.remove(oldQmlObject->rootContext());
init();
oldQmlObject->deleteLater();
}

void AppletQuickItem::reload()
{
d->reload();
init();
}

2. In Latte::View this is called with:
void View::reloadSource()
{
 engine()->clearComponentCache();
 PlasmaQuick::AppletQuickItem *cai =
containment()->property("_plasma_graphicObject").value();
if (cai) {
qDebug() << " CONTAINMENT GRAPHIC OBJECT RELOADING!!!";
cai->reload();
}
}

3. But [1]-[2] just empties the Latte::View with no visual results and
plenty of warnings from qml :

[warning 14:47:30.88] -
file:///home/master/kde/usr/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:469:
ReferenceError: plasmoid is not defined
[warning 14:47:30.88] -
file:///home/master/kde/usr/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:454:
ReferenceError: plasmoid is not defined
[warning 14:47:30.88] -
file:///home/master/kde/usr/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:453:
ReferenceError: plasmoid is not defined
[warning 14:47:30.88] -
file:///home/master/kde/usr/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:451:
ReferenceError: plasmoid is not defined
[warning 14:47:30.88] -
file:///home/master/kde/usr/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:450:
ReferenceError: plasmoid is not defined
[warning 14:47:30.88] -
file:///home/master/kde/usr/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:449:
ReferenceError: plasmoid is not defined
[warning 14:47:30.88] -
file:///home/master/kde/usr/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:448:
ReferenceError: plasmoid is not defined


regards,
michail



Στις Δευ, 1 Ιουλ 2019 στις 1:47 μ.μ., ο/η Marco Martin 
έγραψε:

> On Mon, Jul 1, 2019 at 12:20 PM Michail Vourlakos 
> wrote:
> >
> > Thank for the response Martin,
> > I ended up recreating the View and does the trick but that has some
> downsides from accessibility and user point of view...
> >
> > > in order to do that i guess some new api is needed in AppletQuickItem
> in libplasmaquick, a reload() method
> > > Would you be interested looking into that?
> >
> > yes of course, but after my vacations in mid July, in case I manage to
> add the reload() method for AppletQuickItem
> > I will send the patch in phabricator and assign you as reviewer to
> discuss it :)
>
> cool, awesome :)
>

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/29/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 10 Jul 2019 10:37:33 +
 Build duration:
4 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4012)0%
(0/2728)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1419)0%
(0/1104)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/806)0%
(0/470)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/221)0%
(0/114)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1019)0%
(0/759)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 29 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/29/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 10 Jul 2019 10:37:31 +
 Build duration:
4 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2579)14%
(212/1501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/255)0%
(0/134)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/219)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/3/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 10 Jul 2019 10:37:32 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D22369: Update and add some device names in PCI module

[Konrad Rzepecki]

konradr created this revision.
konradr added reviewers: Plasma, cfeck.
konradr added a project: Plasma.
Herald added a subscriber: plasma-devel.
konradr requested review of this revision.

REVISION SUMMARY
  Update and add some device names in PCI module

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22369

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22368: Formatting cleanup in PCI module

[Konrad Rzepecki]

konradr created this revision.
konradr added reviewers: Plasma, cfeck.
konradr added a project: Plasma.
Herald added a subscriber: plasma-devel.
konradr requested review of this revision.

REVISION SUMMARY
  Formatting cleanup in PCI module

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22368

AFFECTED FILES
  Modules/pci/kpci.cpp
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22367: Update mail address in PCI module

[Konrad Rzepecki]

konradr created this revision.
konradr added reviewers: Plasma, cfeck.
konradr added a project: Plasma.
Herald added a subscriber: plasma-devel.
konradr requested review of this revision.

REVISION SUMMARY
  Update my mail address in PCI module

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22367

AFFECTED FILES
  Modules/pci/kpci.cpp
  Modules/pci/kpci.h
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18920: Fix PCI module

[Konrad Rzepecki]

konradr updated this revision to Diff 61495.
konradr retitled this revision from "Fix and update PCI module" to "Fix PCI 
module".
konradr edited the summary of this revision.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18920?vs=51397=61495

REVISION DETAIL
  https://phabricator.kde.org/D18920

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22344: Expose some more settings in an Advanced dialog

[Alexander Potashev]

aspotashev added a comment.


  I think this UI is missing hints/tips about meaning of these options. 
Otherwise it would be unclear:
  
  - What is the meaning of dad-timeout = -1
  - What is the meaning of dad-timeout = 0
  - What happens if dhcp-send-hostname is true, but dhcp-hostname is empty
  - What happens if dhcp-send-hostname is false, but dhcp-hostname is not empty 
(if it would be ignored, consider disabling the line edit)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: aspotashev, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c3c030d8b595: Fix creation of kdeglobals if 
/etc/xdg/kdeglobals present (authored by fvogt).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22238?vs=61069=61493

REVISION DETAIL
  https://phabricator.kde.org/D22238

AFFECTED FILES
  decorations/decorationpalette.cpp

To: fvogt, #plasma, romangg
Cc: sitter, broulik, rikmills, kwin, plasma-devel, LeGast00n, sbergeron, 
jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, 
crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D22341: [mobile/wifi] Port to SimpleKCM

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:b1e218b92a3b: [mobile/wifi] Port to SimpleKCM (authored 
by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22341?vs=61410=61483

REVISION DETAIL
  https://phabricator.kde.org/D22341

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/NetworkListView.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, #plasma, mart, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart