D22627: Add a GUI option for choosing the input method

[Filip Fila]

filipf added a comment.


  In D22627#499699 , @ngraham wrote:
  
  > Why is there a blank entry?
  
  
  The blank entry is sort of the whole point of the option. The way to fix the 
virtual keyboard popping up on its own with some themes is to leave InputMethod 
empty:
  
  https://github.com/MarianArlt/sddm-sugar-light/issues/2#issuecomment-439741458
  https://www.reddit.com/r/kde/comments/7lk2bs/onscreen_keyboard_on_sddm/
  
  > Also these hardcoded values make me feel a little leery. Is there a way we 
can programmatically generate them or get them from SDDM or something?
  
  Not that I know of. The only time they're mentioned in the SDDM codebase is 
in this documentation file: 
https://github.com/sddm/sddm/blob/develop/data/man/sddm.conf.rst.in

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22627

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19440: Exclude non-managed devices from plasma-nm

[Jan Grulich]

jgrulich added a comment.


  It looks that the patch needs to be rebased.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19440

To: afiestas, #plasma, jgrulich
Cc: aacid, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19440: Exclude non-managed devices from plasma-nm

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:a6bce5fccc14: Exclude non-managed devices from plasma-nm 
(authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19440?vs=52885=62261

REVISION DETAIL
  https://phabricator.kde.org/D19440

AFFECTED FILES
  libs/models/networkmodel.cpp

To: afiestas, #plasma, jgrulich
Cc: aacid, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19440: Exclude non-managed devices from plasma-nm

[Jan Grulich]

jgrulich added a comment.


  In D19440#499168 , @aacid wrote:
  
  > @jgrulich should we land this?
  
  
  Yes.
  
  > Alex is unsure you're convinced it's good
  
  I wasn't sure if this patch is needed, but it makes sense.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19440

To: afiestas, #plasma, jgrulich
Cc: aacid, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Christoph Feck]

cfeck added a comment.


  Do we need a matching commit in KWidgetsAddons? See 
https://commits.kde.org/kwidgetsaddons/2631be903f947872f67c9e2063950345dda9033e

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: cfeck, filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22589: Embrace X-KDE-Wayland-Interfaces

[Michail Vourlakos]

mvourlakos added a comment.


  In D22589#499203 , @davidedmundson 
wrote:
  
  > > Thanks I will add it!
  >
  > And make sure your exec line is an absolute path
  
  
  OH!!! I would had missed that one

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22589

To: apol, #plasma, #kwin, davidedmundson
Cc: davidedmundson, zzag, mvourlakos, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22632: Implement support for the "next" and "previous" actions in SoundCloud

[Radoslav Georgiev]

rgeorgiev updated this revision to Diff 62251.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22632?vs=62244=62251

REVISION DETAIL
  https://phabricator.kde.org/D22632

AFFECTED FILES
  extension/content-script.js

To: rgeorgiev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

[Radoslav Georgiev]

rgeorgiev updated this revision to Diff 62249.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22631?vs=62241=62249

REVISION DETAIL
  https://phabricator.kde.org/D22631

AFFECTED FILES
  extension/content-script.js

To: rgeorgiev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22627: Add a GUI option for choosing the input method

[Nathaniel Graham]

ngraham added a comment.


  Why is there a blank entry? Also these hardcoded values make me feel a little 
leery. Is there a way we can programmatically generate them or get them from 
SDDM or something?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22627

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21950: [Night Color KCM] Add "Constant" mode

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f254f9be8457: [Night Color KCM] Add Constant 
mode (authored by zzag).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21950?vs=60189=62246#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21950?vs=60189=62246

REVISION DETAIL
  https://phabricator.kde.org/D21950

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: zzag, #plasma, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21949: [libcolorcorrect] Add "Constant" mode

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a6b1c0e543cc: [libcolorcorrect] Add Constant 
mode (authored by zzag).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21949?vs=60188=62245

REVISION DETAIL
  https://phabricator.kde.org/D21949

AFFECTED FILES
  libcolorcorrect/compositorcoloradaptor.cpp
  libcolorcorrect/compositorcoloradaptor.h

To: zzag, #plasma, #kwin, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22632: Implement support for the "next" and "previous" actions in SoundCloud

[Radoslav Georgiev]

rgeorgiev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rgeorgiev requested review of this revision.

REVISION SUMMARY
  Implement support for the "next" and "previous" actions in SoundCloud.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22632

AFFECTED FILES
  extension/content-script.js

To: rgeorgiev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22363: Remove cursor theme option

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:34fc153b2593: Remove cursor theme option (authored by 
filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22363?vs=62174=62242

REVISION DETAIL
  https://phabricator.kde.org/D22363

AFFECTED FILES
  sddmauthhelper.cpp
  src/CMakeLists.txt
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/cursortheme/cursortheme.cpp
  src/cursortheme/cursortheme.h
  src/cursortheme/dummytheme.cpp
  src/cursortheme/dummytheme.h
  src/cursortheme/sortproxymodel.cpp
  src/cursortheme/sortproxymodel.h
  src/cursortheme/thememodel.cpp
  src/cursortheme/thememodel.h
  src/cursortheme/xcursortheme.cpp
  src/cursortheme/xcursortheme.h
  src/ui/advanceconfig.ui

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

[Radoslav Georgiev]

rgeorgiev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rgeorgiev requested review of this revision.

REVISION SUMMARY
  Perform registering of dynamically-added players in all cases when media 
controls are enabled, thereby making basic SoundCloud support work.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22631

AFFECTED FILES
  extension/content-script.js

To: rgeorgiev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:217fc7530b75: Slow down the busy indicators 
rotation speed (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22630?vs=62239=62240#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22630?vs=62239=62240

REVISION DETAIL
  https://phabricator.kde.org/D22630

AFFECTED FILES
  org.kde.desktop/BusyIndicator.qml

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

ngraham added a comment.


  *sigh*
  
  Nothing's ever easy with you, is it, arc?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

ngraham updated this revision to Diff 62239.
ngraham added a comment.


  Rebase

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22630?vs=62236=62239

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

AFFECTED FILES
  org.kde.desktop/BusyIndicator.qml
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/private/MobileTextActionsToolBar.qml
  tests/LineEditWithClearButton.qml

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Jup, looks less iritating.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22363: Remove cursor theme option

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  So much removed code.    Shipit!

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  remove-cursor-theme-option (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22363

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  In D22494#499592 , @ngraham wrote:
  
  > In D22494#499587 , @filipf wrote:
  >
  > > Could we only have Unsplash as the provider and the an additional 
combobox that would allow choosing the category?
  >
  >
  > +1, this should be a single Unsplash plugin whose user-facing UI has a 
combobox allowing you to specify the collection.
  
  
  I also feel this is better. We can even provide preview thumbnails before 
users choose a wallpaper collection. The only disadvantage is that I have to 
write a new wallpaper plugin and its UI.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  The FPS before was a little bit gamer-esque.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The busy indicator spins really fast and it's kind of disorienting. Let's 
slow it down.

TEST PLAN
  Before: F7070385: Before.webm 
  After: F7070386: After.webm 
  
  Please excuse the slight choppiness of the video; it's not like that in real 
life.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

AFFECTED FILES
  org.kde.desktop/BusyIndicator.qml

To: ngraham, #vdg
Cc: plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22627: Add a GUI option for choosing the input method

[Filip Fila]

filipf updated this revision to Diff 62233.
filipf added a comment.


  combobox strings shouldn't be translatable

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22627?vs=62226=62233

BRANCH
  add-input-method-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22627

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  In D22494#499587 , @filipf wrote:
  
  > Could we only have Unsplash as the provider and the an additional combobox 
that would allow choosing the category?
  
  
  +1, this should be a single Unsplash plugin whose user-facing UI has a 
combobox allowing you to specify the collection.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Filip Fila]

filipf added a comment.


  Could we only have Unsplash as the provider and the an additional combobox 
that would allow choosing the category?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

[Jan Przybylak]

https://bugs.kde.org/show_bug.cgi?id=377357

--- Comment #6 from Jan Przybylak  ---
Yes, the purpose is saving energy. I always just assumed it was using a lot of
power, but now that you mention it, I'm not so sure anymore.
I will report back when I find concrete data.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D22627: Add a GUI option for choosing the input method

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This exposes an existing SDDM InputMethod option and can function as a 
workaround for: https://github.com/sddm/sddm/issues/952

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  add-input-method-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22627

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22616: Remove phonon KCM

[Pino Toscano]

pino added a comment.


  In D22616#499453 , @nicolasfella 
wrote:
  
  > > @sitter said he has a version of the settings to be integtated into 
phonon so the remaining three users can still access them
  >
  > this
  
  
  ... doesn't say anything. Before removing stuff that works, it is a good idea 
to wait for the "potential replacement" to be implemented, tested, and 
confirmed usable as such.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22616

To: nicolasfella, sitter
Cc: pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22623: Bind SQL parameters in firefox bookmarksrunner support

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  Previously (accidental) SQL injection was easily possible.

TEST PLAN
  Could still list bookmarks.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D22623

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: fvogt, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22616: Remove phonon KCM

[Nicolas Fella]

nicolasfella added a comment.


  > @sitter said he has a version of the settings to be integtated into phonon 
so the remaining three users can still access them
  
  this

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22616

To: nicolasfella, sitter
Cc: pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5a79ff3db16f: Remove duplicate occurence of Qt5::DBus in 
CMakeLists.txt (authored by shubham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22619?vs=62213=62214

REVISION DETAIL
  https://phabricator.kde.org/D22619

AFFECTED FILES
  applets/pager/CMakeLists.txt

To: shubham, davidedmundson, broulik, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22588: [Pager] Don't link kdelibs4support

[Shubham]

shubham added a comment.


  I have put up a patch to remove duplicate occurrence of DBus here.
  https://phabricator.kde.org/D22619

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22588

To: broulik, #plasma, hein, davidedmundson
Cc: pino, shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt

[Shubham]

shubham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22619

AFFECTED FILES
  applets/pager/CMakeLists.txt

To: shubham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19865: Linux softraid: Define _GNU_SOURCE for pipe2

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D19865

To: awilcox, #plasma, davidedmundson, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D17552: Fix 2 typos

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17552

To: lepagevalleeemmanuel, ngraham, bshah
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D4775: Suggestion - newline ending after password to output

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D4775

To: martinkostolny, cfeck, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22616: Remove phonon KCM

[Pino Toscano]

pino added a comment.


  Erm, so what if you do **not** use plasma-pa?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22616

To: nicolasfella, sitter
Cc: pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22616: Remove phonon KCM

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Most of the Phonon KCM settings have been moved to plasma-pa. The remaining 
settings server very specific use cases that are mostl likely not worth 
exposing them front and center.
  
  @sitter said he has a version of the settings to be integtated into phonon so 
the remaining three users can still access them

TEST PLAN
  builds

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nukephonon

REVISION DETAIL
  https://phabricator.kde.org/D22616

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/phonon/CMakeLists.txt
  kcms/phonon/Messages.sh
  kcms/phonon/backendselection.cpp
  kcms/phonon/backendselection.h
  kcms/phonon/backendselection.ui
  kcms/phonon/devicepreference.cpp
  kcms/phonon/devicepreference.h
  kcms/phonon/devicepreference.ui
  kcms/phonon/kcm_phonon.desktop
  kcms/phonon/listview-background.png
  kcms/phonon/main.cpp
  kcms/phonon/main.h

To: nicolasfella, sitter
Cc: plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22613: kstart: Prevent crash when running without args

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> kstart.cpp:355
>} else {
> -  if ( parser.positionalArguments().count() == 0 )
> +  if ( parser.positionalArguments().count() == 0 ) {
>qCritical() << i18n("No command specified");

if ( parser.positionalArguments().isEmpty() ) {

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22613

To: tasossahanidis, davidedmundson
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22612: Fix assert when pressing enter really quickly

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R112:21a7ef11ba70: Fix assert when pressing enter really 
quickly (authored by davidedmundson).

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22612?vs=62194=62195

REVISION DETAIL
  https://phabricator.kde.org/D22612

AFFECTED FILES
  lib/qml/ResultsView.qml

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22613: kstart: Prevent crash when running without args

[Tasos Sahanidis]

tasossahanidis created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tasossahanidis requested review of this revision.

REVISION SUMMARY
  Despite an error being thrown, kstart would continue, trying to
  access an item that didn't exist in parser's arguments QList.
  
  Display the help message and exit instead.
  
  Signed-off-by: Tasos Sahanidis 

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22613

AFFECTED FILES
  kstart/kstart.cpp

To: tasossahanidis
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22612: Fix assert when pressing enter really quickly

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  runCurrentIndex checks if "currentItem" is valid.
  currentItem relies on the ListView being up-to-date.
  
  The ListView also updates in response to QAIM::modelReset, the same
  connection this code is attached to, so run afterwards.
  
  This means the guard for currentItem is potentially out of date, and we
  will call SourcesModel::run without a valid index on an empty source
  model. This hits an assert.
  
  modelReset and countChanged are identical as update resets
  the model (which is wrong but a task for another day)

TEST PLAN
  Could reproduce the crash by typing ":q " really quickly
  Could no longer reproduce

REPOSITORY
  R112 Milou

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22612

AFFECTED FILES
  lib/qml/ResultsView.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21950: [Night Color KCM] Add "Constant" mode

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:151
> +i18n("Times"),
> +i18n("Always on")
> +]

Maybe "Manual"

rather than "always on" as it's intended for use with the keyboard toggle

REPOSITORY
  R119 Plasma Desktop

BRANCH
  native-redshift

REVISION DETAIL
  https://phabricator.kde.org/D21950

To: zzag, #plasma, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22589: Embrace X-KDE-Wayland-Interfaces

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Thanks I will add it!
  
  And make sure your exec line is an absolute path

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22589

To: apol, #plasma, #kwin, davidedmundson
Cc: davidedmundson, zzag, mvourlakos, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19440: Exclude non-managed devices from plasma-nm

[Albert Astals Cid]

aacid added a comment.


  @jgrulich should we land this?
  
  Alex is unsure you're convinced it's good

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19440

To: afiestas, #plasma, jgrulich
Cc: aacid, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22589: Embrace X-KDE-Wayland-Interfaces

[Michail Vourlakos]

mvourlakos added a comment.


  In D22589#499012 , @zzag wrote:
  
  > @mvourlakos Perhaps Latte-Dock will need to set X-KDE-Wayland-Interfaces 
too (I assume that Latte-Dock uses libtaskmanager).
  
  
  Thanks I will add it!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22589

To: apol, #plasma, #kwin
Cc: zzag, mvourlakos, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22493: [Notifications] Move history items' icons over to the left a bit

[Alex Debus]

alexde added a comment.


  In D22493#496764 , @ngraham wrote:
  
  > Yeah, this patch touches only the history items, not the popups. I can do 
that too, if you'd like.
  
  
  Are you sure? When I applied this patch (+ units.iconSizes.medium) it looked 
like that:
  F7067500: Screenshot_20190721_131131.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22493

To: ngraham, broulik, #vdg, #plasma
Cc: alexde, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:d637f92040c3: Add hack to unbreak audio playback through 
pure JS via new Audio() (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20830?vs=56994=62183

REVISION DETAIL
  https://phabricator.kde.org/D20830

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21112: Support message response and reply callbacks

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:59fa1853817b: Support message response and reply 
callbacks (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21112?vs=62129=62182

REVISION DETAIL
  https://phabricator.kde.org/D21112

AFFECTED FILES
  extension/content-script.js
  extension/content-utils.js
  extension/extension.js
  extension/manifest.json
  extension/options.html
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21112: Support message response and reply callbacks

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  In D21112#498669 , @fvogt wrote:
  
  > Code looks good and seems to work fine in vivaldi, but I get an error in 
firefox:
  >
  >   Promise resolved after context unloaded
  >   extension.js:78
  >   sendSettings 
moz-extension://d1f34b4e-4e97-40a5-b4ac-03dc2fea30a9/extension.js:78
  >
  >
  > appears to be harmless though?
  
  
  Couldn't reproduce again, so likely fine.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21112

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  > For pictures (like people's faces in messenger notifications) I would still 
prefer the lager icons, though.
  
  I have to admit, that I'm not very much satisfied myself with the size. It 
could be a bit larger, something between medium and large. Maby we should 
discard it again. :P

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: broulik, pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Kai Uwe Broulik]

broulik added a comment.


  For pictures (like people's faces in messenger notifications) I would still 
prefer the lager icons, though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: broulik, pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  > You must run cmake for the whole repository; once done that, you can cd to 
the applets/notifications/ subdirectory of the builddir, and build only that 
part.
  
  What I also needed to install is
  
kdesignerplugin
  
  then
  
  So the procedure is as follows:
  
  1. cd plasma-workspace (root folder)
  2. cmake -DCMAKE_INSTALL_PREFIX=/usr .
  3. cd applets/notifcation
  4. make -j6
  5. sudo make install
  6. Log out & log in
  
  Is there a simly way to not override my working plasma desktop files?
  
  I am now going to attach the screenshot above.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22607: Fix compile warnings

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:8a254b2ec2e0: Fix compile warnings (authored by fvogt).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22607?vs=62176=62178

REVISION DETAIL
  https://phabricator.kde.org/D22607

AFFECTED FILES
  host/connection.cpp

To: fvogt, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22607: Fix compile warnings

[Fabian Vogt]

fvogt updated this revision to Diff 62176.
fvogt added a comment.


  Do it differently.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22607?vs=62175=62176

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22607

AFFECTED FILES
  host/connection.cpp

To: fvogt, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22607: Fix compile warnings

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  Fix warnings printed during build.

TEST PLAN
  Built it, no warnings anymore.

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22607

AFFECTED FILES
  host/connection.cpp

To: fvogt, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22363: Remove cursor theme option

[Filip Fila]

filipf updated this revision to Diff 62174.
filipf added a comment.


  address review comments

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22363?vs=62101=62174

BRANCH
  remove-cursor-theme-option (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22363

AFFECTED FILES
  sddmauthhelper.cpp
  src/CMakeLists.txt
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/cursortheme/cursortheme.cpp
  src/cursortheme/cursortheme.h
  src/cursortheme/dummytheme.cpp
  src/cursortheme/dummytheme.h
  src/cursortheme/sortproxymodel.cpp
  src/cursortheme/sortproxymodel.h
  src/cursortheme/thememodel.cpp
  src/cursortheme/thememodel.h
  src/cursortheme/xcursortheme.cpp
  src/cursortheme/xcursortheme.h
  src/ui/advanceconfig.ui

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22605: Set notifications entry icon size to medium

[Pino Toscano]

pino added a comment.


  In D22605#499051 , @alexde wrote:
  
  > I would like to test it and post a screenshot, however I am not able to 
compile it:
  >
  > 1. I cloned the source from the git repository
  > 2. mkdir plasma-workspace/applets/notifications/build
  > 3. cd plasma-workspace/applets/notifications/build
  > 4. cmake ..
  >
  >   This resulted in ``` CMake Error at CMakeLists.txt:11 
(kcoreaddons_desktop_to_json): Unknown CMake command 
"kcoreaddons_desktop_to_json". ```
  
  
  You must run cmake for the whole repository; once done that, you can cd to 
the applets/notifications/ subdirectory of the builddir, and build only that 
part.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  I would like to test it and post a screenshot, however I am not able to 
compile it:
  
  1. I cloned the source from the git repository
  2. mkdir plasma-workspace/applets/notifications/build
  3. cd plasma-workspace/applets/notifications/build
  4. cmake ..
  
  This resulted in
  
CMake Error at CMakeLists.txt:11 (kcoreaddons_desktop_to_json):
  Unknown CMake command "kcoreaddons_desktop_to_json".
  
  
  
  5. I then added
  
find_package(KF5Plasma REQUIRED)
  
  to the CMakeLists.txt, which at least make cmake succeed. However, when I 
tried to compile it with
  
  6. make
  
  It breaks with
  
Scanning dependencies of target plasma_applet_notifications
[ 20%] Building CXX object 
CMakeFiles/plasma_applet_notifications.dir/notificationapplet.o

/path/KDE/plasma-workspace/applets/notifications/notificationapplet.cpp:27:10: 
error: QQuickItem: File or directory not found
   27 | #include 
  |  ^~~~
Compilation terminated.
make[2]: *** [CMakeFiles/plasma_applet_notifications.dir/build.make:63: 
CMakeFiles/plasma_applet_notifications.dir/notificationapplet.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:233: 
CMakeFiles/plasma_applet_notifications.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
  
  I have the Qt development and kcoreaddons' files installed. I thought this 
procedure would be more straight forward. I'm looking forward to your advice. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22605: Set plasma-nm history entry icon size to medium

[Alex Debus]

alexde created this revision.
alexde added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexde requested review of this revision.

REVISION SUMMARY
  The current history entry icon is rather large and therefore
  hits the bottom of the entry in the list.
  As the margin between two entries is small, it looks more clear
  overall if the icon becomes smaller.
  
  BUG: 409855

REPOSITORY
  R120 Plasma Workspace

BRANCH
  plasma-nm-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22605

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22589: Embrace X-KDE-Wayland-Interfaces

[Vlad Zagorodniy]

zzag added subscribers: mvourlakos, zzag.
zzag added a comment.


  @mvourlakos Perhaps Latte-Dock will need to set X-KDE-Wayland-Interfaces too 
(I assume that Latte-Dock uses libtaskmanager).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22589

To: apol, #plasma, #kwin
Cc: zzag, mvourlakos, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 updated this revision to Diff 62170.
luc4 added a comment.


  This is another implementation that follows the same principale of the 
previous ones, but moves the responsibility of maintaining the state to the 
`dragHelper` object. This requires to postpone the reset of the state after the 
onRelease event.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22306?vs=61994=62170

REVISION DETAIL
  https://phabricator.kde.org/D22306

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/plugin/draghelper.cpp
  applets/kicker/plugin/draghelper.h

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D9388: Fix queued connection error

[Albert Astals Cid]

aacid closed this revision.
aacid added a comment.


  There's no minimizeall applet anymore

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9388

To: iromanov, graesslin, mart
Cc: aacid, davidedmundson, anthonyfieroni, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Pino Toscano]

pino added a comment.


  In D22210#498929 , @asturmlechner 
wrote:
  
  > drop translations
  
  
  No need to do that, scripty will take care of it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Fabian Vogt]

fvogt added a comment.


  In D22210#498929 , @asturmlechner 
wrote:
  
  > drop translations, rename to 'Plasma on Xorg'
  
  
  That would not be symmetric to "Plasma (Wayland)" though as produced by sddm.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 62165.
asturmlechner added a comment.


  drop translations, rename to 'Plasma on Xorg'

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22210?vs=60995=62165

BRANCH
  session-rename

REVISION DETAIL
  https://phabricator.kde.org/D22210

AFFECTED FILES
  login-sessions/plasma.desktop.cmake

To: asturmlechner, #plasma, davidedmundson
Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21829: Improved Touch support for Kickoff

[Steffen Hartleib]

steffenh added a comment.


  Oh, sorry, I have the feeling I have misunderstood the post from @hein, I 
have the impression he wants to make a patch to DragHelper, but if I read this 
again, so sorry.
  
  I have the last days looking at plasma-frameworks, but my knowledge of the 
working of plasma is close to zero, so I am afraid I'm not able to do this.
  
  Perhaps is it better to remove the change in DragHelper, in the end the main 
point of this patch was to fix the two bugs?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff

REVISION DETAIL
  https://phabricator.kde.org/D21829

To: steffenh, #plasma, hein, ngraham
Cc: mart, sbergeron, davidedmundson, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol