D22738: Remove some uses on QDesktopWidget

[Aleix Pol Gonzalez]

apol updated this revision to Diff 62582.
apol added a comment.


  addressed comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22738?vs=62534=62582

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22738

AFFECTED FILES
  applets/pager/plugin/pagermodel.cpp
  containments/desktop/plugins/folder/foldermodel.cpp
  kcms/desktoppaths/globalpaths.cpp
  kcms/fonts/previewrenderengine.cpp

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22738: Remove some uses on QDesktopWidget

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in foldermodel.cpp:1640
> KNewFileMenu.cpp in the constructor
>  1148 d->m_parentWidget = qobject_cast(parent);
> 
> without a transient parent we probably have focus issues?

It doesn't show any issues that I can see.
Also the QDesktopWidget isn't an actual widget so I'm not sure what it's 
supposed to be bringing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22738

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22480: Don't use KPluginInfo if we can use KPluginMetaData

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:44114500acd3: Dont use KPluginInfo if we can use 
KPluginMetaData (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22480?vs=61820=62581

REVISION DETAIL
  https://phabricator.kde.org/D22480

AFFECTED FILES
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: apol, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:46
> Do we need a Layout.fillWidth here?

This happens without` Layout.fillWidth`

F7097863: image.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-more-warning-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22752

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22757: Guard against missing xrandr extension

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Found from a user doing something wrong with their wayland session, but
  it could still happen.
  
  BUG: 410211

TEST PLAN
  None

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22757

AFFECTED FILES
  shell/screenpool.cpp
  shell/screenpool.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:46
>  
> -FontWidget {
> -id: generalFontWidget
> -label: i18n("General:")
> -category: "generalFont"
> -font: kcm.generalFont
> -}
> -FontWidget {
> -label: i18n("Fixed width:")
> -category: "fixedWidthFont"
> -font: kcm.fixedWidthFont
> -}
> -FontWidget {
> -label: i18n("Small:")
> -category: "smallFont"
> -font: kcm.smallFont
> -}
> -FontWidget {
> -label: i18n("Toolbar:")
> -category: "toolbarFont"
> -font: kcm.toolbarFont
> -}
> -FontWidget {
> -label: i18n("Menu:")
> -category: "menuFont"
> -font: kcm.menuFont
> -}
> -FontWidget {
> -label: i18n("Window title:")
> -category: "windowTitleFont"
> -font: kcm.windowTitleFont
> -}
> -
> -Kirigami.Separator {
> -Kirigami.FormData.isSection: true
> -}
> +Kirigami.FormLayout {
> +id: formLayout

Do we need a Layout.fillWidth here?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-more-warning-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22752

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22753: [taskmanager] Simplifiy one of the two PID lookups

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KwindowInfo already has the PID, which we use in another case where PID is 
used.
  
  More importantly I have a patch coming to KWindowSystem that returns the 
correct PID
  for processes inside a PID namespace, but I don't alter the NETProperties.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22753

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

[Filip Fila]

filipf added a subscriber: broulik.
filipf added a comment.


  Something @broulik proposed is to have the inline message spawn right below 
the separator that precedes the antialiasing settings instead of at the very 
top.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22752

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

[Filip Fila]

filipf updated this revision to Diff 62575.
filipf added a comment.


  rebase on master

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22752?vs=62574=62575

BRANCH
  no-more-warning-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22752

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch gets rid of the popup message spawned when applying changes in the 
Fonts KCM and instead places the very same information in an inline message.
  
  BUG: 388433

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-more-warning-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22752

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22738: Remove some uses on QDesktopWidget

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  concept ++

INLINE COMMENTS

> pagermodel.cpp:120
> +QObject::connect(qGuiApp, ::screenAdded, q, [q](QScreen* 
> screen) {
> +QObject::connect(screen, ::geometryChanged, q, 
> ::pagerItemSizeChanged);
> +q->pagerItemSizeChanged();

we need this connection for screens that already exist when this code runs

> foldermodel.cpp:1640
>  
> -m_newMenu = new KNewFileMenu(_actionCollection, 
> QStringLiteral("newMenu"), QApplication::desktop());
> +m_newMenu = new KNewFileMenu(_actionCollection, 
> QStringLiteral("newMenu"), this);
>  m_newMenu->setModal(false);

KNewFileMenu.cpp in the constructor
 1148 d->m_parentWidget = qobject_cast(parent);

without a transient parent we probably have focus issues?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22738

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  Tried it out. My reaction is: "Wow, this is really nice."
  
  One UI improvement I could see is to allow multi-selection of categories, so 
for example you could see images from all the nature-related categories but not 
Car or Sports.
  
  The way I'd envision this working is that instead of a combo box, a label 
would display the currently selected categories. Next to it would be a button 
labeled "Change categories" that would use the multi-page KCM API to take the 
user to another page with a checkbox for each category. This page would allow 
selecting any assortment of categories, which would then be listed on the main 
page. It would be sort of like the corner selector UI in the new Notifications 
KCM.
  
  Anyway, that's definitely a nice-to-have, and this seems fine from a 
functional and UI perspective already.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22748: whitelist the "turn off screen" shortcut on the lock screen

[Martin Blumenstingl]

mblumenstingl added a comment.


  In D22748#502337 , @mblumenstingl 
wrote:
  
  > I did some more digging and I now believe that I'm facing a problem that's 
related to me running wayland.
  >
  > 
https://github.com/KDE/kwindowsystem/blob/05f5379c24a59e1ded2f12a6fd09946617abd0ac/src/kkeyserver.h#L29
  >  KKeyServer has a compile-time switch for it's backend.
  >  I guess this needs to be converted to a runtime switch similar to what was 
done here 
https://github.com/KDE/kguiaddons/commit/0fe2990dbad992a4925a7b7bee09b1cdfbe5a7a7#diff-928c366533ef47aba95b92e8767bc8ff
  
  
  there's even a task on phabricator for this: T4423 


REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22748

To: mblumenstingl, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22748: whitelist the "turn off screen" shortcut on the lock screen

[Martin Blumenstingl]

mblumenstingl added a comment.


  I did some more digging and I now believe that I'm facing a problem that's 
related to me running wayland.
  
  
https://github.com/KDE/kwindowsystem/blob/05f5379c24a59e1ded2f12a6fd09946617abd0ac/src/kkeyserver.h#L29
  KKeyServer has a compile-time switch for it's backend.
  I guess this needs to be converted to a runtime switch similar to what was 
done here 
https://github.com/KDE/kguiaddons/commit/0fe2990dbad992a4925a7b7bee09b1cdfbe5a7a7#diff-928c366533ef47aba95b92e8767bc8ff

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22748

To: mblumenstingl, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22261: Add a global shortcut action to turn off the screen

[Martin Blumenstingl]

mblumenstingl added a comment.


  In D22261#502044 , @broulik wrote:
  
  > Just checking, are you still up for making this kscreenlocker change? Given 
the heatwave right now I would have loved to be able to turn off my screens on 
the lock screen explicitly :D
  
  
  I just created D22748 
  unfortunately the patch is not working for me, probably because there's some 
other issue on my system with kscreenlocker. see the description for details

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D22261

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22748: whitelist the "turn off screen" shortcut on the lock screen

[Martin Blumenstingl]

mblumenstingl created this revision.
mblumenstingl added a reviewer: broulik.
mblumenstingl added a project: Plasma.
mblumenstingl requested review of this revision.

REVISION SUMMARY
  This is a follow-up to D22261 
  
  unfortunately the test plan is not working for me:
  when I press the global shortcut on the lock screen then the display does not 
turn off.
  however, this is not related to the new global action because "volume up", 
"volume down", "mute" and "play pause" are also not working for me on the lock 
screen

TEST PLAN
  start a plasma wayland session
  open systemsettings5 -> Shortcuts -> Global Shortcuts -> Power Management
  assign a shortcut to "Turn Off Screen"
  press this shortcut
  (screen must now turn off -> this confirms that the shortcut is working)
  move the mouse or press a key to turn the screen back on
  lock the screen
  press the global shortcut again
  (screen must now turn off)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22748

AFFECTED FILES
  globalaccel.cpp

To: mblumenstingl, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  Oh sweet! I guess I should actually test it out. :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  In D22494#502187 , @ngraham wrote:
  
  > Nice!
  >
  > How about adding an "All" entry for the combo box which would show you 
wallpapers from any category? Is that possible?
  
  
  I already added "All" option.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22691: Remove the share dataengine.

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22691

To: aacid, davidedmundson
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D19676: Fix out of bounds access error in SystemLoadViewer.qml

[Albert Astals Cid]

aacid added a comment.


  This is unlandable in KDE at this point because (say our sysadmins) "the 
nameservers for the domain estada.ch are highly unreliable and fail fairly 
often." and our git is very picky and doesn't like that.
  
  I don't particularly care about this piece of code, but if you do i guess you 
should try to fix that, or give us a different email address to use.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19676

To: stefantux, #plasma, davidedmundson
Cc: aacid, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20908: Redesign QML applet configuration windows

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:34ea1e73680f: Redesign QML applet configuration windows 
(authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=62558=62562

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D22728: Provide a link to KInfoCenter

[Nathaniel Graham]

ngraham added a comment.


  And here's the patch for the alternative approach: 
https://phabricator.kde.org/D22742

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is an alternative to D22728 . It 
makes the System Information KCM appear in
  System Settings' System Administration section.
  
  Advantages over D22728 :
  
  - The information is more discoverable
  - It automatically disappears if KInfoCenter is not installed or removed
  - It requires no changes to SystemSettings' fragile codebase
  
  Disadvantages:
  
  - Since it doesn't open KInfoCenter or have a link to it, all the other 
information in KInfoCenter is not exposed
  - If we do later want to adjust this KCM to have a button to open KInfoCenter 
when pushed, we'll hit https://bugs.kde.org/show_bug.cgi?id=410169 since the 
KCM will be already open in System Settings

TEST PLAN
  F7096717: in systemsettings.png 

REPOSITORY
  R102 KInfoCenter

BRANCH
  show-about-distro-kcm-in-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22742

AFFECTED FILES
  Modules/about-distro/src/about-distro.desktop

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20908: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 62558.
filipf added a comment.


  don't remove the other file :)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=62557=62558

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 62557.
filipf added a comment.


  do not update the highlight effect (yet)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60584=62557

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  The companion patches have landed; this can go in now!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  Nice!
  
  How about adding an "All" entry for the combo box which would show you 
wallpapers from any category? Is that possible?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  Now it is working again! You will have a Category combobox to choose photo 
collections from Unsplash
  
  F7096418: image.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62551.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62550=62551

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62550.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62549=62550

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62549.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62547=62549

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62547.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62546=62547

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62546.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62541=62546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Jonathan Marten]

marten created this revision.
marten added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
marten requested review of this revision.

REVISION SUMMARY
  Bug https://bugs.kde.org/show_bug.cgi?id=410190 describes the inconsistent 
virtual desktop numbering between the Switch Window popup and the taskbar Move 
To Desktop list.  This patch fixes the Switch Window popup to use the more 
natural (to the user) 1-based desktop IDs.
  
  According to virtualdesktopinfo.h, a desktop ID on Wayland is a QString while 
on X11 it is a uint.  Therefore using toString() here for correct formatting of 
the desktop ID on both X11 and Wayland.

TEST PLAN
  Built plasma-workspace with this change, observed correct and consistent 
desktop numbering in both these places.  Not yet able to test on Wayland.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

To: marten, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22728: Provide a link to KInfoCenter

[Christoph Feck]

cfeck added a comment.


  +1 for putting it in the Help menu.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22535: Make kimpanel a system tray applet

[Nathaniel Graham]

ngraham added a comment.


  +1,000 for having you guys become the KDE "Input Method dream team". FWIW I 
am super supportive of T11054  and 
sincerely hope it gets chosen. It's critically important.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: xuetianweng, gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

D22480: Don't use KPluginInfo if we can use KPluginMetaData

[Aleix Pol Gonzalez]

apol added a comment.


  ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22480

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22735: Introduce ResultsModel with better data processing and filtering

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM overall

INLINE COMMENTS

> ResultsView.qml:94
>  
> -if (runAutomatically) {
> -runCurrentIndex();
> +function reset() {
> +listView.currentIndex = 0;

Call it `resetView()`? Otherwise it seems like you're resetting the model again.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D22735

To: broulik, #plasma
Cc: apol, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62541.
guoyunhe added a comment.


Fix crashing

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62539=62541

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22735: Introduce ResultsModel with better data processing and filtering

[Kai Uwe Broulik]

broulik updated this revision to Diff 62540.
broulik edited the summary of this revision.
broulik added a comment.


  - Emit dataChanged before inserting and only update the to be signalled range
  - Add some docs to make future me happy
  - Fix current index behavior with mouse and keyboard

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22735?vs=62527=62540

REVISION DETAIL
  https://phabricator.kde.org/D22735

AFFECTED FILES
  CMakeLists.txt
  lib/CMakeLists.txt
  lib/qml/ResultDelegate.qml
  lib/qml/ResultsView.qml
  lib/qml/qmlplugins.cpp
  lib/resultsmodel.cpp
  lib/resultsmodel.h
  lib/runnerresultsmodel.cpp
  lib/runnerresultsmodel.h

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  The new change try to add a new ComboBox "Category" and pass the value to 
PODT data engine. This also introduced a new configuration option. But now it 
makes plasmashell crash without useful error output.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62539.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62538=62539

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62538.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61901=62538

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22648: make handle follow arbitrary height of the drawer

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:518444e4191a: make handle follow arbitrary height of the 
drawer (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22648?vs=62345=62535

REVISION DETAIL
  https://phabricator.kde.org/D22648

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: camiloh, mart, #kirigami
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22738: Remove some uses on QDesktopWidget

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Adds an unnecessary dependency to QtWidgets and forces some round-trips to 
the X server that we don't need.

TEST PLAN
  Been using it for some days

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22738

AFFECTED FILES
  applets/pager/plugin/pagermodel.cpp
  containments/desktop/plugins/folder/foldermodel.cpp
  kcms/desktoppaths/globalpaths.cpp
  kcms/fonts/previewrenderengine.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 93 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/93/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 25 Jul 2019 12:11:31 +
 Build duration:
7 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report11%
(2/19)5%
(7/134)5%
(7/134)4%
(464/12785)2%
(178/8585)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskcm0%
(0/1)0%
(0/1)0%
(0/310)0%
(0/212)kded0%
(0/12)0%
(0/12)0%
(0/1280)0%
(0/946)libs0%
(0/4)0%
(0/4)0%
(0/883)0%
(0/473)libs.declarative0%
(0/7)0%
(0/7)0%
(0/607)0%
(0/461)libs.editor36%
(4/11)36%
(4/11)27%
(212/797)22%
(163/752)libs.editor.settings0%
(0/21)0%
(0/21)0%
(0/2985)0%
(0/1942)libs.editor.widgets0%
(0/17)0%
(0/17)0%
(0/981)0%
(0/426)libs.models0%
(0/9)0%
(0/9)0%
(0/1420)0%
(0/1199)tests100%
(3/3)100%
(3/3)100%
(252/252)63%
(15/24)vpn.fortisslvpn0%
(0/5)0%
(0/5)0%
(0/150)0%
(0/70)vpn.iodine0%
(0/4)0%
(0/4)0%
(0/96)0%
(0/38)vpn.l2tp0%
(0/6)0%
(0/6)0%
(0/341)0%
(0/181)vpn.openswan0%
(0/4)0%
(0/4)0%
(0/159)0%
(0/102)vpn.openvpn0%
(0/5)0%
(0/5)0%
(0/1224)0%
(0/1047)vpn.pptp0%
(0/5)0%
(0/5)0%
(0/207)0%
(0/89)vpn.ssh0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/131)vpn.sstp0%
(0/5)0%
(0/5)0%
(0/244)0%
(0/117)vpn.strongswan0%
(0/5)0%
(0/5)0%
(0/140)0%
(0/71)vpn.vpnc0%
(0/5)0%
   

D22514: Show if KRunner is still searching for more things

[Aleix Pol Gonzalez]

apol planned changes to this revision.
apol added a comment.


  In D22514#502042 , @aspotashev 
wrote:
  
  > This would fix https://bugs.kde.org/show_bug.cgi?id=409959 , right?
  
  
  Yes, please review D22540  so I can offer 
a better solution for @broulik's concerns.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol
Cc: aspotashev, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22535: Make kimpanel a system tray applet

[Gun Park]

gpark added a comment.


  Here's a video demonstrating the GSoC project's results:
  
  F7095313: vokoscreen-2019-07-25_20-29-54.mkv 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: xuetianweng, gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 92 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/92/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 25 Jul 2019 11:29:11 +
 Build duration:
1 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 465 lines...][2019-07-25T11:30:25.794Z] [ 16%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/pppwidget.cpp.o[2019-07-25T11:30:26.051Z] [ 17%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/security802-1x.cpp.o[2019-07-25T11:30:26.051Z] [ 17%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/teamwidget.cpp.o[2019-07-25T11:30:26.306Z] [ 18%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/vlanwidget.cpp.o[2019-07-25T11:30:26.306Z] [ 18%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wificonnectionwidget.cpp.o[2019-07-25T11:30:26.562Z] [ 18%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wifisecurity.cpp.o[2019-07-25T11:30:26.562Z] [ 19%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wiredconnectionwidget.cpp.o[2019-07-25T11:30:27.124Z] [ 19%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wiredsecurity.cpp.o[2019-07-25T11:30:27.703Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardinterfacewidget.cpp.o[2019-07-25T11:30:27.703Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardtabwidget.cpp.o[2019-07-25T11:30:29.067Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardpeerwidget.cpp.o[2019-07-25T11:30:29.322Z] [ 21%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/advancedpermissionswidget.cpp.o[2019-07-25T11:30:29.322Z] [ 21%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/bssidcombobox.cpp.o[2019-07-25T11:30:29.322Z] [ 22%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/delegate.cpp.o[2019-07-25T11:30:29.883Z] [ 22%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/editlistdialog.cpp.o[2019-07-25T11:30:29.883Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/hwaddrcombobox.cpp.o[2019-07-25T11:30:30.138Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/intdelegate.cpp.o[2019-07-25T11:30:30.393Z] /home/jenkins/workspace/Plasma/plasma-nm/kf5-qt5 SUSEQt5.12/libs/editor/settings/wireguardtabwidget.cpp:53:30: warning: ���WireGuardKeyValidator keyValidator()��� declared ���static��� but never defined [-Wunused-function][2019-07-25T11:30:30.393Z]53 | static WireGuardKeyValidator keyValidator();[2019-07-25T11:30:30.393Z]   |  ^~~~[2019-07-25T11:30:30.953Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv4delegate.cpp.o[2019-07-25T11:30:30.953Z] [ 24%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv4routeswidget.cpp.o[2019-07-25T11:30:30.953Z] [ 24%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv6delegate.cpp.o[2019-07-25T11:30:30.953Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv6routeswidget.cpp.o[2019-07-25T11:30:31.209Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/passwordfield.cpp.o[2019-07-25T11:30:31.465Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/settingwidget.cpp.o[2019-07-25T11:30:31.721Z] [ 26%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ssidcombobox.cpp.o[2019-07-25T11:30:32.281Z] [ 26%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditorbase.cpp.o[2019-07-25T11:30:32.282Z] [ 27%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditordialog.cpp.o[2019-07-25T11:30:32.282Z] [ 27%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditortabwidget.cpp.o[2019-07-25T11:30:32.537Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/listvalidator.cpp.o[2019-07-25T11:30:32.792Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleipv4addressvalidator.cpp.o[2019-07-25T11:30:33.048Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleipv6addressvalidator.cpp.o[2019-07-25T11:30:33.048Z] [ 29%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleiplistvalidator.cpp.o[2019-07-25T11:30:33.610Z] [ 29%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/wireguardkeyvalidator.cpp.o[2019-07-25T11:30:33.610Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/vpnuiplugin.cpp.o[2019-07-25T11:30:33.610Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/configuration.cpp.o[2019-07-25T11:30:33.610Z] [ 

D22734: Support displaying emoticons in connection name and SSID

[Jan Grulich]

jgrulich abandoned this revision.
jgrulich added a comment.


  In D22734#502034 , @broulik wrote:
  
  > -1 to dragging in KEmoticons for that.
  >  Aren't they just unicode Emojis which we can render just fine elsewhere.
  
  
  You are right, I can display them just fine. I should have tried that before.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22734

To: jgrulich, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22261: Add a global shortcut action to turn off the screen

[Kai Uwe Broulik]

broulik added a comment.


  Just checking, are you still up for making this kscreenlocker change? Given 
the heatwave right now I would have loved to be able to turn off my screens on 
the lock screen explicitly :D

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D22261

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22514: Show if KRunner is still searching for more things

[Alexander Potashev]

aspotashev added a comment.


  This would fix https://bugs.kde.org/show_bug.cgi?id=409959 , right?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol
Cc: aspotashev, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22735: Introduce ResultsModel with better data processing and filtering

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> resultsmodel.cpp:154
> +
> +class HideRootLevelProxyModel : public QSortFilterProxyModel
> +{

Future Kai is going to appreciate some docs on what each class does.

> runnerresultsmodel.cpp:146-148
> +// Now that the source data has been updated, emit the data changes 
> we noted down earlier
> +if (signalDataChanged) {
> +emit dataChanged(index(0, 0, categoryIdx), 
> index(endOfUpdateableRange, 0, categoryIdx));

Urgh, we've done this style before and it resulted in obscure QtQuick crashes.

For QtQuick we need to insert new rows for new rows, not just insert/remove the 
difference and emit changed on everything, otherwise we mess up the delegates.

See 9371a7c96d4722b93b49b18df7b21780f2a9ad38 
 in 
p-d

Sorry.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D22735

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22734: Support displaying emoticons in connection name and SSID

[Kai Uwe Broulik]

broulik added a comment.


  -1 to dragging in KEmoticons for that.
  Aren't they just unicode Emojis which we can render just fine elsewhere.

INLINE COMMENTS

> DetailsText.qml:84
>  text: "" + details[index*2] + ": "
> +textFormat: Text.StyledText
>  

Since there are HTML tags already, it defaults to `StyledText` already, but it 
doesn't hurt to be explicit

> DetailsText.qml:106
>  text: details[(index*2)+1]
> -textFormat: Text.PlainText
> +textFormat: Text.StyledText
>  

Make sure the text is HTML-escaped

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22734

To: jgrulich, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18860: Add comment / description to the translations kcm

[Bhushan Shah]

bshah accepted this revision as: bshah.
bshah added a comment.
This revision is now accepted and ready to land.


  I'd say if no-one else objects, feel free to submit this revision now. :-)
  
  We can always revise it since this is not going in stable branch.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D18860

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma, ngraham, bshah
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea32a7611227: [Image Wallpaper Slideshow] Allow setting 
of different sorting orders (authored by davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22121?vs=62529=62530#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=62529=62530

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre updated this revision to Diff 62529.
davidre added a comment.


  Last touches
  
  - remove QDebug
  - don't restore image if we are in random mode
  - if we have seen all images generate a new random order

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61648=62529

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[Kai Uwe Broulik]

broulik added a comment.


  Can you delay showing the busy indicator a bit? e.g. only show if there 
haven't been any new results for 500ms or so, to avoid that thing constantly 
flashing up. Perhaps easiest would be something like
  
Timer {
id: delayBusyIndicatorTimer
interval: 500
}

BusyIndicator {
visible: !delayBusyIndicatorTimer.running && results.queryActive
}

onQueryStringChanged: delayBusyIndicatorTimer.start()
  
  Also, it would be lovely to animate its appearance/disappearance instead of 
just using `visible`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22735: Introduce ResultsModel with better data processing and filtering

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This adds a new `Milou.ResultsModel` for runner results which tries very hard 
to avoid model resets and instead signals addition, removal, and changes in 
results.
  The various result processing, filtering, and grouping features are split 
into tiny dedicated proxy models to make the code easier to follow and 
maintain. The QML API isn't changed so that look and feel themes don't need to 
be adjusted.
  
  The raw results model is a tree of runner results grouped by `matchCategory` 
(e.g. "Documents", "Applications").
  Results are then sorted by result type (`ExactMatch`, `HelperMatch`, etc) and 
by their `relevance`. The highest scored match in a group determines its 
overall score. The previous heuristic of prefering categories who have results 
with the query in their visible text has been removed but could easily be added 
back if deemed beneficial for the quality of results.
  
  The groups are then limited in size with higher scored categories being 
allowed to show more matches. This model could in the future also be extended 
to allow expanding groups to show all of the results inside.
  After that the model is flattened back into a tree with the group items 
removed for consumption in the existing `ListView`. Items with an identical 
`text` will have their `subtext` displayed automatically for disambiguation.

TEST PLAN
  - KRunner feels snappier overall, especially when dealing with a result set 
that hardly changes, e.g. using the calculator runner
  - Ran model test and fixed most of its complaints. However, when updating a 
category, we append the new items, replace the entire list, and afterwards 
signal a data change, which model test doesn't like. It checks for whether the 
data before the inserted area didn't change, which it did at this point but 
that's why we signal a data change afterwards :)
  
  - Running results still works
  - Replacing the query string when requested still works, e.g. clicking on a 
calculator runner result changes the query string to that number
  - Dragging results from KRunner to elsewhere still works. I noticed dragging 
applications from krunner to kickoff doesn't work but didn't check if that is a 
regression or because KRunner closes when kickoff opens
  - Invoking runner actions (e.g. "run in terminal") still work

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D22735

AFFECTED FILES
  CMakeLists.txt
  lib/CMakeLists.txt
  lib/qml/ResultDelegate.qml
  lib/qml/ResultsView.qml
  lib/qml/qmlplugins.cpp
  lib/resultsmodel.cpp
  lib/resultsmodel.h
  lib/runnerresultsmodel.cpp
  lib/runnerresultsmodel.h

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22734: Support displaying emoticons in connection name and SSIDBUG: 408550

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22734

AFFECTED FILES
  CMakeLists.txt
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  kcm/qml/ConnectionItem.qml
  libs/CMakeLists.txt
  libs/editor/CMakeLists.txt
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h

To: jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22535: Make kimpanel a system tray applet

[Yunhe Guo]

guoyunhe added a subscriber: xuetianweng.
guoyunhe added a comment.


  Thanks @hein ! I will check the GSoC project and see if I can continue with 
that. I see the original author of Kimpanel is @xuetianweng . Let's listen to 
his opinion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: xuetianweng, gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:29fb6ce9e369: Add icons to Categories, Installed, and 
Sources globaldrawer entries (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22716?vs=62471=62521

REVISION DETAIL
  https://phabricator.kde.org/D22716

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  libdiscover/Category/CategoriesReader.cpp
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, #vdg, ngraham, apol
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22535: Make kimpanel a system tray applet

[Eike Hein]

hein added a subscriber: gpark.
hein added a comment.


  To catch this up to the GSoC status:
  
  
https://medium.com/@mujjingun_23509/google-summer-of-code-porting-keyboard-kcm-to-qt-quick-part-2-30c115771722
  
https://medium.com/@mujjingun_23509/google-summer-of-code-porting-keyboard-kcm-to-qt-quick-part-2-30c115771722
  
  Repo:
  
  
https://cgit.kde.org/clones/plasma-desktop/gpark/gsoc-kcm-keyboard-revamp.git/?h=new_keyboard_kcm
  
  There were nice videos showing the improved kimpanel and the switching w/ OSD 
and KCM open and everything being in sync somewhere, too, but I can't find them 
off-hand.
  
  To be clear: I'm not saying this patch is bad, but rather that we're in the 
fortunate position that it doesn't need to be pushed into slaying the 
configuration beast all alone as the above response did. It's not correct, and 
also not necessary because there's an existing body of work to leverage!
  
  Between @gpark, @guoyunhe, me and others, the right thing to do is form a 
team to advance this together, and make this patch part of it. A good place to 
organize this effort can be around T11054 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

D22535: Make kimpanel a system tray applet

[Eike Hein]

hein added subscribers: mart, hein.
hein added a comment.


  The configuration should be in System Settings, not in this applet, as 
they're system-global and override keyboard layout settings.
  
  The 2018 GSoC work started to implement this and got far, and also made 
kimpanel replace the existing tray keyboard layout indicator in the process and 
update the OSD and all the other system parts to understand input methods and 
switch between then. We should look into leveraging at least the applet changes 
right now and merging them with this patch.
  
  As for the conceptual change: It's a change I also suggested once, but was 
veto'd by the kimpanel maintainer at the time who was strongly of the opinion 
that every icon needs to be visible at all times. The discussion between him, 
me and @mart at the time was to spawn multiple SNIs and teach the tray to sort 
them together. I think this is workable but still advocate a single icon by 
default unless others are explicitly enabled.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: hein, mart, ngraham, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

D22728: Provide a link to KInfoCenter

[Matej Mrenica]

mthw added a comment.


  I personally like the alternative aproach, as it is what I had in mind when 
submitting the bug report.
  
  > - There isn't really a 100% appropriate parent category to put it in
  
  It could be the last item in the Hardware section. Also, IIRC Gnome does it 
like this (not that we should copy Gnome or anything, it just feels intuitive).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Marijo Mustac]

mmustac added a comment.


  In D22728#501819 , @ngraham wrote:
  
  > An alternative approach would be to simply show KCM itself in System 
Settings by adding `X-KDE-System-Settings-Parent-Category=` to the 
`about-dostro.desktop` file that KInfoCenter ships:
  >
  > F7092747: Alternative: as a KCM.png 
  >
  > This makes it more discoverable when using Sidebar view, but has some 
disadvantages:
  >
  > - There isn't really a 100% appropriate parent category to put it in
  > - Visiting the KCM within System Settings doesn't expose all the 
information available in KInfoCenter's other pages. I suppose we could add a 
Show More Information button to this KCM when it's opened in something other 
than KInfoCenter if we wanted to pursue the alternative approach instead of the 
one in this patch.
  
  
  I really like this integrated approach.
  While I have no access to linux or Plasma at the moment ... but when I 
remember correctly there could appear a "system administration" category when 
installing the systemd-kcm for example.
  F7094390: KDE_5_System_Settings_on_Fedora_22_no_user_account.png 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: mmustac, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Kai Uwe Broulik]

broulik added a comment.


  +1 to the idea

INLINE COMMENTS

> SettingsBase.cpp:151
> +systemInformationAction = actionCollection()->addAction( 
> QStringLiteral("help_about_system"), this, [] () {
> +KRun::runCommand( QStringLiteral("kinfocenter"), nullptr );
> +} );

Can you do `runApplication` with `org.kde.kinfocenter` service, then you can 
also just read the icon etc from there

Also, perhaps check if it is installed?

> SettingsBase.cpp:402
>  QList configureBarActions;
> -configureBarActions << configureAction;
> +configureBarActions << configureAction << systemInformationAction;
>  guiFactory()->plugActionList( this, QStringLiteral("configure"), 
> configureBarActions );

Not sure about having a bigass button with wide text in the toolbar at all times

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart