D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein updated this revision to Diff 62883.
hein added a comment.


  Don't hit Kirigami.Label (deprecated)

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22868?vs=62880=62883

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

AFFECTED FILES
  src/controls/AboutPage.qml
  src/controls/Page.qml

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22845: [GTK3] Convert all colors to use GTK color definitions

[Carson Black]

cblack added a comment.


  In D22845#504927 , @ngraham wrote:
  
  > Neato mosquito!
  >
  > Unfortunately, it doesn't build:
  >
  >   [ 75%] Building CXX object 
kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o
  >   Installing into /home/nate/kde/build/breeze-gtk/Breeze-Dark
  >   [ 75%] Built target Breeze-Dark
  >   Installing into /home/nate/kde/build/breeze-gtk/Breeze
  >   cp: cannot stat 'gtk-dark-3.18.css': No such file or directory
  >
  >
  > Looks like your change in `build_theme.sh` had some unintended 
consequences. I guess we still need the 3.18 dirs for compatibility, or else we 
need to formally deprecate 3.18 and remove all traces of it.
  
  
  Just changed the CMakeLists.txt and readded a needed file, it should build 
now.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22845

To: cblack, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22868: Revamp Kirigami.AboutPage

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Super duper better now.

REPOSITORY
  R169 Kirigami

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22845: [GTK3] Convert all colors to use GTK color definitions

[Carson Black]

cblack updated this revision to Diff 62882.
cblack added a comment.


  Forgot to add you

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22845?vs=62881=62882

BRANCH
  colordefs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22845

AFFECTED FILES
  src/CMakeLists.txt
  src/_colors.scss
  src/_functions.scss
  src/build_theme.sh
  src/gtk-dark-3.0.css
  src/gtk-dark-3.18.css
  src/gtk-dark-3.20.css
  src/gtk-dark.css
  src/gtk3/gtk.scss
  src/gtk3/widgets/_app_notifications.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_button.scss
  src/gtk3/widgets/_calendar.scss
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_color_chooser.scss
  src/gtk3/widgets/_dialogs.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_lists.scss
  src/gtk3/widgets/_menus.scss
  src/gtk3/widgets/_misc.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_overshoot.scss
  src/gtk3/widgets/_pathbar.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_sidebar.scss
  src/gtk3/widgets/_spinbutton.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_toolbar.scss
  src/gtk3/widgets/_tooltips.scss
  src/gtk3/widgets/_treeview.scss
  src/gtk3/widgets/_window_decorations.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: cblack, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein added a comment.


  Discover:
  
  F7130049: Screenshot_20190801_100601.png 

  
  Material style:
  
  F7130053: Screenshot_20190801_100645.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22845: [GTK3] Convert all colors to use GTK color definitions

[Carson Black]

cblack updated this revision to Diff 62881.
cblack added a comment.


  Fix CMakeLists.txt

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22845?vs=62858=62881

BRANCH
  colordefs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22845

AFFECTED FILES
  src/CMakeLists.txt
  src/_colors.scss
  src/_functions.scss
  src/build_theme.sh
  src/gtk-dark-3.18.css
  src/gtk-dark-3.20.css
  src/gtk-dark.css
  src/gtk3/gtk.scss
  src/gtk3/widgets/_app_notifications.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_button.scss
  src/gtk3/widgets/_calendar.scss
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_color_chooser.scss
  src/gtk3/widgets/_dialogs.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_lists.scss
  src/gtk3/widgets/_menus.scss
  src/gtk3/widgets/_misc.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_overshoot.scss
  src/gtk3/widgets/_pathbar.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_sidebar.scss
  src/gtk3/widgets/_spinbutton.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_toolbar.scss
  src/gtk3/widgets/_tooltips.scss
  src/gtk3/widgets/_treeview.scss
  src/gtk3/widgets/_window_decorations.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: cblack, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein added a comment.


  Before:
  
  F7130036: Screenshot_20190801_15.png 

  
  After:
  
  F7130037: Screenshot_20190801_100033.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein created this revision.
hein added reviewers: Frameworks, VDG, mart, apol.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
hein requested review of this revision.

REVISION SUMMARY
  - Use a FormLayout to work nicely in both portrait and landscape orientations
  - Don't use an AbstractCard for the person delegate, it's very jarring in 
this design
  - Fix app description not having word wrap (breaks on portrait)
  - Improve inter-section spacing
  - Fix empty author email addresses showing as "Name <>"
  - Fix scrollbar length if a `Kirigami.Page` doesn't set any actions (and 
don't load a gigantic subtree of unnecessary objects into the page)
  - If an app uses `Kirigami.AbstractApplicationWindow` and doesn't have a 
`pageStack`, don't have the license delegate be a `LinkButton` that operates on 
one and causes an error
  - Add a fallback to KAboutData::componentName for the program icon - 
`KAboutData::programIconName` is deprecated, there's no QML accessor for its 
replacement `QGuiApplication::setWindowIcon` yet, but 
`KAboutData::programIconName` falls back to `componentName` already (it fails 
because `KAboutData::programIconName` isn't a qprop, but I don't feel like 
adding it to KCoreAddons for a deprecated thing while `componentName` is not 
deprecated)

REPOSITORY
  R169 Kirigami

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

AFFECTED FILES
  src/controls/AboutPage.qml
  src/controls/Page.qml

To: hein, #frameworks, #vdg, mart, apol
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22493: [Notifications] Move history items' icons over to the left a bit

[Nathaniel Graham]

ngraham added a comment.


  Oops.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22493

To: ngraham, broulik, #vdg, #plasma, filipf
Cc: filipf, alexde, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  In general +1, let's not let this tiny UI improvement die.
  
  However the implementation is not quite finished: Whenever you set a 
rightMargin to make something look better next to a scrollbar, you need to 
conditionalize that on it being a LTR language, and add a matching version for 
the leftMargin when using an RTL language, because in that case, the scrollbar 
goes on the other side of the view. Basically like this:
  
Layour.rightMargin: LayoutMirroring.enabled ? 0 : 
Kirigami.Units.smallSpacing / 2
Layout.leftMargin:  LayoutMirroring.enabled ? Kirigami.Units.smallSpacing / 
2 : 0
  
  Alternatively if the items are inside a Layout--as they are here--instead of 
using margins, you can add an `Item` to the layout with the width of the 
spacing you want, and RTL layouts will look fine automatically. This works 
because the direction of items in a Layout get automatically reversed for RTL 
languages, while the same is not true of manually-set margins.
  
  Your choice; I think using an `Item` is a bit more elegant but I don't object 
to the alternative approach.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D22817: Port KRunner to Plasma Components 3

[Nathaniel Graham]

ngraham added a comment.


  In D22817#504049 , @ognarb wrote:
  
  > To add the clear button, maybe you can use Kirigami.SearchField instead?
  
  
  +1, IMO this makes more sense than manufacturing our own search field, 
especially since the current implementation results in a close button that has 
a toolbutton style hover effect, unlike other ones.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22817

To: apol, #plasma, broulik
Cc: ngraham, ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> filipf wrote in main.qml:118
> @romangg you wrote the feature, should we capitalize its name? :)

I would leave it with the capital C since it's part of the name.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-kcm-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22845: [GTK3] Convert all colors to use GTK color definitions

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Neato mosquito!
  
  Unfortunately, it doesn't build:
  
[ 75%] Building CXX object 
kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o
Installing into /home/nate/kde/build/breeze-gtk/Breeze-Dark
[ 75%] Built target Breeze-Dark
Installing into /home/nate/kde/build/breeze-gtk/Breeze
cp: cannot stat 'gtk-dark-3.18.css': No such file or directory
  
  Looks like your change in `build_theme.sh` had some unintended consequences. 
I guess we still need the 3.18 dirs for compatibility, or else we need to 
formally deprecate 3.18 and remove all traces of it.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22845

To: cblack, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22481: Do not show play/pause button when no media is playing

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  -1 for all the previously given reasons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22481

To: shubham, broulik, #plasma, #vdg, ngraham
Cc: ngraham, filipf, ndavis, davidedmundson, #vdg, #plasma, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

[Eike Hein]

hein created this revision.
hein added reviewers: Frameworks, mart.
Herald added a project: Kirigami.
hein requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22867

AFFECTED FILES
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ForwardButton.qml

To: hein, #frameworks, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Filip Fila]

filipf added a subscriber: romangg.
filipf added inline comments.

INLINE COMMENTS

> GB_2 wrote in main.qml:118
> Lowercase c?

@romangg you wrote the feature, should we capitalize its name? :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg
Cc: romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22866: [Kickoff] Always select previous category in Applications View when navigating backwards

[Andrey Kozlovskiy]

akozlovskiy added a comment.


  Example in case the description is a little confusing :)
  F7129177: KickoffRememberCategory.mp4 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22866

To: akozlovskiy, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22866: Current version of the code positions view on the previous category but doesn't set the category itself. I think that selecting the previous category and not the first one is more convenient f

[Andrey Kozlovskiy]

akozlovskiy created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
akozlovskiy requested review of this revision.

REVISION SUMMARY
  ...right category, for example).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-appview-remember-previous-category (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22866

AFFECTED FILES
  applets/kickoff/package/contents/ui/ApplicationsView.qml

To: akozlovskiy
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> main.qml:118
> +RowLayout {
>  Kirigami.FormData.label: i18n("Night Color temperature:")
>  enabled: activator.checked

Lowercase c?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg
Cc: GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  - the slider is now of the same width as the comobox below it
  - the slider's value has been placed to the right of the slider, as the HIG 
mandates
  - use title case for "Detect Location" button
  - add an icon to the "Detect Location" button

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-kcm-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22863

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

[Noah Davis]

ndavis added a comment.


  I was hesitant about making this change before I committed it, so it's not a 
knee jerk reaction, but I also don't think it's important for me to land this 
quickly. I might want to see if I can come up with the real solution.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-showdesktop-minimizall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22359

To: ndavis, #vdg, #plasma, davidedmundson
Cc: davidedmundson, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Some users complained about the buttons being smaller or the size not being 
configurable when it previously was.
  
  Whatever you change some users will always complain. 
  It's important not to knee-jerk react based on some comments if they go 
against the general trend.
  
  Code-wise it's no worse than before your patches, so I'm happy to accept, but 
if you want to keep it as-is, I would support that too.
  
  Your call.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-showdesktop-minimizall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22359

To: ndavis, #vdg, #plasma, davidedmundson
Cc: davidedmundson, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22481: Do not show play/pause button when no media is playing

[Filip Fila]

filipf added a comment.


  In D22481#496040 , @davidedmundson 
wrote:
  
  > Why?
  
  
  Seconded, why does the plasmoid need to be empty? Note that other plasmoids 
also specify if some thing A is not available.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22481

To: shubham, broulik, #plasma, #vdg
Cc: filipf, ndavis, davidedmundson, #vdg, #plasma, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22861: [Kicker/Kickoff] Use better "Remove from Favorites" icon

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Don't use a minus, because there is no plus next to it.
  F7127189: Kickoff Remove from Favorites Icon.png 


TEST PLAN
  Open Kickoff and open the context menu of a favorite application item.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kicker-kickoff-use-better-remove-from-favorites-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22861

AFFECTED FILES
  applets/kicker/package/contents/ui/code/tools.js
  applets/kickoff/package/contents/ui/code/tools.js

To: GB_2, #vdg
Cc: plasma-devel, #vdg, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22858: [Notifications] Workaround NativeRendering with non-integer scaling

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e3035bbcebbf: [Notifications] Workaround NativeRendering 
with non-integer scaling (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22858?vs=62864=62865

REVISION DETAIL
  https://phabricator.kde.org/D22858

AFFECTED FILES
  applets/notifications/package/contents/ui/SelectableLabel.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[kezi]

kezik updated this revision to Diff 62863.
kezik added a comment.


  > Should it queue up a sound so that it plays one sound at the final volume 
when you've stopped dragging?
  
  I made that it plays the sound at the final volume when you release the mouse 
button

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22316?vs=61337=62863

REVISION DETAIL
  https://phabricator.kde.org/D22316

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/qml/volumefeedback.cpp

To: kezik, #plasma, drosca, davidedmundson
Cc: filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22858: [Notifications] Workaround NativeRendering with non-integer scaling

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since it is a custom `TextEdit` to make text selectable the workaround in the 
style didn't apply to it.

TEST PLAN
  Still works

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22858

AFFECTED FILES
  applets/notifications/package/contents/ui/SelectableLabel.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Depends on D22856 
  
  F7126794: Screenshot_20190731_164705.png 

  
  - Mirrored screens, unchecked checkbox, hit apply, dnd mode was exited.
  - checked checkbox again, dnd mode was entered again.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22857

AFFECTED FILES
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22856: Enable do not disturb mode when screens are mirrored

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When two screens overlap during e.g. a presentation, automatically enable do 
not disturb mode.
  As per usual with automatic do not disturb, it can be overruled by unchecking 
the checkbox in the notification plasmoid where it will be disabled until the 
screen configuration changes again and it still find a mirrored screen setup.

TEST PLAN
  - Hit Meta+P, chose "mirror", dnd was engaged, popups hid
  - Hit Meta+P again, chose "extend left", dnd was disabled
  - Changed setting, it enabled/disabled live accordingly
  
  F7126785: Screenshot_20190731_164642.png 

  
  Two questions:
  
  - Should this be enabled by default? Are there instances where you want to 
mirror but have notifications? Mind that you can still "one time" overrule this 
if you need them for once, until you change screen config again
  - Should the tooltip say anything, if so, what? We show "Do not disturb until 
$time" when a time is set but right now it doesn't say anything for mirrored 
screens. The applet icon changes to the crossed-out bell but the user has to 
click to find out what's going on.
  
  There will be a followup patch to add a checkbox to notifications KCM

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22856

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/mirroredscreenstracker.cpp
  libnotificationmanager/mirroredscreenstracker_p.h
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: broulik, #plasma, #vdg, dfaure
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

[Carson Black]

cblack updated this revision to Diff 62859.
cblack added a comment.


  Dump the rest of the colors.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22844?vs=62847=62859

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma
Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22122: use pwquality_strerror to get error strings

[Luigi Toscano]

ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  My bad, there were some typos in the value of the variable.
  
  I confirm that it works. +1 from the translation point of view.

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22122

To: sitter, #plasma, ltoscano
Cc: davidedmundson, ltoscano, anthonyfieroni, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22845: [GTK3] Convert all colors to use GTK color definitions

[Carson Black]

cblack updated this revision to Diff 62858.
cblack added a comment.


  Fix some issues with incorrect colors being used

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22845?vs=62825=62858

BRANCH
  colordefs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22845

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/build_theme.sh
  src/gtk-dark-3.18.css
  src/gtk-dark-3.20.css
  src/gtk-dark.css
  src/gtk3/gtk.scss
  src/gtk3/widgets/_app_notifications.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_button.scss
  src/gtk3/widgets/_calendar.scss
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_color_chooser.scss
  src/gtk3/widgets/_dialogs.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_lists.scss
  src/gtk3/widgets/_menus.scss
  src/gtk3/widgets/_misc.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_overshoot.scss
  src/gtk3/widgets/_pathbar.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_sidebar.scss
  src/gtk3/widgets/_spinbutton.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_toolbar.scss
  src/gtk3/widgets/_tooltips.scss
  src/gtk3/widgets/_treeview.scss
  src/gtk3/widgets/_window_decorations.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: cblack, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22122: use pwquality_strerror to get error strings

[Harald Sitter]

sitter added a comment.


  Is that with the latest diff (the one changed to fromUtf8)?
  
  LANGUAGE=uk seems to work for me F7126679: Screenshot_20190731_162607.png 


REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D22122

To: sitter, #plasma
Cc: davidedmundson, ltoscano, anthonyfieroni, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22122: use pwquality_strerror to get error strings

[Luigi Toscano]

ltoscano added a comment.


  Sorry, I totally missed the notifications (but I received them).
  
  I think that there is an encoding issue with any characters over the 
canonical 127 base ones. Observed with Italian and Ukrainian, see F7126642: 
user-manager-pwquality-it.png  and 
F7126646: user-manager-pwquality-uk.png .

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D22122

To: sitter, #plasma
Cc: davidedmundson, ltoscano, anthonyfieroni, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22738: Remove some uses on QDesktopWidget

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a8efa8653b09: Remove some uses on QDesktopWidget 
(authored by apol).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22738?vs=62725=62857

REVISION DETAIL
  https://phabricator.kde.org/D22738

AFFECTED FILES
  applets/pager/plugin/pagermodel.cpp
  containments/desktop/plugins/folder/foldermodel.cpp
  kcms/desktoppaths/globalpaths.cpp
  kcms/fonts/previewrenderengine.cpp

To: apol, #plasma, davidedmundson
Cc: hein, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

[David Redondo]

davidre added a comment.


  Sorry my bad, I misread the diff. I thought you added a new flag (as proposed 
above) and looked at `exportGtkTheme` but that flag is an existing one. And to 
my shame it doesn't even have a green background.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma
Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22589: Embrace X-KDE-Wayland-Interfaces

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e561df722bc1: Embrace X-KDE-Wayland-Interfaces (authored 
by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22589?vs=62771=62852

REVISION DETAIL
  https://phabricator.kde.org/D22589

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop
  krunner/krunner.desktop.cmake
  shell/CMakeLists.txt
  shell/org.kde.plasmashell.desktop
  shell/org.kde.plasmashell.desktop.cmake

To: apol, #plasma, #kwin, davidedmundson
Cc: davidedmundson, zzag, mvourlakos, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

[Carson Black]

cblack added a comment.


  In D22844#504691 , @davidre wrote:
  
  > It seems the header with the new flag is missing from the diff.
  
  
  I put it alongside the content in the existing `exportColors` flag because 
there's no reason to make a flag for exporting colors to something when there's 
already a flag for exporting colors to things.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma
Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

[David Redondo]

davidre added a comment.


  It seems the header with the new flag is missing from the diff.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma
Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21619: Wallpaper: delay calling UIReady until the image is actually loaded

[David Edmundson]

davidedmundson updated this revision to Diff 62849.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21619?vs=59259=62849

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21619

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

[Carson Black]

cblack updated this revision to Diff 62847.
cblack added a comment.


  Incorporate feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22844?vs=62819=62847

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22327: [libnotificationmanager] Port to lighter KProcessList

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  With D22471  does what it should

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22327

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Should it queue up a sound so that it plays one sound at the final volume 
when you've stopped dragging?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #plasma, drosca, davidedmundson
Cc: filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[Filip Fila]

filipf added a comment.


  Ah I can definitely reproduce it. I agree, it sounds  bad. +1 for fixing it.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #plasma, drosca
Cc: filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[kezi]

kezik added a comment.


  In D22316#503998 , @filipf wrote:
  
  > Removed VDG as the reviewer, seems like a technical issue all together.
  
  
  Sorry
  
  > Also wanted to contribute, but I don't really perceive any issues when 
moving the slider fast :/
  
  F7125871: 2019-07-31 13-17-48.mp4 
  This is what I am referring to
  
  F7125872: immagine.png 
  
  As you can see in the picture, the waveform of the feedback sound gets 
truncated in a "violent" way, and the abrupt truncation generates a broadband 
sound spike that's clearly audible
  Also, having the sound start and truncate 10 times when you move the slider a 
bit feels less polished 
  Maybe a better option is to have the sound play when you release the mouse 
button from the slider

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #plasma, drosca
Cc: filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22851: [SplitterProxy] Don't manually mapToGlobal

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The constructor of `QMouseEvent` actually expects `windowPos` and/or 
`screenPos` but never `globalPos`.
  By only supplying a `localPos` we have Qt figure it out correctly on its own.

TEST PLAN
  - I can now drag the vertical splitter in QtCreator on my second 4k monitor, 
previously it would just snap to its leftmost position once I started moving, 
as the mapped coordinates became negative
  - I still have the enlarged splitter drag area provided by Breeze compared to 
e.g. Fusion style

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22851

AFFECTED FILES
  kstyle/breezesplitterproxy.cpp

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22823: Restore Mouse Keyboard navigation accessibility feature

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:826dc413a9b7: Restore Mouse Keyboard navigation 
accessibility feature (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22823?vs=62783=62837

REVISION DETAIL
  https://phabricator.kde.org/D22823

AFFECTED FILES
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp

To: broulik, #plasma, schweingruber, rikmills, romangg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22832: Fix build with pango 1.44

[Harald Sitter]

sitter added a comment.


  Sure, don't take my bubbling to mean that I object to the diff. I'm just 
musing on it's long-term necessity
  
  When I dump the variables created by the initial PKG_CHECK_MODULES call in 
the finder they do have the requirements in the LIBRARIES and INCLUDES. So in 
point of fact I guess the entire finder is doing it wrong to begin with? ^^
  The reason it needs to reimplement the entire dependency lookup is because it 
uses the variables incorrectly. Out of the retrieved data from pkgconfig it 
constructs find_ calls of which (I guess) the find_path for includes is 
entirely moot because PC_GTK3_INCLUDE_DIRS is complete already, and the 
find_library call should loop over the names in PC_GTK3_LIBRARIES and find 
them. Actually I'm also right now looking at the FindPkgConfig and it looks 
like it has a IMPORTED_TARGET since 3.6, so if we were to bump the cmake 
requirements of plasma the entire finder could be shrunk down to the imported 
targets option which internally will cause findpkgconfig to do the find_library 
dance *and* set up neat targets we can use from the outside.
  
-- 
PC_GTK3_CFLAGS=-pthread;-I/usr/include/gtk-3.0;-I/usr/include/at-spi2-atk/2.0;-I/usr/include/at-spi-2.0;-I/usr/include/dbus-1.0;-I/usr/lib/x86_64-linux-gnu/dbus-1.0/include;-I/usr/include/gtk-3.0;-I/usr/include/gio-unix-2.0/;-I/usr/include/cairo;-I/usr/include/pango-1.0;-I/usr/include/harfbuzz;-I/usr/include/pango-1.0;-I/usr/include/atk-1.0;-I/usr/include/cairo;-I/usr/include/pixman-1;-I/usr/include/freetype2;-I/usr/include/libpng16;-I/usr/include/freetype2;-I/usr/include/libpng16;-I/usr/include/gdk-pixbuf-2.0;-I/usr/include/libpng16;-I/usr/include/glib-2.0;-I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-- PC_GTK3_CFLAGS_I=
-- PC_GTK3_CFLAGS_OTHER=-pthread
-- PC_GTK3_FOUND=1
-- PC_GTK3_INCLUDEDIR=/usr/include
-- 
PC_GTK3_INCLUDE_DIRS=/usr/include/gtk-3.0;/usr/include/at-spi2-atk/2.0;/usr/include/at-spi-2.0;/usr/include/dbus-1.0;/usr/lib/x86_64-linux-gnu/dbus-1.0/include;/usr/include/gtk-3.0;/usr/include/gio-unix-2.0/;/usr/include/cairo;/usr/include/pango-1.0;/usr/include/harfbuzz;/usr/include/pango-1.0;/usr/include/atk-1.0;/usr/include/cairo;/usr/include/pixman-1;/usr/include/freetype2;/usr/include/libpng16;/usr/include/freetype2;/usr/include/libpng16;/usr/include/gdk-pixbuf-2.0;/usr/include/libpng16;/usr/include/glib-2.0;/usr/lib/x86_64-linux-gnu/glib-2.0/include
-- 
PC_GTK3_LDFLAGS=-lgtk-3;-lgdk-3;-lpangocairo-1.0;-lpango-1.0;-latk-1.0;-lcairo-gobject;-lcairo;-lgdk_pixbuf-2.0;-lgio-2.0;-lgobject-2.0;-lglib-2.0
-- PC_GTK3_LDFLAGS_OTHER=
-- PC_GTK3_LIBDIR=/usr/lib/x86_64-linux-gnu
-- 
PC_GTK3_LIBRARIES=gtk-3;gdk-3;pangocairo-1.0;pango-1.0;atk-1.0;cairo-gobject;cairo;gdk_pixbuf-2.0;gio-2.0;gobject-2.0;glib-2.0
-- PC_GTK3_LIBRARY_DIRS=
-- PC_GTK3_LIBS=
-- PC_GTK3_LIBS_L=
-- PC_GTK3_LIBS_OTHER=
-- PC_GTK3_LIBS_PATHS=
-- PC_GTK3_PREFIX=/usr
  
  That's from the .pc file
  
prefix=/usr
exec_prefix=${prefix}
libdir=/usr/lib/x86_64-linux-gnu
includedir=${prefix}/include
targets=x11 broadway wayland

gtk_binary_version=3.0.0
gtk_host=x86_64-pc-linux-gnu

Name: GTK+
Description: GTK+ Graphical UI Library
Version: 3.22.30
Requires: gdk-3.0 atk >= 2.15.1 cairo >= 1.14.0 cairo-gobject >= 1.14.0 
gdk-pixbuf-2.0 >= 2.30.0 gio-2.0 >= 2.49.4
Requires.private: atk atk-bridge-2.0 wayland-client >= 1.9.91 
wayland-protocols >= 1.12 xkbcommon >= 0.2.0 wayland-cursor >= 1.9.91 
wayland-egl  epoxy >= 1.0 pangoft2 gio-unix-2.0 >= 2.49.4
Libs: -L${libdir} -lgtk-3 
Cflags: -I${includedir}/gtk-3.0 
~

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma
Cc: apol, sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22846: Port KeyboardLayout component to use generated DBus interface

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:18010b1a89c7: Port KeyboardLayout component to use 
generated DBus interface (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22846?vs=62823=62832

REVISION DETAIL
  https://phabricator.kde.org/D22846

AFFECTED FILES
  components/keyboardlayout/CMakeLists.txt
  components/keyboardlayout/keyboardlayout.cpp
  components/keyboardlayout/keyboardlayout.h
  components/keyboardlayout/org.kde.KeyboardLayouts.xml

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22847: [runners/kill] Port old style connects

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:edaa70cbdb34: [runners/kill] Port old style connects 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22847?vs=62826=62831

REVISION DETAIL
  https://phabricator.kde.org/D22847

AFFECTED FILES
  runners/kill/killrunner_config.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

[Kai Uwe Broulik]

broulik added a comment.


  Interesting approach!
  However, this doesn't seem to apply anything on first login?
  Maybe you want to extend the "rdb" thing instead:
  `runRdb(KRdbExportQtColors | KRdbExportGtkTheme | (m_applyToAlien ? 
KRdbExportColors : 0));` and add a `KRdbExportGtkCssColors` which then does all 
of that, given there's already a "Gtk Theme" in there.
  
  Overall I must say I'm not a fan of adding yet another place where we mess 
with GTK config files and would prefer someone write that centralized gtk 
settings daemon I proposed numerous times :) but I don't want to block this on 
a hypothetical idea that will probably never emerge...

INLINE COMMENTS

> colors.cpp:323
>  
> +QString gtkColorsHelper(QString name, QString color)
> +{

Pass by const-ref `const QString , ..`

> colors.cpp:325
> +{
> +return ("@define-color " + name + " " + color) + ";\n";
> +}

`return QStringLiteral("@define-color %1 %2").arg(name, color);\n"`;

> colors.cpp:454
>  
> +QFile gtkCss(QDir::homePath() + "/.config/gtk-3.0/gtk.css");
> +QFile colorsCss(QDir::homePath() + "/.config/gtk-3.0/colors.css");

You probably want to be using 
`QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation)` or 
something along the lines instead of hardcoding `~/.config`

> colors.cpp:458
> +if (gtkCss.open(QIODevice::ReadWrite))
> +{
> +QTextStream gtkStream();

Coding style, brace on same line as `if`

> colors.cpp:471
> +}
> +if (colorsCss.open(QIODevice::ReadWrite | QIODevice::Truncate)) {
> +QTextStream colorsStream();

Not just `WriteOnly`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart