D22874: Remove the ShellManager

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d754abbc4799: Remove the ShellManager (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22874?vs=62898=62957

REVISION DETAIL
  https://phabricator.kde.org/D22874

AFFECTED FILES
  shell/CMakeLists.txt
  shell/main.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/shellmanager.cpp
  shell/shellmanager.h

To: apol, #plasma, davidedmundson, bshah
Cc: bshah, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Nathaniel Graham]

ngraham added a comment.


  In D21815#490482 , @filipf wrote:
  
  > Might be better to just follow current style; updating it to the new one 
would be a quick review.
  
  
  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM

[David Edmundson]

davidedmundson updated this revision to Diff 62956.
davidedmundson added a comment.


  update
  
  Updating D22885: Add global animation speed slider to workspace options KCM
  ===
  
  GNU nano 4.3
  /tmp/edit.fd801hu0c34so8k8/new-commit
  Modified
  Add global animation speed slider to workspace options KCM

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22885?vs=62949=62956

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22885

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18920: Fix PCI module

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:8056039c7947: Fix PCI module (authored by konradr, 
committed by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18920?vs=61562=62955

REVISION DETAIL
  https://phabricator.kde.org/D18920

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22369: Update and add some device names in PCI module

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:ed789f56fc69: Update and add some device names in PCI 
module (authored by konradr, committed by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22369?vs=61498=62954

REVISION DETAIL
  https://phabricator.kde.org/D22369

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[kezi]

kezik added a comment.


  In D22316#505466 , @ngraham wrote:
  
  > With this change, if I press the volume up and volume down key on my 
keyboard, feedback only plays every second or third time I hit the button 
(depending on how fast I press it).
  
  
  True
  
  For some reason, if I measure the amount of time that it takes for 
ca_context_playing to switch back from 1 to 0, by busy waiting, it blocks for 
about two seconds, even though the actual sound lasts about 0.07 seconds
  With the volume slider, for some other reason, the ca_context_playing goes 
back to 0 sooner, but with the volume keys it blocks the whole two seconds.
  
  I have no idea on why it does that

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #plasma, drosca, davidedmundson, ngraham
Cc: filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22876: [Breeze-GTK] Merge gtk320 and gtk318 into gtk3

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  gtk-320-318-merge (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22876

To: cblack, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Introduce a new config entry into kdeglobals AnimationSpeed that will
  control /all/ animation speeds in kwin and plasma themes and Qt styles
  and kirigami.
  
  The value stored is a multiplier.
  i.e 1 == normal speed, 0.5 = twice as fast, 2 = twice as slow.
  0 is a special value meaning "disable animations"
  
  The QML is a bit complex to represent a logarithmic slider that goes
  4x, 2x, 1x, 0.5x, 0.25x, 0.125x
  
  but still allowing a user to type arbitrary values into their config
  
  -
  
  Note @kbroulik This is reversed it from what we coded together, because
  I decided it was confusing.
  
  Needs relevant patches through the rest of the stack before merging.
  Also kwin has some asserts on 0 speed animations that need addressing.
  
  You also need an up-to-date kconfig and qqc2-desktop-style for bugfixes

TEST PLAN
  Looked at config

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22885

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22533: [KCM] Slightly improve tab bar's integration with frame

[Nathaniel Graham]

ngraham added a comment.


  It's already in a comment above. :)

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  slightly-better-tab-bar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22533

To: ngraham, drosca, #vdg, filipf
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22533: [KCM] Slightly improve tab bar's integration with frame

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:941790a0e49d: [KCM] Slightly improve tab bars 
integration with frame (authored by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22533?vs=61993=62947

REVISION DETAIL
  https://phabricator.kde.org/D22533

AFFECTED FILES
  src/kcm/package/contents/ui/main.qml

To: ngraham, drosca, #vdg, filipf
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 added a comment.


  Also notice that the current aspect doesn't look good nor consistent with the 
rest of Plasma.
  In my researches I found this: 
https://git.reviewboard.kde.org/r/121698/diff/1/#, which is a bit what I'm 
doing. I'll stop with this until an agreement is found.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22616: Remove phonon KCM

[Nathaniel Graham]

ngraham added a comment.


  @sitter can you post your patch with that?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22616

To: nicolasfella, sitter
Cc: ngraham, pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5c0ec75f7ce1: [kcms/nightcolor] Minor UI tweaks to the 
KCM (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22863?vs=62875=62946

REVISION DETAIL
  https://phabricator.kde.org/D22863

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf, #plasma, #vdg, ngraham
Cc: zzag, romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

[Nathaniel Graham]

ngraham added a comment.


  Hmm, this requires that the user makes the mental connection between "screens 
are mirrored" and "I'm delivering a presentation". Also, that mapping is not 
100%; LibreOffice Impress even discourages using mirrored displays because when 
you use extended mode instead, the presenter's display can show notes that the 
audience doesn't see.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22857

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  With this change, if I press the volume up and volume down key on my 
keyboard, feedback only plays every second or third time I hit the button 
(depending on how fast I press it).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #plasma, drosca, davidedmundson, ngraham
Cc: filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22882: [Energy] Improve signal-to-noise ratio of battery information

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  Ah OK. I had a feeling someone would complain and explain what all the extra 
info was for. I'll come up with some changes that preserve this information 
when it's relevant, and clean up the display.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22882

To: ngraham, #vdg, #plasma, broulik
Cc: kpiwowarski, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22882: [Energy] Improve signal-to-noise ratio of battery information

[Kamil Piwowarski]

kpiwowarski added a comment.


  Please don't remove that info, it's useful for me.
  
  F7135831: image.png 

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22882

To: ngraham, #vdg, #plasma, broulik
Cc: kpiwowarski, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22882: [Energy] Improve signal-to-noise ratio of battery information

[Filip Fila]

filipf added a comment.


  F7135822: image.png 
  
  I check up on //Full Design// to track precise wear, and the //Capacity// is 
also pretty standard info and useful.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22882

To: ngraham, #vdg, #plasma, broulik
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22882: [Energy] Improve signal-to-noise ratio of battery information

[Filip Fila]

filipf added a comment.


  I think what Capacity means is how worn out your battery has become. Yours 
can still take the full charge so it's at 100% (jealous).
  
  All this info is useful for me, for instance, because I have a shoddy battery 
and I check up on this data from time to time.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22882

To: ngraham, #vdg, #plasma, broulik
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Nathaniel Graham]

ngraham added a comment.


  Hmm, if the existing menu is provided by Qt, changes might need to be made 
upstream. :/ I wonder if there's a way to inject new items into it though, 
without creating an entirely new one?
  
  Hopefully #plasma  people should be 
able to answer those questions.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22879: Rename "Look and Feel" KCM to "Global Theme"

[Nathaniel Graham]

ngraham updated this revision to Diff 62943.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Address review comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22879?vs=62936=62943

BRANCH
  lnf-to-global (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22879

AFFECTED FILES
  kcms/lookandfeel/autotests/lookandfeel/metadata.desktop
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/lnftool.cpp
  kcms/lookandfeel/lookandfeel.knsrc
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22879: Rename "Look and Feel" KCM to "Global Theme"

[Nathaniel Graham]

ngraham added a comment.


  I'd like to get some #plasma  
opinions on this, since it is a fairly user-visible change.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  lnf-to-global (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22879

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> GB_2 wrote in KNSBackend.cpp:214
> I think we can use the icon `plugins` here.

Submit a patch! :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D22716

To: leinir, #discover_software_store, #vdg, ngraham, apol
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22882: [Energy] Improve signal-to-noise ratio of battery information

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The Battery information shows a lot of redundant and confusing information, 
making
  it hard to get the information you're interested in at a glance. In 
particular,
  "Capacity" is confusing because for me it's always 100%, contradicting other 
info
  displayed there. And the "last full" and "full design" always display the 
same values.
  I have removed them, and improved the total capacity text.

TEST PLAN
  Before: F7135750: Before.png 
  After: F7135749: After.png 

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22882

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22783: Fix ambiguous "Current" label in energy information

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:d5268f926798: Fix ambiguous Current label in 
energy information (authored by aloisw, committed by ngraham).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22783?vs=62669=62941

REVISION DETAIL
  https://phabricator.kde.org/D22783

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: aloisw, #plasma, #vdg, broulik, filipf, ngraham
Cc: aspotashev, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 added a comment.


  I started to reimplement the menu. This is how it looked for me:
  
  F7135687: Screenshot_20190801_223211.png 

  
  this is how a new menu would look like (some items and shortcuts are missing):
  
  F7135723: shot.png 
  
  Do you think I'm on the right track? Or do you think it is possible to add an 
item to the previous menu somehow? Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:09598972736b: Show about distro KCM in System 
Settings System Administration category (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22742?vs=62560=62940#toc

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22742?vs=62560=62940

REVISION DETAIL
  https://phabricator.kde.org/D22742

AFFECTED FILES
  Modules/about-distro/src/about-distro.desktop

To: ngraham, #vdg, #plasma, filipf, GB_2
Cc: mthw, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Did D22742  instead.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22879: Rename "Look and Feel" KCM to "Global Theme"

[Björn Feber]

GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.
This revision is now accepted and ready to land.


  We should probably also change the name in the KDE Store and Look and Feel 
Explorer.

INLINE COMMENTS

> metadata.desktop:2
>  [Desktop Entry]
> -Comment=Test Look and Feel package
> +Comment=Test global look and feel package
>  Comment[ast]=Paquete d'aspeutu y sentir de prueba

"Test global theme package" or maybe "Test global look and feel"

> lnftool.cpp:42
>  // About data
> -KAboutData aboutData("lookandfeeltool", i18n("Look and feel tool"), 
> version, i18n("Command line tool to apply look and feel packages."), 
> KAboutLicense::GPL, i18n("Copyright 2017, Marco Martin"));
> +KAboutData aboutData("lookandfeeltool", i18n("Global Theme tool"), 
> version, i18n("Command line tool to apply global theme packages for changing 
> the look and feel."), KAboutLicense::GPL, i18n("Copyright 2017, Marco 
> Martin"));
>  aboutData.addAuthor(i18n("Marco Martin"), i18n("Maintainer"), 
> QStringLiteral("m...@kde.org"));

Uppercase T in "tool" while at it :-)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  lnf-to-global (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22879

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf updated this revision to Diff 62938.
filipf added a comment.


  use 2px instead of 1px of padding

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20972?vs=62937=62938

BRANCH
  sidebarview-padding-nitpick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20972

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Nathaniel Graham]

ngraham added a comment.


  Well it's all about making sure the top, bottom, and right paddings are 
identical. If Discover's search field also needs adjustment, that's fine.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf added a comment.


  @ngraham I forgot about RTL, my bad.
  
  I ended up using the margins approach because adding an Item also added row 
layout's inherent spacing which ended up in too big of a margin.
  
  And when compared with Discover, it turns out the margin needs to be only 
1px, not 2px.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf added a comment.


  2px looks better to me as well, let's add 1px more to the margin in Discover 
then?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Nathaniel Graham]

ngraham added a comment.


  Cool. But trying this out... are you sure 1 is enough? To my eyes, 2 looks 
better:
  
  F7135618: Screenshot_20190801_144149.png 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf updated this revision to Diff 62937.
filipf added a comment.


  watch out for RTL

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20972?vs=57408=62937

BRANCH
  sidebarview-padding-nitpick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20972

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D22879: Rename "Look and Feel" KCM to "Global Theme"

[Nathaniel Graham]

ngraham updated this revision to Diff 62936.
ngraham added a comment.


  Make "look and feel" a description rather than a product name

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22879?vs=62925=62936

BRANCH
  lnf-to-global (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22879

AFFECTED FILES
  kcms/lookandfeel/autotests/lookandfeel/metadata.desktop
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/lnftool.cpp
  kcms/lookandfeel/lookandfeel.knsrc
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22871: Use better Workspace Behavior KCM title and icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:acddedf0bb1d: Use better Workspace Behavior KCM title and 
icon (authored by Bjrn Feber bfe...@protonmail.com, committed by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22871?vs=62933=62935

REVISION DETAIL
  https://phabricator.kde.org/D22871

AFFECTED FILES
  doc/kcontrol/workspaceoptions/index.docbook
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp

To: GB_2, #plasma, #vdg, filipf, ngraham
Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22075: [Notifications] Swap configure and clear buttons in full representation header

[Nathaniel Graham]

ngraham added a comment.


  In retrospect, while this makes it consistent with what's below it, it's now 
inconsistent with all the other system tray pop-ups, which put their Settings 
button all the way over to the right.
  
  Hmm.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22075

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22871: Use better Workspace Behavior KCM title and icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Ah right. Okay, this is fine then.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22871

To: GB_2, #plasma, #vdg, filipf, ngraham
Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22871: Use better Workspace Behavior KCM title and icon

[Björn Feber]

GB_2 updated this revision to Diff 62933.
GB_2 added a comment.


  Drop word "the" in descriptions

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22871?vs=62930=62933

BRANCH
  use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22871

AFFECTED FILES
  doc/kcontrol/workspaceoptions/index.docbook
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp

To: GB_2, #plasma, #vdg, filipf, ngraham
Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22871: Use better Workspace Behavior KCM title and icon

[Björn Feber]

GB_2 added a comment.


  In D22871#505360 , @ngraham wrote:
  
  > If we're going to make it "General", do we even need the word "Behavior" in 
there? It's implied by its category, no? I suppose there would be no visible 
parent category when running in kcmshell, but that doesn't seem like the hugest 
problem to me.
  
  
  It's also the title shown in Kickoff/KRunner/etc.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22871

To: GB_2, #plasma, #vdg, filipf
Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22871: Use better Workspace Behavior KCM title and icon

[Nathaniel Graham]

ngraham added a comment.


  If we're going to make it "General", do we even need the word "Behavior" in 
there? It's implied by its category, no? I suppose there would be no visible 
parent category when running in kcmshell, but that doesn't seem like the hugest 
problem to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22871

To: GB_2, #plasma, #vdg, filipf
Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22871: Use better Workspace Behavior KCM title and icon

[Filip Fila]

filipf accepted this revision as: filipf.
filipf added a comment.
This revision is now accepted and ready to land.


  Looks OK, along with these two inline comments I'd also add some reasoning 
for the change to the commit message.

INLINE COMMENTS

> index.docbook:28
>  
> -This is a module to configure global options for the  
> workspace.
> +This is a module to configure the general workspace behavior.
>  

I'd drop the "the"

> workspaceoptions.cpp:42
> QStringLiteral("1.1"),
> -   i18n("System Settings module for 
> managing global options for the Plasma Workspace."),
> +   i18n("System Settings module for 
> configuring the general workspace behavior."),
> KAboutLicense::GPL);

I'd drop the "the"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22871

To: GB_2, #plasma, #vdg, filipf
Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19947: systray: show a small animation on the icons when activated

[Filip Fila]

filipf added a comment.


  The effect doesn't always work for me.
  
  F7135314: systrayclick-2019-08-01_21.59.41 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19947_1

REVISION DETAIL
  https://phabricator.kde.org/D19947

To: apol, #plasma, ngraham
Cc: filipf, broulik, anthonyfieroni, davidedmundson, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> ngraham wrote in plasma-themes.knsrc:42
> > The KDE Store category name should probably be updated too.
> 
> You mean here? What does this actually do?

I mean in the actual store online :-)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasma-theme-to-plasma-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Nathaniel Graham]

ngraham added a subscriber: leinir.
ngraham added inline comments.

INLINE COMMENTS

> plasma-themes.knsrc:42
>  ProvidersUrl=https://download.kde.org/ocs/providers.xml
>  Categories=Plasma Theme
>  StandardResource=tmp

> The KDE Store category name should probably be updated too.

You mean here? What does this actually do?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasma-theme-to-plasma-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Björn Feber]

GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.
This revision is now accepted and ready to land.


  The KDE Store category name should probably be updated too.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasma-theme-to-plasma-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22871: Use better Global Workspace Behavior KCM title and icon

[Björn Feber]

GB_2 updated this revision to Diff 62930.
GB_2 added a comment.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.


  Use name "General Behavior"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22871?vs=62892=62930

BRANCH
  use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22871

AFFECTED FILES
  doc/kcontrol/workspaceoptions/index.docbook
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp

To: GB_2, #plasma, #vdg
Cc: kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19947: systray: show a small animation on the icons when activated

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19947_1

REVISION DETAIL
  https://phabricator.kde.org/D19947

To: apol, #plasma, ngraham
Cc: filipf, broulik, anthonyfieroni, davidedmundson, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22871: Use better Global Workspace Behavior KCM title and icon

[Björn Feber]

GB_2 added a comment.


  In D22871#505311 , @ngraham wrote:
  
  > Hmm, seems a little bit long to me. Maybe just, "Global Behavior"? Or even 
just, "General"? It's already in a section with the word "Behavior" in it, 
after all.
  
  
  I'll name it "General".
  
  > Also, does the docbook need to be updated?
  
  Seems like it, will do that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22871

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=374311

Nate Graham  changed:

   What|Removed |Added

 Resolution|UPSTREAM|DUPLICATE

--- Comment #6 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 410493 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification-count-no-overflow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22878

To: filipf, broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22871: Use better Global Workspace Behavior KCM title and icon

[Nathaniel Graham]

ngraham added a comment.


  Hmm, seems a little bit long to me. Maybe just, "Global Behavior"? Or even 
just, "General"? It's already in a section with the word "Behavior" in it, 
after all.
  
  Also, does the docbook need to be updated?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22871

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22851: [SplitterProxy] Don't manually mapToGlobal

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Thanks for the fix ! 
  Oxygen needs the same patch. Will you also push it there ?
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22851

To: broulik, #plasma, hpereiradacosta, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This implements one of the changes decided upon in T11314 
. The rationale is as follows:
  
  We don't call anything else a "Theme" in the appearance section; we use the 
word "style"
  if we have to use anything, preferring to not use any word at all. Since the 
app
  settings use "Style", we should do the same thing for the contrasting Plasma 
setting.

TEST PLAN
  F7134998: Plasma Style.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasma-theme-to-plasma-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22880

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/index.docbook
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop
  kcms/desktoptheme/plasma-themes.knsrc

To: ngraham, #vdg, #plasma
Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22879: Rename "Look and Feel" KCM to "Global Theme"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This implements one of the changes decided upon in T11314 
. The rationale is as follows:
  
  The old text ("Look and Feel") is a generic term and could be referring to 
any of the
  other appearance settings. The new text "Global Theme" is more descriptive 
and accurate
  and makes this KCM's relationship to everything else clear.

TEST PLAN
  TODO

REPOSITORY
  R119 Plasma Desktop

BRANCH
  lnf-to-global (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22879

AFFECTED FILES
  kcms/lookandfeel/autotests/lookandfeel/metadata.desktop
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/lnftool.cpp
  kcms/lookandfeel/lookandfeel.knsrc
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

[Filip Fila]

filipf updated this revision to Diff 62923.
filipf added a comment.


  better code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22878?vs=62911=62923

BRANCH
  notification-count-no-overflow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22878

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: filipf, broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> CompactRepresentation.qml:97
>  anchors.centerIn: parent
> -width: Math.round(Math.min(parent.width, parent.height) * 0.75)
> +width: text.length > 1 ? Math.round(Math.min(parent.width, 
> parent.height) * 0.67) : Math.round(Math.min(parent.width, parent.height) * 
> 0.75)
>  height: width

Can you rearrange that a bit

  width: Math.round(Math.min(parent.width, parent.height) * (text.length > 1 ? 
0.67 : 0.75))`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22878

To: filipf, broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

[David Edmundson]

davidedmundson added a comment.


  > but it doesn't make sense to me that Splash Screen will be in Appearance, 
while Login Screen (SDDM) will be in Startup and Shutdown.
  
  The problem that needs resolving there is SDDM KCM also does autologin and 
configuring UIDs to list.
  So you have a split between functional and appearance in one KCM.
  
  It's the fundamental problem with most our KCMs - we group at a top-level by 
category, but internally KCMs individually are grouped by code location. Whilst 
we have that state, no top-level is correct and no moving will fix it.
  
  It's why there is a rule (which still remains!) stopping moving KCMs about at 
a top level without first doing any of the useful work that needs to happen 
from the bottom up inside the KCM.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18417: Adjust and remove some top-level categories to implement new Appearance section layout

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:b4bd5b465511: Adjust and remove some top-level categories 
to implement new Appearance section… (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18417?vs=49966=62922#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18417?vs=49966=62922

REVISION DETAIL
  https://phabricator.kde.org/D18417

AFFECTED FILES
  categories/CMakeLists.txt
  categories/settings-appearance-applicationstyle.desktop
  categories/settings-appearance-font.desktop
  categories/settings-appearance-icons.desktop
  categories/settings-appearance-workspacetheme.desktop

To: ngraham, #vdg, #plasma, davidedmundson, GB_2
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:c9f7aaa0765c: Rename Desktop Behavior 
category to Workspace Behavior (authored by GB_2).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22872?vs=62893=62919

REVISION DETAIL
  https://phabricator.kde.org/D22872

AFFECTED FILES
  categories/settings-workspace-desktopbehavior.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:09a64755e18d: Move KCMs in Workspace Theme to 
more appropriate locations (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18419?vs=62916=62918

REVISION DETAIL
  https://phabricator.kde.org/D18419

AFFECTED FILES
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/ksplash/kcm_splashscreen.desktop

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  In D18419#505221 , @ngraham wrote:
  
  > In D18419#505214 , @filipf wrote:
  >
  > > +1 regarding the //Cursor Theme// and //Plasma Theme//, but it doesn't 
make sense to me that //Splash Screen// will be in **Appearance**, while 
//Login Screen (SDDM)// will be in **Startup and Shutdown**.
  >
  >
  > I guess we have a small conflict then when something is both purely 
appearance-based, but also fits into multiple categories. The Splash Screen, 
Plymouth, and the SDDM KCMs all fit the bill. My gut tells me that you're right 
and all three should live in Startup and Shutdown just based on frequency of 
use.
  
  
  Yeah, it can fit into multiple categories and we don't have usage data, but I 
would bet they don't get interacted with as much as Appearance KCMs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

[Nathaniel Graham]

ngraham updated this revision to Diff 62916.
ngraham added a comment.


  Don't change "Plasma Theme" string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18419?vs=62914=62916

REVISION DETAIL
  https://phabricator.kde.org/D18419

AFFECTED FILES
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/ksplash/kcm_splashscreen.desktop

To: ngraham, #vdg, #plasma
Cc: filipf, GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

[Nathaniel Graham]

ngraham updated this revision to Diff 62914.
ngraham retitled this revision from "Move KCMs in "Workspace Theme" up one 
level" to "Move KCMs in "Workspace Theme" to more appropriate locations".
ngraham added a comment.


  Put the splash screen KCM in {Startup and Shutdown}

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18419?vs=62909=62914

REVISION DETAIL
  https://phabricator.kde.org/D18419

AFFECTED FILES
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/ksplash/kcm_splashscreen.desktop

To: ngraham, #vdg, #plasma
Cc: filipf, GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18419: Move KCMs in "Workspace Theme" up one level

[Nathaniel Graham]

ngraham added a comment.


  In D18419#505214 , @filipf wrote:
  
  > +1 regarding the //Cursor Theme// and //Plasma Theme//, but it doesn't make 
sense to me that //Splash Screen// will be in **Appearance**, while //Login 
Screen (SDDM)// will be in **Startup and Shutdown**.
  >
  > I'd put //Splash Screen// into **Startup and Shutdown**, it's a distinctly 
startup thing.  My just be my 2 cents, but I also don't consider it that 
important (=often changed) of a setting that would warrant putting it somewhere 
close to the top and being top level.
  
  
  I guess we have a small conflict then when something is both purely 
appearance-based, but also fits into multiple categories. The Splash Screen, 
Plymouth, and the SDDM KCMs all fit the bill. My gut tells me that you're right 
and all three should live in Startup and Shutdown just based on frequency of 
use.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma
Cc: filipf, GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18419: Move KCMs in "Workspace Theme" up one level

[Filip Fila]

filipf added a comment.


  +1 regarding the //Cursor Theme// and //Plasma Theme//, but it doesn't make 
sense to me that //Splash Screen// will be in **Appearance**, while //Login 
Screen (SDDM)// will be in **Startup and Shutdown**.
  
  I'd put //Splash Screen// into **Startup and Shutdown**, it's a distinctly 
startup thing.  My just be my 2 cents, but I also don't consider it that 
important (=often changed) of a setting that would warrant putting it somewhere 
close to the top and being top level.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma
Cc: filipf, GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a99c14d1eac9: Consistently use Units.toolTipDelay instead 
of hardcoded values (authored by hein).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22867?vs=62879=62912

REVISION DETAIL
  https://phabricator.kde.org/D22867

AFFECTED FILES
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ForwardButton.qml

To: hein, #frameworks, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  Ping @davidedmundson

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  When the notification count is in double digits, the numbers can overflow the 
icons which is meant to contain them.
  
  This patch checks if there is more than 1 digit and then slightly reduces the 
size of the numbers.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification-count-no-overflow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22878

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22874: Remove the ShellManager

[Bhushan Shah]

bshah accepted this revision.
bshah added a comment.


  Please also remove loader.qml from shell packages I guess.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22874

To: apol, #plasma, davidedmundson, bshah
Cc: bshah, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18419: Move KCMs in "Workspace Theme" up one level

[Nathaniel Graham]

ngraham updated this revision to Diff 62909.
ngraham retitled this revision from "Adjust some KCMs to implement new 
Appearance section layout" to "Move KCMs in "Workspace Theme" up one level".
ngraham edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18419?vs=49968=62909

REVISION DETAIL
  https://phabricator.kde.org/D18419

AFFECTED FILES
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/ksplash/kcm_splashscreen.desktop

To: ngraham, #vdg, #plasma
Cc: GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

[David Edmundson]

davidedmundson resigned from this revision.
davidedmundson added a comment.


  My opinion on top-down "lets shuffle things" remains the same.
  
  However, I am happy to approve iterative changes. I can see how this is a 
prerequisite to renaming "Workspace Theme" which seems to make sense, given 
it's not under the group workspace, and we're sending mixed messages.
  
  I don't object to this particular patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma
Cc: GB_2, abetts, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D22876: [Breeze-GTK] Merge gtk320 and gtk318 into gtk3

[Nathaniel Graham]

ngraham added a comment.


  Not being an expert in this code or familiar with the history here, it would 
be helpful if you added a bit more information to the Description section. 
Specifically, why this split existed in the first place, the function it once 
served, why it's no longer necessary today, and any visual changes (if any) 
that result from this patch.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22876

To: cblack, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22874: Remove the ShellManager

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  The desktop loader has been broken since before 5.0, I think it's a classic 
example of building something too early.
  
  We can always revert if we find a usage later. Go for it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22874

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22845: [GTK3] Convert all colors to use GTK color definitions

[Filip Fila]

filipf added a comment.


  This is going to be fantastic, agreed on splitting up the patch.
  
  "There are some other minor changes (radio buttons/checkboxes now sink in 
when clicking as their Qt counterparts do.)" - this should also be a separate 
patch

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22845

To: cblack, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> zzag wrote in main.qml:118
> There are some technical terms that should stay "technical," "color 
> temperature" is one of those.

I think using the technical term here is fine. IIRC f.lux tried to simplify 
this by adding a bunch of descriptors which compared a particular temperature 
value or even range to a lighting condition, e.g. one generated by incandescent 
bulbs. But I don't think we need this, users will figure it out.

Regarding using uppercase c in "Night Color", that's 2 in favor and 2 against 
it. We had this dilemma with "Look and Feel" before and kept "Feel" capitalized 
because it's the name of a specific feature I guess. I'm not super passionate 
about what we choose, but I slightly lean towards leaving "Color" capitalized 
for now. That okay?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-kcm-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: zzag, romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22845: [GTK3] Convert all colors to use GTK color definitions

[Carson Black]

cblack added a comment.


  In D22845#505092 , @ngraham wrote:
  
  > Hmm, now you've removed the 3.18 and 3.20 versions entirely in favor of a 
single 3.0 version. This change seems like it should be done in a separate 
patch.
  
  
  Closing this to reorganize revisions.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22845

To: cblack, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22876: [Breeze-GTK] Merge gtk320 and gtk318 into gtk3

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  GTK 3.20 and GTK 3.18 are now merged into a single GTK 3.0 directory. This 
will reduce work needed in the future for maintenance and updates.

TEST PLAN
  See that themes work properly.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  gtk-320-318-merge (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22876

AFFECTED FILES
  src/CMakeLists.txt
  src/build_theme.sh
  src/gtk-dark-3.0.css
  src/gtk-dark-3.18.css
  src/gtk-dark-3.20.css
  src/gtk3/gtk.scss
  src/gtk3/widgets/_app_notifications.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_button.scss
  src/gtk3/widgets/_calendar.scss
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_color_chooser.scss
  src/gtk3/widgets/_dialogs.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_lists.scss
  src/gtk3/widgets/_menus.scss
  src/gtk3/widgets/_misc.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_overshoot.scss
  src/gtk3/widgets/_pathbar.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_sidebar.scss
  src/gtk3/widgets/_spinbutton.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_toolbar.scss
  src/gtk3/widgets/_tooltips.scss
  src/gtk3/widgets/_treeview.scss
  src/gtk3/widgets/_window_decorations.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: cblack, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, I agree.

REPOSITORY
  R124 System Settings

BRANCH
  rename-desktop-behavior-category-to-workspace-behavior (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22872

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R258:894f6706afef: Improve the look of the Plymouth Boot 
Splash Screen KCM UI (authored by GB_2).

REPOSITORY
  R258 Plymouth KCM

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20549?vs=62899=62900

REVISION DETAIL
  https://phabricator.kde.org/D20549

AFFECTED FILES
  src/helper.cpp
  src/kcm.cpp
  src/kcm.h
  src/kcm_plymouth.desktop
  src/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: davidedmundson, abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 62899.
GB_2 added a comment.


  Clean up debug messages

REPOSITORY
  R258 Plymouth KCM

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20549?vs=62050=62899

BRANCH
  arcpatch-D20549

REVISION DETAIL
  https://phabricator.kde.org/D20549

AFFECTED FILES
  src/helper.cpp
  src/kcm.cpp
  src/kcm.h
  src/kcm_plymouth.desktop
  src/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: davidedmundson, abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D22874: Remove the ShellManager

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  We had an overly complex and in practice unexploited system to detect
  which shell to use,
  This patch changes it to default to the desktop, still allowing to
  modify which to use from --shell-plugin argument.

TEST PLAN
  Starts up fine, --shell-plugin/-p still works, which is what
  bhushan told me is important for plasma mobile.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22874

AFFECTED FILES
  shell/CMakeLists.txt
  shell/main.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/shellmanager.cpp
  shell/shellmanager.h

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22845: [GTK3] Convert all colors to use GTK color definitions

[Nathaniel Graham]

ngraham added a comment.


  Hmm, now you've removed the 3.18 and 3.20 versions entirely in favor of a 
single 3.0 version. This change seems like it should be done in a separate 
patch.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22845

To: cblack, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22869: [Converter Runner] Support fractional units

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:6f1cadb5882c: [Converter Runner] Support fractional units 
(authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22869?vs=62887=62896

REVISION DETAIL
  https://phabricator.kde.org/D22869

AFFECTED FILES
  runners/converter/converterrunner.cpp

To: broulik, #plasma, kossebau, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22869: [Converter Runner] Support fractional units

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  OMG, this is great stuff! Works great, and code looks sane. I couldn't find 
any regressions in my testing.
  
  Next, the real trick will be to combine this with calculation support so you 
can do `5/8" + 3/16"`. :-)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22869

To: broulik, #plasma, kossebau, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:118
> "Night Color" is the name of the feature itself; you can't truncate it to 
> save a few words. I think it also needs to keep its capitalization.
> 
> If you're looking to change the string, I would focus on the word 
> "temperature." Regular people think of "temperature" as something having to 
> do with heat and cold, not colors. Only artists and computer experts 
> generally understand that colors can have a temperature.

There are some technical terms that should stay "technical," "color 
temperature" is one of those.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-kcm-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: zzag, romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> GB_2 wrote in main.qml:118
> Agreed.

"Night Color" is the name of the feature itself; you can't truncate it to save 
a few words. I think it also needs to keep its capitalization.

If you're looking to change the string, I would focus on the word 
"temperature." Regular people think of "temperature" as something having to do 
with heat and cold, not colors. Only artists and computer experts generally 
understand that colors can have a temperature.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-kcm-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: zzag, romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol
Cc: nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> zzag wrote in main.qml:118
> but it depends on how you look at it. "Night color temperature" might be a 
> better string. As it speaks about color temperature and not temperature of 
> "Night Color."

Agreed.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-kcm-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: zzag, romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  "Desktop" to users means the desktop folder, so use a more appropriate name 
for this category.

TEST PLAN
  Open the system settings.

REPOSITORY
  R124 System Settings

BRANCH
  rename-desktop-behavior-category-to-workspace-behavior (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22872

AFFECTED FILES
  categories/settings-workspace-desktopbehavior.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22871: Use better Global Workspace Behavior KCM title and icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Consistently call the KCM "Global Workspace Behavior" and use 
`preferences-desktop` as the icon
  F7132843: Better Global Workspace Behavior KCM Title and Icon.png 


TEST PLAN
  Open the Global Workspace Behavior KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22871

AFFECTED FILES
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/package/metadata.desktop
  kcms/workspaceoptions/workspaceoptions.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in main.qml:118
> Just my 2 cents: you can simplify this string to "Night temperature." Not 
> sure whether translators will like this change though.

but it depends on how you look at it. "Night color temperature" might be a 
better string. As it speaks about color temperature and not temperature of 
"Night Color."

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-kcm-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: zzag, romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in main.qml:118
> I would leave it with the capital C since it's part of the name.

Just my 2 cents: you can simplify this string to "Night temperature." Not sure 
whether translators will like this change though.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-kcm-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: zzag, romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[System Tray]

[Konrad Materka]

Hi,

recently I was fixing two bugs related to SystemTray (in review:
https://phabricator.kde.org/D22804,
https://phabricator.kde.org/D22767). I noticed that code is highly
coupled and "fragile" with some unclear references like:
item.parent.parent.attrbute etc. Items are imperatively assigned to
different parents depending on the status.

I would like to add one meta-model with all items (both
SystemNotifications and plasmoids) plus Delegate Model(s) with groups:
* active
* passive/hidden
* disabled etc
and additional sorting:
* notification always as first
* other rules possible

That model will allow:
* better separation between data and view, it is additional abstract
layer between backend data (SystemNotifications model + plasmoids
list) and current view.
* ability to filter/sort/group easily - no need for
plasmoid.nativeInterface.reorderItemAfter
* clear information about the model used in active/hidden containers
* easier implementation of new features like ordering, even with drag
and drop  (https://bugs.kde.org/show_bug.cgi?id=384782)
* decoupled code (with further refactoring, preferably not in one step)
no direct parent assignment.

The biggest disadvantage (?) I see is that it adds some complexity,
change is big and will require quite long review process.
I predict it will take around 4 weeks + 4 weeks (or more) for reviews/fixes.

What do you think? Should I start work or someone else is working on SystemTray?

Few words about me:
I'm using KDE for almost 20 years. I'm a developer with 10 years of
commercial experience, mostly in Java. One commercial project in QML
and C++ - Map Downloader on subaru-maps.com. I live in Poland.

-- 
Regards,
Konrad Materka

D22861: [Kicker/Kickoff] Use better "Remove from Favorites" icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d90e82ef7c19: [Kicker/Kickoff] Use better Remove 
from Favorites icon (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22861?vs=62869=62888

REVISION DETAIL
  https://phabricator.kde.org/D22861

AFFECTED FILES
  applets/kicker/package/contents/ui/code/tools.js
  applets/kickoff/package/contents/ui/code/tools.js

To: GB_2, #vdg, ndavis, ngraham, hein
Cc: plasma-devel, #vdg, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22868: Revamp Kirigami.AboutPage

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.


  While swapping out the card for straight up a rowlayout might[1] effectively 
look like a workaround for the weirdness in that bit... this really just looks 
better anyway ;) Go for it :D
  
  [1] to someone who's tried to fix that bit before - D18180 
 - not in general :) once this is landed, 
i'll abandon that diff

REPOSITORY
  R169 Kirigami

BRANCH
  aboutpage

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22869: [Converter Runner] Support fractional units

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, kossebau.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 409216
  FIXED-IN: 5.17.0
  
  CHANGELOG: Converter runner can now convert fractional units, such as 3/8"

TEST PLAN
  Typed `3/8"`, got results for 0,375", i.e. 0.9525cm
  Typed `3/8 in, got the same results
  Typed `3/8" in cm`, got it converted to just centimeters
  Typed `3/0"`, didn't get any results
  Typed `3"`, still works 
  Can still convert units with a slash, such as "50km/h" = 31mph.
  Due to how the runner identifies numbers and units, you cannot have spaces 
between the slashes, i.e. `3 / 8 in` doesn't work

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22869

AFFECTED FILES
  runners/converter/converterrunner.cpp

To: broulik, #plasma, kossebau
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  thanks!

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22867

To: hein, #frameworks, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22817: Port KRunner to Plasma Components 3

[Kai Uwe Broulik]

broulik added a comment.


  > To add the clear button, maybe you can use Kirigami.SearchField instead?
  
  Not sure if that can do Plasma styling?

INLINE COMMENTS

> apol wrote in RunCommand.qml:56
> The button's height is by default really big and krunner then looks rather 
> comical.
> Here we're making sure it all stays as big as the text field after all.

Then this is a regression from PC2 and should be fixed.
There's even a manual test for PC2 to address this, so PC3 should have the same 
behavior.
F7121480: Screenshot_20190730_221403.png 

> apol wrote in RunCommand.qml:226
> PC3 has no moving hightlight delegate, it's the delegate that highlights 
> itself.

But now you get two "highlights", one following the mouse, one following the 
keyboard.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22817

To: apol, #plasma, broulik
Cc: ngraham, ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart