D22316: Avoid garbling the sound if the volume slider is moved fast

[Nathaniel Graham]

ngraham added a comment.


  @davidedmundson and/or @drosca, are you good with this new approach?

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #plasma, drosca, davidedmundson, ngraham
Cc: anthonyfieroni, filipf, ngraham, davidedmundson, plasma-devel, kezik, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better!

REVISION DETAIL
  https://phabricator.kde.org/D22316

To: kezik, #plasma, drosca, davidedmundson, ngraham
Cc: anthonyfieroni, filipf, ngraham, davidedmundson, plasma-devel, kezik, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22844: [kcm-colors] Export colorscheme to GTK color definitions

[Nathaniel Graham]

ngraham added a comment.


  Nice, it works every time now! I'm not super thrilled about all the code 
duplication, though. Can't this live in just one place? If not here, then maybe 
in plasma-framework?

INLINE COMMENTS

> .gitignore:1
> +.vscode

Unrelated to this patch; please remove from the diff

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma, ngraham
Cc: ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22844: [kcm-colors] Export colorscheme to GTK color definitions

[Carson Black]

cblack updated this revision to Diff 63010.
cblack added a comment.


  Fix WM colors on first go round

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22844?vs=63009&id=63010

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

AFFECTED FILES
  .gitignore
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h

To: cblack, #plasma, ngraham
Cc: ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22844: [kcm-colors] Export colorscheme to GTK color definitions

[Carson Black]

cblack updated this revision to Diff 63009.
cblack added a comment.


  Colors are now applied from the active colorscheme every time

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22844?vs=63001&id=63009

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

AFFECTED FILES
  .gitignore
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h

To: cblack, #plasma, ngraham
Cc: ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22316: Avoid garbling the sound if the volume slider is moved fast

[kezi]

kezik updated this revision to Diff 63008.
kezik added a comment.


  I talked with 4-5 people and they all said that giving real time feedback in 
the slider is useless and bad, so here's that, the feedback is given on mouse 
release, and every problem is automatically solved.
  
  If you want more technical details about the alternative version, read the 
rest of this comment, otherwise just ignore, now everything is fine.
  
  **useless part of the comment:**
  
  In D22316#505584 , @anthonyfieroni 
wrote:
  
  > updateTimer uses slider value and it takes 200 ms to react, so you can sync 
the timer with keyboard one by increase the interval 
https://phabricator.kde.org/source/plasma-pa/browse/master/applet/contents/ui/ListItemBase.qml$198
  
  
  I'm not sure if I am understanding this, the timer seems to only provide 
feedback to the slider .. ?
  
  The main issue here is inside libcanberra (or pulseaudio): in some conditions 
(I found that the bug occurs mostly if no other sound is playing) 
ca_context_playing simply does not work correctly, i'm fairly sure that my 
patch is correct, I tested libcanberra independently and I can confirm that 
"bug"
  
  I tested that by setting CA_PROP_CANBERRA_CACHE_CONTROL to "never", the 
problem seems to go away, that's probably suboptimal but it's the only decent 
workaround I can come up with
  
diff --git a/applet/contents/ui/ListItemBase.qml 
b/applet/contents/ui/ListItemBase.qml
index d962eb5..6bdbcb7 100644
--- a/applet/contents/ui/ListItemBase.qml
+++ b/applet/contents/ui/ListItemBase.qml
@@ -190,6 +190,10 @@ PlasmaComponents.ListItem {
 // whereas PA rejected the volume change 
and is
 // still at v15 (e.g.).
 updateTimer.restart();
+
+if (type == "sink") {
+playFeedback(Index);
+}
 }
 }
 
diff --git a/src/qml/volumefeedback.cpp b/src/qml/volumefeedback.cpp
index 69bc260..3e5abae 100644
--- a/src/qml/volumefeedback.cpp
+++ b/src/qml/volumefeedback.cpp
@@ -55,9 +55,9 @@ void VolumeFeedback::play(quint32 sinkIndex)
 
 // NB Depending on how this is desired to work, we may want to simply
 // skip playing, or cancel the currently playing sound and play our
-// new one... for now, let's do the latter.
+// new one... for now, let's do the former.
 if (playing) {
-ca_context_cancel(context, cindex);
+return;
 }
 
 char dev[64];
@@ -70,7 +70,7 @@ void VolumeFeedback::play(quint32 sinkIndex)
 cindex,
 CA_PROP_EVENT_DESCRIPTION, "Volume Control Feedback Sound",
 CA_PROP_EVENT_ID, "audio-volume-change",
-CA_PROP_CANBERRA_CACHE_CONTROL, "permanent",
+CA_PROP_CANBERRA_CACHE_CONTROL, "never",  // XXX workaround a 
libcamberra bug
 CA_PROP_CANBERRA_ENABLE, "1",
 nullptr
 );

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22316?vs=62863&id=63008

REVISION DETAIL
  https://phabricator.kde.org/D22316

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: kezik, #plasma, drosca, davidedmundson, ngraham
Cc: anthonyfieroni, filipf, ngraham, davidedmundson, plasma-devel, kezik, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM, but let's wait for @davidedmundson.

REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22844: [kcm-colors] Export colorscheme to GTK color definitions

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks, it works much better now. I'm really impressed with this, and it's 
very cool to be able to see GTK3 apps respecting the system color scheme:
  F7143222: Screenshot_20190802_141140.png 

  
  However this is still not shippable in its current state due to a 
reproducible issue: GTK apps will only reliable change their color scheme after 
you apply a new color scheme in the KCM //twice//. If you only apply it once, 
most or all of the time, GTK apps will not change, and will retain the old 
color scheme. This needs to be fixed first so that applying the new color 
scheme once is all it takes.
  
  Also, it's a bit annoying that you need to restart GTK apps to see the 
change, but I suppose that's inevitable (and if fixable, we can fix it in a 
subsequent patch).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma, ngraham
Cc: ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22844: [kcm-colors] Export colorscheme to GTK color definitions

[Carson Black]

cblack updated this revision to Diff 63001.
cblack added a comment.


  Make GTK colors its own KRDB flag

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22844?vs=62859&id=63001

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h

To: cblack, #plasma, ngraham
Cc: ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22844: [kcm-colors] Export colorscheme to GTK color definitions

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Very cool idea. However I'm not seeing it work. No matter how many times I 
change the color scheme, the .css files never get created. It doesn't work 
after a reboot either.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma, ngraham
Cc: ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Me too, but please wait for a #plasma 
 person to approve or reject. :)

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 added a comment.


  That is good enough IMO, but if anyone knows how to fix this, then please do 
:-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5b7a43d2ad8d: Rename "Plasma Theme" to 
"Plasma Style" (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22880?vs=62927&id=62999

REVISION DETAIL
  https://phabricator.kde.org/D22880

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/index.docbook
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop
  kcms/desktoptheme/plasma-themes.knsrc

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22881: [GTK3] Give checkboxes and radiobuttons a pressed appearance

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:e5f17d318a5e: [GTK3] Give checkboxes and radiobuttons a 
pressed appearance (authored by cblack, committed by ngraham).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22881?vs=62931&id=62993

REVISION DETAIL
  https://phabricator.kde.org/D22881

AFFECTED FILES
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_menus.scss

To: cblack, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22901: Make alphabetic categorization of the "All Applications" section optional

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:258545f996cf: Make alphabetic categorization of the 
"All Applications" section optional (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22901?vs=62989&id=62992

REVISION DETAIL
  https://phabricator.kde.org/D22901

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/rootmodel.h

To: hein, #plasma, davidedmundson, tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22876: Merge gtk320 and gtk318 into gtk3

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:fdd2df48b37e: Merge gtk320 and gtk318 into gtk3 (authored 
by cblack, committed by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22876?vs=62906&id=62991#toc

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22876?vs=62906&id=62991

REVISION DETAIL
  https://phabricator.kde.org/D22876

AFFECTED FILES
  src/CMakeLists.txt
  src/build_theme.sh
  src/gtk-dark-3.0.css
  src/gtk-dark-3.18.css
  src/gtk-dark-3.20.css
  src/gtk3/gtk.scss
  src/gtk3/widgets/_app_notifications.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_button.scss
  src/gtk3/widgets/_calendar.scss
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_color_chooser.scss
  src/gtk3/widgets/_dialogs.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_lists.scss
  src/gtk3/widgets/_menus.scss
  src/gtk3/widgets/_misc.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_overshoot.scss
  src/gtk3/widgets/_pathbar.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_sidebar.scss
  src/gtk3/widgets/_spinbutton.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_toolbar.scss
  src/gtk3/widgets/_tooltips.scss
  src/gtk3/widgets/_treeview.scss
  src/gtk3/widgets/_window_decorations.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: cblack, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22901: Make alphabetic categorization of the "All Applications" section optional

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  That's much nicer.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22901

To: hein, #plasma, davidedmundson, tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22901: Make alphabetic categorization of the "All Applications" section optional

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, davidedmundson, tcanabrava.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Introduces a new prop and turns it off by default.
  
  Also rewrites the initial "all applications" data gathering avoid
  a crash uncovered while working on this (it didn't check EntryType)
  and reduces assumptions about the model topology.
  
  It also makes it collect root-level apps now, which was forgotten
  to be added when support for root-level apps were added.
  
  This supercedes D22762  and D22890 
. It does less duplicate work and fixes
  more bugs.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22901

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/rootmodel.h

To: hein, #plasma, davidedmundson, tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Good idea, will do.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22857

To: broulik, #plasma, #vdg
Cc: dfaure, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

[Nathaniel Graham]

ngraham added a comment.


  All right, makes sense. I might suggest a little UI re-work now that we have 
two DnD-related checkboxes next to each other:
  
Do not Disturb mode: [ ] Enable when screens are mirrored
 [ ] Show critical notifications

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22857

To: broulik, #plasma, #vdg
Cc: dfaure, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22899: [SplitterProxy] Don't manually mapToGlobal

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The constructor of QMouseEvent actually expects windowPos and/or screenPos 
but never globalPos.
  By only supplying a localPos we have Qt figure it out correctly on its own.

TEST PLAN
  D22851  for oxygen. Compiles.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D22899

AFFECTED FILES
  kstyle/oxygensplitterproxy.cpp

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

[Kai Uwe Broulik]

broulik added a subscriber: dfaure.
broulik added a comment.


  Sure, but in the non-mirrored case notifications popping up won't really be a 
problem as you will have your desktop with notifications alongside your notes 
on the laptop in front of you with just the presentation on the projector.
  This feature is for when you actually show something on your desktop like we 
did during the sprint or as @dfaure pointed out when he demonstrates some code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22857

To: broulik, #plasma, #vdg
Cc: dfaure, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22803: Improved OSD behavior

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:43a6204349a7: Improved OSD behavior (authored by broulik).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22803?vs=62726&id=62985

REVISION DETAIL
  https://phabricator.kde.org/D22803

AFFECTED FILES
  kded/daemon.cpp
  kded/daemon.h

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22762: Take in consideration flat() for the All Applications menu

[Eike Hein]

hein added a comment.


  It's worth noting that this patch as-is also breaks the Dashboard UI ("All 
Applications" no longer shows content), so this revert wasn't just about 
implementation details but also actively broke upstream.
  
  I'm writing an alternative patch now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22762

To: tcanabrava, davidedmundson, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cd027ce844ed: [applets/notifications] Try to not have the 
notification count numbers overflow… (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22878?vs=62923&id=62982

REVISION DETAIL
  https://phabricator.kde.org/D22878

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: filipf, broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22803: Improved OSD behavior

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great for me.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22803

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Nathaniel Graham]

ngraham added a comment.


  Ah so it does. I think that's the most important case to cover, so tentative 
+1 from me.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Filip Fila]

filipf added a comment.


  If it would be draining to do now, we can leave that menu at QQC1 and add a 
note pointing to a bug report?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 added a comment.


  In D22896#505835 , @ngraham wrote:
  
  > Yeah that's pretty bad. I think we need to fix that first--or at the very 
least, make it close when clicking on the button.
  
  
  It does that. Making it close when clicking anywhere would need some C++ code 
though.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Nathaniel Graham]

ngraham added a comment.


  Yeah that's pretty bad. I think we need to fix that first--or at the very 
least, make it close when clicking on the button.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Kai Uwe Broulik]

broulik added a comment.


  "Only issue", I think that's quite a severe regression?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg
Cc: broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  F7141216: System Settings Sidebar QQC2 Port.png 

  Only issue is that the menu can only be closed if you click somewhere in the 
sidebar.

TEST PLAN
  Open the System Settings. Everything should still work.

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22893: introduce the Defaults group for panel values

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  when plasma is starting up, there are no panel views yet
  this means that if a thickness (or other values)
  are written to the config file and then the resolution changes before
  the panel view gets created, we'll have a view that will default
  to 30 pixels regardless what the layout js file specified.
  
  This makes the scripting only write to a [Default] group for resolution
  dependent properties when panels are not actually present
  when they are already there, interact directly with the view which is
  the safest option.
  
  the view will use whatever is in the defaults group as default if the
  resolution dependent is there, and when a new value is set for a
  resolution dependent one, also update the default, which will
  be used when screen resolution changes, as new default value

TEST PLAN
  - With virtualbox, change resolution continuously when plasma is starting up
  
  with an empty setup, panel is the expected size now, as opposed to 30
  
  - Stop Plasma. Change Screen resoluton with plasma *not* running, to a 
resoluton
  
  still "unknown" to plasmashellrc, then start plasma again. Now the thickness 
saved 
  in [Default] is picked, instead of the arbitrary 30

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/saneDefaults

REVISION DETAIL
  https://phabricator.kde.org/D22893

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h
  shell/scripting/panel.cpp
  shell/scripting/panel.h

To: mart, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22868: Revamp Kirigami.AboutPage

[Eike Hein]

hein added a comment.


  I'll remove that part of the patch later tonight and talk Marco into fixing 
it differently.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella
Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

[Nicolas Fella]

nicolasfella requested changes to this revision.
nicolasfella added a comment.
This revision now requires changes to proceed.


  This breaks the display of main actions on mobile

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella
Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> filipf wrote in main.qml:118
> I think using the technical term here is fine. IIRC f.lux tried to simplify 
> this by adding a bunch of descriptors which compared a particular temperature 
> value or even range to a lighting condition, e.g. one generated by 
> incandescent bulbs. But I don't think we need this, users will figure it out.
> 
> Regarding using uppercase c in "Night Color", that's 2 in favor and 2 against 
> it. We had this dilemma with "Look and Feel" before and kept "Feel" 
> capitalized because it's the name of a specific feature I guess. I'm not 
> super passionate about what we choose, but I slightly lean towards leaving 
> "Color" capitalized for now. That okay?

This option talks about color temperature, so lower case makes sense.

This is not a big deal, but just a little detail.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: zzag, romangg, GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22890: Add new class AllAppsModel that gives us a list of installed Apps

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 62965.
tcanabrava added a comment.


  - Add copyright information and docs

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22890?vs=62964&id=62965

BRANCH
  allAppsModel

REVISION DETAIL
  https://phabricator.kde.org/D22890

AFFECTED FILES
  applets/kicker/CMakeLists.txt
  applets/kicker/plugin/allappsmodel.cpp
  applets/kicker/plugin/allappsmodel.h
  applets/kicker/plugin/appsmodel.h
  applets/kicker/plugin/kickerplugin.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22890: Add new class AllAppsModel that gives us a list of installed Apps

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  The idea is to replace the rootModel.allAppsModel with this
  in the future, right now it's a way to not break the rootModel with
  more code. This represents currently a flat list of Apps, no pagination
  nor groups.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  allAppsModel

REVISION DETAIL
  https://phabricator.kde.org/D22890

AFFECTED FILES
  applets/kicker/CMakeLists.txt
  applets/kicker/plugin/allappsmodel.cpp
  applets/kicker/plugin/allappsmodel.h
  applets/kicker/plugin/appsmodel.h
  applets/kicker/plugin/kickerplugin.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22885: Add global animation speed slider to workspace options KCM

[Kai Uwe Broulik]

broulik added a comment.


  Why is it confusing? I find it more confusing if `AnimationSpeed=0.5` means 
*faster* instead of "half the speed" as reading that line would suggest

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22885

To: davidedmundson, #plasma
Cc: broulik, anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18180: Fix layout issues in the AboutPage personDelegate component

[Dan Leinir Turthra Jensen]

leinir abandoned this revision.
leinir added a comment.


  Irrelevantisified by D22868  :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18180

To: leinir, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D22888: Prefer categories with the query string visible in results

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This logic was present in the old model and keeps e.g. Baloo file search 
results from getting higher priority than likely more useful application 
results with the given name. It only affects the order of categories, e.g. 
scoring "Applications" higher than "Documents" if such a match exists. The 
order of matches within a category is untouched and remains determined by the 
runner based on type and relevance.
  Since the "relevance" of a `QueryMatch` is global and determined freely by 
the runners which don't know what other results might already be present, we 
have to resort to some fuzzy logic like this.

TEST PLAN
  Searched for "quassel", got quassel application higher rated than my random 
sprint note file found by Baloo to contain the word quassel.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D22888

AFFECTED FILES
  lib/resultsmodel.cpp
  lib/resultsmodel.h
  lib/runnerresultsmodel.cpp
  lib/runnerresultsmodel.h

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart