D23117: kcmlookandfeel - Fixed Splash Screen applying

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
The-Feren-OS-Dev requested review of this revision.

REVISION SUMMARY
  This is a small change to the Look & Feel KCM Code to fix 
https://bugs.kde.org/show_bug.cgi?id=409015 by changing the Splash Screen 
changing code a little bit.
  This revision makes Look & Feel check if the package has specified a Splash 
Screen, that it wants Plasma to change the user's current Splash Screen to, or 
not via the 'defaults' file and a check for the 'splashrc' 'Theme' value in 
there. If there isn't a value found it will revert back to the old method of 
applying Splash Screens - applying the Look & Feel name as the Splash Screen. 
If a value is found however, ksplashrc's Theme value will be set to that value 
instead of the Look & Feel's name.
  
  The reason for having the fallback in this code to the old behaviour is that 
many popular Look & Feels, such as the Adapta Look & Feel, all rely on the 
fallback method of applying Splash Screens to have their Splash Screens be 
applied, and if the fallback isn't there nothing will then their currently 
applied Splash Screen simply won't change at all unless the Look & Feel package 
specifies a Splash Screen theme.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23117

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: The-Feren-OS-Dev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23100: Let settings work with arbitrary input controls

[Kai Uwe Broulik]

broulik updated this revision to Diff 63629.
broulik edited the summary of this revision.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23100?vs=63567&id=63629

REVISION DETAIL
  https://phabricator.kde.org/D23100

AFFECTED FILES
  extension/options.html
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23090: Handle media session callbacks before passing it on to the browser

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:a181a9e5b3e8: Handle media session callbacks before 
passing it on to the browser (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23090?vs=63618&id=63627

REVISION DETAIL
  https://phabricator.kde.org/D23090

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> content-script.js:693
>  
> -return ret;
> +// Call the original native implementation
> +// "call()" is needed as the real setActionHandler is a 
> class member

Don't mind this screwup

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23099

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

broulik updated this revision to Diff 63624.
broulik added a comment.


  - address review comments
  
  there's now a `handleData` overload which takes a `serial` and returns a 
`QJsonObject`. You can just return a  `QJsonObject` to reply immediately or 
store the `serial` and call `sendReply` explicitly later

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23099?vs=63595&id=63624

REVISION DETAIL
  https://phabricator.kde.org/D23099

AFFECTED FILES
  extension/content-script.js
  extension/extension-utils.js
  extension/extension.js
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/pluginmanager.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23100: Let settings work with arbitrary input controls

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in options.js:119
> What do you mean?

`` -> `` and then just error out if 
there's no key defined.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23100

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23100: Let settings work with arbitrary input controls

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fvogt wrote in options.js:119
> AFAIK we control everything on the settings page already, so why not just 
> convert all of them?

What do you mean?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23100

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23090: Handle media session callbacks before passing it on to the browser

[Kai Uwe Broulik]

broulik updated this revision to Diff 63618.
broulik retitled this revision from "Handle media session callbacks even when 
the requested one isn't supported by the browser" to "Handle media session 
callbacks before passing it on to the browser".
broulik edited the summary of this revision.
broulik added a comment.


  - Register ourselves before passing on to the browser which may throw

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23090?vs=63532&id=63618

REVISION DETAIL
  https://phabricator.kde.org/D23090

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23091: Call media session callback with details

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:2a6557e41e2a: Call media session callback with details 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23091?vs=63533&id=63616#toc

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23091?vs=63533&id=63616

REVISION DETAIL
  https://phabricator.kde.org/D23091

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23107: Slightly prettier debug

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:77128e353466: Slightly prettier debug (authored by 
broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23107?vs=63596&id=63615

REVISION DETAIL
  https://phabricator.kde.org/D23107

AFFECTED FILES
  host/abstractbrowserplugin.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63614.
GB_2 marked 7 inline comments as done.
GB_2 added a comment.


  Address comments

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63611&id=63614

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23099: Allow sending a port message and receive a reply

[Fabian Vogt]

fvogt added a comment.


  IMHO the member variable is really ugly. Messages with and without serial 
number have to be handled differently anyway, so why not introuce a new 
`handleMessage(event, json, serial)` method?

INLINE COMMENTS

> extension-utils.js:65
> +message.event = event;
> +message.serial = ++currentMessageSerial;
> +pendingMessageReplyResolvers[message.serial] = resolve;

Add a manual wrap before INT32_MAX, just to be safe

> extension.js:109
>  
> -if (!subsystem || !action) {
> +if (!replyToSerial && (!subsystem || !action)) {
>  return;

You could make 0 a valid serial, currently -1 and 0 are both used as flag 
values but only one is really needed

> abstractbrowserplugin.cpp:58
> +}
> +Q_ASSERT(requestSerial > 0);
> +

IMO printing a warning and maybe not doing anything is more fitting here than 
an assert which only works in debug builds and is then fatal.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23099

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23100: Let settings work with arbitrary input controls

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> options.js:37
>  
>  function extensionCheckboxes() {
>  return document.querySelectorAll("#extensions-selection 
> input[type=checkbox][data-extension]");

Can be removed?

> options.js:114
> +
> +if (!settings[extension]) {
> +settings[extension] = {};

Before it would just ignore that, but now it just creates a new settings key if 
it didn't exist. Any particular reason?

IMO there has to be a default defined for every possible setting anyway.

> options.js:119
> +let settingsKey = control.dataset.settingsKey;
> +if (control.type === "checkbox" && !settingsKey) {
> +settingsKey = "enabled";

AFAIK we control everything on the settings page already, so why not just 
convert all of them?

> options.js:124
> +if (!settingsKey) {
> +consle.warn("Invalid settings key in", control, "cannot save 
> this");
> +continue;

`console`

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23100

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23107: Slightly prettier debug

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  TIL that exists

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23107

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23091: Call media session callback with details

[Fabian Vogt]

fvogt accepted this revision.
fvogt added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> content-script.js:673
> +action: action
> +// for seeking there's additional information one 
> would need to add
> +};

If you mention `"seekforward", "seekbackward" or "seekto"` here it can be found 
easier

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23091

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23090: Handle media session callbacks even when the requested one isn't supported by the browser

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> content-script.js:687
> +// still be able to handle it
> +if (!["play", "pause", "seekbackward", "seekforward", 
> "previoustrack", "nexttrack", "skipad", "stop"].includes(name)) {
> +throw new TypeError("Failed to execute 
> 'setActionHandler' on 'MediaSession': The provided value '" + name + "' is 
> not a valid enum value of type MediaSessionAction.");

Why add this check and not just save the exception thrown from 
`oldSetActionHandler` for throwing later?

Otherwise the addon controls which browser functionality is accessible.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23090

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

[David Redondo]

davidre added a comment.


  In D23080#510815 , @ngraham wrote:
  
  > IMO the ideal state of affairs would be to somehow emulate the colors of 
the standard Qt tab widget:
  >
  > F7205923: Screenshot_20190812_073407.png 

  >
  > Not too contrasty, but not too subtle either.
  
  
  +1, we should try to match breeze.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23080

To: cblack, #breeze, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> SidebarMode.cpp:402
> +{
> +QMenu *menu = new QMenu();
> +QStringList actionList { QStringLiteral("configure"), 
> QStringLiteral("help_contents"), QStringLiteral("help_about_app"), 
> QStringLiteral("help_about_kde") };

This leaks.
`menu->setAttribute(Qt::WA_DeleteOnClose);`

> SidebarMode.cpp:403
> +QMenu *menu = new QMenu();
> +QStringList actionList { QStringLiteral("configure"), 
> QStringLiteral("help_contents"), QStringLiteral("help_about_app"), 
> QStringLiteral("help_about_kde") };
> +for (QAction *a : d->collection->actions()) {

`const`

> SidebarMode.cpp:404
> +QStringList actionList { QStringLiteral("configure"), 
> QStringLiteral("help_contents"), QStringLiteral("help_about_app"), 
> QStringLiteral("help_about_kde") };
> +for (QAction *a : d->collection->actions()) {
> +if (actionList.contains(a->objectName())) {

I think it's better to iterate the list of actions and then get them from the 
collection. This way the order is also preserved correctly:

  for (const QString &actionName : actionList) {
  menu->addAction(d->collection->action(actionName);
  }

> SidebarMode.cpp:410
> +connect(menu, &QMenu::aboutToHide, this, [this] () { 
> QMetaObject::invokeMethod(d->quickWidget->rootObject(), "closeMenu"); } );
> +menu->exec(position);
> +}

Don't `exec()` in conjunction with QML, this is just asking for trouble. Use 
`popup()` instead

> main.qml:44
> +function closeMenu() {
> +mainColumn.actionMenuButton.checked = false;
> +}

Can you instead do a `Q_PROPERTY(bool actionMenuVisible ...)` in 
`systemsettings` which you set `true` before the menu opens and set `false` in 
`aboutToHide`. Then bind the `checked` of the button to it.
This way everything is in a predictable space and not called all over the place.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

[Björn Feber]

GB_2 updated this revision to Diff 63611.
GB_2 added a comment.


  Use a QMenu

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63460&id=63611

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

[Nathaniel Graham]

ngraham added a comment.


  IMO the ideal state of affairs would be to somehow emulate the colors of the 
standard Qt tab widget:
  
  F7205923: Screenshot_20190812_073407.png 

  
  Not too contrasty, but not too subtle either.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23080

To: cblack, #breeze, #vdg
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23095: Wayland: Rename output member variable

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:989df1eec1f4: Wayland: Rename output member variable 
(authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23095?vs=63540&id=63606

REVISION DETAIL
  https://phabricator.kde.org/D23095

AFFECTED FILES
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23094: Wayland: Improve screen code style

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:c80a7ab40abc: Wayland: Improve screen code style 
(authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23094?vs=63539&id=63605#toc

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23094?vs=63539&id=63605

REVISION DETAIL
  https://phabricator.kde.org/D23094

AFFECTED FILES
  backends/kwayland/waylandscreen.cpp
  backends/kwayland/waylandscreen.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/2/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 12 Aug 2019 12:37:09 +
 Build duration:
7 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 375 lines...][2019-08-12T12:44:05.846Z] **[2019-08-12T12:44:08.206Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-08-12T12:44:08.712Z] [2019-08-12T12:44:08.712Z] jom 1.1.3 - empower your cores[2019-08-12T12:44:08.712Z] [2019-08-12T12:44:08.712Z] jom: parallel job execution disabled for Makefile[2019-08-12T12:44:08.712Z] Scanning dependencies of target kdbgwin_autogen[2019-08-12T12:44:08.712Z] Scanning dependencies of target qbugzilla_autogen[2019-08-12T12:44:08.712Z] Scanning dependencies of target lsb_release_autogen[2019-08-12T12:44:08.712Z] Scanning dependencies of target crashtest_autogen[2019-08-12T12:44:08.712Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-08-12T12:44:08.712Z] [  0%] Automatic MOC for target lsb_release[2019-08-12T12:44:09.218Z] [  4%] Automatic MOC for target drkonqi_backtrace_parser[2019-08-12T12:44:09.218Z] [  4%] Built target lsb_release_autogen[2019-08-12T12:44:09.218Z] [  3%] Automatic MOC for target crashtest[2019-08-12T12:44:09.218Z] [  4%] Built target crashtest_autogen[2019-08-12T12:44:09.218Z] Scanning dependencies of target lsb_release[2019-08-12T12:44:09.735Z] [  1%] Automatic MOC for target kdbgwin[2019-08-12T12:44:09.735Z] [  6%] Built target kdbgwin_autogen[2019-08-12T12:44:10.240Z] [  6%] Built target drkonqi_backtrace_parser_autogen[2019-08-12T12:44:10.240Z] [  2%] Automatic MOC for target qbugzilla[2019-08-12T12:44:10.240Z] [  5%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.obj[2019-08-12T12:44:10.240Z] [  5%] Building CXX object src/tests/CMakeFiles/lsb_release.dir/lsb_release_autogen/mocs_compilation.cpp.obj[2019-08-12T12:44:10.240Z] lsb_release_double.c[2019-08-12T12:44:10.240Z] mocs_compilation.cpp[2019-08-12T12:44:10.240Z] [  6%] Linking CXX executable ..\..\bin\lsb_release.exe[2019-08-12T12:44:10.240Z] [  6%] Built target qbugzilla_autogen[2019-08-12T12:44:10.749Z] LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\HostX64\x64\link.exe /nologo @CMakeFiles\lsb_release.dir\objects1.rsp /out:..\..\bin\lsb_release.exe /implib:..\..\lib\lsb_release.lib /pdb:C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\bin\lsb_release.pdb /version:0.0 /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL /subsystem:windows kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\lsb_release.dir/intermediate.manifest CMakeFiles\lsb_release.dir/manifest.res" failed (exit code 1120) with the following output:[2019-08-12T12:44:10.749Z] msvcrtd.lib(exe_winmain.obj) : error LNK2019: unresolved external symbol WinMain referenced in function "int __cdecl invoke_main(void)" (?invoke_main@@YAHXZ)[2019-08-12T12:44:10.749Z] ..\..\bin\lsb_release.exe : fatal error LNK1120: 1 unresolved externals[2019-08-12T12:44:10.749Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\src\tests\CMakeFiles\lsb_release.dir\build.make [bin\lsb_release.exe] Error 2[2019-08-12T12:44:10.749Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\CMakeFiles\Makefile2 [src\tests\CMakeFiles\lsb_release.dir\all] Error 2[2019-08-12T12:44:10.749Z] Scanning dependencies of target kdbgwin[2019-08-12T12:44:10.749Z] Scanning dependencies of target drkonqi_backtrace_parser[2019-08-12T12:44:10.749Z] Scanning dependencies of target crashtest[2019-08-12T12:44:10.749Z] [  8%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/main.cpp.obj[2019-08-12T12:44:10.749Z] [  8%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/outputters.cpp.obj[2019-08-12T12:44:10.749Z] [  8%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_process.cpp.obj[2019-08-12T12:44:10.749Z] [  9%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/abstract_generator.cpp.obj[2019-08-12T12:44:10.749Z] [  8%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/callbacks.cpp.obj[2019-08-12T12:44:10.749Z] main.cpp[2019-08-12T12:44:10.749Z] [ 10%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.obj[2019-08-12T12:44:10.749Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.obj[2019-08-12T12:44:10.749Z] backtraceparser.cpp[2019-08-12T12:44:10.749Z] crashtest.cpp[2019-08-12T12:44:11.826Z] Scanning dependencies of target qbugzilla[2019-08-12T12:44:11.826Z] [ 11%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/apijob.cpp.obj[2019-08-12T12:44:11.826Z] apijob.cpp[2019-08-12T12:44:15.062Z] [ 12%] Build

D23112: Add a event Spy for GtkFileChooser recent files

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> GtkEventSpy.cpp:125
> +
> +app.name = attributes.value("exec");
> +// remove "'" caracters wrapping the command and any character after 
> a space

It stores the full `Exec` line of the desktop file, including the `%u`.
What you probably want do to is use `KServiceTypeTrader` to find the 
application with said Exec line.

  auto services = 
KServiceTypeTrader::self()->query(QStringLiteral("Application"), 
QStringLiteral("exist Exec and ('%1' == Exec)").arg(cmd));

and then operate on the `KService` desktop file name, e.g. `org.gnome.evince` 
instead of the executable.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Kai Uwe Broulik]

broulik added a comment.


  Can you check out the `KBookmarks` framework which has classes for processing 
xbel files

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  GtkFileChooser/GtkRecentManager follows 
https://www.freedesktop.org/wiki/Specifications/desktop-bookmark-spec/ 
specification to store its recently accessed files.
  The history is stored in $HOME/.local/share/recently-used.xbel
  
  Adds an event spy for the xml file used by gtk following the example of the 
KRecentDocument EventSpy.
  
  It allows to populate recently accessed files from apps using Gtk, including 
inkscape, gimp...

TEST PLAN
  Compile
  killall -9 kactivitymanage
  run your localy built version of kactivitymanagerd, for instance:
  ~/kde/usr/lib/x86_64-linux-gnu/libexec/kactivitymanagerd
  Run a gtk app and open a file
  The file access can be seen in kickoff/kicker history

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23020: Use QQuickWidget instead of a QQuickView placed into QWidget

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:ccce9e3cd247: Use QQuickWidget instead of a QQuickView 
placed into QWidget (authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23020?vs=6&id=63600

REVISION DETAIL
  https://phabricator.kde.org/D23020

AFFECTED FILES
  CMakeLists.txt
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/qml/main.qml

To: jgrulich, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23109: Rework the visibleActions logic in SwipeListItem

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  visibleActions is really only used to check whether there are
  any actions visible at all, the number is irrelevant. For some
  unknown reason the old logic would occasionally get caught in
  some out of order silliness (so we'd end up with a negative
  number of visible actions), but with this logic we only check
  whether there is any visible actions at all, so the whole thing
  is less stateful.

TEST PLAN
  Using Peruse on mobile, load up the Store and see that with the
  old logic there are no handles on the items. With the new
  logic there is.

REPOSITORY
  R169 Kirigami

BRANCH
  rework-swipelistitem-visible-actions-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23109

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: leinir
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23107: Slightly prettier debug

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Print the extension name without quotes and spaces.
  Before:
  `"plugin" : debug output`
  After:
  `plugin: debug output`

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23107

AFFECTED FILES
  host/abstractbrowserplugin.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

broulik updated this revision to Diff 63595.
broulik added a comment.


  - Let plugin access the serial so it can store it and send a reply 
asynchronously later

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23099?vs=63560&id=63595

REVISION DETAIL
  https://phabricator.kde.org/D23099

AFFECTED FILES
  extension/extension-utils.js
  extension/extension.js
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/pluginmanager.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Re: Unified git commit message guideline

[David Faure]

Hello Roman,

On dimanche 11 août 2019 23:52:55 CEST Roman Gilg wrote:
> [1] https://www.conventionalcommits.org

I like the idea very much, the changelog does look a bit messy indeed.
It would allow me to filter out all style, ci, and test changes, which are not 
interesting to the user of the frameworks.

I'm missing a type for internal cleanups like porting away from deprecated 
methods or fixing a harmless compiler warning? OTOH "chore" isn't documented 
in the Angular convention so I don't know what it is. In any case, it sounds 
like we need to write down our own list of types, right?

I would also like to keep the "Test Plan" field from phab even after we move 
to gitlab, it pushes people to write down how they actually tested the change.

I think we should wait until after the switch to gitlab though, because it 
might have some influence on this. For instance with phab I tend to prefix the 
subject with the repo name so that on k-f-d we can see which framework it's 
about. But that looks a bit redundant in the git history of a given repo 
afterwards so if the emails from gitlab include the repo name automatically, 
we shouldn't do that in the git commit log itself.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5