D23112: Add a event Spy for GtkFileChooser recent files

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> GtkEventSpy.cpp:135
> +// See 
> https://techbase.kde.org/Development/Tutorials/Services/Traders#The_KTrader_Query_Language
> +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist 
> GenericName and '%1' ~~ GenericName) or (exist Name and '%1' ~~ 
> Name))").arg(exec);
> +KService::List services = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), query);

Isn't that a bit coarse? Doesn't matching the `Exec` line exactly work?

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23130: [energy kcm] Remove bogus Has power supply property from UI

[Kai Uwe Broulik]

broulik added a comment.


  That property is whether the selected battery powers the computer or is just 
a peripheral. Perhaps just the label must be changed?

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23130

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Björn Feber]

GB_2 added a comment.


  In D21815#490482 , @filipf wrote:
  
  > If keeping the new menu style we have to wait until all those patches get 
merged in Plasma.
  >
  > Might be better to just follow current style; updating it to the new one 
would be a quick review.
  
  
  Yeah, keep the current style.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Björn Feber]

GB_2 added a comment.


  In D19822#442630 , @filipf wrote:
  
  > Just throwing out another possible solution: the PlasmaComponents Highlight 
thingy:
  >
  > F6747233: Screenshot_20190403_005556.png 

  >
  > F6747232: Screenshot_20190403_005453.png 

  >
  > Might be considered too obtrusive though.
  >
  > EDIT: not a good idea "2.0 to be used only as the "highlight" property of 
the ListView and GridView primitive QML components (or their derivates)"
  
  
  Then just use the `FrameSvgItem` directly:
  
PlasmaCore.FrameSvgItem {
imagePath: "widgets/viewitem"
prefix: "hover"
}

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23079: [GTK3] Fix Firefox's CSD colors, kinda

[Carson Black]

cblack updated this revision to Diff 63676.
cblack added a comment.


  Tweak colors some more

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23079?vs=63515&id=63676

BRANCH
  firefox-csd-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23079

AFFECTED FILES
  src/gtk3/applications/_firefox.scss
  src/gtk3/gtk.scss

To: cblack, #vdg, #breeze, ngraham
Cc: mthw, ngraham, zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Thanks for geting involved this much!

INLINE COMMENTS

> GtkEventSpy.cpp:129
> +// remove "'" caracters wrapping the command
> +exec = exec.mid(1, exec.size() -2 );
> +

It might be dangerous to assume that the command is wrapped with single quotes

> GtkEventSpy.cpp:133
> +// See 
> https://techbase.kde.org/Development/Tutorials/Services/Traders#The_KTrader_Query_Language
> +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist 
> GenericName and '%1' ~~ GenericName) or (exist Name and '%1' ~~ 
> Name))").arg(exec);
> +KService::List services = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), query);

const auto query

> GtkEventSpy.cpp:134
> +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist 
> GenericName and '%1' ~~ GenericName) or (exist Name and '%1' ~~ 
> Name))").arg(exec);
> +KService::List services = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), query);
> +

This should also be `const`, other local variables as well

> GtkEventSpy.cpp:143
> +// remove space and any caracter after
> +int spaceIdex = exec.indexOf(" ");
> +if (spaceIdex != -1) {

Let's hope commands will never have spaces in them :)

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23130: [energy kcm] Remove bogus Has power supply property from UI

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Good catch!

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23130

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D12103: Support snap permissions in Discover

[Juan Asensio Sánchez]

juanasensiosanchez added a comment.


  That makes sense:
  
$ dpkg -l | grep discover
ii  avahi-utils 0.7-3.1ubuntu1.2
amd64Avahi browsing, publishing and 
discovery utilities
ii  plasma-discover 
5.12.8-0ubuntu0.1build1~ubuntu18.04~ppa1amd64Discover 
software management suite
ii  plasma-discover-common  
5.12.8-0ubuntu0.1build1~ubuntu18.04~ppa1all  Discover 
software manager suite (common data files)
ii  plasma-discover-snap-backend
5.12.8-0ubuntu0.1build1~ubuntu18.04~ppa1amd64Discover 
software manager suite - Snappy support
  
  Thanks.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D12103

To: apol
Cc: juanasensiosanchez, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23130: [energy kcm] Remove bogus Has power supply property from UI

[Méven Car]

meven created this revision.
meven added reviewers: broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  In a laptop when the ac line is un plugged, kinfocenter wrongly display that 
the ac power supply is plugged. See screenshot.
  
  This is due to "Power Supply" solid property being wrongly interpreted.
  This solid property is always true for devices that can deliver power supply, 
whether or not there active or plugged.
  See https://upower.freedesktop.org/docs/Device.html#Device:PowerSupply

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23130

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63669.
meven added a comment.


  Add a logging category

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63654&id=63669

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

plasma* akademy bofs

[Harald Sitter]

halo

when shall we do plasma bofs?
last year we had 4 slots on Monday. do we want more? or less? a
different day perhaps?

9:30, 10:30, 11:30, 15:30 are the times we had last year, for reference

HS

D14830: Add "Configure Displays" context menu entry on the desktop

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> GB_2 wrote in menu.cpp:117
> I'd change it to "Manage Displays..." to make the differentiate the name even 
> more from the "Configure Desktop..." menu entry.

*to differentiate

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach, harmathy, davidedmundson
Cc: GB_2, gregormi, mart, davidedmundson, abetts, romangg, fabianr, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14830: Add "Configure Displays" context menu entry on the desktop

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> menu.cpp:117
>  
> +m_displaySettingsAction = new 
> QAction(i18nc("plasma_containmentactions_contextmenu", "Configure 
> Displays..."), this);
> +
> m_displaySettingsAction->setIcon(QIcon::fromTheme(QStringLiteral("preferences-desktop-display-randr")));

I'd change it to "Manage Displays..." to make the differentiate the name even 
more from the "Configure Desktop..." menu entry.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach, harmathy, davidedmundson
Cc: GB_2, gregormi, mart, davidedmundson, abetts, romangg, fabianr, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14830: Add "Configure Displays" context menu entry on the desktop

[Björn Feber]

GB_2 added a comment.


  I think we should definitely add this shortcut, because it is very useful for 
the people mentioned and for other situations. I agree that it should be on by 
default, then it's already there when you need it.
  
  In D14830#472177 , @mart wrote:
  
  > if this would be done, i would prefer for the kcm once ported to qml to be 
embedded in the desktop settings window
  
  
  D22468  ports the KCM to QML, but it 
doesn't integrate it into the desktop settings. Just having this shortcut is 
fine IMO, the desktop settings already a lot of categories and configuring the 
desktop does not mean managing displays.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach, harmathy, davidedmundson
Cc: GB_2, gregormi, mart, davidedmundson, abetts, romangg, fabianr, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

[Nathaniel Graham]

ngraham added a comment.


  Might be worth beating the dead horse and revisiting it though. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23127

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

[Björn Feber]

GB_2 abandoned this revision.
GB_2 added a comment.


  Oh, didn't know that existed, it wasn't mentioned anywhere in the bug report.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23127

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

[Nathaniel Graham]

ngraham added a comment.


  I recall that this was controversial. See D14830 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23127

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/72/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 13 Aug 2019 14:54:07 +
 Build duration:
5 min 27 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  F7237121: Displays KCM Desktop Context Menu Entry.png 


TEST PLAN
  Toggle the visibility of the "Manage Displays..." desktop context menu entry 
in the "Standard Menu" mouse action configuration window.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-desktop-context-menu-entry-for-displays-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23128

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 355679
  F7237121: Displays KCM Desktop Context Menu Entry.png 


TEST PLAN
  Open the desktop context menu and click on the "Manage Displays..." menu 
entry.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-desktop-context-menu-entry-for-displays-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23127

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:80bcaaf483da: [GTK3 -> Chrome/ium] Tweak tab stylings 
(authored by cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23080?vs=63661&id=63663

REVISION DETAIL
  https://phabricator.kde.org/D23080

AFFECTED FILES
  src/gtk3/applications/_chromium.scss
  src/gtk3/gtk.scss

To: cblack, #breeze, #vdg, ngraham, GB_2
Cc: davidre, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfect. I agree, we can fix the windeco buttons in another patch.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  chromium-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23080

To: cblack, #breeze, #vdg, ngraham
Cc: davidre, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23049: Add Kirigami ListSectionHeader component

[Björn Feber]

GB_2 updated this revision to Diff 63662.
GB_2 added a comment.


  Improve example

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23049?vs=63653&id=63662

BRANCH
  arcpatch-D23049

REVISION DETAIL
  https://phabricator.kde.org/D23049

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc.in
  src/controls/ListSectionHeader.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: GB_2, #kirigami, #vdg, mart, ngraham
Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, 
fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

[Carson Black]

cblack added a comment.


  I'm aware of the visibility issues of the window buttons on Breeze light CSD, 
however fixing those would require changes outside of the scope of this patch.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23080

To: cblack, #breeze, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

[Carson Black]

cblack updated this revision to Diff 63661.
cblack added a comment.


  Change around the colors a bit

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23080?vs=63559&id=63661

BRANCH
  chromium-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23080

AFFECTED FILES
  src/gtk3/applications/_chromium.scss
  src/gtk3/gtk.scss

To: cblack, #breeze, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23126: Add browser action for status reporting

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This adds a tool bar icon for reporting extension status in lieu of the error 
notification.
  When the extension isn't supported or fails to start, the Plasma icon is 
crossed out. Especially when synced to a device without 
plasma-browser-integration, the error notification that used to show up can be 
annoying and misleading.
  When the extension crashes, an overlay is shown.
  Currently, the overlay is disabled when the extension is running properly, 
but additional controls such as sharing and media controls blacklist settings 
could be added to the browser action. This patch is mostly for the base 
infrastructure of such a toolbar icon.

TEST PLAN
  Needs proper icon from VDG, cf. Bug 410821
  
  Disabled icon
  F7235286: Screenshot_20190813_155423.png 

  Explanation for not working
  F7235285: Screenshot_20190813_155400.png 

  F7235287: Screenshot_20190813_155453.png 

  
  Crashed icon
  F7235282: Screenshot_20190811_220957.png 

  Crashed explanation
  F7235288: Screenshot_20190813_155517.png 

  When the host crashes, you also get a DrKonqi dialog but  don't think there's 
a way for us (other than matching the "Native host has exited" string) to tell 
whether it crashed (DrKonqi) or got disconnected for violating the 
communication protocol or just quit gracefully because of some other issue (No 
DrKonqi)
  
  All working
  F7235297: Screenshot_20190813_155854.png 

  Chrome always shows an extension icon which has a default context menu, on 
Firefox the icon hides completely in this case.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23126

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/action_popup.css
  extension/action_popup.html
  extension/action_popup.js
  extension/constants.js
  extension/extension.js
  extension/icons/plasma-disabled-128.png
  extension/manifest.json

To: broulik, #plasma, #vdg, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23049: Add Kirigami ListSectionHeader component

[Björn Feber]

GB_2 added a comment.


  In D23049#511210 , @ngraham wrote:
  
  > Hmm, if software making use of this needs to manually add a label, that 
seems to defeat part of the point of using a standard component.
  
  
  The label in the example was just supposed to show that any controls can be 
added. Sorry for the confusion, I'll remove it.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart, ngraham
Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, 
fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23109: Rework the visibleActions logic in SwipeListItem

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 63658.
leinir added a comment.


  - Only check for other visible actions if this one is not visible

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23109?vs=63598&id=63658

BRANCH
  rework-swipelistitem-visible-actions-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23109

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: leinir, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:32a4fce2aa74: Allow sending a port message and receive a 
reply (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23099?vs=63646&id=63657

REVISION DETAIL
  https://phabricator.kde.org/D23099

AFFECTED FILES
  extension/extension-utils.js
  extension/extension.js
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/downloadplugin.h
  host/kdeconnectplugin.h
  host/mprisplugin.h
  host/pluginmanager.cpp
  host/tabsrunnerplugin.h

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23125: fix bridge master:slave mapping by-name

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
sitter requested review of this revision.

REVISION SUMMARY
  a slave may be mapped to a master by either the uuid of the master OR
  the connection name of the master.
  
  determine our current connection name and if it is the one referenced by
  the slave we consider ourselves master of that slave.
  since we do not have access to the connection name inside the bridgewidget
  I'm opting to pop it out of connection list on-demand. it may be
  more efficient to get it passed in by the parent widget (which I think
  knows the name). I am not sure if there may be pitfalls with considering
  the name static though.
  
  also partially unpack the if condition so it's a bit easier on the eyes
  with the newly added complexity

TEST PLAN
nmcli c add type bridge ifname br0 autoconnect yes con-name br0 stp off
nmcli c add type bridge-slave autoconnect yes con-name enp4s0 ifname enp4s0 
master br0
  
  kcm correctly shows enp4s0 as slave of br0

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23125

AFFECTED FILES
  libs/editor/settings/bridgewidget.cpp

To: sitter, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23049: Add Kirigami ListSectionHeader component

[Nathaniel Graham]

ngraham added a comment.


  Hmm, if software making use of this needs to manually add a label, that seems 
to defeat part of the point of using a standard component.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart, ngraham
Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, 
fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D12103: Support snap permissions in Discover

[Nathaniel Graham]

ngraham added a comment.


  Kubuntu 18.04 uses Plasma 5.12 which includes Discover 5.12. This code was 
added in a later version (likely 5.13).

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D12103

To: apol
Cc: juanasensiosanchez, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/71/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 13 Aug 2019 13:03:15 +
 Build duration:
2 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 461 lines...][2019-08-13T13:05:56.381Z]Needed to for holidays plugin for Plasma Calendar.[2019-08-13T13:05:56.381Z]  * KF5Activities (required version >= 5.58.0), management of Plasma activities[2019-08-13T13:05:56.381Z]Needed by activity related plasmoids.[2019-08-13T13:05:56.381Z]  * Freetype[2019-08-13T13:05:56.381Z]  * Fontconfig[2019-08-13T13:05:56.381Z]  * X11, X11 libraries, [2019-08-13T13:05:56.381Z]Required for building the X11 based workspace[2019-08-13T13:05:56.381Z]  * KF5Prison (required version >= 5.58.0), Prison library, [2019-08-13T13:05:56.381Z]Needed to create mobile barcodes from clipboard data[2019-08-13T13:05:56.381Z]  * Phonon4Qt5Experimental (required version == 4.10.60)[2019-08-13T13:05:56.381Z]  * PkgConfig[2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z] -- The following RECOMMENDED packages have been found:[2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z]  * KF5Baloo, File Searching[2019-08-13T13:05:56.381Z]Needed for the File Search runner.[2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z] -- The following REQUIRED packages have been found:[2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z]  * Qt5Gui (required version >= 5.13.0)[2019-08-13T13:05:56.381Z]  * Qt5Widgets[2019-08-13T13:05:56.381Z]  * Qt5Qml (required version >= 5.13.0)[2019-08-13T13:05:56.381Z]  * Qt5Quick[2019-08-13T13:05:56.381Z]  * Qt5QuickWidgets[2019-08-13T13:05:56.381Z]  * Qt5Concurrent[2019-08-13T13:05:56.381Z]  * Qt5Test[2019-08-13T13:05:56.381Z]  * Qt5Network[2019-08-13T13:05:56.381Z]  * KF5Plasma (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5DocTools (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5Runner (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5Su (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5NewStuff (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5Wallet (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5IdleTime (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5Declarative (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * Gettext[2019-08-13T13:05:56.381Z]  * KF5I18n (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5KCMUtils (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5TextWidgets (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5Crash (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5GlobalAccel (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5Wayland (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KF5CoreAddons (required version >= 5.58.0)[2019-08-13T13:05:56.381Z]  * KDED[2019-08-13T13:05:56.381Z]  * KF5PlasmaQuick[2019-08-13T13:05:56.381Z]  * KF5SysGuard[2019-08-13T13:05:56.381Z]  * ECM (required version >= 1.6.0)[2019-08-13T13:05:56.381Z]  * KF5Package[2019-08-13T13:05:56.381Z]  * KF5[2019-08-13T13:05:56.381Z]  * KWinDBusInterface[2019-08-13T13:05:56.381Z]  * KScreenLocker (required version >= 5.13.80)[2019-08-13T13:05:56.381Z]  * ScreenSaverDBusInterface[2019-08-13T13:05:56.381Z]  * ZLIB, Support for gzip compressed files and data streams, [2019-08-13T13:05:56.381Z]  * Qt5X11Extras[2019-08-13T13:05:56.381Z]  * Qt5Core[2019-08-13T13:05:56.381Z]  * Qt5Sql[2019-08-13T13:05:56.381Z]  * Qt5[2019-08-13T13:05:56.381Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2019-08-13T13:05:56.381Z]  * XCB, X protocol C-language Binding, [2019-08-13T13:05:56.381Z]Required for enabling special X11 multihead mode[2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z] -- The following RUNTIME packages have not been found:[2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z]  * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.[2019-08-13T13:05:56.381Z]  * AppMenuGtkModule, Application Menu GTK+ Module, [2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z] -- The following OPTIONAL packages have not been found:[2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z]  * KF5NetworkManagerQt (required version >= 5.58.0), Qt wrapper for NetworkManager API[2019-08-13T13:05:56.381Z]Needed by geolocation data engine.[2019-08-13T13:05:56.381Z]  * AppStreamQt (required version >= 0.10.6), Access metadata for listing available software, [2019-08-13T13:05:56.381Z]  * Qalculate, Qalculate Library, [2019-08-13T13:05:56.381Z]Needed to enable advanced features of the calculator runner[2019-08-13T13:05:56.381Z] [2019-08-13T13:05:56.381Z] -- Confi

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 331 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/331/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 13:03:14 +
 Build duration:
2 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 457 lines...][2019-08-13T13:05:54.827Z]  * KF5Activities (required version >= 5.58.0), management of Plasma activities[2019-08-13T13:05:54.827Z]Needed by activity related plasmoids.[2019-08-13T13:05:54.827Z]  * Freetype[2019-08-13T13:05:54.827Z]  * Fontconfig[2019-08-13T13:05:54.827Z]  * X11, X11 libraries, [2019-08-13T13:05:54.827Z]Required for building the X11 based workspace[2019-08-13T13:05:54.827Z]  * AppStreamQt (required version >= 0.10.6), Access metadata for listing available software, [2019-08-13T13:05:54.827Z]  * KF5Prison (required version >= 5.58.0), Prison library, [2019-08-13T13:05:54.827Z]Needed to create mobile barcodes from clipboard data[2019-08-13T13:05:54.827Z]  * Phonon4Qt5Experimental (required version == 4.10.60)[2019-08-13T13:05:54.827Z]  * PkgConfig[2019-08-13T13:05:54.827Z] [2019-08-13T13:05:54.827Z] -- The following RECOMMENDED packages have been found:[2019-08-13T13:05:54.827Z] [2019-08-13T13:05:54.827Z]  * KF5Baloo, File Searching[2019-08-13T13:05:54.827Z]Needed for the File Search runner.[2019-08-13T13:05:54.827Z] [2019-08-13T13:05:54.827Z] -- The following REQUIRED packages have been found:[2019-08-13T13:05:54.827Z] [2019-08-13T13:05:54.827Z]  * Qt5Gui (required version >= 5.12.4)[2019-08-13T13:05:54.827Z]  * Qt5Widgets[2019-08-13T13:05:54.827Z]  * Qt5Qml (required version >= 5.12.4)[2019-08-13T13:05:54.827Z]  * Qt5Quick[2019-08-13T13:05:54.827Z]  * Qt5QuickWidgets[2019-08-13T13:05:54.827Z]  * Qt5Concurrent[2019-08-13T13:05:54.827Z]  * Qt5Test[2019-08-13T13:05:54.827Z]  * Qt5Network[2019-08-13T13:05:54.827Z]  * KF5Plasma (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5DocTools (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5Runner (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5Su (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5NewStuff (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5Wallet (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5IdleTime (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5Declarative (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * Gettext[2019-08-13T13:05:54.827Z]  * KF5I18n (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5KCMUtils (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5TextWidgets (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5Crash (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5GlobalAccel (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5Wayland (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KF5CoreAddons (required version >= 5.58.0)[2019-08-13T13:05:54.827Z]  * KDED[2019-08-13T13:05:54.827Z]  * KF5PlasmaQuick[2019-08-13T13:05:54.827Z]  * KF5SysGuard[2019-08-13T13:05:54.827Z]  * ECM (required version >= 1.6.0)[2019-08-13T13:05:54.827Z]  * KF5Package[2019-08-13T13:05:54.827Z]  * KF5[2019-08-13T13:05:54.827Z]  * KWinDBusInterface[2019-08-13T13:05:54.827Z]  * KScreenLocker (required version >= 5.13.80)[2019-08-13T13:05:54.827Z]  * ScreenSaverDBusInterface[2019-08-13T13:05:54.827Z]  * ZLIB, Support for gzip compressed files and data streams, [2019-08-13T13:05:54.827Z]  * Qt5X11Extras[2019-08-13T13:05:54.827Z]  * Qt5Core[2019-08-13T13:05:54.827Z]  * Qt5Sql[2019-08-13T13:05:54.827Z]  * Qt5[2019-08-13T13:05:54.827Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2019-08-13T13:05:54.827Z]  * XCB, X protocol C-language Binding, [2019-08-13T13:05:54.827Z]Required for enabling special X11 multihead mode[2019-08-13T13:05:54.827Z] [2019-08-13T13:05:54.828Z] -- The following RUNTIME packages have not been found:[2019-08-13T13:05:54.828Z] [2019-08-13T13:05:54.828Z]  * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.[2019-08-13T13:05:54.828Z]  * IsoCodes, ISO language, territory, currency, script codes and their translations, [2019-08-13T13:05:54.828Z]Translation of country names in digital clock applet[2019-08-13T13:05:54.828Z]  * AppMenuGtkModule, Application Menu GTK+ Module, [2019-08-13T13:05:54.828Z] [2019-08-13T13:05:54.828Z] -- The following OPTIONAL packages have not been found:[2019-08-13T13:05:54.828Z] [2019-08-13T13:05:54.828Z]  * Qalculate, Qalculate Library, [2019-08-13T13:05:54.828Z]Needed to enable advanced features of the calculator runner[2019-08-13T13:05:54.828Z]  * libgps, GPS support for geolocation, [2019-08-13T13:05:54.828Z] [2019-08-13T13:05:54.828Z] -- Config

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63654.
meven added a comment.


  Readd include QDebug used by qWarning

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63647&id=63654

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 330 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/330/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 10:58:17 +
 Build duration:
1 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 459 lines...][2019-08-13T11:00:04.293Z]  * KF5Activities (required version >= 5.58.0), management of Plasma activities[2019-08-13T11:00:04.293Z]Needed by activity related plasmoids.[2019-08-13T11:00:04.293Z]  * Freetype[2019-08-13T11:00:04.293Z]  * Fontconfig[2019-08-13T11:00:04.293Z]  * X11, X11 libraries, [2019-08-13T11:00:04.293Z]Required for building the X11 based workspace[2019-08-13T11:00:04.293Z]  * AppStreamQt (required version >= 0.10.6), Access metadata for listing available software, [2019-08-13T11:00:04.293Z]  * KF5Prison (required version >= 5.58.0), Prison library, [2019-08-13T11:00:04.293Z]Needed to create mobile barcodes from clipboard data[2019-08-13T11:00:04.293Z]  * Phonon4Qt5Experimental (required version == 4.10.60)[2019-08-13T11:00:04.293Z]  * PkgConfig[2019-08-13T11:00:04.293Z] [2019-08-13T11:00:04.293Z] -- The following RECOMMENDED packages have been found:[2019-08-13T11:00:04.293Z] [2019-08-13T11:00:04.293Z]  * KF5Baloo, File Searching[2019-08-13T11:00:04.293Z]Needed for the File Search runner.[2019-08-13T11:00:04.293Z] [2019-08-13T11:00:04.293Z] -- The following REQUIRED packages have been found:[2019-08-13T11:00:04.293Z] [2019-08-13T11:00:04.293Z]  * Qt5Gui (required version >= 5.12.4)[2019-08-13T11:00:04.293Z]  * Qt5Widgets[2019-08-13T11:00:04.293Z]  * Qt5Qml (required version >= 5.12.4)[2019-08-13T11:00:04.293Z]  * Qt5Quick[2019-08-13T11:00:04.294Z]  * Qt5QuickWidgets[2019-08-13T11:00:04.294Z]  * Qt5Concurrent[2019-08-13T11:00:04.294Z]  * Qt5Test[2019-08-13T11:00:04.294Z]  * Qt5Network[2019-08-13T11:00:04.294Z]  * KF5Plasma (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5DocTools (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5Runner (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5Su (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5NewStuff (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5Wallet (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5IdleTime (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5Declarative (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * Gettext[2019-08-13T11:00:04.294Z]  * KF5I18n (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5KCMUtils (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5TextWidgets (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5Crash (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5GlobalAccel (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5Wayland (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KF5CoreAddons (required version >= 5.58.0)[2019-08-13T11:00:04.294Z]  * KDED[2019-08-13T11:00:04.294Z]  * KF5PlasmaQuick[2019-08-13T11:00:04.294Z]  * KF5SysGuard[2019-08-13T11:00:04.294Z]  * ECM (required version >= 1.6.0)[2019-08-13T11:00:04.294Z]  * KF5Package[2019-08-13T11:00:04.294Z]  * KF5[2019-08-13T11:00:04.294Z]  * KWinDBusInterface[2019-08-13T11:00:04.294Z]  * KScreenLocker (required version >= 5.13.80)[2019-08-13T11:00:04.294Z]  * ScreenSaverDBusInterface[2019-08-13T11:00:04.294Z]  * ZLIB, Support for gzip compressed files and data streams, [2019-08-13T11:00:04.294Z]  * Qt5X11Extras[2019-08-13T11:00:04.294Z]  * Qt5Core[2019-08-13T11:00:04.294Z]  * Qt5Sql[2019-08-13T11:00:04.294Z]  * Qt5[2019-08-13T11:00:04.294Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2019-08-13T11:00:04.294Z]  * XCB, X protocol C-language Binding, [2019-08-13T11:00:04.294Z]Required for enabling special X11 multihead mode[2019-08-13T11:00:04.294Z] [2019-08-13T11:00:04.294Z] -- The following RUNTIME packages have not been found:[2019-08-13T11:00:04.294Z] [2019-08-13T11:00:04.294Z]  * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.[2019-08-13T11:00:04.294Z]  * IsoCodes, ISO language, territory, currency, script codes and their translations, [2019-08-13T11:00:04.294Z]Translation of country names in digital clock applet[2019-08-13T11:00:04.294Z]  * AppMenuGtkModule, Application Menu GTK+ Module, [2019-08-13T11:00:04.294Z] [2019-08-13T11:00:04.294Z] -- The following OPTIONAL packages have not been found:[2019-08-13T11:00:04.294Z] [2019-08-13T11:00:04.294Z]  * Qalculate, Qalculate Library, [2019-08-13T11:00:04.294Z]Needed to enable advanced features of the calculator runner[2019-08-13T11:00:04.294Z]  * libgps, GPS support for geolocation, [2019-08-13T11:00:04.294Z] [2019-08-13T11:00:04.294Z] -- Config

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 70 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/70/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 13 Aug 2019 10:58:17 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 461 lines...][2019-08-13T10:59:04.500Z]Needed to for holidays plugin for Plasma Calendar.[2019-08-13T10:59:04.500Z]  * KF5Activities (required version >= 5.58.0), management of Plasma activities[2019-08-13T10:59:04.500Z]Needed by activity related plasmoids.[2019-08-13T10:59:04.500Z]  * Freetype[2019-08-13T10:59:04.500Z]  * Fontconfig[2019-08-13T10:59:04.500Z]  * X11, X11 libraries, [2019-08-13T10:59:04.500Z]Required for building the X11 based workspace[2019-08-13T10:59:04.500Z]  * KF5Prison (required version >= 5.58.0), Prison library, [2019-08-13T10:59:04.500Z]Needed to create mobile barcodes from clipboard data[2019-08-13T10:59:04.500Z]  * Phonon4Qt5Experimental (required version == 4.10.60)[2019-08-13T10:59:04.500Z]  * PkgConfig[2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z] -- The following RECOMMENDED packages have been found:[2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z]  * KF5Baloo, File Searching[2019-08-13T10:59:04.500Z]Needed for the File Search runner.[2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z] -- The following REQUIRED packages have been found:[2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z]  * Qt5Gui (required version >= 5.13.0)[2019-08-13T10:59:04.500Z]  * Qt5Widgets[2019-08-13T10:59:04.500Z]  * Qt5Qml (required version >= 5.13.0)[2019-08-13T10:59:04.500Z]  * Qt5Quick[2019-08-13T10:59:04.500Z]  * Qt5QuickWidgets[2019-08-13T10:59:04.500Z]  * Qt5Concurrent[2019-08-13T10:59:04.500Z]  * Qt5Test[2019-08-13T10:59:04.500Z]  * Qt5Network[2019-08-13T10:59:04.500Z]  * KF5Plasma (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5DocTools (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5Runner (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5NotifyConfig (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5Su (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5NewStuff (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5Wallet (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5IdleTime (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5Declarative (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * Gettext[2019-08-13T10:59:04.500Z]  * KF5I18n (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5KCMUtils (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5TextWidgets (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5KDELibs4Support (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5Crash (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5GlobalAccel (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5DBusAddons (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5Wayland (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KF5CoreAddons (required version >= 5.58.0)[2019-08-13T10:59:04.500Z]  * KDED[2019-08-13T10:59:04.500Z]  * KF5PlasmaQuick[2019-08-13T10:59:04.500Z]  * KF5SysGuard[2019-08-13T10:59:04.500Z]  * ECM (required version >= 1.6.0)[2019-08-13T10:59:04.500Z]  * KF5Package[2019-08-13T10:59:04.500Z]  * KF5[2019-08-13T10:59:04.500Z]  * KWinDBusInterface[2019-08-13T10:59:04.500Z]  * KScreenLocker (required version >= 5.13.80)[2019-08-13T10:59:04.500Z]  * ScreenSaverDBusInterface[2019-08-13T10:59:04.500Z]  * ZLIB, Support for gzip compressed files and data streams, [2019-08-13T10:59:04.500Z]  * Qt5X11Extras[2019-08-13T10:59:04.500Z]  * Qt5Core[2019-08-13T10:59:04.500Z]  * Qt5Sql[2019-08-13T10:59:04.500Z]  * Qt5[2019-08-13T10:59:04.500Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2019-08-13T10:59:04.500Z]  * XCB, X protocol C-language Binding, [2019-08-13T10:59:04.500Z]Required for enabling special X11 multihead mode[2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z] -- The following RUNTIME packages have not been found:[2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z]  * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.[2019-08-13T10:59:04.500Z]  * AppMenuGtkModule, Application Menu GTK+ Module, [2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z] -- The following OPTIONAL packages have not been found:[2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z]  * KF5NetworkManagerQt (required version >= 5.58.0), Qt wrapper for NetworkManager API[2019-08-13T10:59:04.500Z]Needed by geolocation data engine.[2019-08-13T10:59:04.500Z]  * AppStreamQt (required version >= 0.10.6), Access metadata for listing available software, [2019-08-13T10:59:04.500Z]  * Qalculate, Qalculate Library, [2019-08-13T10:59:04.500Z]Needed to enable advanced features of the calculator runner[2019-08-13T10:59:04.500Z] [2019-08-13T10:59:04.500Z] -- Configuring

D12103: Support snap permissions in Discover

[Juan Asensio Sánchez]

juanasensiosanchez added a comment.


  New in Phabricator. Is this code already merged? Using Kubuntu 18.04 with 
Backports PPA but I can't see these options.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D12103

To: apol
Cc: juanasensiosanchez, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23049: Add Kirigami ListSectionHeader component

[Björn Feber]

GB_2 updated this revision to Diff 63653.
GB_2 added a comment.


  Ditch the extra property

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23049?vs=63444&id=63653

BRANCH
  arcpatch-D23049

REVISION DETAIL
  https://phabricator.kde.org/D23049

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc.in
  src/controls/ListSectionHeader.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: GB_2, #kirigami, #vdg, mart, ngraham
Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, 
fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23099: Allow sending a port message and receive a reply

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> extension.js:109
>  
> -if (!subsystem || !action) {
> +if (replyToSerial < 0 && (!subsystem || !action)) {
>  return;

Would need to be `"replyToSerial" in message` now, `undefined` is not smaller 
than 0

> pluginmanager.cpp:132
> +const auto reply = plugin->handleData(requestSerial, event, json);
> +if (!reply.isEmpty()) {
> +plugin->sendReply(requestSerial, reply);

Might be useful to always reply as ack?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23099

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63647.
meven marked an inline comment as done.
meven added a comment.


  Remove unused include

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63641&id=63647

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23049: Add Kirigami ListSectionHeader component

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ListSectionHeader.qml:92
> +
> +Component.onCompleted: {
> +for (var i = 0; i < customItems.length; i++) {

This is a no-go hack:
those customItems shouldn't be reparented, but rather the property should be an 
alias to the data of another layout, like:

  property alias customItems: innerLayout.data
  contentItem: RowLayout {
  id: rowLayout
  RowLayout {
  id: innerLayout
  }

or, i would prefer even more, to just ditch that extra property completely:

  default property alias _contents: rowLayout.data
  contentItem: RowLayout {

​   id: rowLayout
​   Heading {

  

so one just does

  ListSectionHeader {
 Button {}
  }

and just works(tm)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart, ngraham
Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, 
fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

broulik updated this revision to Diff 63646.
broulik added a comment.


  - We're signed int :)

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23099?vs=63645&id=63646

REVISION DETAIL
  https://phabricator.kde.org/D23099

AFFECTED FILES
  extension/extension-utils.js
  extension/extension.js
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/downloadplugin.h
  host/kdeconnectplugin.h
  host/mprisplugin.h
  host/pluginmanager.cpp
  host/tabsrunnerplugin.h

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

broulik updated this revision to Diff 63645.
broulik added a comment.


  - Properly support zero as serial
  - Wrap int max properly

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23099?vs=63644&id=63645

REVISION DETAIL
  https://phabricator.kde.org/D23099

AFFECTED FILES
  extension/extension-utils.js
  extension/extension.js
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/downloadplugin.h
  host/kdeconnectplugin.h
  host/mprisplugin.h
  host/pluginmanager.cpp
  host/tabsrunnerplugin.h

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

broulik added a comment.


  Didn't add it to `settings` as I have some follow-up patches that will 
actually use the other overload, too

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23099

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

broulik updated this revision to Diff 63644.
broulik added a comment.


  - Silence method hidden warning

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23099?vs=63624&id=63644

REVISION DETAIL
  https://phabricator.kde.org/D23099

AFFECTED FILES
  extension/extension-utils.js
  extension/extension.js
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/downloadplugin.h
  host/kdeconnectplugin.h
  host/mprisplugin.h
  host/pluginmanager.cpp
  host/tabsrunnerplugin.h

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23099: Allow sending a port message and receive a reply

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in abstractbrowserplugin.h:56
> Why does it say "got hidden" when those two clearly have a different 
> signature?

Because only the overridden overload is visible in the child classes. You can 
fix this by adding `using AbstractBrowserPlugin::handleData;` to the plugin 
classes.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23099

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3417dd1620c7: [Notifications KCM] Add checkbox for 
enabling do not disturb mode when screens… (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22857?vs=63105&id=63643

REVISION DETAIL
  https://phabricator.kde.org/D22857

AFFECTED FILES
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, ngraham
Cc: dfaure, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22856: [Notifications] Enable do not disturb mode when screens are mirrored

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:523ef16369cc: [Notifications] Enable do not disturb mode 
when screens are mirrored (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22856?vs=62861&id=63642

REVISION DETAIL
  https://phabricator.kde.org/D22856

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/mirroredscreenstracker.cpp
  libnotificationmanager/mirroredscreenstracker_p.h
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: broulik, #plasma, #vdg, dfaure, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 284 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/284/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 07:30:56 +
 Build duration:
39 min and counting
   CONSOLE OUTPUT
  [...truncated 5325 lines...][2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/akregator-fav.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/config-win-behavior.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/emacs-attribute.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/emacs-info.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/focus-stealing-pop2top-attribute.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/knotes-attribute.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/knotes-info.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kopete-attribute-2.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kopete-chat-attribute.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kopete-chat-info.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kopete-info.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-detect-window.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-kopete-rules.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-rule-editor.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-rules-main-n-akregator.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-rules-main.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-rules-ordering.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-window-attributes.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-window-matching.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/pager-4-desktops.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/tbird-compose-attribute.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/tbird-compose-info.png[2019-08-13T08:07:51.728Z] -- Installing: /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/tbird-main-attribute.png[2019-08-

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63641.
meven added a comment.


  Use KServiceTypeTrader to look for apps being used

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63603&id=63641

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23099: Allow sending a port message and receive a reply

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> abstractbrowserplugin.h:56
>  virtual void handleData(const QString &event, const QJsonObject &data);
> +virtual QJsonObject handleData(int serial, const QString &event, const 
> QJsonObject &data);
>  

Why does it say "got hidden" when those two clearly have a different signature?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23099

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23122: Enable enhanced media controls by default

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Media Sessions API usage becomes more and more common, so it is quite nice to 
get proper album art. Also, calling into media session for play/pause when the 
website provides them is nicer than blatantly calling `pause()` on the player 
item.
  It also isn't as invasive as the original implementation used to be since it 
doesn't manipulate the website DOM anymore.

TEST PLAN
  I've been using this forever without any hickups.
  I also couldn't reproduce the Bug 397684 at all and likely to have been 
caused by the HTML element we injected into the website throwing off some JS 
templating lib.
  
  David I think said once that he could reproduce it or is running home assist, 
so can you check if it works for you still?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23122

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/constants.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23100: Let settings work with arbitrary input controls

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:c8572d6cbed5: Let settings work with arbitrary input 
controls (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23100?vs=63638&id=63639

REVISION DETAIL
  https://phabricator.kde.org/D23100

AFFECTED FILES
  extension/options.html
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23100: Let settings work with arbitrary input controls

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Didn't test, but looks good

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23100

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven added a comment.


  In D23112#510798 , @broulik wrote:
  
  > Can you check out the `KBookmarks` framework which has classes for 
processing xbel files
  
  
  Thanks for pointing it out.
  I just did, and It does not seem to cover my use case here :
  It is quite heavily oriented towards its main use : application bookmark.
  For instance to get the attributes of the bookmarks elements I would need to 
use the internalElement() method to get a raw QDomElement which kind of defeat 
the purpose of using a library.
  I would also need to parse myself the  elements using 
internalElement as well.
  While user-places.xbel references 
https://www.freedesktop.org/wiki/Specifications/desktop-bookmark-spec/ as its 
specification, it does not abide by it.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23100: Let settings work with arbitrary input controls

[Kai Uwe Broulik]

broulik updated this revision to Diff 63638.
broulik added a comment.


  - Don't write config keys for which we don't have a default

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23100?vs=63629&id=63638

REVISION DETAIL
  https://phabricator.kde.org/D23100

AFFECTED FILES
  extension/options.html
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart