D23392: [energy KCM] Add battery Technology

[Méven Car]

meven updated this revision to Diff 65189.
meven added a comment.


  fix

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23392?vs=65188=65189

BRANCH
  arcpatch-D23392

REVISION DETAIL
  https://phabricator.kde.org/D23392

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Méven Car]

meven added a comment.


  Please note that the feature needs solid 5.62 installed on system as qml 
looks in `/usr/include/solid/battery.h` for the battery model header.
  By chance iIf you know how to set the include path used by qml

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23392

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Méven Car]

meven updated this revision to Diff 65188.
meven added a comment.


  Rebase on master

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23392?vs=64459=65188

BRANCH
  arcpatch-D23392

REVISION DETAIL
  https://phabricator.kde.org/D23392

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase as it no longer applies cleanly:
  
$ arc patch D23392
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D23392.
Branch name arcpatch-D23152 already exists; trying a new name.
Created and checked out branch arcpatch-D23152_1.
Checking patch Modules/energy/package/contents/ui/main.qml...
Checking patch Modules/energy/batterymodel.h...
Checking patch Modules/energy/batterymodel.cpp...
Applied patch Modules/energy/package/contents/ui/main.qml cleanly.
Applied patch Modules/energy/batterymodel.h cleanly.
Applied patch Modules/energy/batterymodel.cpp cleanly.

 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick 'arcpatch-D23152_1'

STDOUT
(empty)

STDERR
error: could not apply 84aed6f... [energy kcm] Display Vendor and model
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

(Run with `--trace` for a full exception trace.)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23392

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23652: [Kicker/Kickoff] Re-word "Manage ..." menu item for greater clarity

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:408f3ebbec9a: [Kicker/Kickoff] Re-word Manage 
app... menu item for greater clarity (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23652?vs=65172=65184

REVISION DETAIL
  https://phabricator.kde.org/D23652

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: ngraham, #vdg, #plasma, hein, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23640: [kicker/kickoff] Add icon to hide application action

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9359baac9e7d: [kicker/kickoff] Add icon to hide 
application action (authored by nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23640?vs=65116=65173

REVISION DETAIL
  https://phabricator.kde.org/D23640

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp

To: nicolasfella, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23652: [Kicker/Kickoff] Re-word "Manage ..." menu item for greater clarity

[Nathaniel Graham]

ngraham updated this revision to Diff 65172.
ngraham added a comment.


  Correct Capitalization

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23652?vs=65171=65172

BRANCH
  re-word-manage-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23652

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: ngraham, #vdg, #plasma, hein, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23652: [Kicker/Kickoff] Re-word "Manage ..." menu item for greater clarity

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, hein, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Even with the Discover icon added in D23623 
, the text is still fairly unclear,
  especially for the common case of wanting to uninstall the app.
  
  This patch re-words the menu item to add that all-important word "Uninstall", 
while not
  losing any of the current meaning.

TEST PLAN
  F7306455: Screenshot_20190901_134728.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  re-word-manage-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23652

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: ngraham, #vdg, #plasma, hein, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23622: [kicker/kickoff] Use better icon for edit application

[Nathaniel Graham]

ngraham added a comment.


  Since this action actually opens the properties window (which just happens to 
have a tab that allows you to edit the .desktop file), how about just, 
"Properties". Then we could use the standard `document-properties` icon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23622

To: nicolasfella, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: plasma-nm strongswan support for custom proposals

[Jan Grulich]

Hi,

please submit your patch to Phabricator [1], we don't do reviews over
email.

[1] - https://phabricator.kde.org

Thank you for your contribution.

Regards,
Jan

so 31. 8. 2019 v 3:35 odesílatel Bob Richmond  napsal:

> This patch brings feature parity with gnome's nm-connection-editor
> strongswan plugin. Enabling custom proposals is required in order to
> support connections to strict strong cipher endpoints, the default
> cipher list doesn't include eg: aes256gcm16-prfsha384-ecp384.
>

D23542: Promote KCM to top level and rename accordingly

[Nathaniel Graham]

ngraham added a comment.


  That's correct. I guess this can be considered an advanced feature.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23542

To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter
Cc: agurenko, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23542: Promote KCM to top level and rename accordingly

[Alex Gurenko]

agurenko added a comment.


  In D23542#523723 , @ngraham wrote:
  
  > In D23542#523306 , @agurenko 
wrote:
  >
  > > Can you still re-order devices to set priority of input/output devices?
  >
  >
  > That's not relevant to this patch, which only moves the KCM to the top 
level. No functionality has been lost; if you require advanced settings like 
setting device priorities, you can still do it via the `phononsettings` tool.
  
  
  But moving KCM to the top level removes Multimedia section (at least that's 
what is visible on a screenshot) which was used to access priority (I assume 
that's phononsettings), hence my question, e.g. this will not be easily 
accessible via GUI if I understand correctly?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23542

To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter
Cc: agurenko, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23651: WIP: Add support for a theming in Kicker Dashboard

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  - Replace hardcoded color with Kirigami.Theme.*
  - Replace search bar with Kirigami.Search
  
  I tried to use PlasmaCore.Theme but this didn't work

TEST PLAN
  Screenshot comming

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kicker-dask-theme-support

REVISION DETAIL
  https://phabricator.kde.org/D23651

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/DashboardTabButton.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemMultiGridView.qml

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23542: Promote KCM to top level and rename accordingly

[Nathaniel Graham]

ngraham added a comment.


  In D23542#523306 , @agurenko wrote:
  
  > Can you still re-order devices to set priority of input/output devices?
  
  
  That's not relevant to this patch, which only moves the KCM to the top level. 
No functionality has been lost; if you require advanced settings like setting 
device priorities, you can still do it via the `phononsettings` tool.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23542

To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter
Cc: agurenko, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Kai Uwe Broulik]

broulik added a comment.


  So I guess we can use the `KFileItem::isSlow()` here now, too?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Méven Car]

meven added a comment.


  In D23342#523626 , @davidedmundson 
wrote:
  
  > > This could be run on package install by distributions, or we could add an 
action somewhere to let the user run it on demand.
  >
  > It is run automatically in the cmake.
  >
  > See
  >  plugins/process/network/helper/CMakeLists.txt
  >
  > I think that should be enough for distros
  
  
  I had to run the command `setcap cap_net_raw+ep` as root, cmake is not run a 
root so if I understand correctly it won't work.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma, meven
Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[David Edmundson]

davidedmundson added a comment.


  > This could be run on package install by distributions, or we could add an 
action somewhere to let the user run it on demand.
  
  It is run automatically in the cmake.
  
  See
  plugins/process/network/helper/CMakeLists.txt
  
  I think that should be enough for distros

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma, meven
Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23387: [Folder view] Scale selection and preview buttons with item size

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d9ea98a61c7f: [Folder view] Scale selection and preview 
buttons with item size (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23387?vs=65127=65131

REVISION DETAIL
  https://phabricator.kde.org/D23387

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemActionButton.qml

To: ngraham, hein, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23387: [Folder view] Scale selection and preview buttons with item size

[Nathaniel Graham]

ngraham added a comment.


  The icons are in the plasma theme.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  folderview-buttons-scale-with-item-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23387

To: ngraham, hein, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23387: [Folder view] Scale selection and preview buttons with item size

[Noah Davis]

ndavis added a comment.


  That's some nice consistent spacing. Does it get the icons from the desktop 
theme? If so, I could add some additional sizes so that it doesn't look as 
blurry.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23387

To: ngraham, hein, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23387: [Folder view] Scale selection and preview buttons with item size

[Nathaniel Graham]

ngraham updated this revision to Diff 65127.
ngraham added a comment.


  Use medium for largest size

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23387?vs=64447=65127

BRANCH
  folderview-buttons-scale-with-item-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23387

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemActionButton.qml

To: ngraham, hein, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23647: XRandR: Generic code cleanup

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  No functional changes, white space added where sensible, debug messages now
  without repetition of qCDebug(..) macros, modernized, keeps line limit.

TEST PLAN
  Compiles and KScreen runs on X11.

REPOSITORY
  R110 KScreen Library

BRANCH
  cleanupXrandrBackend

REVISION DETAIL
  https://phabricator.kde.org/D23647

AFFECTED FILES
  backends/xrandr/xrandr.cpp
  backends/xrandr/xrandr.h
  backends/xrandr/xrandrconfig.cpp
  backends/xrandr/xrandrconfig.h
  backends/xrandr/xrandrcrtc.cpp
  backends/xrandr/xrandrcrtc.h
  backends/xrandr/xrandrmode.cpp
  backends/xrandr/xrandrmode.h
  backends/xrandr/xrandroutput.cpp
  backends/xrandr/xrandroutput.h
  backends/xrandr/xrandrscreen.cpp
  backends/xrandr/xrandrscreen.h

To: romangg, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23640: [kicker/kickoff] Add icon to hide application action

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, hein, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The icon name seems a bit weird to me, but it's what Dolphin uses for a 
similar purpose

REPOSITORY
  R119 Plasma Desktop

BRANCH
  hideicon

REVISION DETAIL
  https://phabricator.kde.org/D23640

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp

To: nicolasfella, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23620: Fix speaker test not showing sinks/buttons

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:097879580833: Fix speaker test not showing sinks/buttons 
(authored by nicolasfella).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23620?vs=65083=65097

REVISION DETAIL
  https://phabricator.kde.org/D23620

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml

To: nicolasfella, #plasma, drosca, ngraham
Cc: aacid, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23621: [kicker/kickoff] Add icon to forget recent docs action

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:16fdd6493162: [kicker/kickoff] Add icon to forget recent 
docs action (authored by nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23621?vs=65085=65096

REVISION DETAIL
  https://phabricator.kde.org/D23621

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: nicolasfella, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23622: [kicker/kickoff] Use better icon for edit application

[Nicolas Fella]

nicolasfella added a comment.


  What do you suggest?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23622

To: nicolasfella, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23623: [kicker/kickoff] Use discover icon for manage application action

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8a9ee0233b07: [kicker/kickoff] Use discover icon for 
manage application action (authored by nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23623?vs=65087=65095

REVISION DETAIL
  https://phabricator.kde.org/D23623

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: nicolasfella, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23387: [Folder view] Scale selection and preview buttons with item size

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> FolderItemActionButton.qml:38
> +case 4: return units.iconSizes.smallMedium;
> +case 5: return units.iconSizes.large;
> +default: return units.iconSizes.small;

medium would be better because then it won't overlap with the icon/thumbnail

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23387

To: ngraham, hein, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23542: Promote KCM to top level and rename accordingly

[Alex Gurenko]

agurenko added a comment.


  Can you still re-order devices to set priority of input/output devices?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23542

To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter
Cc: agurenko, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Méven Car]

meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  The command `sudo setcap cap_net_raw+ep ksgrd_network_helper` needs to be 
documented outside of just the commit message, in 
`plugins/process/network/README.md` at least.
  This could be run on package install by distributions, or we could add an 
action somewhere to let the user run it on demand.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma, meven
Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Méven Car]

meven added a comment.


  It works nicely.
  I thought it missed a screenshot here.
  F7303942: Screenshot_20190901_084433.png 


REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma
Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23287: Create a plugin framework for processes

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> process_data_provider.cpp:23
> +#include "process_attribute.h"
> +
> +using namespace KSysGuard;

Missing `#include `

Results in build error :

  kde/src/libksysguard/processcore/process_data_provider.cpp:30:33: error: 
field ‘m_attributes’ has incomplete type ‘
 │ QVector’
60   │  QVector m_attributes;
61   │  ^~~~

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23287

To: davidedmundson, #plasma, ahiemstra
Cc: meven, zzag, ahiemstra, alexde, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Björn Feber]

GB_2 added a comment.


  In D23174#519704 , @ngraham wrote:
  
  > Hooray!
  >
  > Next, do you think you could clean up the applications list so there aren't 
all those duplicates and they all get icons?
  
  
  Unfortunately, I don't know the code base well enough to fix that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23174

To: GB_2, #plasma, #vdg, ivan, ngraham, #kactivities
Cc: #kactivities, ivan, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart