D12827: Added process details in the process list context menu

[Méven Car]

meven added a comment.


  In D12827#527480 , @chrisx wrote:
  
  > Patch updated. Any suggestions?
  
  
  You have a few code indentation issues, that you can take care of.
  https://phabricator.kde.org/D12827#inline-130952
  
  And I think you should rename `DetailsDlg` to `DetailsDialog`, we prefer to 
avoid abbreviations in classes names as a convention.
  
  Also the patch does not apply on master but I guess it depends on D23287 
 which also needs to be rebased on master...

REVISION DETAIL
  https://phabricator.kde.org/D12827

To: chrisx, broulik, davidedmundson, mart
Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23798: Polish Displays KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 65706.
ngraham marked 3 inline comments as done.
ngraham added a comment.


  Address more review comments

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=65687&id=65706

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23808: Don't create() windows that aren't native, upon receiving a palette change event.

[David Faure]

dfaure created this revision.
dfaure added reviewers: carewolf, davidedmundson, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

TEST PLAN
  run kmail or falkon, then run kcmshell5 fonts, change font size
  
  ASSERT: "!d->offscreenWindow->handle()" in file 
/d/qt/5/kde/qtdeclarative/src/quickwidgets/qquickwidget.cpp, line 1014
  
  Apparently that QQuickWindow should not be create()d so calling winId()
  unconditionally here is a bad idea, skip non-native windows.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D23808

AFFECTED FILES
  src/platformtheme/x11integration.cpp

To: dfaure, carewolf, davidedmundson, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23803: [Folder View] Add subtle shadows to icons

[Kai Uwe Broulik]

broulik added a comment.


  Ah never mind. It's in the if check like the label. Nice!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

To: ngraham, hein, #plasma, #vdg, filipf, ndavis
Cc: broulik, GB_2, cfeck, ndavis, filipf, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23803: [Folder View] Add subtle shadows to icons

[Kai Uwe Broulik]

broulik added a comment.


  Can you check whether it's works with software rendering - we don't want 
desktop icons to entirely disappear in this case.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

To: ngraham, hein, #plasma, #vdg, filipf, ndavis
Cc: broulik, GB_2, cfeck, ndavis, filipf, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23803: [Folder View] Add subtle shadows to icons

[Björn Feber]

GB_2 added a comment.


  In D23803#528128 , @cfeck wrote:
  
  > Isn't Qt Quick amazing?
  
  
  Indeed!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

To: ngraham, hein, #plasma, #vdg, filipf, ndavis
Cc: GB_2, cfeck, ndavis, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23803: [Folder View] Add subtle shadows to icons

[Christoph Feck]

cfeck added a comment.


  Isn't Qt Quick amazing?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

To: ngraham, hein, #plasma, #vdg, filipf, ndavis
Cc: cfeck, ndavis, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish Displays KCM UI

[Björn Feber]

GB_2 added a comment.


  I have a suggestion for the "save output properties" option.

INLINE COMMENTS

> Panel.qml:90
>  
>  Kirigami.FormData.label: i18n("Save values of an output:")
>  Kirigami.FormData.buddyFor: globalRetentionRadio

"Save output properties:"

> Panel.qml:96
>  id: globalRetentionRadio
>  text: i18n("For this and other combination of outputs")
>  checked: !individualRetentionRadio.checked

"For any setup"

> Panel.qml:103
>  id: individualRetentionRadio
>  text: i18n("For this specific setup independently of others")
>  checked: kcm.outputRetention === KScreen.Control.Individual

"Only for this specific setup"

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish Displays KCM UI

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:123
> And I could use some help with the issue detailed in the comment here.

You don't need any of that. Just do `kcm.outputModel.count > 1`. BTW, I'd also 
use a different minimum height if this component is hidden.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23803: [Folder View] Add subtle shadows to icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

To: ngraham, hein, #plasma, #vdg, filipf, ndavis
Cc: ndavis, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23803: [Folder View] Add subtle shadows to icons

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Tried it out, I like the way it looks.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

To: ngraham, hein, #plasma, #vdg, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23803: [Folder View] Add subtle shadows to icons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: hein, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Folder View items currently have shadows behind their labels, but not their 
icons.
  
  This patch adds a very subtle shadow for the icons as well, which improves 
contrast
  for some backgrounds and just looks classy IMO. :)
  
  FEATURE: 411607
  FIXED-IN: 5.17.0

TEST PLAN
  Before: F7334103: Before.png 
  After: F7334104: After.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: ngraham, hein, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Works and looks great to me. @hein, are you okay with this now?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein, GB_2
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Björn Feber]

GB_2 updated this revision to Diff 65691.
GB_2 added a comment.


  Fix diff

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19822?vs=65509&id=65691

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19822

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: faridb, #plasma, #vdg, ngraham, hein, GB_2
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

[Filip Fila]

filipf added a comment.


  Yikes, we need to fix that.
  
  So what this patch does is moves *all* of the UI up a bit.
  
  One issue is you should then also definitely check and modify the Breeze SDDM 
theme so the two look identical.
  
  But... you could maybe skip that and use an alternative approach here. We 
could reduce the spacing between the media player controls and the switch user 
button. I would be more in favor that than shifting everything up, especially 
since I see it's bigger than spacing between the avatar and the clock.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23786

To: kishoreg, #plasma, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham added a comment.


  This patch doesn't apply anymore. I think something went wrong with adding 
that last change.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein, GB_2
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23798: Polish KCM UI

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:123
>  outputs: kcm.outputModel
> +// visible: kcm.numberOfOutputs > 1 // FIXME: this is -1 here; 
> does it get set too late?
>  }

And I could use some help with the issue detailed in the comment here.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 65687.
ngraham added a comment.


  Remove unnecessarily-added id for main layout

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=65685&id=65687

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 65685.
ngraham added a comment.


  Use same slider style for the per-output Wayland version

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=65684&id=65685

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 65684.
ngraham added a comment.


  ...And also capitalize correctly

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=65683&id=65684

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish KCM UI

[Nathaniel Graham]

ngraham updated this revision to Diff 65683.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Add icons to pushbuttons

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23798?vs=65674&id=65683

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. Any objections?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23786

To: kishoreg, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23793: Add icons to Kicker/Kickoff context menu items and correct capitalizations

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6fbfc3ded129: Add icons to Kicker/Kickoff context menu 
items and correct capitalizations (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23793?vs=65660&id=65682

REVISION DETAIL
  https://phabricator.kde.org/D23793

AFFECTED FILES
  applets/kicker/package/contents/ui/code/tools.js
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/appsmodel.cpp
  applets/kickoff/package/contents/ui/code/tools.js

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10362: Change reveal password button logic

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fb18347e4dea: Change reveal password button logic 
(authored by GB_2).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10362?vs=65592&id=65681

REVISION DETAIL
  https://phabricator.kde.org/D10362

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TextField.qml

To: GB_2, #plasma, #vdg, ngraham, broulik, ndavis
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23798: Polish KCM UI

[Nathaniel Graham]

ngraham added a comment.


  In D23798#527978 , @ndavis wrote:
  
  > What are "Values of an output"? I don't understand what these 2 settings do.
  
  
  I agree that this part is rather confusing.
  
  @romangg can confirm, but as far as I understand it, this is asking you 
whether you want the sittings for the current display (resolution, rotation, 
etc) to always be applied whenever this display is in use, or only to take 
effect when this display is in the current display arrangement.
  
  For example, maybe you want to rotate your laptop's screen only when it is 
plugged into an external display, so you can put the laptop vertically and have 
more vertical space.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish KCM UI

[Filip Fila]

filipf added a comment.


  In D23798#527978 , @ndavis wrote:
  
  > What are "Values of an output"? I don't understand what these 2 settings do.
  
  
  +1

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish KCM UI

[Noah Davis]

ndavis added a comment.


  What are "Values of an output"? I don't understand what these 2 settings do.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23795: HiDPI icon in buttons and menus

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:774764b0c5e8: HiDPI icon in buttons and menus (authored 
by Guo Yunhe ).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23795?vs=65662&id=65680

REVISION DETAIL
  https://phabricator.kde.org/D23795

AFFECTED FILES
  gui/ksysguard.cpp

To: guoyunhe, #plasma, ngraham
Cc: #plasma, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23794: HiDPI icon pixmap

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:5906261d6776: HiDPI icon pixmap (authored by Guo Yunhe 
).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23794?vs=65661&id=65679

REVISION DETAIL
  https://phabricator.kde.org/D23794

AFFECTED FILES
  processui/ProcessModel.cpp

To: guoyunhe, #plasma, ngraham
Cc: GB_2, #plasma, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23798: Polish KCM UI

[Björn Feber]

GB_2 added a comment.


  +1

INLINE COMMENTS

> Screen.qml:65
>  onClicked: kcm.identifyOutputs()
>  text: i18n("Identify")
>  focusPolicy: Qt.NoFocus

Icon: "documentinfo"

> Screen.qml:71
>  onClicked: resetTotalSize()
>  text: i18n("Center view")
>  focusPolicy: Qt.NoFocus

"Center View"
Icon: "zoom-original"

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Carl Schwan]

ognarb added a comment.


  +1
  is there a task somewhere where we can track all the KDE projects still  
using khtml?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma
Cc: ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma
Cc: ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Björn Feber]

GB_2 added a comment.


  +1, let's also focus on fixing bugs for the other two views.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel
Cc: GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Volker Krause]

vkrause added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel
Cc: sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Harald Sitter]

sitter added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel
Cc: sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Sune Vuorela]

svuorela created this revision.
svuorela added reviewers: vkrause, plasma-devel.
Herald added a project: Plasma.
svuorela requested review of this revision.

REVISION SUMMARY
  khtml is going away, so remove the classic mode that relies on it

TEST PLAN
  It's optional, so it can go without much being lost

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23799

AFFECTED FILES
  CMakeLists.txt
  classic/CMakeLists.txt
  classic/CategoryList.cpp
  classic/CategoryList.h
  classic/ClassicMode.cpp
  classic/ClassicMode.h
  classic/configClassic.ui
  classic/main.html
  classic/settings-classic-view.desktop
  classic/systemsettings-classic.css
  systemsettings.categories

To: svuorela, vkrause, plasma-devel
Cc: LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23798: Polish KCM UI

[Nathaniel Graham]

ngraham added a comment.


  I was not 100% sure about the method I chose to get the number of outputs, so 
I would appreciate if #kwin  folks could 
me know if this is wrong or there's a better way.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23798: Polish KCM UI

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: romangg, VDG, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch improves and polishes the new KScreen KCM's UI in a variety of 
ways. A picture
  says a thousand words, so look at the pictures. :)

TEST PLAN
  F7333613: Single display.png 
  F7333611: Multi-display.png 
  F7333612: kcmshell.png 
  
  All functionality that was working before is still working now.

REPOSITORY
  R104 KScreen

BRANCH
  clean-up-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23798

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/output_model.cpp
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: ngraham, romangg, #vdg, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde added a comment.


  *Friendly ping to the reviewers.*

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21273: Add support for newer linux kernel power_supply API

[Méven Car]

meven added a comment.


  Thank you @luc4 for pinging again
  
  I have tested it, it works nicely, apparently the code you are replacing has 
not been working for a while.
  
  The code looks good to me.
  F7332944: Screenshot_20190909_102057.png 

  
  I would be great to have a second opinion though from more .

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart