D24101: [GTK3] Improve button appearance

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:22637c221ee3: [GTK3] Improve button appearance (authored 
by cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24101?vs=66511=66518

REVISION DETAIL
  https://phabricator.kde.org/D24101

AFFECTED FILES
  src/gtk3/widgets/_button.scss

To: cblack, #breeze, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24101: [GTK3] Improve button appearance

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  5.17 and merge to master please.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  button-fixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24101

To: cblack, #breeze, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24098: Remove unnecessary KF5People dependency

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3a27e8ceb53e: Remove unnecessary KF5People dependency 
(authored by heikobecker).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24098?vs=66501=66514

REVISION DETAIL
  https://phabricator.kde.org/D24098

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:d3060530e8f8: Create an empty config (.e.g ~/.gtkrc-2.0) 
if none exists (authored by heikobecker).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24087?vs=66496=66513

REVISION DETAIL
  https://phabricator.kde.org/D24087

AFFECTED FILES
  src/appearancegtk2.cpp

To: heikobecker, gikari, #plasma, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24101: [GTK3] Improve button appearance

[Nathaniel Graham]

ngraham added a comment.


  The focus changes are definitely a bugfix, likely this whole patch is 5.17 
material. Will review later!

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24101

To: cblack, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24101: [GTK3] Improve button appearance

[Carson Black]

cblack created this revision.
cblack added a reviewer: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Buttons now have more vertical padding and now indicate if they have keyboard 
focus.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  button-fixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24101

AFFECTED FILES
  src/gtk3/widgets/_button.scss

To: cblack, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 110 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/110/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Sep 2019 21:11:54 +
 Build duration:
4 min 26 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Plasma 5.17 beta update

[Jonathan Riddell]

plasma-workspace was updated for moved build-dep on appstream-qt

http://embra.edinburghlinux.co.uk/~jr/tmp/pkgdiff_reports/plasma-workspace/5.16.90_to_5.16.90.1/changes_report.html

http://download.kde.org/unstable/plasma/5.16.90/plasma-workspace-5.16.90.1.tar.xz

plasma-workspace;Plasma/5.17;273969f07df72f24fc0ce3b91162289cccee03a3;plasma-workspace-5.16.90.1.tar.xz;9ddf66e8fcec11829a5ff885ea74dd508de305707b17ed17ab06608d96357bdd

KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.13/17/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Sep 2019 21:11:14 +
 Build duration:
47 sec and counting
   CONSOLE OUTPUT
  [...truncated 427 lines...][2019-09-19T21:11:51.963Z] bool ProcessesLocal::setIoNiceness(long pid, int priorityClass, int priority) {[2019-09-19T21:11:51.963Z] ^[2019-09-19T21:11:51.963Z] [ 37%] Built target chronotest[2019-09-19T21:11:51.963Z] [ 38%] Building CXX object processcore/CMakeFiles/processcore.dir/processcore_debug.cpp.o[2019-09-19T21:11:51.963Z] [ 39%] Linking CXX shared library ../bin/liblsofui.so[2019-09-19T21:11:51.963Z] 7 warnings generated.[2019-09-19T21:11:52.248Z] [ 39%] Built target lsofui[2019-09-19T21:11:52.809Z] [ 40%] Linking CXX shared library ../bin/libprocesscore.so[2019-09-19T21:11:53.065Z] [ 40%] Built target processcore[2019-09-19T21:11:53.065Z] Scanning dependencies of target processui_autogen[2019-09-19T21:11:53.065Z] Scanning dependencies of target ksgrd_autogen[2019-09-19T21:11:53.065Z] Scanning dependencies of target ksignalplotter_autogen[2019-09-19T21:11:53.065Z] [ 42%] Automatic MOC for target ksgrd[2019-09-19T21:11:53.065Z] [ 43%] Automatic MOC for target processui[2019-09-19T21:11:53.065Z] [ 44%] Automatic MOC for target ksignalplotter[2019-09-19T21:11:53.628Z] [ 44%] Built target ksgrd_autogen[2019-09-19T21:11:53.628Z] [ 44%] Built target ksignalplotter_autogen[2019-09-19T21:11:53.628Z] Scanning dependencies of target ksgrd[2019-09-19T21:11:53.628Z] [ 46%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/ksgrd_autogen/mocs_compilation.cpp.o[2019-09-19T21:11:53.628Z] [ 46%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/SensorAgent.cpp.o[2019-09-19T21:11:53.628Z] [ 48%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/SensorManager.cpp.o[2019-09-19T21:11:53.628Z] [ 49%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/ksgrd_debug.cpp.o[2019-09-19T21:11:53.628Z] [ 50%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/SensorShellAgent.cpp.o[2019-09-19T21:11:53.628Z] [ 51%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/SensorSocketAgent.cpp.o[2019-09-19T21:11:53.628Z] [ 51%] Built target processui_autogen[2019-09-19T21:11:53.628Z] [ 53%] Generating ui_ProcessWidgetUI.h[2019-09-19T21:11:53.628Z] [ 54%] Generating ui_ReniceDlgUi.h[2019-09-19T21:11:53.628Z] Scanning dependencies of target ksignalplotter[2019-09-19T21:11:53.628Z] [ 55%] Building CXX object signalplotter/CMakeFiles/ksignalplotter.dir/ksignalplotter_autogen/mocs_compilation.cpp.o[2019-09-19T21:11:53.628Z] [ 56%] Building CXX object signalplotter/CMakeFiles/ksignalplotter.dir/ksignalplotter.cpp.o[2019-09-19T21:11:54.193Z] Scanning dependencies of target processui[2019-09-19T21:11:54.193Z] [ 57%] Building CXX object processui/CMakeFiles/processui.dir/processui_autogen/mocs_compilation.cpp.o[2019-09-19T21:11:54.450Z] [ 59%] Building CXX object signalplotter/CMakeFiles/ksignalplotter.dir/kgraphicssignalplotter.cpp.o[2019-09-19T21:11:54.708Z] [ 60%] Building CXX object processui/CMakeFiles/processui.dir/ksysguardprocesslist.cpp.o[2019-09-19T21:11:54.708Z] [ 61%] Building CXX object signalplotter/CMakeFiles/ksignalplotter.dir/ksignalplotter_debug.cpp.o[2019-09-19T21:11:54.708Z] [ 62%] Building CXX object processui/CMakeFiles/processui.dir/ProcessFilter.cpp.o[2019-09-19T21:11:54.708Z] [ 63%] Building CXX object processui/CMakeFiles/processui.dir/ProcessModel.cpp.o[2019-09-19T21:11:54.965Z] [ 65%] Building CXX object processui/CMakeFiles/processui.dir/ReniceDlg.cpp.o[2019-09-19T21:11:55.223Z] [ 66%] Building CXX object processui/CMakeFiles/processui.dir/KTextEditVT.cpp.o[2019-09-19T21:11:55.223Z] [ 67%] Linking CXX shared library ../bin/libksgrd.so[2019-09-19T21:11:55.481Z] [ 67%] Built target ksgrd[2019-09-19T21:11:55.481Z] [ 68%] Building CXX object processui/CMakeFiles/processui.dir/scripting.cpp.o[2019-09-19T21:11:55.743Z] [ 69%] Building CXX object processui/CMakeFiles/processui.dir/processui_debug.cpp.o[2019-09-19T21:11:56.305Z] [ 71%] Linking CXX shared library ../bin/libksignalplotter.so[2019-09-19T21:11:56.305Z] [ 71%] Built target ksignalplotter[2019-09-19T21:11:56.305Z] Scanning dependencies of target signalplotterbenchmark_autogen[2019-09-19T21:11:56.305Z] Scanning dependencies of target signalplottertest_autogen[2019-09-19T21:11:56.305Z] Scanning dependencies of target graphicssignalplotterbenchmark_autogen[2019-09-19T21:11:56.305Z] [ 72%] Automatic MOC for target signalplotterbenchmark[2019-09-19T21:11:56.305Z] [ 74%] Automatic MOC for target graphicssignalplotterbenchmark[2019-09-19T21:11:56.305Z] [ 74%] Automatic MOC for target signalplottertest[2019-09-19T21:11:56.583Z] /usr/home/jenkins/workspace/Plasma/libksysguard/kf5-qt5 FreeBSDQt5.13/processui/scripting.cpp:93:42: error: no member named 'setUrlRequestInterceptor' in 'QWebEngineProfile'; did you mean 

D11352: Use consistent ordering for System Tray items

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0df34cc3f7b8: Use consistent ordering for System Tray 
items (authored by Pitel, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=66209=66505

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #vdg, #plasma, mart, ngraham
Cc: kmaterka, ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 88 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/88/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Sep 2019 20:43:39 +
 Build duration:
3 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/6)0%
(0/18)0%
(0/18)0%
(0/1528)0%
(0/605)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/272)0%
(0/126)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/100)0%
(0/27)core0%
(0/9)0%
(0/9)0%
(0/502)0%
(0/232)icons0%
(0/3)0%
(0/3)0%
(0/241)0%
(0/48)sidebar0%
(0/1)0%
(0/1)0%
(0/309)0%
(0/139)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/104)0%
(0/33)

D24097: Use symbolic icon in intro page

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:95316aa9deec: Use symbolic icon in intro page (authored 
by tienisto, committed by ngraham).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24097?vs=66499=66504

REVISION DETAIL
  https://phabricator.kde.org/D24097

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24098: Remove unnecessary KF5People dependency

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  Not longer needed after 84c8dade3ce0c9cad9da26b083c954655266c639 
.

TEST PLAN
  Still builds fine

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24098

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24097: Use symbolic icon in intro page

[Tien Do Nam]

tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tienisto requested review of this revision.

REVISION SUMMARY
  Use the monochrome icon instead of the colorful icon because of dark themes

REPOSITORY
  R124 System Settings

BRANCH
  symbolic-icon-intro-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24097

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: tienisto, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  On second look, given that each one does actually do slightly different 
things, I rescind my request. Since this contains no new translated strings, 
let's land it on the 5.17 branch.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24096: Restore appstream integration in kicker

[Bhushan Shah]

bshah added a comment.


  Whoops, missed this and committed a fix already

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24096

To: arojas, bshah
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Noah Davis]

ndavis added a comment.


  Works just as well as it did before the patch for me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23241: Show application window icon on AboutPage

[Casper Meijn]

caspermeijn added a comment.


  Can I do anything for this to get merged?

REPOSITORY
  R169 Kirigami

BRANCH
  about_icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23241

To: caspermeijn, mart, apol, #kirigami, hein
Cc: bcooksley, sitter, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, davidedmundson, mart, hein

D23378: Check if sddm user exists

[Filip Fila]

filipf added a comment.


  In D23378#517611 , @ngraham wrote:
  
  > How about refactoring this "does SDDM user exist?" check into a function so 
we don't have to write virtually the same code three times?
  
  
  I would need help with this. If someone can speed things up feel free to 
commandeer the revision.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

[Heiko Becker]

heikobecker updated this revision to Diff 66496.
heikobecker added a comment.


  Used the ReadWrite flag to simplify

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24087?vs=66473=66496

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24087

AFFECTED FILES
  src/appearancegtk2.cpp

To: heikobecker, gikari, #plasma, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24096: Restore appstream integration in kicker

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: bshah.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  This got lost in the move from plasma-desktop

TEST PLAN
  libkickerplugin.so links to appstream-qt, "Uninstall or Manage Add-ons" is 
available in kicker context menu

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24096

AFFECTED FILES
  CMakeLists.txt

To: arojas, bshah
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> appearancegtk2.cpp:96
> +
>  if (gtkrc.open(QIODevice::ReadOnly | QIODevice::Text)) {
>  QString fileContents{gtkrc.readAll()};

I think file creation could be simplified. Just replace WriteOnly flag with 
ReadWrite here. This would mean, that file will be created automatically if it 
doesn't exist. If you think intention to open file also for write is unclear, 
write a comment alongside.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24087

To: heikobecker, gikari, #plasma, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: broulik.
ngraham added a comment.


  The logic looks sane to me and the UI is good, but the 
time-to-empty/time-to-full values still don't always update correctly for me 
after a state change. I suspect this is something that @broulik will need to 
advise on. Maybe it's just not auto-updating itself because it was never needed 
to before this patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  @fvogt Nope, but now you've mentioned that I've added an extra line if 
there's no defaults file found to set the Splash Screen to be the Look & Feel 
name like it originally would do.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23117

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 66489.
The-Feren-OS-Dev added a comment.


  - Based on a code review, re-added original behaviour for Splash Screen 
setting if there's no 'defaults' file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23117?vs=63632=66489

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23117

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  @ngraham Do you still have issues with this? @ndavis could you try this too? 
Or anyone else?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66487.
mthw added a comment.


  Re-order again

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66485=66487

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  In D24070#534771 , @ngraham wrote:
  
  > Heh, how I get this every time my battery is discharging: F7387261: 
Screenshot_20190919_102717.png 
  
  
  Not here: F7387375: Screenshot_20190919_183545.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66485.
mthw added a comment.


  Remove ";", reorder and simplify if clauses

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66482=66485

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> kcm.cpp:429
>  //TODO: option to enable/disable apply? they don't seem required by UI 
> design
> -setSplashScreen(m_selectedPlugin);
>  setLockScreen(m_selectedPlugin);

If the if block above is not entered, this is not done anymore. Intentional?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23117

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  Heh, how I get this every time my battery is discharging: F7387261: 
Screenshot_20190919_102717.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw marked 6 inline comments as done.
mthw added a comment.


  Is the formatting OK?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66482.
mthw added a comment.


  Switch lines

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66480=66482

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM but let's see what @apol thinks.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24087

To: heikobecker, gikari, #plasma, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  In D24070#534721 , @mthw wrote:
  
  > I can do that if @ngraham agrees.
  
  
  Yeah alright, I don't have any strong negative preference. Consistency with 
the volume applet's tooltip is also another argument in favor.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66480.
mthw added a comment.


  Use battery at X%

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66476=66480

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Noah Davis]

ndavis added a comment.


  I think it's redundant to say "change level" since the percentage is always 
the charge level. I also think keeping the language consistent is a good idea. 
The volume tooltip says "Volume at %", which is why I originally suggested 
"Battery at %".

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  I can do that if @ngraham agrees.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Noah Davis]

ndavis added a comment.


  In D24070#534719 , @mthw wrote:
  
  > @ndavis So, generally, you would like to switch the two lines?
  
  
  Yes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  @ndavis So, generally, you would like to switch the two lines?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.17 beta out and branches made

[Jonathan Riddell]

Plasma 5.16.90 is now released
https://www.kde.org/announcements/plasma-5.16.90.php

This is a beta release with final due in three weeks time.

Please test it and work on bug fixes in the Plasma/5.17 branches.  Features
can go into master.  No string changes or new build-dependencies in
Plasma/5.17 branches please.

Jonathan

D24070: Don't use toolTipMainText to show info, rather use the second line

[Noah Davis]

ndavis added a comment.


  In D24070#534585 , @ngraham wrote:
  
  > In D24070#534447 , @ndavis wrote:
  >
  > > In D24070#534378 , @broulik 
wrote:
  > >
  > > > Volume shows the percentage in the main title so this is inconsistent 
now.
  > > >  Perhaps instead show some other information like remaining time in the 
subtext?
  > >
  > >
  > > Yes, perhaps it should be like this:
  > >
  > >   Battery at 100%
  > >   Plugged in, not charging
  > >
  >
  >
  > Yeah, that makes sense to me. Put the primary information in the first 
line, and additional information in the second line. For example:
  >
  >   4:58 remaining
  >   55% Battery charge level
  >
  >
  >
  >
  >   2:08 until fully charged
  >   78% Battery charge level
  >
  >
  >
  >
  >   2:08 until fully charged
  >   78% Battery charge level
  >
  >
  >
  >
  >   Battery 100% charged
  >   Plugged in
  >
  >
  > (not totally sure about that last one, just an idea)
  
  
  I think the percentage is more important than the timer because the timer 
might be misleading. For instance, my own laptop says my battery can last 10 
hours on a full battery, but that seems awfully suspicious to me. I don't think 
I've ever actually gotten 10 hours out of my battery.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66476.
mthw added a comment.


  un-capitalize

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66474=66476

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> batterymonitor.qml:70
> +if (remainingTime > 0) {
> +return i18n("%1 Remaining", 
> KCoreAddons.Format.formatDuration(remainingTime, 
> KCoreAddons.FormatTypes.HideSeconds))
> +}

un-capitalize the R

> batterymonitor.qml:70
> +if (remainingTime > 0) {
> +return i18n("%1 Remaining", 
> KCoreAddons.Format.formatDuration(remainingTime, 
> KCoreAddons.FormatTypes.HideSeconds))
> +}

Un-capitalize the R

> batterymonitor.qml:89
>  if (state === "Charging") {
> -return i18n("%1% Charging", percent)
> +return i18n("%1% Battery charge level", percent)
>  } else if (state === "NoCharge") {

Un-capitalize the B

> batterymonitor.qml:93
>  } else {
> -return i18n("%1% Plugged in", percent)
> +return i18n("%1% Battery charge level", percent)
>  }

Un-capitalize the B

> batterymonitor.qml:96
>  } else {
> -if (remainingTime > 0) {
> -return i18nc("%1 is remaining time, %2 is percentage", "%1 
> Remaining (%2%)",
> - 
> KCoreAddons.Format.formatDuration(remainingTime, 
> KCoreAddons.FormatTypes.HideSeconds),
> - pmSource.data["Battery"]["Percent"])
> -} else {
> -return i18n("%1% Battery Remaining", 
> pmSource.data["Battery"]["Percent"]);
> -}
> +return i18n("%1% Battery charge level", 
> pmSource.data.Battery.Percent)
>  }

Un-capitalize the B

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  In D24070#534687 , @mthw wrote:
  
  > In D24070#534676 , @ngraham 
wrote:
  >
  > > Uh-oh, looks like there's a binding that isn't getting updated properly; 
the "time to charge/time to empty" number always reads as 0:00 for me: 
F7386917: Screenshot_20190919_092713.png 
  > >
  > > Also when I unplug the cable, the tooltip's first line doesn't change: 
F7386912: Screenshot_20190919_092632.png 
  >
  >
  > I had this problem too but it fixes itself after a while, don't know why.
  
  
  Probably a broken binding. perhaps @broulik can help.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  In D24070#534676 , @ngraham wrote:
  
  > Uh-oh, looks like there's a binding that isn't getting updated properly; 
the "time to charge/time to empty" number always reads as 0:00 for me: 
F7386917: Screenshot_20190919_092713.png 
  >
  > Also when I unplug the cable, the tooltip's first line doesn't change: 
F7386912: Screenshot_20190919_092632.png 
  
  
  I had this problem too but it fixes itself after a while, don't know why.
  
  Now it works correctly:
  
  F7386988: Screenshot_20190919_173412.png 

  
  F7386989: Screenshot_20190919_173438.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24011: Provide a telemetrics kcm module for Plasma

[Aleix Pol Gonzalez]

apol updated this revision to Diff 66475.
apol added a comment.


  Polish

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24011?vs=66467=66475

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24011

AFFECTED FILES
  CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/feedback/CMakeLists.txt
  kcms/feedback/Messages.sh
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/kcm_feedback.desktop
  kcms/feedback/package/contents/ui/main.qml
  kcms/feedback/package/metadata.desktop
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Uh-oh, looks like there's a binding that isn't getting updated properly; the 
"time to charge/time to empty" number always reads as 0:00 for me: F7386917: 
Screenshot_20190919_092713.png 
  
  Also when I unplug the cable, the tooltip's first line doesn't change: 
F7386912: Screenshot_20190919_092632.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66474.
mthw added a comment.


  re-added powermanagementDisabled and fixed white spaces

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66470=66474

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  After a9f3a3d 
 
saveSettingsPrivate() errors out if the config file
  doesn't exist. This is because QFile::open(QIODevice::ReadOnly... )
  doesn't create a new file for non-existant filenames, like the
  same invocation with the previously used QIODevice::WriteOnly does.
  
  I'm not sure how likely the absence of the config file is, but it's
  easy to recover from by creating an empty file first. We're trying
  to save our settings afterwards anyway.
  
  A place there this problem occurred is the configsave unit test. The
  filenames passed in ConfigSaveTest::testGtk2 don't exist when running
  the test, causing it to fail without this patch.

TEST PLAN
  - Moved ~/.gtkrc-2.0 out of the way, ran kcmshell5 kde-gtk-config, saving 
didn't error out
  
  -

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24087

AFFECTED FILES
  src/appearancegtk2.cpp

To: heikobecker
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66470.
mthw added a comment.


  Made changes, according to instructions, tested, should work correctly

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66431=66470

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24011: Provide a telemetrics kcm module for Plasma

[Nathaniel Graham]

ngraham added a comment.


  Thanks, looking better.
  
  I don't see explanatory text below the combobox yet; looks like that part 
isn't quite working.
  
  Also, suppose I want to contribute both usage and system information, how do 
I do that? The wording in the combobox implies that I can only contribute one 
or the other. If there are multiple pieces of information that it would make 
sense to send, then a combobox isn't the right control and we'll need to use 
radio buttons or checkboxes--or else we'll need to re-word the options so that 
they reveal the full set of what will be included.

INLINE COMMENTS

> feedback.cpp:41
> +setAboutData(new KAboutData(QStringLiteral("kcm_feedback"),
> +   i18n("Configure User Feedback 
> Settings"),
> +   QStringLiteral("1.0"), QString(), 
> KAboutLicense::LGPL));

Title should be the same as the name i.e. "User Feedback"

> feedback.cpp:42
> +   i18n("Configure User Feedback 
> Settings"),
> +   QStringLiteral("1.0"), QString(), 
> KAboutLicense::LGPL));
> +

Description should be "Configure user feedback settings"

> kcm_feedback.desktop:14
> +Name=User Feedback
> +
> +Categories=Qt;KDE;

Add `Comment=Configure user feedback settings`

> main.qml:23
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.3 as QtControls
> +import org.kde.kirigami 2.6 as Kirigami

"as QQC2"

> main.qml:41
> +wrapMode: Text.WordWrap
> +text: i18n("We make Plasma for you. You can help us improve it 
> by contributing information on how you use it. This allows us to focus on 
> things that matter to you.\n\nContributing usage information is optional and 
> entirely anonymous. It will not associate the data with any kind of unique 
> identifier, and will never track the documents you open, the websites you 
> visit, or any other kind of personal information.\n\nYou can read more about 
> our policy in the following link.")
> +}

1. Since this is no longer just about Plasma, maybe the first sentence should 
say, "We make software for you".

2. Use kuit formatting for newlines: `xi18nc("@info", "Line 1Line 
2Line 3etc.");`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24011

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 44 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/44/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Sep 2019 14:32:02 +
 Build duration:
21 min and counting
   CONSOLE OUTPUT
  [...truncated 258 lines...][2019-09-19T14:53:49.778Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-09-19T14:53:49.778Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12'[2019-09-19T14:53:49.778Z] HUDSON_URL= 'https://build.kde.org/'[2019-09-19T14:53:49.778Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-09-19T14:53:49.778Z] NODE_NAME = 'Docker Swarm-750d055aedfc'[2019-09-19T14:53:49.778Z] HOST  = '750d055aedfc'[2019-09-19T14:53:49.778Z] LESSOPEN  = 'lessopen.sh %s'[2019-09-19T14:53:49.778Z] USER  = 'jenkins'[2019-09-19T14:53:49.778Z] MORE  = '-sl'[2019-09-19T14:53:49.778Z] CSHEDIT   = 'emacs'[2019-09-19T14:53:49.778Z] SHLVL = '2'[2019-09-19T14:53:49.778Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-kf5-qt5 SUSEQt5.12-44'[2019-09-19T14:53:49.778Z] WINDOWMANAGER = 'xterm'[2019-09-19T14:53:49.778Z] PAGER = 'less'[2019-09-19T14:53:49.778Z] EXECUTOR_NUMBER   = '0'[2019-09-19T14:53:49.778Z] CVS_RSH   = 'ssh'[2019-09-19T14:53:49.778Z] LIBGL_DEBUG   = 'quiet'[2019-09-19T14:53:49.778Z] STAGE_NAME= 'Configuring Build'[2019-09-19T14:53:49.778Z] NODE_LABELS   = 'Docker Swarm-750d055aedfc SUSEQt5.12'[2019-09-19T14:53:49.778Z] XCURSOR_THEME = 'DMZ-Black'[2019-09-19T14:53:49.778Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-09-19T14:53:49.778Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-09-19T14:53:49.778Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-09-19T14:53:49.778Z] PROFILEREAD   = 'true'[2019-09-19T14:53:49.778Z] MAIL  = '/var/mail/jenkins'[2019-09-19T14:53:49.778Z] HOSTTYPE  = 'x86_64'[2019-09-19T14:53:49.778Z] BUILD_ID  = '44'[2019-09-19T14:53:49.778Z] LESSKEY   = '/etc/lesskey.bin'[2019-09-19T14:53:49.778Z] OLDPWD= '/home/jenkins'[2019-09-19T14:53:49.778Z] LC_CTYPE  = 'C.UTF-8'[2019-09-19T14:53:49.778Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-19T14:53:49.778Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-09-19T14:53:49.778Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-09-19T14:53:49.778Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-09-19T14:53:49.778Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-09-19T14:53:49.778Z] QT_SELECT = 'qt5'[2019-09-19T14:53:49.778Z] LANG  = 'en_US.UTF-8'[2019-09-19T14:53:49.778Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-19T14:53:49.778Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-09-19T14:53:49.778Z] [2019-09-19T14:53:49.778Z] [2019-09-19T14:53:49.778Z] == Commencing Configuration:[2019-09-19T14:53:49.778Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12"[2019-09-19T14:53:50.889Z] -- The C compiler identification is GNU 9.2.1[2019-09-19T14:53:50.889Z] -- The CXX compiler identification is GNU 9.2.1[2019-09-19T14:53:50.889Z] -- Check for working C compiler: /usr/bin/cc[2019-09-19T14:53:50.889Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-19T14:53:50.889Z] -- Detecting C compiler ABI info[2019-09-19T14:53:50.889Z] -- Detecting C compiler ABI info - done[2019-09-19T14:53:50.889Z] -- Detecting C compile features[2019-09-19T14:53:50.889Z] -- Detecting C compile features - done[2019-09-19T14:53:50.889Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-19T14:53:51.422Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-19T14:53:51.422Z] -- Detecting CXX compiler ABI info[2019-09-19T14:53:51.422Z] -- Detecting CXX compiler ABI info - done[2019-09-19T14:53:51.422Z] -- Detecting CXX compile features[2019-09-19T14:53:51.422Z] -- Detecting CXX compile features - done[2019-09-19T14:53:51.422Z] Installing in /home/jenkins/install-prefix. Run 

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 109 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/109/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Sep 2019 14:30:32 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 210 lines...][2019-09-19T14:53:59.305Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.13'[2019-09-19T14:53:59.305Z] BUILD_TAG = 'jenkins-Plasma-plasma-desktop-kf5-qt5 FreeBSDQt5.13-109'[2019-09-19T14:53:59.305Z] BUILD_DISPLAY_NAME= '#109'[2019-09-19T14:53:59.305Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/109/display/redirect'[2019-09-19T14:53:59.305Z] USER  = 'jenkins'[2019-09-19T14:53:59.305Z] HOME  = '/home/jenkins'[2019-09-19T14:53:59.305Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/109/'[2019-09-19T14:53:59.305Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/'[2019-09-19T14:53:59.305Z] HUDSON_URL= 'https://build.kde.org/'[2019-09-19T14:53:59.305Z] SHELL = '/usr/local/bin/bash'[2019-09-19T14:53:59.305Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13'[2019-09-19T14:53:59.305Z] MM_CHARSET= 'UTF-8'[2019-09-19T14:53:59.305Z] STAGE_NAME= 'Configuring Build'[2019-09-19T14:53:59.305Z] NODE_NAME = 'FreeBSD Builder 2'[2019-09-19T14:53:59.305Z] BLOCKSIZE = 'K'[2019-09-19T14:53:59.305Z] EXECUTOR_NUMBER   = '0'[2019-09-19T14:53:59.305Z] SHLVL = '0'[2019-09-19T14:53:59.305Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-19T14:53:59.305Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2019-09-19T14:53:59.305Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-09-19T14:53:59.305Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-09-19T14:53:59.305Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-09-19T14:53:59.305Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-09-19T14:53:59.305Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-09-19T14:53:59.305Z] QT_SELECT = 'qt5'[2019-09-19T14:53:59.305Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-19T14:53:59.305Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-09-19T14:53:59.305Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-09-19T14:53:59.305Z] [2019-09-19T14:53:59.305Z] [2019-09-19T14:53:59.305Z] == Commencing Configuration:[2019-09-19T14:53:59.305Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13"[2019-09-19T14:53:59.305Z] -- The C compiler identification is Clang 6.0.1[2019-09-19T14:53:59.573Z] -- The CXX compiler identification is Clang 6.0.1[2019-09-19T14:53:59.573Z] -- Check for working C compiler: /usr/bin/cc[2019-09-19T14:53:59.573Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-19T14:53:59.573Z] -- Detecting C compiler ABI info[2019-09-19T14:53:59.573Z] -- Detecting C compiler ABI info - done[2019-09-19T14:53:59.573Z] -- Detecting C compile features[2019-09-19T14:53:59.841Z] -- Detecting C compile features - done[2019-09-19T14:53:59.841Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-19T14:53:59.841Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-19T14:53:59.841Z] -- Detecting CXX compiler ABI info[2019-09-19T14:54:00.110Z] -- Detecting CXX compiler ABI info - done[2019-09-19T14:54:00.110Z] -- Detecting CXX compile features[2019-09-19T14:54:00.674Z] -- Detecting CXX compile features - done[2019-09-19T14:54:00.674Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-desktop.[2019-09-19T14:54:00.674Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-09-19T14:54:00.674Z] -- Looking for __GLIBC__[2019-09-19T14:54:00.674Z] -- Looking for __GLIBC__ - not found[2019-09-19T14:54:00.674Z] -- Performing Test _OFFT_IS_64BIT[2019-09-19T14:54:00.674Z] -- Performing Test _OFFT_IS_64BIT - 

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 87 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/87/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Sep 2019 14:32:08 +
 Build duration:
20 min and counting
   CONSOLE OUTPUT
  [...truncated 264 lines...][2019-09-19T14:52:13.661Z] LESSOPEN  = 'lessopen.sh %s'[2019-09-19T14:52:13.661Z] USER  = 'jenkins'[2019-09-19T14:52:13.661Z] MORE  = '-sl'[2019-09-19T14:52:13.661Z] CSHEDIT   = 'emacs'[2019-09-19T14:52:13.661Z] SHLVL = '2'[2019-09-19T14:52:13.661Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-kf5-qt5 SUSEQt5.12-87'[2019-09-19T14:52:13.661Z] WINDOWMANAGER = 'xterm'[2019-09-19T14:52:13.661Z] PAGER = 'less'[2019-09-19T14:52:13.661Z] EXECUTOR_NUMBER   = '0'[2019-09-19T14:52:13.661Z] CVS_RSH   = 'ssh'[2019-09-19T14:52:13.661Z] LIBGL_DEBUG   = 'quiet'[2019-09-19T14:52:13.661Z] STAGE_NAME= 'Configuring Build'[2019-09-19T14:52:13.661Z] NODE_LABELS   = 'Docker Swarm-0cadc87bbe20 SUSEQt5.12'[2019-09-19T14:52:13.661Z] XCURSOR_THEME = 'DMZ-Black'[2019-09-19T14:52:13.661Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-09-19T14:52:13.661Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-09-19T14:52:13.661Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-09-19T14:52:13.661Z] PROFILEREAD   = 'true'[2019-09-19T14:52:13.661Z] MAIL  = '/var/mail/jenkins'[2019-09-19T14:52:13.661Z] HOSTTYPE  = 'x86_64'[2019-09-19T14:52:13.661Z] BUILD_ID  = '87'[2019-09-19T14:52:13.661Z] LESSKEY   = '/etc/lesskey.bin'[2019-09-19T14:52:13.661Z] OLDPWD= '/home/jenkins'[2019-09-19T14:52:13.661Z] LC_CTYPE  = 'C.UTF-8'[2019-09-19T14:52:13.661Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-19T14:52:13.661Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-09-19T14:52:13.661Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-09-19T14:52:13.661Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-09-19T14:52:13.661Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-09-19T14:52:13.661Z] QT_SELECT = 'qt5'[2019-09-19T14:52:13.661Z] LANG  = 'en_US.UTF-8'[2019-09-19T14:52:13.661Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-19T14:52:13.661Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-09-19T14:52:13.661Z] [2019-09-19T14:52:13.661Z] [2019-09-19T14:52:13.661Z] == Commencing Configuration:[2019-09-19T14:52:13.661Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12"[2019-09-19T14:52:13.918Z] -- The C compiler identification is GNU 9.2.1[2019-09-19T14:52:13.918Z] -- The CXX compiler identification is GNU 9.2.1[2019-09-19T14:52:13.918Z] -- Check for working C compiler: /usr/bin/cc[2019-09-19T14:52:14.174Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-19T14:52:14.174Z] -- Detecting C compiler ABI info[2019-09-19T14:52:14.174Z] -- Detecting C compiler ABI info - done[2019-09-19T14:52:14.174Z] -- Detecting C compile features[2019-09-19T14:52:14.174Z] -- Detecting C compile features - done[2019-09-19T14:52:14.174Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-19T14:52:14.174Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-19T14:52:14.174Z] -- Detecting CXX compiler ABI info[2019-09-19T14:52:14.174Z] -- Detecting CXX compiler ABI info - done[2019-09-19T14:52:14.174Z] -- Detecting CXX compile features[2019-09-19T14:52:14.174Z] -- Detecting CXX compile features - done[2019-09-19T14:52:14.174Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for systemsettings.[2019-09-19T14:52:14.174Z] -- Looking for __GLIBC__[2019-09-19T14:52:14.428Z] -- Looking for __GLIBC__ - found[2019-09-19T14:52:14.428Z] -- Performing Test _OFFT_IS_64BIT[2019-09-19T14:52:14.428Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-09-19T14:52:14.428Z] -- Performing Test HAVE_DATE_TIME[2019-09-19T14:52:14.428Z] -- Performing Test HAVE_DATE_TIME - Success[2019-09-19T14:52:14.428Z] -- Found KF5Crash: 

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 398 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/398/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Sep 2019 14:30:32 +
 Build duration:
16 min and counting
   CONSOLE OUTPUT
  [...truncated 275 lines...][2019-09-19T14:46:48.269Z] PAGER = 'less'[2019-09-19T14:46:48.269Z] EXECUTOR_NUMBER   = '0'[2019-09-19T14:46:48.269Z] CVS_RSH   = 'ssh'[2019-09-19T14:46:48.269Z] LIBGL_DEBUG   = 'quiet'[2019-09-19T14:46:48.269Z] STAGE_NAME= 'Configuring Build'[2019-09-19T14:46:48.269Z] NODE_LABELS   = 'Docker Swarm-5861ac7b470c SUSEQt5.12'[2019-09-19T14:46:48.269Z] XCURSOR_THEME = 'DMZ-Black'[2019-09-19T14:46:48.269Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-09-19T14:46:48.269Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-09-19T14:46:48.269Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-09-19T14:46:48.269Z] PROFILEREAD   = 'true'[2019-09-19T14:46:48.269Z] MAIL  = '/var/mail/jenkins'[2019-09-19T14:46:48.269Z] HOSTTYPE  = 'x86_64'[2019-09-19T14:46:48.269Z] BUILD_ID  = '398'[2019-09-19T14:46:48.269Z] LESSKEY   = '/etc/lesskey.bin'[2019-09-19T14:46:48.269Z] OLDPWD= '/home/jenkins'[2019-09-19T14:46:48.269Z] LC_CTYPE  = 'C.UTF-8'[2019-09-19T14:46:48.269Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-19T14:46:48.269Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-09-19T14:46:48.269Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-09-19T14:46:48.269Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-09-19T14:46:48.269Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-09-19T14:46:48.269Z] QT_SELECT = 'qt5'[2019-09-19T14:46:48.269Z] LANG  = 'en_US.UTF-8'[2019-09-19T14:46:48.269Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-19T14:46:48.269Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-09-19T14:46:48.269Z] [2019-09-19T14:46:48.269Z] [2019-09-19T14:46:48.269Z] == Commencing Configuration:[2019-09-19T14:46:48.269Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12"[2019-09-19T14:46:52.396Z] -- The C compiler identification is GNU 9.2.1[2019-09-19T14:46:52.919Z] -- The CXX compiler identification is GNU 9.2.1[2019-09-19T14:46:52.919Z] -- Check for working C compiler: /usr/bin/cc[2019-09-19T14:46:52.919Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-19T14:46:52.919Z] -- Detecting C compiler ABI info[2019-09-19T14:46:53.442Z] -- Detecting C compiler ABI info - done[2019-09-19T14:46:53.442Z] -- Detecting C compile features[2019-09-19T14:46:53.442Z] -- Detecting C compile features - done[2019-09-19T14:46:53.442Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-19T14:46:53.442Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-19T14:46:53.442Z] -- Detecting CXX compiler ABI info[2019-09-19T14:46:53.442Z] -- Detecting CXX compiler ABI info - done[2019-09-19T14:46:53.442Z] -- Detecting CXX compile features[2019-09-19T14:46:53.442Z] -- Detecting CXX compile features - done[2019-09-19T14:46:53.964Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2019-09-19T14:46:53.964Z] -- Looking for __GLIBC__[2019-09-19T14:46:54.487Z] -- Looking for __GLIBC__ - found[2019-09-19T14:46:54.487Z] -- Performing Test _OFFT_IS_64BIT[2019-09-19T14:46:54.487Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-09-19T14:46:54.487Z] -- Performing Test HAVE_DATE_TIME[2019-09-19T14:46:54.487Z] -- Performing Test HAVE_DATE_TIME - Success[2019-09-19T14:46:55.583Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.63.0") [2019-09-19T14:46:56.106Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2019-09-19T14:46:57.202Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2019-09-19T14:46:57.202Z] -- Found 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/10/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Sep 2019 14:28:31 +
 Build duration:
6 min 45 sec and counting
   CONSOLE OUTPUT
  [...truncated 197 lines...][2019-09-19T14:35:04.023Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.13'[2019-09-19T14:35:04.023Z] EDITOR= 'vi'[2019-09-19T14:35:04.023Z] ENV   = '/home/jenkins/.shrc'[2019-09-19T14:35:04.023Z] HUDSON_HOME   = '/home/production/data'[2019-09-19T14:35:04.023Z] CCACHE_DIR= '/home/jenkins/.ccache/'[2019-09-19T14:35:04.023Z] BUILD_ID  = '10'[2019-09-19T14:35:04.023Z] OLDPWD= '/usr/home/jenkins'[2019-09-19T14:35:04.024Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.13'[2019-09-19T14:35:04.024Z] _ = '/usr/local/bin/java'[2019-09-19T14:35:04.024Z] TERM  = 'su'[2019-09-19T14:35:04.024Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.13'[2019-09-19T14:35:04.024Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 FreeBSDQt5.13-10'[2019-09-19T14:35:04.024Z] BUILD_DISPLAY_NAME= '#10'[2019-09-19T14:35:04.024Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/10/display/redirect'[2019-09-19T14:35:04.024Z] USER  = 'jenkins'[2019-09-19T14:35:04.024Z] HOME  = '/home/jenkins'[2019-09-19T14:35:04.024Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/10/'[2019-09-19T14:35:04.024Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/'[2019-09-19T14:35:04.024Z] HUDSON_URL= 'https://build.kde.org/'[2019-09-19T14:35:04.024Z] SHELL = '/usr/local/bin/bash'[2019-09-19T14:35:04.024Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.13'[2019-09-19T14:35:04.024Z] MM_CHARSET= 'UTF-8'[2019-09-19T14:35:04.024Z] STAGE_NAME= 'Configuring Build'[2019-09-19T14:35:04.024Z] NODE_NAME = 'FreeBSD Builder 2'[2019-09-19T14:35:04.024Z] BLOCKSIZE = 'K'[2019-09-19T14:35:04.024Z] EXECUTOR_NUMBER   = '0'[2019-09-19T14:35:04.024Z] SHLVL = '0'[2019-09-19T14:35:04.024Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-19T14:35:04.024Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2019-09-19T14:35:04.024Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-09-19T14:35:04.024Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-09-19T14:35:04.024Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-09-19T14:35:04.024Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-09-19T14:35:04.024Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-09-19T14:35:04.024Z] QT_SELECT = 'qt5'[2019-09-19T14:35:04.024Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-19T14:35:04.024Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-09-19T14:35:04.024Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-09-19T14:35:04.024Z] [2019-09-19T14:35:04.024Z] [2019-09-19T14:35:04.024Z] == Commencing Configuration:[2019-09-19T14:35:04.024Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.13"[2019-09-19T14:35:04.301Z] -- The C compiler identification is Clang 6.0.1[2019-09-19T14:35:04.564Z] -- The CXX compiler identification is Clang 6.0.1[2019-09-19T14:35:04.564Z] -- Check for working C compiler: /usr/bin/cc[2019-09-19T14:35:04.564Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-19T14:35:04.564Z] -- Detecting C compiler ABI info[2019-09-19T14:35:04.846Z] -- Detecting C compiler ABI info - done[2019-09-19T14:35:04.846Z] -- Detecting C compile features[2019-09-19T14:35:05.435Z] -- Detecting C compile features - done[2019-09-19T14:35:05.435Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-19T14:35:05.435Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-19T14:35:05.435Z] -- Detecting CXX 

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 13 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/13/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 19 Sep 2019 14:28:24 +
 Build duration:
4 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 326 lines...][2019-09-19T14:32:11.314Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2019-09-19T14:32:11.314Z] [2019-09-19T14:32:11.571Z] C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- atspi (LoadError)[2019-09-19T14:32:11.571Z] 	from C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'[2019-09-19T14:32:11.571Z] 	from -e:1:in `'[2019-09-19T14:32:11.571Z] -- The following REQUIRED packages have been found:[2019-09-19T14:32:11.571Z] [2019-09-19T14:32:11.571Z]  * ECM (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * Qt5Core[2019-09-19T14:32:11.571Z]  * Qt5Gui (required version >= 5.13.0)[2019-09-19T14:32:11.571Z]  * Qt5Widgets[2019-09-19T14:32:11.571Z]  * Qt5DBus[2019-09-19T14:32:11.571Z]  * Qt5Concurrent[2019-09-19T14:32:11.571Z]  * Qt5 (required version >= 5.12.0)[2019-09-19T14:32:11.571Z]  * Gettext[2019-09-19T14:32:11.571Z]  * KF5I18n (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5CoreAddons (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5Service (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5ConfigWidgets (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5JobWidgets (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5KIO (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5Crash (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5Completion (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5WidgetsAddons (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5Wallet (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5Notifications (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5IdleTime (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KF5 (required version >= 5.58.0)[2019-09-19T14:32:11.571Z]  * KDEWin[2019-09-19T14:32:11.571Z]  * Qt5Test[2019-09-19T14:32:11.571Z] [2019-09-19T14:32:11.571Z] -- The following features have been disabled:[2019-09-19T14:32:11.571Z] [2019-09-19T14:32:11.571Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2019-09-19T14:32:11.571Z] [2019-09-19T14:32:11.571Z] -- The following RECOMMENDED packages have not been found:[2019-09-19T14:32:11.571Z] [2019-09-19T14:32:11.571Z]  * Qt5X11Extras (required version >= 5.12.0)[2019-09-19T14:32:11.571Z]Recommended for better integration on X11.[2019-09-19T14:32:11.571Z] [2019-09-19T14:32:11.571Z] -- Configuring done[2019-09-19T14:32:38.168Z] -- Generating done[2019-09-19T14:32:38.168Z] -- Build files have been written to: C:/CI/workspace/Plasma/drkonqi/kf5-qt5 WindowsMSVCQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-09-19T14:32:39.733Z] [2019-09-19T14:32:39.733Z] C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-09-19T14:32:39.996Z] **[2019-09-19T14:32:39.996Z] ** Visual Studio 2019 Developer Command Prompt v16.2.4[2019-09-19T14:32:39.996Z] ** Copyright (c) 2019 Microsoft Corporation[2019-09-19T14:32:39.996Z] **[2019-09-19T14:32:45.367Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-09-19T14:32:46.422Z] [2019-09-19T14:32:46.422Z] jom 1.1.3 - empower your cores[2019-09-19T14:32:46.422Z] [2019-09-19T14:32:47.088Z] jom: parallel job execution disabled for Makefile[2019-09-19T14:32:47.088Z] Scanning dependencies of target qbugzilla_autogen[2019-09-19T14:32:47.377Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-09-19T14:32:47.377Z] Scanning dependencies of target kdbgwin_autogen[2019-09-19T14:32:47.377Z] Scanning dependencies of target lsb_release_autogen[2019-09-19T14:32:47.377Z] Scanning dependencies of target crashtest_autogen[2019-09-19T14:32:47.656Z] [  3%] Automatic MOC for target qbugzilla[2019-09-19T14:32:48.055Z] [  3%] Automatic MOC for target lsb_release[2019-09-19T14:32:48.691Z] [  4%] Built target lsb_release_autogen[2019-09-19T14:32:49.013Z] [  4%] Automatic MOC for target crashtest[2019-09-19T14:32:49.309Z] [  4%] Built target crashtest_autogen[2019-09-19T14:32:49.309Z] Scanning dependencies of target lsb_release[2019-09-19T14:32:52.793Z] [  4%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.obj[2019-09-19T14:32:52.793Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 26 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/26/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Sep 2019 14:28:31 +
 Build duration:
4 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 256 lines...][2019-09-19T14:32:46.203Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-09-19T14:32:46.203Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/26/display/redirect'[2019-09-19T14:32:46.203Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-09-19T14:32:46.203Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2019-09-19T14:32:46.203Z] HUDSON_URL= 'https://build.kde.org/'[2019-09-19T14:32:46.203Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-09-19T14:32:46.203Z] NODE_NAME = 'Docker Swarm-5936d5f7365d'[2019-09-19T14:32:46.203Z] HOST  = '5936d5f7365d'[2019-09-19T14:32:46.203Z] LESSOPEN  = 'lessopen.sh %s'[2019-09-19T14:32:46.203Z] USER  = 'jenkins'[2019-09-19T14:32:46.203Z] MORE  = '-sl'[2019-09-19T14:32:46.203Z] CSHEDIT   = 'emacs'[2019-09-19T14:32:46.203Z] SHLVL = '2'[2019-09-19T14:32:46.203Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 SUSEQt5.12-26'[2019-09-19T14:32:46.203Z] WINDOWMANAGER = 'xterm'[2019-09-19T14:32:46.203Z] PAGER = 'less'[2019-09-19T14:32:46.203Z] EXECUTOR_NUMBER   = '0'[2019-09-19T14:32:46.203Z] CVS_RSH   = 'ssh'[2019-09-19T14:32:46.203Z] LIBGL_DEBUG   = 'quiet'[2019-09-19T14:32:46.203Z] STAGE_NAME= 'Configuring Build'[2019-09-19T14:32:46.203Z] NODE_LABELS   = 'Docker Swarm-5936d5f7365d SUSEQt5.12'[2019-09-19T14:32:46.203Z] XCURSOR_THEME = 'DMZ-Black'[2019-09-19T14:32:46.203Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-09-19T14:32:46.203Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-09-19T14:32:46.203Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-09-19T14:32:46.203Z] PROFILEREAD   = 'true'[2019-09-19T14:32:46.203Z] MAIL  = '/var/mail/jenkins'[2019-09-19T14:32:46.203Z] HOSTTYPE  = 'x86_64'[2019-09-19T14:32:46.203Z] BUILD_ID  = '26'[2019-09-19T14:32:46.203Z] LESSKEY   = '/etc/lesskey.bin'[2019-09-19T14:32:46.203Z] OLDPWD= '/home/jenkins'[2019-09-19T14:32:46.203Z] LC_CTYPE  = 'C.UTF-8'[2019-09-19T14:32:46.203Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-19T14:32:46.203Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-09-19T14:32:46.203Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-09-19T14:32:46.203Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-09-19T14:32:46.203Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-09-19T14:32:46.203Z] QT_SELECT = 'qt5'[2019-09-19T14:32:46.203Z] LANG  = 'en_US.UTF-8'[2019-09-19T14:32:46.203Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-19T14:32:46.203Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-09-19T14:32:46.203Z] [2019-09-19T14:32:46.203Z] [2019-09-19T14:32:46.203Z] == Commencing Configuration:[2019-09-19T14:32:46.203Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12"[2019-09-19T14:32:50.333Z] -- The C compiler identification is GNU 9.2.1[2019-09-19T14:32:50.333Z] -- The CXX compiler identification is GNU 9.2.1[2019-09-19T14:32:50.861Z] -- Check for working C compiler: /usr/bin/cc[2019-09-19T14:32:50.861Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-19T14:32:50.861Z] -- Detecting C compiler ABI info[2019-09-19T14:32:50.861Z] -- Detecting C compiler ABI info - done[2019-09-19T14:32:50.861Z] -- Detecting C compile features[2019-09-19T14:32:50.861Z] -- Detecting C compile features - done[2019-09-19T14:32:50.861Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-19T14:32:50.861Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-19T14:32:50.861Z] -- Detecting CXX compiler ABI info[2019-09-19T14:32:51.385Z] -- Detecting CXX compiler ABI info - 

D24011: Provide a telemetrics kcm module for Plasma

[Aleix Pol Gonzalez]

apol updated this revision to Diff 66467.
apol added a comment.


  Iterated with Nate's feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24011?vs=66351=66467

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24011

AFFECTED FILES
  CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/feedback/CMakeLists.txt
  kcms/feedback/Messages.sh
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/kcm_feedback.desktop
  kcms/feedback/package/contents/ui/main.qml
  kcms/feedback/package/metadata.desktop
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  In D24070#534447 , @ndavis wrote:
  
  > In D24070#534378 , @broulik 
wrote:
  >
  > > Volume shows the percentage in the main title so this is inconsistent now.
  > >  Perhaps instead show some other information like remaining time in the 
subtext?
  >
  >
  > Yes, perhaps it should be like this:
  >
  >   Battery at 100%
  >   Plugged in, not charging
  >
  
  
  Yeah, that makes sense to me. Put the primary information in the first line, 
and additional information in the second line. For example:
  
4:58 remaining
55% Battery charge level
  
  
  
2:08 until fully charged
78% Battery charge level
  
  
  
2:08 until fully charged
78% Battery charge level
  
  
  
Battery 100% charged
Plugged in
  
  (not totally sure about that last one, just an idea)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24080: Fix copying urls to the clipboard

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Addresses an original porting issue.

TEST PLAN
  Addresses the issue in the feedback kcm I've been developing.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24080

AFFECTED FILES
  src/controls/UrlButton.qml
  src/kirigamiplugin.cpp

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D21524: Keep existing configurations' strings

[Heiko Becker]

heikobecker added a comment.


  This breaks the unit test locally as well as on build.kde.org, eg.: 
https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/51/console
 and 
https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/5/console
  
Start 2: configsavetest
  
  2: Test command: 
/var/tmp/paludis/build/kde-kde-gtk-config-scm/work/build/tests/configsavetest
  2: Test timeout computed to be: 1000
  2: * Start testing of ConfigSaveTest *
  2: Config: Using QtTest library 5.13.1, Qt 5.13.1 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 9.2.0)
  2: PASS   : ConfigSaveTest::initTestCase()
  2: QWARN  : ConfigSaveTest::testGtk2() There was unable to write the 
.gtkrc-2.0 file
  2: FAIL!  : ConfigSaveTest::testGtk2() 'instance->saveSettings(pathA)' 
returned FALSE. ()
  2:Loc: 
[/var/tmp/paludis/build/kde-kde-gtk-config-scm/work/kde-gtk-config-scm/tests/configsavetest.cpp(63)]
  2: PASS   : ConfigSaveTest::testGtk3()
  2: PASS   : ConfigSaveTest::cleanupTestCase()
  2: Totals: 3 passed, 1 failed, 0 skipped, 0 blacklisted, 3ms
  2: * Finished testing of ConfigSaveTest *
  2/2 Test #2: configsavetest ...***Failed0.02 sec

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D21524

To: gikari, apol, #plasma
Cc: heikobecker, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24063: applets/kicker: Remove unused commands from Messages.sh

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1528162b167f: applets/kicker: Remove unused commands from 
Messages.sh (authored by aspotashev).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24063?vs=66412=66448

REVISION DETAIL
  https://phabricator.kde.org/D24063

AFFECTED FILES
  applets/kicker/Messages.sh

To: aspotashev, ltoscano, bshah, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Noah Davis]

ndavis added a comment.


  In D24070#534378 , @broulik wrote:
  
  > Volume shows the percentage in the main title so this is inconsistent now.
  >  Perhaps instead show some other information like remaining time in the 
subtext?
  
  
  Yes, perhaps it should be like this:
  
Battery at 100%
Plugged in, not charging

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24068: docs: add contributing guide

[Yuri Chornoivan]

yurchor added a comment.


  Thanks in advance for fixing this minor typo.

INLINE COMMENTS

> CONTRIBUTING.md:58
> +## Contact
> +Real-time communications about the project happens on the IRC channel 
> `#plasma` on freenode and the bridged Matrix room `#plasma:kde.org`.
> +

Typo: "communication" (singular) or "happen"

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24068

To: romangg, #plasma
Cc: yurchor, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24073: Revert "Revert "i18n fixes""

[Luigi Toscano]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:a81d5e0d4405: Revert Revert i18n 
fixes (authored by ltoscano).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24073?vs=66443=66445

REVISION DETAIL
  https://phabricator.kde.org/D24073

AFFECTED FILES
  kcm/package/contents/ui/main.qml

To: ltoscano, #plasma, romangg
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24073: Revert "Revert "i18n fixes""

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Ok, to not block the release translations any longer I accept this as a 
short-term solution and created task T11721 
 on Kirigami board about this issue and 
hope a long-term solution can be found there. Would be nice if translation team 
can provide input there.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24073

To: ltoscano, #plasma, romangg
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24073: Revert "Revert "i18n fixes""

[Bhushan Shah]

bshah added a comment.


  As mentioned on IRC, +1 to this patch. If this violates a coding style, we 
can discuss it in the mailing-list/IRC later and either
  
  - come up with solution to this affecting translations
  - come up with exception
  
  and make change accordingly, but let's try to not block a release on this. I 
am not marking this as accepted, but would be preferred to get this accepted.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24073

To: ltoscano, #plasma, romangg
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24073: Revert "Revert "i18n fixes""

[Roman Gilg]

romangg added a comment.


  As said in the revert if currently there is no other way of making 
translations of long sentences work in QML while respecting the line chars 
limit this needs to go in of course.
  
  I would like to see this resolved long-term such that:
  
  - Translations work of course.
  - Code **always** respects the 100 chars limit. If we do exceptions for 
translated strings because of technical problems this will dilute the rule and 
likely lead to code not respecting it at all.
  
  Could something like this work:
  
i18n(Lorem ipsum dolor sit amet, consectetur adipisici elit,\
 sed eiusmod tempor incidunt ut labore et dolore magna aliqua.)
  
  Or should/could we make the one with `+` work? Who wrote the original QML 
translation capabilities and could he/she give some input on this issue? Would 
be nice to see a path forward before doing the re-revert.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24073

To: ltoscano, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24073: Revert "Revert "i18n fixes""

[Luigi Toscano]

ltoscano created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  As translator, any supposed arbitrary coding style which
  breaks the translation is not acceptable.
  We can certainly discuss the proper long term solution
  about fixing the coding style, about fixing QML, about
  fixing gettext, or any other fix, but knowingly
  breaking the translations is not acceptable.
  
  We can certainly discuss after.
  
  This reverts commit b5fc1a7619ad851c50a7969ab029c2592727b068 
.

TEST PLAN
  Transltions works.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24073

AFFECTED FILES
  kcm/package/contents/ui/main.qml

To: ltoscano
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24068: docs: add contributing guide

[Roman Gilg]

romangg added a comment.


  In D24068#534383 , @broulik wrote:
  
  > > The CHANGELOG keyword is cumbersome to use because the summary line most 
often already tells sufficiently what the commit is about. So it would only be 
a repetition of what is already written. Besides why should we want to have a 
disparity between changelog and commit log anyway?
  >
  > I use the CHANGELOG tag quite often. The difference being that the summary 
is perhaps something like "Avoid null pointer dereference" with CHANGELOG being 
a more friendly line for the changelog "Fix crash when doing xyz".
  
  
  I went quickly through KScreen, libkscreen, KWin, KWayland, plasma-desktop 
and plasma-workspace repositories to check if you're an outlier or if it is 
more often used than I expected. Results:
  
  | Repo | Commits w. `CHANGELOG` | Last usage | Kai Uwe share |
  | KScreen  | 2  | May 2016   | 0%|
  | libkscreen   | 2  | Sep 2017   | 0%|
  | KWin | 2  | Mar 2017   | 100%  |
  | KWayland | 1  | Oct 2016   | 0%|
  | plasma-desktop   | 26 | Jun 2019   | 92%   |
  | plasma-workspace | 41 | Aug 2019   | 88%   |
  |
  
  So I admire your expertness on using the available tools to their fullest 
potential in contrast to everybody else but the numbers also show that the 
concept hasn't really caught on. I think a more integrated approach in the 
commit workflow with the prefix can improve the changelogs also quite much. 
Maybe this will then also encourage people to use the CHANGELOG keyword more 
often. Since of course with a common prefix it would still be possible to use 
the keyword.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24068

To: romangg, #plasma
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24054: Set default visibility for per-process network sensors to true

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:ec2532c5f2df: Set default visibility for per-process 
network sensors to true (authored by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24054?vs=66385=66440

REVISION DETAIL
  https://phabricator.kde.org/D24054

AFFECTED FILES
  plugins/process/network/network.cpp

To: ahiemstra, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24053: Properly handle ProcessAttribute enabled and default visibility

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:e04aa1b7eebb: Properly handle ProcessAttribute enabled 
and default visibility (authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24053?vs=66384=66439

REVISION DETAIL
  https://phabricator.kde.org/D24053

AFFECTED FILES
  processcore/process_attribute.cpp
  processcore/process_attribute.h
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: ahiemstra, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24068: docs: add contributing guide

[Roman Gilg]

romangg updated this revision to Diff 66437.
romangg added a comment.


  - Explain types

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24068?vs=66424=66437

BRANCH
  contributingGuide

REVISION DETAIL
  https://phabricator.kde.org/D24068

AFFECTED FILES
  CONTRIBUTING.md

To: romangg, #plasma
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 43 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/43/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Sep 2019 09:10:06 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4065)0%
(0/2771)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1438)0%
(0/1110)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/823)0%
(0/484)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/231)0%
(0/116)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1026)0%
(0/780)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

D24068: docs: add contributing guide

[Kai Uwe Broulik]

broulik added a comment.


  > The CHANGELOG keyword is cumbersome to use because the summary line most 
often already tells sufficiently what the commit is about. So it would only be 
a repetition of what is already written. Besides why should we want to have a 
disparity between changelog and commit log anyway?
  
  I use the CHANGELOG tag quite often. The difference being that the summary is 
perhaps something like "Avoid null pointer dereference" with CHANGELOG being a 
more friendly line for the changelog "Fix crash when doing xyz".

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24068

To: romangg, #plasma
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/16/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Sep 2019 09:04:55 +
 Build duration:
22 min and counting

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/12/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 19 Sep 2019 09:03:54 +
 Build duration:
17 min and counting
   CONSOLE OUTPUT
  [...truncated 414 lines...][2019-09-19T09:20:09.154Z] [ 11%] Linking CXX executable ..\..\bin\lsb_release.exe[2019-09-19T09:20:09.154Z] main.cpp[2019-09-19T09:20:09.674Z] backtraceparser.cpp[2019-09-19T09:20:09.674Z] mocs_compilation.cpp[2019-09-19T09:20:09.674Z] Scanning dependencies of target qbugzilla[2019-09-19T09:20:09.674Z] [ 12%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/abstract_generator.cpp.obj[2019-09-19T09:20:10.213Z] LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\HostX64\x64\link.exe /nologo @CMakeFiles\lsb_release.dir\objects1.rsp /out:..\..\bin\lsb_release.exe /implib:..\..\lib\lsb_release.lib /pdb:C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\bin\lsb_release.pdb /version:0.0 /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL /subsystem:windows kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\lsb_release.dir/intermediate.manifest CMakeFiles\lsb_release.dir/manifest.res" failed (exit code 1120) with the following output:[2019-09-19T09:20:10.213Z] msvcrtd.lib(exe_winmain.obj) : error LNK2019: unresolved external symbol WinMain referenced in function "int __cdecl invoke_main(void)" (?invoke_main@@YAHXZ)[2019-09-19T09:20:10.213Z] ..\..\bin\lsb_release.exe : fatal error LNK1120: 1 unresolved externals[2019-09-19T09:20:10.213Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\src\tests\CMakeFiles\lsb_release.dir\build.make [bin\lsb_release.exe] Error 2[2019-09-19T09:20:10.213Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\CMakeFiles\Makefile2 [src\tests\CMakeFiles\lsb_release.dir\all] Error 2[2019-09-19T09:20:10.213Z] [ 12%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/apijob.cpp.obj[2019-09-19T09:20:10.213Z] apijob.cpp[2019-09-19T09:20:10.213Z] [ 12%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.obj[2019-09-19T09:20:37.417Z] backtraceparsergdb.cpp[2019-09-19T09:20:37.417Z] [ 13%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/callbacks.cpp.obj[2019-09-19T09:20:37.417Z] backtraceparserkdbgwin.cpp[2019-09-19T09:20:37.417Z] [ 14%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/bugzilla.cpp.obj[2019-09-19T09:20:37.417Z] [ 15%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.obj[2019-09-19T09:20:37.417Z] backtraceparsernull.cpp[2019-09-19T09:20:37.417Z] bugzilla.cpp[2019-09-19T09:20:37.417Z] [ 15%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/outputters.cpp.obj[2019-09-19T09:20:37.417Z] [ 15%] Linking CXX executable ..\..\..\bin\crashtest.exe[2019-09-19T09:20:46.930Z] kdbgwin_process.cpp[2019-09-19T09:20:47.449Z] [ 16%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/connection.cpp.obj[2019-09-19T09:20:47.449Z] abstract_generator.cpp[2019-09-19T09:20:47.449Z] callbacks.cpp[2019-09-19T09:20:47.449Z] outputters.cpp[2019-09-19T09:20:47.449Z] [ 17%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserlldb.cpp.obj[2019-09-19T09:20:47.449Z] [ 18%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/__/drkonqi_debug.cpp.obj[2019-09-19T09:20:47.957Z] connection.cpp[2019-09-19T09:20:47.957Z] backtraceparserlldb.cpp[2019-09-19T09:20:47.957Z] [ 18%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/exceptions.cpp.obj[2019-09-19T09:20:47.957Z] [ 18%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsercdb.cpp.obj[2019-09-19T09:20:48.458Z] drkonqi_debug.cpp[2019-09-19T09:20:48.458Z] [ 19%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/msvc_generator.cpp.obj[2019-09-19T09:20:48.990Z] msvc_generator.cpp[2019-09-19T09:20:48.990Z] [ 20%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/clients/attachmentclient.cpp.obj[2019-09-19T09:20:51.423Z] backtraceparsercdb.cpp[2019-09-19T09:20:51.423Z] [ 21%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.obj[2019-09-19T09:20:52.511Z] [ 21%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_autogen/mocs_compilation.cpp.obj[2019-09-19T09:20:54.409Z] attachmentclient.cpp[2019-09-19T09:20:54.409Z] exceptions.cpp[2019-09-19T09:20:54.409Z] [ 22%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/clients/bugclient.cpp.obj[2019-09-19T09:20:54.409Z] [ 22%] Built target crashtest[2019-09-19T09:20:54.409Z] [ 23%] Building 

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 42 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/42/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Sep 2019 08:56:00 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 258 lines...][2019-09-19T09:10:00.259Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-09-19T09:10:00.259Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12'[2019-09-19T09:10:00.259Z] HUDSON_URL= 'https://build.kde.org/'[2019-09-19T09:10:00.259Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-09-19T09:10:00.259Z] NODE_NAME = 'Docker Swarm-96b802ca7b4b'[2019-09-19T09:10:00.259Z] HOST  = '96b802ca7b4b'[2019-09-19T09:10:00.259Z] LESSOPEN  = 'lessopen.sh %s'[2019-09-19T09:10:00.259Z] USER  = 'jenkins'[2019-09-19T09:10:00.259Z] MORE  = '-sl'[2019-09-19T09:10:00.259Z] CSHEDIT   = 'emacs'[2019-09-19T09:10:00.259Z] SHLVL = '2'[2019-09-19T09:10:00.259Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-kf5-qt5 SUSEQt5.12-42'[2019-09-19T09:10:00.259Z] WINDOWMANAGER = 'xterm'[2019-09-19T09:10:00.259Z] PAGER = 'less'[2019-09-19T09:10:00.259Z] EXECUTOR_NUMBER   = '0'[2019-09-19T09:10:00.259Z] CVS_RSH   = 'ssh'[2019-09-19T09:10:00.259Z] LIBGL_DEBUG   = 'quiet'[2019-09-19T09:10:00.259Z] STAGE_NAME= 'Configuring Build'[2019-09-19T09:10:00.259Z] NODE_LABELS   = 'Docker Swarm-96b802ca7b4b SUSEQt5.12'[2019-09-19T09:10:00.259Z] XCURSOR_THEME = 'DMZ-Black'[2019-09-19T09:10:00.259Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-09-19T09:10:00.259Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-09-19T09:10:00.259Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-09-19T09:10:00.259Z] PROFILEREAD   = 'true'[2019-09-19T09:10:00.259Z] MAIL  = '/var/mail/jenkins'[2019-09-19T09:10:00.259Z] HOSTTYPE  = 'x86_64'[2019-09-19T09:10:00.259Z] BUILD_ID  = '42'[2019-09-19T09:10:00.259Z] LESSKEY   = '/etc/lesskey.bin'[2019-09-19T09:10:00.259Z] OLDPWD= '/home/jenkins'[2019-09-19T09:10:00.259Z] LC_CTYPE  = 'C.UTF-8'[2019-09-19T09:10:00.259Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-09-19T09:10:00.259Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-09-19T09:10:00.259Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-09-19T09:10:00.259Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-09-19T09:10:00.259Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-09-19T09:10:00.259Z] QT_SELECT = 'qt5'[2019-09-19T09:10:00.259Z] LANG  = 'en_US.UTF-8'[2019-09-19T09:10:00.259Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-09-19T09:10:00.259Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-09-19T09:10:00.259Z] [2019-09-19T09:10:00.259Z] [2019-09-19T09:10:00.259Z] == Commencing Configuration:[2019-09-19T09:10:00.259Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12"[2019-09-19T09:10:00.259Z] -- The C compiler identification is GNU 9.2.1[2019-09-19T09:10:04.454Z] -- The CXX compiler identification is GNU 9.2.1[2019-09-19T09:10:04.454Z] -- Check for working C compiler: /usr/bin/cc[2019-09-19T09:10:04.454Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-19T09:10:04.454Z] -- Detecting C compiler ABI info[2019-09-19T09:10:04.454Z] -- Detecting C compiler ABI info - done[2019-09-19T09:10:04.454Z] -- Detecting C compile features[2019-09-19T09:10:04.454Z] -- Detecting C compile features - done[2019-09-19T09:10:04.454Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-19T09:10:04.454Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-19T09:10:04.454Z] -- Detecting CXX compiler ABI info[2019-09-19T09:10:04.454Z] -- Detecting CXX compiler ABI info - done[2019-09-19T09:10:04.454Z] -- Detecting CXX compile features[2019-09-19T09:10:04.454Z] -- Detecting CXX compile features - done[2019-09-19T09:10:04.454Z] Installing in /home/jenkins/install-prefix. Run 

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

[Victor Ryzhykh]

victorr added a comment.


  The “Apply” button stops working after the “Times” mode is activated.
  Before turning on this mode, the rest works fine.
  To fix, you can delete the line “Mode=Times" from the file
  ~/.config/kwinrc and restart the session.
  
  https://bugs.kde.org/show_bug.cgi?id=411584

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22863

To: filipf, #plasma, #vdg, ngraham
Cc: victorr, zzag, romangg, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Kai Uwe Broulik]

broulik added a comment.


  Volume shows the percentage in the main title so this is inconsistent now.
  Perhaps instead show some other information like remaining time in the 
subtext?

INLINE COMMENTS

> batterymonitor.qml:82
>  }
> +if (powermanagementDisabled) {
> +return i18n("Power management is disabled")

This code path will never be reached

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/15/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Sep 2019 08:49:49 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 746 lines...][2019-09-19T08:50:38.604Z]   ^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtGui/qfontmetrics.h:107:5: note: 'width' has been explicitly marked deprecated here[2019-09-19T08:50:38.604Z] QT_DEPRECATED_X("Use QFontMetrics::horizontalAdvance")[2019-09-19T08:50:38.604Z] ^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-09-19T08:50:38.604Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-09-19T08:50:38.604Z] ^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-09-19T08:50:38.604Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-09-19T08:50:38.604Z]   ^[2019-09-19T08:50:38.604Z] /usr/home/jenkins/workspace/Plasma/ksysguard/kf5-qt5 FreeBSDQt5.13/gui/SensorDisplayLib/DancingBars.cpp:169:12: warning: comparison of integers of different signs: 'uint' (aka 'unsigned int') and 'int' [-Wsign-compare][2019-09-19T08:50:38.604Z]   if ( pos >= mBars ) {[2019-09-19T08:50:38.604Z]~~~ ^  ~[2019-09-19T08:50:38.604Z] [ 69%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/LogFile.cpp.o[2019-09-19T08:50:38.604Z] /usr/home/jenkins/workspace/Plasma/ksysguard/kf5-qt5 FreeBSDQt5.13/gui/SensorDisplayLib/FancyPlotter.cpp:125:36: warning: 'width' is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations][2019-09-19T08:50:38.604Z] textMargin = fontMetrics().width(QLatin1Char('x')) + margin()*2 + frameWidth()*2;[2019-09-19T08:50:38.604Z]^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtGui/qfontmetrics.h:111:5: note: 'width' has been explicitly marked deprecated here[2019-09-19T08:50:38.604Z] QT_DEPRECATED_X("Use QFontMetrics::horizontalAdvance")[2019-09-19T08:50:38.604Z] ^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-09-19T08:50:38.604Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-09-19T08:50:38.604Z] ^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-09-19T08:50:38.604Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-09-19T08:50:38.604Z]   ^[2019-09-19T08:50:38.604Z] /usr/home/jenkins/workspace/Plasma/ksysguard/kf5-qt5 FreeBSDQt5.13/gui/SensorDisplayLib/FancyPlotter.cpp:177:39: warning: 'width' is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations][2019-09-19T08:50:38.604Z] int axisTextWidth = fontMetrics().width(i18nc("Largest axis title", "9 "));[2019-09-19T08:50:38.604Z]   ^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtGui/qfontmetrics.h:107:5: note: 'width' has been explicitly marked deprecated here[2019-09-19T08:50:38.604Z] QT_DEPRECATED_X("Use QFontMetrics::horizontalAdvance")[2019-09-19T08:50:38.604Z] ^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-09-19T08:50:38.604Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-09-19T08:50:38.604Z] ^[2019-09-19T08:50:38.604Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-09-19T08:50:38.604Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-09-19T08:50:38.604Z]   ^[2019-09-19T08:50:38.604Z] 1 warning generated.[2019-09-19T08:50:38.604Z] [ 71%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/MultiMeter.cpp.o[2019-09-19T08:50:38.867Z] [ 72%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/MultiMeterSettings.cpp.o[2019-09-19T08:50:38.867Z] [ 73%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/ProcessController.cpp.o[2019-09-19T08:50:38.867Z] 1 warning generated.[2019-09-19T08:50:38.867Z] [ 75%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/SensorLogger.cpp.o[2019-09-19T08:50:38.867Z] [ 76%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/SensorLoggerDlg.cpp.o[2019-09-19T08:50:39.125Z] [ 78%] Building CXX object 

KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Sep 2019 08:26:44 +
 Build duration:
55 sec and counting
   CONSOLE OUTPUT
  [...truncated 741 lines...][2019-09-19T08:27:34.647Z]^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtGui/qfontmetrics.h:111:5: note: 'width' has been explicitly marked deprecated here[2019-09-19T08:27:34.647Z] QT_DEPRECATED_X("Use QFontMetrics::horizontalAdvance")[2019-09-19T08:27:34.647Z] ^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-09-19T08:27:34.647Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-09-19T08:27:34.647Z] ^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-09-19T08:27:34.647Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-09-19T08:27:34.647Z]   ^[2019-09-19T08:27:34.647Z] /usr/home/jenkins/workspace/Plasma/ksysguard/kf5-qt5 FreeBSDQt5.13/gui/SensorDisplayLib/BarGraph.cpp:123:15: warning: 'width' is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations][2019-09-19T08:27:34.647Z]   if ( fm.width( footers[ b ] ) > barWidth )[2019-09-19T08:27:34.647Z]   ^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtGui/qfontmetrics.h:107:5: note: 'width' has been explicitly marked deprecated here[2019-09-19T08:27:34.647Z] QT_DEPRECATED_X("Use QFontMetrics::horizontalAdvance")[2019-09-19T08:27:34.647Z] ^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-09-19T08:27:34.647Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-09-19T08:27:34.647Z] ^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-09-19T08:27:34.647Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-09-19T08:27:34.647Z]   ^[2019-09-19T08:27:34.647Z] /usr/home/jenkins/workspace/Plasma/ksysguard/kf5-qt5 FreeBSDQt5.13/gui/SensorDisplayLib/FancyPlotter.cpp:177:39: warning: 'width' is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations][2019-09-19T08:27:34.647Z] int axisTextWidth = fontMetrics().width(i18nc("Largest axis title", "9 "));[2019-09-19T08:27:34.647Z]   ^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtGui/qfontmetrics.h:107:5: note: 'width' has been explicitly marked deprecated here[2019-09-19T08:27:34.647Z] QT_DEPRECATED_X("Use QFontMetrics::horizontalAdvance")[2019-09-19T08:27:34.647Z] ^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-09-19T08:27:34.647Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-09-19T08:27:34.647Z] ^[2019-09-19T08:27:34.647Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-09-19T08:27:34.647Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-09-19T08:27:34.647Z]   ^[2019-09-19T08:27:34.647Z] /usr/home/jenkins/workspace/Plasma/ksysguard/kf5-qt5 FreeBSDQt5.13/gui/SensorDisplayLib/DancingBars.cpp:169:12: warning: comparison of integers of different signs: 'uint' (aka 'unsigned int') and 'int' [-Wsign-compare][2019-09-19T08:27:34.647Z]   if ( pos >= mBars ) {[2019-09-19T08:27:34.647Z]~~~ ^  ~[2019-09-19T08:27:34.647Z] [ 69%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/LogFile.cpp.o[2019-09-19T08:27:34.647Z] 1 warning generated.[2019-09-19T08:27:34.906Z] [ 71%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/MultiMeter.cpp.o[2019-09-19T08:27:34.906Z] [ 72%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/MultiMeterSettings.cpp.o[2019-09-19T08:27:35.172Z] [ 73%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/ProcessController.cpp.o[2019-09-19T08:27:35.172Z] 1 warning generated.[2019-09-19T08:27:35.172Z] [ 75%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/SensorLogger.cpp.o[2019-09-19T08:27:35.172Z] [ 76%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/SensorLoggerDlg.cpp.o[2019-09-19T08:27:35.172Z] [ 78%] Building CXX object gui/CMakeFiles/kdeinit_ksysguard.dir/SensorDisplayLib/SensorLoggerSettings.cpp.o[2019-09-19T08:27:35.434Z] 2 warnings 

D24068: docs: add contributing guide

[Roman Gilg]

romangg added a comment.


  In D24068#534288 , @ngraham wrote:
  
  > In terms of changelogs, you can already use the FEATURE: and CHANGELOG: 
tags in your commit message. That's already there and similarly we're not 
actually using it. Might it make sense to develop better documentation around 
using those throughout all of KDE?
  
  
  I think that the FEATURE and CHANGELOG keywords are not often used is not a 
problem of missing documentation - it is there after all and I linked to it - 
but that they have issues on a conceptual level:
  
  The FEATURE keyword associates a Bugzilla bug with a commit. But often a new 
feature is not implemented because of a Bugzilla feature request but there was 
a Phabricator task for example.
  The CHANGELOG keyword is cumbersome to use because the summary line most 
often already tells sufficiently what the commit is about. So it would only be 
a repetition of what is already written. Besides why should we want to have a 
disparity between changelog and commit log anyway?
  
  In comparison using the prefix allows to reuse the subject, organize a 
changelog in categories and filter out irrelevant commits for example changes 
to autotests. In a standard case information is not repeated unnecessarily: 
most often already now one writes something like "Fix the poor behavior in 
component". Now one writes: "fix(component): improve behavior".
  
  At last the "special keywords" are something only we in KDE use as far as I 
know, but the Conventional Commits specs, respective the Angular guideline, is 
something a lot of other projects use and their adaption shows that it seems to 
work fine at least for them. Also there are sysadmin/ci tools available to make 
use of it.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24068

To: romangg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24070: Don't use Main text in Tooltip to show info, rather use second line

[Matej Mrenica]

mthw created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mthw requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart