D24223: [RFC] Add global themes that mimic other platforms' workflows

[Fabian Riethmayer]

fabianr added a comment.


  > I'd also consider to make the global theme also change plasma theme, color 
scheme or even application style so that it switches to a even more similiar 
interface. If Cupertino global theme switched to a light version of 
https://store.kde.org/p/1252328/, that would be, well, //extraordinary//. In 
such case, I'd also consider the addition of a Fluent theme. Still, I can see 
why this would be much harder.
  
  Please, no other plasma themes, color themes, application styles, icons, ... 
then the default ones in any official LnF. If we ship them as part of a default 
LnF we would need to support them as well. Documenting and fixing all the 
inconsistencies with the default ones is more then enough :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Luigi Toscano]

ltoscano added a comment.


  I think that the Kate use case is different, as it provides only one paste 
action. Whenever else there are two paste actions available, it's always 
"paste" (with formatting) associated to ctrl-V and "paste without formatting" 
to ctrl-shift-V. So maybe you are talking about pasting with the mouse? If it's 
through right click, both action are clearly visible. If it's through middle 
click, uhm, maybe we can talk about that. But the meaning of the variants of 
paste and their shortcuts has been very stable cross-platforms for a long while.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  Funny thing: I stopped using Notes due to this formatting thing so long ago 
that I cannot remember when exactly. There's a plaintext Kate file on my 
desktop instead.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  @huftis 
  Having thought about this I guess I have my attitude towards the default 
`Ctlr+V` 'Paste' action: it should be without formatting. I can explain why. 
Notes applet is not an application. The reason it exists is to contain quick 
notes and tasks, memos, etc. Such text objects may come from various sources 
with heavy formatting, but Notes //is not// a web page or document processor, 
it shouldn't default to display potentially //hard to read// text (given the 
size of the applet) as a result of `Ctrl+C - Ctrl+V` pasting. Being not an 
application means it can behave differently in some aspects, that's why I find 
the comparison between this applet and other applications //irrelevant//.
  But not only that. Open Kate pls and try to find "Paste with Formatting" 
there. Try to paste some text from this page there. You'll see there's no 
formatting. But Kate is an application, quite powerful one. And //no// 
formatting.
  From the other side, having an way to paste formatted text is quite a neat 
option, that's why I guess it's better to have it untouched (I mean no reason 
to remove it).
  
  > least surprise.
  
  Well, try to Ctrl+V your own comment to Notes on 5.16.5 (it defaults to Paste 
with formatting here). What I see immediately is an ugly white-on-yellow text 
background which comes w/o no doubt from this page formatting. This is actual 
surprise for anyone who wants to make memos.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Nathaniel Graham]

ngraham added a comment.


  In D24181#537896 , @davidedmundson 
wrote:
  
  > > If this behavior is considered objectionable and people hate it 
(personally I like it), perhaps an alternative approach would be to add a UI to 
toggle individual notes between rich text and plain text, with plain text being 
the default? See https://bugs.kde.org/show_bug.cgi?id=406906
  >
  > That would be way better. The backend of the notes applet was written with 
the intention of being able to sync data. There's even a file watcher if 
someone else modifies the notes on disk - but the stupid formatting markup 
always made using that a problem.
  >
  > That's somewhat orthogonal to this discussion unless you're saying this 
replaces paste with/without formatting.
  
  
  The proposed toggle would supplement being able to paste with or without 
formatting (obviously when it's plain-text only it would always paste without 
formatting). I'm proposing this as a way forward since otherwise I suspect 
we'll be endlessly stuck in debate about which behavior is better for the 
default paste action.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[David Edmundson]

davidedmundson added a comment.


  > If this behavior is considered objectionable and people hate it (personally 
I like it), perhaps an alternative approach would be to add a UI to toggle 
individual notes between rich text and plain text, with plain text being the 
default? See https://bugs.kde.org/show_bug.cgi?id=406906
  
  That would be way better. The backend of the notes applet was written with 
the intention of being able to sync data. There's even a file watcher if 
someone else modifies the notes on disk - but the stupid formatting markup 
always made using that a problem.
  
  That's somewhat orthogonal to this discussion unless you're saying this 
replaces paste with/without formatting.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Nathaniel Graham]

ngraham added a comment.


  The reason we decided to make this change was because users were complaining 
that pasting text into the Notes widget preserved formatting. See 
https://bugs.kde.org/show_bug.cgi?id=396507. So clearly not everyone expected 
that.
  
  It's the classic conflict between "the same behavior everywhere" vs 
"contextually appropriate behavior". There is no real objectively correct 
answer here; it's a judgment call. And I agree with the judgment call that 
pasting without formatting is a better default for the Notes widget.
  
  If this behavior is considered objectionable and people hate it (personally I 
like it), perhaps an alternative approach would be to add a UI to toggle 
individual notes between rich text and plain text, with plain text being the 
default? See https://bugs.kde.org/show_bug.cgi?id=406906

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: huftis, broulik, yurchor, ltoscano, aacid, #localization, yerilov, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24223: [RFC] Add global themes that mimic other platforms' workflows

[Nathaniel Graham]

ngraham added a comment.


  In D24223#537838 , @mmustac wrote:
  
  > It took me some seconds to get it where "garden dwarf" points do :-D
  >  I think the previews for all look and feel packages KDE ships by default 
should show somehow the same desktop. Meaning have the same menu open or the 
same applications in the same spot.
  >  Would make it easier to compare them and look more consistent.
  
  
  That's a good idea for apps. However we can't always show the same menu 
because the themes have different ones and in different places.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24223: [WIP] Add global themes that mimic other platforms' workflows

[Nathaniel Graham]

ngraham updated this revision to Diff 66859.
ngraham added a comment.


  Add Unueco theme

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24223?vs=66852=66859

BRANCH
  add-cupertino-global-theme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24223

AFFECTED FILES
  CMakeLists.txt
  lookandfeel/CMakeLists.txt
  lookandfeel/cupertino/contents/defaults
  lookandfeel/cupertino/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/cupertino/contents/previews/fullscreenpreview.jpg
  lookandfeel/cupertino/contents/previews/preview.png
  lookandfeel/cupertino/metadata.desktop
  lookandfeel/cupertino/metadata.json
  lookandfeel/garden_dwarf/contents/defaults
  lookandfeel/garden_dwarf/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/garden_dwarf/contents/previews/fullscreenpreview.jpg
  lookandfeel/garden_dwarf/contents/previews/preview.png
  lookandfeel/garden_dwarf/metadata.desktop
  lookandfeel/garden_dwarf/metadata.json
  lookandfeel/redmond/contents/defaults
  lookandfeel/redmond/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/redmond/contents/previews/fullscreenpreview.jpg
  lookandfeel/redmond/contents/previews/preview.png
  lookandfeel/redmond/metadata.desktop
  lookandfeel/redmond/metadata.json
  lookandfeel/unueco/contents/defaults
  lookandfeel/unueco/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/unueco/contents/previews/fullscreenpreview.jpg
  lookandfeel/unueco/contents/previews/preview.png
  lookandfeel/unueco/metadata.desktop
  lookandfeel/unueco/metadata.json

To: ngraham, #vdg, #plasma
Cc: mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Karl Ove Hufthammer]

huftis added a comment.


  I find ‘Ctrl + V’ doing a ‘paste without formatting’ (with or without the 
renaming) confusing, and it goes against the principle of least surprise, which 
is in general a bad idea. In all(?) other applications, ‘Ctrl + V’ does a 
normal paste, i.e. with formatting (if possible). IMHO, the best solution would 
be:
  
  **Ctrl + V:** Paste
  **Ctrl + Shift + V**: Paste Without Formatting
  
  Then things will work the way the user’s used to (from other applications). 
And if **both** actions are shown in the context menu, the (useful) ‘Paste 
Without Formatting’ option is easy to discover.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: huftis, broulik, yurchor, ltoscano, aacid, #localization, yerilov, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24223: [WIP] Add global themes that mimic other platforms' workflows

[Marijo Mustac]

mmustac added a comment.


  It took me some seconds to get it where "garden dwarf" points do :-D
  I think the previews for all look and feel packages KDE ships by default 
should show somehow the same desktop. Meaning have the same menu open or the 
same applications in the same spot.
  Would make it easier to compare them and look more consistent. I also would 
like to have an option or even the possibility to have the widgets for the 
system tray using the complete screen height, like @niccolove suggested.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24223: [WIP] Add global themes that mimic other platforms' workflows

[Nathaniel Graham]

ngraham added a comment.


  In D24223#537805 , @niccolove 
wrote:
  
  > In Cupertino, I think that the bottom panel should be limited in width and 
should auto-hide.
  
  
  It doesn't auto-hide by default in macOS. I decided to make it span the full 
width of the screen because not doing this is IMO one of the dumbest parts of 
that macOS dock, because it pointlessly  wastes the bottom-left-most and 
bottom-right-most pixels, which are two of the four easiest to click pixels in 
the whole screen.
  
  > Regarding a side panel, I think it's really easy and nice to make the 
system tray somehow full height, that would easily mimick macOS and W10 
:
  >  F7432840: image.png 
  
  
  
  > I'd also consider to make the global theme also change plasma theme, color 
scheme or even application style so that it switches to a even more similiar 
interface. If Cupertino global theme switched to a light version of 
https://store.kde.org/p/1252328/, that would be, well, //extraordinary//. In 
such case, I'd also consider the addition of a Fluent theme. Still, I can see 
why this would be much harder.
  
  No, I explicitly did not want to do this with these themes. The idea is to 
mimic only the functionality of the targeted platforms, not their visual 
styles. There are already dozens of theme packages on https://store.kde.org 
that try to mimic the entire look-and-feel of macOS, Windows, Unity, GNOME, 
etc. We don't need more of those IMO. :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: niccolove, rikmills, cblack, broulik, mvourlakos, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: [WIP] Add global themes that mimic other platforms' workflows

[Niccolò Venerandi]

niccolove added a comment.


  In Cupertino, I think that the apps launcher should be limited in width and 
should auto-hide. 
  Regarding a side panel, I think it's really easy and nice to make the system 
tray somehow full height, that would easily mimick macOS and W10 
:
  F7432840: image.png  
  I'd also consider to make the global theme also change plasma theme, color 
scheme or even application style so that it switches to a even more similiar 
interface. If Cupertino global theme switched to a light version of 
https://store.kde.org/p/1252328/, that would be, well, //extraordinary//. In 
such case, I'd also consider the addition of a Fluent theme. Still, I can see 
why this would be much harder.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: niccolove, rikmills, cblack, broulik, mvourlakos, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: [WIP] Add global themes that mimic other platforms' workflows

[Nathaniel Graham]

ngraham updated this revision to Diff 66852.
ngraham added a comment.


  Add Garden Dwarf theme

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24223?vs=66849=66852

BRANCH
  add-cupertino-global-theme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24223

AFFECTED FILES
  CMakeLists.txt
  lookandfeel/CMakeLists.txt
  lookandfeel/cupertino/contents/defaults
  lookandfeel/cupertino/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/cupertino/contents/previews/fullscreenpreview.jpg
  lookandfeel/cupertino/contents/previews/preview.png
  lookandfeel/cupertino/metadata.desktop
  lookandfeel/cupertino/metadata.json
  lookandfeel/garden_dwarf/contents/defaults
  lookandfeel/garden_dwarf/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/garden_dwarf/contents/previews/fullscreenpreview.jpg
  lookandfeel/garden_dwarf/contents/previews/preview.png
  lookandfeel/garden_dwarf/metadata.desktop
  lookandfeel/garden_dwarf/metadata.json
  lookandfeel/redmond/contents/defaults
  lookandfeel/redmond/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/redmond/contents/previews/fullscreenpreview.jpg
  lookandfeel/redmond/contents/previews/preview.png
  lookandfeel/redmond/metadata.desktop
  lookandfeel/redmond/metadata.json

To: ngraham, #vdg, #plasma
Cc: rikmills, cblack, broulik, mvourlakos, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24225: [Notifications] Add spacing after positioning popup for bottom panel

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:348260db171d: [Notifications] Add spacing after 
positioning popup for bottom panel (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24225?vs=66832=66850

REVISION DETAIL
  https://phabricator.kde.org/D24225

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: [WIP] Add global themes that mimic other platforms workflows

[Nathaniel Graham]

ngraham added a comment.


  In D24223#537790 , @cblack wrote:
  
  > An application launcher of some sort (besides KRunner) seems to be missing
  
  
  The Redmond style has Kickoff.
  
  The Cupertino style has a stripped down kickoff that only shows power and 
history items by default. IIRC macOS doesn't have an application launcher of 
any kind visible by default, just the apps in the Dock and the Applications 
folder which is also in the dock. The concept of this doesn't really exist 
outside of macOS though, and I don't think we have a widget that does nothing 
more than displaying a grid of all installed apps. That's what's needed here.
  
  > 
  > 
  > In D24223#537788 , @ngraham 
wrote:
  > 
  >> One thing I'm running into is the need for a panel style that's always 
hidden until a button in another panel is clicked. Both macOS and Windows 10 
have right screen edge sidebars that only appear when a button in one of the 
default panels is clicked. I like this quite a lot. It's much nicer than having 
the sidebar panel auto-hide and appear when the screen edge is touched with the 
cursor. since that leads to tons of accidental activations of a large panel 
that covers up a lot of the screen--including the window decoration buttons, 
which breaks your ability to fling the cursor into the top-right corner and 
click to quickly close a window.
  > 
  > 
  > I think such a panel type would be nice, but how would adding such a panel 
work in terms of UX since it inherently relies on something other than itself 
by design?
  
  A good question. It could also just be a widget whose expanded form holds 
other widgets, though that's basically just a panel...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: rikmills, cblack, broulik, mvourlakos, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: [WIP] Add global themes that mimic other platforms workflows

[Carson Black]

cblack added a comment.


  An application launcher of some sort (besides KRunner) seems to be missing
  
  In D24223#537788 , @ngraham wrote:
  
  > One thing I'm running into is the need for a panel style that's always 
hidden until a button in another panel is clicked. Both macOS and Windows 10 
have right screen edge sidebars that only appear when a button in one of the 
default panels is clicked. I like this quite a lot. It's much nicer than having 
the sidebar panel auto-hide and appear when the screen edge is touched with the 
cursor. since that leads to tons of accidental activations of a large panel 
that covers up a lot of the screen--including the window decoration buttons, 
which breaks your ability to fling the cursor into the top-right corner and 
click to quickly close a window.
  
  
  I think such a panel type would be nice, but how would adding such a panel 
work in terms of UX since it inherently relies on something other than itself 
by design?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: rikmills, cblack, broulik, mvourlakos, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: [WIP] Add global themes that mimic other platforms workflows

[Nathaniel Graham]

ngraham added a comment.


  One thing I'm running into is the need for a panel style that's always hidden 
until a button in another panel is clicked. Both macOS and Windows 10 have 
right screen edge sidebars that only appear when a button in one of the default 
panels is clicked. I like this quite a lot. It's much nicer than having the 
sidebar panel auto-hide and appear when the screen edge is touched with the 
cursor. since that leads to tons of accidental activations of a large panel 
that covers up a lot of the screen--including the window decoration buttons, 
which breaks your ability to fling the cursor into the top-right corner and 
click to quickly close a window.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: rikmills, cblack, broulik, mvourlakos, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: [WIP] Add global themes that mimic other platforms workflows

[Nathaniel Graham]

ngraham updated this revision to Diff 66849.
ngraham added a comment.


  Add "Redmond" theme

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24223?vs=66836=66849

BRANCH
  add-cupertino-global-theme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24223

AFFECTED FILES
  CMakeLists.txt
  lookandfeel/CMakeLists.txt
  lookandfeel/cupertino/contents/defaults
  lookandfeel/cupertino/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/cupertino/contents/previews/fullscreenpreview.jpg
  lookandfeel/cupertino/contents/previews/preview.png
  lookandfeel/cupertino/metadata.desktop
  lookandfeel/cupertino/metadata.json
  lookandfeel/redmond/contents/defaults
  lookandfeel/redmond/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/redmond/contents/previews/fullscreenpreview.jpg
  lookandfeel/redmond/contents/previews/preview.png
  lookandfeel/redmond/metadata.desktop
  lookandfeel/redmond/metadata.json

To: ngraham, #vdg, #plasma
Cc: rikmills, cblack, broulik, mvourlakos, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24228: [containments/desktop] Use new colorful filter icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  F7431292: Desktop Configuration Filter Icon.png 


TEST PLAN
  Open the desktop configuration dialog.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24228

AFFECTED FILES
  containments/desktop/package/contents/config/config.qml

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Nathaniel Graham]

ngraham updated this revision to Diff 66836.
ngraham added a comment.


  - Show day of the week
  - Show a button to trigger KRunner where the Spotlight button lives in macOS
  - Add an auto-hiding right panel that has a calendar and notification history

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24223?vs=66826=66836

BRANCH
  add-cupertino-global-theme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24223

AFFECTED FILES
  CMakeLists.txt
  lookandfeel/CMakeLists.txt
  lookandfeel/cupertino/contents/defaults
  lookandfeel/cupertino/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/cupertino/contents/previews/fullscreenpreview.jpg
  lookandfeel/cupertino/contents/previews/preview.png
  lookandfeel/cupertino/metadata.desktop
  lookandfeel/cupertino/metadata.json

To: ngraham, #vdg, #plasma
Cc: cblack, broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24224: Start of the accessibility KCM

[Jeremy Whiting]

whiting added a comment.


  Thanks for taking this on Tomaz, Just throwing some ideas out but if it would 
help to have less tabs it might be useful to put all the keyboard features on 
one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard 
Filters and Activation Gestures) The top groupbox of Activation Gestures items 
could be moved to their respective groupboxes also so there are less groupboxes 
on the Keyboard tab than before on these 3 tabs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24225: [Notifications] Add spacing after positioning popup for bottom panel

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Definitely better.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24225

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66834.
tcanabrava added a comment.


  - Make buttons work

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=66831=66834

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24225: [Notifications] Add spacing after positioning popup for bottom panel

[Fabian Vogt]

fvogt added a comment.


  Seems to work here

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24225

To: broulik, #plasma, #vdg
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Nathaniel Graham]

ngraham added a comment.


  Ahh, great ideas!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: cblack, broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Carson Black]

cblack added a comment.


  Some suggestions:
  
  - Have the clock show day of the week
  - Add an applet that triggers KRunner by the system tray (can't remember if 
Plasma upstream has one)
  - Add a "sidebar" panel to the right with a calendar and notifications applet 
(auto hiding of course)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: cblack, broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24225: [Notifications] Add spacing after positioning popup for bottom panel

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise we'll start of with a bigger gap to the bottom than in e.g. a top 
panel

TEST PLAN
  - Spacing is still not identical but a lot closer now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24225

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Björn Feber]

GB_2 added a comment.


  In D23718#536359 , @ngraham wrote:
  
  > The frame's alignment and padding seem off: F7416705: 
Screenshot_20190923_075306.png 
  >
  > Could we use a list more like the one used in the Virtual Desktops KCM and 
the slideshow wallpaper folder list? Then we would have a unified appearance 
(#consistency  :) ).
  
  
  Yeah, use a Kirigami BasicListItem.

INLINE COMMENTS

> main.qml:2
> +/*
> + * Copyright 2018 Kai Uwe Broulik 
> + *

Shouldn't this be you copyright?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This is a 1 - 1 translation of the QWidgets version of the Accessibility
  KCM - Most of the functionality is there, and the layout is the same
  with minor edits. We do need a better layout, this one does not behave
  correctly in Qml (the tabs are too many and if a tab gets out of the
  window, there's no way to click in it without resizing the whole window)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23274: Add "Show intro page" button to System Settings sidebar

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:de351c8ed6c3: Add Show intro page button to 
System Settings sidebar (authored by GB_2).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23274?vs=66829=66830#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23274?vs=66829=66830

REVISION DETAIL
  https://phabricator.kde.org/D23274

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: Add "Show intro page" button to System Settings sidebar

[Björn Feber]

GB_2 updated this revision to Diff 66829.
GB_2 added a comment.


  Swap menu and home button position

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23274?vs=66806=66829

BRANCH
  arcpatch-D23274

REVISION DETAIL
  https://phabricator.kde.org/D23274

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: Add "Show intro page" button to System Settings sidebar

[Nathaniel Graham]

ngraham added a comment.


  Yeah I would say so.

REPOSITORY
  R124 System Settings

BRANCH
  arcpatch-D23274

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: Add "Show intro page" button to System Settings sidebar

[Björn Feber]

GB_2 added a comment.


  Shouldn't the "Show intro page" button be on the left, like in Discover, and 
the hamburger menu button on the right, like in for example Dolphin?

REPOSITORY
  R124 System Settings

BRANCH
  arcpatch-D23274

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Nathaniel Graham]

ngraham added a comment.


  Maybe the contents of the Settings menu could live there, with the addition 
of Quit. Then again this almost seems like a change we'd want to make in 
KXMLGui because apps could benefit when using in-window menubars, not just when 
using a global menu. It's never made sense to have Quit in the File menu! :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Kai Uwe Broulik]

broulik added a comment.


  In D24223#537622 , @ngraham wrote:
  
  > You mean a thing to add the current app/window's name to the left of the 
global menu? What's what Window Title does, and it's quite nice.
  
  
  Pretty much. Ideally also with some common options like Preferences, Quit.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Nathaniel Graham]

ngraham added a comment.


  In D24223#537620 , @broulik wrote:
  
  > Fwiw I would totally love a patch to add an "application menu" to global 
menu applet and/or having a dedicated applet in plasma addons
  
  
  You mean a thing to add the current app/window's name to the left of the 
global menu? What's what Window Title does, and it's quite nice.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Kai Uwe Broulik]

broulik added a comment.


  Fwiw I would totally love a patch to add an "application menu" to global menu 
applet and/or having a dedicated applet in plasma addons

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Nathaniel Graham]

ngraham added a subscriber: mvourlakos.
ngraham added a comment.


  Note that this cannot be landed yet because it requires @mvourlakos' Window 
Title applet, which is not yet upstreamed. I tried to use Active Window 
Control, which is a KDE project, but it was too buggy and crashy and I found it 
to be practically unusable. I recommend upstreaming @mvourlakos's version and 
abandoning the original one or merging @mvourlakos improvements back into the 
original.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: Add "Cupertino" global theme that mimics the macOS workflow

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

TEST PLAN
  Entry in the Global Theme KCM: F7430169: Global Theme.png 

  
  How it looks if you switch to it: F7430176: fullscreenpreview.jpg 


REPOSITORY
  R114 Plasma Addons

BRANCH
  add-cupertino-global-theme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24223

AFFECTED FILES
  CMakeLists.txt
  lookandfeel/CMakeLists.txt
  lookandfeel/cupertino/contents/defaults
  lookandfeel/cupertino/contents/layouts/org.kde.plasma.desktop-layout.js
  lookandfeel/cupertino/contents/previews/fullscreenpreview.jpg
  lookandfeel/cupertino/contents/previews/preview.png
  lookandfeel/cupertino/metadata.desktop
  lookandfeel/cupertino/metadata.json

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCM

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d2f545bfdc5d: Add global animation speed slider to 
workspace options KCM (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22885?vs=65886=66825

REVISION DETAIL
  https://phabricator.kde.org/D22885

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: davidedmundson, #plasma, broulik
Cc: ngraham, GB_2, broulik, anthonyfieroni, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66823.
tcanabrava added a comment.


  - Remove the ui file
  - Rename kcm_access to kcmaccess
  - Fix typos
  - Qml Loads. Now, fix beaury
  - Fix imports and labels
  - Fix most layouts
  - Fix layout for the mouse navigation
  - Initial Working Gestures
  - Add boilerplate
  - Fixes on bell
  - Fix functionality

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24187?vs=66782=66823

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Luigi Toscano]

ltoscano added a comment.


  I think that this requires a bit more of discussion; "Paste" has a specific 
and well expected meaning.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: broulik, yurchor, ltoscano, aacid, #localization, yerilov, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

REPOSITORY
  R124 System Settings

BRANCH
  arcpatch-D23274

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24158: use KBusyIndicatorWidget for all busy indication uses

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:871ed0a975a5: use KBusyIndicatorWidget for all busy 
indication uses (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24158?vs=1=66807

REVISION DETAIL
  https://phabricator.kde.org/D24158

AFFECTED FILES
  CMakeLists.txt
  src/bugzillaintegration/ui/assistantpage_bugzilla_version.ui
  src/statuswidget.cpp
  src/statuswidget.h

To: sitter, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24214: fix default version selection to allow for renamed "unspecified" versions

[Harald Sitter]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:b769764b4727: fix default version selection to allow for 
renamed unspecified versions (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24214?vs=66803=66808

REVISION DETAIL
  https://phabricator.kde.org/D24214

AFFECTED FILES
  src/bugzillaintegration/productmapping.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Marco Martin]

mart updated this revision to Diff 66806.
mart added a comment.


  - correctly hide subcat column

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23274?vs=66780=66806

BRANCH
  arcpatch-D23274

REVISION DETAIL
  https://phabricator.kde.org/D23274

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 14 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/14/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Wed, 25 Sep 2019 10:51:09 +
 Build duration:
6 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 320 lines...][2019-09-25T10:57:19.409Z]   keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy[2019-09-25T10:57:19.409Z]   details.  Use the cmake_policy command to set the policy and suppress this[2019-09-25T10:57:19.409Z]   warning.[2019-09-25T10:57:19.409Z] [2019-09-25T10:57:19.409Z]   Quoted variables like "MSVC" will no longer be dereferenced when the policy[2019-09-25T10:57:19.409Z]   is set to NEW.  Since the policy is not set the OLD behavior will be used.[2019-09-25T10:57:19.409Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2019-09-25T10:57:19.409Z] [2019-09-25T10:57:19.983Z] C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- atspi (LoadError)[2019-09-25T10:57:19.983Z] 	from C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'[2019-09-25T10:57:19.983Z] 	from -e:1:in `'[2019-09-25T10:57:19.983Z] -- The following REQUIRED packages have been found:[2019-09-25T10:57:19.983Z] [2019-09-25T10:57:19.983Z]  * ECM (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * Qt5Core[2019-09-25T10:57:19.983Z]  * Qt5Gui (required version >= 5.13.0)[2019-09-25T10:57:19.983Z]  * Qt5Widgets[2019-09-25T10:57:19.983Z]  * Qt5DBus[2019-09-25T10:57:19.983Z]  * Qt5Concurrent[2019-09-25T10:57:19.983Z]  * Qt5 (required version >= 5.12.0)[2019-09-25T10:57:19.983Z]  * Gettext[2019-09-25T10:57:19.983Z]  * KF5I18n (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5CoreAddons (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5Service (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5ConfigWidgets (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5JobWidgets (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5KIO (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5Crash (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5Completion (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5WidgetsAddons (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5Wallet (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5Notifications (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5IdleTime (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KF5 (required version >= 5.61.0)[2019-09-25T10:57:19.983Z]  * KDEWin[2019-09-25T10:57:19.983Z]  * Qt5Test[2019-09-25T10:57:19.983Z] [2019-09-25T10:57:19.983Z] -- The following features have been disabled:[2019-09-25T10:57:19.983Z] [2019-09-25T10:57:19.983Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2019-09-25T10:57:19.983Z] [2019-09-25T10:57:19.983Z] -- The following RECOMMENDED packages have not been found:[2019-09-25T10:57:19.983Z] [2019-09-25T10:57:19.983Z]  * Qt5X11Extras (required version >= 5.12.0)[2019-09-25T10:57:19.983Z]Recommended for better integration on X11.[2019-09-25T10:57:19.983Z] [2019-09-25T10:57:20.245Z] -- Configuring done[2019-09-25T10:57:23.621Z] -- Generating done[2019-09-25T10:57:23.621Z] -- Build files have been written to: C:/CI/workspace/Plasma/drkonqi/kf5-qt5 WindowsMSVCQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-09-25T10:57:25.628Z] [2019-09-25T10:57:25.629Z] C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-09-25T10:57:25.629Z] **[2019-09-25T10:57:25.629Z] ** Visual Studio 2019 Developer Command Prompt v16.3.0[2019-09-25T10:57:25.629Z] ** Copyright (c) 2019 Microsoft Corporation[2019-09-25T10:57:25.629Z] **[2019-09-25T10:57:32.682Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-09-25T10:57:34.302Z] [2019-09-25T10:57:34.302Z] jom 1.1.3 - empower your cores[2019-09-25T10:57:34.302Z] [2019-09-25T10:57:34.943Z] jom: parallel job execution disabled for Makefile[2019-09-25T10:57:34.943Z] Scanning dependencies of target qbugzilla_autogen[2019-09-25T10:57:35.249Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-09-25T10:57:35.249Z] Scanning dependencies of target kdbgwin_autogen[2019-09-25T10:57:35.249Z] Scanning dependencies of target lsb_release_autogen[2019-09-25T10:57:35.249Z] [  1%] Automatic MOC for target qbugzilla[2019-09-25T10:57:36.057Z] Scanning dependencies of target crashtest_autogen[2019-09-25T10:57:37.078Z] [  3%] Automatic MOC for target 

D24214: fix default version selection to allow for renamed "unspecified" versions

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  plasmashell for example has a "master" instead of "unspecified". if we
  still tried to file a bug against "unspecified" bugzilla will throw rather
  unhelpful errors. instead as a fallback to finding a "proper" version, make
  sure to set the "default" to something sane. if the hardcoded default
  doesn't map to an actual version as per the API we pick the lowest possible
  id and file against that instead. seeing as you cannot remove versions this
  should technically be the "unspecified" version no matter what it was
  renamed to.
  
  BUG: 411983

TEST PLAN
  can file bugs against plasmashell even when kcrash passed an empty or 
unmapped version

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24214

AFFECTED FILES
  src/bugzillaintegration/productmapping.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart