D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-07 Thread Louis-Arnaud Iscla 
LeGast00n added a comment.


  Great work. This plus additional usability issues tackled  in other streams 
will make my full switch to KDE possible (coming from Mac).
  Two relatively minor things:
  
  - desktop icons (e.g. Recycle bin) are also part of it
  - Cupertino should have window control buttons on the left...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: LeGast00n, enriqueme, mart, fabianr, Zren, mmustac, niccolove, rikmills, 
cblack, broulik, mvourlakos, plasma-devel, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 436 - Still Failing!

2019-10-07 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/436/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 08 Oct 2019 03:29:33 +
 Build duration:
1 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 127 lines...][Pipeline] sh[2019-10-08T03:30:28.512Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-08T03:30:33.812Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-08T03:30:33.812Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-08T03:30:34.079Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-08T03:30:34.079Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-08T03:30:34.079Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-08T03:30:34.079Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-08T03:30:34.079Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-08T03:30:34.079Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-08T03:30:34.079Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-08T03:30:34.336Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-08T03:30:34.336Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-08T03:30:36.872Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-08T03:30:36.872Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-08T03:30:36.872Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-08T03:30:36.872Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-08T03:30:36.872Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-08T03:30:36.872Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-08T03:30:37.452Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-08T03:30:37.714Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-08T03:30:37.714Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-08T03:30:37.714Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-08T03:30:37.978Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-08T03:30:39.365Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-08T03:30:39.365Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-08T03:30:39.365Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-08T03:30:39.365Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-08T03:30:39.365Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-08T03:30:39.626Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-08T03:30:39.626Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-08T03:30:39.888Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-08T03:30:39.888Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-08T03:30:39.888Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-08T03:30:39.888Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-08T03:30:39.888Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-08T03:30:39.888Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-08T03:30:40.153Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-08T03:30:40.419Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-08T03:30:40.681Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-08T03:30:40.681Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-08T03:30:40.681Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-08T03:30:40.681Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-08T03:30:40.681Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-08T03:30:40.681Z] Retrieving: Plasma-krunner-kf5-qt5[2019-10-08T03:30:40.681Z] Retrieving: Plasma-kxmlrpcclient-kf5-qt5[2019-10-08T03:30:40.681Z]

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-07 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: kossebau, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now windy conditions are not handled at all. I live in an area with 
very frequent
  windy conditions especially during certain times of year so this is annoying 
because I
  see the purple question mark icon a lot, which in the past has made me stop 
using the
  weather widget.
  
  This patch is an attempt to fix it for NOAA. It's not perfect because I don't 
know how to
  implement this for Wettercom, and we lack a  dedicated "windy conditions" 
Breeze icon,
  so I have re-used `weather-fog` for now. This is not ideal, but hopefully 
it's better
  than nothing. I have filed https://bugs.kde.org/show_bug.cgi?id=412718 to 
track getting
  a better icon.

TEST PLAN
  Before: F7543885: Before.png 
  After: F7543886: After.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  windy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24483

AFFECTED FILES
  dataengines/weather/ions/ion.cpp
  dataengines/weather/ions/ion.h
  dataengines/weather/ions/noaa/ion_noaa.cpp

To: ngraham, kossebau, #plasma
Cc: plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24470: feedback kcm: Use a horizontal slider like GammaRay does

2019-10-07 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 67472.
apol added a comment.


  ehm, typo

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24470?vs=67471=67472

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24470

AFFECTED FILES
  kcms/feedback/package/contents/ui/main.qml

To: apol, #plasma, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24470: feedback kcm: Use a horizontal slider like GammaRay does

2019-10-07 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 67471.
apol added a comment.


  Address kai's comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24470?vs=67435=67471

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24470

AFFECTED FILES
  kcms/feedback/package/contents/ui/main.qml

To: apol, #plasma, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24479: [KCM] Make multi-screen draggability more obvious

2019-10-07 Thread Nathaniel Graham 
ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in Output.qml:272
> Hm, can you still make the hand "close" when you press the button, which is 
> what is typically done for dragging things

I can do that if I accept the left button, but doing so interferes with the 
drag handler. I couldn;t figure out how to make these two play nicely together; 
assistance would be appreciated

> broulik wrote in Output.qml:273
> That won't update when outputs are added/removed, an invokable cannot be 
> signalled

Nah it totally works! :)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24479: [KCM] Make multi-screen draggability more obvious

2019-10-07 Thread Nathaniel Graham 
ngraham updated this revision to Diff 67464.
ngraham added a comment.


  Translate

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24479?vs=67462=67464

BRANCH
  make-draggability-more-obvious (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24479

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml

To: ngraham, romangg, #plasma, #vdg
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24479: [KCM] Make multi-screen draggability more obvious

2019-10-07 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> Output.qml:272
> +cursorShape: Qt.OpenHandCursor
> +acceptedButtons: Qt.NoButton // Otherwise it interferes with the 
> drag handler
> +visible: kcm.outputModel && kcm.outputModel.rowCount() > 1

Hm, can you still make the hand "close" when you press the button, which is 
what is typically done for dragging things

> Output.qml:273
> +acceptedButtons: Qt.NoButton // Otherwise it interferes with the 
> drag handler
> +visible: kcm.outputModel && kcm.outputModel.rowCount() > 1
> +}

That won't update when outputs are added/removed, an invokable cannot be 
signalled

> Screen.qml:59
> +}
> +text: "Drag screens to re-arrange them"
> +visible: kcm.outputModel && kcm.outputModel.rowCount() > 1

`i18n`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24479: [KCM] Make multi-screen draggability more obvious

2019-10-07 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: romangg, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Add a label and use a grabby hand cursor when hovering over a screen when 
there are
  more than one.
  
  BUG: 412303
  FIXED-IN: 5.18.0

TEST PLAN
  F7542106: grabby.png 

REPOSITORY
  R104 KScreen

BRANCH
  make-draggability-more-obvious (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24479

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml

To: ngraham, romangg, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24474: Show menu items tooltip text

2019-10-07 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Displays a tooltip with the action's tooltip text

TEST PLAN
  Manually

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24474

AFFECTED FILES
  src/controls/private/ActionMenuItem.qml

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
davidedmundson, mart, hein

D5961: Adoption of KUserFeedback for Discover

2019-10-07 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit!

INLINE COMMENTS

> DiscoverWindow.qml:54
> +text: i18n("Submit usage information")
> +tooltip: i18n("Sends anonymized usage information to KDE to better 
> understand its users. For more information see 
> https://kde.org/privacypolicy-apps.php.;)
> +onTriggered: {

to better understand its users -> so we can better understand our users

REPOSITORY
  R134 Discover Software Store

BRANCH
  arcpatch-D5961_3

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5961: Adoption of KUserFeedback for Discover

2019-10-07 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 67448.
apol added a comment.


  ++verbosity
  
  WRT the server error, I'd like to have the patch in before configuring the 
server to acknowledge Discover.

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5961?vs=67441=67448

BRANCH
  arcpatch-D5961_3

REVISION DETAIL
  https://phabricator.kde.org/D5961

AFFECTED FILES
  CMakeLists.txt
  discover/CMakeLists.txt
  discover/DiscoverObject.cpp
  discover/discover.schema
  discover/plasmauserfeedback.kcfg
  discover/plasmauserfeedback.kcfgc
  discover/qml/DiscoverWindow.qml
  discover/qml/SourcesPage.qml
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 435 - Still Failing!

2019-10-07 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/435/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 07 Oct 2019 17:07:11 +
 Build duration:
2 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 127 lines...][Pipeline] sh[2019-10-07T17:08:53.063Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-07T17:08:58.127Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-07T17:08:58.127Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-07T17:08:58.127Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-07T17:08:58.642Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-07T17:08:58.642Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-07T17:08:58.642Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-07T17:08:58.642Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-07T17:08:59.155Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-07T17:08:59.155Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-07T17:08:59.155Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-07T17:08:59.668Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-07T17:09:00.188Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-07T17:09:00.188Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-07T17:09:00.188Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-07T17:09:00.188Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-07T17:09:00.188Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-07T17:09:00.188Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-07T17:09:00.188Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-07T17:09:03.367Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-07T17:09:03.367Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-07T17:09:03.367Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-07T17:09:03.367Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-07T17:09:03.367Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-07T17:09:03.367Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-07T17:09:03.880Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-07T17:09:03.880Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-07T17:09:03.880Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-07T17:09:03.880Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-07T17:09:03.880Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-07T17:09:03.880Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-07T17:09:04.393Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-07T17:09:04.393Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-07T17:09:04.393Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-07T17:09:04.393Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-07T17:09:04.393Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-07T17:09:04.393Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-07T17:09:04.393Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-07T17:09:04.905Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-07T17:09:06.605Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-07T17:09:06.605Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-07T17:09:06.605Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-07T17:09:06.605Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-07T17:09:06.605Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-07T17:09:07.118Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-07T17:09:07.118Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-07T17:09:07.118Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-07T17:09:07.118Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-07T17:09:07.118Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-07T17:09:07.631Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-07T17:09:07.631Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-07T17:09:07.631Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-07T17:09:07.631Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-07T17:09:08.709Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-07T17:09:08.709Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-07T17:09:08.709Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-07T17:09:08.709Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-07T17:09:08.709Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-07T17:09:08.709Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-07T17:09:08.709Z] Retrieving: Plasma-krunner-kf5-qt5[2019-10-07T17:09:08.709Z] Retrieving:

D24265: support global edit mode

2019-10-07 Thread Marco Martin 
mart added a comment.


  In D24265#541411 , @GB_2 wrote:
  
  > A few bugs I found:
  >
  > - when you open the desktop context menu it enters the edit mode 
automatically (probably because it thinks you still click)
  
  
  gah, yet another bug of the folderview mode :/
  
  > - after closing the panel controller or "Add Widgets..." sidebar it closes 
the edit mode too
  
  hmm, not sure it's a bad thing, it all makes this mode to automatically 
exit.. which makes it almost a "quasimode", countering a bit the evils of being 
a modal ui

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D5961: Adoption of KUserFeedback for Discover

2019-10-07 Thread Nathaniel Graham 
ngraham added a comment.


  Clicking "Submit Feedback" produces the following:
  
org.kde.UserFeedback: failed to submit user feedback: "Error transferring 
https://telemetry.kde.org/receiver/submit/org.kde.discover - server replied: 
Not Found" "\nUnknown product." . Calling scheduleNextSubmission with minTime 4 
minutes
  
  Is this a bug in the patch or in the server?

INLINE COMMENTS

> DiscoverWindow.qml:53
> +id: submitStatisticsAction
> +text: i18n("Submit information")
> +onTriggered: {

1. What information? I'd change it to say "Submit usage statistics" (or 
whatever).
2. When you click on this, nothing visibly happens in the UI. I would recommend 
showing a passiveNotification saying some kind of message acknowledging that 
something just happened.

> DiscoverWindow.qml:60
> +id: feedbackSettingsAction
> +text: i18n("Feedback settings...")
> +onTriggered: {

Actions need to start with a verb:

- Change feedback settings...
- Configure feedback settings...

etc.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5961: Adoption of KUserFeedback for Discover

2019-10-07 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 67441.
apol added a comment.


  oops sources page title

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5961?vs=67423=67441

BRANCH
  arcpatch-D5961_3

REVISION DETAIL
  https://phabricator.kde.org/D5961

AFFECTED FILES
  CMakeLists.txt
  discover/CMakeLists.txt
  discover/DiscoverObject.cpp
  discover/discover.schema
  discover/plasmauserfeedback.kcfg
  discover/plasmauserfeedback.kcfgc
  discover/qml/DiscoverWindow.qml
  discover/qml/SourcesPage.qml
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5961: Adoption of KUserFeedback for Discover

2019-10-07 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D5961#543062 , @ngraham wrote:
  
  > So close! The Settings page still says "Sources" in its header rather than 
"Settings."
  >
  > Also it might be nice to have the actions visible on the toolbar when 
there's room rather than always having them all in an overflow menu. Other than 
that, looks good.
  
  
  That's kirigami's decision to hide, and given they don't have an icon, I'd 
say it makes sense as is.
  Note the user will have reminders showing the config dialog.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24471: [KRDB] Remove Oxygen-era colour exporting code

2019-10-07 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Can confirm that it fixes the bug and the fix conceptually makes sense. I'd 
like a review from a #plasma  person 
to confirm before landing this though.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  krdb-remove-oxygen-era-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24471

To: cblack, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24471: [KRDB] Remove Oxygen-era colour exporting code

2019-10-07 Thread Carson Black 
cblack added a comment.


  In D24471#543113 , @ngraham wrote:
  
  > Is this the other half for fixing 
https://bugs.kde.org/show_bug.cgi?id=412331?
  
  
  It'll get rid of the bug on its own by not exporting colours at all. (so 
instead of a mixture of following/not-following, it'll just not follow at all)
  This patch is primarily intended to get something that's known working as a 
solution in before 5.17 releases. While my other patches related to 
  GTK2 recoloration *should* work, they're not as well tested as just disabling 
the behavior that results in graphical oddities in the first place.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24471

To: cblack, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24471: [KRDB] Remove Oxygen-era colour exporting code

2019-10-07 Thread Nathaniel Graham 
ngraham added a comment.


  Is this the other half for fixing https://bugs.kde.org/show_bug.cgi?id=412331?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24471

To: cblack, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24471: [KRDB] Remove Oxygen-era colour exporting code

2019-10-07 Thread Carson Black 
cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  GTK2 colours are no longer exported.
  This is necessary in 2019 because most popular GTK2 themes (including Breeze 
GTK) primarily use pixmaps 
  which cannot respect these colours. This results in odd-looking mixtures of 
some widgets following the
  colourscheme and some not.

TEST PLAN
  See that GTK2 colours are no longer exported and that GTK2 themes with a 
mixture of pixmaps/not pixmaps
  don't display colour inconsistencies.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  krdb-remove-oxygen-era-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24471

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kmenuedit » kf5-qt5 SUSEQt5.12 - Build # 22 - Failure!

2019-10-07 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20SUSEQt5.12/22/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 07 Oct 2019 15:25:56 +
 Build duration:
3 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 127 lines...][2019-10-07T15:27:36.022Z]  > git checkout -f 7db3c74d0335682a78bbcb741325004b36a68a90 # timeout=10[2019-10-07T15:27:39.400Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project kmenuedit --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-07T15:27:45.611Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-07T15:27:45.611Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-07T15:27:45.611Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-07T15:27:45.611Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-07T15:27:46.122Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-07T15:27:46.122Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-07T15:27:46.122Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-07T15:27:46.122Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-07T15:27:46.634Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-07T15:27:46.634Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-07T15:27:46.634Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-07T15:27:47.145Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-07T15:27:47.145Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-07T15:27:47.145Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-07T15:27:47.145Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-07T15:27:47.658Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-07T15:27:47.658Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-07T15:27:47.658Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-07T15:27:47.658Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-07T15:27:48.173Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-07T15:27:48.173Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-07T15:27:48.173Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-07T15:27:48.173Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-07T15:27:48.684Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-07T15:27:48.684Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-07T15:27:48.684Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-07T15:27:49.196Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-07T15:27:53.323Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-07T15:27:53.323Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-07T15:27:53.323Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-07T15:27:53.323Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-07T15:27:53.323Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-07T15:27:53.835Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-07T15:27:54.909Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-07T15:27:54.909Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-07T15:27:55.423Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-07T15:27:55.423Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-07T15:27:55.423Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-07T15:27:55.423Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-07T15:27:57.814Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-07T15:27:58.887Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-07T15:27:59.401Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-07T15:28:02.575Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-07T15:28:03.649Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-07T15:28:04.161Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-07T15:28:08.217Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-07T15:28:14.779Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-07T15:28:18.834Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-07T15:28:23.903Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-07T15:28:23.903Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-07T15:28:23.903Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-07T15:28:23.903Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-07T15:28:24.413Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-07T15:28:24.413Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-07T15:28:24.413Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-07T15:28:24.413Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-07T15:28:24.925Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-07T15:28:25.438Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-07T15:28:25.438Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-07T15:28:25.438Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-07T15:28:25.438Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-07T15:28:26.513Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-07T15:28:26.513Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-07T15:28:26.513Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-07T15:28:27.587Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-07T15:28:27.587Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-07T15:28:27.587Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-07T15:28:27.587Z] Retrieving:

D24470: feedback kcm: Use a horizontal slider like GammaRay does

2019-10-07 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> main.qml:80
> +var found = false;
> +for(var v in modeOptions) {
> +if (modeOptions[v] === kcm.plasmaFeedbackLevel) {

Use `Array.findIndex`

> main.qml:91
>  
> -onActivated: {
> -kcm.plasmaFeedbackLevel = modeOptions.get(index).value;
> +onValueChanged: {
> +kcm.plasmaFeedbackLevel = modeOptions[value]

Use `onMoved` which is the slider equivalent to `onActivated`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24470

To: apol, #plasma, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24454: Include an emoji picker

2019-10-07 Thread Nathaniel Graham 
ngraham added a comment.


  Cool beans.
  
  Can you make the drawer/sidebar more narrow like we do in Discover? The width 
is hardcoded in Kirigami to something that's just way too high for this 
application IMO.
  
  Also an "all" category on top would be nice too. Many smartphone 
implementations also have a "recently/frequently used" category that's quite 
user-friendly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24454

To: apol, #plasma
Cc: ngraham, davidedmundson, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5961: Adoption of KUserFeedback for Discover

2019-10-07 Thread Nathaniel Graham 
ngraham added a comment.


  So close! The Settings page still says "Sources" in its header rather than 
"Settings."
  
  Also it might be nice to have the actions visible on the toolbar when there's 
room rather than always having them all in an overflow menu. Other than that, 
looks good.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24470: feedback kcm: Use a horizontal slider like GammaRay does

2019-10-07 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of a combo box, which is a bit harder on the wording.
  Also get more texts from kuserfeedback itself, no reason to translate twice.

TEST PLAN
  Tested manually

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24470

AFFECTED FILES
  kcms/feedback/package/contents/ui/main.qml

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24469: Allow the global drawer to become a menu if desired

2019-10-07 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 67434.
nicolasfella added a comment.


  - Rename property

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24469?vs=67433=67434

BRANCH
  toolbarmenu

REVISION DETAIL
  https://phabricator.kde.org/D24469

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

To: nicolasfella, #vdg, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24469: Allow the global drawer to become a menu if desired

2019-10-07 Thread Nathaniel Graham 
ngraham added a comment.


  Nice, anything that improves convergence by makes Kirigami apps feel more at 
home on the desktop is a good thing in my mind. :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24469

To: nicolasfella, #vdg, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24469: Allow the global drawer to become a menu if desired

2019-10-07 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: VDG, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The global drawer is usually used to implement one of two patterns: As 
navigation or as a menu. For both cases a drawer is a suboptimal experience on 
the desktop, where it just looks and feels alien.
  
  In the navigation case this is usually addressed by making the drawer always 
open, e.g. seen in Discover or KDE Connect.
  In the menu case (e.g. seen in plasma-phonebook or Itinerary) this is not 
ideal since the actions are not that much important.
  
  This patch adds a property to the global drawer that allows to morph the 
drawers menu content into a hamburger menu in the toolbar so it behaves more 
like other menus seen on the desktop.
  
  This is opt-in for two reasons: 1) We don't want to break the navigation 
pattern 2) it limits the flexibility of the GlobalDrawer, as custom Items 
cannot be represented.
  
  If the isMenu property is set the drawer handle is hidden on the desktop and 
the toolbar contains a similar looking, but differently behaving hamburger 
button.

TEST PLAN
  Tested with patched plasma-phonebook and unpatched Itinerary on Desktop and 
mobile
  
  #TODO screenshot

REPOSITORY
  R169 Kirigami

BRANCH
  toolbarmenu

REVISION DETAIL
  https://phabricator.kde.org/D24469

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

To: nicolasfella, #vdg, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
davidedmundson, mart, hein

D24361: [Style KCM] Port to new design

2019-10-07 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 67427.
broulik added a comment.


  - Don't let current style mess with preview palette

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24361?vs=67342=67427

REVISION DETAIL
  https://phabricator.kde.org/D24361

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/Messages.sh
  kcms/style/kcm_style.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml
  kcms/style/package/metadata.desktop
  kcms/style/previewitem.cpp
  kcms/style/previewitem.h
  kcms/style/style.desktop
  kcms/style/styleconfig.ui
  kcms/style/stylesmodel.cpp
  kcms/style/stylesmodel.h

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24452: Un-break remote input portal

2019-10-07 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R838:91793221302e: Un-break remote input portal (authored by 
apol).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24452?vs=67407=67425

REVISION DETAIL
  https://phabricator.kde.org/D24452

AFFECTED FILES
  data/CMakeLists.txt
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in

To: apol, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D5961: Adoption of KUserFeedback for Discover

2019-10-07 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 67423.
apol added a comment.


  Move options to Sources, rename Sources back to Settings

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5961?vs=67200=67423

BRANCH
  arcpatch-D5961_2

REVISION DETAIL
  https://phabricator.kde.org/D5961

AFFECTED FILES
  CMakeLists.txt
  discover/CMakeLists.txt
  discover/DiscoverObject.cpp
  discover/discover.schema
  discover/plasmauserfeedback.kcfg
  discover/plasmauserfeedback.kcfgc
  discover/qml/DiscoverWindow.qml
  discover/qml/SourcesPage.qml
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Monday meeting notes for 7/10/2019

2019-10-07 Thread Marco Martin 
Kai Uwe
* Been on vacation last week, before that:
* Rewrote widget style KCM as GridViewKCM, please review D24361
Diff 24361 "[Style KCM] Port to new design" [Needs Review]
https://phabricator.kde.org/D24361
* Make qqc2-desktop-style listen to application style changing D24425
Diff 24425 "Listen to the application style changing" [Needs
Review] https://phabricator.kde.org/D24425
* Add some error reporting for when QML KCM fails to load: D24429 D24430
Diff 24429 "[ConfigModule] Expose mainUi component status and
error string" [Needs Review] https://phabricator.kde.org/D24429
Diff 24430 "[KCModuleLoader] Show error when QML fails to load"
[Accepted] https://phabricator.kde.org/D24430
* Restore cursor thumbnailer: D24431
Diff 24431 "Restore cursor thumbnailer" [Needs Review]
https://phabricator.kde.org/D24431
* Per-origin media controls blacklist, please review D24194
Diff 24194 "Add per-origin media controls blacklist" [Needs
Review] https://phabricator.kde.org/D24194
* Wrote a blog post on this year's Akademy, got published just now
https://blog.broulik.de/2019/10/akademy-2019-in-milan/

David
* I merged a new framework into kwin for showing QtQuick into effects
in a more convenient manner
and it'll allow the effect to render parts on top of windows or on top
of the whole scene
* without creating real windows that then mess up other effects
* generally will be all amazing
* that's mostly it on the plasma side
* I've started helping out on the KIO Fuse stuff to help push that
forwards a bit

Nico Fe
* watched a XDC talk by the libinput maintainer. He talked about "user
devices" and I wondered if we can use that for KDE Connect. Dropped
him an email, he says he's not sure, probably a wayland protocol is
the way to go
* Fixed some DB issues in Koko
* Investigated why Koko on Android doesn't find images. TL;DR KIO
doesn't work on Android even without forking slaves
* Also KDirModel has some widget stuff so you'll get ugly error boxes
Task 11821 "Move KDirModel to KioCore" [Open,Needs Triage] {KF6}
https://phabricator.kde.org/T11821
* Added a plugin system to KCalendarCore, which allows services to
provide and apps to consume calendar data
Diff 24443 "Add a plugin system" [Needs Review]
https://phabricator.kde.org/D24443
reference impl in Calindori
https://invent.kde.org/kde/calindori/merge_requests/37
For review: D24046 "Allow triggering sort from QML" [Needs Review]
https://phabricator.kde.org/D24046
* Worked on a Android backend for KPeople. Allows plasma-phonebook to
show Android contact. Painfully slow ATM, but I have ideas for
improvement
* Random improvements for plasma-phonebook
* Found some visual weirdness that only happens with material style

Bhushan
- Blogged: 
https://www.plasma-mobile.org/2019/10/04/Plasma-Mobile-Weekly-update-1.html
 received quite well
- Worked on fixing telephony here and there
- Testing shell changes done by Marco

Arjen
* right, so the opensuse security team found a few issues with the
network helper I introduced for ksysguard's per-process networking
info
* I created https://phabricator.kde.org/D24359 to fix them
   Diff 24359 "Fix a number of issues found by the OpenSuse security
team in networkhelper" [Needs Review]
https://phabricator.kde.org/D24359
* if someone can review that before 5.17 is tagged that'd be nice :)
* I'm also working on some kirigami things, but nothing posted yet so
that's for next week :)

Jonathan
tags and tars for 5.17 on Thursday
release the following tuesday
on't be late!

Aleix
* I looked into ibus + plasma integration a bit, because we wanted a
way to enter emoji for users, I sent a couple of patches in this
regard, all in except for the important one
https://phabricator.kde.org/D24454
Diff 24454 "Include an emoji picker" [Needs Review]
https://phabricator.kde.org/D24454
* I also merged the kuserfeedback bit last week I think, there's some
more work upcoming, including a blog post I'd like to publish this
week on the subject
* it could well use revision and extension, also it needs to be
considered from the kuserfeedback server altogether
* also shout out to plasma hackers, especially those using and testing
wayland, I'd recommend adopting ibus right now as text input method
* it works much better and will allow us to polish a ton of things
which are really necessary

Marco
# Plasma
* more work on the edit mode patches D24263 D24264 and D24265 should
be ready to land, please review
# Kirigami
* PageRow better horizontal flicking behavior
* Finalized PagePool, (Kirigami 2.11 import version)
* make scrollview frames follow the margins from QStyle
* done a patch for BUG 411758, caused a bad regression, reverted just
before tagging (phew:)
* PagePool always caches the latest page created
# Plasma Mobile
* fixed a bug that made a mess in the top panel
* started a refactor of the top panel to make it beautiful, but most
important, simpler code, more robust and less error prone

--
Marco Martin

D24454: Include an emoji picker

2019-10-07 Thread David Edmundson 
davidedmundson added a comment.


  There's coding style issues, as it's new code you can hopefully just run 
clang-format over it.

INLINE COMMENTS

> emojier.cpp:65
> +"Need to create the dictionaries again.";
> +return;
> +}

leak of list?

> emojier.cpp:80
> +QVariant data(const QModelIndex & index, int role) const override {
> +if (index.parent().isValid() || index.column() != 0)
> +return {};

there's a method in QAIM now called checkIndex() which can handle all this for 
you magically.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24454

To: apol, #plasma
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24454: Include an emoji picker

2019-10-07 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 67413.
apol added a comment.


  Remove unused empty file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24454?vs=67412=67413

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24454

AFFECTED FILES
  applets/kimpanel/backend/ibus/CMakeLists.txt
  applets/kimpanel/backend/ibus/emojier/CMakeLists.txt
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/org.kde.plasma.emojier.desktop
  applets/kimpanel/backend/ibus/emojier/resources.qrc
  applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml
  applets/kimpanel/backend/ibus/emojier/ui/emojier.qml

To: apol, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24454: Include an emoji picker

2019-10-07 Thread Kai Uwe Broulik 
broulik added a comment.


  Screenshot, please

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24454

To: apol, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 420 - Still Failing!

2019-10-07 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/420/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 07 Oct 2019 09:57:35 +
 Build duration:
3 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 127 lines...][Pipeline] sh[2019-10-07T09:59:23.870Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-desktop --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-07T09:59:31.327Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-07T09:59:31.327Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-07T09:59:31.327Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-07T09:59:31.327Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-07T09:59:31.327Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-07T09:59:31.327Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-07T09:59:31.327Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-07T09:59:31.327Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-07T09:59:31.327Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-07T09:59:31.829Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-07T09:59:31.829Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-07T09:59:31.829Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-07T09:59:32.332Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-07T09:59:32.332Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-07T09:59:32.332Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-07T09:59:32.332Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-07T09:59:34.699Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-07T09:59:34.699Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-07T09:59:34.699Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-07T09:59:34.699Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-07T09:59:35.200Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-07T09:59:35.200Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-07T09:59:35.200Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-07T09:59:35.699Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-07T09:59:35.699Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-07T09:59:35.699Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-07T09:59:35.699Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-07T09:59:39.685Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-07T09:59:40.186Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-07T09:59:40.687Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-07T09:59:40.687Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-07T09:59:40.687Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-07T09:59:40.687Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-07T09:59:42.344Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-07T09:59:42.345Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-07T09:59:42.345Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-07T09:59:42.345Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-07T09:59:42.345Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-07T09:59:42.844Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-07T09:59:43.894Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-07T09:59:43.894Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-07T09:59:44.396Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-07T09:59:48.375Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-07T09:59:48.876Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-07T09:59:49.376Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-07T09:59:55.514Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-07T10:00:01.644Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-07T10:00:03.305Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-07T10:00:08.300Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-07T10:00:08.300Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-07T10:00:08.300Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-07T10:00:08.300Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-07T10:00:08.800Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-07T10:00:08.800Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-07T10:00:09.300Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-07T10:00:09.300Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-07T10:00:09.802Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-07T10:00:09.802Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-07T10:00:09.802Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-07T10:00:09.802Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-07T10:00:10.302Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-07T10:00:11.351Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-07T10:00:11.351Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-07T10:00:11.351Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-07T10:00:11.351Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-07T10:00:11.351Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-07T10:00:11.851Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-07T10:00:11.851Z] Retrieving: Plasma-krunner-kf5-qt5[2019-10-07T10:00:11.851Z] Retrieving: Plasma-kxmlrpcclient-kf5-qt5[2019-10-07T10:00:11.851Z]

D24454: Include an emoji picker

2019-10-07 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Shows all emoji in categories, it will save the new emoji into the
  clipboard.

TEST PLAN
  Manual testing

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24454

AFFECTED FILES
  applets/kimpanel/backend/ibus/CMakeLists.txt
  applets/kimpanel/backend/ibus/emojier/CMakeLists.txt
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/org.kde.plasma.emojier.desktop
  applets/kimpanel/backend/ibus/emojier/resources.qrc
  applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml
  applets/kimpanel/backend/ibus/emojier/ui/emojier.qml
  applets/kimpanel/backend/ibus/emojier/ui/org.kde.plasma.emojier.desktop

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24414: No need to keep ibus 1.4.* compatibility anymore

2019-10-07 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:95c8ae371483: No need to keep ibus 1.4.* compatibility 
anymore (authored by apol).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24414?vs=67325=67411

REVISION DETAIL
  https://phabricator.kde.org/D24414

AFFECTED FILES
  applets/kimpanel/backend/ibus/CMakeLists.txt
  applets/kimpanel/backend/ibus/ibus14/main.c
  applets/kimpanel/backend/ibus/ibus14/panel.c
  applets/kimpanel/backend/ibus/ibus14/panel.h

To: apol, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 99 - Still Failing!

2019-10-07 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/99/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 07 Oct 2019 09:40:25 +
 Build duration:
42 sec and counting
   CONSOLE OUTPUT
  [...truncated 127 lines...][2019-10-07T09:40:57.428Z]  > git checkout -f 7db3c74d0335682a78bbcb741325004b36a68a90 # timeout=10[2019-10-07T09:40:58.291Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project systemsettings --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-07T09:41:01.566Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-07T09:41:01.566Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-07T09:41:03.455Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-07T09:41:03.713Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-07T09:41:03.713Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-07T09:41:03.713Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-07T09:41:03.713Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-07T09:41:04.646Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-07T09:41:04.646Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-07T09:41:04.646Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-07T09:41:04.646Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-07T09:41:04.646Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-07T09:41:04.907Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-07T09:41:04.907Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-07T09:41:04.907Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-07T09:41:04.907Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-07T09:41:04.907Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-07T09:41:05.163Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-07T09:41:05.163Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-07T09:41:05.163Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-07T09:41:05.163Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-07T09:41:05.419Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-07T09:41:05.419Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-07T09:41:05.419Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-07T09:41:05.419Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-07T09:41:05.419Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-07T09:41:05.419Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-07T09:41:05.419Z] Retrieving:

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 98 - Failure!

2019-10-07 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/98/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 07 Oct 2019 09:39:40 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 125 lines...][Pipeline] sh[2019-10-07T09:40:11.141Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project systemsettings --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-07T09:40:14.425Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-07T09:40:14.425Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-07T09:40:14.425Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-07T09:40:14.425Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-07T09:40:14.425Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-07T09:40:14.681Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-07T09:40:14.681Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-07T09:40:14.681Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-07T09:40:14.937Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-07T09:40:15.194Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-07T09:40:15.194Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-07T09:40:15.759Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-07T09:40:16.016Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-07T09:40:16.016Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-07T09:40:16.273Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-07T09:40:16.273Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-07T09:40:16.273Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-07T09:40:16.273Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-07T09:40:16.273Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-07T09:40:16.835Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-07T09:40:16.835Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-07T09:40:16.835Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-07T09:40:17.089Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-07T09:40:17.090Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-07T09:40:17.090Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-07T09:40:17.090Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-07T09:40:17.090Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-07T09:40:18.988Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-07T09:40:18.988Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-07T09:40:19.249Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-07T09:40:19.249Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-07T09:40:19.249Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-07T09:40:19.249Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-07T09:40:19.814Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-07T09:40:20.070Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-07T09:40:20.070Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-07T09:40:20.070Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-07T09:40:20.070Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-07T09:40:21.001Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-07T09:40:21.001Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-07T09:40:21.001Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-07T09:40:21.257Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-07T09:40:21.257Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-07T09:40:21.258Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-07T09:40:21.258Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-07T09:40:21.258Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-07T09:40:21.515Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-07T09:40:21.515Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-07T09:40:21.515Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-07T09:40:21.515Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-07T09:40:21.515Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-07T09:40:21.515Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-07T09:40:21.772Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-07T09:40:21.772Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-07T09:40:21.772Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-07T09:40:21.772Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-07T09:40:21.772Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-07T09:40:22.028Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-07T09:40:22.028Z] Retrieving: Plasma-krunner-kf5-qt5[2019-10-07T09:40:22.028Z] Retrieving: Plasma-kxmlrpcclient-kf5-qt5[2019-10-07T09:40:22.028Z]

D24427: Explicitly qmlRegisterType QAbstractItemModel

2019-10-07 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:e3d189a838dc: Explicitly qmlRegisterType 
QAbstractItemModel (authored by broulik).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24427?vs=67353=67409

REVISION DETAIL
  https://phabricator.kde.org/D24427

AFFECTED FILES
  sidebar/SidebarMode.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24452: Un-break remote input portal

2019-10-07 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Have it document that it will be using the fake keys protocol

TEST PLAN
  Tested manually

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24452

AFFECTED FILES
  data/CMakeLists.txt
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in

To: apol, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 434 - Still Failing!

2019-10-07 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/434/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 07 Oct 2019 08:30:55 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 127 lines...][2019-10-07T08:31:39.364Z]  > git checkout -f 7db3c74d0335682a78bbcb741325004b36a68a90 # timeout=10[2019-10-07T08:31:40.237Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-07T08:31:43.506Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-07T08:31:43.506Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-07T08:31:43.763Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-07T08:31:43.763Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-07T08:31:43.763Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-07T08:31:43.763Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-07T08:31:43.763Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-07T08:31:44.024Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-07T08:31:44.024Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-07T08:31:44.024Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-07T08:31:44.024Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-07T08:31:44.025Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-07T08:31:44.025Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-07T08:31:44.025Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-07T08:31:45.921Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-07T08:31:45.921Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-07T08:31:45.921Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-07T08:31:45.921Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-07T08:31:45.921Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-07T08:31:45.921Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-07T08:31:45.921Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-07T08:31:46.177Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-07T08:31:46.434Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-07T08:31:46.690Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-07T08:31:47.618Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-07T08:31:47.618Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-07T08:31:47.618Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-07T08:31:47.618Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-07T08:31:47.618Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-07T08:31:47.885Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-07T08:31:47.885Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-07T08:31:47.885Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-07T08:31:48.142Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-07T08:31:48.142Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-07T08:31:48.398Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-07T08:31:48.398Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-07T08:31:48.398Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-07T08:31:48.398Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-07T08:31:48.962Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-07T08:31:48.962Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-07T08:31:48.962Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-07T08:31:48.962Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-07T08:31:48.962Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-07T08:31:49.240Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-07T08:31:49.240Z] Retrieving:

D24333: sddm-theme: Set needsFullUserModel=false

2019-10-07 Thread Fabian Vogt 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0565c8e615e0: sddm-theme: Set needsFullUserModel=false 
(authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24333?vs=67112=67406

REVISION DETAIL
  https://phabricator.kde.org/D24333

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/theme.conf.cmake

To: fvogt, #plasma, davidedmundson
Cc: ngraham, davidedmundson, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-07 Thread Enrique Medina Gremaldos 
enriqueme added a comment.


  It looks like we want look and feel kcm split in two parts:
  
  - Desktop layout (panels and widgets)
  - Themes (wallpaper, color scheme, kwin theme, widget theme)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: enriqueme, mart, fabianr, Zren, mmustac, niccolove, rikmills, cblack, 
broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-07 Thread Bhushan Shah 
bshah added a comment.


  > Commited to 5.17, should I cherry pick the commit to master or merge the 
5.17 branch back into master?
  
  Generally you merge the branch back in master, but I've done it 
(metadata.desktop file of package also needed updating).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24451

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-07 Thread Jonah Brüchert 
jbbgameich added a comment.


  Commited to 5.17, should I cherry pick the commit to master or merge the 5.17 
branch back into master?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mobile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24451

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-07 Thread Jonah Brüchert 
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:91e6cf9694cd: metadata: Add form factors to make kcm 
appear on mobile again (authored by jbbgameich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24451?vs=67400=67403#toc

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24451?vs=67400=67403

REVISION DETAIL
  https://phabricator.kde.org/D24451

AFFECTED FILES
  src/kcm/kcm_pulseaudio.desktop

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart