D24844: [Applet] Remove hamburger button and menu

[Petr K]

pkloc added a comment.


  There is use case for quick increase of maximum volume and I use it a lot, 
for quiet youtube videos.
  I just checked, and "new" way is same amount of clicks away so I wouldn't 
oppose it too much. Still, personally old way feels more intuitive.
  
  Now I'm starting to see benefits of LTS releases, I'm starting to feel like 
Plasma UI is changing too rapidly as of late.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  single-way-to-raise-max-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24844

To: ngraham, #vdg, #plasma, filipf
Cc: pkloc, romangg, manueljlin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 218 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/218/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 03:20:36 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

[Nathaniel Graham]

ngraham added a comment.


  In D24842#551772 , @filipf wrote:
  
  > Makes sense. It's unrelated to this patch but what's up with the double 
message ("No space on device left" and "not enough free disk space") here?
  
  
  Yeah I need to fix that too.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24842

To: ngraham, #vdg, #discover_software_store, apol, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24844: [Applet] Remove hamburger button and menu

[Nathaniel Graham]

ngraham added a comment.


  In D24844#551795 , @romangg wrote:
  
  > > user feedback indicates nobody clicks on.
  >
  > You will get the feedback from people who use it after you have removed it 
and people can't use it anymore.
  
  
  It's the cycle of life. :) However the "Play all audio through this device" 
menu item is well and truly redundant now since the functionality is now 
exposed right on the main UI. I don't think anyone will miss it.
  
  >> You raise the maximum volume by clicking on the configure button in the 
applet to show the settings window and doing it there
  > 
  > That's way slower. I use the functionality actually quite often for my 
bluetooth headset. That being said the functionality is somewhat broken for me 
because using hardware shortcuts after raising the maximum volume do not 
respect this.
  
  Yeah, that bug is fixed here. The problem is that the "raise maximum volume" 
settings does not take into account the user-configured maximum volume setting 
and breaks when you use hardware media keys. It's quite messy and broken at the 
moment. We could fix that problem independently of this, but conceptually it's 
quite messy to have two subtly different ways to do the same thing.
  
  > But after removing the switch from the applet do they then not work anymore 
for other people as well?
  
  After removing the menu item, the only way to raise the maximum volume is on 
a global basis using the settings window, after which the behavior is not buggy 
at all.
  
  > I believe you should put some more thoughts into how to consistently 
improve this plasmoid from usability point of view before doing singular 
drastic changes. Early feedback indicated for example that the current "Default 
Device" button might be too big for people's taste. Maybe @manueljlin can help 
with creating a harmonic overall design.
  
  Definitely open to suggestions.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  single-way-to-raise-max-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24844

To: ngraham, #vdg, #plasma, filipf
Cc: romangg, manueljlin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24844: [Applet] Remove hamburger button and menu

[Roman Gilg]

romangg added subscribers: manueljlin, romangg.
romangg added a comment.


  > user feedback indicates nobody clicks on.
  
  You will get the feedback from people who use it after you have removed it 
and people can't use it anymore.
  
  > You raise the maximum volume by clicking on the configure button in the 
applet to show the settings window and doing it there
  
  That's way slower. I use the functionality actually quite often for my 
bluetooth headset. That being said the functionality is somewhat broken for me 
because using hardware shortcuts after raising the maximum volume do not 
respect this. But after removing the switch from the applet do they then not 
work anymore for other people as well?
  
  I believe you should put some more thoughts into how to consistently improve 
this plasmoid from usability point of view before doing singular drastic 
changes. Early feedback indicated for example that the current "Default Device" 
button might be too big for people's taste. Maybe @manueljlin can help with 
creating a harmonic overall design.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  single-way-to-raise-max-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24844

To: ngraham, #vdg, #plasma, filipf
Cc: romangg, manueljlin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24844: [Applet] Remove "Raise Maximum Volume" menu item from Hamburger menu

[Nathaniel Graham]

ngraham updated this revision to Diff 68494.
ngraham added a comment.
This revision is now accepted and ready to land.


  Remove the hamburger menu completely and fix the slider's max volume not 
adjusting dynamically

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24844?vs=68489=68494

BRANCH
  single-way-to-raise-max-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24844

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: ngraham, #vdg, #plasma, filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  Still sorry for having stalled this effort. Stepping down as maintainer of 
the weather applet now, so also resigning here. Might be the chance to pick 
this up and just move on :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18961

To: Zren
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12944: [weather applet] Show a note why "Show temperature" is disabled

[Friedrich W. H. Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  No time to care for this more, someone else needs to take over if 
needed/wanted,

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12944

To: kossebau, #plasma
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Re: Weather applet/dataengine: passing on maintainer baton

[Friedrich W. H. Kossebau]

Am Dienstag, 22. Oktober 2019, 00:42:01 CEST schrieb Friedrich W. H. Kossebau:
> * https://bugs.kde.org/buglist.cgi?
> bug_status=__open__=Weather_id=1672869=plasmashell
> (though I remember some more open?)

Indeed. Seems there are 2x components for the Plasma widget, once with 
plasmashell (which I found on my quick search before) and once with kdeplasma-
addons, which has the (sadly) longer list of open bugs I remembered:
https://bugs.kde.org/buglist.cgi?
bug_status=__open__=weather_id=1672882=kdeplasma-addons

Someone(tm) should merge that... /me out 8)

Cheers
Friedrich

D24711: [Mouse KCM] Fix acceleration profile on X11

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Lovely.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixMouseAccelProfile

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg, ngraham
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Weather applet/dataengine: passing on maintainer baton

[Friedrich W. H. Kossebau]

Hi,

3 and 1/2 years after I adopted the code for the weather applet in kdeplasma-
addons and the respective weather dataengine in plasma-workspace, to make it 
live on in Plasma5 era instead of being moved into the attic*, I feel there 
are too many other things now which have more of my interest, and I am 
slacking in giving the attention when needed, as I could just again see with 
the windy conditions icons patches.

* 
https://frinring.wordpress.com/2016/03/02/will-the-addons-weather-widget-be-revived-for-plasma-5-6/

This includes also any WIP patches of mine to add multi-city support, some 
integration with krunner, integration with the Plasma calendar, a general 
environment/weather report demon or a revival of a Plasma weather wallpaper, 
which have been bitrotting for > 1 year now, with all forecast models 
delivering a 0.0 % chance of any activity in the near future.

I think I am leaving the code in good shape (modern, simple code base, with 
some documentation added, only a few bug reports open*), so it will not fall 
apart the next minute after I turned my back. Besides, I sense there are other 
people around to look after it some more now with me no longer standing by 
(and perhaps even in the way).

* https://bugs.kde.org/buglist.cgi?
bug_status=__open__=Weather_id=1672869=plasmashell
(though I remember some more open?)

So hereby I drop the (in-official) maintainer bacon into the hands of Plasma 
release managers, so they can pass it on as needed/wanted.
Thanks also all for the support I had while working on the applet & dataengine 
code, I never felt alone or lost.

Cheers
Friedrich

D22201: [mobile/wifi] Rework NetworkSetting header

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:02888058564f: [mobile/wifi] Rework NetworkSetting header 
(authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22201?vs=60970=68491#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22201?vs=60970=68491

REVISION DETAIL
  https://phabricator.kde.org/D22201

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkSettings.qml

To: nicolasfella, #plasma, jgrulich, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:62d595f24db6: Use the text OK instead of 
Proceed in updates dialog when things go wrong (authored by 
ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24842?vs=68477=68492

REVISION DETAIL
  https://phabricator.kde.org/D24842

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #vdg, #discover_software_store, apol, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24808: [mobile/wifi] Group networks by connection state

[Nicolas Fella]

nicolasfella updated this revision to Diff 68490.
nicolasfella added a comment.


  - Use section property

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24808?vs=68376=68490

BRANCH
  groups

REVISION DETAIL
  https://phabricator.kde.org/D24808

AFFECTED FILES
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, jgrulich, #plasma, #plasma:_mobile
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Makes sense. It's unrelated to this patch but what's up with the double 
message ("No space on device left" and "not enough free disk space") here?

REPOSITORY
  R134 Discover Software Store

BRANCH
  proceed-to-ok (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24842

To: ngraham, #vdg, #discover_software_store, apol, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24844: [Applet] Remove "Raise Maximum Volume" menu item from Hamburger menu

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  Looks like it's a simple matter to get rid of the whole hamburger menu; I'll 
do it in this patch.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24844

To: ngraham, #vdg, #plasma, filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24844: [Applet] Remove "Raise Maximum Volume" menu item from Hamburger menu

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This action suffers from the following problems:
  
  - It's buggy: tt does not take into account whether or not the maximum volume 
has already been raised globally using the settings window, and if it has and 
you toggle it, the slider's position gets stuck in an incorrect state
  - It's unnecessary: there is already a more reliable and useful way to raise 
the maximum volume level in the settings window
  - It't one of the last two items in the hamburger menu that user feedback 
indicates nobody clicks on, and we want to move in the direction of removing it

TEST PLAN
  The hamburger menu no longer lists a "Raise Maximum Volume" menu item
  
  You can still raise the baximum volume by clicking on the configure button in 
the applet to show the settings window

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  single-way-to-raise-max-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24844

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: [Mouse KCM] Fix acceleration profile on X11

[Roman Gilg]

romangg updated this revision to Diff 68487.
romangg added a comment.


  Small code style change.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24711?vs=68109=68487

BRANCH
  fixMouseAccelProfile

REVISION DETAIL
  https://phabricator.kde.org/D24711

AFFECTED FILES
  kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp

To: miraiko, #plasma, romangg
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Roman Gilg]

romangg added a comment.


  @miraiko Do you have an email address that should be used for the commit?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf marked 5 inline comments as done.
filipf added a comment.


  Everything should work fine now hopefully.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg, ngraham
Cc: ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf updated this revision to Diff 68485.
filipf added a comment.


  - pin button now appears in the "Status and Notifications" popup again
  - simpler code for checking layout mirroring

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24720?vs=68403=68485

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf, #plasma, #vdg, ngraham
Cc: ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:78ccc2eba9cb: [KCMs/Night Color] Add a valueForText 
handler for the new SpinBox (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24838?vs=68459=68484

REVISION DETAIL
  https://phabricator.kde.org/D24838

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #plasma, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

[Nathaniel Graham]

ngraham added a comment.


  In D24838#551712 , @zzag wrote:
  
  > Uh, I don't use Ukrainian locale. However, it doesn't matter that much. We 
format numbers practically the same way as in en_US.
  >
  > Given the current implementation of textFromValue and the fact that the 
maximum value of transTimeField is capped, this change is good to go. However, 
it would be great to respect the user's locale.
  
  
  I agree. Since there are other `textFromValue` implementations in 
plasma-desktop that don't do this, it would probably make sense to do them all 
at once. I'll see if I can figure out how.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  valuefromtext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24838

To: ngraham, #plasma, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Uh, I don't use Ukrainian locale. However, it doesn't matter that much. We 
format numbers practically the same way as in en_US.
  
  Given the current implementation of textFromValue and the fact that the 
maximum value of transTimeField is capped, this change is good to go. However, 
it would be great to respect the user's locale.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  valuefromtext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24838

To: ngraham, #plasma, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:48
> +//Menu mode
> +if (!activeApplet && hiddenItemsView.visible && 
> LayoutMirroring.enabled === false) {
> +return units.smallSpacing;

!LayoutMirroring.enabled instead of === false

> ExpandedRepresentation.qml:136
> +Layout.fillHeight: true
> +Layout.leftMargin: hiddenItemsView.visible && activeApplet && 
> LayoutMirroring.enabled === false ? units.largeSpacing : 0
> +Layout.rightMargin: hiddenItemsView.visible && activeApplet && 
> LayoutMirroring.enabled === true ? units.largeSpacing : 0

Same

> ExpandedRepresentation.qml:137
> +Layout.leftMargin: hiddenItemsView.visible && activeApplet && 
> LayoutMirroring.enabled === false ? units.largeSpacing : 0
> +Layout.rightMargin: hiddenItemsView.visible && activeApplet && 
> LayoutMirroring.enabled === true ? units.largeSpacing : 0
>  }

Same

REPOSITORY
  R120 Plasma Workspace

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg, ngraham
Cc: ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24843: [KDEPlatformSystemTrayIcon] Recreate menu when deleted

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: apol, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Recreate internal menu when needed.
  It is possible that internal representation of system tray menu is
  deleted. This can happen when QSystemTrayIcon is hidden.
  
  BUG: 365105

TEST PLAN
  Unit tests included

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24843

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kdeplatformsystemtrayicon_unittest.cpp
  src/platformtheme/kdeplatformsystemtrayicon.cpp
  src/platformtheme/kdeplatformsystemtrayicon.h

To: kmaterka, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf added a comment.


  Based on a search of some examples of RTL UI settings I'm going to say 
headings also go on the right side, so it seems they were actually not 
correctly placed before.
  
  But I actually still have two other dilemmas:
  
  - the pin icon doesn't show up anymore in the "Status and Notifications" 
popup and I have no idea why
  - the pin icon is now noticeably bigger, should I make it smaller?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  All right.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24162

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh I see what you mean. This is fine then!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

[Björn Feber]

GB_2 added a comment.


  In D24162#551673 , @ngraham wrote:
  
  > Oh, so that would need to be done in D24839 
 then?
  
  
  That would need to be a new patch IMO.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24162

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Filip Fila]

filipf added a comment.


  The latest version already works with RTL without the `fillWidth` code being 
needed. So as far as I can tell the diff you posted only effectively removes 
the margins from headings. But I think we should keep them, i.e., align those 
headings with the container (@GB_2 already mentioned this : D24720#548745 
)
  
  F7642540: image.png 
  
  But in the case of RTL perhaps the headings should be on the other side 
actually, same as before?
  
  F7642559: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

[Nathaniel Graham]

ngraham added a comment.


  Oh, so that would need to be done in D24839 
 then?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24162

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

[Björn Feber]

GB_2 added a comment.


  In D24162#551671 , @ngraham wrote:
  
  > The Edit Panel menu item probably shouldn't be visible while that panel is 
currently being edited: F7642545: Screenshot_20191021_131210.png 

  
  
  Unrelated ;-)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24162

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

[Nathaniel Graham]

ngraham added a comment.


  The Edit Panel menu item probably shouldn't be visible while that panel is 
currently being edited: F7642545: Screenshot_20191021_131210.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24162

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

[Björn Feber]

GB_2 updated this revision to Diff 68480.
GB_2 added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24839?vs=68468=68480

BRANCH
  arcpatch-D24839

REVISION DETAIL
  https://phabricator.kde.org/D24839

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

[Nathaniel Graham]

ngraham added a comment.


  Also needs a rebase

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24839

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Otherwise the button says "Proceed" when the dialog is showing you an error 
condition
  in which you cannot proceed:
  F7642500: not enough space.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  proceed-to-ok (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24842

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

[Björn Feber]

GB_2 updated this revision to Diff 68476.
GB_2 added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24162?vs=66679=68476

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24162

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24162

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

[Nathaniel Graham]

ngraham added a comment.


  Does it work in your locale?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24838

To: ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

[Vlad Zahorodnii]

zzag removed a reviewer: zzag.
zzag added inline comments.

INLINE COMMENTS

> main.qml:319
> +valueFromText: function(text, locale) {
> +return parseInt(text);
> +}

Hmm, does parseInt take the user's locale into account?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24838

To: ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24834: [KCM] Try harder to display all text in the visualizations

[Roman Gilg]

romangg added a comment.


  Next time.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24834

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

[Nathaniel Graham]

ngraham added a comment.


  This works for me:
  
  P482 Patch for https://phabricator.kde.org/D24720 

  
  F7642232: Screenshot_20191021_113604.png 

  
  F7642255: Screenshot_20191021_114030.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Not needed for normal users with the new edit mode system.

TEST PLAN
  Lock the widgets before compiling this patch. Then compile with it, unlock 
widgets and see that there is no lock option in the panel context menu.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24839

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  In D24732#551035 , @jgrulich wrote:
  
  > In D24732#550902 , @ngraham 
wrote:
  >
  > > So close! You don't need to create a `Rectangle` to give the ScrollView a 
white background; just set `Component.onCompleted: background.visible = true` 
on the scrollview itself. Here's an example of how it's done in the 
Notifications KCM: 
https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n94
  >
  >
  > It doesn't seem to work in my case.
  
  
  That's odd. Any idea why, @mart or @apol?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24834: [KCM] Try harder to display all text in the visualizations

[Nathaniel Graham]

ngraham added a comment.


  In D24834#551549 , @romangg wrote:
  
  > Add a more meaningful summary please and replace the `5.17` text with it.
  
  
  Oops sorry, I missed this before landing it. :(

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24834

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24834: [KCM] Try harder to display all text in the visualizations

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:3c406779cca9: [KCM] Try harder to display all text in the 
visualizations (authored by ngraham).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24834?vs=68448=68466

REVISION DETAIL
  https://phabricator.kde.org/D24834

AFFECTED FILES
  kcm/package/contents/ui/Output.qml

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24834: [KCM] Try harder to display all text in the visualizations

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  In D24834#551507 , @ngraham wrote:
  
  > In D24834#551506 , @romangg 
wrote:
  >
  > > Looks good. If the display is too small to display two rows or the name 
is even longer, does it just elide?
  >
  >
  > Yep.
  >
  > > One question I have long term is what information actually needs to be in 
there. Currently we have name and the logical size. Would only the name or name 
+ resolution make more sense?
  >
  > Unless I'm misunderstanding things, it's already is showing the name and 
the resolution. The name is mandatory I think; not so sure about the resolution.
  
  
  It shows the logical size. If you have a 3840x2160 resolution screen with 
scale factor 2, it shows 1920x1080. I guess it's this way only on Wayland
  
  In D24834#551510 , @ngraham wrote:
  
  > You good with getting this into 5.17 now, and we can investigate what 
should be displayed in there for 5.18?
  
  
  Yes, 5.17.

REPOSITORY
  R104 KScreen

BRANCH
  more-text-in-visualizations (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24834

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24834: [KCM] Try harder to display all text in the visualizations

[Roman Gilg]

romangg added a comment.


  Add a more meaningful summary please and remove the 5.17.

REPOSITORY
  R104 KScreen

BRANCH
  more-text-in-visualizations (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24834

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24814: [KCMs] Make spinboxes editable

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4f90a137e7a3: [KCMs] Make spinboxes editable (authored by 
ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24814?vs=68464=68465

REVISION DETAIL
  https://phabricator.kde.org/D24814

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml
  kcms/launch/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24814: [KCMs] Make spinboxes editable

[Nathaniel Graham]

ngraham added a comment.


  Landing without explicit approval since D24816 
 which does the exact same thing elsewhere 
was approved, and the logic for approving is identical. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24814

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24814: [KCMs] Make spinboxes editable

[Nathaniel Graham]

ngraham updated this revision to Diff 68464.
ngraham added a comment.


  Add valueFromText handlers

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24814?vs=68397=68464

BRANCH
  editable-spinboxes (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24814

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml
  kcms/launch/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24815: [Weather] Make update time spinbox editable

[Nathaniel Graham]

ngraham added a comment.


  Landing without approval since D24816  
which does the exact same thing elsewhere was approved, and the logic for 
approving is identical. :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24815

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24815: [Weather] Make update time spinbox editable

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:ec2392dbf70a: [Weather] Make update time spinbox editable 
(authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24815?vs=68462=68463

REVISION DETAIL
  https://phabricator.kde.org/D24815

AFFECTED FILES
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24815: [Weather] Make update time spinbox editable

[Nathaniel Graham]

ngraham updated this revision to Diff 68462.
ngraham added a comment.


  Add a valueFromText handler

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24815?vs=68398=68462

BRANCH
  editable-spinbox (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24815

AFFECTED FILES
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24816: [Applet] Make spinboxes editable

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:e1a2940de814: [Applet] Make spinboxes editable (authored 
by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24816?vs=68460=68461

REVISION DETAIL
  https://phabricator.kde.org/D24816

AFFECTED FILES
  applet/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24816: [Applet] Make spinboxes editable

[Nathaniel Graham]

ngraham updated this revision to Diff 68460.
ngraham added a comment.


  Add valueForText handlers

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24816?vs=68399=68460

BRANCH
  editable-spinboxes (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24816

AFFECTED FILES
  applet/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

[Nathaniel Graham]

ngraham added a comment.


  @zzag https://phabricator.kde.org/D24838

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24813

To: ngraham, #vdg, #plasma, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: zzag, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Now you can enter "1 minute" and it will be parsed correctly

TEST PLAN
  Enter "1 minute" and tab away from the box

REPOSITORY
  R119 Plasma Desktop

BRANCH
  valuefromtext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24838

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, zzag, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24834: [KCM] Try harder to display all text in the visualizations

[Nathaniel Graham]

ngraham added a comment.


  You good with getting this into 5.17 now, and we can investigate what should 
be displayed in there for 5.18?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24834

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24834: [KCM] Try harder to display all text in the visualizations

[Nathaniel Graham]

ngraham added a comment.


  In D24834#551506 , @romangg wrote:
  
  > Looks good. If the display is too small to display two rows or the name is 
even longer, does it just elide?
  
  
  Yep.
  
  > One question I have long term is what information actually needs to be in 
there. Currently we have name and the logical size. Would only the name or name 
+ resolution make more sense?
  
  Unless I'm misunderstanding it, it already is showing the name and the 
resolution. The name is mandatory I think; not so sure about the resolution.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24834

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24834: [KCM] Try harder to display all text in the visualizations

[Roman Gilg]

romangg added a comment.


  Looks good. If the display is too small to display two rows or the name is 
even longer, does it just elide?
  
  One question I have long term is what information actually needs to be in 
there. Currently we have name and the logical size. Would only the name or name 
+ resolution make more sense?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24834

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24765: [WIP] Notification applet on the phone

[Marco Martin]

mart updated this revision to Diff 68455.
mart added a comment.


  - don't show jobs in popups on mobile

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24765?vs=68253=68455

BRANCH
  mart/mobilenotifications

REVISION DETAIL
  https://phabricator.kde.org/D24765

AFFECTED FILES
  applets/notifications/package/contents/ui/DraggableDelegate.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/SelectableLabel.qml
  applets/notifications/package/contents/ui/global/Globals.qml

To: mart, #plasma
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24730: Port KCMSplashScreen to KConfigXT

[Cyril Rossi]

crossi updated this revision to Diff 68450.
crossi added a comment.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.


  remove unnecessary emit

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24730?vs=68130=68450

REVISION DETAIL
  https://phabricator.kde.org/D24730

AFFECTED FILES
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml
  kcms/ksplash/splashscreensettings.kcfg
  kcms/ksplash/splashscreensettings.kcfgc

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, apol, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> zzag wrote in main.qml:300
> Qt documentation says that we need to override valueFromText
> 
> > Note: When applying a custom textFromValue implementation for editable 
> > spinboxes, a matching valueFromText implementation must be provided to be 
> > able to convert the custom text back to an integer value.
> 
> https://doc.qt.io/qt-5/qml-qtquick-controls2-spinbox.html#valueFromText-prop

Ah ok, will add that in a follow-up patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24813

To: ngraham, #vdg, #plasma, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> main.qml:300
>  }
> -
> -inputMethodHints: Qt.ImhDigitsOnly
> -validator: IntValidator {bottom: 1; top: 
> 600;}  // less than 12 hours (in minutes: 720)
> +textFromValue: function(value, locale) {
> +return i18np("%1 minute", "%1 minutes", 
> value)

Qt documentation says that we need to override valueFromText

> Note: When applying a custom textFromValue implementation for editable 
> spinboxes, a matching valueFromText implementation must be provided to be 
> able to convert the custom text back to an integer value.

https://doc.qt.io/qt-5/qml-qtquick-controls2-spinbox.html#valueFromText-prop

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24813

To: ngraham, #vdg, #plasma, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24833: [KCM] Revert change to reduce size of screens in visualization

[Nathaniel Graham]

ngraham added a comment.


  In D24833#551421 , @romangg wrote:
  
  > Yea it's better how it was before. But it could still be improved with some 
text/fonts/elide magic I guess.
  
  
  Should be fully improved in D24834 .

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24833

To: ngraham, #vdg, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cd14bbc9c720: [KCM/Night Color] Use a spinbox with an 
appropriate suffix for the duration (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24813?vs=68434=68449

REVISION DETAIL
  https://phabricator.kde.org/D24813

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24834: [KCM] Try harder to display all text in the visualizations

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: romangg, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  5.17

TEST PLAN
  F7641815: More text.png 

REPOSITORY
  R104 KScreen

BRANCH
  more-text-in-visualizations (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24834

AFFECTED FILES
  kcm/package/contents/ui/Output.qml

To: ngraham, romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24833: [KCM] Revert change to reduce size of screens in visualization

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:318c16f3c604: [KCM] Revert change to reduce size of 
screens in visualization (authored by ngraham).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24833?vs=68446=68447

REVISION DETAIL
  https://phabricator.kde.org/D24833

AFFECTED FILES
  kcm/package/contents/ui/Screen.qml

To: ngraham, #vdg, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24833: [KCM] Revert change to reduce size of screens in visualization

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Yea it's better how it was before. But it could still be improved with some 
text/fonts/elide magic I guess.
  
  5.17

REPOSITORY
  R104 KScreen

BRANCH
  bigger-screens-in-visualization (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24833

To: ngraham, #vdg, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24833: [KCM] Revert change to reduce size of screens in visualization

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This was done in D23798 , but in 
retrospect, that was a mistake. When more than one output
  is connected, their representations in the visualization become tiny and 
their text gets
  scrunched and elided. The old size worked better. So, let's revert to that.
  
  I could have sworn that I triaged a bug report about this, but now I can't 
find it.
  
  5.17

TEST PLAN
  Multi-screen display is much improved: F7641754: After, two screens.png 


REPOSITORY
  R104 KScreen

BRANCH
  bigger-screens-in-visualization (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24833

AFFECTED FILES
  kcm/package/contents/ui/Screen.qml

To: ngraham, #vdg, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24068: docs: add contributing guide

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> yurchor wrote in CONTRIBUTING.md:58
> Typo: "communication" (singular) or "happen"

Thanks!

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24068

To: romangg, #plasma
Cc: yurchor, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24068: docs: add contributing guide

[Roman Gilg]

romangg updated this revision to Diff 68445.
romangg marked an inline comment as done.
romangg added a comment.


  - Rebase
  - Fix typo

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24068?vs=66437=68445

BRANCH
  contributingGuide

REVISION DETAIL
  https://phabricator.kde.org/D24068

AFFECTED FILES
  CONTRIBUTING.md

To: romangg, #plasma
Cc: yurchor, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24832: Re-add category display to app delegates

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:9dc1768ac897: Re-add category display to app delegates 
(authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24832?vs=68443=68444

REVISION DETAIL
  https://phabricator.kde.org/D24832

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24832: Re-add category display to app delegates

[Nathaniel Graham]

ngraham updated this revision to Diff 68443.
ngraham marked an inline comment as done.
ngraham added a comment.


  Simplify layout conditional

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24832?vs=68439=68443

BRANCH
  re-add-categories-display-on-delegate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24832

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24479: [KCM] Make multi-screen draggability more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 68440.
ngraham added a comment.


  Reduce label opacity

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24479?vs=68259=68440

BRANCH
  make-draggability-more-obvious (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24479

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24479: [KCM] Make multi-screen draggability more obvious

[Nathaniel Graham]

ngraham added a comment.


  All right. :)

REPOSITORY
  R104 KScreen

BRANCH
  make-draggability-more-obvious (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24832: Re-add category display to app delegates

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Let's try and see what it feels like

INLINE COMMENTS

> ApplicationDelegate.qml:77
> +level: delegateArea.compact ? 3 : 2
> +Layout.fillWidth: category.visible ? false : true
> +elide: Text.ElideRight

just `Layout.fillWidth: !category.visible`.

REPOSITORY
  R134 Discover Software Store

BRANCH
  re-add-categories-display-on-delegate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24832

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24479: [KCM] Make multi-screen draggability more obvious

[Roman Gilg]

romangg added a comment.


  Not sure. Do what you feel is best and then commit. ;)

REPOSITORY
  R104 KScreen

BRANCH
  make-draggability-more-obvious (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24479: [KCM] Make multi-screen draggability more obvious

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  Better?
  
  F7641631: Screenshot_20191021_081742.png 


REPOSITORY
  R104 KScreen

BRANCH
  make-draggability-more-obvious (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24832: Re-add category display to app delegates

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  A year ago, I removed this in 0911fbcd561c 
 
with no review. :/ Sorry about that. In the
  past year, Discover's UI has come a long way, and I think we can re-add the 
category
  display now without causing the app delegates to become super cluttered.
  
  The category name is suppressed if it would be identical to the page's title.

TEST PLAN
  Categories in search lists: F7641610: Categories in search lists.png 

  Categories on the featured page: F7641609: Categories on featured page.png 

  Categories in browse lists, featuring 
suppression-when-equal-to-the-page-title: F7641608: Categories on browse lists 
featuring deduplication.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  re-add-categories-display-on-delegate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24832

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24479: [KCM] Make multi-screen draggability more obvious

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  I'm not 100% happy with the font of the message in the overview. Maybe 
decrease opacity? But it's also not a pressing issue.

REPOSITORY
  R104 KScreen

BRANCH
  make-draggability-more-obvious (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

[Nathaniel Graham]

ngraham updated this revision to Diff 68434.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Handle singular and plural forms of the word

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24813?vs=68396=68434

BRANCH
  spinbox-for-nightcolor-duration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24813

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24634: Allow contextualActions to flow into the header toolbar

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d09b13861254: Allow contextualActions to flow into the 
header toolbar (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24634?vs=67906=68433

REVISION DETAIL
  https://phabricator.kde.org/D24634

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: ahiemstra, #kirigami, ngraham, mart
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, hein

D20132: Actually make the network list view show up

[Jan Grulich]

jgrulich added a comment.


  Can we drop this request? I believe it works just fine now.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20132

To: vkrause, jgrulich
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 217 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/217/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 11:07:18 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 4368 lines...][2019-10-21T11:17:29.521Z] [ 98%] Building CXX object dataengines/weather/ions/noaa/CMakeFiles/ion_noaa.dir/ion_noaadebug.cpp.o[2019-10-21T11:17:29.521Z] [ 98%] Built target kcminit[2019-10-21T11:17:29.521Z] [ 98%] Building CXX object shell/CMakeFiles/plasmashell.dir/screenpool.cpp.o[2019-10-21T11:17:30.179Z] [ 98%] Linking CXX shared module ../../../../bin/ion_bbcukmet.so[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/shell/shellcorona.cpp:23:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/build/shell/plasmashell_autogen/include/../../../../shell/shellcorona.h:26:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/plasma/corona.h:25:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/plasma/containment.h:25:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigCore/ksharedconfig.h:25:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfig.h:32:[2019-10-21T11:17:30.180Z] In file included from /usr/local/include/qt5/QtCore/QVariant:1:[2019-10-21T11:17:30.180Z] In file included from /usr/local/include/qt5/QtCore/qvariant.h:51:[2019-10-21T11:17:30.180Z] /usr/local/include/qt5/QtCore/qobject.h:317:9: error: static_assert failed due to requirement 'bool((FunctorArgumentCount >= 0))' "Signal and slot arguments are not compatible."[2019-10-21T11:17:30.180Z] Q_STATIC_ASSERT_X((FunctorArgumentCount >= 0),[2019-10-21T11:17:30.180Z] ^~[2019-10-21T11:17:30.180Z] /usr/local/include/qt5/QtCore/qglobal.h:121:49: note: expanded from macro 'Q_STATIC_ASSERT_X'[2019-10-21T11:17:30.180Z] #  define Q_STATIC_ASSERT_X(Condition, Message) static_assert(bool(Condition), Message)[2019-10-21T11:17:30.180Z] ^ ~~~[2019-10-21T11:17:30.180Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/shell/shellcorona.cpp:239:5: note: in instantiation of function template specialization 'QObject::connect' requested here[2019-10-21T11:17:30.180Z] connect(this, ::editModeChanged,[2019-10-21T11:17:30.180Z] ^[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/shell/shellcorona.cpp:23:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/build/shell/plasmashell_autogen/include/../../../../shell/shellcorona.h:26:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/plasma/corona.h:25:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/plasma/containment.h:25:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigCore/ksharedconfig.h:25:[2019-10-21T11:17:30.180Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfig.h:32:[2019-10-21T11:17:30.180Z] In file included from /usr/local/include/qt5/QtCore/QVariant:1:[2019-10-21T11:17:30.180Z] In file included from /usr/local/include/qt5/QtCore/qvariant.h:46:[2019-10-21T11:17:30.180Z] In file included from /usr/local/include/qt5/QtCore/qmetatype.h:50:[2019-10-21T11:17:30.180Z] In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:50:[2019-10-21T11:17:30.180Z] /usr/local/include/qt5/QtCore/qobjectdefs_impl.h:367:75: error: too few arguments to function call, single argument 'edit' was not specified[2019-10-21T11:17:30.180Z] typedef decltype(dummy().operator()((dummy())...)) Value;[2019-10-21T11:17:30.180Z]  ~~~  ^[2019-10-21T11:17:30.180Z] /usr/local/include/qt5/QtCore/qobject.h:320:37: note: in instantiation of template class 'QtPrivate::FunctorReturnType<(lambda at /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/shell/shellcorona.cpp:240:19), QtPrivate::List<> >' requested here[2019-10-21T11:17:30.180Z] typedef typename QtPrivate::FunctorReturnType::Value>::Value SlotReturnType;[2019-10-21T11:17:30.180Z] ^[2019-10-21T11:17:30.180Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/shell/shellcorona.cpp:239:5: note: in instantiation of function template specialization 'QObject::connect' requested here[2019-10-21T11:17:30.180Z] 

D24265: support global edit mode

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ae55560053ef: support global edit mode (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24265?vs=68414=68426#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24265?vs=68414=68426

REVISION DETAIL
  https://phabricator.kde.org/D24265

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/main.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma, ngraham
Cc: davidedmundson, ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24818: Filter invalid services in most used model

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:ec90e4066c16: Filter invalid services in most used model 
(authored by broulik).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24818?vs=68401=68425

REVISION DETAIL
  https://phabricator.kde.org/D24818

AFFECTED FILES
  sidebar/SidebarMode.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24264: edit mode action and dbus

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c9c0f070a91b: edit mode action and dbus (authored by 
mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24264?vs=68234=68423

REVISION DETAIL
  https://phabricator.kde.org/D24264

AFFECTED FILES
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/itemcontainer.cpp
  containmentactions/contextmenu/menu.cpp
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp

To: mart, #plasma, #vdg, ngraham, GB_2, davidedmundson
Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24749: Fix build with older glibc: link there to librt for clock_gettime

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:3cd40fede73e: Fix build with older glibc: link there to 
librt for clock_gettime (authored by kossebau).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24749?vs=68211=68421

REVISION DETAIL
  https://phabricator.kde.org/D24749

AFFECTED FILES
  processcore/CMakeLists.txt

To: kossebau, #plasma, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24785: Store stashed model index as QPersistentModelIndex

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:de7f988c71b2: Store stashed model index as 
QPersistentModelIndex (authored by davidedmundson).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24785?vs=68307=68420

REVISION DETAIL
  https://phabricator.kde.org/D24785

AFFECTED FILES
  sidebar/ToolTips/tooltipmanager.cpp

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

Monday meeting notes from 21/10/2019

[Marco Martin]

Kai Uwe:
plasma-browser-integration:
* Shows host version number in extension about screen now
Notifications:
* Worked around a crash in old notifications with newer Qt
* New system since Plasma 5.16 isn't affected but 5.12 LTS was, so
I had to do something
KWin:
* Startup feedback ("bouncing cursor") now scales with cursor size
Other Plasma:
* Ported widget style KCM to new design, quite beautiful I think
* Style KCM doesn't reload KWin config anymore since
plasma-integration does everything
* Avoids compositor re-init and a nasty flicker on current AMD
* Ported some trivial bits in plasma-workspace and plasma-desktop away
from KIconThemes
* Added output selector ComboBox to new KScreen KCM since accessing
disabled outputs was quite hard
* Fixed crash in KScreen KCM (and helped d_ed fix another one)
Other:
* Had a KDE booth at LinuxDay Vorarlberg on Saturday with romangg and Mamarok
* People love us :)
* Showed a Pinebook, a generic desktop with ultra widescreen monitor, and
* a convertible laptop with apol's software screen rotation patch
and a makeshift tablet mode toggle plasmoid, was quite an eyecatcher
* KDE Connect worked on the exhibitors' Wifi, so we could blow
people's minds quite easily with that and p-b-i ;)

Nico Fe:
* took care of last plaMo blog post
* some cleanup in plaMo workboard. Moved some stuff to done. Needs more love
Mobile wifi kcm:
* fixed regression by plasma-nm commit
* Diff 24808 "[mobile/wifi] Group networks by connection state" [Needs
Review] https://phabricator.kde.org/D24808
* fixed Maui stuff I broke
* Fixed bug in kscreen
* Diff 24719 "Fix laptop screen being off when opening the lid"
[Closed] https://phabricator.kde.org/D24719
(Regression was kcm not opening at all)
* Investigated popular bug in KScreen where KScreen doesn't handle
monitor unplug
* Works only sometimes and I have reason to believe that it might be
an X11 bug (or Qt QScreen not notice screen changes?)
* Fixed Kirigami not to show an empty context drawer sometimes
* use monochrome icon on all plaMo quick actions
* fixed visual things when running kde Connect with plasma as Qqc2 style
* fixed name of some mobile kcms
* fixed itinerary build on binary factory

David Edmundson:
* Worked on several plasma bugfixes, mostly notably we had an issue
where we leaked all  ConfigModules
* which is why we've had various weird crash reports of QML issues
that make no sense
* Another thing I want to mention and make everyone aware of, the
default KDE clang-format is now accepted into frameworks. I really
hope to run it across all plasma soon
* So please do test that
* There's a nice blog in my clang-tidy phab task from another project
that listed the issues they faced with branches and backporting and
how they solved them
* Finally before I stop rambling - the major QtSVG bug is now P1 -
critical, which is good, but it's still broken, which is not good

David Redondo:
* I pushed yesterday a patch to make KcategoryDrawer draw like
Kirigami ListSection since it wasn't changed in like forever and still
came from oxygen times I think. I also touched system settings
iconview which used a similar style but a custom drawer. So if you
find places that also use a custom drawer it would be awesome if you
tell me
* Also slideshow crash fix is in 5.17.1 pushed today

Arjen:
* posted the wip patch for the kirigami context action toolbar
overflow thing: https://phabricator.kde.org/D24634
Diff 24634 "[WIP] Allow contextualActions to flow into the header
toolbar" [Accepted] https://phabricator.kde.org/D24634
* additionally, the quick charts lib got moved to kde review, about to
send a mail about it

Marco:
# Plasma
* more work on edit mode, going to merge it today
* started some adaptations of the notifications plasmoid for plasma
mobile: hopefully very minimal and non invasive to its codebase
# Plasma Mobile
* top drawer: more android-y look, still ongoing experimentations
* smarter cutting of app names over 2 lines in the launcher
# Kirigami
* Fixed drawer handles on plasma mobile
* Fixed a crash when the combination PagePool/Columnview tries to load
an invalid page

D24634: [WIP] Allow contextualActions to flow into the header toolbar

[Marco Martin]

mart accepted this revision.
mart added a comment.


  just remove the WIP from the review title then good to go

REPOSITORY
  R169 Kirigami

BRANCH
  contextactions_in_toolbar

REVISION DETAIL
  https://phabricator.kde.org/D24634

To: ahiemstra, #kirigami, ngraham, mart
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, hein

D24768: Fix incorrect Credits model for Kirigami.AboutPage

[Ilya Bizyaev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9e3407ec40ab: Fix incorrect Credits model for 
Kirigami.AboutPage (authored by IlyaBizyaev).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24768?vs=68269=68418

REVISION DETAIL
  https://phabricator.kde.org/D24768

AFFECTED FILES
  src/controls/AboutPage.qml

To: IlyaBizyaev, #kirigami, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:04e426461927: [kcms/nightcolor] Add hints to temperature 
slider direction (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24763?vs=68251=68417

REVISION DETAIL
  https://phabricator.kde.org/D24763

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: davidedmundson, #plasma, ngraham
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration

[Cyril Rossi]

crossi updated this revision to Diff 68416.
crossi added a comment.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.


  restore blank lines

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24819?vs=68405=68416

REVISION DETAIL
  https://phabricator.kde.org/D24819

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> ToolBoxButton.qml:230
> +PlasmaComponents3.ToolTip {
> +text: i18n("Close Edit Mode")
> +}

Please change to "Finish Customizing Layout" to match the menu entry.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: davidedmundson, ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Marco Martin]

mart updated this revision to Diff 68414.
mart added a comment.


  - don't dismiss applet edit mode when overing the handle

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24265?vs=68235=68414

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/main.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma, ngraham
Cc: davidedmundson, ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart