D24810: Ensure defintion of XDG_DATA_DIRS

[Tobias C. Berner]

tcberner updated this revision to Diff 68732.
tcberner edited the summary of this revision.
tcberner added a comment.


  Update commit message in diff.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24810?vs=68731&id=68732

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24810

AFFECTED FILES
  startkde/config-startplasma.h.cmake
  startkde/startplasma.cpp

To: tcberner, #freebsd, dfaure, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24810: Ensure defintion of XDG_DATA_DIRS

[Tobias C. Berner]

tcberner updated this revision to Diff 68731.
tcberner added a comment.


  Fix comment and commit message.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24810?vs=68379&id=68731

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24810

AFFECTED FILES
  startkde/config-startplasma.h.cmake
  startkde/startplasma.cpp

To: tcberner, #freebsd, dfaure, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

[Jan Grulich]

jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> networkmodelitem.cpp:548
>  
> +if (device && device->ipV4Config().isValid() && m_connectionState == 
> NetworkManager::ActiveConnection::Activated) {
> +if (!device->ipV4Config().gateway().isEmpty()) {

Because this if statement is the same as the one above and below, can you move 
them together?

> networkmodelitem.cpp:575
> +
> +if (device && device->ipV6Config().isValid() && m_connectionState == 
> NetworkManager::ActiveConnection::Activated) {
> +if (!device->ipV6Config().nameservers().isEmpty()) {

Same for this one.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24940

To: mibofra, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R838:c85055441a22: Rewrite AppChooser dialog (authored by 
jgrulich).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68673&id=68730

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

[Francesco Bonanno]

mibofra created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
mibofra requested review of this revision.

REVISION SUMMARY
  I apologize if I annoy someone with this request, as here 
https://bugs.kde.org/show_bug.cgi?id=361414 I've seed it has been discussed the 
issue, and it was done a survey to choice the displayed info.
  
  But, as written in comment #10 of the bug, I don't know why a mac address has 
more relevance for an average user than an nameserver or a gateway. And usually 
the average user don't see this section of the plasmoid.
  
  So, I'm submitting to the review process this patch, with hope of being 
accepted.
  
  It adds just the possibility to see, with the related present info, the 
current dns (first one) for IPv4 and v6 connectivity, and the current default 
gateway for the IPv4 connectivity.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24940

AFFECTED FILES
  libs/models/networkmodelitem.cpp

To: mibofra, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24935: Fix search field focus, both initial and on-demand

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:5d1b3718efb8: Fix search field focus, both initial and 
on-demand (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24935?vs=68726&id=68728

REVISION DETAIL
  https://phabricator.kde.org/D24935

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #discover_software_store, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24935: Fix search field focus, both initial and on-demand

[Nathaniel Graham]

ngraham added a comment.


  In D24935#553754 , @apol wrote:
  
  > Having the focus there (which is where it used to be in some older version) 
makes it a bit harder to navigate the central view with the arrows
  
  
  Hopefully that will eventually be fixed with Marco's work on 
https://bugs.kde.org/show_bug.cgi?id=407524

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-searchfield-focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24935

To: ngraham, #discover_software_store, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24935: Fix search field focus, both initial and on-demand

[Aleix Pol Gonzalez]

apol added a comment.


  Sure, it makes sense. It's not really changing much, only removing the 
loader. The loader did make things slightly more complex so I can imagine this 
working better.
  
  The whole `Component.onCompleted: {` bit is what gives it the focus.
  
  Having the focus there (which is where it used to be in some older version) 
makes it a bit harder to navigate the central view with the arrows, so it's a 
matter of really really wanting to search first, which I think makes a lot of 
sense.
  
  As is master right now, ctrl+f does give the focus to the search bar.

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-searchfield-focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24935

To: ngraham, #discover_software_store, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24935: Fix search field focus, both initial and on-demand

[Nathaniel Graham]

ngraham added a comment.


  @apol does this make sense conceptually though? I don't want to commit a big 
ugly hack.

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-searchfield-focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24935

To: ngraham, #discover_software_store, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24935: Fix search field focus, both initial and on-demand

[Nathaniel Graham]

ngraham updated this revision to Diff 68726.
ngraham added a comment.


  Remove unnecessary `focus: true`

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24935?vs=68719&id=68726

BRANCH
  fix-searchfield-focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24935

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #discover_software_store, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24937: Set focus on the search bar by default

[Nathaniel Graham]

ngraham added a comment.


  FWIW this doesn't actually fix the bug for me. The search bar is now 
focusable by hitting the tab key enough times, but it doesn't get focus by 
default for me.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24937

To: davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24937: Set focus on the search bar by default

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Opened discover

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24937

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml

To: davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24935: Fix search field focus, both initial and on-demand

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Let's give it a try, merge to master, this could have side-effects.

INLINE COMMENTS

> DiscoverDrawer.qml:85
> +id: searchField
> +focus: true
>  

This shouldn't be necessary, is it?

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-searchfield-focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24935

To: ngraham, #discover_software_store, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 41 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/41/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 20:17:45 +
 Build duration:
2 hr 4 min and counting
   CONSOLE OUTPUT
  [...truncated 105 lines...][2019-10-24T20:18:22.208Z] Retrieving: Plasma-kirigami-stable-kf5-qt5[2019-10-24T20:18:22.208Z] Retrieving: Plasma-kiconthemes-stable-kf5-qt5[2019-10-24T20:18:22.208Z] Retrieving: Plasma-kwindowsystem-stable-kf5-qt5[2019-10-24T20:18:22.464Z] Retrieving: Plasma-kcrash-stable-kf5-qt5[2019-10-24T20:18:22.464Z] Retrieving: Plasma-kdbusaddons-stable-kf5-qt5[2019-10-24T20:18:22.464Z] Retrieving: Plasma-phonon-stable-kf5-qt5[2019-10-24T20:18:22.464Z] Retrieving: Plasma-knotifications-stable-kf5-qt5[2019-10-24T20:18:22.464Z] Retrieving: Plasma-kservice-stable-kf5-qt5[2019-10-24T20:18:22.464Z] Retrieving: Plasma-kcompletion-stable-kf5-qt5[2019-10-24T20:18:22.464Z] Retrieving: Plasma-sonnet-stable-kf5-qt5[2019-10-24T20:18:22.721Z] Retrieving: Plasma-attica-stable-kf5-qt5[2019-10-24T20:18:22.721Z] Retrieving: Plasma-kglobalaccel-stable-kf5-qt5[2019-10-24T20:18:22.721Z] Retrieving: Plasma-ktextwidgets-stable-kf5-qt5[2019-10-24T20:18:22.721Z] Retrieving: Plasma-breeze-icons-stable-kf5-qt5[2019-10-24T20:18:26.080Z] Retrieving: Plasma-kxmlgui-stable-kf5-qt5[2019-10-24T20:18:26.080Z] Retrieving: Plasma-solid-stable-kf5-qt5[2019-10-24T20:18:26.080Z] Retrieving: Plasma-kjobwidgets-stable-kf5-qt5[2019-10-24T20:18:26.080Z] Retrieving: Plasma-kbookmarks-stable-kf5-qt5[2019-10-24T20:18:26.080Z] Retrieving: Plasma-kwallet-stable-kf5-qt5[2019-10-24T20:18:26.080Z] Retrieving: Plasma-kio-stable-kf5-qt5[2019-10-24T20:18:26.673Z] Retrieving: Plasma-kparts-stable-kf5-qt5[2019-10-24T20:18:26.673Z] Retrieving: Plasma-syntax-highlighting-stable-kf5-qt5[2019-10-24T20:18:26.673Z] Retrieving: Plasma-kpackage-stable-kf5-qt5[2019-10-24T20:18:26.673Z] Retrieving: Plasma-kactivities-stable-kf5-qt5[2019-10-24T20:18:26.673Z] Retrieving: Plasma-kdnssd-stable-kf5-qt5[2019-10-24T20:18:26.673Z] Retrieving: Plasma-kdeclarative-stable-kf5-qt5[2019-10-24T20:18:26.937Z] Retrieving: Plasma-kidletime-stable-kf5-qt5[2019-10-24T20:18:26.937Z] Retrieving: Plasma-kitemmodels-stable-kf5-qt5[2019-10-24T20:18:26.937Z] Retrieving: Plasma-kross-stable-kf5-qt5[2019-10-24T20:18:26.937Z] Retrieving: Plasma-threadweaver-stable-kf5-qt5[2019-10-24T20:18:27.212Z] Retrieving: Plasma-kunitconversion-stable-kf5-qt5[2019-10-24T20:18:27.212Z] Retrieving: Plasma-kwayland-stable-kf5-qt5[2019-10-24T20:18:27.212Z] Retrieving: Plasma-ktexteditor-stable-kf5-qt5[2019-10-24T20:18:27.485Z] Retrieving: Plasma-oxygen-icons5-stable-kf5-qt5[2019-10-24T20:18:29.415Z] Retrieving: Plasma-plasma-framework-stable-kf5-qt5[2019-10-24T20:18:29.415Z] Retrieving: Plasma-kpty-stable-kf5-qt5[2019-10-24T20:18:29.415Z] Retrieving: Plasma-kinit-stable-kf5-qt5[2019-10-24T20:18:29.676Z] Retrieving: Plasma-kded-stable-kf5-qt5[2019-10-24T20:18:29.676Z] Retrieving: Plasma-kemoticons-stable-kf5-qt5[2019-10-24T20:18:29.947Z] Retrieving: Plasma-kdesignerplugin-stable-kf5-qt5[2019-10-24T20:18:29.947Z] Retrieving: Plasma-knewstuff-stable-kf5-qt5[2019-10-24T20:18:30.212Z] Retrieving: Plasma-kfilemetadata-stable-kf5-qt5[2019-10-24T20:18:30.212Z] Retrieving: Plasma-baloo-stable-kf5-qt5[2019-10-24T20:18:30.480Z] Retrieving: Plasma-bluez-qt-stable-kf5-qt5[2019-10-24T20:18:30.480Z] Retrieving: Plasma-frameworkintegration-stable-kf5-qt5[2019-10-24T20:18:30.480Z] Retrieving: Plasma-kactivities-stats-stable-kf5-qt5[2019-10-24T20:18:30.480Z] Retrieving: Plasma-kcmutils-stable-kf5-qt5[2019-10-24T20:18:30.749Z] Retrieving: Plasma-kdelibs4support-stable-kf5-qt5[2019-10-24T20:18:31.339Z] Retrieving: Plasma-kdesu-stable-kf5-qt5[2019-10-24T20:18:31.339Z] Retrieving: Plasma-kholidays-stable-kf5-qt5[2019-10-24T20:18:31.339Z] Retrieving: Plasma-kimageformats-stable-kf5-qt5[2019-10-24T20:18:31.339Z] Retrieving: Plasma-knotifyconfig-stable-kf5-qt5[2019-10-24T20:18:31.339Z] Retrieving: Plasma-kpeople-stable-kf5-qt5[2019-10-24T20:18:31.339Z] Retrieving: Plasma-kplotting-stable-kf5-qt5[2019-10-24T20:18:31.598Z] Retrieving: Plasma-krunner-stable-kf5-qt5[2019-10-24T20:18:31.598Z] Retrieving: Plasma-kxmlrpcclient-stable-kf5-qt5[2019-10-24T20:18:31.598Z] Retrieving: Plasma-prison-stable-kf5-qt5[2019-10-24T20:18:31.598Z] Retrieving: Plasma-purpose-stable-kf5-qt5[2019-10-24T20:18:31.598Z] Retrieving: Plasma-qqc2-desktop-style-stable-kf5-qt5[2019-10-24T20:18:31.598Z] Retrieving: Plasma-syndication-stable-kf5-qt5[2019-10-24T20:18:31.860Z] Retrieving: Plasma-kjs-stable-kf5-qt5[2019-10-24T20:18:31.860Z] Retrieving: Plasma-kdecoration-stable-kf5-qt5[2019-10-24T20:18:31.860Z] Retrieving: Plasma-kscreenlocker-stable-kf5-qt5[2019-10-24T20:18:31.860Z] Retrieving: Plasma-kwayland-integration-stable-kf5-qt5[2019-10-24T20:18:32.121Z] Retrieving: Plasma-breeze-stable-kf5-qt5[2019-10-24T20:18:32.121Z] Retrieving: Plasma-khtml-stable

D24934: [notifications] Center no notification text on mobile

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:580
>  PlasmaExtras.Heading {
>  width: list.width
> +height: list.height

Now you could have used an `anchors.fill` xD

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24934

To: nicolasfella, #plasma, #vdg, broulik
Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24934: [notifications] Center no notification text on mobile

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c3ab37034791: [notifications] Center no notification text 
on mobile (authored by nicolasfella).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24934?vs=68721&id=68722

REVISION DETAIL
  https://phabricator.kde.org/D24934

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: nicolasfella, #plasma, #vdg, broulik
Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24934: [notifications] Center no notification text on mobile

[Nicolas Fella]

nicolasfella updated this revision to Diff 68721.
nicolasfella added a comment.


  - Fix it

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24934?vs=68720&id=68721

BRANCH
  cent

REVISION DETAIL
  https://phabricator.kde.org/D24934

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: nicolasfella, #plasma, #vdg, broulik
Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24934: [notifications] Center no notification text on mobile

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Fix it, then ship it

INLINE COMMENTS

> FullRepresentation.qml:582
> +horizontalAlignment: Kirigami.Settings.isMobile ? 
> Text.AlignHCenter : Text.AlignLeft
> +wrapMode: Text.Wrap
>  level: 3

WordWrap

> FullRepresentation.qml:587
>  visible: list.count === 0
> +anchors.centerIn: Kirigami.Settings.isMobile ? parent : 
> undefined
>  }

Only vertical center now, please

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cent

REVISION DETAIL
  https://phabricator.kde.org/D24934

To: nicolasfella, #plasma, #vdg, broulik
Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24934: [notifications] Center no notification text on mobile

[Nicolas Fella]

nicolasfella added a comment.


  Looks just more complicated to me, but :shrug:

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24934

To: nicolasfella, #plasma, #vdg, broulik
Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24934: [notifications] Center no notification text on mobile

[Nicolas Fella]

nicolasfella updated this revision to Diff 68720.
nicolasfella added a comment.


  - Do as Kai says

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24934?vs=68718&id=68720

BRANCH
  cent

REVISION DETAIL
  https://phabricator.kde.org/D24934

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: nicolasfella, #plasma, #vdg, broulik
Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24934: [notifications] Center no notification text on mobile

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  Keep the width and enable wrapping and horizontal centering. We both know how 
wide some locale can get :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24934

To: nicolasfella, #plasma, #vdg, broulik
Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24935: Fix search field focus, both initial and on-demand

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now the search field doesn't get focus initially, or when the user 
types on a page.
  This is because the conditional loader that conditionally loads the 
GlobalDrawer's
  toolbar containing the search field isn't able to pass on focus or signals to 
its content
  properly. I tried various methods of fixing this by adding `focus: true` to 
all the focus
  stopes in the chain, but was unsuccessful. So this patch implements the 
conditional
  loading of the top content differently: instead the top content is always 
loaded, but
  conditionally discarded when in non-widescreen mode. This fixes the 
aforementioned issues.
  
  However it may not be the correct way to fix the problem; if not, assistance 
would be
  appreciated.
  
  BUG: 413407
  FIXED-IN: 5.18.0

TEST PLAN
  - Search field has focus when Discover is launched
  - Search field gains focus and accept text when typing anywhere
  - When the window is made mobiley, the sidebar's toolbar disappears
  - When a mobiley window is made desktoppy, the sidebar;s toolbar re-appears

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-searchfield-focus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24935

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #discover_software_store, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24934: [notifications] Center no notification text on mobile

[KonqiDragon]

KonqiDragon added a comment.


  Could you add a rounded corners?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24934

To: nicolasfella, #plasma, #vdg
Cc: KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24786: [GTK3] Add styles for libhandy widgets

[Carson Black]

cblack added a comment.


  In D24786#550396 , @ndavis wrote:
  
  > I think it might be a bit premature to copy the look of Plasma Mobile at 
this point. I don't know what is likely to change and what is likely to stay. I 
expect that it will mirror the look of desktop Plasma, which will mirror the 
look of the Breeze widget style.
  
  
  The style for the view switcher has been around in Plasma (both desktop and 
mobile) for a while (see tabbed widgets), and I believe the dialer's usage of 
flat buttons has also been around for a while.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24786

To: cblack, #breeze, #vdg
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24934: [notifications] Center no notification text on mobile

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cent

REVISION DETAIL
  https://phabricator.kde.org/D24934

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7a7363289304: [sddm-theme] Add slot to configure a logo 
to be shown on the SDDM login screen (authored by cblack).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61916&id=68717

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma, filipf, ngraham
Cc: GB_2, Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5c8ce892e394: [sddm-theme] Start moving from QQC1 to QQC2 
(authored by cblack).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=64261&id=68716

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24901: [sidebar] Add a hover effect to intro page icons

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:a306b76cb853: [sidebar] Add a hover effect to intro page 
icons (authored by filipf).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24901?vs=68641&id=68713

REVISION DETAIL
  https://phabricator.kde.org/D24901

AFFECTED FILES
  sidebar/package/contents/ui/IntroIcon.qml

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

[Wolfgang Bauer]

wbauer added a comment.


  In D24748#552313 , @anthonyfieroni 
wrote:
  
  > You can try it like that:
  >
  >   if (!m_editMode) {
  >   event->setAccepted(false);
  >   }
  >
  >
  > or
  >
  >   event->setAccepted(m_editMode);
  >
  
  
  That doesn't help, unfortunately.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24748

To: davidedmundson, #plasma
Cc: anthonyfieroni, wbauer, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[Nathaniel Graham]

ngraham added a comment.


  The desktop effects KCM doesn't have a centered form layout like this one 
does. I tried a left-aligned label but it looked quite odd.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24906

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: GB_2, ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[Björn Feber]

GB_2 added a comment.


  In the Desktop Effects KCM the label is top-left aligned.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24906

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: GB_2, ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:af39f0aeaf93: [KCMs/Night Color] Explain Night Color 
feature inline (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24906?vs=68704&id=68705

REVISION DETAIL
  https://phabricator.kde.org/D24906

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[Nathaniel Graham]

ngraham updated this revision to Diff 68704.
ngraham added a comment.


  Tweak wording and set a maximum width for the label

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24906?vs=68646&id=68704

BRANCH
  explain-night-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24906

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[Nathaniel Graham]

ngraham added a comment.


  In D24906#553215 , @ahiemstra 
wrote:
  
  > Hmm, I feel the text here is a bit vague... "can make" should probably be 
"makes". Also, do people understand what "making colours warmer" means?
  
  
  I would hope so; warm vs cool colors is a grade-school-level-art-class 
concept . :) We also use "warm" and "Cool" for the slider's explanatory labels.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  explain-night-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24906

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24925: KCM KSplash port to ManagedConfigModule

[Cyril Rossi]

crossi updated this revision to Diff 68699.
crossi added a comment.


  setNeedsSave() not needed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24925?vs=68682&id=68699

REVISION DETAIL
  https://phabricator.kde.org/D24925

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h

To: crossi, #plasma, ervin, mart, bport
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24927: Use updateItem

[Jan Grulich]

jgrulich added a comment.


  I just pushed the very same change so you don't need to do the review. Can be 
closed then.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24927

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24925: KCM KSplash port to ManagedConfigModule

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> crossi wrote in kcm.cpp:148
> it needs an explicit call, like load() and save()

My bad. setNeedsSave() is no longer needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24925

To: crossi, #plasma, ervin, mart, bport
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24924: Don't reset model when adding an active connection

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:6929300787ac: Don't reset model when adding an 
active connection (authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24924?vs=68695&id=68697

REVISION DETAIL
  https://phabricator.kde.org/D24924

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24919: Don't reset model when device state changes

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:2bb496b0708f: Don't reset model when device state 
changes (authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24919?vs=68694&id=68698#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24919?vs=68694&id=68698

REVISION DETAIL
  https://phabricator.kde.org/D24919

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24927: Use updateItem

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  uu

REVISION DETAIL
  https://phabricator.kde.org/D24927

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24924: Don't reset model when adding an active connection

[Nicolas Fella]

nicolasfella updated this revision to Diff 68695.
nicolasfella added a comment.


  - Only emit changed roles
  - Use updateItem

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24924?vs=68691&id=68695

BRANCH
  updavail

REVISION DETAIL
  https://phabricator.kde.org/D24924

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24919: Don't reset model when device state changes

[Nicolas Fella]

nicolasfella updated this revision to Diff 68694.
nicolasfella added a comment.


  - Only emit changed roles
  - Use updateItem

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24919?vs=68693&id=68694

BRANCH
  noreset2

REVISION DETAIL
  https://phabricator.kde.org/D24919

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24919: Don't reset model when device state changes

[Jan Grulich]

jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> networkmodel.cpp:829
>  item->invalidateDetails();
> +int row = m_list.indexOf(item);
> +Q_EMIT dataChanged(index(row, 0), index(row, 0), 
> item->changedRoles());

Please, see the comment in one of the other PRs. You can just use 
updateItem(item) and it will do everything for you. Sorry for not checking that 
earlier.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24919

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

[Nathaniel Graham]

ngraham added a comment.


  Fair enough, that seems reasonable.

INLINE COMMENTS

> configTimeZones.qml:58
> +Layout.fillWidth: true
> +Layout.margins: 1
>  

Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24919: Don't reset model when device state changes

[Nicolas Fella]

nicolasfella updated this revision to Diff 68693.
nicolasfella added a comment.


  - Only emit changed roles

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24919?vs=68677&id=68693

BRANCH
  noreset2

REVISION DETAIL
  https://phabricator.kde.org/D24919

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24926: [ResultsView] Expose limit

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/milou.git/commit/?id=eda3d274da1d502e61e24fa41f6b23b9f236baed

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D24926

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24925: KCM KSplash port to ManagedConfigModule

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:148
> doesn't managed module take care of this?

it needs an explicit call, like load() and save()

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24925

To: crossi, #plasma, ervin, mart, bport
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24926: [ResultsView] Expose limit

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Lets the user of the view decide how many items they want

TEST PLAN
  - Can have more than the default of 20 now

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D24926

AFFECTED FILES
  lib/qml/ResultsView.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24924: Don't reset model when adding an active connection

[Jan Grulich]

jgrulich added a comment.


  In D24924#553460 , @jgrulich wrote:
  
  > Actually, I just checked our code and we use updateItem(item) function, 
which does the emitting and will clear the roles automatically.
  
  
  Can you change it in other PRs too and even in the one you pushed in the 
morning?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24924

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24924: Don't reset model when adding an active connection

[Jan Grulich]

jgrulich requested changes to this revision.
jgrulich added a comment.
This revision now requires changes to proceed.


  Actually, I just checked our code and we use updateItem(item) function, which 
does the emitting and will clear the roles automatically.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24924

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24924: Don't reset model when adding an active connection

[Nicolas Fella]

nicolasfella updated this revision to Diff 68691.
nicolasfella added a comment.


  - Only emit changed roles

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24924?vs=68681&id=68691

BRANCH
  updavail

REVISION DETAIL
  https://phabricator.kde.org/D24924

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24923: Use more return early

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:c56f00b52786: Use more return early (authored by 
nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24923?vs=68689&id=68690

REVISION DETAIL
  https://phabricator.kde.org/D24923

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24925: KCM KSplash port to ManagedConfigModule

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kcm.cpp:148
> +ManagedConfigModule::defaults();
>  setNeedsSave(m_settings->isSaveNeeded());
>  }

doesn't managed module take care of this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24925

To: crossi, #plasma, ervin, mart, bport
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24923: Use more return early

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> jgrulich wrote in networkmodel.cpp:402
> I think this is a valid Qt coding style, it was just my obsession to use 
> curly braces everywhere, even for single line body.

As much as I hate it, crossi is right. 
https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  ret

REVISION DETAIL
  https://phabricator.kde.org/D24923

To: nicolasfella, jgrulich
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24923: Use more return early

[Cyril Rossi]

crossi resigned from this revision.
crossi added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> jgrulich wrote in networkmodel.cpp:402
> I think this is a valid Qt coding style, it was just my obsession to use 
> curly braces everywhere, even for single line body.

That's a good obsession and help a lot to avoid error . ;)

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  ret

REVISION DETAIL
  https://phabricator.kde.org/D24923

To: nicolasfella, jgrulich
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24923: Use more return early

[Nicolas Fella]

nicolasfella updated this revision to Diff 68689.
nicolasfella added a comment.


  - Conding style

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24923?vs=68680&id=68689

BRANCH
  ret

REVISION DETAIL
  https://phabricator.kde.org/D24923

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich, crossi
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24922: Don't reset model when available connection appears

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:d971703e1df5: Don't reset model when available 
connection appears (authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24922?vs=68679&id=68688

REVISION DETAIL
  https://phabricator.kde.org/D24922

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24923: Use more return early

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added inline comments.

INLINE COMMENTS

> crossi wrote in networkmodel.cpp:402
> Code style :  Use curly braces even when the body of a conditional statement 
> contains only one line.

I think this is a valid Qt coding style, it was just my obsession to use curly 
braces everywhere, even for single line body.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24923

To: nicolasfella, jgrulich, crossi
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24920: Add missing role changes

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:17e4fd449991: Add missing role changes (authored by 
nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24920?vs=68678&id=68687

REVISION DETAIL
  https://phabricator.kde.org/D24920

AFFECTED FILES
  libs/models/networkmodelitem.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24919: Don't reset model when device state changes

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> networkmodel.cpp:830
> +int row = m_list.indexOf(item);
> +Q_EMIT dataChanged(index(row, 0), index(row, 0));
>  // qCDebug(PLASMA_NM) << "Item " << item->name() << ": device 
> state changed to " << item->deviceState();

Shouldn't you add item->changedRoles() as the last parameter?

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  noreset2

REVISION DETAIL
  https://phabricator.kde.org/D24919

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24924: Don't reset model when adding an active connection

[Jan Grulich]

jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> networkmodel.cpp:313
> +int row = m_list.indexOf(item);
> +Q_EMIT dataChanged(index(row, 0), index(row, 0));
>  }

Shouldn't you add item->changedRoles() as the last parameter?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24924

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24923: Use more return early

[Cyril Rossi]

crossi requested changes to this revision.
crossi added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> networkmodel.cpp:402
>  // Check whether the connection is already in the model to avoid 
> duplicates, but this shouldn't happen
> -if (!m_list.contains(NetworkItemsList::Connection, connection->path())) {
> -NetworkModelItem *item = new NetworkModelItem();
> -item->setConnectionPath(connection->path());
> -item->setName(settings->id());
> -item->setTimestamp(settings->timestamp());
> -item->setType(settings->connectionType());
> -item->setUuid(settings->uuid());
> -item->setSlave(settings->isSlave());
> +if (m_list.contains(NetworkItemsList::Connection, connection->path()))
> +return;

Code style :  Use curly braces even when the body of a conditional statement 
contains only one line.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24923

To: nicolasfella, jgrulich, crossi
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24925: KCM KSplash port to ManagedConfigModule

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, mart, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24925

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24924: Don't reset model when adding an active connection

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  same resoning as in D24903 

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  updavail

REVISION DETAIL
  https://phabricator.kde.org/D24924

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24923: Use more return early

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  ret

REVISION DETAIL
  https://phabricator.kde.org/D24923

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24922: Don't reset model when available connection appears

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  addAvailableConnection() does the proper row/data update handling already
  
  Depends on D24920 

TEST PLAN
  Opened a new Wifi, it appeared in the plasmoid

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  resetava

REVISION DETAIL
  https://phabricator.kde.org/D24922

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24920: Add missing role changes

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  A few roles were not marked as changed properly.

TEST PLAN
  Builds

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  changedRoles

REVISION DETAIL
  https://phabricator.kde.org/D24920

AFFECTED FILES
  libs/models/networkmodelitem.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24919: Don't reset model when device state changes

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  same resoning as in D24903 

TEST PLAN
  Toggled Wifi in plasmoid

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  noreset2

REVISION DETAIL
  https://phabricator.kde.org/D24919

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24913: Converts a couple foreach

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1f95ea34ac40: Converts a couple foreach (authored by 
meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24913?vs=68668&id=68675

REVISION DETAIL
  https://phabricator.kde.org/D24913

AFFECTED FILES
  krunner/view.cpp

To: meven, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  In D24732#552239 , @ngraham wrote:
  
  > There still isn't a border around the inner view. That's what I'm trying to 
get there. Otherwise it doesn't look like an inner view; it looks like a 
floating rectangle.
  
  
  Solved now. I used same border which is used in Kirigami components. I also 
added small rounding for the highlight, which I think makes it little more 
nicer.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich updated this revision to Diff 68673.
jgrulich added a comment.


  - Add border around the view and use small radius around for item highlight

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68502&id=68673

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24918: Fix issue when there is no WidgetStyle value in kdeglobals

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  KConfig XT does not store default values in conf files. KCM Style applying 
default style, KHintsSetting expect a value in kdeglobals or ignore the notify 
change.
  fix to provide a default value to allow applying default widget style.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D24918

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: crossi, #plasma, ervin, bport, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24916: KCM style : fix combobox that weren't updated after user made change

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, mart, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

TEST PLAN
  Inside Configure Icons and Toolbars popup menu, change some value in 
combobox, hit apply, then defaults, values inside combobx should be restored

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24916

AFFECTED FILES
  kcms/style/package/contents/ui/EffectSettingsPopup.qml

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24917: KCM Style port to KConfigXT

[Cyril Rossi]

crossi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24917

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/stylesettings.kcfg
  kcms/style/stylesettings.kcfgc

To: crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24913: Converts a couple foreach

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> view.cpp:224
>  
> -Q_FOREACH (QScreen* screen, QGuiApplication::screens()) {
> +const auto screens = QGuiApplication::screens();
> +for (QScreen* screen : screens) {

screens currently returns QList and QList should get deprecated in 
Qt6, so using auto might save us some porting later on.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24913

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24913: Converts a couple foreach

[Méven Car]

meven created this revision.
meven added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24913

AFFECTED FILES
  krunner/view.cpp

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24894: notifier: Make action buttons translatable

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  Good catch! I wonder how that happened :/

REPOSITORY
  R134 Discover Software Store

BRANCH
  notifier-i18n

REVISION DETAIL
  https://phabricator.kde.org/D24894

To: aspotashev, apol, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 137 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/137/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 24 Oct 2019 10:35:30 +
 Build duration:
9 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report11%
(2/19)5%
(7/134)5%
(7/134)4%
(464/12880)2%
(178/8649)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskcm0%
(0/1)0%
(0/1)0%
(0/305)0%
(0/210)kded0%
(0/12)0%
(0/12)0%
(0/1280)0%
(0/946)libs0%
(0/4)0%
(0/4)0%
(0/928)0%
(0/525)libs.declarative0%
(0/7)0%
(0/7)0%
(0/613)0%
(0/463)libs.editor36%
(4/11)36%
(4/11)27%
(212/797)22%
(163/752)libs.editor.settings0%
(0/21)0%
(0/21)0%
(0/2997)0%
(0/1952)libs.editor.widgets0%
(0/17)0%
(0/17)0%
(0/981)0%
(0/426)libs.models0%
(0/9)0%
(0/9)0%
(0/1448)0%
(0/1199)tests100%
(3/3)100%
(3/3)100%
(252/252)63%
(15/24)vpn.fortisslvpn0%
(0/5)0%
(0/5)0%
(0/150)0%
(0/70)vpn.iodine0%
(0/4)0%
(0/4)0%
(0/96)0%
(0/38)vpn.l2tp0%
(0/6)0%
(0/6)0%
(0/341)0%
(0/181)vpn.openswan0%
(0/4)0%
(0/4)0%
(0/159)0%
(0/102)vpn.openvpn0%
(0/5)0%
(0/5)0%
(0/1224)0%
(0/1047)vpn.pptp0%
(0/5)0%
(0/5)0%
(0/207)0%
(0/89)vpn.ssh0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/131)vpn.sstp0%
(0/5)0%
(0/5)0%
(0/244)0%
(0/117)vpn.strongswan0%
(0/5)0%
(0/5)0%
(0/149)0%
(0/73)vpn.vpnc0%
(0/5)0%
  

D24910: Fix build

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:ba142dd7125c: Fix build (authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24910?vs=68660&id=68661

REVISION DETAIL
  https://phabricator.kde.org/D24910

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24910: Fix build

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  You could just push this without me doing review :).

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  fix

REVISION DETAIL
  https://phabricator.kde.org/D24910

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[Arjen Hiemstra]

ahiemstra added a comment.


  Hmm, I feel the text here is a bit vague... "can make" should probably be 
"makes". Also, do people understand what "making colours warmer" means?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  explain-night-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24906

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24910: Fix build

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  fix

REVISION DETAIL
  https://phabricator.kde.org/D24910

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 136 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/136/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 24 Oct 2019 10:27:18 +
 Build duration:
1 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 484 lines...][2019-10-24T10:28:26.443Z] [ 19%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wiredsecurity.cpp.o[2019-10-24T10:28:26.711Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardinterfacewidget.cpp.o[2019-10-24T10:28:26.967Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardtabwidget.cpp.o[2019-10-24T10:28:28.340Z] [ 20%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/settings/wireguardpeerwidget.cpp.o[2019-10-24T10:28:28.340Z] [ 21%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/bssidcombobox.cpp.o[2019-10-24T10:28:28.340Z] [ 21%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/advancedpermissionswidget.cpp.o[2019-10-24T10:28:28.598Z] [ 22%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/delegate.cpp.o[2019-10-24T10:28:28.858Z] [ 22%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/editlistdialog.cpp.o[2019-10-24T10:28:29.114Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/hwaddrcombobox.cpp.o[2019-10-24T10:28:29.114Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/intdelegate.cpp.o[2019-10-24T10:28:29.373Z] /home/jenkins/workspace/Plasma/plasma-nm/kf5-qt5 SUSEQt5.12/libs/editor/settings/wireguardtabwidget.cpp:53:30: warning: ���WireGuardKeyValidator keyValidator()��� declared ���static��� but never defined [-Wunused-function][2019-10-24T10:28:29.373Z]53 | static WireGuardKeyValidator keyValidator();[2019-10-24T10:28:29.373Z]   |  ^~~~[2019-10-24T10:28:29.937Z] [ 23%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv4delegate.cpp.o[2019-10-24T10:28:29.937Z] [ 24%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv4routeswidget.cpp.o[2019-10-24T10:28:29.937Z] [ 24%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv6delegate.cpp.o[2019-10-24T10:28:30.200Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ipv6routeswidget.cpp.o[2019-10-24T10:28:30.463Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/passwordfield.cpp.o[2019-10-24T10:28:30.463Z] [ 25%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/settingwidget.cpp.o[2019-10-24T10:28:30.719Z] [ 26%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/ssidcombobox.cpp.o[2019-10-24T10:28:30.719Z] [ 26%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditorbase.cpp.o[2019-10-24T10:28:31.288Z] [ 27%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditordialog.cpp.o[2019-10-24T10:28:31.288Z] [ 27%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/connectioneditortabwidget.cpp.o[2019-10-24T10:28:31.548Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/listvalidator.cpp.o[2019-10-24T10:28:31.809Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleipv4addressvalidator.cpp.o[2019-10-24T10:28:32.067Z] [ 28%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleipv6addressvalidator.cpp.o[2019-10-24T10:28:32.323Z] [ 29%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/simpleiplistvalidator.cpp.o[2019-10-24T10:28:32.584Z] [ 29%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/wireguardkeyvalidator.cpp.o[2019-10-24T10:28:32.840Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/vpnuiplugin.cpp.o[2019-10-24T10:28:32.840Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/configuration.cpp.o[2019-10-24T10:28:32.840Z] [ 30%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/debug.cpp.o[2019-10-24T10:28:33.099Z] [ 31%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/__/uiutils.cpp.o[2019-10-24T10:28:33.099Z] [ 31%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/widgets/mobileconnectionwizard.cpp.o[2019-10-24T10:28:33.357Z] [ 32%] Building CXX object libs/editor/CMakeFiles/plasmanm_editor.dir/mobileproviders.cpp.o[2019-10-24T10:28:35.874Z] [ 32%] Linking CXX shared library ../../bin/libplasmanm_editor.so[2019-10-24T10:28:36.810Z] [ 32%] Built target plasmanm_editor[2019-10-24T10:28:36.810Z] Scanning dependencies of target plasmanm_internal_autogen[2019-10-24T10:28:36.810Z] Scanning dependencies of target simpleipv4test_autogen[2019-10-24T10:28:36.810Z] Scanning dependencies of target simpleipv6test_autogen[2019-10-24T10:28:36.810Z] Scanning 

D24905: Use return early

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:f301f1ead38a: Use return early (authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24905?vs=68658&id=68659

REVISION DETAIL
  https://phabricator.kde.org/D24905

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24905: Use return early

[Nicolas Fella]

nicolasfella updated this revision to Diff 68658.
nicolasfella added a comment.


  - s/break/continue
  - Fixup

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24905?vs=68644&id=68658

BRANCH
  returnearly

REVISION DETAIL
  https://phabricator.kde.org/D24905

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24903: Don't reset model when activeconnectionstate changed

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:4627aaf6f066: Don't reset model when 
activeconnectionstate changed (authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24903?vs=68643&id=68656

REVISION DETAIL
  https://phabricator.kde.org/D24903

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24900: [mobile/wifi] Remove special font style for active connection

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:5e9ff384b503: [mobile/wifi] Remove special font style for 
active connection (authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24900?vs=68638&id=68655

REVISION DETAIL
  https://phabricator.kde.org/D24900

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24899: Remove commented out code

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:33991d909626: Remove commented out code (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24899?vs=68636&id=68654#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24899?vs=68636&id=68654

REVISION DETAIL
  https://phabricator.kde.org/D24899

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24897: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:b83e86d817bc: [mobile/wifi] Remove broken confirmation 
dialog when forgetting a connection (authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24897?vs=68633&id=68653

REVISION DETAIL
  https://phabricator.kde.org/D24897

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

[Konrad Materka]

kmaterka added a comment.


  It looks like there are some review changes required in D24798 
. Maybe I can commit my changes first? 
D24798  needs changes anyway and it would 
be good to split QCC1 -> QCC2 migration from layout fix.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[David Edmundson]

davidedmundson added a comment.


  > They prefer, correct me if I'm wrong, something like "[Night Color KCM]".
  
  Plasma folks don't really have a good style sorted. You can find examples of 
3 different styles.
  
  It is a good point that we miss a consistency :/
  but it also means no individual commit is wrong right now.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  explain-night-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24906

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[David Edmundson]

davidedmundson added a comment.


  > They prefer, correct me if I'm wrong, something like "[Night Color KCM]".

REPOSITORY
  R119 Plasma Desktop

BRANCH
  explain-night-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24906

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in WallpaperFader.qml:145
> Why are we changing this line?

The clock shadow effectively renders the clock (shader effect with source 
hidden), so it has to be hidden.

> davidedmundson wrote in config.qml:21
> One thing Thomas always used to say was that if you have a checkbox it should 
> be obvious what the opposite action is.
> 
> This currently sounds like if it's off, the clock will randomly start 
> flashing like a 90's html  tag.

Can I have a  clock?
"Show when idle"? (Open to non-jargon suggestions)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> WallpaperFader.qml:145
>  target: clock.shadow
> -opacity: 1
> +opacity: wallpaperFader.alwaysShowClock ? 1 : 0
> +}

Why are we changing this line?

> config.qml:21
> +id: alwaysClock
> +text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "verb, to 
> show something", "Always show")
> +}

One thing Thomas always used to say was that if you have a checkbox it should 
be obvious what the opposite action is.

This currently sounds like if it's off, the clock will randomly start flashing 
like a 90's html  tag.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24906: [KCMs/Night Color] Explain Night Color feature inline

[Vlad Zahorodnii]

zzag added a comment.


  > [KCMs/Night Color]
  
  Plasma folks don't use such scopes. They prefer, correct me if I'm wrong, 
something like "[Night Color KCM]".

REPOSITORY
  R119 Plasma Desktop

BRANCH
  explain-night-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24906

To: ngraham, #vdg, #plasma, ndavis, zzag
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Night Color Widget (Redshift Control Widget adapt to kwin's Night Color)

[John Salatas]

Hey guys!

I was thinking about resurrecting the Redshift Control Widget, as 
apparently there are users (including me) that find it very convenient 
to be able to enable/disable Night Color with just a click.


Anyway I have some questions that I hope you might be able to 
answer. Currently Redshift Control Widget interacts with the redshift 
command through cli commands using an executable datasource engine [1]. 
Given the fact that kwin exposes a dbus interface for the Night Color 
functionality [2], I was thinking that the most straightforward approach 
would be to change the cli commands executed by the executable 
datasource engine and instead of interacting with the redshift command, 
I could use something like qdbus [3], or dbus-send [4] to send messages 
to the kwin's DBus interface.


So my first question is whether I'm right with the above approach. Might 
it be better to communicate with the DBus at some other way? How? Can 
you point me to some documentation, or example implementation?


Furthermore, in case that I want to call setNightColorConfig which 
requires a QHash argument [5], how can I encode it 
for either qdbus or dbus-send?


Finally, I'm not sure if it is better to just create a new git repo and 
create a new widget from scratch borrowing/duplicating most of the 
existing code, or if it is better to continue with the existing 
repo/code and rename the widget from Redshift Control Widget to Night 
Color Widget, or whatever! (btw I'm one of the maintainers of Redshift 
Control Widget) :\


Thank you in advance!

John Salatas


References

[1] 
https://phabricator.kde.org/source/plasma-redshift-control/browse/master/package/contents/ui/main.qml$123


[2] 
https://phabricator.kde.org/source/kwin/browse/master/colorcorrection/colorcorrectdbusinterface.h


[3] https://manpages.ubuntu.com/manpages/bionic/en/man1/qdbus.1.html

[4] https://dbus.freedesktop.org/doc/dbus-send.1.html

[5] 
https://phabricator.kde.org/source/kwin/browse/master/colorcorrection/colorcorrectdbusinterface.h$97

D24905: Use return early

[Jan Grulich]

jgrulich added a comment.


  In D24905#553119 , @broulik wrote:
  
  > I think all of thise `breaks` in loops must be `continue`s?
  
  
  Good catch.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  returnearly

REVISION DETAIL
  https://phabricator.kde.org/D24905

To: nicolasfella, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Night Color Widget (adapt Redshift Control Widget to kwin's Night Color functionality)

[John Salatas]

Hey guys!

I was thinking about resurrecting the Redshift Control Widget, as 
apparently there are users (including me) that find it very convenient 
to be able to enable/disable Night Color with just a click.


Anyway I have some questions that I hope you might be able to 
answer. Currently Redshift Control Widget interacts with the redshift 
command through cli commands using an executable datasource engine [1]. 
Given the fact that kwin exposes a dbus interface for the Night Color 
functionality [2], I was thinking that the most straightforward approach 
would be to change the cli commands executed by the executable 
datasource engine and instead of interacting with the redshift command, 
I could use something like qdbus [3], or dbus-send [4] to send messages 
to the kwin's DBus interface.


So my first question is whether I'm right with the above approach. Might 
it be better to communicate with the DBus at some other way? How? Can 
you point me to some documentation, or example implementation?


Furthermore, in case that I want to call setNightColorConfig which 
requires a QHash argument [5], how can I encode it 
for either qdbus or dbus-send?


Finally, I'm not sure if it is better to just create a new git repo and 
create a new widget from scratch borrowing/duplicating most of the 
existing code, or if it is better to continue with the existing 
repo/code and rename the widget from Redshift Control Widget to Night 
Color Widget, or whatever! (btw I'm one of the maintainers of Redshift 
Control Widget) :\


Thank you in advance!

John Salatas


References

[1] 
https://phabricator.kde.org/source/plasma-redshift-control/browse/master/package/contents/ui/main.qml$123


[2] 
https://phabricator.kde.org/source/kwin/browse/master/colorcorrection/colorcorrectdbusinterface.h


[3] https://manpages.ubuntu.com/manpages/bionic/en/man1/qdbus.1.html

[4] https://dbus.freedesktop.org/doc/dbus-send.1.html

[5] 
https://phabricator.kde.org/source/kwin/browse/master/colorcorrection/colorcorrectdbusinterface.h$97

D24894: notifier: Make action buttons translatable

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  5.17 branch please. While you cannot change strings, you can make previously 
accidentally untranslated strings translatable.

REPOSITORY
  R134 Discover Software Store

BRANCH
  notifier-i18n

REVISION DETAIL
  https://phabricator.kde.org/D24894

To: aspotashev, apol, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24905: Use return early

[Kai Uwe Broulik]

broulik added a comment.


  I think all of thise `breaks` in loops must be `continue`s?

INLINE COMMENTS

> networkmodel.cpp:457
> +if (item->itemType() != NetworkModelItem::AvailableConnection)
> +break;
> +

Shouldn't this be a `continue`?

> networkmodel.cpp:843
> +if (dev->type() != NetworkManager::Device::Modem)
> +break;
> +

`continue`?

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  returnearly

REVISION DETAIL
  https://phabricator.kde.org/D24905

To: nicolasfella, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart