D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  This will unclutter the context menu a bit, +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D24839

REVISION DETAIL
  https://phabricator.kde.org/D24839

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24894: notifier: Make action buttons translatable

[Alexander Potashev]

aspotashev added a comment.


  In D24894#554481 , @yurchor wrote:
  
  > A similar issue can be found in 
libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141:
  >
  > 
https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp#n141
  >
  > Can it be fixed as well?
  >
  > Thanks in advance for your answer.
  
  
  fixed

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24894

To: aspotashev, apol, broulik
Cc: yurchor, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24894: notifier: Make action buttons translatable

[Alexander Potashev]

aspotashev added a comment.


  In D24894#554481 , @yurchor wrote:
  
  > A similar issue can be found in 
libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141:
  >
  > 
https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp#n141
  >
  > Can it be fixed as well?
  >
  > Thanks in advance for your answer.
  
  
  I will fix this.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24894

To: aspotashev, apol, broulik
Cc: yurchor, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D13360: Touchpad KDED module: Convert to JSON metadata

[David Faure]

dfaure added a comment.


  I didn't fully follow this saga, but AFAICS this patch was reverted (commit 
3432c3342b1f801 
, 
bug 395622), so we still rely on desktop files to load the touchpad kded 
module. Can this patch be applied again now that commit f040cdb399b 
 
(X-KDE-PluginInfo-Name=touchpad) is in, or is something else missing?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: dfaure, cfeck, kossebau, fvogt, romangg, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D24839

REVISION DETAIL
  https://phabricator.kde.org/D24839

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24894: notifier: Make action buttons translatable

[Yuri Chornoivan]

yurchor added a comment.


  A similar issue can be found in 
libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141:
  
  
https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp#n141
  
  Can it be fixed as well?
  
  Thanks in advance for your answer.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24894

To: aspotashev, apol, broulik
Cc: yurchor, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24894: notifier: Make action buttons translatable

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d877aa09ba17: notifier: Make action buttons translatable 
(authored by aspotashev).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24894?vs=68625&id=68799

REVISION DETAIL
  https://phabricator.kde.org/D24894

AFFECTED FILES
  notifier/DiscoverNotifier.cpp

To: aspotashev, apol, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24964: [applets/weather] Port from KIconLoader to QIcon

[Ismael Asensio]

iasensio created this revision.
iasensio added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  `KIconLoader` was used only to check if the `iconName` is valid.
  This patch uses `QIcon::hasThemeIcon()` instead.
  It might help T11637  a little.

TEST PLAN
  No behavior changes

REPOSITORY
  R114 Plasma Addons

BRANCH
  weather_qicon

REVISION DETAIL
  https://phabricator.kde.org/D24964

AFFECTED FILES
  applets/weather/plugin/util.cpp

To: iasensio, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart