KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 198 - Still unstable!

2019-11-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/198/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 02 Nov 2019 04:41:58 +
 Build duration:
8 min 51 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24879: [ComboBox] Follow focusPolicy

2019-11-01 Thread Kai Uwe Broulik 
broulik added a comment.


  Ping

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24879

To: broulik, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25109: Make it impossible to open the progress view sheet multiple times

2019-11-01 Thread Jonah Brüchert 
jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  It used to be possible after resizing the window so narrowly that the drawer 
switched into modal mode and back to its original width.
  There is still the question of why the sheet is sometimes left behind the 
drawer, but that's probably something for another patch.

TEST PLAN
  Multiple ProgressView sheets can't be opened at the same time anymore

REPOSITORY
  R134 Discover Software Store

BRANCH
  progress-view-open-only-once (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25109

AFFECTED FILES
  discover/qml/ProgressView.qml

To: jbbgameich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Arjen Hiemstra 
ahiemstra added a comment.


  Can you also have a look at the height and reservedSpace properties below it? 
Those have similar issues.

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D23198: Skip mime type check only for files on network mounts

2019-11-01 Thread Nathaniel Graham 
ngraham added a comment.


  What's the current status of this patch?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-11-01 Thread Kai Uwe Broulik 
broulik added a comment.


  I think it might make sense to move that to libnotification `Server` so the 
applet can get the same information without duplicating code there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25097

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24945: [ksmserver] Signal session management state to kwin directly

2019-11-01 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:09cad25f998a: [ksmserver] Signal session management state 
to kwin directly (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24945?vs=69112=69161

REVISION DETAIL
  https://phabricator.kde.org/D24945

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/logout.cpp
  ksmserver/org.kde.KWin.Session.xml
  ksmserver/server.cpp
  ksmserver/server.h

To: davidedmundson, #kwin, apol
Cc: broulik, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Carl Schwan 
ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb
Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Dimitris Kardarakos 
dkardarakos added a comment.


  Before
  F7709694: before.png 
  
  After
  F7709700: after.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Dimitris Kardarakos 
dkardarakos created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  In PageRow documentation, globalToolBar's style contains an unordered list of 
the various style value options. With this commit, the list is properly 
displayed.

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

AFFECTED FILES
  src/controls/PageRow.qml

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25103: Simplify application load

2019-11-01 Thread Dimitris Kardarakos 
dkardarakos created this revision.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  These is no need to have two different main QML files for desktop and mobile, 
and we do need to check environmental variables to load a platform-specific QML 
file.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  simple-main (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25103

AFFECTED FILES
  src/data/contents/ui/BaseApp.qml
  src/data/contents/ui/mobileApp.qml
  src/main.cpp
  src/resources.qrc

To: dkardarakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein

D25086: [WIP] Port to KGlobalAccel

2019-11-01 Thread Laurent Montel 
mlaurent added inline comments.

INLINE COMMENTS

> basictab.cpp:38
>  
>  #ifndef Q_OS_WIN
> +#include "globalaccel.h"

still necessary to #ifndef ?

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart