D25670: Synchronize decorations buttons order in GTK headerbars

[Mikhail Zolotukhin]

gikari added a comment.


  In D25670#570517 , @cblack wrote:
  
  > You would probably want to use `icon` instead of `menu`, as `menu` is only 
rendered as a fallback for a pattern that most GNOME applications don't use 
nowadays.
  >
  > Edit: Additionally, GTK apps that use an appmenu typically override the 
window decoration layout to reflect this. If they don't, then that's an issue 
on their end.
  
  
  I would like to say "It is their issue", but the thing is, if we remove 
appmenu from that apps, they will be unusable, because this menu contains 
important functionality, that is not present in the other parts of an app. If I 
choose to just grab `icon` instead of `menu`, apps would break and the user 
will be confused and unable to use these apps.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25670

To: gikari, #vdg, cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:e3274dba5fb2: Remove unneeded options in GTK KCM (authored 
by gikari, committed by ngraham).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24744?vs=69779=70714

REVISION DETAIL
  https://phabricator.kde.org/D24744

AFFECTED FILES
  CMakeLists.txt
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk3.cpp
  src/appearencegtk.cpp
  src/cursorthemesmodel.cpp
  src/cursorthemesmodel.h
  src/dialog_installer.cpp
  src/dialog_installer.h
  src/dialog_uninstaller.cpp
  src/dialog_uninstaller.h
  src/fontshelpers.cpp
  src/fontshelpers.h
  src/gtkconfigkcmodule.cpp
  src/gtkconfigkcmodule.h
  src/iconthemesmodel.cpp
  src/iconthemesmodel.h
  src/installer.cpp
  src/installer.h
  src/thread.cpp
  src/ui/dialog_installer.ui
  src/ui/dialog_uninstaller.ui
  src/ui/gui.ui
  tests/configsavetest.cpp

To: gikari, #vdg, #plasma, ngraham, nicolasfella
Cc: apol, ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, 
ahiemstra, mbohlender, mart

D25672: Port to std::sort

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  qsort is deprecated

REPOSITORY
  R122 Powerdevil

BRANCH
  qsort

REVISION DETAIL
  https://phabricator.kde.org/D25672

AFFECTED FILES
  daemon/backends/upower/backlighthelper.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25670: Synchronize decorations buttons order in GTK headerbars

[Carson Black]

cblack added a comment.


  You would probably want to use `icon` instead of `menu`, as `menu` is only 
rendered as a fallback for a pattern that most GNOME applications don't use 
nowadays.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25670

To: gikari, #vdg, cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25671: Fix git builds against Qt 5.14

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's not really acceptable to just error on everything since some of the
  solutions (like in this case) might not be retrocompatible.
  
  The error was:
  kdecoration/src/decoration.cpp:386:37: error: no member named 'posF' in 
'QWheelEvent'

TEST PLAN
  Builds now

REPOSITORY
  R129 Window Decoration Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25671

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25670: Synchronize decorations buttons order in GTK headerbars

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Window decorations button order was applied only for window headers that was 
controlled by KWin, but not for GTK applications with CSD.  Now it is no longer 
true - button order in CSD applications are in sync with the one used by KWin.
  
  Only Close, Maximize, Minimize and Icon buttons are synchronised, because GTK 
supports only them (Actually for Application icon in KWin titles there are two 
gtk counterparts: `icon` and `menu`, see the second point below).
  
  What I do not like:
  
  1. To sync settings I use KWin DBus signal that is emitted in more than 20 
places besides window decoration settings. It would be sensible to use an 
individual signal. I would like to hear an advice about its naming.
  2. GTK apps have so called appmenu (it is a button with an application icon), 
which is used in a few applications, such as Lutris or BleachBit. It is very 
important in applications, I believe, because without it it is not possible to 
fully use application, so it IMO should be always displayed. However, the user 
might want to not display window menu (an application) in KWin window titles, 
so after he decides to do that he will lose the gtk menu too. I would like to 
hear suggestions how to solve that problem.
  
  Possible solutions for the second item:
  
  1. Sync Kwin Menu and GTK `menu` headerbar option. Cons: see above
  2. Sync KWin Menu and GTK `icon` headerbar option. Appmenu is always 
displayed in fixed position. Cons: There is two icons of app in headerbar.

TEST PLAN
  1. Open two windows alongside each other: window decorations button order 
settings and any gtk3 app with CSD (for example, Lutris)
  2. Restart kded5
  3. Apply any WD button order, apply settings
  4. The app should change its buttons order in headerbar (if xsettingsd is not 
installed, on X11 only after restart)

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  gtk-decoration-order-sync (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25670

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25668: Port away from deprecated KIconLoader::SmallIcon

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Compiles, still get an Xorg icon in the tree

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25668

AFFECTED FILES
  Modules/base/os_base.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12685: Fix calendar view: hide unused start/end time labels in day events list

[Friedrich W. H. Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  Sadly lost track of this, and no plans to pick this up again in the 
foreseeable future given other stuff to do, so discarding now to clean up the 
todo stack.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12685

To: kossebau, #vdg, #plasma, dvratil
Cc: abetts, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D25617: MenuIcon: fix warnings when the drawer isn't initialized

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:1f56aba8449a: MenuIcon: fix warnings when the drawer 
isnt initialized (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25617?vs=70586=70686

REVISION DETAIL
  https://phabricator.kde.org/D25617

AFFECTED FILES
  src/controls/templates/private/MenuIcon.qml

To: apol, #kirigami, mart, ngraham
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25618: Account for a mnemonic label to go back to ""

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e649887194f5: Account for a mnemonic label to go back to 
 (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25618?vs=70587=70685

REVISION DETAIL
  https://phabricator.kde.org/D25618

AFFECTED FILES
  src/mnemonicattached.cpp

To: apol, #kirigami, mart, ngraham
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

[Alexander Potashev]

aspotashev added a comment.


  Examples of non-ASCII digits:
  
Original Message: Every 30 Minutes

Farsi (Persian) :   هر ۳۰ دقیقه
Khmer : រៀង​រាល់​ ៣០ ​នាទី​​
Nepali :प्रत्येक ३० मिनेटमा
  
  ( found here: 
https://l10n.kde.org/dictionary/compare-translations.php?package=applications=autorefresh.po=Every+30+Minutes
 )

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24838

To: ngraham, #plasma, zzag
Cc: aspotashev, zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

[Alexander Potashev]

aspotashev added a comment.


  Looks like `parseInt()` won't work for non-ASCII digits and for languages 
where the number of minutes does not come first in the phrase, see Sinhala 
language:
  
ro Romanian :   %1 minute
ru Russian :%1 минуты
gd Scottish Gaelic :%1 m(h)ionaid(ean)
sr Serbian :%1 минута
si Sinhala :මිනිත්තු %1
  
  ( found here: 
https://l10n.kde.org/dictionary/compare-translations.php?package=frameworks=kdelibs4support.po=%251+minutes
 )

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24838

To: ngraham, #plasma, zzag
Cc: aspotashev, zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25636: Fixup deprecated use of QWeakPointer::data

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R129:a2851338b3d6: Fixup deprecated use of QWeakPointer::data 
(authored by davidedmundson).

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25636?vs=70629=70662

REVISION DETAIL
  https://phabricator.kde.org/D25636

AFFECTED FILES
  src/decorationbutton.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart