D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

[Noah Davis]

ndavis updated this revision to Diff 72280.
ndavis added a comment.


  Change comment formatting

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26225?vs=72277=72280

BRANCH
  replace-hardcoded-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26225

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen

[Noah Davis]

ndavis updated this revision to Diff 72277.
ndavis added a comment.


  - Change newFrameRadius to newPenWidthFrameRadius
  
  This name doesn't sound very good, but at least it's more descriptive.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26225?vs=72185=72277

BRANCH
  replace-hardcoded-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26225

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

[Eike Hein]

hein added a comment.


  It's definitely a discussion I'd enjoy more :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  some-apps-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25773

To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

[Nathaniel Graham]

ngraham added a comment.


  Well, I don't wanna hasten our demise under the crushing weight of bloat, and 
I can appreciate your voice of wisdom. :) So I'll hit the pause button and 
continue the discussion.
  
  Now that I think about it, if I step back and examine my motivations for 
this, it's that I think we should use an Icons-Only Task Manager by default, 
and IOTMs make sense to pre-populate with apps (as proposed here), because 
they're basically app launchers. IOTMs (or at least the local equivalent) are 
now shipped by default in Windows, macOS, ChromeOS, Ubuntu's GNOME flavor, and 
every mobile OS. The last major OS to ship a Traditional Task Manager was 
Windows Vista 10 years ago.
  
  People are used to IOTMs at this point, and everyone else switched to them 
years ago because they're better for the common normal-user use cases of 
launching apps and switching between a small number of single-window apps than 
the now-increasingly-less-common use case of switching between a large number 
of windows many of which belong to the same app. People like us who still have 
that use case can always switch back to a TTM in three clicks.
  
  If we use an IOTM by default, we can double the panel thickness and put it on 
the left screen edge, with the positive side effect of being a touch-friendly 
launcher and app switcher for the convertible use case without needing to 
change the UI at all. I keep noticing people (you and I included) naturally 
gravitating to this panel setup, and I think it makes a lot of sense as a 
better default for 2020.
  
  Maybe it's time to have that conversation instead of pushing half-measures 
like this patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  some-apps-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25773

To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  In D25889#583707 , @ndavis wrote:
  
  > Here's a suggestion for a way to improve the UI: F7846171: 
Screenshot_20191227_195713.png 
  
  
  That looks way better, I'll give that a try.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/4/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 28 Dec 2019 04:25:43 +
 Build duration:
38 sec and counting
   CONSOLE OUTPUT
  [...truncated 244 lines...][2019-12-28T04:26:18.945Z] -- Performing Test HAVE_DATE_TIME[2019-12-28T04:26:18.945Z] -- Performing Test HAVE_DATE_TIME - Success[2019-12-28T04:26:19.213Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:19.213Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:19.213Z] -- Found KF5Plasma: /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:19.213Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2019-12-28T04:26:19.213Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] -- Found KF5People: /usr/home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] -- Found KF5: success (found suitable version "5.66.0", minimum required is "5.0.0") found components:  Plasma Service Declarative I18n KIO People [2019-12-28T04:26:19.213Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:19.213Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:19.213Z] -- Found KF5PlasmaQuick: /usr/home/jenkins/install-prefix/lib/cmake/KF5PlasmaQuick/KF5PlasmaQuickConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.66.0") [2019-12-28T04:26:19.213Z] -- Found KF5: success (found version "5.66.0") found components:  PlasmaQuick DBusAddons Notifications [2019-12-28T04:26:19.213Z] -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.6.3") [2019-12-28T04:26:19.213Z] -- Checking for module 'gstreamer-1.0'[2019-12-28T04:26:19.213Z] --   Found gstreamer-1.0, version 1.14.4[2019-12-28T04:26:19.541Z] -- Found GStreamer package: 1.14.4[2019-12-28T04:26:19.541Z] -- Found GStreamer: /usr/local/lib/libgstreamer-1.0.so (Required is at least version "1.1.90") [2019-12-28T04:26:19.541Z] -- Found GLIB2: /usr/local/lib/libglib-2.0.so  [2019-12-28T04:26:19.541Z] -- Checking for module 'gobject-2.0'[2019-12-28T04:26:19.541Z] --   Found gobject-2.0, version 2.56.3[2019-12-28T04:26:19.809Z] -- Found GOBJECT: /usr/local/lib/libgobject-2.0.so;/usr/local/lib/libgmodule-2.0.so;/usr/local/lib/libgthread-2.0.so;/usr/local/lib/libglib-2.0.so  [2019-12-28T04:26:19.809Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:67 (message):[2019-12-28T04:26:19.809Z]   warnings during generation of metainfo for org.kde.plasma.phone: Package[2019-12-28T04:26:19.809Z]   type "Plasma/LookAndFeel" not found[2019-12-28T04:26:19.809Z] [2019-12-28T04:26:19.809Z]   org.kde.kcoreaddons: Invalid plugin metadata: Attempting to create a[2019-12-28T04:26:19.809Z]   KAboutPerson from json without 'Name' property:[2019-12-28T04:26:19.809Z]   QJsonObject({"Email":"","Name":""})[2019-12-28T04:26:19.809Z] [2019-12-28T04:26:19.809Z] Call Stack (most recent call first):[2019-12-28T04:26:19.809Z]   /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaMacros.cmake:34 (kpackage_install_package)[2019-12-28T04:26:19.809Z]   CMakeLists.txt:45 

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 28 Dec 2019 04:25:43 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 283 lines...][2019-12-28T04:26:32.720Z] [2019-12-28T04:26:32.720Z] [2019-12-28T04:26:32.720Z] == Commencing Configuration:[2019-12-28T04:26:32.720Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12"[2019-12-28T04:26:32.983Z] -- The C compiler identification is GNU 9.2.1[2019-12-28T04:26:33.247Z] -- The CXX compiler identification is GNU 9.2.1[2019-12-28T04:26:33.247Z] -- Check for working C compiler: /usr/bin/cc[2019-12-28T04:26:33.247Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-12-28T04:26:33.247Z] -- Detecting C compiler ABI info[2019-12-28T04:26:33.247Z] -- Detecting C compiler ABI info - done[2019-12-28T04:26:33.247Z] -- Detecting C compile features[2019-12-28T04:26:33.247Z] -- Detecting C compile features - done[2019-12-28T04:26:33.247Z] -- Check for working CXX compiler: /usr/bin/c++[2019-12-28T04:26:33.507Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-12-28T04:26:33.507Z] -- Detecting CXX compiler ABI info[2019-12-28T04:26:33.766Z] -- Detecting CXX compiler ABI info - done[2019-12-28T04:26:33.766Z] -- Detecting CXX compile features[2019-12-28T04:26:33.766Z] -- Detecting CXX compile features - done[2019-12-28T04:26:33.767Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:33.767Z] -- Looking for __GLIBC__[2019-12-28T04:26:33.767Z] -- Looking for __GLIBC__ - found[2019-12-28T04:26:33.767Z] -- Performing Test _OFFT_IS_64BIT[2019-12-28T04:26:34.026Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-12-28T04:26:34.026Z] -- Performing Test HAVE_DATE_TIME[2019-12-28T04:26:34.026Z] -- Performing Test HAVE_DATE_TIME - Success[2019-12-28T04:26:34.286Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:34.286Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:34.286Z] -- Found KF5Plasma: /home/jenkins/install-prefix/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:34.286Z] -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2019-12-28T04:26:34.286Z] -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] -- Found KF5People: /home/jenkins/install-prefix/lib64/cmake/KF5People/KF5PeopleConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] -- Found KF5: success (found suitable version "5.66.0", minimum required is "5.0.0") found components:  Plasma Service Declarative I18n KIO People [2019-12-28T04:26:34.286Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:34.286Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2019-12-28T04:26:34.286Z] -- Found KF5PlasmaQuick: /home/jenkins/install-prefix/lib64/cmake/KF5PlasmaQuick/KF5PlasmaQuickConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.66.0") [2019-12-28T04:26:34.286Z] -- Found KF5: success (found version 

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

[Eike Hein]

hein accepted this revision.
hein added a comment.


  Ah sorry, I had a reply typed into the text field but must have botched 
hitting Submit.
  
  Personally, I'm not a fan - I think there's a bad trend of us overstuffing 
the default panel now like we're looking out of "what more can we add ..." out 
of idleness. I predict we'll remove things like this and the Show Desktop 
applet again, when the next collapsing-under-its-own-weight cycle inevitably 
hits. To speed that along I'll accept ;)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  some-apps-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25773

To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25762: Only serialize window pixmap if we're using it

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Nice :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25762

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:c16eb7a4614f: Add standard pen widths and replace 
hardcoded numbers (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26217?vs=72270=72271

REVISION DETAIL
  https://phabricator.kde.org/D26217

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Noah Davis]

ndavis updated this revision to Diff 72270.
ndavis marked 2 inline comments as done.
ndavis added a comment.


  Change symbol pen width back to 1.1

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26217?vs=72223=72270

BRANCH
  replace-hardcoded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26217

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Noah Davis]

ndavis added a comment.


  Another thing to consider is whether or not the review section in Discover 
should be kept consistent with the reviews/comments in the new GHNS UI.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26244: Install all kcm plugins into kcms subdir

[Aleix Pol Gonzalez]

apol added a comment.


  Hi,
  This is a good change but I'm afraid it needs some more tweaking.
  
  Are you sure this doesn't need adapting the desktop files?
  In fact, can you take a look at how the colors kcm does it? Emphasis on the 
kcoreaddons_desktop_to_json bit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26244

To: volkov, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Noah Davis]

ndavis added a comment.


  In D25889#577558 , @ngraham wrote:
  
  > I find that the current one takes up too much vertical space and the top 
line of text blends too much into the review itself. I feel like those issues 
should be addressed somehow. Maybe this isn't the right way, so suggestions 
would be appreciated.
  
  
  I don't think it takes up too much vertical space and I think it uses 
horizontal space inefficiently.
  
  Here's a suggestion for a way to improve the UI: F7846171: 
Screenshot_20191227_195713.png 
  
  F7846174: discover-review_card.svg 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Noah Davis]

ndavis marked an inline comment as done.
ndavis added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breeze.h:180
> For the record, //* (and /**) should also be caught by Doxygen (and hopefully 
> KDevelop). It is used more or less systematically in oxygen, so please use 
> this instead of ///

OK. KDevelop won't always detect comments that use other doxygen styles or 
display them correctly, but that's a KDevelop problem, not a Breeze code 
problem.

> hpereiradacosta wrote in breezehelper.cpp:1355
> Here the penwidth is actually changed (from 1.1 to 1.01) this could affect 
> the appearance of the actual buttons. Are you happy with the new appearance ? 
> Also, should doublecheck that this is consistent with button rendering in the 
> decoration.
> 
> In fact for the sake of changing only one thing at a time, I would set 
> penwidth::Symbol to 1.1

Yes, 1.01 works fine. 1.1 is slightly visible when scaling up the UI, so I 
changed it. I had planned to do the KDecoration after this patch. I will put 
the width change in a different commit though.

REPOSITORY
  R31 Breeze

BRANCH
  replace-hardcoded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26217

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezehelper.h:318
> +//* frame radius with new pen width
> +constexpr qreal newFrameRadius ( const qreal oldRadius, const int 
> penWidth ) const
> +{ return qMax( oldRadius - (0.5 * penWidth), 0.0 ); }

Would need a new function name than "newFrameRadius", that makes it clear when 
this should be used on not the other.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26225

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.


  looks good. See comment about the symbol pen width change and then ship it.
  
  In D26217#583358 , @ngraham wrote:
  
  > ...And after these patches land, let's do the doxygen-friendly comment 
formatting all at once in another patch.
  
  
  Most comments should already be doxygen friendly in breeze, except that //* 
and /** are used instead of ///

INLINE COMMENTS

> breeze.h:180
> + */
> +// The standard pen stroke width for symbols.
> +static constexpr qreal Symbol = 1.01;

For the record, //* (and /**) should also be caught by Doxygen (and hopefully 
KDevelop). It is used more or less systematically in oxygen, so please use this 
instead of ///

> breezehelper.cpp:1355
>  pen.setJoinStyle( Qt::MiterJoin );
> -pen.setWidthF( 1.1*qMax(1.0, 18.0/rect.width() ) );
> +pen.setWidthF( PenWidth::Symbol*qMax(1.0, 18.0/rect.width() ) );
>  painter->setPen( pen );

Here the penwidth is actually changed (from 1.1 to 1.01) this could affect the 
appearance of the actual buttons. Are you happy with the new appearance ? 
Also, should doublecheck that this is consistent with button rendering in the 
decoration.

In fact for the sake of changing only one thing at a time, I would set 
penwidth::Symbol to 1.1

REPOSITORY
  R31 Breeze

BRANCH
  replace-hardcoded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26217

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d0fffa46372c: [KCMs/Workspace] Add explanatory labels for 
click-related settings (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25873?vs=71340=72264

REVISION DETAIL
  https://phabricator.kde.org/D25873

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, Fuchs, ndavis
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

[Christian]

Fuchs accepted this revision.
Fuchs added a comment.
This revision is now accepted and ready to land.


  Good for me, hopefully the upstream bug will be fixed, too :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  explanatory-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25873

To: ngraham, #vdg, #plasma, Fuchs
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

[Nathaniel Graham]

ngraham added a comment.


  Ping.
  
  If nobody likes this, I can just abandon it, but I'd appreciate some feedback 
one way or another. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25873

To: ngraham, #vdg, #plasma, Fuchs
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Nathaniel Graham]

ngraham added a comment.


  @bruns?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

[Nathaniel Graham]

ngraham added a comment.


  @davidedmundson ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, 
ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

[Nathaniel Graham]

ngraham added a comment.


  @hein ping. Other folks seem to like this, but I don't want to move ahead 
without your approval since you're the maintainer. Maybe we can discuss it some 
more?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  some-apps-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25773

To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:fe5dbf9f2b96: Improve context menu (authored by trmdi).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72253=72255

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=369158

Christoph Feck  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #8 from Christoph Feck  ---
Thanks for the updates; changing status. If you see this issue again, please
add a comment or reopen the ticket.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=375909

Christoph Feck  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #7 from Christoph Feck  ---
Thanks for the update; changing status.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D26238#583563 , @trmdi wrote:
  
  > In D26238#583556 , @mvourlakos 
wrote:
  >
  > > In D26238#583555 , @trmdi 
wrote:
  > >
  > > > In D26238#583551 , 
@mvourlakos wrote:
  > > >
  > > > > @trmdi I used Cuttlefish app, it points to **"edit"**
  > > >
  > > >
  > > > Maybe it's `document-edit`.
  > > >  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)
  > >
  > >
  > > Correct
  >
  >
  > Could I land it now?
  
  
  Of course

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi added a comment.


  In D26238#583556 , @mvourlakos 
wrote:
  
  > In D26238#583555 , @trmdi wrote:
  >
  > > In D26238#583551 , @mvourlakos 
wrote:
  > >
  > > > @trmdi I used Cuttlefish app, it points to **"edit"**
  > >
  > >
  > > Maybe it's `document-edit`.
  > >  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)
  >
  >
  > Correct
  
  
  Could I land it now?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

[George Vogiatzis]

gvgeo planned changes to this revision.
gvgeo added a comment.


  Either I missing something, or I need to make it more clear.
  
  With this patch, the maximum volume setting is for the devices/apps that have 
enabled the raise maximum option.
  By default users will be limited to 100. Will need to enable raise maximum 
volume for some application or device first, for the default value of 150 to 
have any effect.
  Even then, the rest devices and applications will keep using 100 as maximum 
value.
  
  This could take more fine tuning, but was trying to keep patches small and 
clean:
  renaming 'maximum volume' to 'custom maximum volume'(or something better to 
explain the difference),
  adding an 'raise maximum volume for all devices/applications' option,
  make label change to 'lower maximum volume' when lower than 100% is selected.
  
  I cannot see any solution that will have as default 100 and not complicate 
the raise maximum volume even more.
  In any mode(separate or global), if default maximum volume will be kept 100, 
user will need to enable raise maximum volume and change the maximum volume.
  Even more important in case of removal of the setting. Will need to 
predefined a value.
  Right now, the slider already uses 150 which users cannot be change, does not 
cause any issue(except the existence of two modes).
  
  Marking as planned changes, no need to appear in review queues, if global 
mode is the way forward.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26234

To: gvgeo, #vdg, #plasma, drosca
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi updated this revision to Diff 72253.
trmdi added a comment.


  - Change icon of the configure action

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72246=72253

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D26238#583555 , @trmdi wrote:
  
  > In D26238#583551 , @mvourlakos 
wrote:
  >
  > > @trmdi I used Cuttlefish app, it points to **"edit"**
  >
  >
  > Maybe it's `document-edit`.
  >  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)
  
  
  Correct

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi added a comment.


  In D26238#583551 , @mvourlakos 
wrote:
  
  > @trmdi I used Cuttlefish app, it points to **"edit"**
  
  
  Maybe it's `document-edit`.
  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a comment.


  @trmdi I used Cuttlefish app, it points to **"edit"**

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a subscriber: ngraham.
mvourlakos added a comment.


  In D26238#583529 , @trmdi wrote:
  
  > In D26238#583386 , @ndavis wrote:
  >
  > > This seems inconsistent with the Plasma panel context menu: F7844566: 
Screenshot_20191227_000605.png 
  >
  >
  > Do you know what icon is used for the "Edit Panel" item in this screenshot?
  
  
  @ngraham do you know which icon this is it?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26244: Install all kcm plugins into kcms subdir

[Alexander Volkov]

volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  To reduce clutter in the plugins dir.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26244

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/autostart/CMakeLists.txt
  kcms/componentchooser/CMakeLists.txt
  kcms/dateandtime/CMakeLists.txt
  kcms/desktoppaths/CMakeLists.txt
  kcms/emoticons/CMakeLists.txt
  kcms/formats/CMakeLists.txt
  kcms/hardware/joystick/CMakeLists.txt
  kcms/kded/CMakeLists.txt
  kcms/keyboard/CMakeLists.txt
  kcms/keys/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/ksmserver/CMakeLists.txt
  kcms/mouse/CMakeLists.txt
  kcms/runners/CMakeLists.txt
  kcms/solid_actions/CMakeLists.txt
  kcms/spellchecking/CMakeLists.txt
  kcms/standard_actions/CMakeLists.txt
  solid-device-automounter/kcm/CMakeLists.txt

To: volkov
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi added a comment.


  In D26238#583386 , @ndavis wrote:
  
  > This seems inconsistent with the Plasma panel context menu: F7844566: 
Screenshot_20191227_000605.png 
  
  
  Do you know what icon is used for the "Edit Panel" item in this screenshot?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos accepted this revision.
mvourlakos added a comment.
This revision is now accepted and ready to land.


  looks ok...
  
  I am not that fond of the second line separator but we can discuss this again 
in the future.

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi added a comment.


  In D26238#583520 , @mvourlakos 
wrote:
  
  > look ok! Can you please provide also the three screenshots mentioned 
earlier for reference?
  
  
  Done.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a comment.


  look ok! Can you please provide also the three screenshots mentioned earlier 
for reference?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi updated this revision to Diff 72246.
trmdi added a comment.


  - Typo

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72244=72246

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> manager.h:114
>  void hideLatteSettingsDialog();
> -Q_INVOKABLE void showLatteSettingsDialog(int page = 
> Latte::Types::LayoutPage);
> +Q_INVOKABLE void showLatteSettingsDialog(int firstPage = 
> Latte::Types::LayoutPage, bool toogleCurrentPage = false);
>  

please fix type "**toggleCurrentPage**"

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> main.xml:10
>  
> -  100
> +  150
>  

I don't think the default should be anything but 100

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26234

To: gvgeo, #vdg, #plasma, drosca
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi updated this revision to Diff 72244.
trmdi added a comment.


  - Call toggleCurrentPage() only when using the shortcut

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72238=72244

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26242: Port the translations module to ManagedConfigModule

[Kevin Ottens]

ervin updated this revision to Diff 72243.
ervin added a comment.


  Add missing files

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26242?vs=72242=72243

REVISION DETAIL
  https://phabricator.kde.org/D26242

AFFECTED FILES
  kcms/translations/CMakeLists.txt
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h
  kcms/translations/translationssettings.cpp
  kcms/translations/translationssettings.h
  kcms/translations/translationssettingsbase.kcfg
  kcms/translations/translationssettingsbase.kcfgc

To: ervin, #plasma, mart, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26242: Port the translations module to ManagedConfigModule

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26242

AFFECTED FILES
  kcms/translations/CMakeLists.txt
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h

To: ervin, #plasma, mart, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26241: Remove Kirigami DelegateRecycler

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This is not really needed here due to the size of the delegates and of
  the list which is generally short. I ended up getting rid of it because
  it makes this config module crash somewhere in the QML runtime when the
  user clicks reset. I couldn't track down why DelegateRecycler does this
  so far.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26241

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml

To: ervin, #plasma, mart, davidedmundson, crossi, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26212: [Applet] Remember devices to raise maximum volume

[George Vogiatzis]

gvgeo planned changes to this revision.
gvgeo added a comment.


  Patch is not needed,  without separate raise maximum volume mode. 
D26234#583337 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26212

To: gvgeo, #plasma, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

[George Vogiatzis]

gvgeo added a comment.


  I get what you mean global, but I'll try to clarify for others, too.
  Currently, the option in configuration, only works from shortcuts or mouse 
wheel on task icon.
  And affects only the default output device, that is selected, at the moment 
of volume change.
  
  From what I get, you'd like to become really global, without controlling the 
Max value.
  The mockup in this case would have no more 115% maximum volume, and they all 
get 100% line mark.
  The same would be for all the applications?
  F7844978: Screenshot_20191227_102400_e.png 

  
  But I wonder, why need to have Raise maximum volume so accessible.
  If it is because one application or device is low, instead of changing it all 
the time, it would make more sense to have separate mode.
  
  **About this patch:**
  In essence, does what you said in the first comment.
  But keeps the separate mode instead of the global.
  Maximum volume becomes just a setting, for the raise maximum volume.
  Could hardcode 150% and remove the setting. Almost nothing would change for 
this patch.
  But I recall a request that enabled values below 100%.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26234

To: gvgeo, #vdg, #plasma, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a comment.


  @trmdi based on your last commit:
  
  1. you have made all showLatteSettingsDialog callers as togglers, meaning 
that : IF Latte Layouts manager is already shown and the user tries 
Layouts->Manage Layouts then the settings tab will switch to Latte Preferences 
window, is that the behavior you want?
  
  If I understood correctly then I think we want the following:
  
a. menu -> Layouts->Manage Layouts = ALWAYS shows the Layouts tab
b. menu -> Configure Latte... = ALWAYS shows there Preferences tab
c. clicking the Latte trademark in Dock config window = ALWAYS shows there 
Preferences tab
d. using [Meta+W]  = Toggles between Layouts and Preferences tab
  
  2. Please provide also three screenshots from this commit changes: a. context 
menu of applets b. context menu of a task that has one window shown c. context 
menu of Latte Tasks plasmoid when used on the desktop

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi updated this revision to Diff 72238.
trmdi added a comment.


  - Address comments

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72228=72238

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26219: Check DPMS extension being present

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:18e53dbaaea2: Check for DPMS extension being present 
(authored by broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26219?vs=72160=72234

REVISION DETAIL
  https://phabricator.kde.org/D26219

AFFECTED FILES
  daemon/actions/dpms/xcbdpmshelper.cpp

To: broulik, #plasma, anthonyfieroni, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> manager.cpp:419
>  
>  void Manager::showLatteSettingsDialog(int page)
>  {

We could try to rename the function to:

  void Manager::showLatteSettingsDialog(int firstPage, bool cycleBetweenPages = 
false)

when cycleBetweenPages = true then the current behavior is applied, in any 
other case the specified firstPage is shown

> settingsdialog.cpp:365
>  
> -void SettingsDialog::toggleCurrentPage()
> +void SettingsDialog::toggleCurrentPage(int page)
>  {

leave this function untouched and introduce a new function called,

  setCurrentPage(int page)

> settingsdialog.h:58
>  
> -void toggleCurrentPage();
> +void toggleCurrentPage(int page);
>  

leave this function untouched and introduce a new function called,

setCurrentPage(int page)

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart