D26225: Change frameRadius to use pen widths, add frameRadiusForNewPenWidth, add PenWidth::NoPen

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:5bd591bb0f3b: Change frameRadius to use pen widths, add 
frameRadiusForNewPenWidth, add… (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26225?vs=72355=72356

REVISION DETAIL
  https://phabricator.kde.org/D26225

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

[Noah Davis]

ndavis updated this revision to Diff 72355.
ndavis added a comment.


  - use frameRadiusForNewPenWidth
  
  I think the use of the word new is important here because it's taking a 
radius and modifying it based on the pen width.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26225?vs=72281=72355

BRANCH
  replace-hardcoded-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26225

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26268: Fix QTime function deprecation warnings by switching to QElapsedTimer

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:ff333a478065: Fix QTime function deprecation warnings by 
switching to QElapsedTimer (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26268?vs=72318=72354

REVISION DETAIL
  https://phabricator.kde.org/D26268

AFFECTED FILES
  kstyle/animations/breezetransitiondata.h

To: ndavis, #breeze, #plasma, hpereiradacosta
Cc: hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  In D26225#583803 , @ndavis wrote:
  
  > - Change newPenWidthFrameRadius to frameRadiusNewPenWidth
  >
  >   This sounds slightly better to me and allows it to show up next to 
frameRadius when autocompleting.
  
  
  What about "frameRadiusForPenWidth"  ? 
  I think the "New" is misleading. 
  If you agree, please change and then commit. The rest sounds good.

REPOSITORY
  R31 Breeze

BRANCH
  replace-hardcoded-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26225

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26037: feat(kded): add orientation sensor

[Roman Gilg]

romangg updated this revision to Diff 72352.
romangg added a comment.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.


  - Activate orientation sensor only when used
  - Query new libkscreen auto rotation and tablet mode API

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26037?vs=71645=72352

BRANCH
  orientation-sensor

REVISION DETAIL
  https://phabricator.kde.org/D26037

AFFECTED FILES
  CMakeLists.txt
  common/globals.h
  common/orientation_sensor.cpp
  common/orientation_sensor.h
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/output.cpp
  kded/output.h

To: romangg, #plasma
Cc: plasma-devel, davidedmundson, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26037: feat(kded): add orientation sensor

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in orientation_sensor.h:38
> I suspect some apps will need that info, but it's just as easy for them to 
> get that via QSensors directly.

Looking at it again I don't think it is advisable to remove these two values 
from the class interface. Instead having them in there for later and ignoring 
them in the meantime in the implementation in the KScreenDaemon is fine. See 
the comment there:

> We currently don't do anything with FaceUp/FaceDown, but in the future we 
> could use them to shut off and switch on again a display when display is 
> facing downwards/upwards.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26037

To: romangg, #plasma
Cc: plasma-devel, davidedmundson, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26281: feat: add auto rotate and tablet mode information

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  This adds feature flags if a backend supports auto rotations. While this is 
not
  directly a function of a backend on X11 auto rotation is not tested fully yet
  and there are problems with touch input. This way a client can query if auto
  rotation is fully functional on a backend.
  
  For the KWayland backend auto rotation and tablet mode information querying is
  already wired up but for now deactivated until all KWin patches have been
  landed.

TEST PLAN
  Compiles and tests with an XPS 2-in-1, which sadly does not send events about
  the tablet state.

REPOSITORY
  R110 KScreen Library

BRANCH
  tabletmode

REVISION DETAIL
  https://phabricator.kde.org/D26281

AFFECTED FILES
  backends/kwayland/CMakeLists.txt
  backends/kwayland/org.kde.KWin.TabletModeManager.xml
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h
  src/config.cpp
  src/config.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah my mistake. I was confused by the empty overflow issue, which your other 
patch fixes. I can confirm that this fixes the actual reported issue. :)
  
  However... I wonder if it's also worth fixing ListSectionHeader. It is indeed 
designed for you to feed it items rather than building your own custom layout, 
as this was perceived as being more simple. However I can see how this doesn't 
work at all when you put an ActionToolbar in it since it winds up inside the 
Rowlayout.  I wonder if ultimately the idea was bad and we should just require 
that you give it your own custom layout... or if maybe it can detect when  the 
item you give it is or has a layout and then replace the RowLayout with it? Or 
maybe that's a terrible idea.

REPOSITORY
  R134 Discover Software Store

BRANCH
  sources_actiontoolbar

REVISION DETAIL
  https://phabricator.kde.org/D26275

To: ahiemstra, #plasma, #discover_software_store, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fixes the issue, thanks!

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_contextbutton_visible

REVISION DETAIL
  https://phabricator.kde.org/D26279

To: ahiemstra, #kirigami, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart, hein

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26267#584400 , @ndavis wrote:
  
  > In D26267#584396 , 
@hpereiradacosta wrote:
  >
  > > -1:
  > >  if QWeakPointer::data() is obsoleted, (while needed in the code), I 
would object to adding toStrongRef, in between, since as pointed out by Antony, 
calling data immediately after brings no further security, and just results in 
some overhead (Weak to shared pointer). It means that either
  > >
  > > - weakPointer::data should not be obsoleted
  > > - the kdecoration api should be changed (to return shared pointers, or 
provide direct access to the data).
  >
  >
  > So this patch is not the correct thing to do at all, even if I make the 
changes @anthonyfieroni suggested. I doubt getting Qt to undeprecate 
QWeakPointer::data() is an option, so it seems like changing KDecoration would 
be the correct thing to do. Does that seem correct to you?
  
  
  That's my understanding yes. As long as access to the true data is needed 
(here for signal/slot connections) by the customers of kdecoration, then 
kdecoration must provide this access, without roundtrips to shared pointers. 
  Others please correct me if I am wrong.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26267

To: ndavis, #breeze, #plasma
Cc: hpereiradacosta, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

[Noah Davis]

ndavis added a comment.


  
  
  In D26267#584396 , 
@hpereiradacosta wrote:
  
  > -1:
  >  if QWeakPointer::data() is obsoleted, (while needed in the code), I would 
object to adding toStrongRef, in between, since as pointed out by Antony, 
calling data immediately after brings no further security, and just results in 
some overhead (Weak to shared pointer). It means that either
  >
  > - weakPointer::data should not be obsoleted
  > - the kdecoration api should be changed (to return shared pointers, or 
provide direct access to the data).
  
  
  So this patch is not the correct thing to do at all, even if I make the 
changes @anthonyfieroni suggested. I doubt getting Qt to undeprecate 
QWeakPointer::data() is an option, so it seems like changing KDecoration would 
be the correct thing to do. Does that seem correct to you?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26267

To: ndavis, #breeze, #plasma
Cc: hpereiradacosta, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Awesome work, @gvego. I'm really liking all of these patches of yours. :)
  
  The checkbox size issue is probably from the styling of the PlasmaComponents 
checkbox, as opposed to the basic QQC2 Checkbox. If I'm right, we'd need to fix 
the PC checkbox, or else just use the QQC2 one instead.
  
  It might also be worth figuring out how to implement the different 
window/view background colors as depicted in the mockup, because it's a common 
pattern on those mockups. Might require tweaking the scrollable list appearance 
in the Plasma style, maybe?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  -1:
  if QWeakPointer::data() is obsoleted, (while needed in the code), I would 
object to adding toStrongRef, in between, since as pointed out by Antony, 
calling data immediately after brings no further security, and just results in 
some overhead (Weak to shared pointer). It means that either
  
  - weakPointer::data should not be obsoleted
  - the kdecoration api should be changed (to return shared pointers, or 
provide direct access to the data).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26267

To: ndavis, #breeze, #plasma
Cc: hpereiradacosta, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26270: Fix QFontMetrics::width() deprecation warning by switching to boundingRect().width()

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:8a6f6851a49b: Fix QFontMetrics::width() deprecation 
warning by switching to boundingRect(). (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26270?vs=72320=72348

REVISION DETAIL
  https://phabricator.kde.org/D26270

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #breeze, #plasma, davidedmundson
Cc: hpereiradacosta, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

[Andreas Hartmetz]

ahartmetz added a comment.


  In D26185#584249 , @davidedmundson 
wrote:
  
  > Thanks for following up!
  >
  > > I'll open a Qt bug and see how it goes.
  >
  > Can you link it please.
  
  
  Somebody was faster. I added a comment and a link to this discussion.
  https://bugreports.qt.io/browse/QTBUG-80967

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D25762: Only serialize window pixmap if we're using it

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b49d5cfde098: Only serialize window pixmap if were 
using it (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25762?vs=71789=72347

REVISION DETAIL
  https://phabricator.kde.org/D25762

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  I was not able to change the checkbox size, nothing I tried worked.
  Checked other places with smaller checkbox(like notifications). But could not 
found how the size is controlled.
  
  Current view:
  F7849371: Screenshot_20191229_220847.png 

  
  F7849370: Screenshot_20191229_220809.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 72345.
gvgeo added a comment.


  Fix spacing
  Change plasmoid tooltip to mirror the port name
  Cleanup main.qml

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26271?vs=72321=72345

BRANCH
  UI (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, manueljlin, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

[Arjen Hiemstra]

ahiemstra added a comment.


  I've created https://phabricator.kde.org/D26279 for the overflow menu.
  
  I understood this bug to be about certain buttons now being hidden on the 
sources page, which as far as I could tell was happening due to sizing, which 
is what this patch fixes.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26275

To: ahiemstra, #plasma, #discover_software_store, apol
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 72344.
ahiemstra added a comment.


  - Remove unrelated flat change

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26279?vs=72343=72344

BRANCH
  actiontoolbar_contextbutton_visible

REVISION DETAIL
  https://phabricator.kde.org/D26279

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This fixes https://bugs.kde.org/show_bug.cgi?id=415412 , which was occuring 
because the
  overflow button did not properly check to see if the actions in the menu were 
actually
  visible.
  
  BUG: 415412

TEST PLAN
  The example code from the linked bug report now works correctly.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_contextbutton_visible

REVISION DETAIL
  https://phabricator.kde.org/D26279

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26121: Kicker/RecentDocument display file path as decoration

[Méven Car]

meven added a comment.


  In D26121#583212 , @ervin wrote:
  
  > LGTM, might need an update if D26122  
lands though.
  
  
  No need to update here after D26122 , the 
code uses now KFilePlacesModel to replace all places'path by their name rather 
than just ~.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26121

REVISION DETAIL
  https://phabricator.kde.org/D26121

To: meven, #vdg, #plasma, ngraham, ervin, hein
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

[Nathaniel Graham]

ngraham added a comment.


  Hmm, it doesn't seem to fix the issue for me: F7849179: 
Screenshot_20191229_101410.png 
  
  FWIW I've noticed the same phantom overflow menu on the Application page's 
toolbar: F7849182: Screenshot_20191229_101453.png 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26275

To: ahiemstra, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the reviews UI and presentation

[Nathaniel Graham]

ngraham added a comment.


  I'll do the change to show the top positive and top negative reviews on the 
app page in a separate patch once this lands.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Nathaniel Graham]

ngraham updated this revision to Diff 72336.
ngraham added a comment.


  Implement VDG mockups

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25889?vs=72312=72336

BRANCH
  polish-review-reviewing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25889

AFFECTED FILES
  discover/qml/ReviewDelegate.qml
  discover/qml/ReviewsPage.qml

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Kirigami's ListSectionHeader has a default property that points to an 
embedded RowLayout's
  data property, in an attempt (I guess?) to make it simpler to add things to 
it. However,
  this does not work properly, at least not in combination with ActionToolBar. 
So instead,
  override the section header's contentItem so we can specify the right layout 
properties.
  
  BUG: 415666

TEST PLAN
  The sources page now displays actions properly, but still places them in the 
overflow menu
  when the window gets smaller.

REPOSITORY
  R134 Discover Software Store

BRANCH
  sources_actiontoolbar

REVISION DETAIL
  https://phabricator.kde.org/D26275

AFFECTED FILES
  discover/qml/SourcesPage.qml

To: ahiemstra, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Looking at the screenshots, UI wise it's looking good already, only that the 
checkbox seems too big (should be the same size as the radio button, 16px) and 
there's a 5px sized padding after the divider that cuts off part of the 
Internal Microphone button and volume slider earlier than it's supposed to  
F7849101: image.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> davidedmundson wrote in strutmanager.h:25
> what's this about?

This is just for easily testing using the qdbus command.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> strutmanager.h:22
> +public Q_SLOTS:
> +void setAvailableScreenRect(QString service, QString screenName, 
> QRect rect);
> +void setAvailableScreenRegion(QString service, QString screenName, 
> QList rects);

(const QString , const QString , const QRect );

saves some (shallow) copies

> strutmanager.h:25
> +
> +void test(QString service, QString screenName, int x, int y, int 
> width, int height);
> +

what's this about?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi added a comment.


  Ping!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi abandoned this revision.
trmdi added a comment.


  In D26266#584135 , @mvourlakos 
wrote:
  
  > What is ConfigOverlay for plasma panels is using at its tooltip?
  
  
  Ah, I was wrong. "delete" should be the right one. Sorry.
  
https://github.com/KDE/plasma-desktop/blob/def96d60241ad7c835532ee09bf95afb7f56fed7/containments/panel/contents/ui/ConfigOverlay.qml#L408

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26266

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

[David Edmundson]

davidedmundson added a comment.


  Thanks for following up!
  
  > I'll open a Qt bug and see how it goes.
  
  Can you link it please.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  F7848862: Screenshot_20191229_155100.png 

  
  May be tabs would be the solution? (This is mockup)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg
Cc: baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  Looks weird right now.
  From what I can tell, themes add lines between list items.
  There must be some easy way to disable it.
  F7848489: Screenshot_20191229_114632.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

[Noah Davis]

ndavis added a subscriber: hpereiradacosta.
ndavis added a comment.


  Thank you for pointing those out. I don't have a lot of experience, so this 
helps a lot.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26267

To: ndavis, #breeze, #plasma
Cc: hpereiradacosta, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, manueljlin, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Change layout according to T10470  
mockups.
  
  Not included in this patch:
  100% line mark
  Size changes(Margins, fonts)
  Raise maximum volume D26256 
  Mute all icon

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  UI (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, manueljlin, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26270: Fix QFontMetrics::width() deprecation warning by switching to boundingRect().width()

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Breeze, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  According to an article by @cfeck [1], QFontMetrics::width() gave the 
horizontal advance, which doesn't necessarily include every pixel that the text 
might use.
  He suggested that boundingRect().width() might be what most people actually 
want.
  
  - [1] 
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

REPOSITORY
  R31 Breeze

BRANCH
  replace-deprecated-3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26270

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #breeze, #plasma
Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

[Anthony Fieroni]

anthonyfieroni added a comment.


  `auto c = client().toStrongRef().data();`
  This is completely wrong, the idea behind shared / weak pointer is ability to 
know when non-owning resource goes out of scope. by calling toStrongRef you 
extend its lifetime if and only if it exists at time of call then holding this 
ref you ensure that resource will not be destroyed meanwhile. By holding data() 
it does nothing to extend resource lifetime but getting a pointer to well-known 
dying object. It should be
  `auto c = m_decoration.data()->client().toStrongRef();`
  Last but not least, c can be nullptr check against null should be performed 
as well. Exp
  
xcb_window_t windowId;
auto c = m_decoration.data()->client().toStrongRef();
if (c && (windowId = c->windowId())) {
} else {
hide();
}
  
  It should be added checks in all use places.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26267

To: ndavis, #breeze, #plasma
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26268: Fix QTime function deprecation warnings by switching to QElapsedTimer

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Breeze, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The following functions have deprecation warnings: start(), restart(), 
elapsed()
  _clock.isNull() had to be changed to !_clock.isValid() since QElapsedTimer 
does not have isNull().
  QTime::isNull() is also invalid, so behavior shouldn't change.

REPOSITORY
  R31 Breeze

BRANCH
  replace-deprecated-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26268

AFFECTED FILES
  kstyle/animations/breezetransitiondata.h

To: ndavis, #breeze, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Michail Vourlakos]

mvourlakos added a comment.


  What is ConfigOverlay for plasma panels is using at its tooltip?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26266

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi added a comment.


  But I've just found that Plasma panels use QIcon::fromTheme which load the 
icon from the icon theme, while PlasmaComponent.ToolButton loads icon from 
Plasma theme, that is not consistent in some cases. What do you think?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26266

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart