D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Ben Cooksley]

bcooksley added a comment.


  Cancel that, it fails to build on Linux as well - i'm guessing that the 
KNetstuff changes have not been landed?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Ben Cooksley]

bcooksley added a comment.


  This change fails to build from source on FreeBSD due to missing headers in 
Frameworks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 05:50:00 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.idletime.idleTest_kwayland_test

KDE CI: Plasma » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/51/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 05:49:40 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 FreeBSDQt5.13 - Build # 51 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20FreeBSDQt5.13/51/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 05:49:38 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

KDE CI: Plasma » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 86 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/86/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 05:49:39 +
 Build duration:
3 min 50 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.67.0.xmllogs/KF5WindowSystem/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7264/9613)55%
(3527/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3075/3162)52%
(1289/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(820/1374)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3362/4719)60%
(1934/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 SUSEQt5.12 - Build # 84 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20SUSEQt5.12/84/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 05:49:38 +
 Build duration:
3 min 0 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.67.0.xmllogs/KF5WindowSystem/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7270/9613)56%
(3537/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3076/3162)53%
(1291/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(820/1374)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3367/4719)61%
(1942/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 34 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/34/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 05:49:59 +
 Build duration:
2 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.idletime.idleTest_kwayland_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/10)0%
(0/10)0%
(0/764)0%
(0/489)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.idletime0%
(0/1)0%
(0/1)0%
(0/50)0%
(0/48)src.idletime0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/56)src.kmodifierkeyinfoprovider0%
(0/2)0%
(0/2)0%
(0/41)0%
(0/10)src.windowsystem0%
(0/5)0%
(0/5)0%
(0/570)0%
(0/375)

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 664 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/664/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 04:56:54 +
 Build duration:
8 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 2754 lines...][2020-01-16T05:04:05.761Z] Scanning dependencies of target kcm_clock[2020-01-16T05:04:05.761Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/kcm_clock_autogen/mocs_compilation.cpp.o[2020-01-16T05:04:07.683Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T05:04:07.683Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/EWIEGA46WW/moc_dtime.cpp:9,[2020-01-16T05:04:07.683Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/mocs_compilation.cpp:2:[2020-01-16T05:04:07.683Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h: In member function ���void Ui_DateAndTime::setupUi(QWidget*)���:[2020-01-16T05:04:07.683Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:157:47: warning: ���K4TimeZoneWidget::K4TimeZoneWidget(QWidget*, KTimeZones*)��� is deprecated [-Wdeprecated-declarations][2020-01-16T05:04:07.683Z]   157 | tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-16T05:04:07.683Z]   |   ^[2020-01-16T05:04:07.683Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:26,[2020-01-16T05:04:07.683Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T05:04:07.683Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/EWIEGA46WW/moc_dtime.cpp:9,[2020-01-16T05:04:07.683Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/mocs_compilation.cpp:2:[2020-01-16T05:04:07.683Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:41: note: declared here[2020-01-16T05:04:07.683Z]73 | KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-16T05:04:07.683Z]   | ^~~~[2020-01-16T05:04:07.955Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/dtime.cpp.o[2020-01-16T05:04:09.864Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T05:04:09.864Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.cpp:26:[2020-01-16T05:04:09.864Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h: In member function ���void Ui_DateAndTime::setupUi(QWidget*)���:[2020-01-16T05:04:09.864Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:157:47: warning: ���K4TimeZoneWidget::K4TimeZoneWidget(QWidget*, KTimeZones*)��� is deprecated [-Wdeprecated-declarations][2020-01-16T05:04:09.864Z]   157 | tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-16T05:04:09.864Z]   |   ^[2020-01-16T05:04:09.864Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:26,[2020-01-16T05:04:09.864Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T05:04:09.864Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.cpp:26:[2020-01-16T05:04:09.864Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:41: note: declared here[2020-01-16T05:04:09.864Z]73 | KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-16T05:04:09.864Z]   | ^~~~[2020-01-16T05:04:13.177Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/main.cpp.o[2020-01-16T05:04:14.602Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T05:04:14.602Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/main.cpp:37:[2020-01-16T05:04:14.602Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 395 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/395/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 02:25:24 +
 Build duration:
3 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 4040 lines...][2020-01-16T02:28:19.198Z] Scanning dependencies of target ksmserver_autogen[2020-01-16T02:28:19.198Z] [ 93%] Automatic MOC for target ksmserver[2020-01-16T02:28:19.198Z] [ 93%] Built target ksmserver_autogen[2020-01-16T02:28:19.198Z] Scanning dependencies of target kcminit_autogen[2020-01-16T02:28:19.198Z] [ 93%] Automatic MOC for target kcminit[2020-01-16T02:28:19.198Z] [ 93%] Built target kcminit_autogen[2020-01-16T02:28:19.198Z] Scanning dependencies of target kcminit_startup_autogen[2020-01-16T02:28:19.198Z] [ 93%] Automatic MOC for target kcminit_startup[2020-01-16T02:28:19.198Z] [ 93%] Built target kickerplugin[2020-01-16T02:28:19.198Z] [ 93%] Linking CXX shared module ../../bin/colorcorrectlocationupdater.so[2020-01-16T02:28:19.198Z] [ 93%] Built target kcminit_startup_autogen[2020-01-16T02:28:19.456Z] Scanning dependencies of target testChromeBookmarks[2020-01-16T02:28:19.456Z] [ 93%] Building CXX object runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testChromeBookmarks_autogen/mocs_compilation.cpp.o[2020-01-16T02:28:19.456Z] [ 93%] Built target colorcorrectlocationupdater[2020-01-16T02:28:19.456Z] Scanning dependencies of target servicerunnertest[2020-01-16T02:28:19.456Z] [ 93%] Building CXX object runners/services/autotests/CMakeFiles/servicerunnertest.dir/servicerunnertest_autogen/mocs_compilation.cpp.o[2020-01-16T02:28:19.456Z] [ 93%] Building CXX object runners/services/autotests/CMakeFiles/servicerunnertest.dir/servicerunnertest.cpp.o[2020-01-16T02:28:19.456Z] Scanning dependencies of target krunner_kill[2020-01-16T02:28:19.456Z] [ 93%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/screensaver_interface.cpp.o[2020-01-16T02:28:19.456Z] [ 93%] Building CXX object runners/kill/CMakeFiles/krunner_kill.dir/krunner_kill_autogen/mocs_compilation.cpp.o[2020-01-16T02:28:19.720Z] Scanning dependencies of target plasmashell[2020-01-16T02:28:19.720Z] [ 93%] Building CXX object shell/CMakeFiles/plasmashell.dir/plasmashell_autogen/mocs_compilation.cpp.o[2020-01-16T02:28:19.720Z] [ 93%] Building CXX object shell/CMakeFiles/plasmashell.dir/alternativeshelper.cpp.o[2020-01-16T02:28:20.296Z] [ 93%] Building CXX object runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testchromebookmarks.cpp.o[2020-01-16T02:28:20.296Z] Scanning dependencies of target plasma_engine_weather[2020-01-16T02:28:20.296Z] [ 93%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/plasma_engine_weather_autogen/mocs_compilation.cpp.o[2020-01-16T02:28:20.556Z] [ 93%] Linking CXX executable ../../bin/nightcolortest[2020-01-16T02:28:20.556Z] [ 93%] Built target nightcolortest[2020-01-16T02:28:20.556Z] [ 93%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/weatherengine.cpp.o[2020-01-16T02:28:21.118Z] [ 93%] Building CXX object runners/kill/CMakeFiles/krunner_kill.dir/killrunner.cpp.o[2020-01-16T02:28:21.118Z] [ 94%] Linking CXX executable ../../../bin/servicerunnertest[2020-01-16T02:28:21.118Z] [ 94%] Built target servicerunnertest[2020-01-16T02:28:21.118Z] [ 94%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o[2020-01-16T02:28:21.375Z] Scanning dependencies of target ion_bbcukmet[2020-01-16T02:28:21.375Z] [ 94%] Building CXX object dataengines/weather/ions/bbcukmet/CMakeFiles/ion_bbcukmet.dir/ion_bbcukmet_autogen/mocs_compilation.cpp.o[2020-01-16T02:28:21.375Z] [ 94%] Building CXX object dataengines/weather/ions/bbcukmet/CMakeFiles/ion_bbcukmet.dir/ion_bbcukmet.cpp.o[2020-01-16T02:28:21.375Z] [ 94%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/weatherenginedebug.cpp.o[2020-01-16T02:28:21.375Z] [ 94%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/kscreensaversettings.cpp.o[2020-01-16T02:28:21.375Z] [ 95%] Linking CXX executable ../../../bin/testChromeBookmarks[2020-01-16T02:28:21.638Z] [ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o[2020-01-16T02:28:21.638Z] [ 95%] Built target testChromeBookmarks[2020-01-16T02:28:21.638Z] Scanning dependencies of target ion_envcan[2020-01-16T02:28:21.638Z] [ 95%] Building CXX object dataengines/weather/ions/envcan/CMakeFiles/ion_envcan.dir/ion_envcan_autogen/mocs_compilation.cpp.o[2020-01-16T02:28:21.895Z] Scanning dependencies of target ion_noaa[2020-01-16T02:28:21.895Z] [ 95%] Building CXX object dataengines/weather/ions/noaa/CMakeFiles/ion_noaa.dir/ion_noaa_autogen/mocs_compilation.cpp.o[2020-01-16T02:28:22.150Z] [ 95%] Linking CXX shared module ../../bin/plasma_engine_weather.so[2020-01-16T02:28:22.150Z] [ 95%] Built target 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 394 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/394/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 01:36:54 +
 Build duration:
3 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 4028 lines...][2020-01-16T01:40:02.913Z] ^[2020-01-16T01:40:02.913Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:1: note: 'requestSleep' has been explicitly marked deprecated here[2020-01-16T01:40:02.913Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2020-01-16T01:40:02.913Z] ^[2020-01-16T01:40:02.913Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-01-16T01:40:02.913Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-01-16T01:40:02.913Z]^[2020-01-16T01:40:02.913Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-01-16T01:40:02.913Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-01-16T01:40:02.913Z]  ^[2020-01-16T01:40:02.913Z] [ 93%] Built target plasma_engine_statusnotifieritem[2020-01-16T01:40:02.913Z] Scanning dependencies of target klipper[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object klipper/CMakeFiles/klipper.dir/klipper_autogen/mocs_compilation.cpp.o[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object klipper/CMakeFiles/klipper.dir/klipper_dummy.cpp.o[2020-01-16T01:40:02.913Z] [ 93%] Linking CXX executable ../bin/klipper[2020-01-16T01:40:02.913Z] [ 93%] Built target klipper[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/debug.cpp.o[2020-01-16T01:40:02.913Z] Scanning dependencies of target ksmserver_autogen[2020-01-16T01:40:02.913Z] [ 93%] Automatic MOC for target ksmserver[2020-01-16T01:40:02.913Z] 4 warnings generated.[2020-01-16T01:40:02.913Z] [ 93%] Built target ksmserver_autogen[2020-01-16T01:40:02.913Z] Scanning dependencies of target kcminit_autogen[2020-01-16T01:40:02.913Z] [ 93%] Automatic MOC for target kcminit[2020-01-16T01:40:02.913Z] Scanning dependencies of target kcminit_startup_autogen[2020-01-16T01:40:02.913Z] [ 93%] Automatic MOC for target kcminit_startup[2020-01-16T01:40:02.913Z] [ 93%] Built target kcminit_autogen[2020-01-16T01:40:02.913Z] [ 93%] Built target kcminit_startup_autogen[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object shell/CMakeFiles/plasmashell.dir/alternativeshelper.cpp.o[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/krunner_interface.cpp.o[2020-01-16T01:40:02.913Z] Scanning dependencies of target testChromeBookmarks[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testChromeBookmarks_autogen/mocs_compilation.cpp.o[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testchromebookmarks.cpp.o[2020-01-16T01:40:02.913Z] [ 93%] Linking CXX shared library ../../bin/libsessionsprivateplugin.so[2020-01-16T01:40:02.913Z] [ 93%] Built target sessionsprivateplugin[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/ksmserver_interface.cpp.o[2020-01-16T01:40:02.913Z] Scanning dependencies of target servicerunnertest[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object runners/services/autotests/CMakeFiles/servicerunnertest.dir/servicerunnertest_autogen/mocs_compilation.cpp.o[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object runners/services/autotests/CMakeFiles/servicerunnertest.dir/servicerunnertest.cpp.o[2020-01-16T01:40:02.913Z] [ 93%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o[2020-01-16T01:40:03.489Z] [ 93%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o[2020-01-16T01:40:03.489Z] Scanning dependencies of target krunner_kill[2020-01-16T01:40:03.489Z] [ 93%] Building CXX object runners/kill/CMakeFiles/krunner_kill.dir/krunner_kill_autogen/mocs_compilation.cpp.o[2020-01-16T01:40:03.746Z] [ 93%] Building CXX object shell/CMakeFiles/plasmashell.dir/currentcontainmentactionsmodel.cpp.o[2020-01-16T01:40:04.012Z] [ 93%] Building CXX object shell/CMakeFiles/plasmashell.dir/desktopview.cpp.o[2020-01-16T01:40:04.285Z] [ 94%] Linking CXX executable ../../../bin/testChromeBookmarks[2020-01-16T01:40:04.285Z] [ 94%] Built target testChromeBookmarks[2020-01-16T01:40:04.556Z] Scanning dependencies of target plasma_engine_weather[2020-01-16T01:40:04.556Z] [ 94%] Building CXX object 

D26681: [TabBox] Thumbnail Grid window switcher

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:59cd237a7146: [TabBox] Add Thumbnail Grid window switcher 
(authored by Zren).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26681?vs=73648=73675

REVISION DETAIL
  https://phabricator.kde.org/D26681

AFFECTED FILES
  windowswitchers/CMakeLists.txt
  windowswitchers/thumbnail_grid/contents/ui/main.qml
  windowswitchers/thumbnail_grid/metadata.desktop

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 393 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/393/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 00:36:23 +
 Build duration:
3 min 51 sec and counting
   CONSOLE OUTPUT
  [...truncated 3999 lines...][2020-01-16T00:39:44.211Z] [ 92%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/debug.cpp.o[2020-01-16T00:39:44.497Z] [ 92%] Building CXX object krunner/CMakeFiles/krunner.dir/main.cpp.o[2020-01-16T00:39:44.497Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:96:47: warning: 'supportedSleepStates' is deprecated [-Wdeprecated-declarations][2020-01-16T00:39:44.497Z] m_valid = Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::SuspendState);[2020-01-16T00:39:44.497Z]   ^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:1: note: 'supportedSleepStates' has been explicitly marked deprecated here[2020-01-16T00:39:44.497Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();[2020-01-16T00:39:44.497Z] ^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-01-16T00:39:44.497Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-01-16T00:39:44.497Z]^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-01-16T00:39:44.497Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-01-16T00:39:44.497Z]  ^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:99:47: warning: 'supportedSleepStates' is deprecated [-Wdeprecated-declarations][2020-01-16T00:39:44.497Z] m_valid = Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::HibernateState);[2020-01-16T00:39:44.497Z]   ^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:1: note: 'supportedSleepStates' has been explicitly marked deprecated here[2020-01-16T00:39:44.497Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();[2020-01-16T00:39:44.497Z] ^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-01-16T00:39:44.497Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-01-16T00:39:44.497Z]^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-01-16T00:39:44.497Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-01-16T00:39:44.497Z]  ^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:334:37: warning: 'requestSleep' is deprecated [-Wdeprecated-declarations][2020-01-16T00:39:44.497Z] Solid::PowerManagement::requestSleep(Solid::PowerManagement::SuspendState, nullptr, nullptr);[2020-01-16T00:39:44.497Z] ^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:1: note: 'requestSleep' has been explicitly marked deprecated here[2020-01-16T00:39:44.497Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2020-01-16T00:39:44.497Z] ^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-01-16T00:39:44.497Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-01-16T00:39:44.497Z]^[2020-01-16T00:39:44.497Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-01-16T00:39:44.497Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 392 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/392/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 00:30:39 +
 Build duration:
5 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 4021 lines...][2020-01-16T00:34:49.386Z] [ 92%] Building CXX object dataengines/weather/ions/bbcukmet/CMakeFiles/ion_bbcukmet.dir/ion_bbcukmet_autogen/mocs_compilation.cpp.o[2020-01-16T00:34:49.642Z] Scanning dependencies of target ion_envcan[2020-01-16T00:34:49.642Z] [ 92%] Building CXX object dataengines/weather/ions/envcan/CMakeFiles/ion_envcan.dir/ion_envcan_autogen/mocs_compilation.cpp.o[2020-01-16T00:34:49.897Z] Scanning dependencies of target ion_noaa[2020-01-16T00:34:49.897Z] [ 92%] Building CXX object dataengines/weather/ions/noaa/CMakeFiles/ion_noaa.dir/ion_noaa_autogen/mocs_compilation.cpp.o[2020-01-16T00:34:49.897Z] [ 92%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/recentusagemodel.cpp.o[2020-01-16T00:34:50.153Z] [ 93%] Linking CXX executable ../../../bin/servicerunnertest[2020-01-16T00:34:50.415Z] [ 93%] Built target servicerunnertest[2020-01-16T00:34:50.415Z] [ 93%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/submenu.cpp.o[2020-01-16T00:34:50.415Z] [ 93%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/weatherengine.cpp.o[2020-01-16T00:34:50.415Z] [ 93%] Building CXX object runners/kill/CMakeFiles/krunner_kill.dir/killrunner.cpp.o[2020-01-16T00:34:50.415Z] [ 93%] Building CXX object dataengines/weather/ions/bbcukmet/CMakeFiles/ion_bbcukmet.dir/ion_bbcukmet.cpp.o[2020-01-16T00:34:50.670Z] [ 94%] Linking CXX executable ../../../bin/testChromeBookmarks[2020-01-16T00:34:50.670Z] [ 95%] Building CXX object dataengines/weather/ions/envcan/CMakeFiles/ion_envcan.dir/ion_envcan.cpp.o[2020-01-16T00:34:50.670Z] gmake[1]: *** [CMakeFiles/Makefile2:4803: shell/CMakeFiles/plasmashell.dir/all] Error 2[2020-01-16T00:34:50.670Z] gmake[1]: *** Waiting for unfinished jobs[2020-01-16T00:34:50.670Z] [ 95%] Building CXX object dataengines/weather/ions/bbcukmet/CMakeFiles/ion_bbcukmet.dir/ion_bbcukmetdebug.cpp.o[2020-01-16T00:34:50.670Z] [ 95%] Built target testChromeBookmarks[2020-01-16T00:34:50.670Z] [ 95%] Building CXX object dataengines/weather/ions/envcan/CMakeFiles/ion_envcan.dir/ion_envcandebug.cpp.o[2020-01-16T00:34:50.926Z] [ 95%] Building CXX object dataengines/weather/ions/noaa/CMakeFiles/ion_noaa.dir/ion_noaa.cpp.o[2020-01-16T00:34:51.488Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systementry.cpp.o[2020-01-16T00:34:51.488Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systemmodel.cpp.o[2020-01-16T00:34:51.488Z] [ 96%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/weatherenginedebug.cpp.o[2020-01-16T00:34:51.488Z] [ 96%] Building CXX object dataengines/weather/ions/noaa/CMakeFiles/ion_noaa.dir/ion_noaadebug.cpp.o[2020-01-16T00:34:51.743Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systemsettings.cpp.o[2020-01-16T00:34:52.003Z] [ 96%] Linking CXX shared module ../../bin/krunner_kill.so[2020-01-16T00:34:52.259Z] [ 96%] Built target krunner_kill[2020-01-16T00:34:52.259Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/wheelinterceptor.cpp.o[2020-01-16T00:34:52.515Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/windowsystem.cpp.o[2020-01-16T00:34:52.515Z] [ 96%] Linking CXX shared module ../../../../bin/ion_bbcukmet.so[2020-01-16T00:34:52.515Z] [ 96%] Linking CXX shared module ../../bin/plasma_engine_weather.so[2020-01-16T00:34:52.515Z] [ 96%] Built target ion_bbcukmet[2020-01-16T00:34:52.515Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/debug.cpp.o[2020-01-16T00:34:52.515Z] [ 96%] Linking CXX shared module ../../../../bin/ion_noaa.so[2020-01-16T00:34:52.515Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/krunner_interface.cpp.o[2020-01-16T00:34:52.515Z] [ 96%] Built target plasma_engine_weather[2020-01-16T00:34:52.515Z] [ 96%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/ksmserver_interface.cpp.o[2020-01-16T00:34:52.515Z] [ 96%] Built target ion_noaa[2020-01-16T00:34:52.770Z] [ 96%] Linking CXX shared module ../../../../bin/ion_envcan.so[2020-01-16T00:34:53.026Z] [ 96%] Built target ion_envcan[2020-01-16T00:34:53.281Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:96:47: warning: 'supportedSleepStates' is deprecated [-Wdeprecated-declarations][2020-01-16T00:34:53.281Z] m_valid = Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::SuspendState);[2020-01-16T00:34:53.281Z]   ^[2020-01-16T00:34:53.281Z] 

D26570: Improve Plasma user feedback introspection

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:35dcbd3dd89c: Improve Plasma user feedback introspection 
(authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26570?vs=73641=73674

REVISION DETAIL
  https://phabricator.kde.org/D26570

AFFECTED FILES
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/package/contents/ui/main.qml
  shell/main.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

To: apol, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Roman Gilg]

romangg accepted this revision.
romangg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> Zren wrote in main.qml:183
> Uhg, I was using `width: parent.height` and `height: parent.height` but 
> changed it when cleaning it up. I must've not staged all the changes before 
> diffing. This has made me notice another bug though.
> 
> By using `height: parent.height`, I was basically setting it at `height: 22`, 
> which is smaller than the "close button" which is 30x30.
> 
>   width: parent.height
>   height: parent.height
> 
> F7884740: 2020-01-15___12-05-59.png 
> 
>   Layout.fillHeight: true
>   Layout.minimumWidth: height
>   Layout.maximumWidth: Layout.minimumWidth
> 
> This makes the icon slightly larger than I'm used to.
> F7884741: 2020-01-15___12-04-32.png 
> 
> I've also noticed why I added `clip: true` to the `KWin.ThumbnailItem`, 
> apparently the close button is 30x30, which is taller than the 
> `captionRow.height: 22`. Here's a look at the overflow after removing `clip: 
> true` and `clipTo: parent`:
> Outlines with: `Rectangle { anchors.fill: parent; border.color: "#f00"; 
> border.width: 1; color: "transparent" }`
> F7884784: 2020-01-15___12-31-12.png 
> 
> I've fixed it all in the latest diff:
> F7884833: 2020-01-15___12-38-31.png 
> F7884834: 2020-01-15___12-55-01.png 

Yea, just tested it again and looks good!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26698: [widgetexplorer] Fix animate in animation

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh never mind, I see it now. Quite subtle! Nice fix.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26698

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26699: [widgetexplorer] Animate column moves

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much nicer.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26699

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26698: [widgetexplorer] Fix animate in animation

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I don't notice a difference before and after this patch. Maybe I'm not 
noticing the original problem

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26698

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham added a comment.


  I don't know of any netbooks shorter with screens shorter than 600px, which 
is why I chose 600. Also, the window is resizable to be smaller.
  
  Is there a better way?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26699: [widgetexplorer] Animate column moves

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Search for something in the second column
  Now it doesn't jump

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26699

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[David Edmundson]

davidedmundson added a comment.


  Ok, but why minimum? 
  We still have a few reports of people on weird tiny netbooks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26698: [widgetexplorer] Fix animate in animation

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The animation in comes in from offscreen on the left.
  
  "to: 0" was correct when we had one column. With the 2 column view it
  means we animate two items on top of each other and jump when the
  animation completes. We want to animate to the final position the item
  will end up in.
  
  It bugs me more than it probably should.

TEST PLAN
  Search for "asdfasdfsadfsadf"
  Remove search
  Animation now looks ok, instead of horrific

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26698

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Noah Davis]

ndavis added a comment.


  I noticed that when hovering on the scrollbar border, while the view area is 
not focused, the scrollbar handle is light gray (Breeze Dark, dark gray for 
Breeze) instead of blue. Moving the mouse just slightly more to the right turns 
the scrollbar handle blue.
  F7884963: Screenshot_20200115_152752.PNG 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R130:3a6508dd350b: [windowsystem] Fix compilation with 
no-deprecated build of KWindowSystem (authored by zzag).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26643?vs=73468=73658

REVISION DETAIL
  https://phabricator.kde.org/D26643

AFFECTED FILES
  src/windowsystem/windoweffects.cpp
  src/windowsystem/windoweffects.h

To: zzag, #kwin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 377653
  FIXED-IN: 5.18.0

TEST PLAN
  Before: F7884930: Before.png 
  After: F7884929: After.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  standardshortcuts-minimum-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26631: [kstyle] Update blur region even if Breeze has no X11 support

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:e1710bd6808b: [kstyle] Update blur region even if Breeze 
has no X11 support (authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26631?vs=73430=73656

REVISION DETAIL
  https://phabricator.kde.org/D26631

AFFECTED FILES
  kstyle/breezeblurhelper.cpp
  kstyle/breezeblurhelper.h

To: zzag, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Noah Davis]

ndavis added a comment.


  In D26655#595033 , @mart wrote:
  
  > moving the points half a pixel in renderArrow seems to fix it, but it may 
have sideeffects for arrows used in other places..
  
  
  Indeed, it would. I already made the arrows pixel aligned under normal 
circumstances, so the alignment fix needs to happen somewhere else.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Chris Holland]

Zren updated this revision to Diff 73648.
Zren edited the summary of this revision.
Zren added a comment.


  Fix implicitWidth error by using Layout.min/maxWidth.
  Scale captionRow.spacing by dpi.
  Take into account the close button is 30x30.
  Use a ColumnLayout for thumbnailGridItems instead of anchoring.
  Add Item container for KWin.ThumbnailItem so it's not cliping the bottom of 
the window thumbnail.
  Remove "keybindings don't work" comment that no longer applies.
  Use `const` for function variables.
  644 (RW-R--R--) file permission.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26681?vs=73590=73648

REVISION DETAIL
  https://phabricator.kde.org/D26681

AFFECTED FILES
  windowswitchers/CMakeLists.txt
  windowswitchers/thumbnail_grid/contents/ui/main.qml
  windowswitchers/thumbnail_grid/metadata.desktop

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 15 Jan 2020 19:02:45 +
 Build duration:
18 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on FreeBSD Builder 1 in /usr/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2020-01-15T19:03:02.791Z] No credentials specified[2020-01-15T19:03:02.797Z] Cloning the remote Git repository[2020-01-15T19:03:02.879Z] ERROR: Error cloning remote repo 'origin'[2020-01-15T19:03:02.879Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwayland-integration +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:03:02.879Z] stdout: [2020-01-15T19:03:02.879Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:03:02.879Z] [2020-01-15T19:03:02.879Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:03:02.879Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:03:02.879Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:03:02.879Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:03:02.879Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:787)[2020-01-15T19:03:02.879Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:03:02.879Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:03:02.879Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:03:02.879Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:03:02.879Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:03:02.879Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:03:02.879Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:03:02.879Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:03:02.879Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:03:02.879Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:03:02.879Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 1[2020-01-15T19:03:02.879Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:03:02.879Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:03:02.879Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:03:02.879Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:03:02.879Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:03:02.879Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2020-01-15T19:03:02.879Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2020-01-15T19:03:02.879Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2020-01-15T19:03:02.879Z] 		at com.sun.proxy.$Proxy81.execute(Unknown Source)[2020-01-15T19:03:02.879Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)[2020-01-15T19:03:02.879Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:03:02.879Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:03:02.879Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:03:02.879Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:03:02.879Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:03:02.879Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:03:02.879Z] 		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }[2020-01-15T18:18:58.347Z] Cloning repository git://anongit.kde.org/kwayland-integration[2020-01-15T18:18:58.347Z]  > git init /usr/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 FreeBSDQt5.13 # 

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 SUSEQt5.12 - Build # 83 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20SUSEQt5.12/83/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 15 Jan 2020 19:02:19 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on Docker Swarm-0fa3c80ee7b1 in /home/jenkins/workspace/Plasma/kwindowsystem/stable-kf5-qt5 SUSEQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2020-01-15T19:02:38.336Z] No credentials specified[2020-01-15T19:02:38.338Z] Cloning the remote Git repository[2020-01-15T19:02:38.348Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:38.370Z]  > git init /home/jenkins/workspace/Plasma/kwindowsystem/stable-kf5-qt5 SUSEQt5.12 # timeout=10[2020-01-15T19:02:38.384Z] Fetching upstream changes from git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:38.385Z]  > git --version # timeout=10[2020-01-15T19:02:38.387Z]  > git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-15T19:03:07.787Z] ERROR: Error fetching remote repo 'origin'[2020-01-15T19:03:07.787Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kwindowsystem[2020-01-15T19:03:07.787Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-15T19:03:07.787Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-15T19:03:07.787Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:03:07.787Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:03:07.787Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:03:07.787Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:03:07.787Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:03:07.787Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:03:07.787Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:03:07.787Z] stdout: [2020-01-15T19:03:07.787Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:03:07.787Z] [2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:03:07.787Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:03:07.787Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:03:07.787Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:03:07.787Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:03:07.787Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:03:07.787Z] 	... 4 more[2020-01-15T19:03:07.787Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-0fa3c80ee7b1[2020-01-15T19:03:07.787Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:03:07.787Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:03:07.787Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:03:07.787Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:03:07.787Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:03:07.787Z] 		at 

KDE CI: Plasma » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 85 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/85/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 15 Jan 2020 19:02:17 +
 Build duration:
51 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskAll nodes of label ‘SUSEQt5.12’ are offlineRunning on Docker Swarm-d79fcbcdaf2a in /home/jenkins/workspace/Plasma/kwindowsystem/kf5-qt5 SUSEQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2020-01-15T19:02:38.433Z] No credentials specified[2020-01-15T19:02:38.435Z] Cloning the remote Git repository[2020-01-15T19:02:38.445Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:38.468Z]  > git init /home/jenkins/workspace/Plasma/kwindowsystem/kf5-qt5 SUSEQt5.12 # timeout=10[2020-01-15T19:02:38.508Z] Fetching upstream changes from git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:38.509Z]  > git --version # timeout=10[2020-01-15T19:02:38.521Z]  > git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-15T19:03:07.819Z] ERROR: Error fetching remote repo 'origin'[2020-01-15T19:03:07.819Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kwindowsystem[2020-01-15T19:03:07.819Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-15T19:03:07.819Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-15T19:03:07.819Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:03:07.819Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:03:07.819Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:03:07.819Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:03:07.819Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:03:07.819Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:03:07.819Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:03:07.819Z] stdout: [2020-01-15T19:03:07.819Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:03:07.819Z] [2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:03:07.819Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:03:07.819Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:03:07.819Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:03:07.819Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:03:07.819Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:03:07.819Z] 	... 4 more[2020-01-15T19:03:07.819Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-d79fcbcdaf2a[2020-01-15T19:03:07.819Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:03:07.819Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:03:07.819Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:03:07.819Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:03:07.819Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:03:07.819Z] 		at 

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 FreeBSDQt5.13 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20FreeBSDQt5.13/50/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 15 Jan 2020 19:02:19 +
 Build duration:
37 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on FreeBSD Builder 1 in /usr/home/jenkins/workspace/Plasma/kwindowsystem/stable-kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2020-01-15T19:02:23.430Z] No credentials specified[2020-01-15T19:02:23.434Z] Cloning the remote Git repository[2020-01-15T18:18:18.979Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-15T18:18:18.980Z]  > git init /usr/home/jenkins/workspace/Plasma/kwindowsystem/stable-kf5-qt5 FreeBSDQt5.13 # timeout=10[2020-01-15T18:18:18.988Z] Fetching upstream changes from git://anongit.kde.org/kwindowsystem[2020-01-15T18:18:18.988Z]  > git --version # timeout=10[2020-01-15T18:18:18.991Z]  > git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-15T19:02:54.395Z] ERROR: Error fetching remote repo 'origin'[2020-01-15T19:02:54.395Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:54.395Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-15T19:02:54.395Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-15T19:02:54.395Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:02:54.395Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:02:54.395Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:02:54.395Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:02:54.395Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:02:54.395Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:02:54.395Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:02:54.395Z] stdout: [2020-01-15T19:02:54.395Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:02:54.395Z] [2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:02:54.395Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:02:54.395Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:02:54.395Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:02:54.395Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:02:54.395Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:02:54.395Z] 	... 4 more[2020-01-15T19:02:54.395Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 1[2020-01-15T19:02:54.395Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:02:54.395Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:02:54.395Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:02:54.395Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:02:54.395Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:02:54.395Z] 		at 

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 33 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/33/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 15 Jan 2020 19:02:45 +
 Build duration:
25 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘SUSEQt5.12’Running on Docker Swarm-aa25420de7fe in /home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 SUSEQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2020-01-15T19:03:08.856Z] No credentials specified[2020-01-15T19:03:08.858Z] Cloning the remote Git repository[2020-01-15T19:03:08.980Z] ERROR: Error cloning remote repo 'origin'[2020-01-15T19:03:08.980Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwayland-integration +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:03:08.980Z] stdout: [2020-01-15T19:03:08.980Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:03:08.980Z] [2020-01-15T19:03:08.980Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:03:08.980Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:03:08.980Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:03:08.980Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:03:08.980Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:787)[2020-01-15T19:03:08.980Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:03:08.980Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:03:08.980Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:03:08.980Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:03:08.980Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:03:08.980Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:03:08.981Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:03:08.981Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:03:08.981Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:03:08.981Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:03:08.981Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-aa25420de7fe[2020-01-15T19:03:08.981Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:03:08.981Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:03:08.981Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:03:08.981Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:03:08.981Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:03:08.981Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2020-01-15T19:03:08.981Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2020-01-15T19:03:08.981Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2020-01-15T19:03:08.981Z] 		at com.sun.proxy.$Proxy81.execute(Unknown Source)[2020-01-15T19:03:08.981Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)[2020-01-15T19:03:08.981Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:03:08.981Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:03:08.981Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:03:08.981Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:03:08.981Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:03:08.981Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:03:08.981Z] 		... 4 more[2020-01-15T19:03:08.874Z] Cloning repository git://anongit.kde.org/kwayland-integration[2020-01-15T19:03:08.902Z]  > git init /home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 SUSEQt5.12 # 

KDE CI: Plasma » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/50/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 15 Jan 2020 19:02:19 +
 Build duration:
44 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.13’Running on FreeBSD Builder 2 in /usr/home/jenkins/workspace/Plasma/kwindowsystem/kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2020-01-15T19:03:02.520Z] No credentials specified[2020-01-15T19:03:02.526Z] Cloning the remote Git repository[2020-01-15T19:03:02.609Z] ERROR: Error cloning remote repo 'origin'[2020-01-15T19:03:02.609Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:03:02.609Z] stdout: [2020-01-15T19:03:02.609Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:03:02.609Z] [2020-01-15T19:03:02.609Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:03:02.609Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:03:02.609Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:03:02.609Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:03:02.609Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:787)[2020-01-15T19:03:02.609Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:03:02.609Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:03:02.609Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:03:02.609Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:03:02.609Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:03:02.609Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:03:02.609Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:03:02.609Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:03:02.609Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:03:02.609Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:03:02.609Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 2[2020-01-15T19:03:02.609Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:03:02.609Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:03:02.609Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:03:02.609Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:03:02.609Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:03:02.609Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2020-01-15T19:03:02.609Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2020-01-15T19:03:02.609Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2020-01-15T19:03:02.609Z] 		at com.sun.proxy.$Proxy81.execute(Unknown Source)[2020-01-15T19:03:02.609Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)[2020-01-15T19:03:02.609Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:03:02.609Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:03:02.609Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:03:02.609Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:03:02.610Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:03:02.610Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:03:02.610Z] 		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }[2020-01-15T18:53:02.131Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-15T18:53:02.131Z]  > git init 

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart added a comment.


  In D26655#595022 , 
@hpereiradacosta wrote:
  
  > Confirmed that the centering is fixed. Now the arrow seem to have moved 
vertically (for vertical scrollbars) by half a pixel, which is probably a 
consequence of the 20->21, and make them look somewhat thicker due to 
antialiasing. It is a minor detail, so feel free to ignore.
  >  Other than that, no more comments !
  
  
  moving the points half a pixel in renderArrow seems to fix it, but it may 
have sideeffects for arrows used in other places..

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26688: WIP: [Night Color] Display time when the next transition will start

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in main.qml:57
> The bigger todo is hardcoded 6500K ?

6500K is the neutral screen color temperature. Although I don't think that I 
follow you. Do you recommend not to hardcode this constant?

> ngraham wrote in main.qml:59
> This is a comma splice. Change to:
> 
> Night Color is not active. The next transition...
> 
> or
> 
> Night Color is not active; the next transition...
> 
> or
> 
> Night Color is not active, but the next transition...

Thank you very much for suggesting correct messages. As a VDG person, do you 
have tips how to better inform the user that Night Color currently doesn't have 
any effect and it will activate a bit later? Given tight time budget, I don't 
target 5.18 so no rush. Although it would be great to get this little feature 
in the next release.

Also, what time format should we use? The current one is way too informative if 
you ask me.

I'm pretty happy about the backend side, but the frontend obviously still needs 
some work... :(

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26688

To: zzag, #plasma, #vdg
Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:df1340617147: show a thin separator between view and 
scrollbar (authored by mart).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26655?vs=73642=73646

REVISION DETAIL
  https://phabricator.kde.org/D26655

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:183
> you can use Layout.preferredWidth
> 
> One shouldn't specifiy a width/height from an item inside a layout

Uhg, I was using `width: parent.height` and `height: parent.height` but changed 
it when cleaning it up. I must've not staged all the changes before diffing. 
This has made me notice another bug though.

By using `height: parent.height`, I was basically setting it at `height: 22`, 
which is smaller than the "close button" which is 30x30.

  width: parent.height
  height: parent.height

F7884740: 2020-01-15___12-05-59.png 

  Layout.fillHeight: true
  Layout.minimumWidth: height
  Layout.maximumWidth: Layout.minimumWidth

This makes the icon slightly larger than I'm used to.
F7884741: 2020-01-15___12-04-32.png 

I've also noticed why I added `clip: true` to the `KWin.ThumbnailItem`, 
apparently the close button is 30x30, which is taller than the 
`captionRow.height: 22`. Here's a look at the overflow after removing `clip: 
true` and `clipTo: parent`:
Outlines with: `Rectangle { anchors.fill: parent; border.color: "#f00"; 
border.width: 1; color: "transparent" }`
F7884784: 2020-01-15___12-31-12.png 

I've fixed it all in the latest diff:
F7884833: 2020-01-15___12-38-31.png 
F7884834: 2020-01-15___12-55-01.png 

> davidedmundson wrote in main.qml:231
> GridView has it's own input handling you shouldn't need this anyway.
> 
> If keyboard doesn't work, chances are your activeFocus is incorrect.
> 
> I can only see focus: true on
> 
>   id: dialogMainItem
> 
> it should be on the gridview instead

Arrow keys work. Sorry, forgot to this comment.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.


  Confirmed that the centering is fixed. Now the arrow seem to have moved 
vertically (for vertical scrollbars) by half a pixel, which is probably a 
consequence of the 20->21, and make them look somewhat thicker due to 
antialiasing. It is a minor detail, so feel free to ignore.
  Other than that, no more comments !

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D26655

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26609: [kstyle] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag marked an inline comment as done.
zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in oxygenshadowhelper.cpp:291
> I don't understand what this line is trying to do

I presume that it acted as a sub-surface test, in either case we don't need it.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D26609

To: zzag, #kwin, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26609: [kstyle] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 73644.
zzag added a comment.


  - Drop sub-surface check
  - Don't use obsolete QWidget::isTopLevel()

REPOSITORY
  R113 Oxygen Theme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26609?vs=73351=73644

REVISION DETAIL
  https://phabricator.kde.org/D26609

AFFECTED FILES
  kstyle/oxygenshadowhelper.cpp
  kstyle/oxygenshadowhelper.h

To: zzag, #kwin, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26475: [kstyle] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 73643.
zzag added a comment.


  - Drop sub-surface test
  - Don't use obsolete QWidget::isTopLevel()

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26475?vs=73349=73643

REVISION DETAIL
  https://phabricator.kde.org/D26475

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #kwin, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart added a comment.


  now everything is centered.
  for some reasons (i didn't fully understand that) the option->rect of 
scrollBarInternalSubControlRect was influenced by the previous calls of it, if 
i just substract.
  now using absolute values for the rect, it always returns the proper value 
and everyuthing is centerd

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D26655

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart updated this revision to Diff 73642.
mart added a comment.


  - fix arrows too

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26655?vs=73639=73642

BRANCH
  arcpatch-D26655

REVISION DETAIL
  https://phabricator.kde.org/D26655

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26570: Improve Plasma user feedback introspection

[Nathaniel Graham]

ngraham added a comment.


  Very nice. It occurs to me that by showing the full list of what gets sent, 
we no longer need to show the details text. It's rendered obsolete by showing 
the actual list of what gets sent. Can we remove the description from the KCM 
here without touching KUSerFeedback again?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26570

To: apol, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26570: Improve Plasma user feedback introspection

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in feedback.cpp:41
> where do you use this?

It's used by `std::sort(m_feedbackSources.begin(), m_feedbackSources.end()...`

> davidedmundson wrote in feedback.cpp:109
> This doesn't look right.
> 
> With 2 async processes, the second one to come in will replace the first?

No, we're using m_uses, because we need the proper integration. That's why we 
keep both.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26570

To: apol, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26570: Improve Plasma user feedback introspection

[David Edmundson]

davidedmundson added a comment.


  Quite a clever solution. I like the general idea.
  
  One major comment at the bottom, rest aren't important.

INLINE COMMENTS

> feedback.cpp:41
> +
> +inline void swap(QJsonValueRef v1, QJsonValueRef v2)
> +{

where do you use this?

> feedback.cpp:109
> +p->deleteLater();
> +m_feedbackSources = {};
> +for (auto it = m_uses.constBegin(), itEnd = m_uses.constEnd(); it != 
> itEnd; ++it) {

This doesn't look right.

With 2 async processes, the second one to come in will replace the first?

> main.qml:90
>  
> -Component.onCompleted: {
> +value: {
>  var idx = findIndex(modeOptions, kcm.plasmaFeedbackLevel)

unrelated to this patch.

> main.qml:144
> +delegate: Image {
> +source: "image://icon/" + 
> modelData
> +}

AFAIK we're deprecating this.

Use of Kirigami.Icon would be preferred

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26570

To: apol, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26570: Improve Plasma user feedback introspection

[Aleix Pol Gonzalez]

apol updated this revision to Diff 73641.
apol added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26570?vs=73315=73641

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26570

AFFECTED FILES
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/package/contents/ui/main.qml
  shell/main.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  yeah thanks !
  Now, it turns out that the arrows are still ill-aligned (with respect to the 
handle). Maybe they use the full width for rendering ?

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D26655

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26525: Fix wallpaper destination path

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2212a9af156b: Fix wallpaper destination path (authored by 
trmdi).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26525?vs=73217=73640#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26525?vs=73217=73640

REVISION DETAIL
  https://phabricator.kde.org/D26525

AFFECTED FILES
  wallpapers/image/image.cpp

To: trmdi, #plasma, mart, ngraham
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 663 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/663/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 15 Jan 2020 17:05:07 +
 Build duration:
5 min 21 sec and counting
   CONSOLE OUTPUT
  [...truncated 2933 lines...][2020-01-15T17:10:19.744Z] [ 43%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/__/krdb/krdb.cpp.o[2020-01-15T17:10:20.306Z] [ 43%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/styleconfdialog.cpp.o[2020-01-15T17:10:21.234Z] [ 43%] Building CXX object kcms/launch/CMakeFiles/kcm_launchfeedback.dir/launchfeedbacksettings.cpp.o[2020-01-15T17:10:21.234Z] [ 43%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/kcmstyle.cpp.o[2020-01-15T17:10:21.796Z] [ 43%] Linking CXX executable ../../../bin/kcolorschemeeditor[2020-01-15T17:10:22.051Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/krdb/krdb.cpp: In function ���void applyGtkStyles(bool, int)���:[2020-01-15T17:10:22.051Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/krdb/krdb.cpp:93:33: warning: unused parameter ���active��� [-Wunused-parameter][2020-01-15T17:10:22.051Z]93 | static void applyGtkStyles(bool active, int version)[2020-01-15T17:10:22.051Z]   |~^~[2020-01-15T17:10:22.307Z] [ 43%] Building CXX object kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/themesmodel.cpp.o[2020-01-15T17:10:22.307Z] [ 43%] Built target kcolorschemeeditor[2020-01-15T17:10:22.307Z] [ 43%] Building CXX object kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/filterproxymodel.cpp.o[2020-01-15T17:10:22.307Z] [ 43%] Linking CXX shared module ../../bin/kcm_launchfeedback.so[2020-01-15T17:10:22.868Z] [ 43%] Built target kcm_launchfeedback[2020-01-15T17:10:23.429Z] [ 43%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/stylesmodel.cpp.o[2020-01-15T17:10:23.429Z] [ 43%] Building CXX object kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/desktopthemesettings.cpp.o[2020-01-15T17:10:24.404Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In lambda function:[2020-01-15T17:10:24.404Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:229:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2020-01-15T17:10:24.404Z]   229 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2020-01-15T17:10:24.404Z]   |  ^[2020-01-15T17:10:24.404Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2020-01-15T17:10:24.404Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:52:[2020-01-15T17:10:24.404Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2020-01-15T17:10:24.404Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2020-01-15T17:10:24.404Z]   |^~[2020-01-15T17:10:24.404Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:229:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2020-01-15T17:10:24.404Z]   229 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2020-01-15T17:10:24.404Z]   |  ^[2020-01-15T17:10:24.404Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2020-01-15T17:10:24.404Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:52:[2020-01-15T17:10:24.404Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2020-01-15T17:10:24.404Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2020-01-15T17:10:24.404Z]   |^~[2020-01-15T17:10:24.404Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In member function ���virtual void KCMStyle::save()���:[2020-01-15T17:10:24.404Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:306:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2020-01-15T17:10:24.404Z]   306 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2020-01-15T17:10:24.405Z]   |

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart updated this revision to Diff 73639.
mart added a comment.


  - Revert "center scrollbars"
  - align by growing scrollbar

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26655?vs=73636=73639

BRANCH
  arcpatch-D26655

REVISION DETAIL
  https://phabricator.kde.org/D26655

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:442c43b3ca98: Switch the Plasma Desktop KCMs to using 
KNewStuffQuick (authored by leinir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73598=73638

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/CMakeLists.txt
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26688: WIP: [Night Color] Display time when the next transition will start

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:59
> +// TODO: Show a better message...
> +return i18n("Night Color is not active, the next transition 
> will occur at %1",
> +
> monitor.scheduledTransitionDateTime.toLocaleString(Qt.locale()));

This is a comma splice. Change to:

Night Color is not active. The next transition...

or

Night Color is not active; the next transition...

or

Night Color is not active, but the next transition...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26688

To: zzag, #plasma, #vdg
Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26525: Fix wallpaper destination path

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yep, go ahead.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26525

To: trmdi, #plasma, mart, ngraham
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26686: Remove scrollbar related workarounds from list delegates

[Nathaniel Graham]

ngraham added a comment.


  Will we still need the `LayoutMirroring.enabled ?` logic to account for when 
using an RTL language where the scrollbar is on the left side?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26686

To: ahiemstra, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Alignment again: so you increased the width of the groove rather than 
increasing the width of the scrollbar. This indeed fixes the alignment of the 
handle (and groove), but now the scrollbar arrows are off centered. (for the 
same reason), with both the scrollbar groove and with respect to the line. I 
would revert to the old handle width and rather increase the scrollbar width by 
1 pixel. Then adjust the positioning. Does that make sense ? Increasing the 
width of the arrows by one pixel might break pixel alignment and create 
inconsistencies with other places were arrows are rendered ... 
  Now I realize that the thin scrollbar will still be off centered (and always 
was so far) while it is well centered with your patch, since it is only 3 
pixels while the thick one is 6 pixels ... This was not visible without the 
separator line. But it is going to dissapear with the other patch anyway. 
(otherwise one would probably need to increase its width to 4 pixels)

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D26655

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26609: [kstyle] Port to KWindowSystem shadows API

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> oxygenshadowhelper.cpp:291
>  #if OXYGEN_HAVE_KWAYLAND
> -if( widget->windowHandle()->parent() ) return false;
> -if( !_shadowManager || !_shmPool ) return false;
> -
> -const bool isDockWidget( this->isDockWidget( widget ) || 
> this->isToolBar( widget ) );
> -const TileSet  = isDockWidget ? _dockTiles : _tiles;
> -
> -if( !tiles.isValid() ) return false;
> -
> -// create shadow
> -using namespace KWayland::Client;
> -auto s = Surface::fromWindow( widget->windowHandle() );
> -if( !s ) return false;
> -
> -auto shadow = _shadowManager->createShadow( s, widget );
> -if( !shadow->isValid() ) return false;
> -
> -// add the shadow elements
> -shadow->attachTop( _shmPool->createBuffer( tiles.pixmap( 1 
> ).toImage() ) );
> -shadow->attachTopRight( _shmPool->createBuffer( tiles.pixmap( 2 
> ).toImage() ) );
> -shadow->attachRight( _shmPool->createBuffer( tiles.pixmap( 5 
> ).toImage() ) );
> -shadow->attachBottomRight( _shmPool->createBuffer( tiles.pixmap( 8 
> ).toImage() ) );
> -shadow->attachBottom( _shmPool->createBuffer( tiles.pixmap( 7 
> ).toImage() ) );
> -shadow->attachBottomLeft( _shmPool->createBuffer( tiles.pixmap( 6 
> ).toImage() ) );
> -shadow->attachLeft( _shmPool->createBuffer( tiles.pixmap( 3 
> ).toImage() ) );
> -shadow->attachTopLeft( _shmPool->createBuffer( tiles.pixmap( 0 
> ).toImage() ) );
> -
> -shadow->setOffsets( shadowMargins( widget ) );
> -shadow->commit();
> -s->commit( Surface::CommitFlag::None );
> -
> -return true;
> -#else
> -Q_UNUSED( widget );
> +if( widget->windowHandle()->parent() ) return;
>  #endif

I don't understand what this line is trying to do

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D26609

To: zzag, #kwin, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart updated this revision to Diff 73636.
mart added a comment.


  - center scrollbars

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26655?vs=73603=73636

BRANCH
  arcpatch-D26655

REVISION DETAIL
  https://phabricator.kde.org/D26655

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart marked 2 inline comments as done.
mart added a comment.


  comments should be adressed

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D26655

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26525: Fix wallpaper destination path

[Tranter Madi]

trmdi added a comment.


  Ping. Could I land this now?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26525

To: trmdi, #plasma, mart, ngraham
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  Strings can't be changed during the beta.
  
  There really isn't a rush for this, is there? It's a pretty minor thing. I 
want it too, but it's more important to get it right than to get it in earlier.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26685: Make the scrollbar always thick

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:6694eb7a9e80: Make the scrollbar always thick (authored by 
mart).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26685?vs=73604=73635

REVISION DETAIL
  https://phabricator.kde.org/D26685

AFFECTED FILES
  kstyle/breezestyle.cpp

To: mart, #plasma, #vdg, #breeze, ngraham, ndavis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:6570
> +
> +_helper->renderScrollBarBorder( painter, separatorRect, 
> _helper->alphaColor( option->palette.color( QPalette::WindowText ), 0.1 ));
> +

Another thing:
Color role should be QPalette::Text rather than WindowText, since the vast 
majority of the scrollbars are rendered on views (color roles then being Base 
and Text)

REPOSITORY
  R31 Breeze

BRANCH
  mart/phab/scrollbarseparator2

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26655: show a thin separator between view and scrollbar

[Noah Davis]

ndavis added a comment.


  +1 to this change.

INLINE COMMENTS

> breezestyle.cpp:6567
> +Qt::AlignLeft,
> +QSize(1, option->rect.height()), 
> option->rect);
> +}

Use PenWidth::Frame instead of hardcoding 1.

REPOSITORY
  R31 Breeze

BRANCH
  mart/phab/scrollbarseparator2

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26688: WIP: [Night Color] Display time when the next transition will start

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> main.qml:57
> +if (monitor.operationMode != Monitor.ConstantMode) {
> +if (monitor.currentTemperature == 6500) {
> +// TODO: Show a better message...

The bigger todo is hardcoded 6500K ?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26688

To: zzag, #plasma, #vdg
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26658: WIP: fix(kwayland): stall tablet config change

[Roman Gilg]

romangg updated this revision to Diff 73630.
romangg added a comment.


  - Init tablet before starting KWayland timer
  
  Further analysis showed that the issue is that for some reason the d-bus call 
to tablet mode properties is blocking for over one second. That in return leads 
to the single-shot timer failing. While we should not fail in this case that 
badly and in KWin it should be further investigated why the d-bus call is 
blocking for so long (it only blocks on startup, later on not anymore), for now 
move the tablet init before the timer is started. Then we should not fail any 
more on receiving the Wayland interfaces.

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26658?vs=73514=73630

BRANCH
  tablet-fix

REVISION DETAIL
  https://phabricator.kde.org/D26658

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: romangg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e2bfeb160bad: [SystemTray] Rework system tray settings 
(authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26586?vs=73504=73629

REVISION DETAIL
  https://phabricator.kde.org/D26586

AFFECTED FILES
  applets/systemtray/package/contents/config/config.qml
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, 
mart
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26583: [Application Style] Add GTK Application Style Page

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> gikari wrote in gtkthemesmodel.h:36
> No purpose, therefore can I just delete it?

Yes, I don't see why one would want `~Class() override = default` in a header 
file.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26583

To: gikari, #vdg, broulik, #plasma, ngraham, mart
Cc: zzag, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  Push it! Push it real good! :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, 
mart
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi again Marco,
  since you mentionned centering in plasmoids in the other commits, in fact 
here also the centering is wrong, with the added separator. Probably the offset 
is the one pixel you take for the separator. Can you double check ? (this 
appears true for QWidget based scrollbars, not QQC). Likely you need to 
increase the scrollbar width by 1, and tune the positionning of the 
groove+handle.

REPOSITORY
  R31 Breeze

BRANCH
  mart/phab/scrollbarseparator2

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26654: support mobile mode scrollbar

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:471213f74a40: support mobile mode scrollbar (authored by 
mart).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26654?vs=73626=73627

REVISION DETAIL
  https://phabricator.kde.org/D26654

AFFECTED FILES
  org.kde.desktop/ScrollBar.qml
  org.kde.desktop/ScrollView.qml

To: mart, #plasma, #vdg, #kirigami, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26654: support mobile mode scrollbar

[Marco Martin]

mart updated this revision to Diff 73626.
mart added a comment.


  - Merge branch 'master' into phab/mobilescrollbar
  - consider the frame paddings for the scrollbar

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26654?vs=73542=73626

BRANCH
  phab/mobilescrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26654

AFFECTED FILES
  org.kde.desktop/ScrollBar.qml
  org.kde.desktop/ScrollView.qml

To: mart, #plasma, #vdg, #kirigami, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> zzag wrote in gtkthemesmodel.h:36
> Whar's the purpose of this destructor?

No purpose, therefore can I just delete it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26583

To: gikari, #vdg, broulik, #plasma, ngraham, mart
Cc: zzag, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26593: Remove GTK KCM

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26593

To: gikari, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26689: [MPRIS Data Engine] Refactor to reduce code duplication

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `addPlayer` and `playerUpdated` effectively do the same, so merge the two 
implementations.
  Also simplify nesting in `setPlayerActive`

TEST PLAN
  Still behaves as before:
  
  - It never switches away from a playing player when another starts playing
  - It switches to a playing player if there was none before
  - When current player gets paused, it switches to another playing one, if 
any, or a paused one, if any, or a stopped one, if any
  - Closing a player, switches to another play one, if any, or a paused one, if 
any, or a stopped one, if any

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26689

AFFECTED FILES
  dataengines/mpris2/multiplexer.cpp
  dataengines/mpris2/multiplexer.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26583: [Application Style] Add GTK Application Style Page

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> gtkthemesmodel.h:36
> +GtkThemesModel(QObject *parent = nullptr);
> +~GtkThemesModel() override = default;
> +

Whar's the purpose of this destructor?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26583

To: gikari, #vdg, broulik, #plasma, ngraham, mart
Cc: zzag, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  In D24070#594840 , @ngraham wrote:
  
  > Maybe we can land it early in the 5.19 cycle?
  
  
  Do we really have to? That would delay this by additional 5 months., which is 
really unfortunate since work (a very slow work but still...) on this begun 
about 4 moths ago. I mean this patch works correctly right? And even if we find 
an issue during Beta, it can still be fixed. That's what Betas are for, anyway.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:268c5ced8ec2: [Application Style] Add GTK Application 
Style Page (authored by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26583?vs=73536=73624

REVISION DETAIL
  https://phabricator.kde.org/D26583

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.cpp
  kcms/style/gtkthemesmodel.h
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/GtkStylePage.qml
  kcms/style/package/contents/ui/main.qml

To: gikari, #vdg, broulik, #plasma, ngraham, mart
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  @broulik I'm leery of landing this for 5.18 since today is the last day for 
string changes. Maybe we can land it early in the 5.19 cycle?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26571: Provide information about how we are using KUserFeedback

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:b893a9bb940c: Provide information about how we are using 
KUserFeedback (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26571?vs=73228=73623

REVISION DETAIL
  https://phabricator.kde.org/D26571

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/DiscoverObject.h
  discover/main.cpp
  discover/qml/DiscoverWindow.qml

To: apol, #plasma, vkrause
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26660: [Applets/Task Manager] Fix and improve behavior tab layouts

[Nathaniel Graham]

ngraham added a comment.


  Don't worry about it. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26660

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Nathaniel Graham]

ngraham added a comment.


  In D26655#594415 , 
@hpereiradacosta wrote:
  
  > For the record, you were around for the original commit that made the 
scrollbar thiner (https://phabricator.kde.org/D9792)
  
  
  Heh, how embarrassing. I do remember that patch now, and I remember not 
really liking the idea it but not feeling like it was my place to object since 
I was quite new and I should give things a chance. And I wasn't around for 
D3210  where the scrollbars were first 
changed.

REPOSITORY
  R31 Breeze

BRANCH
  mart/phab/scrollbarseparator2

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26037: feat(kded): add orientation sensor

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:8032881459d1: feat(kded): add orientation sensor 
(authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26037?vs=73185=73619

REVISION DETAIL
  https://phabricator.kde.org/D26037

AFFECTED FILES
  CMakeLists.txt
  common/orientation_sensor.cpp
  common/orientation_sensor.h
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt

To: romangg, #plasma, davidedmundson
Cc: plasma-devel, davidedmundson, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26038: feat(kcm): add option for auto rotation

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:039337cd3b1a: feat(kcm): add option for auto rotation 
(authored by romangg).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26038?vs=73149=73620

REVISION DETAIL
  https://phabricator.kde.org/D26038

AFFECTED FILES
  common/control.cpp
  common/control.h
  kcm/CMakeLists.txt
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/output_model.cpp
  kcm/output_model.h
  kcm/package/contents/ui/Orientation.qml
  kded/config.cpp

To: romangg, #plasma
Cc: plasma-devel, apol, aaronhoneycutt, sasch, ngraham, davidedmundson, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26684: [Notifications KCM] Add docbook for new KCM

[Yuri Chornoivan]

yurchor accepted this revision.
yurchor added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26684

To: broulik, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26684: [Notifications KCM] Add docbook for new KCM

[Kai Uwe Broulik]

broulik updated this revision to Diff 73618.
broulik added a comment.


  - Fix wording

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26684?vs=73600=73618

REVISION DETAIL
  https://phabricator.kde.org/D26684

AFFECTED FILES
  doc/kcontrol/CMakeLists.txt
  doc/kcontrol/kcmnotify/CMakeLists.txt
  doc/kcontrol/kcmnotify/index.docbook
  doc/kcontrol/notifications/CMakeLists.txt
  doc/kcontrol/notifications/index.docbook

To: broulik, #documentation
Cc: yurchor, plasma-devel, kde-doc-english, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> main.qml:1
> +/
> + KWin - the KDE window manager

Bad file permissions. Needs to be 644.

> main.qml:74-76
> +var c = Math.min(thumbnailGridView.count, 
> maxGridColumnsByWidth);
> +
> +var residue = thumbnailGridView.count % c;

You could use `const` here

  const c = ...
  
  const residue = ...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:231
> +
> +// This doesn't work, nor does keyboard input work on any other 
> tabbox skin (KDE 5.7.4)
> +// It does work in the preview however.

GridView has it's own input handling you shouldn't need this anyway.

If keyboard doesn't work, chances are your activeFocus is incorrect.

I can only see focus: true on

  id: dialogMainItem

it should be on the gridview instead

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

To: Zren, romangg, #plasma
Cc: davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> romangg wrote in main.qml:183
> This must be `width: parent.height`. implicitWidth is a read-only property. 
> WIthout this change the qml file won't load.

you can use Layout.preferredWidth

One shouldn't specifiy a width/height from an item inside a layout

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

To: Zren, romangg, #plasma
Cc: davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Roman Gilg]

romangg requested changes to this revision.
romangg added a reviewer: Plasma.
romangg added a comment.
This revision now requires changes to proceed.


  Nice. Let's fix these few issues and get it merged before tomorrow. Other 
small issues can be fixed in beta phase.

INLINE COMMENTS

> main.qml:182
> +id: iconItem
> +Layout.fillHeight: true
> +implicitWidth: parent.height

It works for me if you keep it `height: parent.height`.

> main.qml:183
> +Layout.fillHeight: true
> +implicitWidth: parent.height
> +icon: model.icon

This must be `width: parent.height`. implicitWidth is a read-only property. 
WIthout this change the qml file won't load.

> main.qml:230
> +
> +
> +// This doesn't work, nor does keyboard input work on any other 
> tabbox skin (KDE 5.7.4)

trailing white space

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

To: Zren, romangg, #plasma
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26688: WIP: [Night Color] Display time when the next transition will start

[Vlad Zahorodnii]

zzag created this revision.
zzag added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Currently the applet displays "Night Color is active (%screen color
  temperature% K)" all the time even if the screen is not actually
  red-ish. It may be really confusing for ordinary people and I expect
  that a few bug reports saying "the applet shows that Night Color is
  active, but in reality it isn't" might be reported.
  
  The best thing would be to display "Night Color is not active, the next
  transition will start at %datetime% and end at %datetime%" or something
  along the line.
  
  This patch is still WIP because I'm not 100% sure how to present this
  kind of information to user.

REPOSITORY
  R114 Plasma Addons

BRANCH
  show-next-transition-timings

REVISION DETAIL
  https://phabricator.kde.org/D26688

AFFECTED FILES
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h

To: zzag, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:5e55e45d8794: Add option to easily configure and start a 
hotspot (authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26392?vs=73614=73615

REVISION DETAIL
  https://phabricator.kde.org/D26392

AFFECTED FILES
  applet/contents/ui/Toolbar.qml
  kcm/kcm.cpp
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/main.qml
  kded/networkmanagement.notifyrc
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp

To: jgrulich, #plasma, ngraham, #vdg, apol
Cc: meven, cblack, alexde, mthw, apol, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  hotspot

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg, apol
Cc: meven, cblack, alexde, mthw, apol, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Jan Grulich]

jgrulich updated this revision to Diff 73614.
jgrulich marked an inline comment as done.
jgrulich added a comment.


  - Code improvements

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26392?vs=73437=73614

BRANCH
  hotspot

REVISION DETAIL
  https://phabricator.kde.org/D26392

AFFECTED FILES
  applet/contents/ui/Toolbar.qml
  kcm/kcm.cpp
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/main.qml
  kded/networkmanagement.notifyrc
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp

To: jgrulich, #plasma, ngraham, #vdg
Cc: meven, cblack, alexde, mthw, apol, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26684: [Notifications KCM] Add docbook for new KCM

[Yuri Chornoivan]

yurchor added a comment.


  Thanks for fixing this minor typo.

INLINE COMMENTS

> index.docbook:132
> +Keep popup open during progress
> +Whether the popup should remain visible for the 
> entire duration of the progress or automatically hide. It will always shown 
> again when the task finishes or fails.
> +

Typo: It will always shown -> It will always be shown

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26684

To: broulik, #documentation
Cc: yurchor, plasma-devel, kde-doc-english, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Aleix Pol Gonzalez]

apol added a comment.


  Patch looks good to me overall. +1

INLINE COMMENTS

> handler.cpp:615
> +
> +QVariantMap options;
> +options.insert(QLatin1String("persist"), QLatin1String("volatile"));

I'd prefer the initializer list syntax
`const QVariantMap options = { {QLatin1String("persist"), 
QLatin1String("volatile")} };`

> handler.cpp:623
> +connect(watcher, ::finished, this, 
> ::replyFinished);
> +connect(watcher, ::finished, this, 
> static_cast *)>(::hotspotCreated));
> +}

Use QOverload instead of static_cast, for readability.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: meven, cblack, alexde, mthw, apol, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26680: [kcms/feedback] Implement setRepresentsDefaults

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> meven wrote in feedback.cpp:43
> nitpick, You could move this to `Feedback::setPlasmaFeedbackLevel` as well.
> 1 saves a connect, 
> 2 make setRepresesentsDefault and setNeedsSave close in the file

sorry I missed your comment.

I'll make this change.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26680

To: davidedmundson, #plasma, ngraham
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26679: [kcms/feedback] Fix default button not showing

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e1324b0f5457: [kcms/feedback] Fix default button not 
showing (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26679?vs=73588=73612

REVISION DETAIL
  https://phabricator.kde.org/D26679

AFFECTED FILES
  kcms/feedback/package/contents/ui/main.qml

To: davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart