D26720: Cache single image wallpapers locally

[Kai Uwe Broulik]

broulik added a comment.


  This doesn't appear to be containment-aware (e.g. multi-screen, activities, 
etc).
  How does the settings page handle this scenario?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26720

To: ngraham, #plasma
Cc: broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

[David Edmundson]

davidedmundson added a comment.


  What does enabled on a label do?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26715

To: ngraham, #vdg, #plasma, apol
Cc: davidedmundson, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26714: KCM/Component Revamp FileManager UI

[Nathaniel Graham]

ngraham added a comment.


  Selecting the "Other..." option for this one takes me to the filetype editor 
for `inode/directory` instead of the app chooser as in the other patches. Is 
that intentional?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26714

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ce5094c02a87: [Widget Explorer] Show placeholder message 
when there are no widgets or search… (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26715?vs=73735=73744

REVISION DETAIL
  https://phabricator.kde.org/D26715

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: ngraham, #vdg, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

[Nathaniel Graham]

ngraham added a comment.


  Yep.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26715

To: ngraham, #vdg, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D18006: Include only the largest size for the "Next" wallpaper

[Nathaniel Graham]

ngraham added a comment.


  The whole point was to save some space on the user's machine. However trading 
space savings for load time maybe isn't the best trade-off? 18 MB isn't really 
all that much of a savings.
  
  Should we shelve this idea?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D18006

To: ngraham, #vdg, #breeze, mart
Cc: apol, davidedmundson, mart, filipf, kvermette, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra

D24706: [RFC] Change button style

[Noah Davis]

ndavis added a comment.


  TBH, the current way control shadows are rendered seems kind of wrong anyway. 
The shadow is rendered within the button, so when you rotate a button, the 
shadow gets rotated as well.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, 
Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis added a comment.


  I think I'm going to need bigger, fancier shadows to get a good pressed 
movement (besides changing background color) with the diagonal movement removed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, 
Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis added a comment.


  In D24706#595764 , @ngraham wrote:
  
  > Thanks Noah.
  >
  > So you're the boss after all (as the de- facto Breeze maintainer now), and 
I think we should follow your lead design-wise. But it might also be 
interesting to have a discussion about what we want this to accomplish.
  >
  > Personally here's my wishlist:
  >
  > 1. Make it much more visually obvious which button is the default button
  > 2. Make the focused state look less like what most people would assume is 
the appearance for the default button
  > 3. Avoid making the focused state look too subtle
  > 4. Make the pressed state look more "pressed"
  >
  >   I think this patch does #3 and #4, but not #1 or #2. However it's 
possible that the focus style you've chosen will be just fine once the 
selection effects look like this everywhere for consistency, and if the default 
button gets a stronger look.
  
  
  I can agree with all of these goals.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, 
Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D18006: Include only the largest size for the "Next" wallpaper

[Aleix Pol Gonzalez]

apol added a comment.


  In D18006#595773 , @apol wrote:
  
  > -1
  
  
  I just saw what this revision depends on. So it could make sense. I'll leave 
it at -0 because caches are bad.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D18006

To: ngraham, #vdg, #breeze, mart
Cc: apol, davidedmundson, mart, filipf, kvermette, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra

D18006: Include only the largest size for the "Next" wallpaper

[Aleix Pol Gonzalez]

apol added a comment.


  -1
  This will also reduce load time considerably (I did the profiling before, 
using the same resolution is a big win).
  Also you'll get to save quite some IO.
  
  If this is a problem, I'd suggest looking into doing these wallpapers in svg 
or even QML.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D18006

To: ngraham, #vdg, #breeze, mart
Cc: apol, davidedmundson, mart, filipf, kvermette, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra

D26111: Runner: make recentdocument use KActivityStats data

[Aleix Pol Gonzalez]

apol added a comment.


  I'm not the original author. I guess I appear because of the git repository 
split or something.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik, apol
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I believe we are in string freeze, this will sadly have to go to master.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26715

To: ngraham, #vdg, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24706: [RFC] Change button style

[Nathaniel Graham]

ngraham added a comment.


  Thanks Noah.
  
  So you're the boss after all (as the de- facto Breeze maintainer now), and I

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, 
Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis added a comment.


  There were some conflicts, so this isn't exactly how it was before.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, 
Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis updated this revision to Diff 73742.
ndavis added a comment.


  Rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24706?vs=69901=73742

BRANCH
  ndavis/pushbutton-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24706

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, 
Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  The continual forwarding of keys makes sense. I'm happy to accept that.
  
  I don't want us to make krunner autostart. It's a hack, not a fix.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26720: Cache single image wallpapers locally

[Nathaniel Graham]

ngraham added a comment.


  Note that I found the code here very complicated so it's possible I may have 
done this in a sub-optimal way.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26720

To: ngraham, #plasma
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26720: Cache single image wallpapers locally

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now, if the user sets a wallpaper and it disappears on disk, the next 
time Plasma
  is restarted, the wallpaper will be reset to the default, which is probably 
not what
  the user expected.
  
  This patch caches the wallpaper locally every time the user specifically 
changes it.
  Thereafter, if the path to the original wallpaper becomes invalid, Plasma 
will fall
  back to reading the wallpaper from the cache.
  
  BUG: 399905
  FIXED-IN; 5.18.0

TEST PLAN
  - Set wallpaper to some image on disk
  - Delete or rename that file
  - Restart plasmashell
  
  User-specified image is retained, rather than being replaced with the default 
wallpaper.
  
  No changes to slideshows or other wallpaper plugins.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wallpaper-cache (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26720

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/image.h

To: ngraham, #plasma
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski updated this revision to Diff 73740.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26718?vs=73737=73740

REVISION DETAIL
  https://phabricator.kde.org/D26718

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/dbus/org.kde.krunner.service.in
  krunner/krunner-daemon.desktop.cmake
  shell/desktopview.cpp
  shell/desktopview.h

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26719: [Battery Monitor] Glow icon on hover

[Konrad Materka]

kmaterka added inline comments.

INLINE COMMENTS

> CompactRepresentation.qml:67
> -pluggedIn: batteryContainer.pluggedIn
> -height: isConstrained ? batteryContainer.iconSize : 
> batteryContainer.iconSize - batteryLabel.height
> -width: height

`batteryLabel` does not exist anymore, it was replaced by `BadgeOverlay`

> CompactRepresentation.qml:86
>  
> -BadgeOverlay {
> -anchors.fill: batteryIcon
> -text: batteryContainer.hasBattery ? i18nc("battery 
> percentage below battery icon", "%1%", percent) : i18nc("short symbol to 
> signal there is no battery currently available", "-")
> -icon: batteryIcon
> -visible: plasmoid.configuration.showPercentage
> +GammaAdjust {
> +anchors.fill: batteryItem

Is it a good candidate for a component? It can be reused in Notifications 
applet.

> CompactRepresentation.qml:87
> +GammaAdjust {
> +anchors.fill: batteryItem
> +source: batteryItem

Must be a sibling

> CompactRepresentation.qml:89
> +source: batteryItem
> +gamma: root.containsMouse ? (1.0 / 0.7) : 1
> +

0.7 is from KIconEffect::init() 
.
 Theoretically it can be overwritten by kglobalconfig: 
["DesktopIcons"]["ActiveEffect"]["value"], but I looked and found no usage of 
this config parameter.
In fact, the effect itself can be overwritten by a config value...

> CompactRepresentation.qml:93-94
> +PropertyAnimation {
> +easing: Easing.InOutQuad
> +duration: 250
> +}

These two are from IconItem 
:

  m_animation->setEasingCurve(QEasingCurve::InOutQuad);
  m_animation->setDuration(250); //FIXME from theme

Animation duration is hardcoded, how to get theme value (in QML)?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26719

To: kmaterka, #plasma_workspaces, #plasma, broulik, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Plasma 5.18 Branched

[Albert Astals Cid]

El dijous, 16 de gener de 2020, a les 14:30:29 CET, Jonathan Riddell va 
escriure:
> Plasma has branched for the 5.18 releases.  Beta is due today and final
> release in three weeks time.
> 
> Could i18n team move over the stable translations from master?

Luigi did this.

Cheers,
  Albert

> 
> Plasma team please don't commit new features to Plasma/5.18 branches but
> please do make lots of bug fixes.
> 
> Jonathan
> 

D26719: [Battery Monitor] Glow icon on hover

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, broulik, ngraham, 
davidedmundson.
Herald added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  All icons in System Tray "glow" a little bit when mouse is over the icon. 
This is easy to implement using IconItem, but for SvgItem this eefect must be 
applied manually.
  
  BUG: 416310

TEST PLAN
  Move mouse over the baterry icon, it should be a little bit brighter.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26719

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml

To: kmaterka, #plasma_workspaces, #plasma, broulik, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski added inline comments.

INLINE COMMENTS

> broulik wrote in main.cpp:231
> This is not how we want to autostart something :) Instead, you want to place 
> the desktop file in autostart folder again

Right :)
I thought of this so that everytime Plasma starts it ensures KRunner is running 
too.
But I guess this is not really needed - both KRunner and Plasma would have to 
crash for this to be useful.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski added a comment.


  In D26718#595688 , @broulik wrote:
  
  > Maybe if we autostarted KRunner based on whether it was used previously
  
  
  "Used previously" as in opened at least once?
  I guess this is always true for every user, because KRunner probably was 
opened even accidentally (DesktopView typing, Alt+Space) by everyone.
  
  Used to actually run something at least once?
  That could work. Still if someone cares for KRunner *not* starting up with 
Plasma, they may want better control over it.
  
  So maybe a simple checkbox somewhere in System Settings?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

[Kai Uwe Broulik]

broulik added a comment.


  Hmm, I'd appreciate some startup time optimizations for KRunner first.
  Maybe if we autostarted KRunner based on whether it was used previously would 
be a nice trade-off between resources for systems that don't use it and power 
users that always use it and get annoyed by the lag.

INLINE COMMENTS

> main.cpp:231
> +if (krunnerPeer->isValid()) {
> +krunnerPeer->asyncCall(QStringLiteral("Ping"));
> +}

This is not how we want to autostart something :) Instead, you want to place 
the desktop file in autostart folder again

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26111: Runner: make recentdocument use KActivityStats data

[Méven Car]

meven added a comment.


  Adding @apol as reviewers as he was the original author of this runner.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik, apol
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

[Nathaniel Graham]

ngraham added a comment.


  IIRC we used to do this, but changed it to run-on-demand to save some memory 
on startup.
  
  Might be worth revisiting that though, since I can confirm the latency that 
leads to the first few characters getting typed into the open app instead of 
KRunner, which is really annoying. We have a recent bug report about this: 
https://bugs.kde.org/show_bug.cgi?id=416145

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

[Mikhail Zolotukhin]

gikari planned changes to this revision.
gikari added a comment.


  Ok, then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26717

To: gikari, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

[Nathaniel Graham]

ngraham added a comment.


  No I see it as a consistency/polish/bugfix thing. The rest of the KCMs got 
ported to use the new dialog for Plasma 5.18; it would be a bit weird if this 
one didn't get the same treatment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26717

To: gikari, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski created this revision.
pdabrowski added reviewers: Plasma, Plasma: Workspaces, davidedmundson, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pdabrowski requested review of this revision.

REVISION SUMMARY
  autostart KRunner with Plasma as daemon to minimize query latency
  
  aggregate text for KRunner in DesktopView to prevent eating fast-typed 
characters

TEST PLAN
  KRunner should be now running when Plasma starts.
  (when testing from your own KDE install location, watch out for conflicts with
  "/usr/share/dbus-1/services/org.kde.krunner.service" KRunner DBUS service)
  
  When DesktopView is focused, typed characters show KRunner query.
  All fast-typed characters should now appear correctly in KRunner window,
  instead of only first typed character.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

AFFECTED FILES
  krunner/dbus/org.kde.krunner.service.in
  shell/desktopview.cpp
  shell/desktopview.h
  shell/main.cpp

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

[Mikhail Zolotukhin]

gikari added a comment.


  In D26717#595664 , @ngraham wrote:
  
  > Even better would be if we can use the new QML dialogs too. See D26544 

  
  
  Does this count as a new feature, i.e is this QML change will be in 5.18?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26717

To: gikari, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

[Nathaniel Graham]

ngraham added a comment.


  Even better would be if we can use the new QML dialogs too. See D26544 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26717

To: gikari, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

[Mikhail Zolotukhin]

gikari created this revision.
gikari added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Move away from using QDialog::exec() due to using nested event loop.
  
  Also make knsrc files use better names.

TEST PLAN
  Test dialogs for GTK themes installation.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  change-exec (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26717

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtk2_themes.knsrc
  kcms/style/gtk3_themes.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.h
  kcms/style/package/contents/ui/GtkStylePage.qml

To: gikari, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26715: [Widget Explorer] Show placeholder message when there are no widgets or searc results

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 416313
  FIXED-IN: 5.19.0

TEST PLAN
  F7886823: Peek 2020-01-16 13-03.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26715

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

[Andreas Hartmetz]

ahartmetz added a comment.


  So what do we do here? The Qt bug has been fixed but still I'm not sure what 
should be done about the environment variables.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: acooligan, fvogt, asturmlechner, dfaure, davidedmundson, anthonyfieroni, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Plasma 5.18 LTS Beta

[Jonathan Riddell]

Two more updates

http://download.kde.org/unstable/plasma/5.17.90/plasma-nm-5.17.90.4.tar.xz
b9a507d05806ec1cc83b2c6c5c6076901d5e3aaf4849f4a0691858cdfb282d74

http://download.kde.org/unstable/plasma/5.17.90/libkscreen-5.17.90.1.tar.xz
f4f935e511a377966b593a51a3cdddc7624bb9358ebf9792e9b76b9dffefe9fb

D26580: Kicker/RecentDocuments display place's icon when resource matches one

[Méven Car]

meven added a comment.


  ping @hein

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26714: KCM/Component Revamp FileManager UI

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ervin, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filemanager-settings

REVISION DETAIL
  https://phabricator.kde.org/D26714

AFFECTED FILES
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/filemanagerconfig_ui.ui

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

[Vlad Zahorodnii]

zzag updated this revision to Diff 73729.
zzag added a comment.


  Adjust to recent changes in KWindowShadow

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26458?vs=73381=73729

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 59 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/59/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 17:05:59 +
 Build duration:
6 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2587)14%
(212/1505)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/165)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1249)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/259)0%
(0/138)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D26565: KCM/Component Revamp email config

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I'm so sorry, this was my mistake. Somehow KMail got re-installed without my 
knowledge. Probably https://bugzilla.suse.com/show_bug.cgi?id=1035802 biting me 
again.
  
  Once I've removed it again, everything works perfectly.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 75 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/75/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 17:07:03 +
 Build duration:
3 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4082)0%
(0/2646)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1444)0%
(0/1063)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/823)0%
(0/478)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/237)0%
(0/122)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1026)0%
(0/750)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/198)0%
(0/93)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/72)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/80)0%
(0/22)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/118)0%
(0/46)

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.13 - Build # 42 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/42/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 17:06:01 +
 Build duration:
3 min 54 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D26565: KCM/Component Revamp email config

[Méven Car]

meven added a comment.


  In D26565#595522 , @ngraham wrote:
  
  > Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I 
don't think that makes sense.
  
  
  Everything in the combobox comes from /usr/share/applications/*desktop  (or 
similar path) or mimeapps.list's "Added Applications"
  
  So Are you sure ?
  Does it have an icon ?
  Do you have a `/usr/share/applications/org.kde.kmail2.desktop` file ?
  Is kmail mentioned in ~/.config/mimeapps.list ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26705: KCM/Component Revamp Terminal Emulator UI

[Méven Car]

meven updated this revision to Diff 73718.
meven marked an inline comment as done.
meven edited the test plan for this revision.
meven added a comment.


  NoDisplay == false instead of NoDisplay != true

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26705?vs=73697=73718

BRANCH
  terminal-config

REVISION DETAIL
  https://phabricator.kde.org/D26705

AFFECTED FILES
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/terminalemulatorconfig_ui.ui

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I 
don't think that makes sense.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt added a comment.


  Ping.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: ngraham, fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26705: KCM/Component Revamp Terminal Emulator UI

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> componentchooserterminal.cpp:76
> +
> +const auto constraint = QStringLiteral("'TerminalEmulator' in Categories 
> AND (not exist NoDisplay OR NoDisplay != true)");
> +const auto terminalEmulators = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), constraint);

`NoDisplay == false` seems slightly more readable than `NoDisplay != true`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  terminal-config

REVISION DETAIL
  https://phabricator.kde.org/D26705

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26688: WIP: [Night Color] Display time when the next transition will start

[Nathaniel Graham]

ngraham added a comment.


  Here's my suggestions for what to display in the applet for various 
conditions:
  
  Feature disabled: no tray icon shown anywhere
  
  Feature enabled but not active: tray icon in passive state (only in pop-up) 
with the following text:
  
  > Night color is inactive
  >  Activation will begin at 
  
  Feature enabled, transition to turning on is in progress: tray icon is in 
active state with the following text:
  
  > Night color is activating
  >  Colors fully changed at 
  
  Feature enabled and colors are fully changed: tray icon is in active state 
with the following text:
  
  > Night color is active with color temperature 
  >  Deactivation will begin at  tomorrow
  
  Feature enabled, transition to turning off is in progress: tray icon is in 
active state with the following text:
  
  > Night color is deactivating
  >  Colors will return to normal at 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26688

To: zzag, #plasma, #vdg
Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: [RFC] Change button style

[Nathaniel Graham]

ngraham added a comment.


  Would you mind rebasing this? It seems like we're moving forward with the 
idea of iterating on Breeze rather than making a whole new theme, and since 
Plasma 5.18 just branched, we have some space to hack on master now. I'd like 
to see if we can move forward with this.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, 
Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D26709: add gpu entry to about system

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> broulik wrote in GPUEntry.cpp:49
> `KSqueezedTextLabel` doesn't help?

Never knew this was a thing!
Looks like this would require lots of fiddling though. It seems to bug out with 
AlignLeft in the grid layout, and also one would have to know what size the 
qlabel should be I guess.

...the trouble is more that a long label looks silly F7886480: 
Screenshot_20200116_164337.png , not just 
that it should fit within the size constraint

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26709

To: sitter
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26710: [Notifications] Support DESKTOP_FILE_HINT without BAMF prefix

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  No idea why this has changed for my Spotify but that's what I have now...

TEST PLAN
  5.18
  My spotify track changes are associated with Spotify again

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26710

AFFECTED FILES
  libnotificationmanager/utils.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/8/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 15:18:54 +
 Build duration:
26 sec and counting
   CONSOLE OUTPUT
  [...truncated 244 lines...][2020-01-16T15:19:20.561Z] -- Performing Test HAVE_DATE_TIME[2020-01-16T15:19:20.561Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-16T15:19:20.561Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-16T15:19:20.561Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-16T15:19:20.561Z] -- Found KF5Plasma: /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.561Z] -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.561Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-16T15:19:20.561Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.561Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2020-01-16T15:19:20.561Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.561Z] -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.816Z] -- Found KF5People: /usr/home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.816Z] -- Found KF5: success (found suitable version "5.67.0", minimum required is "5.66.0") found components: Plasma Service Declarative I18n KIO People [2020-01-16T15:19:20.816Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-16T15:19:20.816Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-16T15:19:20.816Z] -- Found KF5PlasmaQuick: /usr/home/jenkins/install-prefix/lib/cmake/KF5PlasmaQuick/KF5PlasmaQuickConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.816Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.816Z] -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.67.0") [2020-01-16T15:19:20.816Z] -- Found KF5: success (found version "5.67.0") found components: PlasmaQuick DBusAddons Notifications [2020-01-16T15:19:20.816Z] -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.6.3") [2020-01-16T15:19:20.816Z] -- Checking for module 'gstreamer-1.0'[2020-01-16T15:19:20.816Z] --   Found gstreamer-1.0, version 1.14.4[2020-01-16T15:19:20.816Z] -- Found GStreamer package: 1.14.4[2020-01-16T15:19:20.816Z] -- Found GStreamer: /usr/local/lib/libgstreamer-1.0.so (Required is at least version "1.1.90") [2020-01-16T15:19:20.816Z] -- Found GLIB2: /usr/local/lib/libglib-2.0.so  [2020-01-16T15:19:20.816Z] -- Checking for module 'gobject-2.0'[2020-01-16T15:19:20.816Z] --   Found gobject-2.0, version 2.56.3[2020-01-16T15:19:20.816Z] -- Found GOBJECT: /usr/local/lib/libgobject-2.0.so;/usr/local/lib/libgmodule-2.0.so;/usr/local/lib/libgthread-2.0.so;/usr/local/lib/libglib-2.0.so  [2020-01-16T15:19:20.816Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:67 (message):[2020-01-16T15:19:20.816Z]   warnings during generation of metainfo for org.kde.plasma.phone: Package[2020-01-16T15:19:20.816Z]   type "Plasma/LookAndFeel" not found[2020-01-16T15:19:20.816Z] [2020-01-16T15:19:20.816Z]   org.kde.kcoreaddons: Invalid plugin metadata: Attempting to create a[2020-01-16T15:19:20.816Z]   KAboutPerson from json without 'Name' property:[2020-01-16T15:19:20.816Z]   QJsonObject({"Email":"","Name":""})[2020-01-16T15:19:20.816Z] [2020-01-16T15:19:20.816Z] Call Stack (most recent call first):[2020-01-16T15:19:20.816Z]   /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaMacros.cmake:34 (kpackage_install_package)[2020-01-16T15:19:20.816Z]   CMakeLists.txt:45 

Re: Plasma 5.18 LTS Beta

[Jonathan Riddell]

plasma-nm has an update 5.17.90.2

http://download.kde.org/unstable/plasma/5.17.90/plasma-nm-5.17.90.2.tar.xz

sha256 2c68cab7de88e8479aa9be91255fcec4ca8129ae42c0a8aeee14b884ef5cd60e


On Thu, 16 Jan 2020 at 14:42, Jonathan Riddell  wrote:

> Plasma 5.18 LTS Beta is out for testing for the next three weeks!
>
> Emoji Selector, global edit mode, improved touch-friendliness, better GTK
> app support and weather widget gets breezy with windy conditions.
>
> https://kde.org/announcements/plasma-5.17.90
>
> New in this release is plasma-nano and plasma-phone-components which are
> not LTS releases.
>
>

D26709: add gpu entry to about system

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> GPUEntry.cpp:49
> +// It seems the renderer value may have excess information in 
> parentheses ->
> +// strip that. Elide would probably be nicer, a bit meh with 
> QWidgets though.
> +value = value.mid(0, value.indexOf('('));

`KSqueezedTextLabel` doesn't help?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26709

To: sitter
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26709: add gpu entry to about system

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  simply queries gl_renderer from gl
  
  also refactor string processing for (R) and (TM) replacement so
  it can be shared for cpu and gpu entries
  
  I do wonder if we need to blacklist software gl somehow though

TEST PLAN
  shows something of value on amd and intel
  
  depends on D26667 

REPOSITORY
  R102 KInfoCenter

BRANCH
  gpu

REVISION DETAIL
  https://phabricator.kde.org/D26709

AFFECTED FILES
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/CPUEntry.cpp
  Modules/about-distro/src/FancyString.cpp
  Modules/about-distro/src/FancyString.h
  Modules/about-distro/src/GPUEntry.cpp
  Modules/about-distro/src/GPUEntry.h
  Modules/about-distro/src/Module.cpp

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26667: refactor about-distro to more generically support textual dumps

[Harald Sitter]

sitter updated this revision to Diff 73708.
sitter added a comment.


  remove extra file

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26667?vs=73707=73708

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26667

AFFECTED FILES
  Modules/about-distro/src/BitEntry.cpp
  Modules/about-distro/src/BitEntry.h
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/CPUEntry.cpp
  Modules/about-distro/src/CPUEntry.h
  Modules/about-distro/src/Entry.cpp
  Modules/about-distro/src/Entry.h
  Modules/about-distro/src/KernelEntry.cpp
  Modules/about-distro/src/KernelEntry.h
  Modules/about-distro/src/MemoryEntry.cpp
  Modules/about-distro/src/MemoryEntry.h
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui
  Modules/about-distro/src/PlasmaEntry.cpp
  Modules/about-distro/src/PlasmaEntry.h
  Modules/about-distro/src/SectionLabel.cpp
  Modules/about-distro/src/SectionLabel.h

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  > Can the top of the scrollbar go below the column headers instead of next to 
them?
  > 
  > Like this:
  >  F7886305: Screenshot_20200116_083629.png 

  
  I don't think it is doable inside Qt no, due to how widgets are nested ( 
header in viewport, next to scrollbars, in scrollarea)
  Also, for the last column this would pose serious problems on centering 
between column content and column header (for right align column in particular)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26667: refactor about-distro to more generically support textual dumps

[Harald Sitter]

sitter updated this revision to Diff 73707.
sitter added a comment.


  split into one class per file

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26667?vs=73602=73707

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26667

AFFECTED FILES
  Modules/about-distro/src/BitEntry.cpp
  Modules/about-distro/src/BitEntry.h
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/CPUEntry.cpp
  Modules/about-distro/src/CPUEntry.h
  Modules/about-distro/src/Entry.cpp
  Modules/about-distro/src/Entry.h
  Modules/about-distro/src/GPUEntry.cpp
  Modules/about-distro/src/GPUEntry.h
  Modules/about-distro/src/KernelEntry.cpp
  Modules/about-distro/src/KernelEntry.h
  Modules/about-distro/src/MemoryEntry.cpp
  Modules/about-distro/src/MemoryEntry.h
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui
  Modules/about-distro/src/PlasmaEntry.cpp
  Modules/about-distro/src/PlasmaEntry.h
  Modules/about-distro/src/SectionLabel.cpp
  Modules/about-distro/src/SectionLabel.h

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Plasma 5.18 LTS Beta

[Jonathan Riddell]

Plasma 5.18 LTS Beta is out for testing for the next three weeks!

Emoji Selector, global edit mode, improved touch-friendliness, better GTK
app support and weather widget gets breezy with windy conditions.

https://kde.org/announcements/plasma-5.17.90

New in this release is plasma-nano and plasma-phone-components which are
not LTS releases.

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 383 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/383/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 14:07:46 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26655: show a thin separator between view and scrollbar

[Noah Davis]

ndavis added a comment.


  Vertical scrollbar taking the corner without the column header change: 
F7886334: Screenshot_20200116_083629.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 673 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/673/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 14:07:46 +
 Build duration:
6 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtestName: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report15%
(12/79)16%
(59/369)16%
(59/369)12%
(3749/31456)9%
(1725/18990)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.emojier0%
(0/1)0%
(0/1)0%
(0/185)0%
(0/82)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1098)0%
(0/620)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/356)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/320)0%
(0/244)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2350)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%

D26655: show a thin separator between view and scrollbar

[Noah Davis]

ndavis added a comment.


  In D26655#595381 , 
@hpereiradacosta wrote:
  
  > As a side note: I have been using this code for a couple of days now, and 
while I think the separator looks well for vertical scrollbars, when you have 
both vertical and horizontal, ... this will need some getting used to. 
  >  See: 
  >  F7886206: Screenshot_20200116_083629.png 

  >  This is with a thin handle, but having the thick one does not really 
improve. The view looks like a frame inside a frame, first one being 
off-centered. 
  >  I have no clue how this can be improved
  
  
  Can the top of the scrollbar go below the column headers instead of next to 
them?
  
  Like this:
  F7886305: Screenshot_20200116_083629.png 

  
  Or maybe we could make the vertical scrollbar take up the bottom right corner:
  F7886321: Screenshot_20200116_083629.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26706: Remove notification inhibitor lock

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:8df6c01ca46f: Remove notification inhibitor lock 
(authored by broulik).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26706?vs=73701=73706

REVISION DETAIL
  https://phabricator.kde.org/D26706

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml

To: broulik, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:aa2119a835e9: [KDED KCM] Rewrite as KDeclarative 
ScrollViewKCM (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26506?vs=73369=73705#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26506?vs=73369=73705

REVISION DETAIL
  https://phabricator.kde.org/D26506

AFFECTED FILES
  CMakeLists.txt
  kcms/kded/CMakeLists.txt
  kcms/kded/filterproxymodel.cpp
  kcms/kded/filterproxymodel.h
  kcms/kded/kcmkded.cpp
  kcms/kded/kcmkded.desktop
  kcms/kded/kcmkded.h
  kcms/kded/modulesmodel.cpp
  kcms/kded/modulesmodel.h
  kcms/kded/package/contents/ui/main.qml
  kcms/kded/package/metadata.desktop

To: broulik, #plasma, #vdg, mart, ngraham
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 382 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/382/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 13:15:49 +
 Build duration:
48 min and counting
   CONSOLE OUTPUT
  [...truncated 218 lines...][2020-01-16T14:03:48.511Z] HOME  = '/home/jenkins'[2020-01-16T14:03:48.511Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/382/'[2020-01-16T14:03:48.511Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/'[2020-01-16T14:03:48.511Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-16T14:03:48.511Z] SHELL = '/usr/local/bin/bash'[2020-01-16T14:03:48.511Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13'[2020-01-16T14:03:48.511Z] MM_CHARSET= 'UTF-8'[2020-01-16T14:03:48.511Z] STAGE_NAME= 'Configuring Build'[2020-01-16T14:03:48.511Z] NODE_NAME = 'FreeBSD Builder 1'[2020-01-16T14:03:48.511Z] BLOCKSIZE = 'K'[2020-01-16T14:03:48.511Z] EXECUTOR_NUMBER   = '0'[2020-01-16T14:03:48.511Z] SHLVL = '0'[2020-01-16T14:03:48.511Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T14:03:48.511Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-01-16T14:03:48.511Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-01-16T14:03:48.511Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-01-16T14:03:48.511Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-01-16T14:03:48.511Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-01-16T14:03:48.511Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-01-16T14:03:48.511Z] QT_SELECT = 'qt5'[2020-01-16T14:03:48.511Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T14:03:48.511Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-01-16T14:03:48.511Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-01-16T14:03:48.511Z] [2020-01-16T14:03:48.511Z] [2020-01-16T14:03:48.511Z] == Commencing Configuration:[2020-01-16T14:03:48.511Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13"[2020-01-16T14:03:48.511Z] -- The C compiler identification is Clang 8.0.1[2020-01-16T14:03:48.766Z] -- The CXX compiler identification is Clang 8.0.1[2020-01-16T14:03:48.766Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T14:03:48.766Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T14:03:48.766Z] -- Detecting C compiler ABI info[2020-01-16T14:03:48.766Z] -- Detecting C compiler ABI info - done[2020-01-16T14:03:48.766Z] -- Detecting C compile features[2020-01-16T14:03:48.766Z] -- Detecting C compile features - done[2020-01-16T14:03:48.766Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T14:03:48.766Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T14:03:48.766Z] -- Detecting CXX compiler ABI info[2020-01-16T14:03:48.766Z] -- Detecting CXX compiler ABI info - done[2020-01-16T14:03:48.766Z] -- Detecting CXX compile features[2020-01-16T14:03:48.766Z] -- Detecting CXX compile features - done[2020-01-16T14:03:48.766Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-desktop.[2020-01-16T14:03:48.766Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-01-16T14:03:48.766Z] -- Looking for __GLIBC__[2020-01-16T14:03:49.034Z] -- Looking for __GLIBC__ - not found[2020-01-16T14:03:49.034Z] -- Performing Test _OFFT_IS_64BIT[2020-01-16T14:03:49.034Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-16T14:03:49.034Z] -- Performing Test HAVE_DATE_TIME[2020-01-16T14:03:49.034Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-16T14:03:49.034Z] -- Found KF5Auth: /usr/home/jenkins/install-prefix/lib/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.67.0") [2020-01-16T14:03:49.034Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-desktop.[2020-01-16T14:03:49.034Z] Installing in 

D26706: Remove notification inhibitor lock

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
broulik requested review of this revision.

REVISION SUMMARY
  Now that the notifications dodge the popup

TEST PLAN
  5.18
  
  - No suspicious warnings
  - Search field still closes when closing the popup

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26706

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml

To: broulik, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 141 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/141/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 13:17:55 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/6)0%
(0/18)0%
(0/18)0%
(0/1495)0%
(0/651)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/274)0%
(0/128)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/100)0%
(0/27)core0%
(0/9)0%
(0/9)0%
(0/524)0%
(0/252)icons0%
(0/3)0%
(0/3)0%
(0/122)0%
(0/32)sidebar0%
(0/1)0%
(0/1)0%
(0/367)0%
(0/179)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/108)0%
(0/33)

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/41/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 13:13:24 +
 Build duration:
30 min and counting
   CONSOLE OUTPUT
  [...truncated 200 lines...][2020-01-16T13:43:51.193Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.13'[2020-01-16T13:43:51.193Z] EDITOR= 'vi'[2020-01-16T13:43:51.193Z] ENV   = '/home/jenkins/.shrc'[2020-01-16T13:43:51.193Z] HUDSON_HOME   = '/home/production/data'[2020-01-16T13:43:51.193Z] CCACHE_DIR= '/home/jenkins/.ccache/'[2020-01-16T13:43:51.193Z] BUILD_ID  = '41'[2020-01-16T13:43:51.193Z] OLDPWD= '/usr/home/jenkins'[2020-01-16T13:43:51.193Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.13'[2020-01-16T13:43:51.193Z] _ = '/usr/local/bin/java'[2020-01-16T13:43:51.193Z] TERM  = 'su'[2020-01-16T13:43:51.193Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.13'[2020-01-16T13:43:51.193Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 FreeBSDQt5.13-41'[2020-01-16T13:43:51.193Z] BUILD_DISPLAY_NAME= '#41'[2020-01-16T13:43:51.193Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/41/display/redirect'[2020-01-16T13:43:51.193Z] USER  = 'jenkins'[2020-01-16T13:43:51.193Z] HOME  = '/home/jenkins'[2020-01-16T13:43:51.193Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/41/'[2020-01-16T13:43:51.193Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/'[2020-01-16T13:43:51.193Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-16T13:43:51.193Z] SHELL = '/usr/local/bin/bash'[2020-01-16T13:43:51.193Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.13'[2020-01-16T13:43:51.193Z] MM_CHARSET= 'UTF-8'[2020-01-16T13:43:51.193Z] STAGE_NAME= 'Configuring Build'[2020-01-16T13:43:51.193Z] NODE_NAME = 'FreeBSD Builder 2'[2020-01-16T13:43:51.193Z] BLOCKSIZE = 'K'[2020-01-16T13:43:51.193Z] EXECUTOR_NUMBER   = '0'[2020-01-16T13:43:51.193Z] SHLVL = '0'[2020-01-16T13:43:51.193Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T13:43:51.193Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-01-16T13:43:51.193Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-01-16T13:43:51.193Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-01-16T13:43:51.193Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-01-16T13:43:51.193Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-01-16T13:43:51.193Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-01-16T13:43:51.193Z] QT_SELECT = 'qt5'[2020-01-16T13:43:51.193Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T13:43:51.193Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-01-16T13:43:51.193Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-01-16T13:43:51.193Z] [2020-01-16T13:43:51.193Z] [2020-01-16T13:43:51.193Z] == Commencing Configuration:[2020-01-16T13:43:51.193Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.13"[2020-01-16T13:43:51.193Z] -- The C compiler identification is Clang 8.0.1[2020-01-16T13:43:51.448Z] -- The CXX compiler identification is Clang 8.0.1[2020-01-16T13:43:51.448Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T13:43:51.448Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T13:43:51.448Z] -- Detecting C compiler ABI info[2020-01-16T13:43:51.448Z] -- Detecting C compiler ABI info - done[2020-01-16T13:43:51.448Z] -- Detecting C compile features[2020-01-16T13:43:51.448Z] -- Detecting C compile features - done[2020-01-16T13:43:51.448Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T13:43:51.448Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T13:43:51.448Z] -- Detecting CXX compiler ABI info[2020-01-16T13:43:51.703Z] 

D26705: KCM/Component Revamp Terminal Emulator UI

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ervin, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Revamp UI, to use a simple combobox
  
  - Other... choice allows to select any programe
  - Keep konsole as default
  - changed & default works
  - List in the combobox knwon TerminalEmulator installed

REPOSITORY
  R119 Plasma Desktop

BRANCH
  terminal-config

REVISION DETAIL
  https://phabricator.kde.org/D26705

AFFECTED FILES
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/terminalemulatorconfig_ui.ui

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 74 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/74/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 13:17:40 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 259 lines...][2020-01-16T13:40:42.992Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/74/display/redirect'[2020-01-16T13:40:42.992Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-01-16T13:40:42.992Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12'[2020-01-16T13:40:42.992Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-16T13:40:42.992Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-01-16T13:40:42.992Z] NODE_NAME = 'Docker Swarm-7d82cc9d3eb6'[2020-01-16T13:40:42.992Z] HOST  = '7d82cc9d3eb6'[2020-01-16T13:40:42.992Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-16T13:40:42.992Z] USER  = 'jenkins'[2020-01-16T13:40:42.992Z] MORE  = '-sl'[2020-01-16T13:40:42.992Z] CSHEDIT   = 'emacs'[2020-01-16T13:40:42.992Z] SHLVL = '2'[2020-01-16T13:40:42.992Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-kf5-qt5 SUSEQt5.12-74'[2020-01-16T13:40:42.992Z] WINDOWMANAGER = 'xterm'[2020-01-16T13:40:42.992Z] PAGER = 'less'[2020-01-16T13:40:42.992Z] EXECUTOR_NUMBER   = '0'[2020-01-16T13:40:42.992Z] CVS_RSH   = 'ssh'[2020-01-16T13:40:42.992Z] LIBGL_DEBUG   = 'quiet'[2020-01-16T13:40:42.992Z] STAGE_NAME= 'Configuring Build'[2020-01-16T13:40:42.992Z] NODE_LABELS   = 'Docker Swarm-7d82cc9d3eb6 SUSEQt5.12'[2020-01-16T13:40:42.992Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-16T13:40:42.992Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-16T13:40:42.992Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-16T13:40:42.992Z] PROFILEREAD   = 'true'[2020-01-16T13:40:42.992Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-16T13:40:42.992Z] HOSTTYPE  = 'x86_64'[2020-01-16T13:40:42.992Z] BUILD_ID  = '74'[2020-01-16T13:40:42.992Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-01-16T13:40:42.992Z] OLDPWD= '/home/jenkins'[2020-01-16T13:40:42.992Z] LC_CTYPE  = 'C.UTF-8'[2020-01-16T13:40:42.992Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T13:40:42.992Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-16T13:40:42.992Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-16T13:40:42.992Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-16T13:40:42.992Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-16T13:40:42.992Z] QT_SELECT = 'qt5'[2020-01-16T13:40:42.992Z] LANG  = 'en_US.UTF-8'[2020-01-16T13:40:42.992Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T13:40:42.992Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-16T13:40:42.992Z] [2020-01-16T13:40:42.992Z] [2020-01-16T13:40:42.992Z] == Commencing Configuration:[2020-01-16T13:40:42.992Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12"[2020-01-16T13:40:43.918Z] -- The C compiler identification is GNU 9.2.1[2020-01-16T13:40:45.811Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-16T13:40:45.811Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T13:40:47.692Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T13:40:47.692Z] -- Detecting C compiler ABI info[2020-01-16T13:40:47.947Z] -- Detecting C compiler ABI info - done[2020-01-16T13:40:47.947Z] -- Detecting C compile features[2020-01-16T13:40:47.947Z] -- Detecting C compile features - done[2020-01-16T13:40:47.947Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T13:40:50.470Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T13:40:50.470Z] -- Detecting CXX compiler ABI info[2020-01-16T13:40:51.837Z] -- Detecting CXX compiler ABI info - done[2020-01-16T13:40:51.837Z] -- Detecting CXX compile features[2020-01-16T13:40:51.837Z] -- Detecting CXX compile features - 

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  As a side note: I have been using this code for a couple of days now, and 
while I think the separator looks well for vertical scrollbars, when you have 
both vertical and horizontal, ... this will need some getting used to. 
  See: 
  F7886206: Screenshot_20200116_083629.png 

  This is with a thin handle, but having the thick one does not really improve. 
The view looks like a frame inside a frame, first one being off-centered. 
  I have no clue how this can be improved

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 672 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/672/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 13:15:49 +
 Build duration:
18 min and counting
   CONSOLE OUTPUT
  [...truncated 276 lines...][2020-01-16T13:33:59.137Z] WINDOWMANAGER = 'xterm'[2020-01-16T13:33:59.137Z] PAGER = 'less'[2020-01-16T13:33:59.137Z] EXECUTOR_NUMBER   = '0'[2020-01-16T13:33:59.137Z] CVS_RSH   = 'ssh'[2020-01-16T13:33:59.137Z] LIBGL_DEBUG   = 'quiet'[2020-01-16T13:33:59.137Z] STAGE_NAME= 'Configuring Build'[2020-01-16T13:33:59.137Z] NODE_LABELS   = 'Docker Swarm-32062eacb608 SUSEQt5.12'[2020-01-16T13:33:59.137Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-16T13:33:59.137Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-16T13:33:59.137Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-16T13:33:59.137Z] PROFILEREAD   = 'true'[2020-01-16T13:33:59.137Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-16T13:33:59.137Z] HOSTTYPE  = 'x86_64'[2020-01-16T13:33:59.137Z] BUILD_ID  = '672'[2020-01-16T13:33:59.137Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-01-16T13:33:59.137Z] OLDPWD= '/home/jenkins'[2020-01-16T13:33:59.137Z] LC_CTYPE  = 'C.UTF-8'[2020-01-16T13:33:59.137Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T13:33:59.137Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-16T13:33:59.137Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-16T13:33:59.137Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-16T13:33:59.137Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-16T13:33:59.137Z] QT_SELECT = 'qt5'[2020-01-16T13:33:59.137Z] LANG  = 'en_US.UTF-8'[2020-01-16T13:33:59.137Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T13:33:59.137Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-16T13:33:59.137Z] [2020-01-16T13:33:59.137Z] [2020-01-16T13:33:59.137Z] == Commencing Configuration:[2020-01-16T13:33:59.137Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12"[2020-01-16T13:34:00.498Z] -- The C compiler identification is GNU 9.2.1[2020-01-16T13:34:00.754Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-16T13:34:01.010Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T13:34:01.570Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T13:34:01.570Z] -- Detecting C compiler ABI info[2020-01-16T13:34:01.824Z] -- Detecting C compiler ABI info - done[2020-01-16T13:34:01.824Z] -- Detecting C compile features[2020-01-16T13:34:01.824Z] -- Detecting C compile features - done[2020-01-16T13:34:01.824Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T13:34:02.079Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T13:34:02.079Z] -- Detecting CXX compiler ABI info[2020-01-16T13:34:02.079Z] -- Detecting CXX compiler ABI info - done[2020-01-16T13:34:02.079Z] -- Detecting CXX compile features[2020-01-16T13:34:02.079Z] -- Detecting CXX compile features - done[2020-01-16T13:34:02.639Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-01-16T13:34:03.199Z] -- Looking for __GLIBC__[2020-01-16T13:34:03.199Z] -- Looking for __GLIBC__ - found[2020-01-16T13:34:03.199Z] -- Performing Test _OFFT_IS_64BIT[2020-01-16T13:34:03.454Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-16T13:34:03.454Z] -- Performing Test HAVE_DATE_TIME[2020-01-16T13:34:03.454Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-16T13:34:03.709Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.67.0") [2020-01-16T13:34:03.709Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-01-16T13:34:03.709Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-01-16T13:34:03.709Z] -- Found 

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26655#595314 , @mart wrote:
  
  > In D26655#595102 , @ndavis wrote:
  >
  > > I noticed that when hovering on the scrollbar border, while the view area 
is not focused, the scrollbar handle is light gray (Breeze Dark, dark gray for 
Breeze) instead of blue. Moving the mouse just slightly more to the right turns 
the scrollbar handle blue.
  >
  >
  > That's the difference between thesubControlRect of the handle (that has 
been moved by one pixel to the right for the line) and the rectangle of the 
entire scrollbar.
  >
  > to change this and have the handle always hitting, the subcontrolrects 
should stay the same and just paint the handle moved by one pixeltough the 
subcontrol rects not moving.
  >  either is good, probably the latter approach looks a bit dirtier in the 
code but if you think is better from a design pov, it can be done
  
  
  Yeah. I think one has to go this second way, to avoid the 1 pixel color 
flicker noted by Noah: scrollbar hover without handle hover. 
  Right now the scrollbar hit area includes the separator, while the handle 
does not. 
  Agreed that the code will look slightly less intuitive but so be it.
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Plasma 5.18 Branched

[Jonathan Riddell]

Plasma has branched for the 5.18 releases.  Beta is due today and final
release in three weeks time.

Could i18n team move over the stable translations from master?

Plasma team please don't commit new features to Plasma/5.18 branches but
please do make lots of bug fixes.

Jonathan

D26658: fix(kwayland): move blocking tablet init before timer start

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:13b631eabb98: fix(kwayland): move blocking tablet init 
before timer start (authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26658?vs=73630=73696

REVISION DETAIL
  https://phabricator.kde.org/D26658

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: romangg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 58 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/58/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 13:13:24 +
 Build duration:
9 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-01-16T13:21:43.048Z] JOB_NAME  = 'Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2020-01-16T13:21:43.048Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-01-16T13:21:43.048Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/58/display/redirect'[2020-01-16T13:21:43.048Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-01-16T13:21:43.048Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2020-01-16T13:21:43.048Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-16T13:21:43.048Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-01-16T13:21:43.048Z] NODE_NAME = 'Docker Swarm-72a668052bd6'[2020-01-16T13:21:43.048Z] HOST  = '72a668052bd6'[2020-01-16T13:21:43.048Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-16T13:21:43.048Z] USER  = 'jenkins'[2020-01-16T13:21:43.048Z] MORE  = '-sl'[2020-01-16T13:21:43.048Z] CSHEDIT   = 'emacs'[2020-01-16T13:21:43.048Z] SHLVL = '2'[2020-01-16T13:21:43.048Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 SUSEQt5.12-58'[2020-01-16T13:21:43.048Z] WINDOWMANAGER = 'xterm'[2020-01-16T13:21:43.048Z] PAGER = 'less'[2020-01-16T13:21:43.048Z] EXECUTOR_NUMBER   = '0'[2020-01-16T13:21:43.048Z] CVS_RSH   = 'ssh'[2020-01-16T13:21:43.048Z] LIBGL_DEBUG   = 'quiet'[2020-01-16T13:21:43.048Z] STAGE_NAME= 'Configuring Build'[2020-01-16T13:21:43.048Z] NODE_LABELS   = 'Docker Swarm-72a668052bd6 SUSEQt5.12'[2020-01-16T13:21:43.048Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-16T13:21:43.048Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-16T13:21:43.048Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-16T13:21:43.048Z] PROFILEREAD   = 'true'[2020-01-16T13:21:43.048Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-16T13:21:43.048Z] HOSTTYPE  = 'x86_64'[2020-01-16T13:21:43.048Z] BUILD_ID  = '58'[2020-01-16T13:21:43.048Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-01-16T13:21:43.048Z] OLDPWD= '/home/jenkins'[2020-01-16T13:21:43.048Z] LC_CTYPE  = 'C.UTF-8'[2020-01-16T13:21:43.048Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T13:21:43.048Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-16T13:21:43.048Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-16T13:21:43.048Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-16T13:21:43.048Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-16T13:21:43.048Z] QT_SELECT = 'qt5'[2020-01-16T13:21:43.048Z] LANG  = 'en_US.UTF-8'[2020-01-16T13:21:43.048Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T13:21:43.048Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-16T13:21:43.048Z] [2020-01-16T13:21:43.048Z] [2020-01-16T13:21:43.048Z] == Commencing Configuration:[2020-01-16T13:21:43.048Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12"[2020-01-16T13:21:45.575Z] -- The C compiler identification is GNU 9.2.1[2020-01-16T13:22:03.651Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-16T13:22:03.651Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T13:22:10.200Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T13:22:10.200Z] -- Detecting C compiler ABI info[2020-01-16T13:22:18.356Z] -- Detecting C compiler ABI info - done[2020-01-16T13:22:18.356Z] -- Detecting C compile features[2020-01-16T13:22:18.356Z] -- Detecting C compile features - done[2020-01-16T13:22:18.356Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T13:22:19.285Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T13:22:19.285Z] -- Detecting CXX compiler ABI info[2020-01-16T13:22:21.183Z] 

D26565: KCM/Component Revamp email config

[Méven Car]

meven updated this revision to Diff 73695.
meven added a comment.


  Add a couple of const

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73548=73695

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 671 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/671/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 12:19:29 +
 Build duration:
1 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 276 lines...][2020-01-16T12:21:16.101Z] WINDOWMANAGER = 'xterm'[2020-01-16T12:21:16.101Z] PAGER = 'less'[2020-01-16T12:21:16.101Z] EXECUTOR_NUMBER   = '0'[2020-01-16T12:21:16.101Z] CVS_RSH   = 'ssh'[2020-01-16T12:21:16.101Z] LIBGL_DEBUG   = 'quiet'[2020-01-16T12:21:16.101Z] STAGE_NAME= 'Configuring Build'[2020-01-16T12:21:16.101Z] NODE_LABELS   = 'Docker Swarm-ff01fc12cf7d SUSEQt5.12'[2020-01-16T12:21:16.101Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-16T12:21:16.101Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-16T12:21:16.101Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-16T12:21:16.101Z] PROFILEREAD   = 'true'[2020-01-16T12:21:16.101Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-16T12:21:16.101Z] HOSTTYPE  = 'x86_64'[2020-01-16T12:21:16.101Z] BUILD_ID  = '671'[2020-01-16T12:21:16.101Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-01-16T12:21:16.101Z] OLDPWD= '/home/jenkins'[2020-01-16T12:21:16.101Z] LC_CTYPE  = 'C.UTF-8'[2020-01-16T12:21:16.101Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T12:21:16.101Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-16T12:21:16.101Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-16T12:21:16.101Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-16T12:21:16.101Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-16T12:21:16.101Z] QT_SELECT = 'qt5'[2020-01-16T12:21:16.101Z] LANG  = 'en_US.UTF-8'[2020-01-16T12:21:16.101Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T12:21:16.101Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-16T12:21:16.101Z] [2020-01-16T12:21:16.101Z] [2020-01-16T12:21:16.101Z] == Commencing Configuration:[2020-01-16T12:21:16.101Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12"[2020-01-16T12:21:16.101Z] -- The C compiler identification is GNU 9.2.1[2020-01-16T12:21:16.664Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-16T12:21:16.664Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T12:21:16.922Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T12:21:16.922Z] -- Detecting C compiler ABI info[2020-01-16T12:21:16.922Z] -- Detecting C compiler ABI info - done[2020-01-16T12:21:16.922Z] -- Detecting C compile features[2020-01-16T12:21:16.922Z] -- Detecting C compile features - done[2020-01-16T12:21:16.922Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T12:21:16.922Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T12:21:16.922Z] -- Detecting CXX compiler ABI info[2020-01-16T12:21:17.177Z] -- Detecting CXX compiler ABI info - done[2020-01-16T12:21:17.177Z] -- Detecting CXX compile features[2020-01-16T12:21:17.177Z] -- Detecting CXX compile features - done[2020-01-16T12:21:17.177Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-01-16T12:21:17.177Z] -- Looking for __GLIBC__[2020-01-16T12:21:17.177Z] -- Looking for __GLIBC__ - found[2020-01-16T12:21:17.177Z] -- Performing Test _OFFT_IS_64BIT[2020-01-16T12:21:17.177Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-16T12:21:17.177Z] -- Performing Test HAVE_DATE_TIME[2020-01-16T12:21:17.437Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-16T12:21:17.437Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.67.0") [2020-01-16T12:21:17.437Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-01-16T12:21:17.437Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-01-16T12:21:17.437Z] -- 

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 140 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/140/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 12:03:57 +
 Build duration:
16 min and counting
   CONSOLE OUTPUT
  [...truncated 266 lines...][2020-01-16T12:20:47.554Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-16T12:20:47.554Z] USER  = 'jenkins'[2020-01-16T12:20:47.554Z] MORE  = '-sl'[2020-01-16T12:20:47.554Z] CSHEDIT   = 'emacs'[2020-01-16T12:20:47.554Z] SHLVL = '2'[2020-01-16T12:20:47.554Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-kf5-qt5 SUSEQt5.12-140'[2020-01-16T12:20:47.554Z] WINDOWMANAGER = 'xterm'[2020-01-16T12:20:47.554Z] PAGER = 'less'[2020-01-16T12:20:47.554Z] EXECUTOR_NUMBER   = '0'[2020-01-16T12:20:47.554Z] CVS_RSH   = 'ssh'[2020-01-16T12:20:47.554Z] LIBGL_DEBUG   = 'quiet'[2020-01-16T12:20:47.554Z] STAGE_NAME= 'Configuring Build'[2020-01-16T12:20:47.554Z] NODE_LABELS   = 'Docker Swarm-dfd1138a965e SUSEQt5.12'[2020-01-16T12:20:47.554Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-16T12:20:47.554Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-16T12:20:47.554Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-16T12:20:47.554Z] PROFILEREAD   = 'true'[2020-01-16T12:20:47.554Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-16T12:20:47.554Z] HOSTTYPE  = 'x86_64'[2020-01-16T12:20:47.554Z] BUILD_ID  = '140'[2020-01-16T12:20:47.554Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-01-16T12:20:47.554Z] OLDPWD= '/home/jenkins'[2020-01-16T12:20:47.554Z] LC_CTYPE  = 'C.UTF-8'[2020-01-16T12:20:47.554Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T12:20:47.554Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-16T12:20:47.554Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-16T12:20:47.554Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-16T12:20:47.554Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-16T12:20:47.554Z] QT_SELECT = 'qt5'[2020-01-16T12:20:47.554Z] LANG  = 'en_US.UTF-8'[2020-01-16T12:20:47.554Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T12:20:47.554Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-16T12:20:47.554Z] [2020-01-16T12:20:47.554Z] [2020-01-16T12:20:47.554Z] == Commencing Configuration:[2020-01-16T12:20:47.554Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12"[2020-01-16T12:20:47.809Z] -- The C compiler identification is GNU 9.2.1[2020-01-16T12:20:49.167Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-16T12:20:49.167Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T12:20:50.098Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T12:20:50.098Z] -- Detecting C compiler ABI info[2020-01-16T12:20:50.354Z] -- Detecting C compiler ABI info - done[2020-01-16T12:20:50.354Z] -- Detecting C compile features[2020-01-16T12:20:50.354Z] -- Detecting C compile features - done[2020-01-16T12:20:50.354Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T12:20:50.609Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T12:20:50.609Z] -- Detecting CXX compiler ABI info[2020-01-16T12:20:50.609Z] -- Detecting CXX compiler ABI info - done[2020-01-16T12:20:50.609Z] -- Detecting CXX compile features[2020-01-16T12:20:50.609Z] -- Detecting CXX compile features - done[2020-01-16T12:20:50.609Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for systemsettings.[2020-01-16T12:20:50.609Z] -- Looking for __GLIBC__[2020-01-16T12:20:50.609Z] -- Looking for __GLIBC__ - found[2020-01-16T12:20:50.609Z] -- Performing Test _OFFT_IS_64BIT[2020-01-16T12:20:50.609Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-16T12:20:50.862Z] -- Performing Test HAVE_DATE_TIME[2020-01-16T12:20:50.862Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-16T12:20:50.862Z] -- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.67.0") 

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 73 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/73/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 12:03:42 +
 Build duration:
16 min and counting
   CONSOLE OUTPUT
  [...truncated 259 lines...][2020-01-16T12:20:09.302Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/73/display/redirect'[2020-01-16T12:20:09.302Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-01-16T12:20:09.302Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12'[2020-01-16T12:20:09.302Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-16T12:20:09.302Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-01-16T12:20:09.302Z] NODE_NAME = 'Docker Swarm-c356775468d9'[2020-01-16T12:20:09.302Z] HOST  = 'c356775468d9'[2020-01-16T12:20:09.302Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-16T12:20:09.302Z] USER  = 'jenkins'[2020-01-16T12:20:09.302Z] MORE  = '-sl'[2020-01-16T12:20:09.302Z] CSHEDIT   = 'emacs'[2020-01-16T12:20:09.302Z] SHLVL = '2'[2020-01-16T12:20:09.302Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-kf5-qt5 SUSEQt5.12-73'[2020-01-16T12:20:09.302Z] WINDOWMANAGER = 'xterm'[2020-01-16T12:20:09.302Z] PAGER = 'less'[2020-01-16T12:20:09.302Z] EXECUTOR_NUMBER   = '0'[2020-01-16T12:20:09.302Z] CVS_RSH   = 'ssh'[2020-01-16T12:20:09.302Z] LIBGL_DEBUG   = 'quiet'[2020-01-16T12:20:09.302Z] STAGE_NAME= 'Configuring Build'[2020-01-16T12:20:09.302Z] NODE_LABELS   = 'Docker Swarm-c356775468d9 SUSEQt5.12'[2020-01-16T12:20:09.302Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-16T12:20:09.302Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-16T12:20:09.302Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-16T12:20:09.302Z] PROFILEREAD   = 'true'[2020-01-16T12:20:09.302Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-16T12:20:09.302Z] HOSTTYPE  = 'x86_64'[2020-01-16T12:20:09.302Z] BUILD_ID  = '73'[2020-01-16T12:20:09.302Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-01-16T12:20:09.302Z] OLDPWD= '/home/jenkins'[2020-01-16T12:20:09.302Z] LC_CTYPE  = 'C.UTF-8'[2020-01-16T12:20:09.302Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T12:20:09.302Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-16T12:20:09.302Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-16T12:20:09.302Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-16T12:20:09.302Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-16T12:20:09.302Z] QT_SELECT = 'qt5'[2020-01-16T12:20:09.302Z] LANG  = 'en_US.UTF-8'[2020-01-16T12:20:09.302Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T12:20:09.302Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-16T12:20:09.302Z] [2020-01-16T12:20:09.302Z] [2020-01-16T12:20:09.302Z] == Commencing Configuration:[2020-01-16T12:20:09.302Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.12"[2020-01-16T12:20:11.202Z] -- The C compiler identification is GNU 9.2.1[2020-01-16T12:20:11.456Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-16T12:20:11.456Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T12:20:11.952Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T12:20:11.952Z] -- Detecting C compiler ABI info[2020-01-16T12:20:11.952Z] -- Detecting C compiler ABI info - done[2020-01-16T12:20:11.952Z] -- Detecting C compile features[2020-01-16T12:20:11.952Z] -- Detecting C compile features - done[2020-01-16T12:20:11.952Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T12:20:11.952Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T12:20:11.952Z] -- Detecting CXX compiler ABI info[2020-01-16T12:20:11.952Z] -- Detecting CXX compiler ABI info - done[2020-01-16T12:20:11.952Z] -- Detecting CXX compile features[2020-01-16T12:20:11.952Z] -- Detecting CXX compile features - 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 57 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/57/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 11:59:26 +
 Build duration:
6 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-01-16T12:05:33.866Z] JOB_NAME  = 'Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2020-01-16T12:05:33.866Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-01-16T12:05:33.866Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/57/display/redirect'[2020-01-16T12:05:33.866Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-01-16T12:05:33.866Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12'[2020-01-16T12:05:33.866Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-16T12:05:33.866Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-01-16T12:05:33.866Z] NODE_NAME = 'Docker Swarm-8f52d3b707d2'[2020-01-16T12:05:33.866Z] HOST  = '8f52d3b707d2'[2020-01-16T12:05:33.866Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-16T12:05:33.866Z] USER  = 'jenkins'[2020-01-16T12:05:33.866Z] MORE  = '-sl'[2020-01-16T12:05:33.866Z] CSHEDIT   = 'emacs'[2020-01-16T12:05:33.866Z] SHLVL = '2'[2020-01-16T12:05:33.866Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 SUSEQt5.12-57'[2020-01-16T12:05:33.866Z] WINDOWMANAGER = 'xterm'[2020-01-16T12:05:33.866Z] PAGER = 'less'[2020-01-16T12:05:33.866Z] EXECUTOR_NUMBER   = '0'[2020-01-16T12:05:33.866Z] CVS_RSH   = 'ssh'[2020-01-16T12:05:33.866Z] LIBGL_DEBUG   = 'quiet'[2020-01-16T12:05:33.866Z] STAGE_NAME= 'Configuring Build'[2020-01-16T12:05:33.866Z] NODE_LABELS   = 'Docker Swarm-8f52d3b707d2 SUSEQt5.12'[2020-01-16T12:05:33.866Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-16T12:05:33.866Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-16T12:05:33.866Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-16T12:05:33.866Z] PROFILEREAD   = 'true'[2020-01-16T12:05:33.866Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-16T12:05:33.866Z] HOSTTYPE  = 'x86_64'[2020-01-16T12:05:33.866Z] BUILD_ID  = '57'[2020-01-16T12:05:33.866Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-01-16T12:05:33.866Z] OLDPWD= '/home/jenkins'[2020-01-16T12:05:33.866Z] LC_CTYPE  = 'C.UTF-8'[2020-01-16T12:05:33.866Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-16T12:05:33.866Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-16T12:05:33.866Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-16T12:05:33.866Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-16T12:05:33.866Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-16T12:05:33.866Z] QT_SELECT = 'qt5'[2020-01-16T12:05:33.866Z] LANG  = 'en_US.UTF-8'[2020-01-16T12:05:33.866Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-16T12:05:33.866Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-16T12:05:33.866Z] [2020-01-16T12:05:33.866Z] [2020-01-16T12:05:33.866Z] == Commencing Configuration:[2020-01-16T12:05:33.866Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.12"[2020-01-16T12:05:34.122Z] -- The C compiler identification is GNU 9.2.1[2020-01-16T12:05:34.378Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-16T12:05:34.378Z] -- Check for working C compiler: /usr/bin/cc[2020-01-16T12:05:34.378Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-16T12:05:34.378Z] -- Detecting C compiler ABI info[2020-01-16T12:05:34.634Z] -- Detecting C compiler ABI info - done[2020-01-16T12:05:34.634Z] -- Detecting C compile features[2020-01-16T12:05:34.634Z] -- Detecting C compile features - done[2020-01-16T12:05:34.634Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-16T12:05:34.891Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-16T12:05:34.891Z] -- Detecting CXX compiler ABI info[2020-01-16T12:05:35.147Z] 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 396 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/396/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 11:01:27 +
 Build duration:
5 min 8 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.runners.bookmarks.tests.testChromeBookmarksName: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26702: [MPRIS Data Engine] Support player proxying for another one

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e4f91a3ee8b0: [MPRIS Data Engine] Support player proxying 
for another one (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26702?vs=73678=73692

REVISION DETAIL
  https://phabricator.kde.org/D26702

AFFECTED FILES
  dataengines/mpris2/multiplexer.cpp
  dataengines/mpris2/multiplexer.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26686: Remove scrollbar related workarounds from list delegates

[Arjen Hiemstra]

ahiemstra added a comment.


  That logic is in ScrollView already. Since the delegate no longer needs 
special padding, this changes the padding to the same value for left or right. 
We could change the padding depending on where the scrollbar is, but I don't 
think that would be an improvement.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26686

To: ahiemstra, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 377 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/377/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 10:05:23 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 668 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/668/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 10:06:41 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtestName: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report15%
(12/79)17%
(62/365)17%
(62/365)13%
(4089/31449)10%
(1911/18969)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.emojier0%
(0/1)0%
(0/1)0%
(0/185)0%
(0/82)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1098)0%
(0/620)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/356)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/320)0%
(0/244)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2350)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26544#595312 , @meven wrote:
  
  > In D26544#595269 , @leinir wrote:
  >
  > > In D26544#595246 , @bcooksley 
wrote:
  > >
  > > > Cancel that, it fails to build on Linux as well - i'm guessing that the 
KNetstuff changes have not been landed?
  > >
  > >
  > > The KNS changes have indeed not been landed yet
  >
  >
  > Please revert this temporally, it breaks all build of master plasma-desktop
  
  
  The problem is that a small part of it depends on functionality to exist 
master which doesn't currently exist - specifically D26543 
. I've pushed a thing that works around 
this, which can be reverted once said code has become available in the CI.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: meven, bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26688: WIP: [Night Color] Display time when the next transition will start

[Vlad Zahorodnii]

zzag updated this revision to Diff 73686.
zzag added a comment.


  - Use i18nc().

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26688?vs=73685=73686

BRANCH
  show-next-transition-timings

REVISION DETAIL
  https://phabricator.kde.org/D26688

AFFECTED FILES
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h

To: zzag, #plasma, #vdg
Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 376 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/376/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 09:14:31 +
 Build duration:
50 min and counting
   CONSOLE OUTPUT
  [...truncated 2954 lines...][2020-01-16T10:05:14.591Z]  ^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:310:24: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2020-01-16T10:05:14.591Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2020-01-16T10:05:14.591Z]^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2020-01-16T10:05:14.591Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2020-01-16T10:05:14.591Z]   ^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-01-16T10:05:14.591Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-01-16T10:05:14.591Z]^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-01-16T10:05:14.591Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-01-16T10:05:14.591Z]  ^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:310:34: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2020-01-16T10:05:14.591Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2020-01-16T10:05:14.591Z]  ^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2020-01-16T10:05:14.591Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2020-01-16T10:05:14.591Z]^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-01-16T10:05:14.591Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-01-16T10:05:14.591Z]  ^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:310:60: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2020-01-16T10:05:14.591Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2020-01-16T10:05:14.591Z]^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2020-01-16T10:05:14.591Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2020-01-16T10:05:14.591Z]   ^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-01-16T10:05:14.591Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-01-16T10:05:14.591Z]^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-01-16T10:05:14.591Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-01-16T10:05:14.591Z]  ^[2020-01-16T10:05:14.591Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:310:94: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2020-01-16T10:05:14.591Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2020-01-16T10:05:14.591Z]  ^[2020-01-16T10:05:14.591Z] 

D26688: WIP: [Night Color] Display time when the next transition will start

[Vlad Zahorodnii]

zzag updated this revision to Diff 73685.
zzag added a comment.


  - Add Monitor.NeutralTemperature constant
  - Display locale time
  - Nate's suggestion

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26688?vs=73616=73685

BRANCH
  show-next-transition-timings

REVISION DETAIL
  https://phabricator.kde.org/D26688

AFFECTED FILES
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h

To: zzag, #plasma, #vdg
Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 667 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/667/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 09:41:14 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 2754 lines...][2020-01-16T09:50:22.762Z] Scanning dependencies of target kcm_clock[2020-01-16T09:50:22.762Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/kcm_clock_autogen/mocs_compilation.cpp.o[2020-01-16T09:50:24.688Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:50:24.688Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/EWIEGA46WW/moc_dtime.cpp:9,[2020-01-16T09:50:24.688Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/mocs_compilation.cpp:2:[2020-01-16T09:50:24.688Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h: In member function ���void Ui_DateAndTime::setupUi(QWidget*)���:[2020-01-16T09:50:24.688Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:157:47: warning: ���K4TimeZoneWidget::K4TimeZoneWidget(QWidget*, KTimeZones*)��� is deprecated [-Wdeprecated-declarations][2020-01-16T09:50:24.688Z]   157 | tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-16T09:50:24.688Z]   |   ^[2020-01-16T09:50:24.688Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:26,[2020-01-16T09:50:24.688Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:50:24.688Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/EWIEGA46WW/moc_dtime.cpp:9,[2020-01-16T09:50:24.688Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/mocs_compilation.cpp:2:[2020-01-16T09:50:24.688Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:41: note: declared here[2020-01-16T09:50:24.688Z]73 | KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-16T09:50:24.688Z]   | ^~~~[2020-01-16T09:50:24.947Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/dtime.cpp.o[2020-01-16T09:50:26.879Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:50:26.879Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.cpp:26:[2020-01-16T09:50:26.879Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h: In member function ���void Ui_DateAndTime::setupUi(QWidget*)���:[2020-01-16T09:50:26.879Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:157:47: warning: ���K4TimeZoneWidget::K4TimeZoneWidget(QWidget*, KTimeZones*)��� is deprecated [-Wdeprecated-declarations][2020-01-16T09:50:26.879Z]   157 | tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-16T09:50:26.879Z]   |   ^[2020-01-16T09:50:26.879Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:26,[2020-01-16T09:50:26.879Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:50:26.879Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.cpp:26:[2020-01-16T09:50:26.879Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:41: note: declared here[2020-01-16T09:50:26.879Z]73 | KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-16T09:50:26.879Z]   | ^~~~[2020-01-16T09:50:30.199Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/main.cpp.o[2020-01-16T09:50:31.614Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:50:31.614Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/main.cpp:37:[2020-01-16T09:50:31.614Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart added a comment.


  In D26655#595102 , @ndavis wrote:
  
  > I noticed that when hovering on the scrollbar border, while the view area 
is not focused, the scrollbar handle is light gray (Breeze Dark, dark gray for 
Breeze) instead of blue. Moving the mouse just slightly more to the right turns 
the scrollbar handle blue.
  
  
  That's the difference between thesubControlRect of the handle (that has been 
moved by one pixel to the right for the line) and the rectangle of the entire 
scrollbar.
  
  to change this and have the handle always hitting, the subcontrolrects should 
stay the same and just paint the handle moved by one pixeltough the subcontrol 
rects not moving.
  either is good, probably the latter approach looks a bit dirtier in the code 
but if you think is better from a design pov, it can be done

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Méven Car]

meven added a comment.


  In D26544#595269 , @leinir wrote:
  
  > In D26544#595246 , @bcooksley 
wrote:
  >
  > > Cancel that, it fails to build on Linux as well - i'm guessing that the 
KNetstuff changes have not been landed?
  >
  >
  > The KNS changes have indeed not been landed yet
  
  
  Please revert this temporally, it breaks all build of master plasma-desktop

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: meven, bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 666 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/666/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 09:28:11 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 2754 lines...][2020-01-16T09:40:16.421Z] Scanning dependencies of target kcm_clock[2020-01-16T09:40:16.421Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/kcm_clock_autogen/mocs_compilation.cpp.o[2020-01-16T09:40:18.382Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:40:18.382Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/EWIEGA46WW/moc_dtime.cpp:9,[2020-01-16T09:40:18.382Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/mocs_compilation.cpp:2:[2020-01-16T09:40:18.382Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h: In member function ���void Ui_DateAndTime::setupUi(QWidget*)���:[2020-01-16T09:40:18.382Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:157:47: warning: ���K4TimeZoneWidget::K4TimeZoneWidget(QWidget*, KTimeZones*)��� is deprecated [-Wdeprecated-declarations][2020-01-16T09:40:18.382Z]   157 | tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-16T09:40:18.382Z]   |   ^[2020-01-16T09:40:18.382Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:26,[2020-01-16T09:40:18.382Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:40:18.382Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/EWIEGA46WW/moc_dtime.cpp:9,[2020-01-16T09:40:18.382Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/mocs_compilation.cpp:2:[2020-01-16T09:40:18.382Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:41: note: declared here[2020-01-16T09:40:18.382Z]73 | KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-16T09:40:18.382Z]   | ^~~~[2020-01-16T09:40:18.658Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/dtime.cpp.o[2020-01-16T09:40:20.038Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:40:20.038Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.cpp:26:[2020-01-16T09:40:20.038Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h: In member function ���void Ui_DateAndTime::setupUi(QWidget*)���:[2020-01-16T09:40:20.038Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:157:47: warning: ���K4TimeZoneWidget::K4TimeZoneWidget(QWidget*, KTimeZones*)��� is deprecated [-Wdeprecated-declarations][2020-01-16T09:40:20.038Z]   157 | tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-16T09:40:20.038Z]   |   ^[2020-01-16T09:40:20.038Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:26,[2020-01-16T09:40:20.038Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:40:20.038Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.cpp:26:[2020-01-16T09:40:20.038Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:41: note: declared here[2020-01-16T09:40:20.038Z]73 | KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-16T09:40:20.038Z]   | ^~~~[2020-01-16T09:40:22.557Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/main.cpp.o[2020-01-16T09:40:23.966Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:40:23.966Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/main.cpp:37:[2020-01-16T09:40:23.966Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 

D26684: [Notifications KCM] Add docbook for new KCM

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:75481705c68e: [Notifications KCM] Add docbook for new KCM 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26684?vs=73618=73681#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26684?vs=73618=73681

REVISION DETAIL
  https://phabricator.kde.org/D26684

AFFECTED FILES
  doc/kcontrol/notifications/CMakeLists.txt
  doc/kcontrol/notifications/index.docbook

To: broulik, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 665 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/665/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 09:14:31 +
 Build duration:
6 min 45 sec and counting
   CONSOLE OUTPUT
  [...truncated 2743 lines...][2020-01-16T09:20:30.507Z] Scanning dependencies of target kcm_clock[2020-01-16T09:20:30.507Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/kcm_clock_autogen/mocs_compilation.cpp.o[2020-01-16T09:20:31.870Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:20:31.870Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/EWIEGA46WW/moc_dtime.cpp:9,[2020-01-16T09:20:31.870Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/mocs_compilation.cpp:2:[2020-01-16T09:20:31.870Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h: In member function ���void Ui_DateAndTime::setupUi(QWidget*)���:[2020-01-16T09:20:31.871Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:157:47: warning: ���K4TimeZoneWidget::K4TimeZoneWidget(QWidget*, KTimeZones*)��� is deprecated [-Wdeprecated-declarations][2020-01-16T09:20:31.871Z]   157 | tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-16T09:20:31.871Z]   |   ^[2020-01-16T09:20:31.871Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:26,[2020-01-16T09:20:31.871Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:20:31.871Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/EWIEGA46WW/moc_dtime.cpp:9,[2020-01-16T09:20:31.871Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/kcm_clock_autogen/mocs_compilation.cpp:2:[2020-01-16T09:20:31.871Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:41: note: declared here[2020-01-16T09:20:31.871Z]73 | KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-16T09:20:31.871Z]   | ^~~~[2020-01-16T09:20:32.128Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/dtime.cpp.o[2020-01-16T09:20:33.493Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:20:33.493Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.cpp:26:[2020-01-16T09:20:33.493Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h: In member function ���void Ui_DateAndTime::setupUi(QWidget*)���:[2020-01-16T09:20:33.493Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:157:47: warning: ���K4TimeZoneWidget::K4TimeZoneWidget(QWidget*, KTimeZones*)��� is deprecated [-Wdeprecated-declarations][2020-01-16T09:20:33.493Z]   157 | tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-16T09:20:33.493Z]   |   ^[2020-01-16T09:20:33.493Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/dateandtime/ui_dateandtime.h:26,[2020-01-16T09:20:33.493Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:20:33.494Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.cpp:26:[2020-01-16T09:20:33.494Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:41: note: declared here[2020-01-16T09:20:33.494Z]73 | KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-16T09:20:33.494Z]   | ^~~~[2020-01-16T09:20:36.032Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/main.cpp.o[2020-01-16T09:20:37.403Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/dtime.h:25,[2020-01-16T09:20:37.403Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/dateandtime/main.cpp:37:[2020-01-16T09:20:37.403Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 

D26702: [MPRIS Data Engine] Support player proxying for another one

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Plasma Browser Integration provides controls for Chrome, so when a player 
with `kde:pid` metadata is found, it is preferred over the actual pid it 
represents.

TEST PLAN
  Still behaves as before:
  
  - It never switches away from a playing player when another starts playing
  - It switches to a playing player if there was none before
  - When current player gets paused, it switches to another playing one, if 
any, or a paused one, if any, or a stopped one, if any. When the current player 
gets paused and there is no playing one, it makes sure to prefer the paused 
proxy over another random paused player.
  - Closing a player, switches to another play one, if any, or a paused one, if 
any, or a stopped one, if any
  - Verified that it never used Chrome's broken mpris when p-b-i was running
  - When disabling p-b-i controls were transferred to Chrome's own mpris

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26702

AFFECTED FILES
  dataengines/mpris2/multiplexer.cpp
  dataengines/mpris2/multiplexer.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart