D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

[Filip Fila]

filipf accepted this revision.
filipf added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ToolTipInstance.qml:123
>  opacity: 0.75
> -visible: !hasPlayer && text.length !== 0
> +visible: !hasPlayer && text.length !== 0 && text != 
> appNameHeading.text
>  }

I think they want us using !== now

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-be-redundant-in-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27273

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Before-and-after pictures below should be self-explanatory:

TEST PLAN
  Before: F8094802: Before.png 
  After: F8094803: After.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-be-redundant-in-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27273

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c8a7a3bd98a8: Scroll the truncated song/artist text when 
long hovering over it (authored by trmdi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=75321=75322

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

trmdi updated this revision to Diff 75321.
trmdi added a comment.


  - Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=75287=75321

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27262: Reduce blank space inside tooltip's header

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5be0b548b6ed: Reduce blank space inside tooltips 
header (authored by trmdi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27262?vs=75288=75320

REVISION DETAIL
  https://phabricator.kde.org/D27262

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, davidedmundson, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 33 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/33/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 10 Feb 2020 03:28:19 +
 Build duration:
19 min and counting
   CONSOLE OUTPUT
  [...truncated 339 lines...][2020-02-10T03:47:41.589Z]  * PkgConfig[2020-02-10T03:47:41.589Z]  * Fontconfig[2020-02-10T03:47:41.589Z] [2020-02-10T03:47:41.589Z] -- The following REQUIRED packages have been found:[2020-02-10T03:47:41.589Z] [2020-02-10T03:47:41.589Z]  * ECM (required version >= 5.66.0)[2020-02-10T03:47:41.589Z]  * Qt5Gui[2020-02-10T03:47:41.589Z]  * Qt5 (required version >= 5.12.0)[2020-02-10T03:47:41.589Z]  * Qt5Widgets (required version >= 5.12.0)[2020-02-10T03:47:41.589Z]  * KF5ConfigWidgets (required version >= 5.66.0)[2020-02-10T03:47:41.589Z]  * Qt5Core (required version >= 5.12.0)[2020-02-10T03:47:41.589Z]  * KF5DocTools (required version >= 5.66.0)[2020-02-10T03:47:41.589Z]  * Gettext[2020-02-10T03:47:41.589Z]  * KF5I18n (required version >= 5.66.0)[2020-02-10T03:47:41.589Z]  * KF5 (required version >= 5.66.0)[2020-02-10T03:47:41.589Z]  * X11[2020-02-10T03:47:41.589Z] [2020-02-10T03:47:41.589Z] -- Configuring done[2020-02-10T03:47:41.589Z] -- Generating done[2020-02-10T03:47:41.589Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-10T03:47:42.358Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kgamma5 --branchGroup stable-kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-02-10T03:47:42.628Z] Scanning dependencies of target kcm_kgamma_autogen[2020-02-10T03:47:42.628Z] [ 11%] Automatic MOC for target kcm_kgamma[2020-02-10T03:47:43.219Z] [ 11%] Built target kcm_kgamma_autogen[2020-02-10T03:47:43.219Z] Scanning dependencies of target doc-index-cache-bz2[2020-02-10T03:47:43.219Z] [ 22%] Generating index.cache.bz2[2020-02-10T03:47:44.166Z] [ 22%] Built target doc-index-cache-bz2[2020-02-10T03:47:44.166Z] Scanning dependencies of target kcm_kgamma[2020-02-10T03:47:44.166Z] [ 33%] Building CXX object kcmkgamma/CMakeFiles/kcm_kgamma.dir/kcm_kgamma_autogen/mocs_compilation.cpp.o[2020-02-10T03:47:45.568Z] [ 44%] Building CXX object kcmkgamma/CMakeFiles/kcm_kgamma.dir/kgamma.cpp.o[2020-02-10T03:47:48.128Z] [ 55%] Building CXX object kcmkgamma/CMakeFiles/kcm_kgamma.dir/gammactrl.cpp.o[2020-02-10T03:47:49.523Z] [ 66%] Building CXX object kcmkgamma/CMakeFiles/kcm_kgamma.dir/displaynumber.cpp.o[2020-02-10T03:47:51.473Z] [ 77%] Building CXX object kcmkgamma/CMakeFiles/kcm_kgamma.dir/xvidextwrap.cpp.o[2020-02-10T03:47:52.941Z] [ 88%] Building CXX object kcmkgamma/CMakeFiles/kcm_kgamma.dir/xf86configpath.cpp.o[2020-02-10T03:47:53.538Z] [100%] Linking CXX shared module ../bin/kcm_kgamma.so[2020-02-10T03:47:54.140Z] [100%] Built target kcm_kgamma[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[2020-02-10T03:48:01.736Z] + python3 -u ci-tooling/helpers/install-build.py --product Plasma --project kgamma5 --branchGroup stable-kf5-qt5 --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/ --divertTo '/home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/install-divert/'[2020-02-10T03:48:02.022Z] [ 11%] Automatic MOC for target kcm_kgamma[2020-02-10T03:48:02.319Z] [ 11%] Built target kcm_kgamma_autogen[2020-02-10T03:48:02.319Z] [ 22%] Built target doc-index-cache-bz2[2020-02-10T03:48:02.319Z] [100%] Built target kcm_kgamma[2020-02-10T03:48:02.319Z] Install the project...[2020-02-10T03:48:02.319Z] -- Install configuration: "Debug"[2020-02-10T03:48:02.319Z] -- Installing: /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/plugins/kcm_kgamma.so[2020-02-10T03:48:02.319Z] -- Set runtime path of "/home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/install-divert//home/jenkins/install-prefix/lib64/plugins/kcm_kgamma.so" to "/home/jenkins/install-prefix/lib64"[2020-02-10T03:48:02.319Z] -- Installing: /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/kservices5/kgamma.desktop[2020-02-10T03:48:02.319Z] -- Installing: /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/kgamma/pics/background.png[2020-02-10T03:48:02.319Z] -- Installing: /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/kgamma/pics/cmyscale.png[2020-02-10T03:48:02.319Z] -- Installing: /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/kgamma/pics/darkgrey.png[2020-02-10T03:48:02.319Z] -- Installing: /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 57 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/57/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 10 Feb 2020 03:28:15 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2587)14%
(212/1505)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/165)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1249)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/259)0%
(0/138)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.13/4/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 10 Feb 2020 01:39:43 +
 Build duration:
11 min and counting

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack updated this revision to Diff 75318.
cblack added a comment.


  Use ColorButton

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27271?vs=75317=75318

BRANCH
  accent-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27271

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/editor/scmeditorcolors.cpp
  kcms/colors/package/contents/ui/main.qml

To: cblack, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  accent-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27271

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/editor/scmeditorcolors.cpp
  kcms/colors/package/contents/ui/main.qml

To: cblack, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham added a comment.


  Hmm, good point. Should we not fix the bug in the PC3 toolbutton? How should 
we proceed?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27265: Use Kirigami.PasswordField instead of plain text field

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:5fbc994c959a: Use Kirigami.PasswordField instead of plain 
text field (authored by ognarb).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27265?vs=75301=75316

REVISION DETAIL
  https://phabricator.kde.org/D27265

AFFECTED FILES
  mobile/wifi/package/contents/ui/PasswordField.qml

To: ognarb, jgrulich, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Thanks, and sorry for wasting your time :x

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 75315.
gvgeo added a comment.


  Up it goes again

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26806?vs=75297=75315

BRANCH
  b4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26806

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  you can close this task if you want, after talking a bit over T10470 
 it's better to use headers instead of 
footers

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27199: [WIP][Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo planned changes to this revision.
gvgeo added a comment.


  Background margins and big connect button is a problem. Other themes break as 
it is now.
  Also creates an awkward empty space between label and details. Which 
direction to take?
  
  1. Remove button and replace with a text. Bold when hover to click.
  2. Remove listitem background.
  3. Increase the available connections height, to match the other's height.
  4. Something else?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:c4b41ffe6660: Have authhelper define config file paths on 
its own (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27142?vs=75005=75309

REVISION DETAIL
  https://phabricator.kde.org/D27142

AFFECTED FILES
  sddmauthhelper.cpp
  src/sddmkcm.cpp
  src/sddmkcm.h

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 334 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/334/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 09 Feb 2020 18:15:11 +
 Build duration:
4 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.discover Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.discover.autotests.toplevelsName: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report72%
(13/18)70%
(74/105)70%
(74/105)62%
(3575/5747)48%
(1697/3542)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover100%
(12/12)100%
(12/12)75%
(589/783)55%
(255/466)discover.autotests100%
(1/1)100%
(1/1)100%
(100/100)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/65)0%
(0/40)libdiscover71%
(5/7)71%
(5/7)79%
(218/275)64%
(118/183)libdiscover.Category100%
(5/5)100%
(5/5)67%
(164/244)48%
(111/230)libdiscover.ReviewsBackend100%
(7/7)100%
(7/7)86%
(197/228)77%
(56/73)libdiscover.Transaction88%
(7/8)88%
(7/8)79%
(236/298)69%
(99/144)libdiscover.UpdateModel100%
(3/3)100%
(3/3)91%
(224/247)74%
(92/125)libdiscover.appstream0%
(0/5)0%
(0/5)0%
(0/244)0%
(0/128)libdiscover.backends.DummyBackend73%
(8/11)73%
(8/11)83%
(261/315)75%
(124/166)libdiscover.backends.DummyBackend.tests100%
(2/2)100%
(2/2)97%
(250/259)53%
(143/268)libdiscover.backends.FwupdBackend0%
(0/8)0%
(0/8)0%
(0/553)0%
(0/267)libdiscover.backends.KNSBackend100%
(5/5)100%
(5/5)59%
(348/588)43%
(139/327)libdiscover.backends.KNSBackend.tests100%
(1/1)100%
(1/1)98%
(90/92)55%
(63/114)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/7)0%
(0/2)libdiscover.resources94%

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 187 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/187/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 09 Feb 2020 18:15:11 +
 Build duration:
3 min 28 sec and counting
   JUnit Tests
  Name: projectroot.discover Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.discover.autotests.toplevelsName: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27262: Reduce blank space inside tooltip's header

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Shipit!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reduce-tooltip-blank-space (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27262

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, davidedmundson, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27266: [libtaskmanager] Fix shared VirtualDesktopInfo::Private tied to the 1st creator

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  VirtualDesktopInfo::Private is ref counted and shared between N
  VirtualDesktopInfo's.
  
  We were passing the first VirtualDesktopInfo as a parent to
  VirtualDesktopInfo::Private which didn't manage the lifespan or do
  anything useful.
  
  The wayland backend incorrectly used this 'q' object and spanned
  mulitple internal objects and connections to the first object that
  created the shared private instance, leaving us with dangly objects
  inside.
  
  BUG: 415200
  (and possibly several other bugs of wayland task manager not updating
  correctly)

TEST PLAN
  Compiles
  Plasma still loads

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27266

AFFECTED FILES
  libtaskmanager/virtualdesktopinfo.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27262: Reduce blank space inside tooltip's header

[Tranter Madi]

trmdi added a subscriber: ngraham.
trmdi added a comment.


  Do you have any objection @ngraham ?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reduce-tooltip-blank-space (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27262

To: trmdi, #plasma, #vdg, ndavis
Cc: ngraham, davidedmundson, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27261: [Folder view] Fix binding loop on width

[George Vogiatzis]

gvgeo added a comment.


  This removes the smallSpacing. Text will touch the edges.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27261

To: ngraham, #plasma
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27265: Use Kirigami.PasswordField instead of plain text field

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
ognarb requested review of this revision.

REVISION SUMMARY
  Allow showing the plain text password when typing (optional)

TEST PLAN
  :(

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  passwordfield

REVISION DETAIL
  https://phabricator.kde.org/D27265

AFFECTED FILES
  mobile/wifi/package/contents/ui/PasswordField.qml

To: ognarb, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27260: [applets/systemtray] Set pin button's size correctly

[David Edmundson]

davidedmundson added a comment.


  workspace changes required as a result of a frameworks change raises questions
  
  What happens to users of Plasma 5.17 with the D27221 
 applied and not this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27264: Fix tabbar width computation

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c31e7ea68957: Fix tabbar width computation (authored by 
cordlandwehr).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27264?vs=75299=75300

REVISION DETAIL
  https://phabricator.kde.org/D27264

AFFECTED FILES
  src/controls/private/globaltoolbar/TabBarControl.qml

To: cordlandwehr, mart, davidedmundson
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27264: Fix typo in Math call

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
cordlandwehr added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cordlandwehr requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  bugfix/widthComputation

REVISION DETAIL
  https://phabricator.kde.org/D27264

AFFECTED FILES
  src/controls/private/globaltoolbar/TabBarControl.qml

To: cordlandwehr, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 75297.
gvgeo added a comment.


  Small improvement of Power Managment checkbox's tooltip code.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26806?vs=74347=75297

BRANCH
  b3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26806

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Alexander Lohnau]

alex added a comment.


  No problem, thanks for reviewing :-)

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann added a comment.


  Upsa ;) missed that this is in plasma addons, not in the session launcher 
applet we have in our repo, ignore my comment about the invent stuff ;=)

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann added a comment.


  Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, 
but I will just apply this via arc.

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Improved output seems fine for me, thanks for taking care.

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[George Vogiatzis]

gvgeo added a comment.


  The was plan to move them all to the bottom, and there are patches for most 
of them. There is a recent small discussion about it in T10470 
.

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[George Vogiatzis]

gvgeo updated this revision to Diff 75293.
gvgeo added a comment.


  For some reason arc send both patches together here.
  Updated with diff.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27257?vs=75291=75293

REVISION DETAIL
  https://phabricator.kde.org/D27257

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[Anthony Fieroni]

anthonyfieroni added a comment.


  Why? That's make huge inconsistency, bluetooth applet has it on top, battery 
and brightness too.

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27262: Reduce blank space inside tooltip's header

[David Edmundson]

davidedmundson added a comment.


  Code wise, no objections. Needs vdg to approve visual changes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27262

To: trmdi, #plasma, #vdg
Cc: davidedmundson, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[George Vogiatzis]

gvgeo updated this revision to Diff 75291.
gvgeo edited the test plan for this revision.
gvgeo added a comment.


  Requested change

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27257?vs=75279=75291

BRANCH
  flip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27257

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27262: Reduce blank space inside tooltip's header

[Noah Davis]

ndavis added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27262

To: trmdi, #plasma, #vdg
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart