D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo planned changes to this revision.
gvgeo added a comment.


  Clicking and  highlight only on the main row, and only when hover.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27337: [Emojier] Optimize performance

[David Edmundson]

davidedmundson added a comment.


  Delegates are already async loaded. What does nesting a loader provide on top?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27337

To: Zren, apol, #plasma
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

[Marijo Mustac]

mmustac added a comment.


  Wouldn't it look better to use the new header/title component for the list 
view ?
  F8099139: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: mmustac, davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, domson, ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, abrahams, sebas, 
apol, ahiemstra, mart

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in ExpandedRepresentation.qml:145-148
> https://github.com/qt/qtdeclarative/blob/9893e71cea5de10193376c1733db627ef0783614/src/quick/items/qquickimage.cpp#L600-L603

That says the opposite of what you want.

We want image's texture provider to be used directly. Only then will this 
sourcesize matter.

This is saying when layer effect is enabled it uses the base blitting path.

We don't want to use layer here, we want the image as a source to the blur 
directly

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin, ngraham
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

[Nathaniel Graham]

ngraham added a comment.


  That turned out to be an unrelated Baloo bug that was recently fixed by 
D27326 .
  
  This is ready for re-review.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, domson, ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, 
ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

[Nathaniel Graham]

ngraham updated this revision to Diff 75508.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25447?vs=73775=75508

BRANCH
  suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25447

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, domson, ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, 
ahiemstra, mart

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

[Nathaniel Graham]

ngraham added a comment.


  @mart ping

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: alexde, ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 165 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/165/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 04:33:33 +
 Build duration:
7 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 296 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/296/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 12 Feb 2020 04:33:28 +
 Build duration:
5 min 28 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.68.0.xmlacc/KF5PlasmaQuick-5.68.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)37%
(47/126)37%
(47/126)35%
(4667/13383)26%
(2524/9696)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(869/916)52%
(439/852)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/472)0%
(0/245)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(774/2330)27%
(396/1489)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1520/3565)33%
(952/2894)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(756/1577)36%
(373/1045)src.plasma.scripting67%
(2/3)67%
(2/3)26%
(46/176)18%
(19/105)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick38%
(5/13)38%
(5/13)29%
(609/2086)19%
(335/1737)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid14%
(1/7)14%
(1/7)1%
(13/1185)0%
(0/994)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
 

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 300 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/300/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 12 Feb 2020 04:33:32 +
 Build duration:
5 min 22 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.68.0.xmlacc/KF5PlasmaQuick-5.67.0.xmllogs/KF5Plasma/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)37%
(47/126)37%
(47/126)35%
(4666/13383)26%
(2529/9696)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(868/916)51%
(438/852)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/472)0%
(0/245)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(774/2330)27%
(402/1489)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1520/3565)33%
(952/2894)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(756/1577)36%
(373/1045)src.plasma.scripting67%
(2/3)67%
(2/3)26%
(46/176)18%
(19/105)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick38%
(5/13)38%
(5/13)29%
(609/2086)19%
(335/1737)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid14%
(1/7)14%
(1/7)1%
(13/1185)0%
(0/994)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 167 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/167/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 04:33:31 +
 Build duration:
5 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

D27271: [kcms/colors] RFC: Accent Colours

[Nathaniel Graham]

ngraham added a comment.


  Looks like plasma doesn't respect the accent color.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ExpandedRepresentation.qml:261
> +}
> +PlasmaExtras.Heading { // Song Album
> +color: (softwareRendering || !albumArt.visible) ? 
> PlasmaCore.ColorScope.textColor : "white"

there's a massive binding loop somewhere here:

  
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.mediacontroller/contents/ui/ExpandedRepresentation.qml:261:21:
 QML Heading: Binding loop detected for property "height"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin, ngraham
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27282: [Applet]Correct raise max volume functions for mic

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Everyone else good with this?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27282

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

[Nathaniel Graham]

ngraham added a comment.


  Overall looks much better I think! However the minimum height seems to be a 
bit tall now: F8098822: Screenshot_20200211_203232.png 

  
  Also I have a hard time putting my finger on why, but somehow the scrubber 
not filling the full width feels odd to me, especially when the applet is wider 
than it is tall: F8098826: Screenshot_20200211_203341.PNG 

  
  When the scrubber is the same width as the player controls below it, it seems 
fine. But when the window is wider and they no longer align vertically, it 
doesn't feel quite right to me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 299 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/299/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 12 Feb 2020 03:09:57 +
 Build duration:
2 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 267 lines...][2020-02-12T03:12:12.166Z] -- Detecting CXX compiler ABI info - done[2020-02-12T03:12:12.166Z] -- Detecting CXX compile features[2020-02-12T03:12:12.166Z] -- Detecting CXX compile features - done[2020-02-12T03:12:12.166Z] -- [2020-02-12T03:12:12.166Z] [2020-02-12T03:12:12.423Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:12:12.423Z] -- Looking for __GLIBC__[2020-02-12T03:12:12.423Z] -- Looking for __GLIBC__ - found[2020-02-12T03:12:12.423Z] -- Performing Test _OFFT_IS_64BIT[2020-02-12T03:12:12.681Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-12T03:12:12.681Z] -- Performing Test HAVE_DATE_TIME[2020-02-12T03:12:12.681Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-12T03:12:12.937Z] -- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.67.0") [2020-02-12T03:12:12.937Z] -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.67.0") [2020-02-12T03:12:12.937Z] -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.67.0") [2020-02-12T03:12:12.937Z] -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.67.0") [2020-02-12T03:12:12.937Z] -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.67.0") [2020-02-12T03:12:12.937Z] -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.67.0") [2020-02-12T03:12:12.937Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:12:12.937Z] -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.67.0") [2020-02-12T03:12:12.937Z] -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.67.0") [2020-02-12T03:12:12.937Z] -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2020-02-12T03:12:13.195Z] -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.68.0") [2020-02-12T03:12:13.195Z] -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:12:13.195Z] -- Found KF5Package: /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found KF5Kirigami2: /home/jenkins/install-prefix/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found KF5Wayland: /home/jenkins/install-prefix/lib64/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.68.0") [2020-02-12T03:12:13.195Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.67.0") [2020-02-12T03:12:13.195Z] -- Found KF5: success (found suitable version "5.67.0", minimum required is "5.67.0") found components: Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools 

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 166 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/166/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 03:09:57 +
 Build duration:
1 min 55 sec and counting
   CONSOLE OUTPUT
  [...truncated 189 lines...][2020-02-12T03:11:49.213Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-12T03:11:49.213Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-12T03:11:49.213Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-12T03:11:49.213Z] [2020-02-12T03:11:49.213Z] [2020-02-12T03:11:49.213Z] == Commencing Configuration:[2020-02-12T03:11:49.213Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13"[2020-02-12T03:11:49.471Z] -- The C compiler identification is Clang 8.0.1[2020-02-12T03:11:49.471Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-12T03:11:49.471Z] -- Check for working C compiler: /usr/bin/cc[2020-02-12T03:11:49.471Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-12T03:11:49.471Z] -- Detecting C compiler ABI info[2020-02-12T03:11:49.731Z] -- Detecting C compiler ABI info - done[2020-02-12T03:11:49.731Z] -- Detecting C compile features[2020-02-12T03:11:49.731Z] -- Detecting C compile features - done[2020-02-12T03:11:49.731Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-12T03:11:49.731Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-12T03:11:49.731Z] -- Detecting CXX compiler ABI info[2020-02-12T03:11:49.731Z] -- Detecting CXX compiler ABI info - done[2020-02-12T03:11:49.731Z] -- Detecting CXX compile features[2020-02-12T03:11:49.731Z] -- Detecting CXX compile features - done[2020-02-12T03:11:49.731Z] -- [2020-02-12T03:11:49.731Z] [2020-02-12T03:11:49.731Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:11:49.731Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-12T03:11:49.731Z] -- Looking for __GLIBC__[2020-02-12T03:11:49.991Z] -- Looking for __GLIBC__ - not found[2020-02-12T03:11:49.991Z] -- Performing Test _OFFT_IS_64BIT[2020-02-12T03:11:49.991Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-12T03:11:49.991Z] -- Performing Test HAVE_DATE_TIME[2020-02-12T03:11:49.991Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-12T03:11:50.252Z] -- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:11:50.252Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2020-02-12T03:11:50.252Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.68.0") [2020-02-12T03:11:50.252Z] -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found 

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 164 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/164/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 03:09:57 +
 Build duration:
1 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 189 lines...][2020-02-12T03:11:34.147Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-12T03:11:34.147Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-12T03:11:34.147Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-12T03:11:34.147Z] [2020-02-12T03:11:34.147Z] [2020-02-12T03:11:34.147Z] == Commencing Configuration:[2020-02-12T03:11:34.147Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13"[2020-02-12T03:11:34.405Z] -- The C compiler identification is Clang 8.0.1[2020-02-12T03:11:34.405Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-12T03:11:34.405Z] -- Check for working C compiler: /usr/bin/cc[2020-02-12T03:11:34.405Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-12T03:11:34.405Z] -- Detecting C compiler ABI info[2020-02-12T03:11:34.405Z] -- Detecting C compiler ABI info - done[2020-02-12T03:11:34.405Z] -- Detecting C compile features[2020-02-12T03:11:34.405Z] -- Detecting C compile features - done[2020-02-12T03:11:34.405Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-12T03:11:34.661Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-12T03:11:34.661Z] -- Detecting CXX compiler ABI info[2020-02-12T03:11:34.661Z] -- Detecting CXX compiler ABI info - done[2020-02-12T03:11:34.661Z] -- Detecting CXX compile features[2020-02-12T03:11:34.661Z] -- Detecting CXX compile features - done[2020-02-12T03:11:34.661Z] -- [2020-02-12T03:11:34.661Z] [2020-02-12T03:11:34.661Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:11:34.661Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-12T03:11:34.661Z] -- Looking for __GLIBC__[2020-02-12T03:11:34.661Z] -- Looking for __GLIBC__ - not found[2020-02-12T03:11:34.661Z] -- Performing Test _OFFT_IS_64BIT[2020-02-12T03:11:34.661Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-12T03:11:34.661Z] -- Performing Test HAVE_DATE_TIME[2020-02-12T03:11:34.972Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-12T03:11:34.972Z] -- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:11:34.972Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2020-02-12T03:11:34.972Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.67.0") [2020-02-12T03:11:34.972Z] -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.67.0") 

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 295 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/295/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 12 Feb 2020 03:09:57 +
 Build duration:
1 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 267 lines...][2020-02-12T03:11:37.080Z] -- Detecting CXX compiler ABI info - done[2020-02-12T03:11:37.080Z] -- Detecting CXX compile features[2020-02-12T03:11:37.080Z] -- Detecting CXX compile features - done[2020-02-12T03:11:37.080Z] -- [2020-02-12T03:11:37.080Z] [2020-02-12T03:11:37.080Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:11:37.080Z] -- Looking for __GLIBC__[2020-02-12T03:11:37.340Z] -- Looking for __GLIBC__ - found[2020-02-12T03:11:37.340Z] -- Performing Test _OFFT_IS_64BIT[2020-02-12T03:11:37.340Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-12T03:11:37.340Z] -- Performing Test HAVE_DATE_TIME[2020-02-12T03:11:37.340Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-12T03:11:37.340Z] -- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.340Z] -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.340Z] -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.340Z] -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.340Z] -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.340Z] -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.340Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:11:37.340Z] -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.340Z] -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.340Z] -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2020-02-12T03:11:37.597Z] -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for Plasma.[2020-02-12T03:11:37.597Z] -- Found KF5Package: /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5Kirigami2: /home/jenkins/install-prefix/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5Wayland: /home/jenkins/install-prefix/lib64/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.68.0") [2020-02-12T03:11:37.597Z] -- Found KF5: success (found suitable version "5.68.0", minimum required is "5.67.0") found components: Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package 

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi added a comment.


  Hmm, I think the 1.5 ratio makes a nice shape, the thumbnail is also not too 
small.
  A tooltip has texts and a thumbnail, we needn't too focus in the thumbnail.
  
  F8098753: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Pretty nice. If the list items are no longer going to have a selection 
highlight but still open up/unfold when single-clicked, then the cursor should 
change to a pointing hand when hovering over them.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27337: [Emojier] Optimize performance

[Nathaniel Graham]

ngraham added reviewers: apol, Plasma.
ngraham added a comment.


  Very nice.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27337

To: Zren, apol, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27337: [Emojier] Optimize performance

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  BUG: 417454
  
  The emojier fairly slow. Launching is slow. Resizing the window is slow. 
Changing pages is slow. Scrolling is also slow.
  
  On launch, the sidebar widens from `0px`, resizing the `GridView`, which 
resizes `cellWidth` as we abuse it's the width calculation to create cell 
spacing. Resizing 1000 emoji Labels is slow. This also happens when you resize 
the window. The cpu core spikes to 100% (on a 2.8Ghz cpu).
  
  F8098605: screen-2020-02-11_18.21.04.mp4 

  
  After selecting an emoji, closing, and reopening, the recent emoji's is shown 
first (without a search box) which opens faster since it has much less work. 
However switching to the all emoji page resurfaces the problem.
  
  Scrolling is also a problem, as loading the emoji `QQC2.Label`s is slow. So 
we'll use a `Loader { asynchronous: true }`. I'm not sure why it loads them 
from bottom to top.
  
  Here's what it looks like after this patch. Resizing no longer blocks, nor 
does scrolling.
  
  F8098612: screen-2020-02-11_18.18.37.mp4 


TEST PLAN
  How I compile and run emojier by itself:
  https://gist.github.com/Zren/1d16e51199c9e47718ccfe41755d8ee2

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27337

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml

To: Zren
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

[Will Stephenson]

wstephenson abandoned this revision.
wstephenson added a comment.


  @broulik Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27319

To: wstephenson, hein, davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27078: Drag-and-drop files at the right coordinates

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, nice fix.
  
  #plasma  folks, y'all good with 
this? 5.18 branch?

REVISION DETAIL
  https://phabricator.kde.org/D27078

To: painlessroaster, hein, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

[Kai Uwe Broulik]

broulik added a comment.


  In the "Add Action..." combobox above the comment field at the end you choose 
say "Abandon revision"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27319

To: wstephenson, hein, davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27199: [WIP][Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 75498.
gvgeo added a comment.


  Route no.2
  Added line and Warning messages.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75280=75498

BRANCH
  layout2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

[Will Stephenson]

wstephenson added a comment.


  Changes integrated into https://phabricator.kde.org/D27322 - how do I 
withdraw/close a posted diff in phabricator? :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27319

To: wstephenson, hein, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

[Will Stephenson]

wstephenson added a comment.


  I tried to test dragging multiple windows (as a grouped taskbar entry) but 
this fails at the first test, outside of my changes, so I think there's an 
unrelated bug hiding in TaskManager::XWindowTasksModel::winIdsFromMimeData(), 
which can wait for another patch.

REVISION DETAIL
  https://phabricator.kde.org/D27322

To: wstephenson, davidedmundson, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

[Will Stephenson]

wstephenson updated this revision to Diff 75496.
wstephenson added a comment.


  Implement feedback from d_ed
  
  Integrate logic fix from https://phabricator.kde.org/D27319

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27322?vs=75472=75496

REVISION DETAIL
  https://phabricator.kde.org/D27322

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml
  applets/pager/plugin/pagermodel.cpp
  applets/pager/plugin/pagermodel.h

To: wstephenson, davidedmundson, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Filip Fila]

filipf added a comment.


  In D27329#609851 , @ngraham wrote:
  
  > That's better, though I dunno, I can't shake the feeling that the album art 
is still too compressed.
  
  
  Me too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Nathaniel Graham]

ngraham added a comment.


  That's better, though I dunno, I can't shake the feeling that the album art 
is still too compressed:
  
  F8098251: Screenshot_20200211_113432.png 

  
  Maybe I'm just being crotchety though. #VDG 
 folks, what does everyone else think?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi added a comment.


  We can increase the height a bit, but not sure which ratio is the best.
  Another thing is that, even with a bigger thumbnail, we could hardly see its 
content, so making it bigger doesn't make it more clear.
  
  In D27329#609831 , @ngraham wrote:
  
  > Okay, seeing this in action, I don't hate it. However I feel like my 
concern with the album art being squeezed too much is valid:
  >
  > F8098196: Screenshot_20200211_104708.png 

  >
  > Even the windows previews get squeezed a lot:
  >
  > F8098199: Screenshot_20200211_104800.png 

  >
  > If we're going to do this, I think the rectangle should be either larger or 
taller.
  
  
  We should avoid making it larger, otherwise it looks ugly on small screens.
  Does the 1.5 ratio look better to you?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi updated this revision to Diff 75486.
trmdi added a comment.


  - Increase the height a bit

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27329?vs=75484=75486

BRANCH
  adjust-size-of-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27329

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Okay, seeing this in action, I don't hate it. However I feel like my concern 
with the album art being squeezed too much is valid:
  
  F8098196: Screenshot_20200211_104708.png 

  
  Even the windows previews get squeezed a lot:
  
  F8098199: Screenshot_20200211_104800.png 

  
  If we're going to do this, I think the rectangle should be either larger or 
taller.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

TEST PLAN
  The size of tooltips are not changed between cases
  e.g. a normal window vs a window which is available on all activities,
  e.g. a normal window vs a window which has a player...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  adjust-size-of-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27329

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[George Vogiatzis]

gvgeo added a comment.


  Shadows look fine in wayland. Like many other elements, the problem is with 
X11.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27325: improve some previously recycled strings

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In that case, with kio-fuse, "Mounted shares" is probably more accurate and 
just fine.

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27325

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27325: improve some previously recycled strings

[Harald Sitter]

sitter added a comment.


  That may be misleading expectations I fear. When you browse smb:// in dolphin 
you'd be accessing shares, but they'd not appear in that list ;)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27325

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27325: improve some previously recycled strings

[Nathaniel Graham]

ngraham added a comment.


  "Accessed shares"?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27325

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27325: improve some previously recycled strings

[Harald Sitter]

sitter added a comment.


  I do wonder if "Mounted Shares" is all that grand. Technically they may not 
be mounted but mountable. E.g. when you put a mount into /etc/fstab it will be 
listed here but not necessarily mounted.
  
  Another question is if someone has better suggestions for the column names on 
the that table.
  
  `Resource | Mounted Under | Accessible`
  
  Resource in particular is a bit meh, it'd be the windows share name that was 
mounted so I am not sure there's a better label for it e.g. 
`\\ajax.local\Public`.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27325

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27325: improve some previously recycled strings

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  for 5.18 we recycled these to reduce the new strings, for 5.19 we want
  something more approachable

TEST PLAN
  fancy new strings show up

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27325

AFFECTED FILES
  Modules/samba/main.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[George Vogiatzis]

gvgeo updated this revision to Diff 75476.
gvgeo added a reviewer: VDG.
gvgeo added a comment.


  Rebase.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27316?vs=75453=75476

BRANCH
  shadow2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27316

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: gvgeo, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

[David Edmundson]

davidedmundson added a comment.


  Seems sensible +1

INLINE COMMENTS

> pagermodel.cpp:615
> +// if on >1 activity, remove it from the current 
> activity and add it to the new activity
> +QString currentActivity = 
> d->activityInfo->currentActivity();
> +//qDebug() << id << " is on " << activities << ", 
> removing from " << currentActivity;

const

> pagermodel.cpp:616
> +QString currentActivity = 
> d->activityInfo->currentActivity();
> +//qDebug() << id << " is on " << activities << ", 
> removing from " << currentActivity;
> +activities.removeAll(currentActivity);

please port to qCDebug() and uncomment

(or just remove)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27322

To: wstephenson, davidedmundson, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

[Will Stephenson]

wstephenson created this revision.
wstephenson added reviewers: davidedmundson, Plasma, hein.
wstephenson added a project: Plasma.
Herald added a subscriber: plasma-devel.
wstephenson requested review of this revision.

REVISION SUMMARY
  This allows the familiar file manager semantics of ctrl+drag = copy,
  drag = move to be used when dragging and dropping windows between
  activities using the taskbar and the activity pager applet.

TEST PLAN
  - Move window between activities
  - Setup desktop with two activities, taskbar and activity pager, test window 
on one activity, activate activity with the window on it
  - Drag window's taskbar entry to the other activity's pager item.
  - Observe window moves to other activity
  
  - Add window to another activity
  - Setup remaining from previous test
  - Ctrl-drag window's taskbar entry to the other activity's pager item.
  - Observe window is now on all activities
  
  - Move window from all activities to a single activity
  - Setup remaining from previous test. Window is on all activities
  - Drag window's taskbar entry to an activity pager item
  - Observe window is now only on one activity
  
  - Add window to two out of three activities
  - Setup remaining from previous test. Window is on 1/2 activities
  - Add 3rd activity using Activity Manager
  - Ctrl-drag window's taskbar entry to the new activity.
  - Observe window is now on 2/3 activities
  
  - Move window to a different 2/3 activities
  - Setup remaining from previous test. Window is on 2/3 activities
  - Activate an activity the window is present on
  - Drag window's taskbar entry to the activity it is not on
  - Observe window is now moved to the activity it was dropped on, and is no 
longer on the current activity
  
  - Add window to the only activity it is not on
  - Setup remaining from previous test. Window is on 2/3 activities
  - Activate an activity the window is present on
  - Ctrl-drag window's taskbar entry to the activity it is not on
  - Observe window is now present on all activities

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27322

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml
  applets/pager/plugin/pagermodel.cpp
  applets/pager/plugin/pagermodel.h

To: wstephenson, davidedmundson, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7a0c4f86530f: [applets/taskmanager] Add a bit more 
padding around album/artist info in tooltip (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27303?vs=75425=75473

REVISION DETAIL
  https://phabricator.kde.org/D27303

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, manueljlin, filipf
Cc: ndavis, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fonts.cpp:131
> +for (int t = KXftConfig::SubPixel::None; t <= 
> KXftConfig::SubPixel::Vbgr; ++t) {
> +QStandardItem *item = new 
> QStandardItem(KXftConfig::description((KXftConfig::SubPixel::Type)t));
> +m_subPixelOptionsModel->appendRow(item);

Please no C cast, use static_cast instead.
Also was a good place to use auto (DRY and all that) ;-)

> fonts.cpp:136
> +for (int s = KXftConfig::Hint::None; s <= KXftConfig::Hint::Full; ++s) {
> +QStandardItem * item = new 
> QStandardItem(KXftConfig::description((KXftConfig::Hint::Style)s));
> +m_hintingOptionsModel->appendRow(item);

ditto (and no space after *)

> fontsaasettings.cpp:70
> +FontAASettingsStore(FontsAASettings *parent = nullptr)
> +: QObject(parent)
> +, m_settings(parent)

Wrong indentation

> fontsaasettings.cpp:224
> +bool m_subPixelChanged;
> +int m_hinting;
> +bool m_hintingChanged;

I'd go for the enums all the way until here of course

> fontsaasettings.h:35
> +Q_PROPERTY(int dpi READ dpi WRITE setDpi NOTIFY dpiChanged)
> +Q_PROPERTY(int subPixel READ subPixel WRITE setSubPixel NOTIFY 
> subPixelChanged)
> +Q_PROPERTY(int hinting READ hinting WRITE setHinting NOTIFY 
> hintingChanged)

Why int here and for the next property and not the enum types directly? This 
would avoid the static_cast in KRDB.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27156

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[Nathaniel Graham]

ngraham added a comment.


  Oh gosh, are shadows not scale-aware anywhere? We'd have to replicate this 
code in a lot of places... might it make more sense to fix this in Qt itself?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27261: [Folder view] Fix binding loop on width

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6b1cc98f0959: [Folder view] Fix binding loop on width 
(authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27261?vs=75470=75471

REVISION DETAIL
  https://phabricator.kde.org/D27261

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: ngraham, #plasma, davidedmundson
Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27261: [Folder view] Fix binding loop on width

[Nathaniel Graham]

ngraham updated this revision to Diff 75470.
ngraham added a comment.


  One more

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27261?vs=75469=75470

BRANCH
  fix-folderview-binding-loop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27261

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: ngraham, #plasma, davidedmundson
Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27261: [Folder view] Fix binding loop on width

[Nathaniel Graham]

ngraham updated this revision to Diff 75469.
ngraham added a comment.


  Use identical margins; don't change the visuals at all (should be done in 
another patch if necessary)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27261?vs=75427=75469

BRANCH
  fix-folderview-binding-loop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27261

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: ngraham, #plasma, davidedmundson
Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> usta wrote in main.qml:242
> I am really away from qml thing but are you sure this one correct ? I mean 
> isnt this should be 
> kcm.dpi instead of kcm.fontsAASettings.dpi ??

No dpi is declared inside fontsAASettings

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27156

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[kio-extras] [Bug 354004] smb kioslave timeouts looking for kerberos authentication

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=354004

Harald Sitter  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||sit...@kde.org
 Status|REPORTED|NEEDSINFO

--- Comment #2 from Harald Sitter  ---
Do you still have access to that network? Is this still a problem? If so which
versions of libsmbclient are you using?

>From looking at the current GVFS code gnome does pretty much what we do, which
is to say it tells libsmbclient to use kerberos and only if that fails fall
back to NTLM, so I would rather expect the same timeout. It's entirely possible
I am not seeing a trick though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Plasma 5.18 LTS

[Jonathan Riddell]

Plasma 5.18.0 is now released
https://www.kde.org/announcements/plasma-5.18.0.php

This includes plasma-nano and plasma-phone-components which are not part of
the LTS.

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75465.
bport added a comment.


  fix coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75446=75465

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

[Will Stephenson]

wstephenson created this revision.
wstephenson added reviewers: hein, davidedmundson.
wstephenson added a project: Plasma.
Herald added a subscriber: plasma-devel.
wstephenson requested review of this revision.

REVISION SUMMARY
  The code to handle a window drag from the taskbar to drop on the
  Activity Pager to add the window to an Activity was broken,
  because the test to see if the drop location is a running activity
  still treated the itemId as an integer indexing into an array of running
  activity indices, rather than an id string that could be a member of the
  list of running activities.
  

This commit fixes that logic and simplifies the no-op return logic.

TEST PLAN
  0) add activity pager widget[to panel]
  
  1. Create 2nd activity
  2. Open a window.
  3. Set that window via the window menu to only appear on the first activity
  4. Check that the 2nd activity is empty
  5. Drag the window's taskbar entry to the pager item for the 2nd activity
  6. check that the dropped window is now also present on the 2nd activity.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27319

AFFECTED FILES
  applets/pager/plugin/pagermodel.cpp

To: wstephenson, hein, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[George Vogiatzis]

gvgeo updated this revision to Diff 75453.
gvgeo edited the test plan for this revision.
gvgeo added a comment.


  Enclosed in Math.round()
  Although works fine without it.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27316?vs=75450=75453

BRANCH
  shadow

REVISION DETAIL
  https://phabricator.kde.org/D27316

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: gvgeo, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27316: [Folder view]Make shadow scale aware

[George Vogiatzis]

gvgeo created this revision.
gvgeo added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Added devicePixelRatio to shadow's radius.

TEST PLAN
  Check the shadow of items on the desktop.
  Compare scale 100% vs big display scale (e.g. 300%).
  Before: Shadow is invisible.
  After: Proper shadow at every display scale.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  shadow

REVISION DETAIL
  https://phabricator.kde.org/D27316

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: gvgeo, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75446.
bport added a comment.


  coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75444=75446

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27084: Don't delay ksplash until the entire slideshow is loaded

[David Redondo]

davidre added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27084

To: davidre, davidedmundson, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75444.
bport added a comment.


  Fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75442=75444

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75442.
bport added a comment.


  Take in consideration Cyril's feedbacks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75000=75442

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27237: [Background Finder] Create a valid invocation token

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ae0fafe23700: [Background Finder] Create a valid 
invocation token (authored by zzag).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27237?vs=75232=75435

REVISION DETAIL
  https://phabricator.kde.org/D27237

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp

To: zzag, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27261: [Folder view] Fix binding loop on width

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  It's technically different to before. The old code had half a small margin 
each side.
  
  Generally speaking bug fixes shouldn't change things, as then you're mixing 
different types of task.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-folderview-binding-loop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27261

To: ngraham, #plasma, davidedmundson
Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart