D27346: emojier: Improve resizing performance

[Chris Holland]

Zren added a comment.


  As in `clip: true`?
  
delegate: MouseArea {
width: emojiView.cellWidth
height: emojiView.cellHeight
clip: true

Rectangle { border.color: "#ff0"; anchors.fill: parent; border.width: 
1; color: "transparent" }

QQC2.Label {
font.pointSize: -1
font.pixelSize: Math.floor(emojiView.desiredSize / 2)

Rectangle {
width: parent.contentWidth
height: parent.contentHeight
border.color: "#f00"
anchors.centerIn: parent
border.width: 1
color: "transparent"
}
}
}
  
  F8105518: 2020-02-15___20-04-25.png 
  F8105516: 2020-02-15___20-03-15.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27346

To: apol, #plasma
Cc: ngraham, Zren, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27346: emojier: Improve resizing performance

[Aleix Pol Gonzalez]

apol added a comment.


  In D27346#612081 , @ngraham wrote:
  
  > What's the status of this? Is it ready?
  
  
  No, it's not.
  
  @Zren 
  Another thing we could do is taking such multiglyph renders as a bug on the 
font. We can clip them so they don't overlap each other. In the end, it's not 
like seeing them resized is pleasing to the eye either...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27346

To: apol, #plasma
Cc: ngraham, Zren, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2020-02-15 11:55, Ben Cooksley wrote:

My point above was that the version you decide to freeze on should
only be the version you depend on during development.
The version you depend on when you release will be the next release of
Frameworks (so by freezing on 5.66 for development, it should have had
a release-day dependency of 5.67)

The release of Plasma should then take place shortly after the
Frameworks version you have a release-day dependency on.

You stagger it like this to ensure that developers are performing a
full burn in of the Frameworks version for several weeks on their
systems, and to ensure that all the problems they find end up in the
Frameworks that users will have on their systems.


None of this makes a difference for distros that ship LTS Plasma don't 
ship newer Frameworks versions. No matter how much testing you do, some 
bugs in Frameworks will slip through and need to be fixed after the 
release. But the frameworks release cycle has no concept of the 
post-release bugfix like Apps and Plasma do; instead the expectation is 
that the distro will just ship a new Frameworks version in a month. This 
expectation does not match the reality for the distros that want to ship 
an LTS plasma version and do not ship newer Frameworks versions.




As for the distributions that are refusing to update Frameworks, do
you have a list of those distributions?
If they're providing a poor experience to our users then we at the
very least should ensure we steer people away from them.


Oh, you know, just some weird, unimportant little ones, like Debian, 
Ubuntu/Kubuntu, and openSUSE Leap. ;-) We should definitely make sure 
that our users don't use *those*; it's not like they're the big heavy 
hitters of the Linux world that are used in large numbers by 
corporations and shipped on hardware or anything. :)


Nate

D27424: Add missing cursors for Chromium-based apps

[Guilherme Silva]

guilhermesilva added a comment.


  It wouldn't call it tough, but it wasn't that easy either... Hahah.
  
  Thanks for pointing me to the right direction too!

REPOSITORY
  R31 Breeze

BRANCH
  breeze-symlinks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27424

To: guilhermesilva, #breeze, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Ben Cooksley]

On Sat, Feb 15, 2020 at 8:10 AM Nate Graham  wrote:
>
> On 2020-02-13 00:42, Ben Cooksley wrote:
> > A better way of approaching this would be to freeze the Frameworks
> > version you are going to require API wise at an earlier point in the
> > Plasma development cycle. This would allow for a full Frameworks
> > release cycle to pass where bugs encountered during the lead up to the
> > Plasma release can be fixed.
> >
> > This version of Frameworks would then be the one that Plasma hard depends 
> > on.
>
> We do this; Plasma 5.18 has a minimum Frameworks dependency of 5.66. See
> https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series
>
> The problem here isn't so much API breaks but rather major bugs and UI
> regressions. if a framework has a very visible bug or UI regression in
> 5.66 of the kind that we would really like to fix, but LTS distros
> freeze on that version, then LTS users will be stuck with that issue
> forever unless we make a frameworks point release or cajole distro
> packagers to backport the fix.
>
> Rolling release distro users will first see Plasma 5.18 with Frameworks
> 5.67, so if that frameworks version has a major bug or UI regression, it
> will take a month for the fix to land in users' hands whereas if the
> issue were in Plasma itself, we could fix it immediately and users would
> get the fix in a week (the first point release is one week after the .0
> release).
>
> My point is that the schedules just don't really match up if we want to
> present a polished finished product and continue to fix bugs for the
> lifetime of an LTS release.
>

My point above was that the version you decide to freeze on should
only be the version you depend on during development.
The version you depend on when you release will be the next release of
Frameworks (so by freezing on 5.66 for development, it should have had
a release-day dependency of 5.67)

The release of Plasma should then take place shortly after the
Frameworks version you have a release-day dependency on.

You stagger it like this to ensure that developers are performing a
full burn in of the Frameworks version for several weeks on their
systems, and to ensure that all the problems they find end up in the
Frameworks that users will have on their systems.

As for the distributions that are refusing to update Frameworks, do
you have a list of those distributions?
If they're providing a poor experience to our users then we at the
very least should ensure we steer people away from them.

>
> Nate

Regards,
Ben

D27420: [Applet]Improvements for unavailable port.

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> ListItemBase.qml:357
> +if (port.name == "analog-output-speaker" || 
> port.name == "analog-input-microphone-internal") {
> +menuItem.text += i18nc("Port is 
> unavailable", " (unavailable)");
> +} else {

please avoid i18n puzzles, and use placeholders instead; for example

  i18nc("Port is unavailable", "%1 (unavailable)", port_description);

> ListItemBase.qml:359
> +} else {
> +menuItem.text += i18nc("Port is unplugged", 
> " (unplugged)");
> +}

ditto

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

[Nathaniel Graham]

ngraham added a comment.


  Or has the code diverged between 5.18 and master too much?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  That's a clever fix. Very nice how it solves the reporter's problem without 
changing the UI at all for everyone else who doesn't need it. No regressions 
found in testing.
  
  What do you think; should we target 5.18.1 for this bugfix?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27424: Add missing cursors for Chromium-based apps

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks for the patch! Hope the process wasn't too tough to get through for 
the first time.
  
  LGTM! @broulik, does this look good to you too?

REPOSITORY
  R31 Breeze

BRANCH
  breeze-symlinks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27424

To: guilhermesilva, #breeze, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Always allow port selection

[Nathaniel Graham]

ngraham added a comment.


  In D27422#612019 , @gvgeo wrote:
  
  > If default button can leave, personally I would prefer this layout (ignore 
the margins).
  >  F8105190: Screenshot_20200215_173638.png 

  >  And it could help avoid bugs like "applet missing the default button".
  
  
  +1, let's do that. Better to make the default device selection UI look like 
it does in the applet, now that it's been changed there.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27346: emojier: Improve resizing performance

[Nathaniel Graham]

ngraham added a comment.


  What's the status of this? Is it ready?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27346

To: apol, #plasma
Cc: ngraham, Zren, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27426: [KRDB] Rename GTK colours to be exported

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The colours exported by KRDB for GTK now have the _breeze suffix.

TEST PLAN
  In tandem with D27425 , no visual change 
should be expected.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  krdb-rename-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27426

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27425: [GTK3] Rename colour definitions

[Carson Black]

cblack created this revision.
cblack added a reviewer: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Colour definitions are now suffixed with _breeze, and public API colours
  are now reexported variables.
  
  CCBUG: 417461

TEST PLAN
  In tandem with a corresponding patch to KRDB, no visual effect should
  be noticeable.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  rename-colours (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27425

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_treeview.scss

To: cblack, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Always allow port selection

[George Vogiatzis]

gvgeo added a reviewer: VDG.
gvgeo added a comment.


  If default button can leave, personally I would prefer this layout (ignore 
the margins).
  F8105190: Screenshot_20200215_173638.png 

  And it could help avoid bugs like "applet missing the default button".

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27424: Add missing cursors for Chromium-based apps

[Guilherme Silva]

guilhermesilva created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guilhermesilva requested review of this revision.

REVISION SUMMARY
  The Cursor Specification from FreeDesktop doesn't even mention these two, but 
Chromium-based apps search for them using a different name, so it wouldn't hurt 
to symlink them.

TEST PLAN
  This can be tested on any webpage using either `cursor: grab` or `cursor: 
grabbing` CSS rule. But here's a page where you can easily test them:
  
  http://elektronotdienst-nuernberg.de/bugs/cursor.html

REPOSITORY
  R31 Breeze

BRANCH
  breeze-symlinks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27424

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/grab
  cursors/Breeze/Breeze/cursors/grabbing
  cursors/Breeze/src/cursorList
  cursors/Breeze_Snow/Breeze_Snow/cursors/grab
  cursors/Breeze_Snow/Breeze_Snow/cursors/grabbing
  cursors/Breeze_Snow/src/cursorList

To: guilhermesilva
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Nathaniel Graham]

ngraham added a comment.


  Thanks! Our documentation can be found at:
  
  - https://community.kde.org/Get_Involved/development (setting up a 
development environment)
  - https://community.kde.org/Infrastructure/Phabricator (submitting the patch)
  
  If you run into trouble, feel free to ask for help in the #kde-devel 
Matrix/Freenode IRC room, or send an email to kde-de...@kde.org.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: guilhermesilva, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27088: [applets/SystemTray] Implement sorting in the model

[Konrad Materka]

kmaterka added a comment.


  OK, I will wait for second review from @davidedmundson, @broulik or @mart.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27088

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26726: [Breeze Cursors] Add some more cursor names

[Guilherme Silva]

guilhermesilva added a comment.


  Alright, I'll try :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: guilhermesilva, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27422: [KCM]Always allow port selection

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Add extra row for port combobox.
  Limit combobox's size to fit inside the row.
  Set device icon size huge. Unifies the size which was based on row height.

TEST PLAN
  Before:
  Was not possible to select an unavailable port.
  Combobox could drive the default button out of the layout.
  After:
  Combobox row appears for devices that have at least two ports.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

[David Redondo]

davidre updated this revision to Diff 75742.
davidre added a comment.


  Add new files

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27421?vs=75741=75742

BRANCH
  searchproxy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27421

AFFECTED FILES
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/autotests/iconmodeltest.cpp
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp
  cuttlefish/src/sortfiltermodel.cpp
  cuttlefish/src/sortfiltermodel.h

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Don't reload everything when filter or category is changed. Fixes selected 
icon
  changing when filtering and the first icon not being selectd when the current
  icon is selected.

TEST PLAN
  select and filter

REPOSITORY
  R118 Plasma SDK

BRANCH
  searchproxy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27421

AFFECTED FILES
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/autotests/iconmodeltest.cpp
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Enable unavailable ports to be active, which was added in 10ab204a62cf 
.
  Enable port selection in case an unavailable port is active.

TEST PLAN
  Before: Choosing an unavailable port from pavucontrol was impossible.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart