D27577: [KCM]Fix content below scrollbars

[George Vogiatzis]

gvgeo updated this revision to Diff 76200.
gvgeo edited the test plan for this revision.
gvgeo added a comment.


  Changed comment.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76173=76200

BRANCH
  scrollbars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27579: Remove attempt to start long gone baloo_file_cleaner

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:616a99165eda: Remove attempt to start long gone 
baloo_file_cleaner (authored by bruns).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27579?vs=76181=76199

REVISION DETAIL
  https://phabricator.kde.org/D27579

AFFECTED FILES
  kcms/baloo/kcm.cpp

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27577: [KCM]Fix content below scrollbars

[George Vogiatzis]

gvgeo added inline comments.

INLINE COMMENTS

> Advanced.qml:33
> +// TODO Fix contentview width, and Remove policy.
> +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff
>  

> What if there's too many devices?

No matter how many devices there are, column is always a column.

> It doesn't sound like a good solution to hide the ScrollBar forever.

That's why a TODO comment exist.

> Also what does contentview refer to?

The width of the content. Need to remove "view".

ContentWidth calculates most of the text with contentWidth instead of 
paintedWidth.
Have not found the loop.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27590: Calculate needsSave on checkbox toggle not on change

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27590

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27577: [KCM]Fix content below scrollbars

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> Advanced.qml:33
> +// TODO Fix contentview width, and Remove policy.
> +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff
>  

What if there's too many devices?
It doesn't sound like a good solution to hide the ScrollBar forever.

Also what does contentview refer to?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27590: Calculate needsSave on checkbox toggle not on change

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Otherwise we will trigger it during load, which is wasteful.
  
  But worse potentially we haven't evaluated the other settings yet, so it
  could trigger that we have changed the settings, and prematurely set
  apply to enabled prematurely which currently breaks things.
  
  I suspect it will fix the bug below, I couldn't reproduce reliably
  enough to prove it.
  
  Please reopen if it remains an issue
  
  BUG: 411584
  Fixed-in: 5.18.2

TEST PLAN
  Opened KCM
  toggling still worked as expected

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27590

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26035: battery: Improve the brightness responsiveness

[Frans de Jonge]

frenzie added inline comments.

INLINE COMMENTS

> PopupDialog.qml:73
>  KeyNavigation.backtab: batteryList
> +stepSize: batterymonitor.maximumScreenBrightness/100
> +

Because it's artificially limited to 100 positions, this change makes it 
impossible to set a value by clicking on a position or by dragging the slider 
with the pointer. It snaps to one of the 100 positions and the precision we 
want just isn't there.

On my laptop the slider currently consists of ~582 pixels in width. (Just a 
quick screenshot selection-based estimate; the exact value is irrelevant other 
than to point out that it's very unlikely to be less than ~450 and extremely 
likely to be much more.) The organic limit is therefore 582 on my laptop. In 
the example given above, 7000/582 = 12.

I assume there has to be reason for this change, so an organic limit would mean 
something along the lines of:

  stepSize: batterymonitor.maximumScreenBrightness / this.width

But intuitively it seems that a slider would have to do that all by itself no 
matter what, which just leaves me confused as to what the purpose behind this 
line is.

I hope it can simply be removed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26035

To: apol, #plasma, broulik
Cc: frenzie, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27581: Use K_PLUGIN_CLASS_WITH_JSON

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It's a bit niver than the factory thing

TEST PLAN
  builds, kcm opens

REPOSITORY
  R133 KScreenLocker

BRANCH
  kpc

REVISION DETAIL
  https://phabricator.kde.org/D27581

AFFECTED FILES
  kcm/kcm.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27426: [KRDB] Rename GTK colours to be exported

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fffb352cfa1e: [KRDB] Rename GTK colours to be exported 
(authored by cblack).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27426?vs=75752=76185

REVISION DETAIL
  https://phabricator.kde.org/D27426

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma, ngraham
Cc: ongunkanat, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27425: [GTK3] Rename colour definitions

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:dca25cb44b37: [GTK3] Rename colour definitions (authored 
by cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27425?vs=75751=76184

REVISION DETAIL
  https://phabricator.kde.org/D27425

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_treeview.scss

To: cblack, #breeze, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27579: Remove attempt to start long gone baloo_file_cleaner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch please

REPOSITORY
  R119 Plasma Desktop

BRANCH
  baloo_config_rework

REVISION DETAIL
  https://phabricator.kde.org/D27579

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27574: Remove bold formatting of device name

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27574

To: nicolasfella, #plasma, drosca, davidedmundson
Cc: ngraham, broulik, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

[Nathaniel Graham]

ngraham added a comment.


  My bad, your patch actually fixes a pre-existing visual bug. :) That accounts 
for the change. +1 visually

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27579: Remove attempt to start long gone baloo_file_cleaner

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The standalone index cleaner has been replaced almost 5 years by
  functionality implemented in baloo_file.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  baloo_config_rework

REVISION DETAIL
  https://phabricator.kde.org/D27579

AFFECTED FILES
  kcms/baloo/kcm.cpp

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27570: [applets/systemtray] Clip ListView in config

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:193c89a4a0cf: [applets/systemtray] Clip ListView in 
config (authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27570?vs=76165=76180#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27570?vs=76165=76180

REVISION DETAIL
  https://phabricator.kde.org/D27570

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: nicolasfella, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27574: Remove bold formatting of device name

[Nicolas Fella]

nicolasfella updated this revision to Diff 76178.
nicolasfella added a comment.


  - Simplify

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27574?vs=76169=76178

BRANCH
  nobold

REVISION DETAIL
  https://phabricator.kde.org/D27574

AFFECTED FILES
  src/kcmodule/devices/devicedetails.cpp

To: nicolasfella, #plasma, drosca, davidedmundson
Cc: broulik, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27570: [applets/systemtray] Clip ListView in config

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch

REPOSITORY
  R120 Plasma Workspace

BRANCH
  clip

REVISION DETAIL
  https://phabricator.kde.org/D27570

To: nicolasfella, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27577: [KCM]Fix content below scrollbars

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Set content to use available space.
  
  BUG:416331
  BUG:417447

TEST PLAN
  Open audio settings from kickoff.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  scrollbars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml

To: gvgeo, #plasma, #vdg, drosca
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

[Alexander Lohnau]

alex created this revision.
alex added reviewers: davidedmundson, ngraham, broulik, meven, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The config keys/sorting enum have been moved to a new file, before this the 
runner included the header of the config class.
  This patch originated from https://phabricator.kde.org/D27513, but it was 
requested to split it up into separate patches.

TEST PLAN
  Should compile.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  killrunner_config_refactoring

REVISION DETAIL
  https://phabricator.kde.org/D27576

AFFECTED FILES
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27565: Hide configure action in Info center mode

[Kai Uwe Broulik]

broulik added a comment.


  In D27565#615851 , @broulik wrote:
  
  > Wouldnt it be better to just hide the `configure` action when it's created?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27565

To: ngraham, #plasma, mart
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27565: Hide configure action in Info center mode

[Kai Uwe Broulik]

broulik added a comment.


  Wouldnt it be better to just hide the `configure` action where it's created?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27565

To: ngraham, #plasma, mart
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27574: Remove bold formatting of device name

[Kai Uwe Broulik]

broulik added a comment.


  It uses plain text so a device named "phone" doesn't mess with the layout

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27574

To: nicolasfella, #plasma, drosca, davidedmundson
Cc: broulik, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27572: [kcm] Drop 'Enable bluetooth integration' setting

[Kai Uwe Broulik]

broulik added a comment.


  +1
  Iirc the plasmoid is loaded regardless of that setting anyway?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27572

To: nicolasfella, #plasma, drosca
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27574: Remove bold formatting of device name

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> devicedetails.cpp:117
>  {
> -m_ui->remoteName->setText(QStringLiteral("%1").arg(name));
> +m_ui->remoteName->setText(QStringLiteral("%1").arg(name));
>  }

then you can simply remove the string+arg...

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27574

To: nicolasfella, #plasma, drosca, davidedmundson
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27574: Remove bold formatting of device name

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, drosca, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  D27543  set the label to plaintext, for a 
reason I assume, but the device name label actually used style tags. We either 
need to drop that or reenable rich text formatting

TEST PLAN
  No longer see device name

REPOSITORY
  R97 Bluedevil

BRANCH
  nobold

REVISION DETAIL
  https://phabricator.kde.org/D27574

AFFECTED FILES
  src/kcmodule/devices/devicedetails.cpp

To: nicolasfella, #plasma, drosca, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27572: [kcm] Drop 'Enable bluetooth integration' setting

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It controls whether the bluedevil kded module is loaded. I don't see any use 
case for it. If one really really needs to disable the kded module this can be 
done from the kded KCM.

REPOSITORY
  R97 Bluedevil

BRANCH
  nointe

REVISION DETAIL
  https://phabricator.kde.org/D27572

AFFECTED FILES
  src/kcmodule/global/global.cpp
  src/kcmodule/global/global.h
  src/kcmodule/global/global.ui

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27570: [applets/systemtray] Clip ListView in config

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Else the content will overflow the frame when scrolling

REPOSITORY
  R120 Plasma Workspace

BRANCH
  clip

REVISION DETAIL
  https://phabricator.kde.org/D27570

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: nicolasfella, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27561: [kcm/activities] Clip ListView

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dba3d5670275: [kcm/activities] Clip ListView (authored by 
nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27561?vs=76134=76163

REVISION DETAIL
  https://phabricator.kde.org/D27561

AFFECTED FILES
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml

To: nicolasfella, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27559: [kcm/baloo] Clip ListView

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0ec354f7d269: [kcm/baloo] Clip ListView (authored by 
nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27559?vs=76132=76164

REVISION DETAIL
  https://phabricator.kde.org/D27559

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml

To: nicolasfella, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27513: Kill Runner: Remove duplicate function calls and refactor

[Alexander Lohnau]

alex updated this revision to Diff 76149.
alex marked an inline comment as done.
alex added a comment.


  Revert moving of config keys from commit "Remove duplicate function calls, 
move config keys to new file"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27513?vs=76085=76149

BRANCH
  killrunner_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27563: [mobile/wifi] Use ScrollViewKCM

[Nicolas Fella]

nicolasfella added a comment.


  In D27563#615561 , @ngraham wrote:
  
  > What's the chance we could unify the mobile and desktop versions at some 
point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather 
than using the power of convergence.
  
  
  I'm unsure. The mobile wifi KCM and the desktop connections KCM are quite a 
bit different. The former acts more like the plasmoid since it shows 
//available// connections. The latter shows //known// connections and has very 
extensive settings for things (that would be a challenge to get into a mobile 
UI completely).
  
  I'm open for proposals though

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27563

To: nicolasfella, #plasma, jgrulich, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27555: Add a category for kde-only and gnome-only apps

[Nicolas Fella]

nicolasfella added a comment.


  In D27555#615587 , @ngraham wrote:
  
  > I used to think this was really important but am less sure now. I don't 
feel the need to push for it, but nonetheless Aleix is right that it's pretty 
common user request--not just in that bug report but in other places too. So we 
might not want to dismiss the idea out of hand.
  
  
  We get a lot of requests about implementing various things, that does not 
always mean it's a good idea to do so
  
  > I'm preparing for a conference next weekend in which I plan to represent 
and promote KDE, and it occurs to me that this would make it really easy to 
highlight KDE's vast software catalog to interested parties.
  
  For this purpose https://kde.org/applications/ looks like the way to go for me

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27555

To: apol, #plasma
Cc: ngraham, pino, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems good to me, wait for @broulik review

REPOSITORY
  R120 Plasma Workspace

BRANCH
  webshortcuts_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27566

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27518: Only enable the "Help" button if khelpcenter is available

[Ahmad Samir]

ahmadsamir added a comment.


  openHelp() will need to be changed, because the "application=" part of the 
url will be "systemsettings" (QCoreApplication::applicationName()), which would 
open the handbook of systemsettings instead of e.g. 
/kcontrol/fonts/index.html.
  
  Is the API for the redirects in the docs.kde.org url documented somewhere?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27518

To: ahmadsamir, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27556: HiDPI pixmap

[Yunhe Guo]

guoyunhe marked an inline comment as done.
guoyunhe added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in AuthDialog.cpp:108
> You wanna use `devicePixelRatioF` right?

Fixed thanks!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27556

To: guoyunhe, #plasma
Cc: anthonyfieroni, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D27556: HiDPI pixmap

[Yunhe Guo]

guoyunhe updated this revision to Diff 76146.
guoyunhe marked 2 inline comments as done.
guoyunhe added a comment.


  Change devicePixelRatio() to devicePixelRatioF()

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27556?vs=76145=76146

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27556

AFFECTED FILES
  AuthDialog.cpp

To: guoyunhe, #plasma
Cc: anthonyfieroni, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D27556: HiDPI pixmap

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> AuthDialog.cpp:108
>  
> +const qreal dpr = devicePixelRatio();
> +

You wanna use `devicePixelRatioF` right?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27556

To: guoyunhe, #plasma
Cc: anthonyfieroni, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D27556: HiDPI pixmap

[Yunhe Guo]

guoyunhe marked 2 inline comments as done.
guoyunhe added inline comments.

INLINE COMMENTS

> apol wrote in AuthDialog.cpp:108
> You should get the dpr from the window, not the qApp. Different screens will 
> have different dprs.

Fixed. Getting it from widget now.

> apol wrote in AuthDialog.cpp:133
> All are integers, why are you turning it into QPointF?

This is how HiDPI QPainter works.

Source https://doc.qt.io/qt-5/highdpi.html#migrate-existing-applications

> Always use the qreal versions of the QPainter drawing API.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27556

To: guoyunhe, #plasma
Cc: anthonyfieroni, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D27556: HiDPI pixmap

[Yunhe Guo]

guoyunhe updated this revision to Diff 76145.
guoyunhe added a comment.


  Get DPR from widget instead of app

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27556?vs=76128=76145

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27556

AFFECTED FILES
  AuthDialog.cpp

To: guoyunhe, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart