D27563: [mobile/wifi] Use ScrollViewKCM

[Jan Grulich]

jgrulich added a comment.


  In D27563#615561 , @ngraham wrote:
  
  > What's the chance we could unify the mobile and desktop versions at some 
point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather 
than using the power of convergence.
  
  
  The desktop KCM is not fully written in QML. I have a branch, where I started 
working on it a long time ago, but it still requires significant amount of work.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27563

To: nicolasfella, #plasma, jgrulich, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27577: [KCM]Fix content below scrollbars

[George Vogiatzis]

gvgeo added a comment.


  In D27577#616579 , @ngraham wrote:
  
  > The changes to labels in `Header.qml` seem unrelated.
  
  
  They are as related as the other 4 changes are.
  Either will make 5 different patches or 1. But I'm not going to change back 
and forth.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24009: RFC: Make Breeze Dark darker

[Nathaniel Graham]

ngraham added a comment.


  If adding a color for the separators isn't an option, and adding an option 
isn't an option (heh), then could we add a simple algorithm to switch to light 
separators if the background color is set to a sufficiently dark color?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24009

To: filipf, cblack, ndavis, #vdg, ngraham, #plasma
Cc: onvitaik, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24009: RFC: Make Breeze Dark darker

[Nathaniel Graham]

ngraham added a comment.


  Also is there a better place to discuss this? A Phab task maybe?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24009

To: filipf, cblack, ndavis, #vdg, ngraham, #plasma
Cc: onvitaik, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27577: [KCM]Fix content below scrollbars

[Nathaniel Graham]

ngraham added a comment.


  The changes to labels in `Header.qml` seem unrelated.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24009: RFC: Make Breeze Dark darker

[Noah Davis]

ndavis added a comment.


  I think these 4 colors could be used for backgrounds in Breeze Dark:
  
#1b1e20
#232629
#2a2e32
#31363b
  
  Coincidentally, these colors are very close in lightness to the colors used 
by VS Code (`#1e1e1e`, `#252526`, `#2d2d2d`, `#33`)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24009

To: filipf, cblack, ndavis, #vdg, ngraham, #plasma
Cc: onvitaik, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24009: RFC: Make Breeze Dark darker

[Noah Davis]

ndavis added a comment.


  The problem with having dark separators is that they disappear if you set the 
background color to black. That isn't an unreasonable thing for a user to want 
to do. It's also arguable that it isn't unreasonable for a user to want dark 
separators, so they could be an option, but last time I tried that for 
colorschemes, it didn't get a lot of support (D25814 
). It could be an option in the Breeze 
widget style settings, but I really don't want to start stuffing options in 
obscure places...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24009

To: filipf, cblack, ndavis, #vdg, ngraham, #plasma
Cc: onvitaik, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24009: RFC: Make Breeze Dark darker

[Nathaniel Graham]

ngraham added a comment.


  @onvitaik I completely agree. You're gonna have to convince @ndavis and 
@filipf who prefer light outlines and separators though. :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24009

To: filipf, cblack, ndavis, #vdg, ngraham, #plasma
Cc: onvitaik, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27613: Remove bogus mount points check when starting baloo on save

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The check stops baloo if non of the included pathes is *currently*
  mounted, i.e. if a device is mounted later baloo is not running and
  can not pick up the device.
  
  Depends on D27612 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27613

AFFECTED FILES
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

[Stefan Brüns]

bruns updated this revision to Diff 76253.
bruns added a comment.


  ignoreMountPoint -> ignoredMountPoint
  whitespace

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27611?vs=76251=76253

REVISION DETAIL
  https://phabricator.kde.org/D27611

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h

To: bruns, #baloo, ngraham
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

[Stefan Brüns]

bruns added a comment.


  In D27611#616556 , @usta wrote:
  
  > 2 Question : 
  >  1- isnt that method should be const'ified ?
  
  
  Its not a member function ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27611

To: bruns, #baloo, ngraham
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

[Ömer Fadıl Usta]

usta added a comment.


  2 Question : 
  1- isnt that method should be const'ified ? 
  2- also its name will be much better isIgnoreableMountPoint (or something can 
be more understandable
  that it will just return true or false ) becase right now it looks like
  "ignore that mount point"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27611

To: bruns, #baloo, ngraham
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27612: Remove unused functions

[Stefan Brüns]

bruns updated this revision to Diff 76252.
bruns added a comment.


  rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27612?vs=76250=76252

REVISION DETAIL
  https://phabricator.kde.org/D27612

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

[Stefan Brüns]

bruns updated this revision to Diff 76251.
bruns added a comment.


  move out of class

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27611?vs=76249=76251

REVISION DETAIL
  https://phabricator.kde.org/D27611

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27595: Watch for language change events, and forward those to the QML engine

[Aleix Pol Gonzalez]

apol added a comment.


  I'm fine with this being done here for convenience, but it feels like it's 
something that should be in QQmlEngine itself.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27595

To: vkrause
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27612: Remove unused functions

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  showMessage() is only declared, but never defined.
  
  includeFolders() and fetchMountPoint(url) are not used.
  
  Depends on D27611 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27612

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Instead of negating the logic values in several places, just invert
  the logic.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27611

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27606: Remove usage of KDBusConnectionPool

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R161:fa5b3bb382ac: Remove usage of KDBusConnectionPool 
(authored by vkrause).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27606?vs=76237=76248

REVISION DETAIL
  https://phabricator.kde.org/D27606

AFFECTED FILES
  src/service/Activities.cpp
  src/service/Application.cpp
  src/service/Features.cpp
  src/service/Resources.cpp
  src/service/ksmserver/KSMServer.cpp
  src/service/plugins/activitytemplates/TemplatesPlugin.cpp
  src/service/plugins/slc/SlcPlugin.cpp
  src/service/plugins/sqlite/ResourceLinking.cpp
  src/service/plugins/sqlite/StatsPlugin.cpp

To: vkrause, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24009: RFC: Make Breeze Dark darker

[Onvitai Kayan]

onvitaik added a comment.


  The problem, as I see it, with it looking "fairly light" is that all the 
button and frame borders are lighter than the background and almost as light as 
the text. These color changes just exacerbate this issue.
  
  On that note, light borders on dark buttons makes no sense if you think of 
buttons like the keys on your keyboard. It makes the button look like it's 
sunk, and the borders take your focus nearly as much as the text does. Right 
now, it's almost like there are a bunch of neon signs all over the place. With 
darker borders and frames, it looks much less painful to the eyes:
  
  F8127315: edit.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24009

To: filipf, cblack, ndavis, #vdg, ngraham, #plasma
Cc: onvitaik, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27608: Fix applet configuration ovelap with top line

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  For plasmoids configuration add top line as topMargin.

TEST PLAN
  Open desktop configuration.
  Use Scroll to move contents at the top.
  Observe content, and category highlight.
  Before:
  Displayed on top of the line.
  After:
  They touch below the line.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configtop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: gvgeo, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27606: Remove usage of KDBusConnectionPool

[Volker Krause]

vkrause created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  As per T12722  this is no longer needed, 
QDBusConnection now behaves
  correctly in a multi-threaded scenario.

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27606

AFFECTED FILES
  src/service/Activities.cpp
  src/service/Application.cpp
  src/service/Features.cpp
  src/service/Resources.cpp
  src/service/ksmserver/KSMServer.cpp
  src/service/plugins/activitytemplates/TemplatesPlugin.cpp
  src/service/plugins/slc/SlcPlugin.cpp
  src/service/plugins/sqlite/ResourceLinking.cpp
  src/service/plugins/sqlite/StatsPlugin.cpp

To: vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Plasma Sprint 2020 in Augsburg, Germany

[Alexander Potashev]

Hi Kai,

I have a few questions:

 1. Is it OK to join the sprint for those who don't touch Plasma
source code on a regular basis? Would this make the sponsored office
space overcrowded?
(Asking for myself. Of course I won't request travel support.)

 2. May we please merge "Arrival/Leaving" columns in the attendance
table so I can answer e.g. "weekends: 18-19, then 25-26"?

 3. Do you expect the sprint to go on in parallel with Linux-Infotag
on 2020-04-25?

 4. Are you going to give your talk in German or English?

пт, 21 февр. 2020 г. в 10:24, Kai Uwe Broulik :
>
> Hello again,
>
> I have now booked a hotel for all of us. We'll be staying at Hotel B
> Augsburg, in walking-distance to the venue.
>
> Everyone who's had their name on the wiki [1] until now (and is marked
> with an "ok") was considered. As with sprint tradition I've booked
> double rooms with separate beds. If anyone isn't comfortable with or
> unwilling to share rooms, please let me know, but be aware that it is
> getting increasingly hard to get rooms in that timeframe, which is why
> I've just had to book now.
>
> Anyone else who still wants to join the sprint, please get in touch. We
> should have room for 1-2 persons more on that same booking but other
> than that please see for booking an accomodation yourself.
>
> Thanks
> Kai Uwe
>


-- 
Alexander Potashev

D27595: Watch for language change events, and forward those to the QML engine

[Volker Krause]

vkrause created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This fixes a race condition on startup for the Kirigami translation
  catalog that happens as follows:
  
  - QML code triggers the loading of the Kirigami plugin
  - the ECM QM loader is triggered, but since this is running outside of the
  
  main thread, the actual QM loading is deferred to the main thread
  
  - QML code execution continues, at which point qsTr might still return
  
  unstranslated strings
  
  This is for example visible by the "Actions" header in the context drawer
  of the main application page not getting translated.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27595

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

To: vkrause
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27577: [KCM]Fix content below scrollbars

[George Vogiatzis]

gvgeo updated this revision to Diff 76202.
gvgeo added a comment.


  typo

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76201=76202

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27577: [KCM]Fix content below scrollbars

[George Vogiatzis]

gvgeo updated this revision to Diff 76201.
gvgeo added a comment.


  Make scrollbars touch the side of the frame.
  Fit speaker test grid inside the scrollview area.
  Fix advanced content layout.
  Make Header always fit inside the scrollview area.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76200=76201

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart