D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 76597.
trmdi added a comment.


  Small fix.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=76596=76597

BRANCH
  arcpatch-D27458 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 76596.
trmdi added a comment.


  Never show before position is set

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=75883=76596

BRANCH
  arcpatch-D27458 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  In D27669#619230 , 
@hpereiradacosta wrote:
  
  > Overall, this is good stuff I think (although we should also discuss 
whether this should be part of breeze or rather a next-gen theme).
  
  
  We discussed that in T12488 . Folks were 
generally in favor, but in the end Marco convinced us to keep iterating on the 
current Breeze rather than forking and making a totally new theme. Perhaps we 
could consider doing a "reverse fork" to keep around a theme called "Breeze 
Classic" for the people who are happy with the current version.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[Nathaniel Graham]

ngraham added a comment.


  Yeah, that's fine.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[George Vogiatzis]

gvgeo added a comment.


  Kirigami in applet?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Overall, this is good stuff I think (although we should also discuss whether 
this should be part of breeze or rather a next-gen theme).
  Still:
  right now it crashes all applications (here at least) when you unlock 
toolbars, move them to a different position, then move them back to top. 
  Tested with dolphin, okular, etc. All crash.
  
  I also have other comments (code wise and design wise), but will only have 
time to post them over the week-end.
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[Nathaniel Graham]

ngraham added a comment.


  Even better than a GridLayout is a `Kirigami.FormLayout! That's what's being 
approximated here, so why not use the real thing? :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a subscriber: hpereiradacosta.
ndavis added a comment.


  Adding Hugo as a subscriber since he might have some advice.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76592.
cblack added a comment.


  Transition from window active <-> inactive, TODO: read from kdecoration config

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76590=76592

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76590.
cblack added a comment.


  Properly draw menubar borders

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76586=76590

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Looking pretty great. The appearance of the Tools Area itself is good in all 
KDE apps tested. Visually, I only see a few remaining issues:
  
  There's no line under the titlebar in windows without a Tools Area: F8135611: 
Screenshot_20200227_151538.png 
  
  ...Except in System Settings, where there is a line, but it's darker than it 
is under the Tools Area for apps that do have one: F8135609: 
Screenshot_20200227_151418.png 
  
  In KSysGuard, there's a tab bar right under the Tools area, but the Tools 
area doesn't get a line under it like there is in other apps with tabs below 
the Tools Area like Dolphin and Okular: F8135614: 
Screenshot_20200227_151712.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76586.
cblack added a comment.


  Update tools area manager on colourscheme change

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76585=76586

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76585.
cblack added a comment.


  Don't draw border when you shouldn't draw tools area

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76582=76585

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3b2e4ddaa01a: [applets/taskmanager] Show PA-related 
features even when audio indicators are… (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27684?vs=76495=76584

REVISION DETAIL
  https://phabricator.kde.org/D27684

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

To: ngraham, #plasma, hein
Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76582.
cblack added a comment.


  Recompute toolbars after adding a widget

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76581=76582

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76581.
cblack added a comment.


  Draw separator line

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76568=76581

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Good stuff.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  show-mute-feature-even-when-audio-indicators-are-disabled (branched from 
master)

REVISION DETAIL
  https://phabricator.kde.org/D27684

To: ngraham, #plasma, hein
Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: Display a warning, if xsettingsd is not found

[Peter Eszlari]

eszlari added a comment.


  In D25324#563373 , @gikari wrote:
  
  > In D25324#563347 , @eszlari 
wrote:
  >
  > > But seems, this only applies to dependencies checked by find_package().
  >
  >
  > I'm confused.
  >
  > Does it mean, I should create custom `FindXsettingsd.cmake` module for 
xsettingsd, then write something like this:
  >
  >   find_package(Xsettingsd)
  >   set_package_properties(Xsettingsd PROPERTIES
  >   TYPE RUNTIME
  >   DESCRIPTION "Provides settings to X11 applications via the XSETTINGS 
specification"
  >   URL "https://github.com/derat/xsettingsd;
  >   )
  >
  >
  > ?
  
  
  Yes. Maybe you can take inspiration from this commit:
  
https://cgit.kde.org/kinfocenter.git/commit/?id=35b19106c5cb64c4705a3682269826d4be6510f2

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari
Cc: eszlari, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[George Vogiatzis]

gvgeo added a comment.


  Separate patch so can be easily reverted, if a grid+repeater problem exist 
R120:d12521b149fa 
.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27711

To: gvgeo, #plasma, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27711: [Applet]Use gridLayout for details

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, jgrulich, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Use gridLayout for repeater in DetailsText.
  Now right mouse menu(copy) opens on label too.

TEST PLAN
  Check elide, and copy that work correctly.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  grid2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27711

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml

To: gvgeo, #plasma, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:24b737bc6d5c: [Applet]Update layout based on T10470 
(authored by gvgeo).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=76526=76576

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76571.
niccolove added a comment.


  Fixed margin

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76543=76571

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76568.
cblack added a comment.


  Don't do tools area on dialog windows

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76564=76568

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76564.
cblack added a comment.


  Improvements to toolbar heuristics

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76560=76564

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

[Fabian Vogt]

fvogt planned changes to this revision.
fvogt added a comment.


  I need some input on how to express `HAVE_QTWEBENGINEWIDGETS` with this. 
Currently it would fail to build if `Qt5WebEngineWidgets` is installed but 
`Qt5WebChannel` isn't.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D27347

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76560.
cblack added a comment.


  Increase padding of toolbar

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76559=76560

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76559.
cblack added a comment.


  Fix bad heuristic

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76558=76559

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76558.
cblack added a comment.


  Improve toolbar heuristics

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76552=76558

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:0be65944f311: If KHelpCenter isnt available 
fallback to opening doc at docs.kde.org (authored by ahmadsamir).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27518?vs=76447=76557

REVISION DETAIL
  https://phabricator.kde.org/D27518

AFFECTED FILES
  CMakeLists.txt
  app/CMakeLists.txt
  core/ModuleView.cpp

To: ahmadsamir, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27700: Add an autotest for ActionToolBar

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:86
> Maybe pass different COMMAND to the same add_custom_command? As is it reads 
> like you're declaring the command several times.
> 
> See https://cmake.org/cmake/help/v3.13/command/add_custom_command.html

Good point. Done.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27700

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27700: Add an autotest for ActionToolBar

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 76556.
ahiemstra added a comment.


  - Don't use multiple commands to achieve what one can also do

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27700?vs=76539=76556

BRANCH
  actiontoolbar_test

REVISION DETAIL
  https://phabricator.kde.org/D27700

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/tst_actiontoolbar.qml
  src/CMakeLists.txt

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27697: WIP: Added top area to notification header

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  Also please `Math.round` when you divide sizes

INLINE COMMENTS

> NotificationItem.qml:114
>  
> -NotificationHeader {
> -id: notificationHeading
> -Layout.fillWidth: true
> -Layout.leftMargin: notificationItem.headingLeftPadding
> -Layout.rightMargin: notificationItem.headingRightPadding
> +PlasmaContents.TopArea{
> +bottomInset: thumbnailTopPadding / 2

Plasma*Contents*?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27697

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14562: Introduce Theme.smallestFont

[Alexander Volkov]

volkov updated this revision to Diff 76554.
volkov added a comment.


  registered for 2.2

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14562?vs=38964=76554

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14562

AFFECTED FILES
  src/controls/plugins.qmltypes
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: volkov, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D27699: Replace qmltestrunner with a custom executable that effectively does the same

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6a0009b41047: Replace qmltestrunner with a custom 
executable that effectively does the same (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27699?vs=76538=76553

REVISION DETAIL
  https://phabricator.kde.org/D27699

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/qmltest.cpp

To: ahiemstra, #kirigami, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LGTM! Nice work.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76551.
cblack added a comment.


  Reload on colour scheme update

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76510=76551

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76552.
cblack added a comment.


  Drop qDebug() <<

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76551=76552

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27554: reviews: expose the reviewed package version on the delegate

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d58668698f5f: reviews: expose the reviewed package 
version on the delegate (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27554?vs=76124=76549

REVISION DETAIL
  https://phabricator.kde.org/D27554

AFFECTED FILES
  discover/qml/ReviewDelegate.qml
  libdiscover/ReviewsBackend/ReviewsModel.cpp
  libdiscover/ReviewsBackend/ReviewsModel.h

To: apol, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27702: Block calls to org.kde.KSplash till it is registered

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a8299642d718: Block calls to org.kde.KSplash till it is 
registered (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27702?vs=76547=76548

REVISION DETAIL
  https://phabricator.kde.org/D27702

AFFECTED FILES
  startkde/waitforname/CMakeLists.txt
  startkde/waitforname/org.kde.KSplash.service.in

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27702: Block calls to org.kde.KSplash till it is registered

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  A recent update to startup made it too fast and hit a race with ksplash.
  
  We expose that we could send that kinit and ksmserver were ready before
  ksplash registered the service name.
  
  We have an existing mechanism to make DBus server queue up messages if a
  service is not registered yet without actually activating it. So we can
  re-use that.
  
  Long term we need to rethink ksplash completely.

TEST PLAN
  Confirmed issue with extra debug
  Logged in and the issue was gone

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27702

AFFECTED FILES
  startkde/waitforname/CMakeLists.txt
  startkde/waitforname/org.kde.KSplash.service.in

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

broulik updated this revision to Diff 76546.
broulik edited the test plan for this revision.
broulik added a comment.


  - Clarify comment

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27701?vs=76545=76546

REVISION DETAIL
  https://phabricator.kde.org/D27701

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When not using `dim` it breaks "click outside" for `ComboBox` when in a 
`ScrollView`.
  I believe because without an actual `Item` the `Popup` filters some events 
and might have them stolen by the `Flickable`?
  So we keep `dim` on but use a transparent `Item` to avoid it actually dimming 
its surroundings.

TEST PLAN
  - Kirigami gallery `ComboBox` still doesn't dim (it does without the `Item`)
  - `ComboBox` in QtQuick KCMs like KScreen KCM now close properly on click 
outside

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27700: Change copy to binary to use a custom target that always runs

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:86
>  make_directory 
> ${CMAKE_BINARY_DIR}/bin/org/kde/kirigami.2/)
> -add_custom_command(TARGET kirigamiplugin POST_BUILD
> +add_custom_command(TARGET copy_to_bin POST_BUILD
>  COMMAND ${CMAKE_COMMAND} -E

Maybe pass different COMMAND to the same add_custom_command? As is it reads 
like you're declaring the command several times.

See https://cmake.org/cmake/help/v3.13/command/add_custom_command.html

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27700

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76543.
niccolove added a comment.


  Fix margins

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76533=76543

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 126 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/126/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 27 Feb 2020 13:12:38 +
 Build duration:
5 min 46 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove added a comment.


  Wait, are notifications ignoring dialog/background theme margins!?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27697

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 280 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/280/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 27 Feb 2020 13:12:38 +
 Build duration:
3 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report15%
(12/79)17%
(62/364)17%
(62/364)13%
(4137/31503)10%
(1929/19056)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.emojier0%
(0/1)0%
(0/1)0%
(0/202)0%
(0/111)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1098)0%
(0/620)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/356)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/320)0%
(0/244)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2350)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%
  

D27679: [emojier] Set minimum window height and width

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d0247bf56954: [emojier] Set minimum window height and 
width (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27679?vs=76468=76541

REVISION DETAIL
  https://phabricator.kde.org/D27679

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/ui/emojier.qml

To: filipf, apol, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> bport wrote in spellchecking.cpp:88
> Yes, or I can probably also use item like before, and that will be handled 
> for me

That would create other issues I think (not fully sure TBH). Well in any case 
that's an extra level of indirection we don't really need (and it's already 
very confusing as is). Adding the missing usrRead() in the skeleton ctor is 
clearly easier IMO.

> bport wrote in spellchecking.cpp:118
> no because we hold loaded data if we do that, apply button will be 
> deactivated after clicking default

*sigh* OK... KConfigDialogManager is so confusing each time...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27700: Change copy to binary to use a custom target that always runs

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds an inital test to test whether ActionToolBar does the
  right thing. It does not yet cover display hints or custom
  components, but does cover using QQC2 action instead of Kirigami
  Action.

TEST PLAN
  The new test passes.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_test

REVISION DETAIL
  https://phabricator.kde.org/D27700

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/tst_actiontoolbar.qml
  src/CMakeLists.txt

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27699: Replace qmltestrunner with a custom executable that effectively does the same

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  CI is currently failing due to LD_PRELOAD of the ASAN libraries failing for 
some
  reason. Since it is not clear what causes this problem, instead create a 
custom
  executable that does the same as qmltestrunner but will be compiled using ASAN
  like the rest of the library.

TEST PLAN
  Tests still pass. I used the same solution for kquickcharts where it has been 
working
  for a while.

REPOSITORY
  R169 Kirigami

BRANCH
  autotest_qmlrunner

REVISION DETAIL
  https://phabricator.kde.org/D27699

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/qmltest.cpp

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27698: Fix PrivateActionToolButton behaviour with showText vs IconOnly

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  PrivateActionToolButton behaves slightly different when setting
  showText to false versus setting display to IconOnly. This is
  because the implicitWidth binding does not check the display
  property. This fixes that to make sure both `showText: false`
  and `display: IconOnly` return the implicitHeight, making the
  button square in both cases.

TEST PLAN
  Kirigami Gallery still works correctly.

REPOSITORY
  R169 Kirigami

BRANCH
  patb_icononly_width

REVISION DETAIL
  https://phabricator.kde.org/D27698

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:26f942fc335f: Fix ActionToolBar/PrivateActionToolButton 
in combination with QQC2 Action (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27653?vs=76370=76536

REVISION DETAIL
  https://phabricator.kde.org/D27653

AFFECTED FILES
  src/controls/private/ActionToolBarLayoutDetails.qml
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami, mart
Cc: camiloh, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D27650: ItemContainer: disconnect signals in destructor

[Aleksei Nikiforov]

alnikiforov added a comment.


  In D27650#618492 , @davidedmundson 
wrote:
  
  > Can I have your full name + email address please.
  
  
  Aleksei Nikiforov 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27650

To: alnikiforov, ngraham, davidedmundson, mart
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> ervin wrote in spellchecking.cpp:88
> Sure but still, the skeleton is expected to be already be in a "loaded" state 
> at that point, that's why it works for the items (otherwise a findItem 
> wouldn't be enough, it'd have to call readConfig on them or load on the whole 
> skeleton, and it doesn't). I think the problem is more that in the ctor of 
> the skeleton you initialize the items just fine but you don't initialize the 
> extra properties you need a call to usrRead() at the end of that ctor.

Yes, or I can probably also use item like before, and that will be handled for 
me

> ervin wrote in spellchecking.cpp:118
> I'd expect this to be the same block than the one in load() now. Since 
> `KCModule::defaults()` will reset the skeleton to defaults, ignoreList, 
> preferredLanguages and defaultLanguage will hold the default values.

no because we hold loaded data if we do that, apply button will be deactivated 
after clicking default

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> bport wrote in spellchecking.cpp:88
> no load only do findItem for managed widget on the skeleton

Sure but still, the skeleton is expected to be already be in a "loaded" state 
at that point, that's why it works for the items (otherwise a findItem wouldn't 
be enough, it'd have to call readConfig on them or load on the whole skeleton, 
and it doesn't). I think the problem is more that in the ctor of the skeleton 
you initialize the items just fine but you don't initialize the extra 
properties you need a call to usrRead() at the end of that ctor.

> bport wrote in spellcheckingskeleton.cpp:51
> Yes is necessary no code is run after that so nobody will take care of saving 
> this skeleton.

Ah right it does the writeConfig calls first... there's really some 
"interesting" design choices in KCoreConfigSkeleton...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This is supposed to add a top area to floating notifications:
  (just a sec)
  The result is not correct:
  (just a sec)
  Also, this is also applied to notifications in the notification list, which 
should instead remain unchanged:
  (just a sec)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> ervin wrote in spellchecking.cpp:88
> Are you sure this is necessary? I'd expect KCModule::load() to call load() on 
> m_skeleton

no load only do findItem for managed widget on the skeleton

> ervin wrote in spellcheckingskeleton.cpp:51
> I have a doubt, is it really necessary? I'd expect it to work without that 
> line.

Yes is necessary no code is run after that so nobody will take care of saving 
this skeleton.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> mart wrote in ExpandedRepresentation.qml:48
> not in all places you will have access to a dialog. the magic correct values 
> should come from the toparea margins itself done to go well with the 
> correspoding background svg.
> 
> in the end, i would like to have this in a control... i kinda hope a standard 
> toolBar control (will need some special casing when that style is running in 
> plasma or an app in plasma mobile

Okay, I tried to create a new component for this on 
https://phabricator.kde.org/D27695. I did not use toolBar because it was 
already using a different svg, but if you think that's the best idea, I can 
investigate that

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76530.
niccolove added a comment.


  Using new TopArea element from PlasmaComponents

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76529=76530

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76529.
niccolove added a comment.


  - Merge branch 'master' into topbar

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76374=76529

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  Ok - I think I got it. I will try to create a generic PlasmaCore.TopArea 
element and use it here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27669: WIP: [kstyle] Tools area

[George Vogiatzis]

gvgeo added a comment.


  Filelight works fine here. Kmag has some buttons with wrong color, but the 
toolbar row takes correct color.
  
  With breeze light when changing active window, color changing is not in sync 
with the titlebar. The timing is a little off, can get dizzy.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 76526.
gvgeo edited the summary of this revision.
gvgeo added a comment.


  rebase

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75906=76526

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ervin wrote in spellchecking.cpp:55
> What about calling toSet() on those? Not overly efficient but would compress 
> a bit the resulting code. Alternatively, couldn't we ensure those lists are 
> always kept sorted?

Not what I had in mind at all, now it's even less readable and less performant 
than before... I had something in mind like:
`const auto currentIgnoreSet = m_configWidget->ignoreList().toSet()`

I know they advertise the new range ctor, but it wouldn't buy us anything in 
that context. At least the `toSet()` call even though less performant buys us 
some readability.

> spellchecking.cpp:43
> +m_skeleton = new SpellCheckingSkeleton(this);
> +m_configWidget = new Sonnet::ConfigView(this);
> +
> m_configWidget->setNoBackendFoundVisible(m_skeleton->clients().isEmpty());

I notice it only now, but those two `new` would be better done in the ctor 
initialization list.

> spellchecking.cpp:88
> +// Load unmanaged widget
> +m_skeleton->load();
> +m_configWidget->setIgnoreList(m_skeleton->ignoreList());

Are you sure this is necessary? I'd expect KCModule::load() to call load() on 
m_skeleton

> spellchecking.cpp:118
> +
> m_configWidget->setPreferredLanguages(Sonnet::Settings::defaultPreferredLanguages());
> +m_configWidget->setLanguage(Sonnet::Settings::defaultDefaultLanguage());
>  }

I'd expect this to be the same block than the one in load() now. Since 
`KCModule::defaults()` will reset the skeleton to defaults, ignoreList, 
preferredLanguages and defaultLanguage will hold the default values.

> spellcheckingskeleton.cpp:27
> +
> +SpellCheckingSkeleton::SpellCheckingSkeleton(QObject *parent)
> +: KCoreConfigSkeleton(QStringLiteral(""), parent), m_store(new 
> Sonnet::Settings(this))

I'd tend to name that SpellCheckingSettings I think and m_settings instead of 
m_skeleton. I understand this is debatable because of the proximity with 
Sonnet::Settings but you hold it in a m_store member so it reduces chances of 
confusion I think.

> spellcheckingskeleton.cpp:51
> +m_store->setDefaultLanguage(m_defaultLanguage);
> +m_store->save();
> +return KCoreConfigSkeleton::usrSave();

I have a doubt, is it really necessary? I'd expect it to work without that line.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27689: Use correct connections for QQC2 controls

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:223
> +onActivated: {
>  cA.modeStaged = currentIndex;
>  calcNeedsSave();

Change this to `index` (which is the signal argument). There's no guarantee 
that `currentIndex` will be updated at this point (it wasn't a while ago)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27689

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin accepted this revision as: manueljlin.
manueljlin added a comment.


  Looks good, let's wait for ngraham so he accepts as vdg

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart