D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Makes sense.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27763

To: dkosovic, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[George Vogiatzis]

gvgeo added a comment.


  IMO this is the wrong way to do these changes.
  
  1. I don't see "itemSize" to be used anywhere else(didn't check) than 
"tasksRow" where we already add a smallSpacing. It would be best to increase 
the size in one place.
  2. For tablets already allow to use  bigger size icons. There is no need to 
artificially increase the size this way, if they need bigger size can increase 
the panel height.
  3. Can make use of plasmoid.configuration.iconSize, which is not exposed to 
the user. Otherwise can be removed.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Douglas Kosovic]

dkosovic added a comment.


  This patch is depends on D27763  being 
applied first.
  
  Old l2tp:
  F8144374: old-l2tp.png 
  
  Old l2tp IPsec Settings :
  F8144378: old-l2tp-ipsec.png 
  
  New l2tp (username/password) :
  F8144380: new-l2tp-1.png 
  
  New l2tp (certificate) :
  F8144382: new-l2tp-2.png 
  
  New l2tp IPsec Settings (PSK) :
  F8144385: new-l2tp-ipsec-1.png 
  
  New l2tp IPsec Settings (certificate) :
  F8144388: new-l2tp-ipsec-2.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27770: HiDPI improvement of left panel

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27770

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp

To: guoyunhe
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Well, if dedoimedo likes it this way, then it's probably the right thing to 
do ;)
  
  Since no one else complains about this change, I'll assume I just was lucky 
to have proper scaling on my machine without "magic number" spacings.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Niccolò Venerandi]

niccolove added a comment.


  E.g.: dedoimedo complained about this in both the .18 and .17 review.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  The main point of this patch is the spacing increase between tray icons that 
this hitbox size increase gives, which makes the tray look less cramped as a 
result.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

[Anthony Fieroni]

anthonyfieroni added a comment.


  Do it like in pager for wayland 
https://github.com/KDE/plasma-desktop/blob/master/applets/pager/plugin/pagermodel.cpp#L577

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27353

To: wstephenson, #plasma, ivan, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

[Will Stephenson]

wstephenson added a comment.


  In D27353#618452 , @ivan wrote:
  
  > This looks cool. The thing I'm missing (correct me if I'm wrong - I'm yet 
to test the patch) is for it to open the switcher when dragging the window over 
the switcher applet icon.
  
  
  That would be org.kde.plasma.showActivityManager, I assume? If so, yes, that 
would be good for completeness. I will also need to add the drop functionality 
to org.kde.plasma.activitybar then I think this is feature complete.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27353

To: wstephenson, #plasma, ivan, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  It's hard to measure this in pixels, but on the screenshot, it's a 10% 
increase in size.
  I use default font settings btw, with a global scaling factor of 1.25.
  
  I'm not strongly against this, but I don't really see a point in this either. 
In, like, 4 years of Plasma on my machines, I haven't missed a systray item a 
single time; probably because they're quite big already, compared to other 
elements like checkboxes and dropdown list arrows.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Okular has the same problem as Dolphin. Backtrace: F8143746: 
okular-20200301-093637.kcrash.txt <https://phabricator.kde.org/F8143746>

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  It's too hard to tell the difference between active and inactive icons: 
F8143741: Screenshot_20200301_093349.PNG 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Falkon doesn't blend: F8143736: Screenshot_20200301_093246.PNG 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  This line is way too bright on Dark themes{F8143729 
}

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Dolphin is crashing pretty regularly for me and it has this graphical glitch 
every time it crashes:
  F8143719: Screenshot_20200301_092241.PNG 
<https://phabricator.kde.org/F8143719>
  Backtrace:
  F8143722: dolphin-20200301-092242.kcrash.txt 
<https://phabricator.kde.org/F8143722>
  
  I'm on Qt 5.14.1 with all of my KDE software on git master.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

ngraham added a comment.


  I mean, it's only one more pixel. :) But yes, for some people with certain 
fonts maybe it will be too much. But then again, could a single pixel really be 
enough to make it too much?

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Douglas Kosovic]

dkosovic created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
dkosovic requested review of this revision.

REVISION SUMMARY
  - Update to NetworkManager-l2tp 1.8.0 features which include:
- NetworkManager-l2tp 1.8.0 user certificate support.
- Machine certificate support.
- Rename Gateway ID to Remote ID.
- Phase 1 & Phase 2 Lifetime TimeEdits.
- Use IP Compression CheckBox.
- Disable PFS CheckBox.
  - Synchronize nm-l2tp-service.h with NetworkManager-l2tp 1.8.0's 
nm-service-defines.h.
  - Base new user certificate UI on openvpn UI.
  - Delete l2tpauth.ui and replace with programmatically generated  
l2tpauthwidget.
  - Add user and machine private key / certificate password support to 
l2tpauthwidget.
  - Detect if libreswan or strongswan is being used and change UI based on 
which one is detected, e.g. disable "Disable PFS" check box with strongswan, 
Phase 1 & Phase 2 Lifetime show default strongswan and libreswan values when 
unchecked.
  - Disable IPSec settings button if libreswan or strongswan not detected.
  - Remove visibility of PPP Authentication group box if user certificate 
authentication is selected.
  - Support loading *SWAN Base64 encoded PSK, but for backwards compatibility 
use unencoded for saving settings.
  - For backwards compatibility with older NetworkManager-l2tp use 
`NM_L2TP_KEY_IPSEC_GATEWAY_ID` instead of `NM_L2TP_KEY_IPSEC_REMOTE_ID` for 
saving connection settings.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27764

AFFECTED FILES
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h

To: dkosovic, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec

[Douglas Kosovic]

dkosovic created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
dkosovic requested review of this revision.

REVISION SUMMARY
  Calling the IPsec dialog Advanced is confusing, so rename it to IPsec.
  Also in a subsequent patch there is also an Advanced group box in the IPsec 
dialog which would have added more confusion..
  
  The following git file name renames occur in the vpn/l2tp folder and are in 
the patch file.
  
git mv l2tpadvancedwidget.cpp l2tpipsecwidget.cpp
git mv l2tpadvancedwidget.h l2tpipsecwidget.h
git mv l2tpadvanced.ui l2tpipsec.ui

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27763

AFFECTED FILES
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h

To: dkosovic, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27466#620191 , @ngraham wrote:
  
  > It is (already) font-dependent, yes. A higher font size will result in 
larger spacing.
  >
  > IMO this is not super sensible, but, there is it. :p
  
  
  Ok, so I guess for the group of users who currently have the right spacing 
it's going to become excessive then :/

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart