D27903: [applet/digital-clock] Show time zones in expanded representation too

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2130c848e677: [applet/digital-clock] Show time zones in 
expanded representation too (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27903?vs=77531=77532

REVISION DETAIL
  https://phabricator.kde.org/D27903

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/digital-clock/package/contents/ui/Tooltip.qml
  applets/digital-clock/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27903: [applet/digital-clock] Show time zones in expanded representation too

[Nathaniel Graham]

ngraham updated this revision to Diff 77531.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use better name for bool property

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27903?vs=77123=77531

BRANCH
  digital-clock-layouts-and-timezones-in-popup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27903

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/digital-clock/package/contents/ui/Tooltip.qml
  applets/digital-clock/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27903: [applet/digital-clock] Show time zones in expanded representation too

[Nathaniel Graham]

ngraham added a comment.


  @cblack all of those things are in the existing code; I just moved the 
section from one place to another. I'd prefer to do those refactorings in 
another commit.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  digital-clock-layouts-and-timezones-in-popup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27903

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:4382
> I am sorry to say this is a serious show stopper. 
> One cannot reset/update the kiconloader palette at every repaint event for 
> every single toolbutton in toolbars especially when there are animations (not 
> only for the active inactive switch but also simply mouse-over).
> 
> If there is no way to make this more efficient, then as far as I am concerned 
> this is a no-go.
> 
> Maybe one could try to cache the icons ourselves ? (and trigger cache clear 
> when appropriate ?)

I'll dig in KIconLoader code a bit over the week-end to see what really happens 
when calling setCustomPalette and resetPalette, to get a sense of how resource 
consuming this is ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> cblack wrote in breezestyle.cpp:4382
> The issue is that the QStyle only has the global icon palette to mutate for 
> the tools area.  If the custom palette were to be left intact, that would 
> affect widgets it's not supposed to. There is no other code flow that won't 
> result in KIconLoader using a custom palette when it shouldn't.
> 
> The reason this is necessary in the first place is that KIconLoader doesn't 
> honor the widget palettes set elsewhere in the QStyle. This code is simply 
> working with what it's being given, and the issues that lead to this solution 
> are deep-rooted in Qt. You simply cannot do anything else without likely 
> breaking Qt's current APIs that are in control of this.

I am sorry to say this is a serious show stopper. 
One cannot reset/update the kiconloader palette at every repaint event for 
every single toolbutton in toolbars especially when there are animations (not 
only for the active inactive switch but also simply mouse-over).

If there is no way to make this more efficient, then as far as I am concerned 
this is a no-go.

Maybe one could try to cache the icons ourselves ? (and trigger cache clear 
when appropriate ?)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27903: [applet/digital-clock] Show time zones in expanded representation too

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> cblack wrote in main.qml:69
> Style change: use arg() instead of string concatenation so it's easier to see 
> what the end string will look like

I don't think that's fair. I wouldn't say arg makes it more readable.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  digital-clock-layouts-and-timezones-in-popup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27903

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:4382
> Not at every paint event. You should check if kiconloader already have a 
> customPalette, if it matches the one you want, and update (or reset) only 
> when necessary.

The issue is that the QStyle only has the global icon palette to mutate for the 
tools area.  If the custom palette were to be left intact, that would affect 
widgets it's not supposed to. There is no other code flow that won't result in 
KIconLoader using a custom palette when it shouldn't.

The reason this is necessary in the first place is that KIconLoader doesn't 
honor the widget palettes set elsewhere in the QStyle. This code is simply 
working with what it's being given, and the issues that lead to this solution 
are deep-rooted in Qt. You simply cannot do anything else without likely 
breaking Qt's current APIs that are in control of this.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77529.
cblack marked 14 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77376=77529

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27572: [kcm] Drop 'Enable bluetooth integration' setting

[Nicolas Fella]

nicolasfella added a comment.


  In D27572#626285 , @drosca wrote:
  
  > What happens if someone have it disabled and updates Plasma with this 
change?
  
  
  Nothing immediately happens, but the module can be reenabled via the KDED KCM

REPOSITORY
  R97 Bluedevil

BRANCH
  nointe

REVISION DETAIL
  https://phabricator.kde.org/D27572

To: nicolasfella, #plasma, drosca
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27574: Remove bold formatting of device name

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:c190802e1e0a: Remove bold formatting of device name 
(authored by nicolasfella).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27574?vs=76178=77527

REVISION DETAIL
  https://phabricator.kde.org/D27574

AFFECTED FILES
  src/kcmodule/devices/devicedetails.cpp

To: nicolasfella, #plasma, drosca, davidedmundson
Cc: ngraham, broulik, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27903: [applet/digital-clock] Show time zones in expanded representation too

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> CalendarView.qml:432
> +id: listItem
> +readonly property bool lastTimeZone: modelData === 
> plasmoid.configuration.lastSelectedTimezone
>  

This property's name doesn't imply it's a boolean

> main.qml:62
> +// get current UTC time
> +var msUTC = now.getTime() + (now.getTimezoneOffset() * 6);
> +// add the dataengine TZ offset to it

This variable is only used in the following statement, so I would move it into 
there. Would probably make it multiple lines to not hurt readability.

> main.qml:69
> +if (dateTime.getDay() !== 
> dataSource.data["Local"]["DateTime"].getDay()) {
> +formattedTime += " (" + Qt.formatDate(dateTime, 
> compactRepresentationItem.dateFormat) + ")";
> +}

Style change: use arg() instead of string concatenation so it's easier to see 
what the end string will look like

> main.qml:80
> +
> +return timezoneString;
> +}

Declaring a variable and then returning it immediately seems redundant.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  digital-clock-layouts-and-timezones-in-popup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27903

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27903: [applet/digital-clock] Show time zones in expanded representation too

[Carson Black]

cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  Visually, this looks good.
  
  The code also looks makes sense and looks good to me, albeit there's some 
minor style issues, mostly in how properties are grouped and ordered.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  digital-clock-layouts-and-timezones-in-popup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27903

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77514.
niccolove added a comment.


  - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into 
systray_toparea
  

  
  remove unrelated change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77512=77514

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Re: Proposal to centralize KCM bugs inside the systemsettings product

[David Edmundson]

On Thu, 12 Mar 2020, 17:58 David Edmundson, 
wrote:

>
>
> On Wed, 11 Mar 2020, 16:55 Nate Graham,  wrote:
>
>> Forwarding to plasma-devel at David Edmundson's request because I
>> originally sent this to the wrong mailing lists. Will send future such
>> emails to plasma-devel, sorry about that.
>>
>> FWIW the proposed changes were already made, so this is mostly for
>> visibility and record-keeping at this point.
>>
>> Nate
>>
>>
>>  Forwarded Message 
>> Subject: Proposal to centralize KCM bugs inside the systemsettings product
>> Date: Thu, 27 Feb 2020 07:42:23 -0700
>> From: Nate Graham 
>> Organization: kde.org
>> To: kscreen-bugs-n...@kde.org, jgrul...@redhat.com, now...@gmail.com,
>> plasma-b...@kde.org, albertv...@gmail.com, nicolas.fe...@gmx.de,
>> bhus...@gmail.com, dantt...@gmail.com
>>
>> Howdy folks!
>>
>> Right now most Bugzilla components for KCMs live inside the
>> systemsettings product, but there are a small number of exceptions:
>>
>> - bluedevil | kcm
>> - kdeconnect | kcm
>> - kscreen | kcm
>> - kscreenlocker | kcm
>> - plasma-pa | kcm
>> - plasma-nm | kcm
>> - print-manager | general
>>
>> I'd like to propose moving these into components of the systemsettings
>> product, which would make it easier for bug submitters to file bugs in
>> the right place, easier for bug triagers to keep track of System
>> Settings bugs, and easier for Plasma developers to notice significant
>> issues and regressions in KCMs, since we started a new policy of more
>> closely monitoring Plasma bugs, including those filed on the
>> systemsettings product.
>>
>
> It'll help filers and triagers, I'm worried about the impact for the
> maintainers that stick to their one specific domain, which is quite a few.
>
> On a more general comment I'd like us to be at a point where plasma is a
> very small very stable core with a rich ecosystem around it. That means
> approaching things without the monolithic mindset throughout.
>
> That said, what's done is done and we'll see what happens.
>
> With one exception: print manager.
>
> The version field will not match the product  version . This will be a
> problem.
>
> We also moved the applet bugs to plasmashell which is confusing since not
> even kdeplasma-addons are there.
>
>
>>

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77512.
niccolove added a comment.


  Removed head

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77510=77512

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:43
>  
> -RowLayout {
> -
> -PlasmaExtras.Heading {
> -id: heading
> -Layout.fillWidth: true
> -level: 1
> -Layout.leftMargin: {
> -//Menu mode
> -if (!activeApplet && hiddenItemsView.visible && 
> !LayoutMirroring.enabled) {
> -return units.smallSpacing;
> -
> -//applet open, sidebar
> -} else if (activeApplet && hiddenItemsView.visible && 
> !LayoutMirroring.enabled) {
> -return hiddenItemsView.width + units.largeSpacing;
> -
> -//applet open, no sidebar
> -} else {
> -return units.smallSpacing;
> +<<< HEAD
> +PlasmaExtras.PlasmoidHeading {

merge conflict remnant

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77510.
niccolove added a comment.


  - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into 
systray_toparea

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77416=77510

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27980: make opengl module support multiple dri devices

[Vlad Zahorodnii]

zzag added a comment.


  In D27980#626500 , @sitter wrote:
  
  > Had a quick look, using libdrm seems a bit excessive for what we want to do 
here.
  
  
  Well, it was worth a try.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D27998: Add workspace kcm option for dndToMove

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> meven wrote in main.qml:150
> You can nowadays write `!kcm.globalsSettings.isDndToMoveImmutable`
> That was added recently. D26368 

Thanks, but maybe this need another patch. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27998

To: trmdi, #vdg, #plasma, ngraham
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27998: Add workspace kcm option for dndToMove

[Tranter Madi]

trmdi updated this revision to Diff 77509.
trmdi added a comment.


  Move to bottom, add hint

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27998?vs=77478=77509

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: trmdi, #vdg, #plasma, ngraham
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27984: Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra added a comment.


  With that, I think this is now completely ready.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami, mart
Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra marked an inline comment as done.
ahiemstra added inline comments.

INLINE COMMENTS

> ahiemstra wrote in shadowedrectangle.h:15
> I've actually been pondering making it a grouped property, it would make it 
> more similar to border.
> 
> So then you'd have:
> 
>   ShadowedRectangle {
>   shadow {
>   size: 10
>   color: "red"
>   xOffset: 10
>   yOffset: 10
>   }
>   }

Done that now.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami, mart
Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 77506.
ahiemstra added a comment.


  - Convert shadow properties of ShadowedRectangle to a grouped property

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27984?vs=77504=77506

BRANCH
  shadowrect_distancefield

REVISION DETAIL
  https://phabricator.kde.org/D27984

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shadowedborderrectangle.frag
  src/scenegraph/shadowedborderrectangle_core.frag
  src/scenegraph/shadowedborderrectanglematerial.cpp
  src/scenegraph/shadowedborderrectanglematerial.h
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami, mart
Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 77504.
ahiemstra added a comment.


  - Documentation
  - Add support for rendering a border

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27984?vs=77446=77504

BRANCH
  shadowrect_distancefield

REVISION DETAIL
  https://phabricator.kde.org/D27984

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shadowedborderrectangle.frag
  src/scenegraph/shadowedborderrectangle_core.frag
  src/scenegraph/shadowedborderrectanglematerial.cpp
  src/scenegraph/shadowedborderrectanglematerial.h
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglematerial.h
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  tests/ShadowedRectangleTest.qml

To: ahiemstra, #kirigami, mart
Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in kstart.cpp:184
> Wouldn't it be easier here to just do `windowtitle.compare(info.name(), 
> Qt::CaseInsensitive)` and skip the regex?

I thought about that, but looking at the code I found:

  void KStart::sendRule() {
  KXMessages msg;
  QString message;
  if( !windowtitle.isEmpty() )
  message += QStringLiteral("title=") + windowtitle + 
QStringLiteral("\ntitlematch=3\n"); // 3 = regexp match

which made me leave the regex in...

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28000

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kstart.cpp:184
> +const QRegularExpression 
> re(QRegularExpression::anchoredPattern(windowtitle.toLower()));
> +if (!re.match(title).hasMatch()) {
> +return; // no match

Wouldn't it be easier here to just do `windowtitle.compare(info.name(), 
Qt::CaseInsensitive)` and skip the regex?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28000

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Harald Sitter]

sitter added a comment.


  In D27980#625840 , @zzag wrote:
  
  > I'm not sure whether this is useful, but libdrm has an API to enumerate 
devices.
  
  
  Had a quick look, using libdrm seems a bit excessive for what we want to do 
here. The current /sys digging also doesn't exactly fill me with joy though :(

INLINE COMMENTS

> sitter wrote in opengl.cpp:281
> Dirs actually, e.g. /proc/dri/0/name
> I honestly do not know what they are so I figured best to just list 
> everything. They could be symlinks for all I know. /proc/dri/ isn't a thing 
> on any of my VMs :|

As it turns out the /proc/dri stuff was supposedly removed here 
https://github.com/torvalds/linux/commit/cb6458f97b53d7f73043206c18014b3ca63ac345
 making this code entirely irrelevant since kernel 3.12.
Any objections to removing it altogether?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> mart wrote in shadowedrectangle.h:15
> shadowSize to correspond with shadowColor

I've actually been pondering making it a grouped property, it would make it 
more similar to border.

So then you'd have:

  ShadowedRectangle {
  shadow {
  size: 10
  color: "red"
  xOffset: 10
  yOffset: 10
  }
  }

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami, mart
Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D27985: Include s_kcrashErrorMessage in our traces

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM for when the kcrash diff is ready.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27985

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27984: [WIP] Add a ShadowedRectangle item

[Arjen Hiemstra]

ahiemstra added a comment.


  I've been adding some documentation, in addition to border properties. With 
that I'm fairly sure this is ready.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami, mart
Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D27984: [WIP] Add a ShadowedRectangle item

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  to me is good, would just change that one thing api wise.
  do you think there are other blockers from a technical pov or good to go?

INLINE COMMENTS

> shadowedrectangle.h:15
> +Q_OBJECT
> +Q_PROPERTY(qreal size READ size WRITE setSize NOTIFY sizeChanged)
> +Q_PROPERTY(qreal radius READ radius WRITE setRadius NOTIFY radiusChanged)

shadowSize to correspond with shadowColor

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27984

To: ahiemstra, #kirigami, mart
Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D28003: [WIP]Expose global switch to the user

[George Vogiatzis]

gvgeo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  This is a rough patch and will be abandoned.
  See D28002  instead.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feedback (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28003

AFFECTED FILES
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/package/contents/ui/main.qml

To: gvgeo
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77481.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Fix commit message

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28000?vs=77480=77481

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28000

AFFECTED FILES
  kcmshell/main.cpp
  kstart/kstart.cpp

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol, davidedmundson.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28000

AFFECTED FILES
  kcmshell/main.cpp
  kstart/kstart.cpp

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/40/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 07:55:12 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 131 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/131/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 07:55:09 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27998: Add workspace kcm option for dndToMove

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> main.qml:150
> +text: i18n("Always ask what to do")
> +enabled: !kcm.globalsSettings.isImmutable("dndToMove")
> +checked: !kcm.globalsSettings.dndToMove

You can nowadays write `!kcm.globalsSettings.isDndToMoveImmutable`
That was added recently. D26368 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27998

To: trmdi, #vdg, #plasma, ngraham
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 285 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/285/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Mar 2020 07:55:09 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report15%
(12/79)16%
(59/364)16%
(59/364)12%
(3797/31488)9%
(1743/19056)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.emojier0%
(0/1)0%
(0/1)0%
(0/202)0%
(0/111)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1098)0%
(0/620)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/356)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/320)0%
(0/244)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2350)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%
 

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 59 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/59/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Mar 2020 07:55:07 +
 Build duration:
5 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4082)0%
(0/2646)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1444)0%
(0/1063)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/823)0%
(0/478)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/237)0%
(0/122)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1026)0%
(0/750)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/198)0%
(0/93)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/72)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/80)0%
(0/22)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/118)0%
(0/46)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 64 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/64/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Mar 2020 07:55:11 +
 Build duration:
4 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2587)14%
(212/1505)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/165)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1249)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/259)0%
(0/138)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Vlad Zahorodnii]

zzag added a reviewer: VDG.
zzag added a comment.


  In D27972#626302 , @broulik wrote:
  
  > I think this needs a VDG/Usability discussion.
  
  
  Yes!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham, #vdg
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Kai Uwe Broulik]

broulik added a comment.


  I think this needs a VDG/Usability discussion.
  Having the icon show when color correction is active (the status quo) imho 
makes sense.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> pdabrowski wrote in main.qml:36-38
> > We want to keep the applet visible even if Night Color is inhibited so user 
> > can quickly uninhibit it.
> 
> You are right. I have modified the patch to show the icon when inhibited in 
> timed modes.

Why only in timed modes?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27572: [kcm] Drop 'Enable bluetooth integration' setting

[David Rosca]

drosca accepted this revision.
drosca added a comment.
This revision is now accepted and ready to land.


  Applet doesn't need the KDED module, it only talks with BlueZ directly. This 
is for stuff like bluetooth:// kio protocol and receiving files.
  
  What happens if someone have it disabled and updates Plasma with this change?

REPOSITORY
  R97 Bluedevil

BRANCH
  nointe

REVISION DETAIL
  https://phabricator.kde.org/D27572

To: nicolasfella, #plasma, drosca
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart